GNU bug report logs - #74406
[PATCH 0/1] antlr4 package does not refer to java executable by full path

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: guix-patches; Reported by: Rutherther <rutherther@HIDDEN>; Keywords: patch; merged with #74405; dated Sun, 17 Nov 2024 19:16:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 74406 <at> debbugs.gnu.org:


Received: (at 74406) by debbugs.gnu.org; 2 Jan 2025 13:51:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 02 08:51:51 2025
Received: from localhost ([127.0.0.1]:43192 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tTLc6-0001BG-8p
	for submit <at> debbugs.gnu.org; Thu, 02 Jan 2025 08:51:50 -0500
Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]:47259)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1tTLc2-0001At-I8; Thu, 02 Jan 2025 08:51:47 -0500
Received: by mail-pl1-x634.google.com with SMTP id
 d9443c01a7336-21680814d42so133374385ad.2; 
 Thu, 02 Jan 2025 05:51:46 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1735825900; x=1736430700; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=3Mos5f/ruxJ81Nnl75cvsMajVhvRdBSE2CanB+udvu8=;
 b=EOmdTvXGhmmZNu1bn+o10sbXcnvmJqxAJA681qtv38EK9roOjW0tGJ31G/ZE9ZKnxC
 ptG2CHB3LbhDsMYLyXPVqjrwndKxCqWWKGQhGuBzOn0qsXSs+TJPCaJQaH5TPqcivobM
 Dyr662UJcG3XgvYh22Ub8s1MZ+aCzZrd4KC7binOCflCQEGxcVDUbEyVjoFwbcTS/mmt
 bWjmOOvLl+hj8cm1RxCpEr033GxY8qI40MzwxlQOpApVfDKx8w30SlANUC7Ifq6Asz8p
 xuGJS2V2TWPci72Je33xzYKDZeXcmwvDXiTHUXHwZ1heIUcZyNGUE/HS7A9EpgVqB5/Z
 5I6A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1735825900; x=1736430700;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=3Mos5f/ruxJ81Nnl75cvsMajVhvRdBSE2CanB+udvu8=;
 b=e9dk+kajg6vvL7WjDP1JFHAcSpuZnHSiJ4seED5IiAIUWQb0ZgbrCorGysHISEKpHx
 PHV+acF5tevrTUOcAfAf9OUu1A3BK4zVTqAoTs6q7oTqzjq4+yO1x8onauWnUaaJ4cPS
 EiMpD5ke++0eNxrm5iJW4D6JRPNhiSn2f4L7Mum7tPSK2ZJfk3JyxB41GsE/wnrNqo+3
 jBFwJyj98bJo9/YyZbjpVrE4bwnr/2aZP4EcyEA0Q2FH/VVgSPAhqRMgg6ak6WL/dcYH
 nFRaj+lyddgIepjmoUOZ4zEZvlp7KucRxAEnuO/ixqosJKONZyRIyzBQsvB1H0No62zU
 HR0g==
X-Forwarded-Encrypted: i=1;
 AJvYcCWPVFoz3ZeuKRa1XQiQezLHguUWtDCP9ibDQZBK++Xs1W8Vih8kRdqqcGd6fMG72N4szpLcvg==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YwGt2+Jt6Ab329ShMtis8sDDe1GY5NC2rZF1KGx3NPDxE9DDE8g
 WVJfxQSDh7TYcBnaSMSF+wMFrj62pZ9w+VVLnT54shtwqoCpCePUNageT0QC
X-Gm-Gg: ASbGnctDlY3pwp1z4xtuNFVmobNTE608Xr8Jidkt5QPNj0A0Gr0fRYaLzesFwpl0QEP
 Oa8Cg0t76t1xB+VnvK2RbRz6rDCEiFxfGD4JkDdWUxloAWjJXq2dcyrSGhkgCgTqEcG1yEmOIwk
 vxNP2ptaQLZUBOjUY/TIkn1fncDPstMv+YuL60YbxBLbLbDLObU4xTZjyPTo7pmRzC3fBcFJvsN
 6svxtehHx0nLgxFObnDLV7eUYwF7Ej4mCJYCz05SZIbRIOPI072lQ==
X-Google-Smtp-Source: AGHT+IG1cXHduT7z+4SJDxLUJZbshYFpD01KnUs1j03nWidMESUdHswMweyChT3tqBzBNcHqPQvYiA==
X-Received: by 2002:a17:902:c406:b0:215:854c:a71a with SMTP id
 d9443c01a7336-219e6ebb68dmr545512085ad.34.1735825900393; 
 Thu, 02 Jan 2025 05:51:40 -0800 (PST)
Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89])
 by smtp.gmail.com with ESMTPSA id
 d9443c01a7336-219dca013f4sm227754135ad.234.2025.01.02.05.51.38
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 02 Jan 2025 05:51:39 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: Rutherther <rutherther@HIDDEN>
Subject: Re: [bug#74406] [PATCH 1/1] gnu: antlr4: Pass full path to java in
 bin executable
In-Reply-To: <27ea0b2b5326c827fd03399b4009c1bb62d81600.1731870758.git.rutherther@HIDDEN>
 (rutherther@HIDDEN's message of "Sun, 17 Nov 2024 20:43:58
 +0100")
References: <cover.1731870758.git.rutherther@HIDDEN>
 <27ea0b2b5326c827fd03399b4009c1bb62d81600.1731870758.git.rutherther@HIDDEN>
Date: Thu, 02 Jan 2025 22:51:28 +0900
Message-ID: <87wmfd5nof.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 74406
Cc: Julien Lepiller <julien@HIDDEN>, 74405 <at> debbugs.gnu.org,
 74406 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Rutherther,

Apologies for the delay, this had been tagged as SPAM by big G.

Rutherther <rutherther@HIDDEN> writes:

> The executable outputted by antlr4 package does not
> refer to full path of java, but to standalone "java".
> That means the package expects java to be in PATH.
> Since it's an application, requiring java to run,
> it should rather refer to full path of java executable
> it was built with/for.
>
> * gnu/packages/java.scm: (antrl4)[arguments]: Change "java" in bin/antlr4 for full path
>
> Change-Id: I311b9ec54a90fc7251eb8fcb62b232e843853e64
> ---
>  gnu/packages/java.scm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index df57385ea7..8607b62bea 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -8866,13 +8866,14 @@ (define-public antlr4
>           (add-after 'install 'bin-install
>             (lambda* (#:key inputs outputs #:allow-other-keys)
>               (let ((jar (string-append (assoc-ref outputs "out") "/share/java"))
> -                   (bin (string-append (assoc-ref outputs "out") "/bin")))
> +                   (bin (string-append (assoc-ref outputs "out") "/bin"))
> +                   (java (search-input-file inputs "bin/java")))
>                 (mkdir-p bin)
>                 (with-output-to-file (string-append bin "/antlr4")
>                   (lambda _
>                     (display
>                       (string-append "#!" (which "sh") "\n"
> -                                    "java -cp " jar "/antlr4.jar:"
> +                                    java " -cp " jar "/antlr4.jar:"

Hm.  I'm not sure what is the state of the art here for our Java
packages; it makes sense that it should work out of the box, but perhaps
there's a reason to want to have it run with any Java available on PATH?

I'll defer to Julien, which I believe has done more work with Java in
Guix.

-- 
Thanks,
Maxim
Information forwarded to guix-patches@HIDDEN:
bug#74406; Package guix-patches. Full text available.

Message received at 74406 <at> debbugs.gnu.org:


Received: (at 74406) by debbugs.gnu.org; 17 Nov 2024 19:44:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 17 14:44:13 2024
Received: from localhost ([127.0.0.1]:58734 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tClBt-0002x0-68
	for submit <at> debbugs.gnu.org; Sun, 17 Nov 2024 14:44:13 -0500
Received: from ditigal.xyz ([78.46.201.50]:43070 helo=mail.ditigal.xyz)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rutherther@HIDDEN>) id 1tClBq-0002wh-N7
 for 74406 <at> debbugs.gnu.org; Sun, 17 Nov 2024 14:44:12 -0500
Received: by cerebrum (OpenSMTPD) with ESMTPSA id be4d8196
 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); 
 Sun, 17 Nov 2024 19:44:02 +0000 (UTC)
From: Rutherther <rutherther@HIDDEN>
To: 74406 <at> debbugs.gnu.org
Subject: [PATCH 1/1] gnu: antlr4: Pass full path to java in bin executable
Date: Sun, 17 Nov 2024 20:43:58 +0100
Message-ID: <27ea0b2b5326c827fd03399b4009c1bb62d81600.1731870758.git.rutherther@HIDDEN>
X-Mailer: git-send-email 2.46.0
In-Reply-To: <cover.1731870758.git.rutherther@HIDDEN>
References: <cover.1731870758.git.rutherther@HIDDEN>
MIME-Version: 1.0
X-Debbugs-Cc: Julien Lepiller <julien@HIDDEN>
Content-Transfer-Encoding: 8bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ditigal.xyz;
 i=@ditigal.xyz; q=dns/txt; s=20240917; t=1731872642; h=from : to : cc
 : subject : date : message-id : in-reply-to : references :
 mime-version : content-transfer-encoding : from;
 bh=s2SwSMVNRbG1OWVW885rvr4k5PLi705fgklH17/YbpA=;
 b=b07yXyiiLLdYdzpMmEhsF3hnvLH4FB7hBXDTUlIyh5PxHXyBxw1B1AOcgNUIOva4EeCss
 rFQWiGa50Sv9K/rYuwFYv99PFdKeHU2BGQLBLHDF9LqVcjwhg81H0TfKiTKPEhBp1NjpQLM
 CTSbkd1v7RukPvBm2hpfix9eCi3a7h4=
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 74406
Cc: Rutherther <rutherther@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

The executable outputted by antlr4 package does not
refer to full path of java, but to standalone "java".
That means the package expects java to be in PATH.
Since it's an application, requiring java to run,
it should rather refer to full path of java executable
it was built with/for.

* gnu/packages/java.scm: (antrl4)[arguments]: Change "java" in bin/antlr4 for full path

Change-Id: I311b9ec54a90fc7251eb8fcb62b232e843853e64
---
 gnu/packages/java.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index df57385ea7..8607b62bea 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -8866,13 +8866,14 @@ (define-public antlr4
          (add-after 'install 'bin-install
            (lambda* (#:key inputs outputs #:allow-other-keys)
              (let ((jar (string-append (assoc-ref outputs "out") "/share/java"))
-                   (bin (string-append (assoc-ref outputs "out") "/bin")))
+                   (bin (string-append (assoc-ref outputs "out") "/bin"))
+                   (java (search-input-file inputs "bin/java")))
                (mkdir-p bin)
                (with-output-to-file (string-append bin "/antlr4")
                  (lambda _
                    (display
                      (string-append "#!" (which "sh") "\n"
-                                    "java -cp " jar "/antlr4.jar:"
+                                    java " -cp " jar "/antlr4.jar:"
                                     (string-join
                                       (apply
                                         append
-- 
2.46.0
Information forwarded to julien@HIDDEN, guix-patches@HIDDEN:
bug#74406; Package guix-patches. Full text available.
Merged 74405 74406. Request was from Rutherther <rutherther@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 17 Nov 2024 19:15:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 17 14:15:49 2024
Received: from localhost ([127.0.0.1]:58640 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tCkkP-0001cZ-7T
	for submit <at> debbugs.gnu.org; Sun, 17 Nov 2024 14:15:49 -0500
Received: from lists.gnu.org ([209.51.188.17]:39514)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rutherther@HIDDEN>) id 1tCkkN-0001cR-3k
 for submit <at> debbugs.gnu.org; Sun, 17 Nov 2024 14:15:47 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <rutherther@HIDDEN>)
 id 1tCkkM-00021a-K2
 for guix-patches@HIDDEN; Sun, 17 Nov 2024 14:15:46 -0500
Received: from ditigal.xyz ([2a01:4f8:1c1b:6a1c::] helo=mail.ditigal.xyz)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256)
 (Exim 4.90_1) (envelope-from <rutherther@HIDDEN>)
 id 1tCkkK-00057t-0y
 for guix-patches@HIDDEN; Sun, 17 Nov 2024 14:15:45 -0500
Received: by cerebrum (OpenSMTPD) with ESMTPSA id 3c466c89
 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); 
 Sun, 17 Nov 2024 19:15:42 +0000 (UTC)
From: Rutherther <rutherther@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH 0/1] antlr4 package does not refer to java executable by full
 path
Date: Sun, 17 Nov 2024 20:15:41 +0100
Message-ID: <cover.1731870758.git.rutherther@HIDDEN>
X-Mailer: git-send-email 2.46.0
MIME-Version: 1.0
X-Debbugs-Cc: Julien Lepiller <julien@HIDDEN>
Content-Transfer-Encoding: 8bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ditigal.xyz;
 i=@ditigal.xyz; q=dns/txt; s=20240917; t=1731870942; h=from : to : cc
 : subject : date : message-id : mime-version :
 content-transfer-encoding : from;
 bh=zC7T22bBxwXKDpy5DpZiLruRwxc0xW7j7p5CAr4JuuY=;
 b=da0UR0rA3rNAkyWRkjfWECbU4i20Zrja5dFhhWZquimgf8MLTo04uQbXj1cWpDFZIYeLG
 MEFOmxRLq+YVVsgavVfkBcAhpKMtY6y/7/VMM72uUL734XmFn3AlkJVuRde/1J1KXzQ0l8i
 mCLRuZHRJQkq/qvofqXGHSLT0+y4UH8=
Received-SPF: pass client-ip=2a01:4f8:1c1b:6a1c::;
 envelope-from=rutherther@HIDDEN; helo=mail.ditigal.xyz
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
Cc: Rutherther <rutherther@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

Hello,

this seems to me like a bug - the package antlr4 refers
to "java" in bin/antlr4 that is produced. I think it should
refer to #$icedtea/bin/java. It seems to me quite probable
this was a mistake, since there was java written multiple
times in phases, where it's available in PATH automatically.

Rutherther (1):
  gnu: antlr4: Pass full path to java in bin executable

 gnu/packages/java.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)


base-commit: d108a7aac2c51f21c55cb8ea8801629a97f5242a
--
2.46.0
Acknowledgement sent to Rutherther <rutherther@HIDDEN>:
New bug report received and forwarded. Copy sent to julien@HIDDEN, guix-patches@HIDDEN. Full text available.
Report forwarded to julien@HIDDEN, guix-patches@HIDDEN:
bug#74406; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.