GNU bug report logs - #74505
[PATCH] Update freeciv to version 3.1.3

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74505 in the body.
You can then email your comments to 74505 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: glab <glab <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] Update freeciv to version 3.1.3
Date: Sat, 23 Nov 2024 22:20:17 +0000

[0001-Update-freeciv-to-version-3.1.3.patch (text/x-diff, attachment)]

Message #8 received at 74505 <at> debbugs.gnu.org (full text, mbox):

From: Rodion Goritskov <rodion.goritskov <at> gmail.com>
To: 74505 <at> debbugs.gnu.org
Cc: glab <glab <at> disroot.org>
Subject: Re: [PATCH] Update freeciv to version 3.1.3
Date: Mon, 25 Nov 2024 00:37:11 +0400

Hi!

I tried building and running an updated version.
It builds fine, but game has no sound.

>     (inputs
> -    (list curl cyrus-sasl gtk+ sdl-mixer zlib))
> +    (list curl cyrus-sasl gtk+ sdl-mixer zlib sqlite))

As far as I understand - sdl-mixer version 1 support had been dropped in
version 3.1.0 [1]

I tried building with sdl2-mixer instead of sdl-mixer - that fixed the
sound issue.

Also, I think that dependency list should be sorted alphabetically (it
looks like it was previously).

[1] - https://web.archive.org/web/https://gna.org/patch/?6246

Message #11 received at 74505 <at> debbugs.gnu.org (full text, mbox):

From: glab <glab <at> disroot.org>
To: Rodion Goritskov <rodion.goritskov <at> gmail.com>
Cc: 74505 <at> debbugs.gnu.org
Subject: Re: [PATCH] Update freeciv to version 3.1.3
Date: Sun, 08 Dec 2024 20:52:30 +0000

[Message part 1 (text/plain, inline)]

On 2024-11-24 20:37, Rodion Goritskov wrote:
> Hi!
> 
> I tried building and running an updated version.
> It builds fine, but game has no sound.
> 
>>     (inputs
>> -    (list curl cyrus-sasl gtk+ sdl-mixer zlib))
>> +    (list curl cyrus-sasl gtk+ sdl-mixer zlib sqlite))
> 
> As far as I understand - sdl-mixer version 1 support had been dropped 
> in
> version 3.1.0 [1]
> 
> I tried building with sdl2-mixer instead of sdl-mixer - that fixed the
> sound issue.
> 
> Also, I think that dependency list should be sorted alphabetically (it
> looks like it was previously).
> 
> [1] - https://web.archive.org/web/https://gna.org/patch/?6246

Hello. Thank you, Rodion, for helping me with this patch.

I think I have improved it, based on your feedback.

Best regards,
-- 
Gustavo

[0001-Update-freeciv-to-version-3.1.3.patch (text/x-diff, attachment)]

Message #14 received at 74505 <at> debbugs.gnu.org (full text, mbox):

From: Rodion Goritskov <rodion.goritskov <at> gmail.com>
To: 74505 <at> debbugs.gnu.org
Subject: [PATCH] Update freeciv to version 3.1.3
Date: Sun, 22 Dec 2024 22:45:08 +0100

Hi Gustavo,

Thank you for the updated patch - it works great now (not a big fan of
freeciv, but at least game starts and sound works fine after selecting
sdl in sound options).

I don't have any comments about the changes in patch.
But I noticed some things to improve in commit messages and patch naming.

Looks like now it is not fully up to the Guix commit style practices.

Lets take a look on some package update commit message example [1]

Commit message first line should be in format:
> gnu: <package name>: Update to <version>

And then in following lines specific changes should be described:

> * gnu/packages/<file>.scm (<package>): Update to <version>
> [inputs]: <change in inputs description>

For broad and detailed commit logs standards you could check GNU Coding
Standards [2]. But examples are easier (:

Also, please send an updated version of the patch with the next
revision, so it would be easier for maintainers to distinct and apply
it.

To do this you could specify the revision 2 in git send-email. You could
find some instructions in documentation [3] at the end of the Single
Patches section.

Also, you could take a look on the mumi CLI tool, it makes working with
patches much easier [4].

Happy hacking!

[1] -
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=af28be202cb2b7fd0fc2e277467304f81c78ab74
[2] -
https://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-Logs
[3] -
https://guix.gnu.org/manual/devel/en/html_node/Sending-a-Patch-Series.html
[4] - https://guix.gnu.org/manual/devel/en/html_node/Debbugs-User-Interfaces.html#Command_002dLine-Interface

Message #21 received at 74505-done <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: glab <glab <at> disroot.org>
Cc: 74505-done <at> debbugs.gnu.org, Rodion Goritskov <rodion.goritskov <at> gmail.com>
Subject: Re: [bug#74505] [PATCH] Update freeciv to version 3.1.3
Date: Sun, 16 Mar 2025 10:56:38 +0800

glab <glab <at> disroot.org> writes:

> Subject: [PATCH] Update freeciv to version 3.1.3

Hello glab, thanks for the patch, it was already updated, so this patch
no longer apply.  Close.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.