Received: (at 74554-done) by debbugs.gnu.org; 12 Feb 2025 04:42:27 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 11 23:42:26 2025 Received: from localhost ([127.0.0.1]:60236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ti4Zu-0005zE-IS for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 23:42:26 -0500 Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]:58759) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <tmarjeski@HIDDEN>) id 1ti4Zr-0005yy-Lr for 74554-done <at> debbugs.gnu.org; Tue, 11 Feb 2025 23:42:24 -0500 Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-5439e331cceso7175839e87.1 for <74554-done <at> debbugs.gnu.org>; Tue, 11 Feb 2025 20:42:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739335337; x=1739940137; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=XpMI4jdO6ALv9jNZrEkHg5+VtrSnjQP7GDwjS1BEvAY=; b=M9E1sokHbX6mTd+rt1tZIu+DpLw355KZlWqa92ELsMrHP4XvpHUSPK8IJ3aJxKm81Q 9VHcmNqqci6lzGaly7cOElBpHV1LO5UnMS7PFfdCQ4M14rvhdenJvDYdHHMsLVmQjLuP Qw0Ia0UIAQE+kXhiSnFsp4mnXknTXlKCMLBhNqXweGYXooTgfMYVnKgVizUP99mH5Olc ynj/zebORUWAXp7553xZFA8bPSc3BGSE+7yB2ipdyreWVnBxDSD6gZfJbmQ0tK7cQoyn aCT4A2MrSqAo3l9VSATxtwf1uzdXhaFL/cvc4iMKJQ7skWCmwPQdhRPPIVVVTezt32e7 Yxww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739335337; x=1739940137; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XpMI4jdO6ALv9jNZrEkHg5+VtrSnjQP7GDwjS1BEvAY=; b=KF0CzUVLqWT394ic5BpzxeERuAO4hROGzh7TDGwLl0mqltO+O0u8MngD1zy1a34a05 kbaI8swhEe0YjczVPAwFGbXIlldcXE/wvAVM8UqfwTudVoo4PishrR6gYpe5/nnoGY5J r/DHhJKC16VW2g8GioD1S1DEEmtgsv+4fEDN6euu5kFLJhH1MND15V5O5UVvKByuimk5 qSpxxB6noZPsmITlq9WJpNQv80MojW9LwpVGWSxWc4aWHeR5Jfcw9C7kNSpmlcjSD2yK W9v4OQwBil1dosqTnX7nqVN9nr1Mv6ttKcr4RhuIh/JpCNM/LdDtxuoypGx+smwj9RTr QmoQ== X-Forwarded-Encrypted: i=1; AJvYcCVXHSu0SMSciAR57ZlBWoFIUMyaMa6ocoLMy92dHyAhdmQ4JakOEun4Uk3VekKy1kjQGCw6bW3ZarIu <at> debbugs.gnu.org X-Gm-Message-State: AOJu0YwSQUA6k9LJuKmeLTK0iuXKRRKuPC2teOoKsHV7OngMsnZ9DiVz K1MV5qTnWraiIBVl4at7BS0Oi8V9AU6pXtKSVvHBWwYyqc1ufD4z X-Gm-Gg: ASbGnct5rqDVKt0kG08yVFO5drrMBT3QIaFVJSXX6ZxBoVhkPVwBuwdvLtzbTcnVZDa nIcRG9ENAWgVZwpx6GY3TpE8FyOYwMq/IdB60tqq8DpxSqzB7AsZ7YWMQ3+qY/BpvZ+7lCZZAcQ 56+wxCNlAG1NiPKFElLH9QAobcHs2vjDLpcAkqmxv6z/yjLbMcA9NePEnGq0k9WPwsX0SaK0Ks+ crOYkc6TbbKz/0T27uEzT5NfKWCC2me2ImR5tj6Yy7F1QTUPO8e0DPhDa6PAN89h4fJfzd1mN7V 5JDpFFQjXaiGJzz7tXLKvaytOt3i+8OFmOevocIEQQ== X-Google-Smtp-Source: AGHT+IHj2dmfdXb4JhmO3pX/MKPYB3DJ+wLq3bUY3gywV036AhwwXW3ub3Oo7LWpPSPpeXoVnxMB3w== X-Received: by 2002:a05:6512:10c8:b0:545:10cf:3462 with SMTP id 2adb3069b0e04-5451818c59emr369839e87.41.1739335336608; Tue, 11 Feb 2025 20:42:16 -0800 (PST) Received: from trevarch (109-252-32-232.nat.spd-mgts.ru. [109.252.32.232]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5450e3e4e72sm705518e87.199.2025.02.11.20.42.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2025 20:42:15 -0800 (PST) From: Trevor Arjeski <tmarjeski@HIDDEN> To: Stefan Kangas <stefankangas@HIDDEN> Subject: Re: bug#74554: 31.0.50; [PATCH] gnus: fix logo color customization In-Reply-To: <CADwFkmmUj4QisD1xnMouM2jtphaqg=E+tXpw5mL0v2jsP9Vxhw@HIDDEN> References: <87frndjf7e.fsf@HIDDEN> <CADwFkmkKOsOqR9O7OwJRj_dpBDo7H_RsiatUtYBaccN7SLpi3g@HIDDEN> <87lduc5860.fsf@HIDDEN> <CADwFkmmUj4QisD1xnMouM2jtphaqg=E+tXpw5mL0v2jsP9Vxhw@HIDDEN> Date: Wed, 12 Feb 2025 07:42:13 +0300 Message-ID: <87v7tfbwpm.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74554-done Cc: Andrew Cohen <acohen@HIDDEN>, Eric Abrahamsen <eric@HIDDEN>, 74554-done <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Stefan Kangas <stefankangas@HIDDEN> writes: > Version: 31.1 > > Andrew Cohen <acohen@HIDDEN> writes: > >>>>>>> "SK" == Stefan Kangas <stefankangas@HIDDEN> writes: >> >> SK> Trevor Arjeski <tmarjeski@HIDDEN> writes: >> >> 1. Add the following code to an init.el: >> >> >> >> (use-package gnus :ensure nil :custom (gnus-logo-color-style >> >> 'neutral)) >> >> >> >> 2. Start emacs, M-x gnus, and notice that the logo does not >> >> change to the neutral gray colors. >> >> >> >> This does not seem to happen when using the Customization >> >> interface which puts `custom-set-variables' in your init.el: >> >> >> >> (custom-set-variables '(gnus-logo-color-style 'neutral)) >> >> >> >> >> >> I'm not sure if this is related to use-package's :custom keyword, >> >> but I have not come across this issue while using any other >> >> built-in emacs packages. >> >> >> >> Please see the attached patch file for a possible fix and minor >> >> improvement. >> >> >> >> Thanks, Trevor >> >> SK> Andrew, Eric, could you please help review this patch? >> >> Looks OK to me. >> -- >> Andrew Cohen > > Thanks, installed on master with a ChangeLog entry as per CONTRIBUTE, > and a touched up commit message. See commit 77d0078a6c5. > > Trevor, it seems like we have reached the limit of the amount of code we > can accept from you without a copyright assignment. If you plan to > contribute more patches in the future, it would be a good idea to get > the copyright assignment process started now. Please let us know if you > want to do that, and we can help you get started. Hi Stefan, I actually applied for copyright assignment already and I have signed and submitted a few weeks ago. Just waiting the FSF's signature and response. Thanks, Trevor
bug-gnu-emacs@HIDDEN, bugs@HIDDEN:bug#74554; Package emacs,gnus.
Full text available.Received: (at 74554-done) by debbugs.gnu.org; 12 Feb 2025 02:59:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 11 21:59:47 2025 Received: from localhost ([127.0.0.1]:59876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ti2yY-0005O5-LV for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 21:59:47 -0500 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]:58572) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1ti2yU-0005Ni-SQ for 74554-done <at> debbugs.gnu.org; Tue, 11 Feb 2025 21:59:44 -0500 Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-ab7e1286126so257517366b.0 for <74554-done <at> debbugs.gnu.org>; Tue, 11 Feb 2025 18:59:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739329176; x=1739933976; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=EjIWgnK7uvFSzJic7hZFgCOzrxMyQaosaEh2vcN4GXI=; b=lmTWt9fZ57CS+iMric1RmA0DrMCn7wd0x9KiAm+LDrTgSPthdbP0vSkpdqR5B/2xaB fIHAKYhMOG8nDn7NveUxNRl05b4Cn74mSGKjCr/uOmqpV6s2WubL05oCkF3aPncHWPoq mje2HDdoz+hH1+efBxbK0Ys17H7iVan42bkE1xd5C0udc7D2fMiUY9PqYZnZn5UCVewS bKw8AieQRsHBPojtfvDzHgADZduu/w7xMaV1DN6RZzs/Wgjdcz8OYpVtuHqZsF6P9AOi jCkSXfNn20KhElIV1qmtPCcvi4eIRbL7t5657Jhl9QUZPMoTTypn0hiyfbttiaCfPRao Y0fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739329176; x=1739933976; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EjIWgnK7uvFSzJic7hZFgCOzrxMyQaosaEh2vcN4GXI=; b=QXsEkuZkbRSX8mbApzG2Sdqo2qH/v+7GdhMjjVaDnB1EY9ALBgdemPHBxkKGHhlYjS pemhYIUiMqW+m9s5ca0NtyDefooYBQsH1oydGShjoNjYcTTr6Bi0Wino+CAH/Yq+cHFj RRfBQr01T1lxkn/qdpnEb1q0soUhLmIkCIQYT7WSmV6a6HK0I3jTsRStNrsFwNDIriD6 mXKRhcgFHMsDWm0nXQhq9IooWTEadH3UR6k3Ce08+lwjCFC6WZ3qYx2OP2eX0gPaSTIJ 5UVnAAk6uvL2nVWe05uaXHV2HMZWfOeJmJYoZPWxhIr2um+2sNabQIoVIn2hAhUcDpYj b1tw== X-Forwarded-Encrypted: i=1; AJvYcCVULBuArQB9YyCQR/lwxPC/kcBKecIhegH5ytIKzHdNqz3wpTQUxGODzHG6/hKpFnyA+OV0iV9aYde3 <at> debbugs.gnu.org X-Gm-Message-State: AOJu0YxCeX4YE4xnJcgQk7+U7mrC4oUfCbMfMabKbQnk59zcyG+zHB6y WVFFV5mlq3cNd6WoKT0plwuU/ExHn6vvWWXUQyG0nZ3H39pUWwt8IVQbBVkFUWmekPQ049Q0VDH ZynEoK1chJINsAuT3tySC8TSYCoA= X-Gm-Gg: ASbGncsgJUiScdhKXycme6v9UeMH1j7qXzEuOXqtSm3gxipDqsvVcAiTMsHoxwApuIp E0TNv5ByWZMY5VHvmS5KaZy4x2UT+iH/btG5qep+XIknZCSLBxYZB91ii/W9SH6GJ/nL9dpcw X-Google-Smtp-Source: AGHT+IE/djTgXpMUdsHpYK9HIQ01Eu7tRMsSmoWCCMLc96LKBXkdiCNQMusMWYuwlqJDLcpO/wFs97CGDP0V4XnWjUg= X-Received: by 2002:a17:907:9448:b0:ab7:b5d6:2696 with SMTP id a640c23a62f3a-ab7f33c7843mr113091166b.32.1739329176372; Tue, 11 Feb 2025 18:59:36 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 11 Feb 2025 18:59:35 -0800 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <87lduc5860.fsf@HIDDEN> References: <87frndjf7e.fsf@HIDDEN> <CADwFkmkKOsOqR9O7OwJRj_dpBDo7H_RsiatUtYBaccN7SLpi3g@HIDDEN> <87lduc5860.fsf@HIDDEN> MIME-Version: 1.0 Date: Tue, 11 Feb 2025 18:59:35 -0800 X-Gm-Features: AWEUYZl-0xw5D6LPq47KcY3kY4Zv4ZnkuLuW3-0hDjFvAgez7o_fBruuk3hIF8M Message-ID: <CADwFkmmUj4QisD1xnMouM2jtphaqg=E+tXpw5mL0v2jsP9Vxhw@HIDDEN> Subject: Re: bug#74554: 31.0.50; [PATCH] gnus: fix logo color customization To: Andrew Cohen <acohen@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74554-done Cc: Eric Abrahamsen <eric@HIDDEN>, Trevor Arjeski <tmarjeski@HIDDEN>, 74554-done <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Version: 31.1 Andrew Cohen <acohen@HIDDEN> writes: >>>>>> "SK" == Stefan Kangas <stefankangas@HIDDEN> writes: > > SK> Trevor Arjeski <tmarjeski@HIDDEN> writes: > >> 1. Add the following code to an init.el: > >> > >> (use-package gnus :ensure nil :custom (gnus-logo-color-style > >> 'neutral)) > >> > >> 2. Start emacs, M-x gnus, and notice that the logo does not > >> change to the neutral gray colors. > >> > >> This does not seem to happen when using the Customization > >> interface which puts `custom-set-variables' in your init.el: > >> > >> (custom-set-variables '(gnus-logo-color-style 'neutral)) > >> > >> > >> I'm not sure if this is related to use-package's :custom keyword, > >> but I have not come across this issue while using any other > >> built-in emacs packages. > >> > >> Please see the attached patch file for a possible fix and minor > >> improvement. > >> > >> Thanks, Trevor > > SK> Andrew, Eric, could you please help review this patch? > > Looks OK to me. > -- > Andrew Cohen Thanks, installed on master with a ChangeLog entry as per CONTRIBUTE, and a touched up commit message. See commit 77d0078a6c5. Trevor, it seems like we have reached the limit of the amount of code we can accept from you without a copyright assignment. If you plan to contribute more patches in the future, it would be a good idea to get the copyright assignment process started now. Please let us know if you want to do that, and we can help you get started.
Trevor Arjeski <tmarjeski@HIDDEN>:Stefan Kangas <stefankangas@HIDDEN>:
Received: (at 74554) by debbugs.gnu.org; 12 Feb 2025 00:16:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 11 19:16:58 2025
Received: from localhost ([127.0.0.1]:59614 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ti0R0-0005nE-Cx
for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 19:16:58 -0500
Received: from mail-japaneastazon11020112.outbound.protection.outlook.com
([52.101.229.112]:8861 helo=TY3P286CU002.outbound.protection.outlook.com)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <acohen@HIDDEN>) id 1ti0Qw-0005mu-LB
for 74554 <at> debbugs.gnu.org; Tue, 11 Feb 2025 19:16:56 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=ItRgvdzEOIvPH782DO3Svp02UIvUtVwAbIEAbiYwhAdGMbOsLYz/2sUEFFRJr+G0AO1hzRUaOVRjGmVcVyxEDgUgkaxEEdPtX0HBla/vV+AM7n5KkSUZyOIiSWNQ+yyejM6VdGX487g/nA5P2N+Go6ZXyfia1XNcvB8UapBI0gGPOnN/NLwrSoN9Anb3VajL71WfCOZnDtD13skVoGMIyPeI0yzvLpSWzG3qcbTVPj1T1GbJEsPDy+ghodd8/c/TXcSGzJ5FMcBX09NZ9Eq7HXZ1+Dh/KjvxHp+ptTFoln4aFcZGiEbfRog+Ok3zvR9pRkxKWqhbI6h9NWwgvfr0xQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=kPWxDfsG+5dWrQ2fNcswHegp1z/0l4dPNHFZ7xs/qPc=;
b=OpZdYPSL4t1M0v1J7S8CoaFTkfcxaL9C+olaHMgi5UK2OYcgdVmZ7JmbUygM0ximvGeMFavyXnq3CqkrWp1HvvcB8RJStDhvjpWTpn9KT6XYaBW6+PsRgSdd1UFqjB7nvq6lbuv+wSu4+SdAoVSDlVKohnpiPhTweCDiZnwMs78GZyyJpvrfjLl24FO3Hx8TnpD3BQtw21oeiH+K6cEN2/SVjEd1FbZjaKuTUAw2lHa+y/kxte6SddfDwjEFpwzx3nZXop1HsPBliawx9dqLzghg3i+j7v0b+d3sG/tACLE/lSfy+LDc4kpsUovcpa9xD5KllOrgYrOQcE5LAm1QKQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=ust.hk; dmarc=pass action=none header.from=ust.hk; dkim=pass
header.d=ust.hk; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ust.hk; s=selector2;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=kPWxDfsG+5dWrQ2fNcswHegp1z/0l4dPNHFZ7xs/qPc=;
b=Jy0XkquJsXj2PpQpJxrX+td/eaSIl3Zq2nzf1288Fnj5qdTdpBILJjCi7CsXMJmZc6f/a0RW+wnO8A5LyqRkqWLcZZOzZt1ZCmM30O13wvsr8fUbc2S1hx/Hak4CFALm9FbEh5qowUhARCzqcehsvcHt0PbAnFBns7FOPqcYdjHC9ZSnTPjWJ/bJd3A89sA7d9dapWfKfP/30SR54V6owGNOeWjU5/mRpImRY/5xGTBrH2D0GVQ13tqw7c5SmwKjVj5uATIz0QkZcUbKBa1L+e2zlIT22wpeXhm8/FBTU1g4jOhcYcMOUF6zuI8zwhu/gZEWgOapCmhJBGWN+rQI4g==
Authentication-Results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=ust.hk;
Received: from OS3P286MB1877.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:1bf::11)
by TYYP286MB4874.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:145::12)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8422.18; Wed, 12 Feb
2025 00:16:45 +0000
Received: from OS3P286MB1877.JPNP286.PROD.OUTLOOK.COM
([fe80::4b6e:c37e:4327:cfab]) by OS3P286MB1877.JPNP286.PROD.OUTLOOK.COM
([fe80::4b6e:c37e:4327:cfab%4]) with mapi id 15.20.8422.015; Wed, 12 Feb 2025
00:16:45 +0000
From: Andrew Cohen <acohen@HIDDEN>
To: Stefan Kangas <stefankangas@HIDDEN>
Subject: Re: bug#74554: 31.0.50; [PATCH] gnus: fix logo color customization
In-Reply-To: <CADwFkmkKOsOqR9O7OwJRj_dpBDo7H_RsiatUtYBaccN7SLpi3g@HIDDEN>
References: <87frndjf7e.fsf@HIDDEN>
<CADwFkmkKOsOqR9O7OwJRj_dpBDo7H_RsiatUtYBaccN7SLpi3g@HIDDEN>
Date: Wed, 12 Feb 2025 08:16:39 +0800
Message-ID: <87lduc5860.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
Content-Type: text/plain
X-ClientProxiedBy: TPYP295CA0050.TWNP295.PROD.OUTLOOK.COM
(2603:1096:7d0:8::12) To OS3P286MB1877.JPNP286.PROD.OUTLOOK.COM
(2603:1096:604:1bf::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: OS3P286MB1877:EE_|TYYP286MB4874:EE_
X-MS-Office365-Filtering-Correlation-Id: 832b0132-1429-486b-2970-08dd4afa8861
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016;
X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?u39X/JJiP2TibcxRkZawxsI+WMxzkZruxuCRXLUjOTWtKESJ2CPfoOUdciV5?=
=?us-ascii?Q?YnvZNDW5Xqs7B9RoMPVx5tJwtA6Oe6P5hzfey/v+oFa+4nLQVrZ4qnvh//nq?=
=?us-ascii?Q?sFr9ZvWK0cjASGFLSgDgF3N8yVxbMAjOaSKXSnZYW00z8A19ulaTBiw/QJ/B?=
=?us-ascii?Q?0hMhhvyizdwVc6EJe2Wv6l6uo/ErIcIFcKXMYEFEF0H4zR9FchowN0/AYSXm?=
=?us-ascii?Q?n9v0Dlok3F8CU0Y3SVduLBUlNJQFUI1SqYF0pyLmTIxLg0AOUUQbBuixkt7m?=
=?us-ascii?Q?jVMp6Jw55kp0UGIMr5AxLjWnh7wcf6t2EFbB2IqVvQBpinnBBfnHdlRch+rR?=
=?us-ascii?Q?pPWHeldQ7f6hw1/Qxnkri3K3fx00RYFxoT3PJm2VX0gcg/UpVC01pfay3pjA?=
=?us-ascii?Q?jESndqEaI1uHvu9SJw0vrcFKkSKnLsutsD99WJdnZGMr8RVdUqIWR+k1jJ7o?=
=?us-ascii?Q?YIfMMzGkBO9k/4nTJ3DnhxJXeq9ltUUjugHV5lRjHm5vcuAJdsLNpzcVEnOp?=
=?us-ascii?Q?LEk9VamtUxNnep3nVyeFVY0gQfOAzJJSRdECk1u2G5DggDfehfg7iiFg83k/?=
=?us-ascii?Q?tGZ/metZIfCef3c0TqMlgFDiFSlwAagkSevoKdYAxoeibH+m69/QMLBuBDaT?=
=?us-ascii?Q?7hllH/fBWKYtNBAIweCMSugEA6ympZsXqDva5gHIH7wS4EBDDwH0jesTk2iZ?=
=?us-ascii?Q?CXI3oJKfiIyKJMSQG2pHaQxTGAoQ1hW+KSPlteW5ef9bR7douWstcC6RgyLF?=
=?us-ascii?Q?i1UnJS4kb/DXVeIDuS8aJoNohANSvbbF34B0lEf92CjqL3w+8CRJLdK/sXAx?=
=?us-ascii?Q?rvzxJvgO949APrwuh4YXEVIXc441QSjUppRE7PHgZyhSB29k4gkALvCHJQTJ?=
=?us-ascii?Q?R30SMRVkmgg8bsyPFc6lHKxYSnV1Y21wb2jhGeAYi1yJPpjpDaRZ3iTWgFtk?=
=?us-ascii?Q?pCn2p4QOh4LUPOXyODm3xQ5aSGQl7Y+g7r5K2kGWjKctwTw6lptPDLeKQnbp?=
=?us-ascii?Q?hlqe9+LVJzZE9zSRo+gvhtdpI/g1UMQNuAImAaxT9RiMVZmiNcD6Cdwf/oWf?=
=?us-ascii?Q?gzbJ1D0UuubL/a4lPQUsTJKllHWH9iVSFHQj9x/J57rSLs2pk4lRENiirXRr?=
=?us-ascii?Q?1EFtqOXNH/ZqUqEGpggGQGNyel2mtAiK7QMjkb3GUob7NLbk5yp5xkl1jU7W?=
=?us-ascii?Q?ubYUOBBDGBaBkdv7TV5EkYpe0mVrv/kxlkX0LtNhJuvjDk4R7GBT3xcDHTnL?=
=?us-ascii?Q?mG0c08D7iTAZLX/kIkIs6RQHEakj9r7t4lzLZpj8FkAkvjOvhECK8SqJcnFb?=
=?us-ascii?Q?JqUmFHrQwjeIll3GoRxjTbXaKlOBFBx/LZWNka/8x62n9ZPNtghPOXtXPc9N?=
=?us-ascii?Q?N3lo0vROxQNHF/4Lrqfhsr9unpXl?=
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:OS3P286MB1877.JPNP286.PROD.OUTLOOK.COM; PTR:; CAT:NONE;
SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ipCZqUyJkVOkfOp7oQPhxTFKg6eeG/wv8kDw2dY3G1LoWAGnPsIn2c7DIq+r?=
=?us-ascii?Q?LvbddoRdGrsYf0AFU0jhfdMFRG6mx6YdUJICIZuv6ovh/GthHGgXkD+G0FoT?=
=?us-ascii?Q?qK1jBI1rUltrdioU0gwRn0SAZxYcG/A7QRetzNdX6KubXGJUw846p4TdOFvK?=
=?us-ascii?Q?0iQtjOyyz6Q5PW+Z/Rv4zXTlxW9Z0PzPXvHaV0qdpfN0W1JIyByS7DNKv7iE?=
=?us-ascii?Q?zU7GUnXkg/ggE91gqhZJXMEK892d7MVp9wKgDpf1hFmt5nk3NNxVjtlAWx5q?=
=?us-ascii?Q?2xfvrDfWARuWOg8U30yRKv7t77sV62CfP0ijj07/SDQd/8RAFWJQuodPbFh0?=
=?us-ascii?Q?0o77HQpVoH7jZRnGpcCaNBCb2GN15ak6Id1trOfLqqszkihXrKtUQPB7LU59?=
=?us-ascii?Q?uNreoKcMMhbflyxEBhZ1QLrzrvM1R5xzEDD5Ot4PTQtiySngHKrBRQkM29Ki?=
=?us-ascii?Q?uMmNPcGXgyfi9xxjZEZBBRWbcKoK38thM+1AlS+FhoWclNSiTTVj+AOIJ3GF?=
=?us-ascii?Q?W+QUgZMSvmJPe6hfm2eSkoQOHb/8O0zvjgPAUSSh5KKKeUMOCdlFR1FJhOhG?=
=?us-ascii?Q?c74Hp1stIPNqv4W3GYOET7/TLlKLce8hRneyL4VO0fcWquuJZWjCVe5i3zZG?=
=?us-ascii?Q?lPAzzEYlnWXp8DK66pAn77RSIzmc9CWykT3UNZ+0lhr2BcjTeUo/UDpGImEQ?=
=?us-ascii?Q?gviKHK2YUSIckQB+2fcGhEO9ou9n0A5hQBaMAQU8IK/1UXB19kkJKQLGqn+u?=
=?us-ascii?Q?Kpph6PWUbjNKAe/ILEez6AwEJW9uae70/LB7DIHZWK0GMk11iBhhHJVNlLIU?=
=?us-ascii?Q?LZuGP73AAN0THZ2Q+k+4qBy+GMaxBl/j2hXscODLxjM5gw8jxX0NWVCx+duV?=
=?us-ascii?Q?gPdzONg9GjaaOT6nEMpCukVCGB07geNyPE8m4aO7Tz1AYszjYthL1mEOjacS?=
=?us-ascii?Q?txXyftBKPvYbD5HQsOqXw46DkVAtI3vTxxgcVPzQVvY+XlqWDolYmsQtMqk6?=
=?us-ascii?Q?4RtReONSFr7H/+kx/Ku6K5+MCv9oo82KLKpla0Eo+I0nr65pPKh2GAfIXbuc?=
=?us-ascii?Q?3Y6zsH7LZ9Mf0ml6JWykT4Lx3pwTJk1+s+4KR+wmKxt97EXtdC1DRQZxFblA?=
=?us-ascii?Q?aoRdVdpsCEqFvepCuegtA398K9qGkM+gI6ZzOraNkLPnzphSc7ySKtI/YsST?=
=?us-ascii?Q?RM2Cfj2jIteiPkM35OO0aqwoozXMJlijdXB5+zopVvKNHlFEgV3xDwTaAvem?=
=?us-ascii?Q?OINoOe6pk2n3vo+CSKBnQ091Vu7MDKqNWO7/TsBFx89svoBmkQ8sf83eUL5N?=
=?us-ascii?Q?YiHw1UQVI/HkqYAnFQQwxc+oPcX0sjkxWhslHdDslxoFK0exidFn2Se2wqqT?=
=?us-ascii?Q?N3/aT59sfoiplRqgfc9UvUrk7Pci8WMwNyWGSMLgvn96VvbPWXbfOEmh+fZe?=
=?us-ascii?Q?EodblzLLrBqcdVMm9HBMlsvM57xTavKZSbxnfVmEHXq+ncWPeivjRPxQIic4?=
=?us-ascii?Q?yHSMYPulCjxkSURd4MtA81i1a3rDimy0wYM0uALvx58WGl4mclf8IttD0/q4?=
=?us-ascii?Q?Fp6jVga8PWIwdlyCehU=3D?=
X-OriginatorOrg: ust.hk
X-MS-Exchange-CrossTenant-Network-Message-Id: 832b0132-1429-486b-2970-08dd4afa8861
X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB1877.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2025 00:16:45.0361 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: c917f3e2-9322-4926-9bb3-daca730413ca
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d6dmD9be1I1gsn3SMwBEOs8fnaLpEdExje8M/4byYovLZhO579YXhJQHoGfxleT0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYYP286MB4874
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 74554
Cc: Eric Abrahamsen <eric@HIDDEN>,
Trevor Arjeski <tmarjeski@HIDDEN>, 74554 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
>>>>> "SK" == Stefan Kangas <stefankangas@HIDDEN> writes:
SK> Trevor Arjeski <tmarjeski@HIDDEN> writes:
>> 1. Add the following code to an init.el:
>>
>> (use-package gnus :ensure nil :custom (gnus-logo-color-style
>> 'neutral))
>>
>> 2. Start emacs, M-x gnus, and notice that the logo does not
>> change to the neutral gray colors.
>>
>> This does not seem to happen when using the Customization
>> interface which puts `custom-set-variables' in your init.el:
>>
>> (custom-set-variables '(gnus-logo-color-style 'neutral))
>>
>>
>> I'm not sure if this is related to use-package's :custom keyword,
>> but I have not come across this issue while using any other
>> built-in emacs packages.
>>
>> Please see the attached patch file for a possible fix and minor
>> improvement.
>>
>> Thanks, Trevor
SK> Andrew, Eric, could you please help review this patch?
Looks OK to me.
--
Andrew Cohen
bug-gnu-emacs@HIDDEN, bugs@HIDDEN:bug#74554; Package emacs,gnus.
Full text available.Received: (at 74554) by debbugs.gnu.org; 11 Feb 2025 19:15:25 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 11 14:15:25 2025 Received: from localhost ([127.0.0.1]:58647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thvjB-0003Fi-6w for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 14:15:25 -0500 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]:47263) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1thvj8-0003E1-0i for 74554 <at> debbugs.gnu.org; Tue, 11 Feb 2025 14:15:22 -0500 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5de4a8b4f86so7018712a12.2 for <74554 <at> debbugs.gnu.org>; Tue, 11 Feb 2025 11:15:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739301316; x=1739906116; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=7Wen9zOsy0n0wymj87jz0sdBpBDKjxh0WH6MnxEpkgA=; b=GMkgL0qUzmnF6hrzmlJc4pRJhHJ9oD6mdJY4M+9n/csBoWJhUOsMMcgWQDBRPETBDf ZwaToxgH61vUFYi5MQTKd6eX/LTCh/0OUEsv6LyGzWKmPg4CIFNXUzcYCshIdx82WlR1 VLZEXddMNr2Xd4h/dEB4UBG4EjB4LVIndxIS9kzU6C+a8AeVcl8QlZFU/7Qze6UgZaoR hSa2nnuN0kldj7xedZVbyd2g96Nj0Fi20cXgmVCza+ix57PFevZCaz5zV4oG+2U8ZgZR jGHxKmgSZJs+0iRY8Ku1IMFt35nOpn+TNNk8mYC/LglEa1av9ycpPbg804JjLHYrAmhl Aipw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739301316; x=1739906116; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7Wen9zOsy0n0wymj87jz0sdBpBDKjxh0WH6MnxEpkgA=; b=HCl7g60vReHbuo9c92HWi8hEFFl64XeV7s8BPHCfgOgFKVg4aAchMwpAOsInPeabJD Op5XmOUG4U6appz0fGv9y+RMkfWkZ1YH71upVor7zQxOX2jGg6nVhUJoUARdxDOvfQYk b3cU4QQmeN/88Qjj8uJALxwYUBVvakX0MMo+1bdMhcgjPVtKo6Hkxur6yHNHviNmn7Vr qPmZpO73H5r8TtWQVFaKS2iGIjBRYppXtjuHKDHlCcQ1tMgnCrIhDbToz6t3pgB34wPD jahjpPhBUxILK9ijFJ+U2iX71ZkXbQf6b72IXqm9aLuwULbRi3rxzNn8Zd/G1I/1a6cf 96Fg== X-Gm-Message-State: AOJu0YxFCVCzwnAKK2DR8L/WeO0C/YGIrNd+y2Td5ehwPj1TD81XAYTo 05Zy6foG6QKZs67ltM6lWVN+FGrljfwAVJSFLluUh/jNC2CHa5g0cIG3FyEsq8i81zRwwa3l0w3 eY+M3cGGjj+qpr51Kjj4fZAgq+ZQ= X-Gm-Gg: ASbGncufkrx7rVJxpJ/8S7CaaWTxTub4gw7EYdftqS32nVcImYv4SH1vNlPUBtchebJ Bl2Wi/TDCM2Gw7fl+POGy0Q5L8hNLh1/oNjtXbToIAQe65VuZ2Aj2JCla2L6s9RwdVZ4iLiRtfg == X-Google-Smtp-Source: AGHT+IHZ3nPHxkDPHgxdlfFArRBKn7oEofd7uf7Mf+f+bff8eOnntCrhkfM+RDmiYsSH+KphidhXDVAI45V+a7dCVnE= X-Received: by 2002:a05:6402:26c9:b0:5dc:1ec6:12bc with SMTP id 4fb4d7f45d1cf-5deade00874mr331367a12.28.1739301315636; Tue, 11 Feb 2025 11:15:15 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 11 Feb 2025 11:15:15 -0800 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <87frndjf7e.fsf@HIDDEN> References: <87frndjf7e.fsf@HIDDEN> MIME-Version: 1.0 Date: Tue, 11 Feb 2025 11:15:15 -0800 X-Gm-Features: AWEUYZkFjWIQe18iRnuQ31Q-QUsQGWXNbiwILa6QeFzeAIXO3dtpftHpvaOl2Rs Message-ID: <CADwFkmkKOsOqR9O7OwJRj_dpBDo7H_RsiatUtYBaccN7SLpi3g@HIDDEN> Subject: Re: bug#74554: 31.0.50; [PATCH] gnus: fix logo color customization To: Trevor Arjeski <tmarjeski@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74554 Cc: Andrew Cohen <acohen@HIDDEN>, Eric Abrahamsen <eric@HIDDEN>, 74554 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Trevor Arjeski <tmarjeski@HIDDEN> writes: > 1. Add the following code to an init.el: > > (use-package gnus > :ensure nil > :custom > (gnus-logo-color-style 'neutral)) > > 2. Start emacs, M-x gnus, and notice that the logo does not change to > the neutral gray colors. > > This does not seem to happen when using the Customization interface > which puts `custom-set-variables' in your init.el: > > (custom-set-variables > '(gnus-logo-color-style 'neutral)) > > > I'm not sure if this is related to use-package's :custom keyword, but I > have not come across this issue while using any other built-in emacs > packages. > > Please see the attached patch file for a possible fix and minor > improvement. > > Thanks, > Trevor Andrew, Eric, could you please help review this patch?
bug-gnu-emacs@HIDDEN, bugs@HIDDEN:bug#74554; Package emacs,gnus.
Full text available.Stefan Kangas <stefankangas@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at submit) by debbugs.gnu.org; 27 Nov 2024 07:42:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 27 02:42:09 2024
Received: from localhost ([127.0.0.1]:58148 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tGCga-0006NV-SC
for submit <at> debbugs.gnu.org; Wed, 27 Nov 2024 02:42:09 -0500
Received: from lists.gnu.org ([209.51.188.17]:59548)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <tmarjeski@HIDDEN>) id 1tGCgY-0006NL-VO
for submit <at> debbugs.gnu.org; Wed, 27 Nov 2024 02:42:07 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <tmarjeski@HIDDEN>)
id 1tGCgY-0002u7-GB
for bug-gnu-emacs@HIDDEN; Wed, 27 Nov 2024 02:42:06 -0500
Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <tmarjeski@HIDDEN>)
id 1tGCgV-0002E8-KZ
for bug-gnu-emacs@HIDDEN; Wed, 27 Nov 2024 02:42:06 -0500
Received: by mail-lf1-x136.google.com with SMTP id
2adb3069b0e04-53df1d1b6f8so160003e87.3
for <bug-gnu-emacs@HIDDEN>; Tue, 26 Nov 2024 23:42:03 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1732693321; x=1733298121; darn=gnu.org;
h=mime-version:message-id:date:subject:to:from:from:to:cc:subject
:date:message-id:reply-to;
bh=yDmEtXQBTfdJR7oVWqChI/8kwezYiS9RkLMc3NSxWxI=;
b=c2HEpVj5kBsAEkrN4JXH1mwcTBMRVJdJoY5E4g3546qiDKlhswxScGFLtll0Es2A+O
jD4cB3bFmHagHCvvw6qWMmGkhkcpfnrmK53UAPm5ubcJvwGoxWpkmb3wUH8dvhoGT6wa
4aH/D++69AguQDh1bbVMrn6zasZDUWPi9mv8rg7Qibrp+KGiEtIk7MuBy4aH+lIz/f6N
AHAhLnmKOUZRebvwZKJbjrK4nC4clfMJidmYi6ZuzZdt9PBsuiHVaQP1NzUoSo/R7C7I
MJ3igqdM1bvtj/UXdDSgOqRUc+fJtU0j2JFUGO8NWuPYjMCptF0yPrpqNrf1O69yIMHJ
v0cQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1732693321; x=1733298121;
h=mime-version:message-id:date:subject:to:from:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=yDmEtXQBTfdJR7oVWqChI/8kwezYiS9RkLMc3NSxWxI=;
b=cxRaydsOlKMMEvsBQeFAyW00bdtLxYzoqu+eP7Y11rLHqNORHgvU7RV5O+Ehevbfm0
w07/f7Y20s3sSSCw+qaUMcLsnYd2d0rg/3rTKdNNSV8XTDAJyIlG2EQcoJQWXmITej3v
8mGJ+lcIu+7hymzzpNI6g6Tk7tiJtf6358W0NrXlvevPE4TWfHiGc7//EXMDjeQs26bB
Q3+hEMgwK4cqFtOhkEbkMta7oftnF02jVhDpOU/Jg+A5Ncyzhdj4UeUVPvrvIzfV5CBe
LBca/4ClOE4u63hzVtvEjF4Lw/3QXsgXR6WGyUJKa7UwI/OPRFNBEJD3wiRSpO2lss2d
WVqQ==
X-Gm-Message-State: AOJu0YzS8O+42Up4iXwsfnH4ZF3ZveM6PftDYWbIcknjqa2AYBpUCQEh
hPXxY7eCl80oIF6sTI+kYiuFtFeP7XyaiFpCPb98fWqNtGPRhaQuohgPH6rn
X-Gm-Gg: ASbGncuHiJy5vbNlS0G8sdShd7JbdkPNkFVmd+85a29SQVLQE/aDYH0gXG2w+PEIw+K
WOgfMAwfyqv0Uv5uHz6JRcluOm4e+60IiXE8tSkazLo31/o9Da+T6F0Ht84l7yglDKYbtTiBa2e
IaW3b2nhRKlxDOqeulADyL9mLIQst96wnW1cHa8kbLAhPVqMpEuD+jX1ENHX6zzn4U2UYBmL9Z5
eQfbx9McOvWEQYbkoH3gDZJOW9iVKCbMYYbOc+CpfTPCXDqemIhaOQKg+I3Nfiboza3bO58U7Or
2w==
X-Google-Smtp-Source: AGHT+IGafYSvi0oD25xIViBN63jyVIt8ZNXvzNEdrXlG2cPMdGqNbI4z852dr9w51RXxFdDk4AYZ+Q==
X-Received: by 2002:a05:6512:2350:b0:53d:d41e:b1a8 with SMTP id
2adb3069b0e04-53df00d10f1mr890280e87.20.1732693320676;
Tue, 26 Nov 2024 23:42:00 -0800 (PST)
Received: from trevarch (109-252-36-249.nat.spd-mgts.ru. [109.252.36.249])
by smtp.gmail.com with ESMTPSA id
2adb3069b0e04-53dd248b36asm2234153e87.217.2024.11.26.23.41.57
for <bug-gnu-emacs@HIDDEN>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 26 Nov 2024 23:41:59 -0800 (PST)
From: Trevor Arjeski <tmarjeski@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 31.0.50; [PATCH] gnus: fix logo color customization
X-Debbugs-Package: emacs,gnus
X-Debbugs-Cc:
Date: Wed, 27 Nov 2024 10:41:57 +0300
Message-ID: <87frndjf7e.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=2a00:1450:4864:20::136;
envelope-from=tmarjeski@HIDDEN; helo=mail-lf1-x136.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)
--=-=-=
Content-Type: text/plain
1. Add the following code to an init.el:
(use-package gnus
:ensure nil
:custom
(gnus-logo-color-style 'neutral))
2. Start emacs, M-x gnus, and notice that the logo does not change to
the neutral gray colors.
This does not seem to happen when using the Customization interface
which puts `custom-set-variables' in your init.el:
(custom-set-variables
'(gnus-logo-color-style 'neutral))
I'm not sure if this is related to use-package's :custom keyword, but I
have not come across this issue while using any other built-in emacs
packages.
Please see the attached patch file for a possible fix and minor
improvement.
Thanks,
Trevor
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0001-gnus-fix-logo-color-customization.patch
Content-Description: patch file
From f3d26de73e4362db837d20a3b0aa871f8b4ed345 Mon Sep 17 00:00:00 2001
From: Trevor Arjeski <tmarjeski@HIDDEN>
Date: Wed, 27 Nov 2024 10:12:07 +0300
Subject: [PATCH] gnus: fix logo color customization
Fixes a bug where customizing `gnus-logo-color-style' from use-package's
:custom keyword did not set `gnus-logo-colors' before gnus is launched.
This patch does the following:
- Implements a :set keyword on `gnus-logo-color-style' which will
correctly set `gnus-logo-colors'
- Exposes `gnus-logo-colors' using `defcustom' for more fine-grained
customization
- Uses :set-after on `gnus-logo-colors' so that it is set after
`gnus-logo-color-style'
---
lisp/gnus/gnus.el | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/lisp/gnus/gnus.el b/lisp/gnus/gnus.el
index 62a090bd9df..ef07f34ca07 100644
--- a/lisp/gnus/gnus.el
+++ b/lisp/gnus/gnus.el
@@ -757,16 +757,22 @@ gnus-logo-color-alist
(september "#bf9900" "#ffcc00"))
"Color alist used for the Gnus logo.")
+(defcustom gnus-logo-colors nil
+ "Colors used for the Gnus logo."
+ :set-after '(gnus-logo-color-style)
+ :type '(list color color)
+ :group 'gnus-xmas)
+
(defcustom gnus-logo-color-style 'ma
"Color styles used for the Gnus logo."
:type `(choice ,@(mapcar (lambda (elem) (list 'const (car elem)))
gnus-logo-color-alist))
+ :set (lambda (sym val)
+ (set-default-toplevel-value sym val)
+ (set-default-toplevel-value 'gnus-logo-colors
+ (cdr (assq val gnus-logo-color-alist))))
:group 'gnus-xmas)
-(defvar gnus-logo-colors
- (cdr (assq gnus-logo-color-style gnus-logo-color-alist))
- "Colors used for the Gnus logo.")
-
(defvar image-load-path)
(declare-function image-size "image.c" (spec &optional pixels frame))
--
2.47.1
--=-=-=
Content-Type: text/plain
In GNU Emacs 31.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version
3.24.43, cairo version 1.18.2) of 2024-11-14 built on trevarch
Repository revision: b83a45eab53b8e6d8f3be45c0acb9a42a5262cb0
Repository branch: makepkg
Windowing system distributor 'The X.Org Foundation', version 11.0.12101014
System Description: Arch Linux
Configured using:
'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib
--localstatedir=/var --mandir=/usr/share/man --with-gameuser=:games
--with-modules --without-m17n-flt --without-gconf
--with-native-compilation=yes --with-xinput2 --with-x-toolkit=gtk3
--without-xaw3d --with-sound=no --with-tree-sitter --without-gpm
--without-compress-install
'--program-transform-name=s/\([ec]tags\)/\1.emacs/'
'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions
-Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security
-fstack-clash-protection -fcf-protection -fno-omit-frame-pointer
-mno-omit-leaf-frame-pointer -Wno-implicit-function-declaration -g
-ffile-prefix-map=/home/trev/Workspace/emacs-git/src=/usr/src/debug/emacs-git
-flto=auto' 'LDFLAGS=-Wl,-O1 -Wl,--sort-common -Wl,--as-needed
-Wl,-z,relro -Wl,-z,now -Wl,-z,pack-relative-relocs -flto=auto''
Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG
LCMS2 LIBOTF LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY
PDUMPER PNG RSVG SECCOMP SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS
TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB
Important settings:
value of $LC_ALL: en_US.UTF-8
value of $LC_CTYPE: en_US.UTF-8
value of $LANG: en_US.UTF-8
locale-coding-system: utf-8-unix
Major mode: ELisp/l
Minor modes in effect:
global-git-commit-mode: t
magit-auto-revert-mode: t
server-mode: t
erc-track-mode: t
erc-track-minor-mode: t
erc-spelling-mode: t
erc-ring-mode: t
erc-netsplit-mode: t
erc-menu-mode: t
erc-match-mode: t
erc-list-mode: t
erc-irccontrols-mode: t
erc-move-to-prompt-mode: t
erc-readonly-mode: t
erc-scrolltobottom-mode: t
erc-imenu-mode: t
erc-pcomplete-mode: t
erc-button-mode: t
erc-fill-mode: t
erc-stamp-mode: t
erc-autojoin-mode: t
erc-networks-mode: t
diff-hl-flydiff-mode: t
global-diff-hl-mode: t
diff-hl-mode: t
bug-reference-prog-mode: t
paredit-mode: t
display-line-numbers-mode: t
ligature-mode: t
rainbow-delimiters-mode: t
format-all-mode: t
global-treesit-auto-mode: t
corfu-popupinfo-mode: t
global-corfu-mode: t
corfu-mode: t
marginalia-mode: t
savehist-mode: t
vertico-mode: t
undo-fu-session-global-mode: t
undo-fu-session-mode: t
which-key-mode: t
electric-pair-mode: t
global-auto-revert-mode: t
desktop-save-mode: t
recentf-mode: t
save-place-mode: t
override-global-mode: t
global-eldoc-mode: t
eldoc-mode: t
show-paren-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
window-divider-mode: t
minibuffer-regexp-mode: t
column-number-mode: t
line-number-mode: t
auto-fill-function: do-auto-fill
transient-mark-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
Load-path shadows:
~/.emacs.d//lisp/aoc hides /home/trev/.emacs.d/elpa/aoc-1.0.0/aoc
~/.emacs.d//lisp/launch-program hides /home/trev/.emacs.d/elpa/launch-program-1.0.0/launch-program
~/.emacs.d//lisp/my-secrets hides /home/trev/.emacs.d/elpa/my-secrets-1.0.0/my-secrets
/home/trev/.emacs.d/elpa/transient-20241115.2034/transient hides /usr/share/emacs/31.0.50/lisp/transient
Features:
(shadow sort mail-extr emacsbug ibuf-ext ibuffer ibuffer-loaddefs
nndraft nnmh gnus-agent gnus-srvr gnus-score score-mode nnvirtual
gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-cache
gnus-sum shr pixel-fill kinsoku url-file svg dom gnutls nntp gnus-group
gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail
mail-source utf7 nnoo parse-time iso8601 gnus-spec gnus-int gnus-range
gnus-win magit-patch magit-extras face-remap magit-bookmark
magit-submodule magit-blame magit-stash magit-reflog magit-bisect
magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit
magit-sequence magit-notes magit-worktree magit-tag magit-merge
magit-branch magit-reset magit-files magit-refs magit-status magit
magit-repos magit-apply magit-wip magit-log which-func magit-diff
smerge-mode git-commit magit-core magit-autorevert magit-margin
magit-transient magit-process with-editor shell server magit-mode
transient benchmark magit-git magit-base magit-section cursor-sensor crm
noutline outline lisp-mnt cc-mode cc-fonts cc-guess cc-menus cc-cmds
cc-styles cc-align cc-engine cape-char undo-fu whitespace cape shortdoc
reveal ace-window avy jka-compr comp comp-cstr warnings comp-run
comp-common helpful cc-langs cc-vars cc-defs trace cl-print edebug debug
backtrace info-look f elisp-refs s dash misearch multi-isearch pulse
help-fns radix-tree find-func xref project consult bookmark
network-stream nsm erc-track erc-spelling flyspell ispell erc-ring
erc-nicks erc-netsplit erc-menu erc-match erc-list erc-goodies erc-imenu
imenu erc-pcomplete pcomplete erc-button erc-fill erc-stamp erc-join
my-secrets cus-start epa-file erc format-spec erc-backend erc-networks
erc-common erc-compat erc-loaddefs mule-util orderless rainbow-mode
color diff-hl-flydiff diff diff-hl log-view log-edit message sendmail
yank-media puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg
rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231
rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader add-log
pcvs-util vc-dir ewoc vc vc-git diff-mode track-changes files-x
vc-dispatcher bug-reference thingatpt paredit display-line-numbers rx
ligature rainbow-delimiters format-all language-id inheritenv init gnus
nnheader gnus-util time-date mail-utils range mm-util mail-prsvr
cus-edit pp treesit-auto treesit corfu-popupinfo corfu marginalia
savehist vertico compat grep compile text-property-search comint
ansi-osc ansi-color ring cus-load finder-inf undo-fu-session which-key
diminish doom-themes-ext-org doom-nord-theme pcase doom-themes
doom-themes-base edmacro kmacro elec-pair autorevert filenotify desktop
frameset recentf tree-widget wid-edit saveplace use-package
use-package-ensure use-package-delight use-package-diminish
use-package-bind-key bind-key easy-mmode package browse-url url
url-proxy url-privacy url-expand url-methods url-history url-cookie
generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse
auth-source eieio eieio-core icons password-cache json subr-x map
byte-opt url-vars cl-macs gv cl-extra help-mode cl-seq use-package-core
cl-loaddefs cl-lib bytecomp byte-compile info ace-window-autoloads
aoc-autoloads avy-autoloads cape-autoloads consult-autoloads
corfu-autoloads debbugs-autoloads diff-hl-autoloads diminish-autoloads
doom-themes-autoloads eat-autoloads elfeed-autoloads envrc-autoloads
format-all-autoloads geiser-guile-autoloads geiser-autoloads
git-modes-autoloads helpful-autoloads elisp-refs-autoloads f-autoloads
inheritenv-autoloads language-id-autoloads launch-program-autoloads
leetcode-autoloads aio-autoloads ligature-autoloads log4e-autoloads
magit-autoloads magit-section-autoloads dash-autoloads
marginalia-autoloads markdown-mode-autoloads my-secrets-autoloads
nerd-icons-dired-autoloads nerd-icons-autoloads orderless-autoloads
paredit-autoloads rainbow-delimiters-autoloads rainbow-mode-autoloads
request-autoloads rust-mode-autoloads s-autoloads sly-autoloads
transient-autoloads treesit-auto-autoloads undo-fu-autoloads
undo-fu-session-autoloads vertico-autoloads with-editor-autoloads
ws-butler-autoloads early-init rmc iso-transl tooltip cconv eldoc paren
electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset
image regexp-opt fringe tabulated-list replace newcomment text-mode
lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch
easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo gtk
x-toolkit xinput2 x multi-tty move-toolbar make-network-process
native-compile emacs)
Memory information:
((conses 16 917542 482327) (symbols 48 37245 16) (strings 32 163700 24966)
(string-bytes 1 6520673) (vectors 16 77967) (vector-slots 8 1694574 293787)
(floats 8 857 8668) (intervals 56 59063 1370) (buffers 992 39))
--=-=-=--
Trevor Arjeski <tmarjeski@HIDDEN>:bug-gnu-emacs@HIDDEN, bugs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN, bugs@HIDDEN:bug#74554; Package emacs,gnus.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.