GNU bug report logs - #74570
[PATCH] gnu: xterm: Update to 395.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74570 in the body.
You can then email your comments to 74570 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: kiasoc5 <kiasoc5 <at> disroot.org>
To: guix-patches <at> gnu.org
Cc: kiasoc5 <kiasoc5 <at> disroot.org>
Subject: [PATCH] gnu: xterm: Update to 395.
Date: Thu, 28 Nov 2024 00:19:14 -0500

* gnu/packages/xorg.scm (xterm): Update to 395.

Change-Id: If8434c5d5055fa0a3163a7018b4c0ba5e5280935
---
 gnu/packages/xorg.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
index 554dc21ba7..470e8f1bc3 100644
--- a/gnu/packages/xorg.scm
+++ b/gnu/packages/xorg.scm
@@ -5969,7 +5969,7 @@ (define-public xmessage
 (define-public xterm
   (package
     (name "xterm")
-    (version "390")
+    (version "395")
     (source
      (origin
        (method url-fetch)
@@ -5979,7 +5979,7 @@ (define-public xterm
              (string-append "ftp://ftp.invisible-island.net/xterm/"
                             "xterm-" version ".tgz")))
        (sha256
-        (base32 "03wwdwnpj5dg1ah5sfp00ppzawjd81lnw47g4p20jjhpqly7q4bm"))
+        (base32 "1j1x16c1789w845hgs49wsmgx7b2cwan49r8427f7siqb6m3qvi8"))
        (patches
          (search-patches "xterm-370-explicit-xcursor.patch"))))
     (build-system gnu-build-system)

base-commit: c6d15cf27a137051ccd8f301330a70dd0eecc3d4
-- 
2.46.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: kiasoc5 via Guix-patches via <guix-patches <at> gnu.org>
Cc: 74570 <at> debbugs.gnu.org, kiasoc5 <kiasoc5 <at> disroot.org>
Subject: Re: [bug#74570] [PATCH] gnu: xterm: Update to 395.
Date: Fri, 29 Nov 2024 17:59:43 +0800

[Message part 1 (text/plain, inline)]

kiasoc5 via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/xorg.scm (xterm): Update to 395.
>
> Change-Id: If8434c5d5055fa0a3163a7018b4c0ba5e5280935
> ---
>  gnu/packages/xorg.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
> index 554dc21ba7..470e8f1bc3 100644
> --- a/gnu/packages/xorg.scm
> +++ b/gnu/packages/xorg.scm
> @@ -5969,7 +5969,7 @@ (define-public xmessage
>  (define-public xterm
>    (package
>      (name "xterm")
> -    (version "390")
> +    (version "395")
>      (source
>       (origin
>         (method url-fetch)
> @@ -5979,7 +5979,7 @@ (define-public xterm
>               (string-append "ftp://ftp.invisible-island.net/xterm/"
>                              "xterm-" version ".tgz")))
>         (sha256
> -        (base32 "03wwdwnpj5dg1ah5sfp00ppzawjd81lnw47g4p20jjhpqly7q4bm"))
> +        (base32 "1j1x16c1789w845hgs49wsmgx7b2cwan49r8427f7siqb6m3qvi8"))
>         (patches
>           (search-patches "xterm-370-explicit-xcursor.patch"))))
>      (build-system gnu-build-system)
>
> base-commit: c6d15cf27a137051ccd8f301330a70dd0eecc3d4

Now the xvfb-run test depends on xterm, so we can't simply update xterm,
we might add a new xterm package and hide the original xterm for
xvfb-run only.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 74570 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
Cc: 74570 <at> debbugs.gnu.org, kiasoc5 <at> disroot.org
Subject: Re: [bug#74570] [PATCH] gnu: xterm: Update to 395.
Date: Sat, 07 Dec 2024 23:17:24 +0900

Hi Zheng,

Zheng Junjie <zhengjunjie <at> iscas.ac.cn> writes:

> kiasoc5 via Guix-patches via <guix-patches <at> gnu.org> writes:
>
>> * gnu/packages/xorg.scm (xterm): Update to 395.
>>
>> Change-Id: If8434c5d5055fa0a3163a7018b4c0ba5e5280935
>> ---
>>  gnu/packages/xorg.scm | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
>> index 554dc21ba7..470e8f1bc3 100644
>> --- a/gnu/packages/xorg.scm
>> +++ b/gnu/packages/xorg.scm
>> @@ -5969,7 +5969,7 @@ (define-public xmessage
>>  (define-public xterm
>>    (package
>>      (name "xterm")
>> -    (version "390")
>> +    (version "395")
>>      (source
>>       (origin
>>         (method url-fetch)
>> @@ -5979,7 +5979,7 @@ (define-public xterm
>>               (string-append "ftp://ftp.invisible-island.net/xterm/"
>>                              "xterm-" version ".tgz")))
>>         (sha256
>> -        (base32 "03wwdwnpj5dg1ah5sfp00ppzawjd81lnw47g4p20jjhpqly7q4bm"))
>> +        (base32 "1j1x16c1789w845hgs49wsmgx7b2cwan49r8427f7siqb6m3qvi8"))
>>         (patches
>>           (search-patches "xterm-370-explicit-xcursor.patch"))))
>>      (build-system gnu-build-system)
>>
>> base-commit: c6d15cf27a137051ccd8f301330a70dd0eecc3d4
>
> Now the xvfb-run test depends on xterm, so we can't simply update xterm,
> we might add a new xterm package and hide the original xterm for
> xvfb-run only.

Yes, we could rename the current 'xterm' variable to xterm/pinned, make
it hidden, then proceed to add a new 'xterm' package which inherits from
it, at its latest version.

-- 
Thanks,
Maxim

Message #17 received at 74570 <at> debbugs.gnu.org (full text, mbox):

From: kiasoc5 <kiasoc5 <at> disroot.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
Cc: 74570 <at> debbugs.gnu.org
Subject: Re: [bug#74570] [PATCH] gnu: xterm: Update to 395.
Date: Sun, 8 Dec 2024 18:28:08 -0500

On 12/7/24 09:17, Maxim Cournoyer wrote:
> Hi Zheng,
> 
> Zheng Junjie <zhengjunjie <at> iscas.ac.cn> writes:
> 
>> Now the xvfb-run test depends on xterm, so we can't simply update xterm,
>> we might add a new xterm package and hide the original xterm for
>> xvfb-run only.
> 
> Yes, we could rename the current 'xterm' variable to xterm/pinned, make
> it hidden, then proceed to add a new 'xterm' package which inherits from
> it, at its latest version.
> 

I agree with making a separate xterm package for tests. Since naming is 
one of the hardest things in computer science, how about naming the 
pinned version 'xterm-for-tests' instead?

Message #20 received at 74570 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: kiasoc5 <kiasoc5 <at> disroot.org>
Cc: 74570 <at> debbugs.gnu.org, Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
Subject: Re: [bug#74570] [PATCH] gnu: xterm: Update to 395.
Date: Mon, 09 Dec 2024 09:43:42 +0900

Hi,

kiasoc5 <kiasoc5 <at> disroot.org> writes:

> On 12/7/24 09:17, Maxim Cournoyer wrote:
>> Hi Zheng,
>> Zheng Junjie <zhengjunjie <at> iscas.ac.cn> writes:
>> 
>>> Now the xvfb-run test depends on xterm, so we can't simply update xterm,
>>> we might add a new xterm package and hide the original xterm for
>>> xvfb-run only.
>> Yes, we could rename the current 'xterm' variable to xterm/pinned,
>> make
>> it hidden, then proceed to add a new 'xterm' package which inherits from
>> it, at its latest version.
>> 
>
> I agree with making a separate xterm package for tests. Since naming
> is one of the hardest things in computer science, how about naming the
> pinned version 'xterm-for-tests' instead?

I don't have a strong preference, but note that in general I think
naming things based on what they *are*, rather than what they are *used*
for, is a better practice, as we can't reasonably foresee all future use
cases.

There is also a recent convention to use the '/pinned' suffix for
packages that shouldn't be updated often such as with our
git-minimal/pinned one [0]

[0]  https://issues.guix.gnu.org/61078

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.