X-Loop: help-debbugs@HIDDEN Subject: bug#74630: 31.0.50; emacs-mail-verify Resent-From: Richard Stallman <rms@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Sun, 01 Dec 2024 05:40:02 +0000 Resent-Message-ID: <handler.74630.B.17330315496605 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 74630 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 74630 <at> debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN Reply-To: rms@HIDDEN Received: via spool by submit <at> debbugs.gnu.org id=B.17330315496605 (code B ref -1); Sun, 01 Dec 2024 05:40:02 +0000 Received: (at submit) by debbugs.gnu.org; 1 Dec 2024 05:39:09 +0000 Received: from localhost ([127.0.0.1]:49894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tHcfk-0001iR-Nf for submit <at> debbugs.gnu.org; Sun, 01 Dec 2024 00:39:09 -0500 Received: from lists.gnu.org ([209.51.188.17]:36898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <rms@HIDDEN>) id 1tHcfj-0001iJ-5l for submit <at> debbugs.gnu.org; Sun, 01 Dec 2024 00:39:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <rms@HIDDEN>) id 1tHcfh-0000Ez-KJ for bug-gnu-emacs@HIDDEN; Sun, 01 Dec 2024 00:39:06 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <rms@HIDDEN>) id 1tHcfg-0007QI-Mc for bug-gnu-emacs@HIDDEN; Sun, 01 Dec 2024 00:39:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Date:Subject:To:From:mime-version:in-reply-to: references; bh=SjTwXJNSNNzsB4i+7hiadWAaoCMRGNDOM4dQHF1V3GY=; b=B6ruWM+woEDUlm PDWqtcuph/ZIipWvLPBlgt72tgGkQSHS4HFuet9Yx8qbnz6zcA89b5t+b8rcM/20iFCJeRQQLFQRp nVkVsYaLVNZH8OC38HxSOsPbADex6nXF0Qz1vpano7jFrfQRMijPpkVmjvuURCa2YjNmyHjQKBPrn Pg3wVZfdRZPI/R1hRwV2zDkTi2o61ShPOc6OsX9wkQIoywHFjYm2nuAw22LLcCdPCqp4Bg5t64Ezo TZCNJoSTDHLXcsFdWlIvoINM88tSL0QfDloCr9AqcnXoSGTMqQKH+uc5zR3SP3ysPbzsm31pLc1s6 7IZBROOcPm7IAi6gb1bA==; Received: from rms by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from <rms@HIDDEN>) id 1tHcfc-0004mm-UT; Sun, 01 Dec 2024 00:39:02 -0500 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman <rms@HIDDEN> Message-Id: <E1tHcfc-0004mm-UT@HIDDEN> Date: Sun, 01 Dec 2024 00:39:00 -0500 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) The doc string of `emacs-mail-verify' does not say how it indicates that the signature is valid, or how it indicates that the signature is not valid. Would someone please add that to its doc string? In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 2.24.33, cairo version 1.16.0) of 2024-08-01 built on freetop Repository revision: a2c439db687774f7b57959c39560993579c5d1bd Repository branch: master System Description: Trisquel GNU/Linux Aramo (11.0) Configured using: 'configure 'CFLAGS=-O0 -g' --with-gnutls=ifavailable' Configured features: CAIRO DBUS FREETYPE GIF GLIB GPM GSETTINGS HARFBUZZ JPEG LIBOTF LIBSELINUX LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XINPUT2 XPM GTK2 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: ELisp/l Minor modes in effect: bug-reference-prog-mode: t gpm-mouse-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: linux auto-encryption-mode: t auto-compression-mode: t abbrev-mode: t Load-path shadows: None found. Features: (shadow emacsbug epa-file vc-git diff-mode track-changes easy-mmode vc-dispatcher bug-reference find-func shortdoc comp-common rx apropos rmail-spam-filter rmailedit rmailsort undigest help-fns radix-tree rect jka-compr display-line-numbers novice mule-util cal-move cal-menu calendar cal-loaddefs mail-extr ffap quail epa-mail etags fileloop generator xref project rmailkwd cl-extra help-mode shell pcomplete thingatpt files-x grep compile comint ansi-osc ansi-color ring dabbrev ispell rmailout mailalias misearch multi-isearch textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check shr pixel-fill kinsoku url-file svg xml dom qp rmailmm message sendmail yank-media puny rfc822 mml mml-sec epa epg epg-config gnus-util text-property-search time-date mm-decode mm-bodies mm-encode mailabbrev gmm-utils mailheader mail-parse rfc2231 dired-aux dired dired-loaddefs t-mouse term/linux view derived disp-table advice rmailsum rmail rfc6068 rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils finder-inf info osm-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs icons password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo gtk x-toolkit xinput2 x multi-tty move-toolbar make-network-process emacs) Memory information: ((conses 16 622712 118122) (symbols 48 15101 10) (strings 32 79308 9073) (string-bytes 1 1459899) (vectors 16 57657) (vector-slots 8 1411286 252804) (floats 8 142 345) (intervals 56 69856 759) (buffers 984 77)) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] -- Dr Richard Stallman (https://stallman.org) Chief GNUisance of the GNU Project (https://gnu.org) Founder, Free Software Foundation (https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org)
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: rms@HIDDEN Subject: bug#74630: Acknowledgement (31.0.50; emacs-mail-verify) Message-ID: <handler.74630.B.17330315496605.ack <at> debbugs.gnu.org> References: <E1tHcfc-0004mm-UT@HIDDEN> X-Gnu-PR-Message: ack 74630 X-Gnu-PR-Package: emacs Reply-To: 74630 <at> debbugs.gnu.org Date: Sun, 01 Dec 2024 05:40:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 74630 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 74630: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D74630 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN Subject: bug#74630: 31.0.50; emacs-mail-verify Resent-From: Eli Zaretskii <eliz@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Sun, 01 Dec 2024 12:57:02 +0000 Resent-Message-ID: <handler.74630.B74630.173305779229906 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 74630 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: rms@HIDDEN Cc: 74630 <at> debbugs.gnu.org Received: via spool by 74630-submit <at> debbugs.gnu.org id=B74630.173305779229906 (code B ref 74630); Sun, 01 Dec 2024 12:57:02 +0000 Received: (at 74630) by debbugs.gnu.org; 1 Dec 2024 12:56:32 +0000 Received: from localhost ([127.0.0.1]:50657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tHjV1-0007mH-6G for submit <at> debbugs.gnu.org; Sun, 01 Dec 2024 07:56:31 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tHjUx-0007ly-Rh for 74630 <at> debbugs.gnu.org; Sun, 01 Dec 2024 07:56:28 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tHjSh-0001VI-Oa for 74630 <at> debbugs.gnu.org; Sun, 01 Dec 2024 07:54:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=LrWIYf9Lnzqrg+awj5mgmiEikjq1myW3LSfA0BuQO6o=; b=iJA5zExY9J3X OZX/SLjtOu/myt0wjyoRTg3g3T2j0zqKfCc9Ax8fMVEnle2SDKBZ0kTovubxixro6FjQOU0Hh71b/ 4hvDLQpuvNQBUjZ7EJHeKwaGbt2dLKT/Sfve6+tVonFdEUNxHZYvT26IvCcBIqpLsCm0kFQIGU3/E yO4T/rjiGVLG+7+QxAMNKSy6nDrQWgmknHKf3pED2O+LPtjkQI8y33Npgw9wd1VmSSq1/fsO4/N76 +OqftJRbNYn5zofxhdwW24H1qFsQc0v85uTVmQPdhlsG1HDAsPAICFD50tDc702q1mZyOKrGl1wNT MvGPTvia/z2iOjWB1nAqzw==; Date: Sun, 01 Dec 2024 14:53:46 +0200 Message-Id: <868qsz5ztx.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> In-Reply-To: <E1tHcfc-0004mm-UT@HIDDEN> (message from Richard Stallman on Sun, 01 Dec 2024 00:39:00 -0500) References: <E1tHcfc-0004mm-UT@HIDDEN> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Richard Stallman <rms@HIDDEN> > Date: Sun, 01 Dec 2024 00:39:00 -0500 > > > The doc string of `emacs-mail-verify' does not say how it > indicates that the signature is valid, or how it indicates > that the signature is not valid. I guess you meant epa-mail-verify? > Would someone please add that to its doc string? Not sure what you expected the doc string to say. Would the below be enough? Verify OpenPGP cleartext signed messages in the current buffer. The buffer is expected to contain a mail message. If the verification fails, the command signals an error. The last sentence describes the following snippet from epa-verify-region, which epa-mail-verify calls: (unless (epg-context-result-for context 'verify) (error "Unable to verify region")) There are also other reasons to signal an error, e.g. if there are no "-----BEGIN PGP SIGNED MESSAGE-----" line. But eventually, all of the problems cause an error. If this is somehow not detailed enough, then I'm afraid someone else, who knows the code, will have to improve the doc string, because I could see no clear description in the code what values could the context-result have and what is the meaning of each result. Maybe I missed something.
X-Loop: help-debbugs@HIDDEN Subject: bug#74630: 31.0.50; emacs-mail-verify Resent-From: Richard Stallman <rms@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Wed, 04 Dec 2024 06:12:02 +0000 Resent-Message-ID: <handler.74630.B74630.173329268619533 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 74630 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii <eliz@HIDDEN> Cc: 74630 <at> debbugs.gnu.org Reply-To: rms@HIDDEN Received: via spool by 74630-submit <at> debbugs.gnu.org id=B74630.173329268619533 (code B ref 74630); Wed, 04 Dec 2024 06:12:02 +0000 Received: (at 74630) by debbugs.gnu.org; 4 Dec 2024 06:11:26 +0000 Received: from localhost ([127.0.0.1]:33801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tIibd-00054z-UI for submit <at> debbugs.gnu.org; Wed, 04 Dec 2024 01:11:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <rms@HIDDEN>) id 1tIiba-00054d-Hg for 74630 <at> debbugs.gnu.org; Wed, 04 Dec 2024 01:11:24 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <rms@HIDDEN>) id 1tIiZP-00032B-2b for 74630 <at> debbugs.gnu.org; Wed, 04 Dec 2024 01:09:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Date:References:Subject:In-Reply-To:To:From: mime-version; bh=6ntLAwHC4SCWwAhWNA+SDOG/7z/1NG9h3uqvYOD9BCI=; b=pCLcZujRo4MK jy8VwoBa2dNbNxtyDqkEyJVgnqFN0bI6KoEsCPy3fLTs5nVSLomA4rYEO5t+EAoXFsx6TaQZzvWi3 7Y8ulSBYLqj1m2aY/j0hhyTAGl25jCq70IdIR1xl42E9VTQzgx8zV6wJWbWNB1SngqR9M85XBqfNa ab9O5IjC3A4/+7S2PTliNss7v/yj1PleYkOoTIz6A0W7Oac/vaIL3ohCKNu+ByleYCP5cZ5qAbSdc GGBy7sQ1zaNEfS54Z1VbzZ0COpx/SNfLDxR6Vtz21kl5WmQwoNhpx53uqur9ngJo+Ufp1d8FLiDrZ jK2AWL3wo8aU40kxFIyjgA==; Received: from rms by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from <rms@HIDDEN>) id 1tIiZN-0001hB-LT; Wed, 04 Dec 2024 01:09:05 -0500 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman <rms@HIDDEN> In-Reply-To: <868qsz5ztx.fsf@HIDDEN> (message from Eli Zaretskii on Sun, 01 Dec 2024 14:53:46 +0200) References: <E1tHcfc-0004mm-UT@HIDDEN> <868qsz5ztx.fsf@HIDDEN> Message-Id: <E1tIiZN-0001hB-LT@HIDDEN> Date: Wed, 04 Dec 2024 01:09:05 -0500 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > I guess you meant epa-mail-verify? Oops, yes. > Not sure what you expected the doc string to say. Would the below be > enough? > Verify OpenPGP cleartext signed messages in the current buffer. > The buffer is expected to contain a mail message. > If the verification fails, the command signals an error. That is better, becauee it gives enough information to deduce what indicates success. But the user should need to do any deduction about that, let alone read code and guess what some other functions do. To make the doc string truly clear, it should say explicitly what indicates success. That way the user can know, rather than just supposing. Should the function be changed to display a message, "Signature verified", on success? Do some people run this function from a hook for every message and want to see output only in case of failure? Should it a value indicating success or failure? -- Dr Richard Stallman (https://stallman.org) Chief GNUisance of the GNU Project (https://gnu.org) Founder, Free Software Foundation (https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org)
X-Loop: help-debbugs@HIDDEN Subject: bug#74630: 31.0.50; emacs-mail-verify Resent-From: Eli Zaretskii <eliz@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Wed, 04 Dec 2024 13:27:02 +0000 Resent-Message-ID: <handler.74630.B74630.17333188124858 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 74630 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: rms@HIDDEN Cc: 74630 <at> debbugs.gnu.org Received: via spool by 74630-submit <at> debbugs.gnu.org id=B74630.17333188124858 (code B ref 74630); Wed, 04 Dec 2024 13:27:02 +0000 Received: (at 74630) by debbugs.gnu.org; 4 Dec 2024 13:26:52 +0000 Received: from localhost ([127.0.0.1]:34657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tIpP1-0001GF-Hu for submit <at> debbugs.gnu.org; Wed, 04 Dec 2024 08:26:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tIpOz-0001G0-ET for 74630 <at> debbugs.gnu.org; Wed, 04 Dec 2024 08:26:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tIpOd-0003gb-Jt for 74630 <at> debbugs.gnu.org; Wed, 04 Dec 2024 08:26:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=UqlNJwskhKvkFMEAhO8WyLm2HWqnfPoRhmw1Qv5fk3U=; b=rgZ9lTVsGMxZ 3FWJM8TXxBqbyxth+PV+e2yqFOawvj7qtiYYqnR/eTnMplOdZXK4djuZf5T+4xlfZsuTojI670Fum NhWoRykprOWoUlEx86j8kmyDdxg7Ud1Kmhr7g0LzyP0Zo8HmapemxVtQa8QhDsEzOwHR7Mk34nNWe 4N/Yp9lc+hkyINdzOwBU1hzSblJKB4dmEaqkbS+NgR0DZXOOAL9O8b+VkcXSZBt9dEV1Xdd+Gkvfy Jq+Z1ZjatxlcY6d6zNdViulaWc6n0TLPAI5sUnoT8zfN1O1cUz9VMxRJ8OXf+0fOAtKCFuZpBdCfE gLkj/MpH5VJpQGL7bHhl7g==; Date: Wed, 04 Dec 2024 15:26:15 +0200 Message-Id: <864j3j1sw8.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> In-Reply-To: <E1tIiZN-0001hB-LT@HIDDEN> (message from Richard Stallman on Wed, 04 Dec 2024 01:09:05 -0500) References: <E1tHcfc-0004mm-UT@HIDDEN> <868qsz5ztx.fsf@HIDDEN> <E1tIiZN-0001hB-LT@HIDDEN> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Richard Stallman <rms@HIDDEN> > Cc: 74630 <at> debbugs.gnu.org > Date: Wed, 04 Dec 2024 01:09:05 -0500 > > > Not sure what you expected the doc string to say. Would the below be > > enough? > > > Verify OpenPGP cleartext signed messages in the current buffer. > > The buffer is expected to contain a mail message. > > > If the verification fails, the command signals an error. > > That is better, becauee it gives enough information to deduce what > indicates success. But the user should need to do any deduction about > that, let alone read code and guess what some other functions do. Thanks, I installed a change along those lines. > To make the doc string truly clear, it should say explicitly what > indicates success. That way the user can know, rather than just > supposing. I don't know how to describe success in this case, except as the lack of an error. > Should the function be changed to display a message, "Signature verified", > on success? It says "Verifying...done", which I think is enough (and quite standard in Emacs). > Do some people run this function from a hook for every message and > want to see output only in case of failure? See above: it displays a message in case of success as well. > Should it a value indicating success or failure? I don't know. The values of the relevant functions don't seem to be documented.
X-Loop: help-debbugs@HIDDEN Subject: bug#74630: 31.0.50; emacs-mail-verify Resent-From: Richard Stallman <rms@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Fri, 20 Dec 2024 05:26:01 +0000 Resent-Message-ID: <handler.74630.B74630.173467232010349 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 74630 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii <eliz@HIDDEN> Cc: 74630 <at> debbugs.gnu.org Reply-To: rms@HIDDEN Received: via spool by 74630-submit <at> debbugs.gnu.org id=B74630.173467232010349 (code B ref 74630); Fri, 20 Dec 2024 05:26:01 +0000 Received: (at 74630) by debbugs.gnu.org; 20 Dec 2024 05:25:20 +0000 Received: from localhost ([127.0.0.1]:41280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tOVVo-0002gr-50 for submit <at> debbugs.gnu.org; Fri, 20 Dec 2024 00:25:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <rms@HIDDEN>) id 1tOVVl-0002bz-PY for 74630 <at> debbugs.gnu.org; Fri, 20 Dec 2024 00:25:18 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <rms@HIDDEN>) id 1tOVTZ-0003hY-76 for 74630 <at> debbugs.gnu.org; Fri, 20 Dec 2024 00:23:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Date:References:Subject:In-Reply-To:To:From: mime-version; bh=zFLXaKKidZfaRSivSS8EW2XXKNOUsxkMqnnD9XHlwiA=; b=fzjGNaUKxNwR yfxk6amwG/ARMb6Phw5mu4iNlkIobf9WxMe0X/Fv2Pe9JRZif+8rULEsL2v9fpzpxsu/bAqr+cL6K h8Mf9RLB6zBTWsJV/rH8SyGoZXlfNxabL1lqd1cH/6DbtITpkS6E/0GXyIFtBDKQX7tqgRUlPUX7N OT7D122KCwXlu5ToIS423sbNUDCaKyd1cAAiA66Zt5/HTSKD8Xd9n12cAcWe4rxuWGshGFuqBB2+e JBLDxzgnJVizaw3fr3pKCqljrCI2VjIFpxTXf8y+UAwKrkBCYcYiveRE38Ot9deX5zNwHEENb07Vi D7SjllKJzw1+m1/Z1qIzPQ==; Received: from rms by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from <rms@HIDDEN>) id 1tOVTY-0001KC-95; Fri, 20 Dec 2024 00:23:00 -0500 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman <rms@HIDDEN> In-Reply-To: <864j3j1sw8.fsf@HIDDEN> (message from Eli Zaretskii on Wed, 04 Dec 2024 15:26:15 +0200) References: <E1tHcfc-0004mm-UT@HIDDEN> <868qsz5ztx.fsf@HIDDEN> <E1tIiZN-0001hB-LT@HIDDEN> <864j3j1sw8.fsf@HIDDEN> Message-Id: <E1tOVTY-0001KC-95@HIDDEN> Date: Fri, 20 Dec 2024 00:23:00 -0500 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > > Do some people run this function from a hook for every message and > > want to see output only in case of failure? > See above: it displays a message in case of success as well. I agree, that should be enough. (I didn't know it did that.) Perhaps document that in the doc string: On successful verification, displays ""Verifying...done" in echo area. Perhaps it should return t if it succeeds in verifying, and nil otherwise. -- Dr Richard Stallman (https://stallman.org) Chief GNUisance of the GNU Project (https://gnu.org) Founder, Free Software Foundation (https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org)
X-Loop: help-debbugs@HIDDEN Subject: bug#74630: 31.0.50; emacs-mail-verify Resent-From: Eli Zaretskii <eliz@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Fri, 20 Dec 2024 07:46:02 +0000 Resent-Message-ID: <handler.74630.B74630.17346807184093 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 74630 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: rms@HIDDEN Cc: 74630 <at> debbugs.gnu.org Received: via spool by 74630-submit <at> debbugs.gnu.org id=B74630.17346807184093 (code B ref 74630); Fri, 20 Dec 2024 07:46:02 +0000 Received: (at 74630) by debbugs.gnu.org; 20 Dec 2024 07:45:18 +0000 Received: from localhost ([127.0.0.1]:41495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tOXhG-00013x-G9 for submit <at> debbugs.gnu.org; Fri, 20 Dec 2024 02:45:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tOXhE-00013h-Hx for 74630 <at> debbugs.gnu.org; Fri, 20 Dec 2024 02:45:17 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tOXh8-0005yQ-Ue for 74630 <at> debbugs.gnu.org; Fri, 20 Dec 2024 02:45:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=oiW+BcaZMZFBvpfNVCvApR3rgg1dv0K2PIVFKd6J6E8=; b=SG4sntpbEUWs JzfE6Dv9WYRsZHAUgEQFo1B3mdSSCBT5z3rIkQ39UMWVoD7nToeR1juvIOrCRFf2AY4o2WIEhOf6o 31NWd50M7AKbU3nJwhuDTzXaXPPuADJhgzK/2XYbQFc/ecXV5Y8McGllpg/wlYeFyNe0a+n0KK3d/ qdwJxJ6iT5RPgQ0orTC6bg90VB9dN8VnCtgdudbvmF9o0/UlPUbLvwT7CohL8UECREBQEbXZOo+2r oFECIQ/Xv0d4yY2SrfIpzDLdFhxGZstOir6gWNgBjCyReruCmrpkHuji2l4NIUyDSZZPpVKmTwib3 p23/bGpZqGU8pKlWUHKLGg==; Date: Fri, 20 Dec 2024 09:45:03 +0200 Message-Id: <86frmikdc0.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> In-Reply-To: <E1tOVTY-0001KC-95@HIDDEN> (message from Richard Stallman on Fri, 20 Dec 2024 00:23:00 -0500) References: <E1tHcfc-0004mm-UT@HIDDEN> <868qsz5ztx.fsf@HIDDEN> <E1tIiZN-0001hB-LT@HIDDEN> <864j3j1sw8.fsf@HIDDEN> <E1tOVTY-0001KC-95@HIDDEN> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Richard Stallman <rms@HIDDEN> > Cc: 74630 <at> debbugs.gnu.org > Date: Fri, 20 Dec 2024 00:23:00 -0500 > > > > Do some people run this function from a hook for every message and > > > want to see output only in case of failure? > > > See above: it displays a message in case of success as well. > > I agree, that should be enough. > (I didn't know it did that.) > > Perhaps document that in the doc string: > > On successful verification, displays ""Verifying...done" in echo area. That sounds redundant, as the message seems to speak for itself? > Perhaps it should return t if it succeeds in verifying, and nil otherwise. I thought about it, but the functions it calls don't have their return value documented, so doing that seems to require a serious surgery of the code with which I'm not familiar.
Received: (at control) by debbugs.gnu.org; 2 Jan 2025 01:56:06 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 01 20:56:06 2025 Received: from localhost ([127.0.0.1]:41324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tTARS-00025y-C7 for submit <at> debbugs.gnu.org; Wed, 01 Jan 2025 20:56:06 -0500 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]:50221) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tTARP-00024c-VS for control <at> debbugs.gnu.org; Wed, 01 Jan 2025 20:56:04 -0500 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-5d3cf094768so17607991a12.0 for <control <at> debbugs.gnu.org>; Wed, 01 Jan 2025 17:56:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735782958; x=1736387758; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=IruLw/GkfMRcdw8L1wAX4bQaJ/IFAbrBGIhKEmAeK2E=; b=RJ0vi2Ow2z/BKfJ4iChLr1Y9KMuhOS1am4p5XTkdNOOKnQRU5aHs8gUXwVXOuPprYM AdtUKhrWo2JyVujUajSMCSx5WquNd7Icunr+c63EN506sbEPzMoDhiqq14NYcCI4ZxhD z7b2wFFLEo9d0ERmZIPwGxwxZRG7l+QxQb5uQYGeb6W+4/biWRjVm5sSLWInOE7cKgEu R5B30ZGaNamQVbgur1MslQYWJS6nVo7pJDxkd93imKJwzlonKrlacX8Ughr22giGd9/z lvW6xWv77IWwyWFF6pF5vDC7Sqogxl9DRsmxxa+35t7XuyL9tpIofJC/fLz1HND7y4E5 47CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735782958; x=1736387758; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=IruLw/GkfMRcdw8L1wAX4bQaJ/IFAbrBGIhKEmAeK2E=; b=c6yBcMoxOfDG3uFUTnog9W1o8H2tpHizh2uuv/rOtKkhdmqgvrxJB/qDKDf05b+mL0 VnaQqn1btX0I1+9SO8su/PO3ueW9KWQO4C4p5iwjTilyR7F0fJXDiCH/yGqkBxOm5fng lgfr+Ra2i1DgnyebdDkCOW442I27nGR99teldrvinFcKYQo6kvMzWR2xrvMwd7s6X5c9 rDtK9pOswPgHRQIQ8IC58C3Pg1/cQCwp9jf+jxxYKDfHJTSeJjnI8PVdAJPcyAqmmgYL 3APLprbZZw6GH9Ht5aptqb3g6N+jYSIND9cJRRA/dymxbw+cY0ZTumKYd0E9Tk83iC+0 gTzQ== X-Gm-Message-State: AOJu0Yyek0h/Tn5P078tMFuYTCIGUCEbYxTWQ0QTl40OoKXAWUmR+s3C hLGfhZQpwut6xdEl5KqPEeE5JGEfH7ORQke8alRSnr3qq96fkR0JB018sIOp8Xwz5J7q9oFG45z k09vwHZ7vqem1H2ngIESfvLCToLgG5nmj X-Gm-Gg: ASbGnctjEWSks7Kn3HbzsWSboalI/mMnSoh0lCUUYHUFobGkEcXrKe3B2WY8dzNj2gp F/vuNzcBLUj58cSHxQ4P/hJaZ4PRoq4QNTdsp65NI X-Google-Smtp-Source: AGHT+IFW6x2m1K2ce5iWp4wN8FboY/2JO5ts41AuloXRV5fBihNSsyrhmIOoC43Nx7FcoMfvx3HZKFx1nnBhyh6hBPg= X-Received: by 2002:a05:6402:348c:b0:5ce:d028:e11 with SMTP id 4fb4d7f45d1cf-5d81ddb0d46mr38494313a12.17.1735782957897; Wed, 01 Jan 2025 17:55:57 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 1 Jan 2025 19:55:57 -0600 From: Stefan Kangas <stefankangas@HIDDEN> MIME-Version: 1.0 Date: Wed, 1 Jan 2025 19:55:57 -0600 Message-ID: <CADwFkmnWcbxPeqaiqHjgF1kyhBCqtsfvF2rg3O8cwaXbqqy-mw@HIDDEN> Subject: control message for bug #74630 To: control <at> debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) severity 74630 wishlist quit
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.