GNU bug report logs - #74735
31.0.50; Commit 986621ae1ff4d3cfad31adb20216f1f71ce0747c broke org-ql
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: emacs;
Reported by: Visuwesh <visuweshm@HIDDEN>; dated Sun, 8 Dec 2024 11:10:02 UTC;
Maintainer for emacs is
bug-gnu-emacs@HIDDEN.
Message received at 74735 <at> debbugs.gnu.org:
Received: (at 74735) by debbugs.gnu.org; 14 Dec 2024 01:44:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 13 20:44:34 2024
Received: from localhost ([127.0.0.1]:44888 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tMHCr-0001Hh-K9
for submit <at> debbugs.gnu.org; Fri, 13 Dec 2024 20:44:33 -0500
Received: from mail-pl1-f195.google.com ([209.85.214.195]:56370)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <visuweshm@HIDDEN>) id 1tMHCn-0001HW-NZ
for 74735 <at> debbugs.gnu.org; Fri, 13 Dec 2024 20:44:32 -0500
Received: by mail-pl1-f195.google.com with SMTP id
d9443c01a7336-2163b0c09afso21763265ad.0
for <74735 <at> debbugs.gnu.org>; Fri, 13 Dec 2024 17:44:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1734140609; x=1734745409; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=whKW4jWl84qXOX5bLCSSvccxvVbdpOCORD02ExQeKKA=;
b=RRYMVsbZk3CEAeiCvwA7ZVUyN43jPNTRXI8VmfSBftipxTyXWSBJrdy9dNrQVJdScG
C8bYM9mjbGYIlCi61+wLl1vmp6xzl0Q3XSxqSnh9ZRVEh/6OfcskYGb/IPa1+m1hhEs4
wRX8JvprNfqCEBFVRMe40bFuQt8hRArrlYNmnekjRSxeccorLMzKYuNGVqtNkQIHkjI2
lgu2yDMIK7YNTuNRQtHVrZFXXctdQSP2M6X4Xw5clRU9nZBy73WcemIYM7hyf27ymPVB
V9107Yb+qg+ILQOyUjDCVysLlZ8gKLkZEcjxr/mDHMF23GizKaraTvimNDuqEW136zg2
yfXA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1734140609; x=1734745409;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
:to:cc:subject:date:message-id:reply-to;
bh=whKW4jWl84qXOX5bLCSSvccxvVbdpOCORD02ExQeKKA=;
b=t0hAY0HbJWvZs2hsqCU4zGLa2xbM9+FBqUN8ShOKLdy8MGWZ25r1Gpz8umGSbFp0fG
2fL+7JD06wDFZN9VDZvRLhrqft6E0tiwwDsIEyhUpJMog16DLYnPDAirFiRfImg9bJud
3e3TWl3rKd0Moi5NVqVSPxBhoXGLqepS+wilhGLgqACTrzWYj1haAPO0kKf7PamWKy1c
2QIVMy0+jqUxAuqquttNPmGkrJUYcxK/Ym41loKQyJx3mukPo5qlPk2DF0ndxRDGswAD
+EweQCltQUJjM8f+rLPwgsLWPIrNtezLKvaYmKHo6RVHqhyNkImybahZk4RgHXW84OyD
7i9g==
X-Gm-Message-State: AOJu0YzjG5fLWzFmNIzbLPhLFUgSWS0fmDVxY+cg4wBJzBudMVBguBVn
0hQ9WaloSfmsEAD1oc2Rfp2zr/dVANFNy1DSdzXC677i9IT7qpZk
X-Gm-Gg: ASbGnct2HkB5rLMgHyE6GNmZ6HNTDIIGbDlm+xdvYw90DFE1Np22mPZPL+BYovtlMOr
/NFczgKlCusZ6suXzK0MbtAa1I+vEIywX72DapkORot/cwHaSmWW4DJ1GggwvrVKLDY6K5fn6cP
B515mNCrXapFz4mNf/13T/ZxEo3PYud8uzUDne+KuhppEtlj6ZAv2RjU/o5ttLhMByUsDVfdLhj
Ll3Zi/r4oScpVj4LMAAS8cdnYvBJVz3o6rQw/5FBxABzG4i3lkKVA==
X-Google-Smtp-Source: AGHT+IEeCLJk2tCkeiHjPsyAHS2euarB96h2Yl0hZNJVxqZJ7jHO4vrQQrr5XMJ3HDsBqik6BspP8Q==
X-Received: by 2002:a17:902:f688:b0:216:4cc2:b1e0 with SMTP id
d9443c01a7336-218929d71f7mr54393395ad.20.1734140608550;
Fri, 13 Dec 2024 17:43:28 -0800 (PST)
Received: from localhost ([115.240.90.130]) by smtp.gmail.com with ESMTPSA id
d9443c01a7336-218a1e501c5sm3780585ad.135.2024.12.13.17.43.26
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 13 Dec 2024 17:43:27 -0800 (PST)
From: Visuwesh <visuweshm@HIDDEN>
To: Stefan Monnier <monnier@HIDDEN>
Subject: Re: bug#74735: 31.0.50; Commit
986621ae1ff4d3cfad31adb20216f1f71ce0747c broke org-ql
In-Reply-To: <jwvbjxfp6re.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message
of "Fri, 13 Dec 2024 17:21:07 -0500")
References: <87r06i8m8v.fsf@HIDDEN> <jwvbjxfp6re.fsf-monnier+emacs@HIDDEN>
Date: Sat, 14 Dec 2024 07:13:23 +0530
Message-ID: <871pyb11l0.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 74735
Cc: 74735 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
[=E0=AE=B5=E0=AF=86=E0=AE=B3=E0=AF=8D=E0=AE=B3=E0=AE=BF =E0=AE=9F=E0=AE=BF=
=E0=AE=9A=E0=AE=AE=E0=AF=8D=E0=AE=AA=E0=AE=B0=E0=AF=8D 13, 2024] Stefan Mon=
nier wrote:
>> The recent change you made in
>>
>> commit 986621ae1ff4d3cfad31adb20216f1f71ce0747c
>> Author: Stefan Monnier <monnier@HIDDEN>
>> Date: Tue Nov 12 23:12:07 2024 -0500
>>
>> (with-peg-rules): Build proper `peg-function`s
>>
>> * lisp/progmodes/peg.el (with-peg-rules): Use the new (FUNC EXP)
>> feature in `cl-labels`.
>>
>> broke org-ql's PEG parser. I tried to reproduce it with the number
>> parser example given in the Elisp Info manual but failed. With the
>> above change, I get an assertion error when I try to use org-ql-find:
>>
>> Debugger entered--Lisp error: (cl-assertion-failed (lexical-binding nil))
>
> Thanks. Until this is fixed on `master`, the patch below will fix
> `org-ql` to use lexical-binding for that code (like it already does for
> all the rest of the code).
Thanks! I tried this exact change but it still erred. Now, the error
went away. I guess I did not re-eval the relevant functions properly.
> [ It also removes a NUL byte from the file which caused some tools to
> treat it as a binary file. ]
Thanks for catching this! I always wondered why the modeline did not
say 'U' for the encoding.
> diff --git a/org-ql.el b/org-ql.el
> index f3b7715..654da49 100644
> --- a/org-ql.el
> +++ b/org-ql.el
> @@ -863,7 +863,7 @@ respectively."
> (zero-or-more (not (any "\n\":"))))
> (zero-or-more (not (any "\n\":")))))
> (group (zero-or-more (not (any "\n")))) "\n"
> - (63 (group (*\? (not (any "."))) "\n"))
> + (63 (group (*\? (not (any "\0"))) "\n"))
> (zero-or-more (any " "))
> "#+end_src")
> t))
> @@ -1003,7 +1003,8 @@ value of `org-ql-predicates')."
> (peg-run (peg ,(caar pexs))
> (lambda (failures)
> (when org-ql-signal-=
peg-failure
> - (peg-signal-failur=
e failures)))))))))
> + (peg-signal-failur=
e failures)))))
> + t))))
> (pcase parsed-sexp
> (`(,one-predicate) one-predicate)
> (`(,_ . ,_) (cons boolean (reverse parsed-sexp=
)))
Shall I notify Adam of this change?
Information forwarded
to bug-gnu-emacs@HIDDEN
:
bug#74735
; Package emacs
.
Full text available.
Message received at 74735 <at> debbugs.gnu.org:
Received: (at 74735) by debbugs.gnu.org; 13 Dec 2024 22:21:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 13 17:21:25 2024
Received: from localhost ([127.0.0.1]:44484 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tME2H-0007qo-1i
for submit <at> debbugs.gnu.org; Fri, 13 Dec 2024 17:21:25 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:34381)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1tME2E-0007qT-D8
for 74735 <at> debbugs.gnu.org; Fri, 13 Dec 2024 17:21:23 -0500
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2397A10004A;
Fri, 13 Dec 2024 17:21:15 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1734128468;
bh=X0odgkY1gyZdU5P1LL9yiZ4STB/zwpBMc2jbic7exDk=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=DwMgpUFjO9Xmt9NOJPzce5YEpd4BpaoPWgpAlcXZERYSwgXRoFEyo7Kav1I1L+fmA
nhJWKQXLkHnnq0sHMtaRhsTZ3Ota7Yms+/VSOpA4vLrkQXwTgrxC++I9D42nnrfHwT
02dYXe1g3OSfrzgux6vF+chhN5Iq4EzXo8qfEHphuvTpWgDR4nV7lnMR1NAQjEhrYR
jasm7hhipVLHK7SOpbzkohBEycTiZEu6CkyHqzdjiJLhPY4+ZkreCJcgug6+Pu7COe
aPBolYHqo7a6EaT/3vcjVw5kg2aNbkDTwBTUjxoZ7U3oiH4WKdZo+0H372Ch2XGwX9
bcQraQv3/x3kQ==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9AC11100042;
Fri, 13 Dec 2024 17:21:08 -0500 (EST)
Received: from alfajor (104-195-225-43.cpe.teksavvy.com [104.195.225.43])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 46F5012049E;
Fri, 13 Dec 2024 17:21:08 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Visuwesh <visuweshm@HIDDEN>
Subject: Re: bug#74735: 31.0.50; Commit
986621ae1ff4d3cfad31adb20216f1f71ce0747c broke org-ql
In-Reply-To: <87r06i8m8v.fsf@HIDDEN> (Visuwesh's message of "Sun, 08 Dec
2024 16:39:20 +0530")
Message-ID: <jwvbjxfp6re.fsf-monnier+emacs@HIDDEN>
References: <87r06i8m8v.fsf@HIDDEN>
Date: Fri, 13 Dec 2024 17:21:07 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -2.004 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain ENA_SUBJ_LONG_WORD 2.2 Subject has a very long word
NULL_IN_BODY 1.596 Message has NUL (ASCII 0) byte in message
PP_MIME_FAKE_ASCII_TEXT 0.241 MIME text/plain claims to be ASCII but isn't
X-SPAM-LEVEL:
X-Spam-Score: -1.6 (-)
X-Debbugs-Envelope-To: 74735
Cc: 74735 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)
--=-=-=
Content-Type: text/plain
> The recent change you made in
>
> commit 986621ae1ff4d3cfad31adb20216f1f71ce0747c
> Author: Stefan Monnier <monnier@HIDDEN>
> Date: Tue Nov 12 23:12:07 2024 -0500
>
> (with-peg-rules): Build proper `peg-function`s
>
> * lisp/progmodes/peg.el (with-peg-rules): Use the new (FUNC EXP)
> feature in `cl-labels`.
>
> broke org-ql's PEG parser. I tried to reproduce it with the number
> parser example given in the Elisp Info manual but failed. With the
> above change, I get an assertion error when I try to use org-ql-find:
>
> Debugger entered--Lisp error: (cl-assertion-failed (lexical-binding nil))
Thanks. Until this is fixed on `master`, the patch below will fix
`org-ql` to use lexical-binding for that code (like it already does for
all the rest of the code).
[ It also removes a NUL byte from the file which caused some tools to
treat it as a binary file. ]
Stefan
--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline; filename=org-ql.patch
Content-Transfer-Encoding: 8bit
diff --git a/org-ql.el b/org-ql.el
index f3b7715..654da49 100644
--- a/org-ql.el
+++ b/org-ql.el
@@ -863,7 +863,7 @@ respectively."
(zero-or-more (not (any "\n\":"))))
(zero-or-more (not (any "\n\":")))))
(group (zero-or-more (not (any "\n")))) "\n"
- (63 (group (*\? (not (any "