GNU bug report logs - #74799
Support setting `save-place-file' after running `save-place-mode'

Message received at 74799 <at> debbugs.gnu.org:

Received: (at 74799) by debbugs.gnu.org; 11 Dec 2024 21:01:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 11 16:01:22 2024
Received: from localhost ([127.0.0.1]:36474 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tLTpi-000791-IH
	for submit <at> debbugs.gnu.org; Wed, 11 Dec 2024 16:01:22 -0500
Received: from eggs.gnu.org ([209.51.188.92]:48230)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1tLTpf-00078d-Qv
 for 74799 <at> debbugs.gnu.org; Wed, 11 Dec 2024 16:01:20 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1tLTpZ-0001Iz-Vn; Wed, 11 Dec 2024 16:01:13 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=xswcLxagWaBfmXFhZHKo3ECHVXBQ4s/ly8A6H91O10c=; b=a2+RZMTg0fNM
 8oVEjhlCqGWq4S9qacPxsa5CAHoV6O3cm6yNh/BYJ8B4V0B2BevlQKN6H+At8IPia4PcbICb6ctna
 wMV0PzZxS35c9FnmrqXQuEGLx+Vo0AuDTw2qT4ER9y76LAJrEqY+TKTYPTW4WG/RF+ABt6Z17WtWf
 1ApQl06SCaejV5aliCiPPEH/iUG30Oj5sEOR0HnR8HGpkwD0VSVpXoaUC5G39RZIUU9tJ/LXxLGAm
 Oje/z2bdd0P2K5FtkMhD5KpRzS5Q41nnKZA+zDz4L09P0VEHibSPHwdRZDDosh9wTTTn7Mv4Io7+G
 9N0Yziyl4TCXwe9BhIEfhQ==;
Date: Wed, 11 Dec 2024 23:01:08 +0200
Message-Id: <86zfl20wa3.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Hong Xu <hong@HIDDEN>
In-Reply-To: <87sequymtf.fsf@HIDDEN> (message from Hong Xu on Wed, 11 Dec
 2024 12:41:32 -0800)
Subject: Re: bug#74799: [PATCH] Clarify that save-place-file must be set
 before save-place-mode starts
References: <20241211200119.92243-1-hong@HIDDEN> <865xnq2cbn.fsf@HIDDEN>
 <87sequymtf.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 74799
Cc: 74799 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Hong Xu <hong@HIDDEN>
> Cc: 74799 <at> debbugs.gnu.org
> Date: Wed, 11 Dec 2024 12:41:32 -0800
> 
> On 2024-12-11 Wed 12:29 GMT-08, Eli Zaretskii <eliz@HIDDEN> wrote:
> 
> >> -  "Name of the file that records `save-place-alist' value."
> >> +  "Name of the file that records `save-place-alist' value.
> >> +Must be set before starting save-place-mode."
> >>    :version "24.4"                       ; added locate-user-emacs-file
> >>    :type 'file)
> >
> > Thanks, but how about removing the limitation instead?
> 
> I'm not sure how to do this. It seems to me the limitation didn't exist
> in Emacs 29 but suddenly I have to set save-place-file before calling
> save-place-mode. I thought this was intended but maybe this is a
> regression?
> 
> (It's difficult for me to try out Emacs 29 now to 100% confirm, sorry.)

I'd start by comparing saveplace.el in Emacs 28 and Emacs 29.

You could also try loading saveplace.el from Emacs 28 into an Emacs 29
session, to see if the problems you have go away.

Btw, what actually happens if you modify the file name after you turn
on save-place-mode? what doesn't work?

Message received at 74799 <at> debbugs.gnu.org:

Received: (at 74799) by debbugs.gnu.org; 11 Dec 2024 20:58:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 11 15:58:50 2024
Received: from localhost ([127.0.0.1]:36462 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tLTnG-0006uY-0N
	for submit <at> debbugs.gnu.org; Wed, 11 Dec 2024 15:58:50 -0500
Received: from eggs.gnu.org ([209.51.188.92]:54594)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1tLTnD-0006u6-EY
 for 74799 <at> debbugs.gnu.org; Wed, 11 Dec 2024 15:58:48 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1tLTn8-0000tZ-04; Wed, 11 Dec 2024 15:58:42 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU=; b=HFwCVjIx9F4I
 78IuTXZPxArt6bZx5cg1shsJAhfdQEqtQEp6csB5dIDrhLyv8GU3dCYKsbuhAyCTJ9Px2GBngX3m7
 j953JS+9rxsi6ub7Jw+ByEuBtfvXcpeBh7vA6Ae0y/nECktdlrn/QKKQZQHgEDJRAsR2+K2JTi3RX
 L1wfQSY9L6gKiUbxLe3iazb0cfGHhUG06Feh/zcMlHuio/ue4ti2+YSjaEdD8KcXSWRjH3QDfAcN/
 3OvWakzE8JhgC0S5WSEocBTnjBwA//dV78BF6REG+O2VNvoVG3dIVZQF5YL5qGcHX6MuQaKm/ydM8
 KjPmB0mcc4GGRkT95Lxp7A==;
Date: Wed, 11 Dec 2024 22:58:38 +0200
Message-Id: <864j3a2ayq.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Hong Xu <hong@HIDDEN>
In-Reply-To: <87sequymtf.fsf@HIDDEN> (message from Hong Xu on Wed, 11 Dec
 2024 12:41:32 -0800)
Subject: Re: bug#74799: [PATCH] Clarify that save-place-file must be set
 before save-place-mode starts
References: <20241211200119.92243-1-hong@HIDDEN> <865xnq2cbn.fsf@HIDDEN>
 <87sequymtf.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 74799
Cc: 74799 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Message received at 74799 <at> debbugs.gnu.org:

Received: (at 74799) by debbugs.gnu.org; 11 Dec 2024 20:56:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 11 15:56:43 2024
Received: from localhost ([127.0.0.1]:36453 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tLTlC-0006nJ-DW
	for submit <at> debbugs.gnu.org; Wed, 11 Dec 2024 15:56:42 -0500
Received: from mail-vs1-f43.google.com ([209.85.217.43]:54292)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <shipmints@HIDDEN>) id 1tLTl9-0006mq-C8
 for 74799 <at> debbugs.gnu.org; Wed, 11 Dec 2024 15:56:40 -0500
Received: by mail-vs1-f43.google.com with SMTP id
 ada2fe7eead31-4afde39e360so1490179137.0
 for <74799 <at> debbugs.gnu.org>; Wed, 11 Dec 2024 12:56:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1733950534; x=1734555334; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=lPSJI8uT46rRcW1qn/Yq0Hv2Ach2HNkMESJDYt/99hA=;
 b=T8DgfaYHhDh7/78skQq6Arw7jQT2l524k6PYg2AOMh0eAnJj3YSrJaHiDZiPEZoOl9
 5GrwgAIQ7S8zGgaaSwOQib29m0RahgSybvAmGrpmeQ/zkDh0IJoEKisLFUfQ3U/G+AX5
 JcVusPHouGsI80JRVi5IyP6SG9Mk/grmfSxotC8o+ZN5H8/B/M22T/KZzcZEVqWfGaVX
 7znn8hBPfn1VlJCBoctevHqvkj6srsueRdcloAK0Ju2AVz5nZMTngicwHyPu70Smye+b
 S5l9ZxsU9JJ2rxX82u1mjvd+Gl9PhdBrt4o69HACR9+V+tsoSdk6J9oRU6beMlMsz6kk
 VdQg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1733950534; x=1734555334;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=lPSJI8uT46rRcW1qn/Yq0Hv2Ach2HNkMESJDYt/99hA=;
 b=VFgekhU29WU4bTbTO9L1IV0wKkYRajEBpsPEVUQTWh/Y7C0rSdslx+JIU0p8vkKAR1
 4B1KeeWtz8U0vhQp2d7v8QX1F1hqhyq27EmpJYWu3uE7/E7Ib8iPtFPO1UK8jMbA3Sha
 ks1y5mYBSKGk6xy3uNpd127ioOxXFKiGWmgJHnTT0ALgT3uevTPuz8OZZm0+VASTIlVf
 l8+fa2XNDbsWtj/jtwhnMJuVzd7JeW4BuTy1jyskGAMMDmuzRlT3yE9bnx6XJ5XEFVvO
 7d4sbMA9sOjd7zpuyuE2DwokRVKC5qNNB2vbC9ODkud0w/X4579xXhjCzPtyYD8ZfsuU
 84vQ==
X-Forwarded-Encrypted: i=1;
 AJvYcCXU8afUjOfNpaR5HfxZqAG84uayZ8+TzbDzVl5ZFDbnZXGEkmNcAs/irHLprC6Gl60ZMk8TCQ==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YwQvAIdBUr+k9iQXQqkvCSJQQhg1I6vOKdAOil0xNcqg7iyym4U
 OI3CQATYGV86LkWlbJt+4YLXHY31XzZx0Px0IcEMKQam+C1CDeRY5SJs1LJPkfXoxVk72noO0hj
 /kOZSS4LTp2yAZ1xsJ08UW5CJIEU=
X-Gm-Gg: ASbGnctkzUAJLfBi9FCeTehYoicyRtf+tMMkBNMwmQvGELvMcANSbCQ2cYooPU9HUxr
 xNqJROUL7P8PgNrIPhM/SyIATNibCLTTInBo=
X-Google-Smtp-Source: AGHT+IFlcIRM719OwI9/7dVlexuS5txovp0MxbKVtVqV/0insa12B70fKGGJsJ2jUlpBl9p8zuDPmgeWQE3UeTG7YNA=
X-Received: by 2002:a05:6102:5491:b0:4af:deaf:f891 with SMTP id
 ada2fe7eead31-4b24777b349mr1485715137.4.1733950533740; Wed, 11 Dec 2024
 12:55:33 -0800 (PST)
MIME-Version: 1.0
References: <20241211200119.92243-1-hong@HIDDEN> <865xnq2cbn.fsf@HIDDEN>
 <87sequymtf.fsf@HIDDEN>
In-Reply-To: <87sequymtf.fsf@HIDDEN>
From: Ship Mints <shipmints@HIDDEN>
Date: Wed, 11 Dec 2024 15:54:53 -0500
Message-ID: <CAN+1HboGND18cCYZx76Gws-zSb-gWOVxpi3dO-2QgBgGCzL4Hg@HIDDEN>
Subject: Re: bug#74799: [PATCH] Clarify that save-place-file must be set
 before save-place-mode starts
To: Hong Xu <hong@HIDDEN>
Content-Type: multipart/alternative; boundary="0000000000009f3189062904d166"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 74799
Cc: 74799 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--0000000000009f3189062904d166
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Using saveplace myself, and having added functionality such as a save timer
for which I'll contribute a patch for at some point, I've read the code.

If one changes the value of save-place-file from its default to another
value after the file has first been read, you'll have to manually reset
save-place-loaded to nil to force a reload. The defcustom
for save-place-file could be patched to provide a setter which would do
that, if that helps. I don't see this issue as I defer save-place-mode
until after init when my overrides have already taken effect.

On Wed, Dec 11, 2024 at 3:42=E2=80=AFPM Hong Xu <hong@HIDDEN> wrote:

> On 2024-12-11 Wed 12:29 GMT-08, Eli Zaretskii <eliz@HIDDEN> wrote:
>
> >> From: Hong Xu <hong@HIDDEN>
> >> Date: Wed, 11 Dec 2024 12:00:57 -0800
> >>
> >> ---
> >>  lisp/saveplace.el | 3 ++-
> >>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/lisp/saveplace.el b/lisp/saveplace.el
> >> index 012e305f7f45..ea67c4567b63 100644
> >> --- a/lisp/saveplace.el
> >> +++ b/lisp/saveplace.el
> >> @@ -63,7 +63,8 @@ save-place-alist
> >>  This alist is saved between Emacs sessions.")
> >>
> >>  (defcustom save-place-file (locate-user-emacs-file "places"
> ".emacs-places")
> >> -  "Name of the file that records `save-place-alist' value."
> >> +  "Name of the file that records `save-place-alist' value.
> >> +Must be set before starting save-place-mode."
> >>    :version "24.4"                       ; added locate-user-emacs-fil=
e
> >>    :type 'file)
> >
> > Thanks, but how about removing the limitation instead?
>
> I'm not sure how to do this. It seems to me the limitation didn't exist
> in Emacs 29 but suddenly I have to set save-place-file before calling
> save-place-mode. I thought this was intended but maybe this is a
> regression?
>
> (It's difficult for me to try out Emacs 29 now to 100% confirm, sorry.)
>
> --
> Hong
>
>
>
>

--0000000000009f3189062904d166
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:monospac=
e">Using saveplace myself, and having added functionality such as a save ti=
mer for which I&#39;ll contribute a patch for at some point, I&#39;ve read =
the code.</div><div class=3D"gmail_default" style=3D"font-family:monospace"=
><br></div><div class=3D"gmail_default" style=3D"font-family:monospace">If =
one changes the value of=C2=A0save-place-file from its default to another v=
alue after the file has first been read, you&#39;ll have to manually reset =
save-place-loaded to nil to force a reload. The defcustom for=C2=A0save-pla=
ce-file could be patched to provide a setter which would do that, if that h=
elps. I don&#39;t see this issue as I defer save-place-mode until after ini=
t when my overrides have already taken=C2=A0effect.</div></div><br><div cla=
ss=3D"gmail_quote gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_at=
tr">On Wed, Dec 11, 2024 at 3:42=E2=80=AFPM Hong Xu &lt;<a href=3D"mailto:h=
ong@HIDDEN">hong@HIDDEN</a>&gt; wrote:<br></div><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex">On 2024-12-11 Wed 12:29 GMT-08, Eli Zarets=
kii &lt;<a href=3D"mailto:eliz@HIDDEN" target=3D"_blank">eliz@HIDDEN</a>&=
gt; wrote:<br>
<br>
&gt;&gt; From: Hong Xu &lt;<a href=3D"mailto:hong@HIDDEN" target=3D"_bl=
ank">hong@HIDDEN</a>&gt;<br>
&gt;&gt; Date: Wed, 11 Dec 2024 12:00:57 -0800<br>
&gt;&gt; <br>
&gt;&gt; ---<br>
&gt;&gt;=C2=A0 lisp/saveplace.el | 3 ++-<br>
&gt;&gt;=C2=A0 1 file changed, 2 insertions(+), 1 deletion(-)<br>
&gt;&gt; <br>
&gt;&gt; diff --git a/lisp/saveplace.el b/lisp/saveplace.el<br>
&gt;&gt; index 012e305f7f45..ea67c4567b63 100644<br>
&gt;&gt; --- a/lisp/saveplace.el<br>
&gt;&gt; +++ b/lisp/saveplace.el<br>
&gt;&gt; @@ -63,7 +63,8 @@ save-place-alist<br>
&gt;&gt;=C2=A0 This alist is saved between Emacs sessions.&quot;)<br>
&gt;&gt;=C2=A0 <br>
&gt;&gt;=C2=A0 (defcustom save-place-file (locate-user-emacs-file &quot;pla=
ces&quot; &quot;.emacs-places&quot;)<br>
&gt;&gt; -=C2=A0 &quot;Name of the file that records `save-place-alist&#39;=
 value.&quot;<br>
&gt;&gt; +=C2=A0 &quot;Name of the file that records `save-place-alist&#39;=
 value.<br>
&gt;&gt; +Must be set before starting save-place-mode.&quot;<br>
&gt;&gt;=C2=A0 =C2=A0 :version &quot;24.4&quot;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0; added locate-user-=
emacs-file<br>
&gt;&gt;=C2=A0 =C2=A0 :type &#39;file)<br>
&gt;<br>
&gt; Thanks, but how about removing the limitation instead?<br>
<br>
I&#39;m not sure how to do this. It seems to me the limitation didn&#39;t e=
xist<br>
in Emacs 29 but suddenly I have to set save-place-file before calling<br>
save-place-mode. I thought this was intended but maybe this is a<br>
regression?<br>
<br>
(It&#39;s difficult for me to try out Emacs 29 now to 100% confirm, sorry.)=
<br>
<br>
-- <br>
Hong<br>
<br>
<br>
<br>
</blockquote></div>

--0000000000009f3189062904d166--

Message received at 74799 <at> debbugs.gnu.org:

Received: (at 74799) by debbugs.gnu.org; 11 Dec 2024 20:41:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 11 15:41:44 2024
Received: from localhost ([127.0.0.1]:36432 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tLTWi-0005vF-F0
	for submit <at> debbugs.gnu.org; Wed, 11 Dec 2024 15:41:44 -0500
Received: from sender4-of-o52.zoho.com ([136.143.188.52]:21257)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <hong@HIDDEN>) id 1tLTWg-0005v0-2Q
 for 74799 <at> debbugs.gnu.org; Wed, 11 Dec 2024 15:41:42 -0500
ARC-Seal: i=1; a=rsa-sha256; t=1733949694; cv=none; 
 d=zohomail.com; s=zohoarc; 
 b=DEbbDjdjU/5nM8TwOwYBpCquYdj6yaCNcGgoRZH/Ep+OouD2FhGpKQxysOFHpiq5RJ/FVFk0q9b0t0Bx25JimJZa08FhRGvWNBMSrGC6PENIOWzXuGWaWBLoH3VbcbgLVKif58dtBgT1Cr1VZNkw6p0wwiwPJk6R/GlGMh4TrY4=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
 s=zohoarc; t=1733949694;
 h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;
 bh=pPkh3Nzca1Q/WqtvJcrd/WdBjZui8qVHN8csWVvZwwE=; 
 b=Rzy69HJLVGm0vKY4BAFg2kUwvGFk+Ed3s1oNejEEK16Jhu1f+Rei87p2VJAlCUr2w8mbQqvU9S8GEHMsi68JFS+NHNNTwye+vw1XDi9JGOQv2DFJNWtAZi8/WUPrz0+JA+uDB6+NKnFQ6fYtMFN1ksV1QLjnDZnip4K0deJSUi0=
ARC-Authentication-Results: i=1; mx.zohomail.com;
 dkim=pass  header.i=topbug.net;
 spf=pass  smtp.mailfrom=hong@HIDDEN;
 dmarc=pass header.from=<hong@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1733949694; 
 s=zoho; d=topbug.net; i=hong@HIDDEN;
 h=From:From:To:To:Cc:Cc:Subject:Subject:In-Reply-To:References:Date:Date:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To;
 bh=pPkh3Nzca1Q/WqtvJcrd/WdBjZui8qVHN8csWVvZwwE=;
 b=Aa2A5zFajZTGIFJQewQniXp/FRa18b76SyRVSxsvQI8gZJt2KtDz9eDCFocZcw0B
 0J9A3lx7kDMunkrbnvJsLckPMiDi9rJ4wxLLbVzSQUKtWDqDZhDN/MjvfyL2gTlW8pv
 SeX22aBfavJq/FnUSOPrU0gaJMoD7MA5FTcfvaXI=
Received: by mx.zohomail.com with SMTPS id 17339496933861010.284287946085;
 Wed, 11 Dec 2024 12:41:33 -0800 (PST)
From: Hong Xu <hong@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#74799: [PATCH] Clarify that save-place-file must be set
 before save-place-mode starts
In-Reply-To: <865xnq2cbn.fsf@HIDDEN> (Eli Zaretskii's message of "Wed, 11 Dec
 2024 22:29:16 +0200")
References: <20241211200119.92243-1-hong@HIDDEN> <865xnq2cbn.fsf@HIDDEN>
User-Agent: mu4e 1.12.7; emacs 30.0.92
Date: Wed, 11 Dec 2024 12:41:32 -0800
Message-ID: <87sequymtf.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-ZohoMailClient: External
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 74799
Cc: 74799 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On 2024-12-11 Wed 12:29 GMT-08, Eli Zaretskii <eliz@HIDDEN> wrote:

>> From: Hong Xu <hong@HIDDEN>
>> Date: Wed, 11 Dec 2024 12:00:57 -0800
>> 
>> ---
>>  lisp/saveplace.el | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/lisp/saveplace.el b/lisp/saveplace.el
>> index 012e305f7f45..ea67c4567b63 100644
>> --- a/lisp/saveplace.el
>> +++ b/lisp/saveplace.el
>> @@ -63,7 +63,8 @@ save-place-alist
>>  This alist is saved between Emacs sessions.")
>>  
>>  (defcustom save-place-file (locate-user-emacs-file "places" ".emacs-places")
>> -  "Name of the file that records `save-place-alist' value."
>> +  "Name of the file that records `save-place-alist' value.
>> +Must be set before starting save-place-mode."
>>    :version "24.4"                       ; added locate-user-emacs-file
>>    :type 'file)
>
> Thanks, but how about removing the limitation instead?

I'm not sure how to do this. It seems to me the limitation didn't exist
in Emacs 29 but suddenly I have to set save-place-file before calling
save-place-mode. I thought this was intended but maybe this is a
regression?

(It's difficult for me to try out Emacs 29 now to 100% confirm, sorry.)

-- 
Hong

Message received at 74799 <at> debbugs.gnu.org:

Received: (at 74799) by debbugs.gnu.org; 11 Dec 2024 20:29:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 11 15:29:37 2024
Received: from localhost ([127.0.0.1]:36401 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tLTKz-000590-8G
	for submit <at> debbugs.gnu.org; Wed, 11 Dec 2024 15:29:37 -0500
Received: from eggs.gnu.org ([209.51.188.92]:53476)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1tLTKw-00058g-Po
 for 74799 <at> debbugs.gnu.org; Wed, 11 Dec 2024 15:29:35 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1tLTKq-0005jf-Pe; Wed, 11 Dec 2024 15:29:28 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=AK5hxS0Lo9pZCbvGDNrJl+zD3PsS4CbUxsPSf6su0gg=; b=RLfaMYZxLP8p
 jMlcCGX+m3+GqKOXgd2U6Mq1bWW60JcV/iAkRjPfYcmQ9RY5syG+8nuBZ7dEt61Q9F4ViYn/bMyW6
 cXQeEuIQxe4ykElxnAcmQaXTIuN1pb02lOKRU77qCMsgTQBoUt/oZlx+3++FfdXqf8SciwvgUe2Zv
 pAJ0hLTeJcai6P2HkxH2txrYXM5FltNsMQFodULko3rNtstcNg2Khgt0rOQOOZBkAUroeEtb0i675
 OoiMgUOT00RLphG8uE+DCE+3T1tHbpWK8aWEksHXAf9pBbXbnRSivlX37OjrDcKtjh4gLhjHGvzZn
 mmkCvqq2920JQFodFMC6bg==;
Date: Wed, 11 Dec 2024 22:29:16 +0200
Message-Id: <865xnq2cbn.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Hong Xu <hong@HIDDEN>
In-Reply-To: <20241211200119.92243-1-hong@HIDDEN> (message from Hong Xu on
 Wed, 11 Dec 2024 12:00:57 -0800)
Subject: Re: bug#74799: [PATCH] Clarify that save-place-file must be set before
 save-place-mode starts
References: <20241211200119.92243-1-hong@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 74799
Cc: 74799 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Hong Xu <hong@HIDDEN>
> Date: Wed, 11 Dec 2024 12:00:57 -0800
> 
> ---
>  lisp/saveplace.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lisp/saveplace.el b/lisp/saveplace.el
> index 012e305f7f45..ea67c4567b63 100644
> --- a/lisp/saveplace.el
> +++ b/lisp/saveplace.el
> @@ -63,7 +63,8 @@ save-place-alist
>  This alist is saved between Emacs sessions.")
>  
>  (defcustom save-place-file (locate-user-emacs-file "places" ".emacs-places")
> -  "Name of the file that records `save-place-alist' value."
> +  "Name of the file that records `save-place-alist' value.
> +Must be set before starting save-place-mode."
>    :version "24.4"                       ; added locate-user-emacs-file
>    :type 'file)

Thanks, but how about removing the limitation instead?

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 11 Dec 2024 20:01:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 11 15:01:34 2024
Received: from localhost ([127.0.0.1]:36339 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tLStp-0002mL-K9
	for submit <at> debbugs.gnu.org; Wed, 11 Dec 2024 15:01:33 -0500
Received: from lists.gnu.org ([209.51.188.17]:51898)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <hong@HIDDEN>) id 1tLStn-0002m2-A4
 for submit <at> debbugs.gnu.org; Wed, 11 Dec 2024 15:01:32 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <hong@HIDDEN>) id 1tLStn-0004sv-3W
 for bug-gnu-emacs@HIDDEN; Wed, 11 Dec 2024 15:01:31 -0500
Received: from sender4-of-o54.zoho.com ([136.143.188.54])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <hong@HIDDEN>) id 1tLStl-00023W-CK
 for bug-gnu-emacs@HIDDEN; Wed, 11 Dec 2024 15:01:30 -0500
ARC-Seal: i=1; a=rsa-sha256; t=1733947283; cv=none; 
 d=zohomail.com; s=zohoarc; 
 b=T2wvpYqbqHFwQ4iPOewj0de67mM+Gy4+QW+6X8TazRQMp3Mn9+YjMh7z+yw7X7X7UdFd3+P5Zu3GQTw4o6jtQknyZUPzaRvA12x61H3h/1Q5HsjPtzkqC/stYwu7mPD4xMqBcMYmWh4nqlqadtnnADmWY0fIupDvz1rT2UVMH2s=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
 s=zohoarc; t=1733947283;
 h=Content-Transfer-Encoding:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To:Cc;
 bh=aV3afJK4ET8yGOfcMTE3s47e6Vex81lDmZ9jk3sGgaA=; 
 b=GIuqFnOBIR4ylwq33StGD+FMV51CgQyJbK2hAgGb4LWqt4xEaOkj6gNTPydhNSQZGxjeLmcIm/xm1crgrZ8YC0RQ4c9weX3zmDSpytxOh/ouGY1l1IZTi61R70wgwysSC/N8US9FLRT2wPMu7fpoludACdCS9lFjo9aM6x4Nj40=
ARC-Authentication-Results: i=1; mx.zohomail.com;
 dkim=pass  header.i=topbug.net;
 spf=pass  smtp.mailfrom=hong@HIDDEN;
 dmarc=pass header.from=<hong@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1733947283; 
 s=zoho; d=topbug.net; i=hong@HIDDEN;
 h=From:From:To:To:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To:Cc;
 bh=aV3afJK4ET8yGOfcMTE3s47e6Vex81lDmZ9jk3sGgaA=;
 b=au3zKvUgNwDMbvZvwgKHVcmg3ETNJx/CUdZ++5OYBSiEFGhW7TgS2jpSYgJwz52o
 3xq8sh0HTcxOdWY+RViqKz1Q2X0vQqdhVbk9l0RiNTNiuVfCcP/X5k7azj93wPvI9sv
 6XiHap/RVzR/r62g2cNXQy1jM6SRovmDVsy8n7MA=
Received: by mx.zohomail.com with SMTPS id 173394728021161.30563147817497;
 Wed, 11 Dec 2024 12:01:20 -0800 (PST)
From: Hong Xu <hong@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: [PATCH] Clarify that save-place-file must be set before
 save-place-mode starts
Date: Wed, 11 Dec 2024 12:00:57 -0800
Message-ID: <20241211200119.92243-1-hong@HIDDEN>
X-Mailer: git-send-email 2.45.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External
Received-SPF: pass client-ip=136.143.188.54; envelope-from=hong@HIDDEN;
 helo=sender4-of-o54.zoho.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001,
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

---
 lisp/saveplace.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/saveplace.el b/lisp/saveplace.el
index 012e305f7f45..ea67c4567b63 100644
--- a/lisp/saveplace.el
+++ b/lisp/saveplace.el
@@ -63,7 +63,8 @@ save-place-alist
 This alist is saved between Emacs sessions.")
 
 (defcustom save-place-file (locate-user-emacs-file "places" ".emacs-places")
-  "Name of the file that records `save-place-alist' value."
+  "Name of the file that records `save-place-alist' value.
+Must be set before starting save-place-mode."
   :version "24.4"                       ; added locate-user-emacs-file
   :type 'file)
 
-- 
2.45.2