GNU logs - #74909, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#74909] [PATCH 0/3] Make guile-build-system packages reproducible.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 16 Dec 2024 06:10:02 +0000
Resent-Message-ID: <handler.74909.B.173432939915684 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 74909 <at> debbugs.gnu.org
Cc: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Date: Mon, 16 Dec 2024 15:07:19 +0900
Message-ID: <cover.1734329084.git.maxim.cournoyer@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2607:f8b0:4864:20::432;
 envelope-from=maxim.cournoyer@HIDDEN; helo=mail-pf1-x432.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

This makes our guile-build-system packages reproducible, working around a
defect in Guile that introduces non-determinism in the byte code depending off
the order the files get loaded/byte-compiled (IIUC).

Maxim Cournoyer (3):
  build/guile-build-system: Remove trailing #t in phases.
  build/guile: Disable parallel build for now.
  build/guile-build-system: Fix byte-compilation warnings.

 guix/build-system/guile.scm       | 11 +++++++++++
 guix/build/guile-build-system.scm | 22 +++++++++++-----------
 2 files changed, 22 insertions(+), 11 deletions(-)

base-commit: 3a8e19a61d785ba651c63a3a5991a6e6dcfba9cb
-- 
2.46.0

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Subject: bug#74909: Acknowledgement ([PATCH 0/3] Make guile-build-system
 packages reproducible.)
Message-ID: <handler.74909.B.173432939915684.ack <at> debbugs.gnu.org>
References: <cover.1734329084.git.maxim.cournoyer@HIDDEN>
X-Gnu-PR-Message: ack 74909
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 74909 <at> debbugs.gnu.org
Date: Mon, 16 Dec 2024 06:10:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 74909 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
74909: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D74909
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to maxim.cournoyer@HIDDEN, guix-patches@HIDDEN:

Subject: [bug#74909] [PATCH 2/3] build/guile: Disable parallel build for now.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: maxim.cournoyer@HIDDEN, guix-patches@HIDDEN
Resent-Date: Mon, 16 Dec 2024 06:30:04 +0000
Resent-Message-ID: <handler.74909.B74909.173433059919411 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 74909 <at> debbugs.gnu.org
Cc: Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Date: Mon, 16 Dec 2024 15:28:04 +0900
Message-ID: <d13269b557132bb136aa7c634c5995b1225fdf17.1734329084.git.maxim.cournoyer@HIDDEN>
In-Reply-To: <cover.1734329084.git.maxim.cournoyer@HIDDEN>
References: <cover.1734329084.git.maxim.cournoyer@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Following discussions in bug #74204.

* guix/build-system/guile.scm (guile-build): Add a #:parallel-build? flag,
defaulting to #f for now.
(guile-cross-build): Likewise.
* guix/build/guile-build-system.scm (build): Honor it.

Change-Id: Ibf12ac098e9dcea83da7b9685796e501df606c6c
---
 guix/build-system/guile.scm       | 11 +++++++++++
 guix/build/guile-build-system.scm |  6 +++++-
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/guix/build-system/guile.scm b/guix/build-system/guile.scm
index ee59bb15f2..df6988a1b7 100644
--- a/guix/build-system/guile.scm
+++ b/guix/build-system/guile.scm
@@ -85,6 +85,10 @@ (define* (guile-build name inputs
                       (source-directory ".")
                       not-compiled-file-regexp
                       (scheme-file-regexp %scheme-file-regexp)
+                      ;; FIXME: Turn on parallel building of Guile modules by
+                      ;; default after the non-determinism issues in the Guile byte
+                      ;; compiler are resolved (see bug #20272).
+                      (parallel-build? #f)
                       (compile-flags %compile-flags)
                       (imported-modules %guile-build-system-modules)
                       (modules '((guix build guile-build-system)
@@ -101,6 +105,7 @@ (define* (guile-build name inputs
                        #:source-directory #$source-directory
                        #:scheme-file-regexp #$scheme-file-regexp
                        #:not-compiled-file-regexp #$not-compiled-file-regexp
+                       #:parallel-build? #$parallel-build?
                        #:compile-flags #$compile-flags
                        #:phases #$phases
                        #:system #$system
@@ -132,6 +137,11 @@ (define* (guile-cross-build name
                             (source-directory ".")
                             (scheme-file-regexp %scheme-file-regexp)
                             not-compiled-file-regexp
+                            ;; FIXME: Turn on parallel building of Guile
+                            ;; modules by default after the non-determinism
+                            ;; issues in the Guile byte compiler are resolved
+                            ;; (see bug #20272).
+                            (parallel-build? #f)
                             (compile-flags %compile-flags)
                             (imported-modules %guile-build-system-modules)
                             (modules '((guix build guile-build-system)
@@ -159,6 +169,7 @@ (define* (guile-cross-build name
                        #:source-directory #$source-directory
                        #:scheme-file-regexp #$scheme-file-regexp
                        #:not-compiled-file-regexp #$not-compiled-file-regexp
+                       #:parallel-build? #$parallel-build?
                        #:compile-flags #$compile-flags
                        #:inputs %build-target-inputs
                        #:native-inputs %build-host-inputs
diff --git a/guix/build/guile-build-system.scm b/guix/build/guile-build-system.scm
index 37a1654ce4..b497573c0a 100644
--- a/guix/build/guile-build-system.scm
+++ b/guix/build/guile-build-system.scm
@@ -145,6 +145,10 @@ (define* (report-build-progress total completed
 (define* (build #:key outputs inputs native-inputs
                 (source-directory ".")
                 (compile-flags '())
+                ;; FIXME: Turn on parallel building of Guile modules by
+                ;; default after the non-determinism issues in the Guile byte
+                ;; compiler are resolved (see bug #20272).
+                (parallel-build? #f)
                 (scheme-file-regexp %scheme-file-regexp)
                 (not-compiled-file-regexp #f)
                 target
@@ -205,7 +209,7 @@ (define* (build #:key outputs inputs native-inputs
                                  (string-append source-directory "/" file)
                                  flags)))
                    source-files)
-       #:max-processes (parallel-job-count)
+       #:max-processes (if parallel-build? (parallel-job-count) 1)
        #:report-progress report-build-progress))))
 
 (define* (install-documentation #:key outputs
-- 
2.46.0

Message sent to maxim.cournoyer@HIDDEN, guix-patches@HIDDEN:

Subject: [bug#74909] [PATCH 1/3] build/guile-build-system: Remove trailing #t in phases.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: maxim.cournoyer@HIDDEN, guix-patches@HIDDEN
Resent-Date: Mon, 16 Dec 2024 06:31:02 +0000
Resent-Message-ID: <handler.74909.B74909.173433060919663 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 74909 <at> debbugs.gnu.org
Cc: Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Date: Mon, 16 Dec 2024 15:28:03 +0900
Message-ID: <8e4bf4f91b8b034ef216e87ca6720f9dd8361a7b.1734329084.git.maxim.cournoyer@HIDDEN>
In-Reply-To: <cover.1734329084.git.maxim.cournoyer@HIDDEN>
References: <cover.1734329084.git.maxim.cournoyer@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

* guix/build/guile-build-system.scm (set-locale-path): Delete trailing #t.
(invoke-each, build, install-documentation): Likewise.

Change-Id: I7a0d035b9bef2160856e141642dee70974c571db
---
 guix/build/guile-build-system.scm | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/guix/build/guile-build-system.scm b/guix/build/guile-build-system.scm
index 8927da224a..37a1654ce4 100644
--- a/guix/build/guile-build-system.scm
+++ b/guix/build/guile-build-system.scm
@@ -76,8 +76,7 @@ (define* (set-locale-path #:key inputs native-inputs
   (match (assoc-ref (or native-inputs inputs) "locales")
     (#f #t)
     (locales
-     (setenv "GUIX_LOCPATH" (string-append locales "/lib/locale"))
-     #t)))
+     (setenv "GUIX_LOCPATH" (string-append locales "/lib/locale")))))

 (define* (invoke-each commands
                       #:key (max-processes (current-processor-count))
@@ -112,8 +111,7 @@ (define* (invoke-each commands
          (lambda ()
            (primitive-exit 127))))
       (pid
-       (hashv-set! processes pid command)
-       #t)))
+       (hashv-set! processes pid command))))

   (let loop ((commands  commands)
              (running   0)
@@ -208,8 +206,7 @@ (define* (build #:key outputs inputs native-inputs
                                  flags)))
                    source-files)
        #:max-processes (parallel-job-count)
-       #:report-progress report-build-progress))
-    #t))
+       #:report-progress report-build-progress))))

 (define* (install-documentation #:key outputs
                                 (documentation-file-regexp
@@ -220,8 +217,7 @@ (define* (install-documentation #:key outputs
          (doc (string-append out "/share/doc/"
                              (strip-store-file-name out))))
     (for-each (cut install-file <> doc)
-              (find-files "." documentation-file-regexp))
-    #t))
+              (find-files "." documentation-file-regexp))))

 (define %standard-phases
   (modify-phases gnu:%standard-phases
-- 
2.46.0

Message sent to maxim.cournoyer@HIDDEN, guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#74909] [PATCH 3/3] build/guile-build-system: Fix byte-compilation warnings.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: maxim.cournoyer@HIDDEN, guix-patches@HIDDEN
Resent-Date: Mon, 16 Dec 2024 06:31:02 +0000
Resent-Message-ID: <handler.74909.B74909.173433061019711 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 74909
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 74909 <at> debbugs.gnu.org
Cc: Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
X-Debbugs-Original-Xcc: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Received: via spool by 74909-submit <at> debbugs.gnu.org id=B74909.173433061019711
          (code B ref 74909); Mon, 16 Dec 2024 06:31:02 +0000
Received: (at 74909) by debbugs.gnu.org; 16 Dec 2024 06:30:10 +0000
Received: from localhost ([127.0.0.1]:53228 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tN4cL-00057D-Cd
	for submit <at> debbugs.gnu.org; Mon, 16 Dec 2024 01:30:09 -0500
Received: from mail-pf1-f175.google.com ([209.85.210.175]:42113)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1tN4c8-00052r-53
 for 74909 <at> debbugs.gnu.org; Mon, 16 Dec 2024 01:30:03 -0500
Received: by mail-pf1-f175.google.com with SMTP id
 d2e1a72fcca58-728e78c4d7bso2628766b3a.0
 for <74909 <at> debbugs.gnu.org>; Sun, 15 Dec 2024 22:29:56 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1734330535; x=1734935335; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=PGtLOcOvkoAUgrQpD81B7l1n+dGLaLautWqFpgZ4850=;
 b=O8/BPH00vmfKHzPq5P438d/DbflPapDfbLAvyZORWwefSFB1q2yl4nphK0jSDNcdMk
 dSIr7hYhxIqA21CP3ohf2W+pJtzjGBrw/haipJsWDObUSeQzTsWCxDlYNApmXKES/3x2
 T7f9sbAirziSbR5B7NkH4gwbTjxJtknKqqSI/AT7bLCbWX9ekZGYwMJLrK021M5C/puz
 7Le+FPZI7daDxtzMlT5S1S2dq4vcLSXi21dpcUC16iYwPA7u6lQBgP3fbRlLB1Avk6Hh
 G1wYc4tDqdxymQZz3cKa14sfIxW2GR2A1gf3rCP99VMOkukQGrdiwCaohvFwO0fmgIaO
 3ZKg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1734330535; x=1734935335;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=PGtLOcOvkoAUgrQpD81B7l1n+dGLaLautWqFpgZ4850=;
 b=pS4F5bVV2r7xIlH0Eh6HeIp8VFdV8ggnWLc9jky2vVE6unGo+/h5yX7gH7BiJB1sQI
 kX67Ujgs/17tSBjnlQdTl4VHL0Q+4EezPi0s3uj3I9jn/hDev1oa/sAhLUfv1N9WExhP
 vgYWTdV7Wygz9CJpba3j9MP884HeJyN3X9E1oa9DRFE4TXJI3+kBsfRlomQ+iIXt6dgn
 XwnS9+iqi/2Lbq2N45KVbwvdm49mBzF39YgNvTcqsPIDXDGqkHGio/ZnupPMAPcxJHYm
 N9tVemEidtsrEwpuA20lr0cJWsqLokFIPX7acve5EfhnxmFyD5X3VF6OhQg3LIE6Ca9G
 tobw==
X-Gm-Message-State: AOJu0YxsRxnsD49a5CMuWYQOWJT+xk0dON+th5PwQwA32BQGlAI6oW66
 zDP6SsyKYKQ8f4vcOURh7JQmGTprhTIHYp/oV5eegNODllwBOFDi/EoUag==
X-Gm-Gg: ASbGncuWj3iEKjZ3NugAJFTrcjr2AXLo7odTvCB1sRpy2Q/5vWRgTVeRtVhd64kSya+
 4jmZJ4t/its0vjTh7QhEPbJo+0/4HByecWoIJHA0siCAMgv8+1d6T5FtTsujHU0xBWwouDEaxno
 B1MFZQ5JObz7Jitzcn5hy+L1qT1qXMInjTniNvfWcePU7gXib2zohtjBM/b2KpMgykLokDihIxQ
 0tEIj+mcaaYzQWO8fB/ibv0sp0J3smO5R4OVG9E+6CE+cQSCvTY37FLYGW0GNActnbPItdip6c=
X-Google-Smtp-Source: AGHT+IGFMNQvl81WbHH3ucrEFD/Ja7f03pJ24GqGtw9s1qpYLME7wolYYlb5xEbGI0TT7yBg40mLKQ==
X-Received: by 2002:a05:6a21:b8d:b0:1e1:adcd:eadb with SMTP id
 adf61e73a8af0-1e1e000c365mr14143519637.11.1734330534894; 
 Sun, 15 Dec 2024 22:28:54 -0800 (PST)
Received: from localhost.localdomain ([2405:6586:be0:0:c8ff:1707:9b9:af89])
 by smtp.gmail.com with ESMTPSA id
 d2e1a72fcca58-72918b788d1sm3948509b3a.110.2024.12.15.22.28.53
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 15 Dec 2024 22:28:54 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Date: Mon, 16 Dec 2024 15:28:05 +0900
Message-ID: <212e93c9b6e20be25a0479b3fee8af8ad633df32.1734329084.git.maxim.cournoyer@HIDDEN>
X-Mailer: git-send-email 2.46.0
In-Reply-To: <cover.1734329084.git.maxim.cournoyer@HIDDEN>
References: <cover.1734329084.git.maxim.cournoyer@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* guix/build/guile-build-system.scm: Hide 'delete' from (guix build utils), to
avoid shadowing the builtin.
(invoke-each): Replace current-processor-count with parallel-job-count.  The
former would require importing (ice-9 threads).

Change-Id: I7cde3305b9017bfec52ffe50ed124e21cbdceb25
---
 guix/build/guile-build-system.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/guix/build/guile-build-system.scm b/guix/build/guile-build-system.scm
index b497573c0a..d2198b6715 100644
--- a/guix/build/guile-build-system.scm
+++ b/guix/build/guile-build-system.scm
@@ -18,7 +18,7 @@
 
 (define-module (guix build guile-build-system)
   #:use-module ((guix build gnu-build-system) #:prefix gnu:)
-  #:use-module (guix build utils)
+  #:use-module ((guix build utils) #:hide (delete))
   #:use-module (srfi srfi-1)
   #:use-module (srfi srfi-26)
   #:use-module (ice-9 match)
@@ -79,7 +79,7 @@ (define* (set-locale-path #:key inputs native-inputs
      (setenv "GUIX_LOCPATH" (string-append locales "/lib/locale")))))
 
 (define* (invoke-each commands
-                      #:key (max-processes (current-processor-count))
+                      #:key (max-processes (parallel-job-count))
                       report-progress)
   "Run each command in COMMANDS in a separate process, using up to
 MAX-PROCESSES processes in parallel.  Call REPORT-PROGRESS at each step.
-- 
2.46.0

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.