GNU bug report logs - #74972
[PATCH] add font-monaspace package

Previous Next

Package: guix-patches;

Reported by: Josep Bigorra <jjbigorra <at> gmail.com>

Date: Thu, 19 Dec 2024 13:48:01 UTC

Severity: normal

Tags: patch

Done: 宋文武 <iyzsong <at> envs.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74972 in the body.
You can then email your comments to 74972 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#74972; Package guix-patches. (Thu, 19 Dec 2024 13:48:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Josep Bigorra <jjbigorra <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 19 Dec 2024 13:48:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Josep Bigorra <jjbigorra <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] add font-monaspace package
Date: Thu, 19 Dec 2024 14:46:59 +0100
[Message part 1 (text/plain, inline)]
Hi all,
I hereby submit a patch adding the beautiful Monaspace font families.
This works nicely in my Guix system so I want to upstream it. Hope I
didn't miss anything.

Regards,
Joe
[0001-add-font-monaspace-package.patch (text/x-patch, attachment)]

Information forwarded to all_but_last <at> 163.com, iyzsong <at> envs.net, guix-patches <at> gnu.org:
bug#74972; Package guix-patches. (Fri, 20 Dec 2024 15:28:02 GMT) Full text and rfc822 format available.

Message #8 received at 74972 <at> debbugs.gnu.org (full text, mbox):

From: Noé Lopez <noe <at> xn--no-cja.eu>
To: 74972 <at> debbugs.gnu.org
Cc: Noé Lopez <noe <at> xn--no-cja.eu>
Subject: [PATCH v2] gnu: fonts: Add font-monaspace.
Date: Fri, 20 Dec 2024 16:25:57 +0100
From: Josep Bigorra <jjbigorra <at> gmail.com>

* gnu/packages/fonts.scm (font-monaspace): New variable.

Change-Id: I25559696f792a8dbf4961dfba2be906fb6d5f0c0
---
 gnu/packages/fonts.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 69d7d039aa..b36a46ebb3 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -60,6 +60,7 @@
 ;;; Copyright © 2023 chris <chris <at> bumblehead.com>
 ;;; Copyright © 2023, 2024 Luis Felipe López Acevedo <sirgazil <at> zoho.com>
 ;;; Copyright © 2024 Christina O'Donnell <cdo <at> mutix.org>
+;;; Copyright © 2024 Josep Bigorra <jjbigorra <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3893,3 +3894,27 @@ (define-public font-dina
 It is relatively compact to allow a lot of code on screen, while (hopefully) clear
 enough to remain readable even at high resolutions.")
     (license license:expat)))
+
+(define-public font-monaspace
+  (package
+    (name "font-monaspace")
+    (version "1.101")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/githubnext/monaspace")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "00bpzzpwz5m20ap0c1gy0rf99pc76g8lk6jr0wh7xs8fjazq7lf1"))))
+    (build-system font-build-system)
+    (home-page "https://monaspace.githubnext.com")
+    (synopsis "Innovative superfamily of fonts for code")
+    (description
+     "The Monaspace type system is a monospaced type superfamily with some modern
+tricks up its sleeve.  It consists of five variable axis typefaces.  Each one has a
+distinct voice, but they are all metrics-compatible with one another, allowing you to
+mix and match them for a more expressive typographical palette.")
+    (license license:silofl1.1)))

base-commit: 5e82c33839b1c02a3db8ef22f7b52e10d97a2f78
-- 
2.46.0





Information forwarded to guix-patches <at> gnu.org:
bug#74972; Package guix-patches. (Fri, 20 Dec 2024 15:31:01 GMT) Full text and rfc822 format available.

Message #11 received at 74972 <at> debbugs.gnu.org (full text, mbox):

From: Noé Lopez <noe <at> xn--no-cja.eu>
To: 74972 <at> debbugs.gnu.org
Cc: Josep Bigorra <jjbigorra <at> gmail.com>
Subject: Re: [PATCH] add font-monaspace package
Date: Fri, 20 Dec 2024 16:31:51 +0100
Hi,

Thank you for your patch, there are a few issues with it that are
reported by guix lint: it is better to use a git origin instead of an
archive, your synopsys starts with an article (”an”) and sentences in
the description are not separated with two spaces.  It is also missing a
commit messages.

These are only small changes, the rest of the patch works well :) I have
sent a second version to fix the issues listed.

Have a good day,
Noé Lopez

> Hi all,
> I hereby submit a patch adding the beautiful Monaspace font families.
> This works nicely in my Guix system so I want to upstream it. Hope I
> didn't miss anything.
> 
> Regards,
> Joe
> From 030da8462240259aac4c46f398d7e2b4e9db9aa0 Mon Sep 17 00:00:00 2001
> Message-ID: <030da8462240259aac4c46f398d7e2b4e9db9aa0.1734615915.git.jjbigorra <at> gmail.com>
> From: Josep Bigorra <jjbigorra <at> gmail.com>
> Date: Thu, 19 Dec 2024 14:44:46 +0100
> Subject: [PATCH] add font-monaspace package
> 
> ---
>  gnu/packages/fonts.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
> index 69d7d03..d7afe14 100644
> --- a/gnu/packages/fonts.scm
> +++ b/gnu/packages/fonts.scm
> @@ -60,6 +60,7 @@
>  ;;; Copyright © 2023 chris <chris <at> bumblehead.com>
>  ;;; Copyright © 2023, 2024 Luis Felipe López Acevedo <sirgazil <at> zoho.com>
>  ;;; Copyright © 2024 Christina O'Donnell <cdo <at> mutix.org>
> +;;; Copyright © 2024 Josep Bigorra <jjbigorra <at> gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -3893,3 +3894,23 @@ (define-public font-dina
>  It is relatively compact to allow a lot of code on screen, while (hopefully) clear
>  enough to remain readable even at high resolutions.")
>      (license license:expat)))
> +
> +(define-public font-monaspace
> +  (package
> +    (name "font-monaspace")
> +    (version "1.101")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri
> +        "https://github.com/githubnext/monaspace/archive/refs/tags/v1.101.tar.gz")
> +       (sha256
> +        (base32 "076gx85and4xb262y0rbqvy7f6w732krzlh236xr7v3zbsw1h872"))))
> +    (build-system font-build-system)
> +    (home-page "https://monaspace.githubnext.com")
> +    (synopsis "An innovative superfamily of fonts for code")
> +    (description
> +     "The Monaspace type system is a monospaced type superfamily with some modern tricks up its sleeve.
> +     It consists of five variable axis typefaces. Each one has a distinct voice, but they are all metrics-compatible with one another,
> +     allowing you to mix and match them for a more expressive typographical palette.")
> +    (license license:silofl1.1)))
> -- 
> 2.46.0




Information forwarded to guix-patches <at> gnu.org:
bug#74972; Package guix-patches. (Fri, 20 Dec 2024 15:34:01 GMT) Full text and rfc822 format available.

Message #14 received at 74972 <at> debbugs.gnu.org (full text, mbox):

From: Noé Lopez <noe <at> xn--no-cja.eu>
To: control <at> debbugs.gnu.org, 74972 <at> debbugs.gnu.org
Subject: Control message for 74972
Date: Fri, 20 Dec 2024 16:34:39 +0100
user guix
tags 74972 + reviewed-looks-good
thanks




Information forwarded to guix-patches <at> gnu.org:
bug#74972; Package guix-patches. (Fri, 20 Dec 2024 17:26:01 GMT) Full text and rfc822 format available.

Message #17 received at 74972 <at> debbugs.gnu.org (full text, mbox):

From: Josep Bigorra <jjbigorra <at> gmail.com>
To: 74972 <at> debbugs.gnu.org
Date: Fri, 20 Dec 2024 18:24:17 +0100
[Message part 1 (text/plain, inline)]
Thanks a lot for your work Noé LGTM
[Message part 2 (text/html, inline)]

Reply sent to 宋文武 <iyzsong <at> envs.net>:
You have taken responsibility. (Fri, 21 Feb 2025 04:46:01 GMT) Full text and rfc822 format available.

Notification sent to Josep Bigorra <jjbigorra <at> gmail.com>:
bug acknowledged by developer. (Fri, 21 Feb 2025 04:46:02 GMT) Full text and rfc822 format available.

Message #22 received at 74972-done <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: Josep Bigorra <jjbigorra <at> gmail.com>
Cc: 74972-done <at> debbugs.gnu.org
Subject: Re: [bug#74972]
Date: Fri, 21 Feb 2025 12:49:31 +0800
Pushed now, thanks!




Information forwarded to guix-patches <at> gnu.org:
bug#74972; Package guix-patches. (Fri, 21 Feb 2025 10:39:02 GMT) Full text and rfc822 format available.

Message #25 received at 74972 <at> debbugs.gnu.org (full text, mbox):

From: Steve George <steve <at> futurile.net>
To: 74972 <at> debbugs.gnu.org
Subject: RE: add font-monaspace package
Date: Fri, 21 Feb 2025 10:38:01 +0000
Hi,

There's a PR for it here: 

https://codeberg.org/civodul/guix/pulls/9

Steve / Futurile




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 21 Mar 2025 11:24:19 GMT) Full text and rfc822 format available.

This bug report was last modified 117 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.