GNU logs - #74973, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#74973] [PATCH] gnu: Fix clojure-tools.
Resent-From: Rostislav Svoboda <rostislav.svoboda@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 19 Dec 2024 14:24:01 +0000
Resent-Message-ID: <handler.74973.B.17346181878645 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 74973 <at> debbugs.gnu.org, amorenompls@HIDDEN
Cc: Rostislav Svoboda <Rostislav.Svoboda@HIDDEN>
From: Rostislav Svoboda <rostislav.svoboda@HIDDEN>
Date: Thu, 19 Dec 2024 15:22:27 +0100
Message-ID: <71b44c3763ea0a72d756b300fbe36220a6899a5d.1734617873.git.Rostislav.Svoboda@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2a00:1450:4864:20::636;
 envelope-from=rostislav.svoboda@HIDDEN; helo=mail-ej1-x636.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

* gnu/packages/clojure.scm (clojure-tools): The AOT compiled JAR must be
included and used by the bin/clojure script.

See also
https://yhetil.org/guix-user/CAOXoXz0fKD+3B+b_y6A8MPYxZcSRDusby6VWTUy8Nnp4Y0fAzQ@HIDDEN/

Change-Id: I3a8221fd415631f191cbf6ddcb0e8ecbd94e389f
---
 gnu/packages/clojure.scm | 21 ++++-----------------
 1 file changed, 4 insertions(+), 17 deletions(-)

diff --git a/gnu/packages/clojure.scm b/gnu/packages/clojure.scm
index 09674f541e..6146b38753 100644
--- a/gnu/packages/clojure.scm
+++ b/gnu/packages/clojure.scm
@@ -204,18 +204,14 @@ (define-public clojure
 (define-public clojure-tools
   (package
     (name "clojure-tools")
-    (version "1.11.1.1413")
+    (version "1.12.0.1488")
     (source
      (origin
        (method url-fetch)
        (uri (string-append "https://download.clojure.org/install/clojure-tools-"
                            version
                            ".tar.gz"))
-       (sha256 (base32 "1q0z71ifdxwvyy9gvq8mx8jbygf8cszrlhb3h22walfamnisbhwk"))
-       ;; Remove AOT compiled JAR.  The other JAR only contains uncompiled
-       ;; Clojure source code.
-       (snippet
-        `(delete-file ,(string-append "clojure-tools-" version ".jar")))))
+       (sha256 (base32 "0hh78b22shj530armm9850cqr85wqdxyqfzx4qf45w5y200bw6dw"))))
     (build-system copy-build-system)
     (arguments
      `(#:install-plan
@@ -223,6 +219,7 @@ (define-public clojure-tools
          ("example-deps.edn" "lib/clojure/")
          ("tools.edn" "lib/clojure/")
          ("exec.jar" "lib/clojure/libexec/")
+         (,(string-append "clojure-tools-" version ".jar") "lib/clojure/libexec/")
          ("clojure" "bin/")
          ("clj" "bin/"))
        #:modules ((guix build copy-build-system)
@@ -237,17 +234,7 @@ (define-public clojure-tools
                (("PREFIX") (string-append (assoc-ref outputs "out") "/lib/clojure")))
              (substitute* "clj"
                (("BINDIR") (string-append (assoc-ref outputs "out") "/bin"))
-               (("rlwrap") (which "rlwrap")))))
-         (add-after 'fix-paths 'copy-tools-deps-alpha-jar
-           (lambda* (#:key inputs outputs #:allow-other-keys)
-             (substitute* "clojure"
-               (("\\$install_dir/libexec/clojure-tools-\\$version\\.jar")
-                (string-join
-                 (append-map (match-lambda
-                               ((label . dir)
-                                (find-files dir "\\.jar$")))
-                             inputs)
-                 ":"))))))))
+               (("rlwrap") (which "rlwrap"))))))))
     (inputs (list rlwrap
                   clojure
                   clojure-tools-deps

base-commit: 5634bc206d82a867850c86044c423b0a8700f34e
-- 
2.46.0

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Rostislav Svoboda <rostislav.svoboda@HIDDEN>
Subject: bug#74973: Acknowledgement ([PATCH] gnu: Fix clojure-tools.)
Message-ID: <handler.74973.B.17346181878645.ack <at> debbugs.gnu.org>
References: <71b44c3763ea0a72d756b300fbe36220a6899a5d.1734617873.git.Rostislav.Svoboda@HIDDEN>
X-Gnu-PR-Message: ack 74973
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 74973 <at> debbugs.gnu.org
Date: Thu, 19 Dec 2024 14:24:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 74973 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
74973: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D74973
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#74973] [PATCH] gnu: Fix clojure-tools.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 25 Dec 2024 21:57:02 +0000
Resent-Message-ID: <handler.74973.B74973.173516380011607 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Rostislav Svoboda <rostislav.svoboda@HIDDEN>
Cc: amorenompls@HIDDEN, 74973 <at> debbugs.gnu.org
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
In-Reply-To: <71b44c3763ea0a72d756b300fbe36220a6899a5d.1734617873.git.Rostislav.Svoboda@HIDDEN>
 (Rostislav Svoboda's message of "Thu, 19 Dec 2024 15:22:27 +0100")
References: <71b44c3763ea0a72d756b300fbe36220a6899a5d.1734617873.git.Rostislav.Svoboda@HIDDEN>
Date: Wed, 25 Dec 2024 22:56:16 +0100
Message-ID: <87h66r2zr3.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi Rostislav,

Rostislav Svoboda <rostislav.svoboda@HIDDEN> skribis:

> * gnu/packages/clojure.scm (clojure-tools): The AOT compiled JAR must be
> included and used by the bin/clojure script.
>
> See also
> https://yhetil.org/guix-user/CAOXoXz0fKD+3B+b_y6A8MPYxZcSRDusby6VWTUy8Nnp=
4Y0fAzQ@HIDDEN/
>
> Change-Id: I3a8221fd415631f191cbf6ddcb0e8ecbd94e389f

[...]

>      (source
>       (origin
>         (method url-fetch)
>         (uri (string-append "https://download.clojure.org/install/clojure=
-tools-"
>                             version
>                             ".tar.gz"))
> -       (sha256 (base32 "1q0z71ifdxwvyy9gvq8mx8jbygf8cszrlhb3h22walfamnis=
bhwk"))
> -       ;; Remove AOT compiled JAR.  The other JAR only contains uncompil=
ed
> -       ;; Clojure source code.
> -       (snippet
> -        `(delete-file ,(string-append "clojure-tools-" version ".jar")))=
))
> +       (sha256 (base32 "0hh78b22shj530armm9850cqr85wqdxyqfzx4qf45w5y200b=
w6dw"))))

The problem is that in general we don=E2=80=99t want to keep pre-built bina=
ries
like this one.  Could we keep this snippet and instead find a way to
ensure that this jar is built from source and installed?

Thanks,
Ludo=E2=80=99.

Message sent to guix-patches@HIDDEN:

Subject: [bug#74973] [PATCH] gnu: Fix clojure-tools.
Resent-From: Rostislav Svoboda <rostislav.svoboda@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 26 Dec 2024 14:43:02 +0000
Resent-Message-ID: <handler.74973.B74973.17352241534634 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Cc: amorenompls@HIDDEN, 74973 <at> debbugs.gnu.org
MIME-Version: 1.0
References: <71b44c3763ea0a72d756b300fbe36220a6899a5d.1734617873.git.Rostislav.Svoboda@HIDDEN>
 <87h66r2zr3.fsf@HIDDEN>
In-Reply-To: <87h66r2zr3.fsf@HIDDEN>
From: Rostislav Svoboda <rostislav.svoboda@HIDDEN>
Date: Thu, 26 Dec 2024 15:40:45 +0100
Message-ID: <CAEtmmex9BPyXgPM+0B+GHL-K5-tHivrL-mixAfgdkpPyTJDeSQ@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hello Ludo=E2=80=99

> Could we keep this snippet and instead find a way to ensure that this jar=
 is built from source and installed?

Uff, we're diving into the rabbit hole here. The clojure-tools-*.jar
is built using itself and relies on a considerable number of
configuration settings and jar files. (See below.)

Cheers,
Bost

bost@ecke /tmp$ git clone https://github.com/clojure/brew-install
Clonage dans 'brew-install'...
remote: Enumerating objects: 6984, done.
remote: Counting objects: 100% (1280/1280), done.
remote: Compressing objects: 100% (89/89), done.
remote: Total 6984 (delta 1196), reused 1244 (delta 1171), pack-reused
5704 (from 1)
R=C3=A9ception d'objets: 100% (6984/6984), 854.54 Kio | 6.62 Mio/s, fait.
R=C3=A9solution des deltas: 100% (3418/3418), fait.
bost@ecke /tmp$ cd brew-install/

bost@ecke /tmp/brew-install$ clj -Sverbose -T:build release
version      =3D 1.12.0.1488
install_dir  =3D /gnu/store/s7basyx1rffp9bnacnr90v6zscx3ch72-clojure-tools-=
1.12.0.1488/lib/clojure
config_dir   =3D /home/bost/.config/clojure
config_paths =3D /gnu/store/s7basyx1rffp9bnacnr90v6zscx3ch72-clojure-tools-=
1.12.0.1488/lib/clojure/deps.edn
/home/bost/.config/clojure/deps.edn deps.edn
cache_dir    =3D .cpcache
cp_file      =3D .cpcache/519643847.cp

Refreshing classpath
clojure-tools/
clojure-tools/clj
clojure-tools/clojure.1
clojure-tools/clj.1
clojure-tools/example-deps.edn
clojure-tools/install.sh
clojure-tools/exec.jar
clojure-tools/tools.edn
clojure-tools/clojure
clojure-tools/deps.edn
clojure-tools/clojure-tools-1.12.0.1488.jar

bost@ecke /tmp/brew-install$ clj -Stree
org.clojure/clojure 1.12.0
  . org.clojure/spec.alpha 0.5.238
  . org.clojure/core.specs.alpha 0.4.74
org.clojure/tools.deps 0.21.1460
  . org.apache.maven.resolver/maven-resolver-api 1.8.2
  . org.apache.maven.resolver/maven-resolver-spi 1.8.2
    . org.apache.maven.resolver/maven-resolver-api 1.8.2
  . org.apache.maven.resolver/maven-resolver-impl 1.8.2
    . org.apache.maven.resolver/maven-resolver-api 1.8.2
    . org.apache.maven.resolver/maven-resolver-spi 1.8.2
    . org.apache.maven.resolver/maven-resolver-named-locks 1.8.2
      . org.slf4j/slf4j-api 1.7.36
    . org.apache.maven.resolver/maven-resolver-util 1.8.2
    . org.apache.commons/commons-lang3 3.12.0
    . javax.annotation/javax.annotation-api 1.3.2
    . org.slf4j/slf4j-api 1.7.36
  . org.apache.maven.resolver/maven-resolver-util 1.8.2
    . org.apache.maven.resolver/maven-resolver-api 1.8.2
  . org.apache.maven.resolver/maven-resolver-connector-basic 1.8.2
    . org.apache.maven.resolver/maven-resolver-api 1.8.2
    . org.apache.maven.resolver/maven-resolver-spi 1.8.2
    . org.apache.maven.resolver/maven-resolver-util 1.8.2
    . org.slf4j/slf4j-api 1.7.36
  . org.apache.maven.resolver/maven-resolver-transport-file 1.8.2
    . org.apache.maven.resolver/maven-resolver-api 1.8.2
    . org.apache.maven.resolver/maven-resolver-spi 1.8.2
    . org.slf4j/slf4j-api 1.7.36
  . org.apache.maven.resolver/maven-resolver-transport-http 1.8.2
    . org.apache.maven.resolver/maven-resolver-api 1.8.2
    . org.apache.maven.resolver/maven-resolver-spi 1.8.2
    . org.apache.maven.resolver/maven-resolver-util 1.8.2
    . org.apache.httpcomponents/httpclient 4.5.13
      X org.apache.httpcomponents/httpcore 4.4.13 :older-version
      . commons-codec/commons-codec 1.11
    . org.apache.httpcomponents/httpcore 4.4.15
    . org.slf4j/jcl-over-slf4j 1.7.36
      . org.slf4j/slf4j-api 1.7.36
    . org.slf4j/slf4j-api 1.7.36
  . org.apache.maven/maven-resolver-provider 3.8.8
    . org.apache.maven/maven-model 3.8.8
      . org.codehaus.plexus/plexus-utils 3.3.1
    . org.apache.maven/maven-model-builder 3.8.8
      . org.codehaus.plexus/plexus-utils 3.3.1
      . org.codehaus.plexus/plexus-interpolation 1.26
      . javax.inject/javax.inject 1
      . org.apache.maven/maven-model 3.8.8
      . org.apache.maven/maven-artifact 3.8.8
      . org.apache.maven/maven-builder-support 3.8.8
      . org.eclipse.sisu/org.eclipse.sisu.inject 0.3.5
    . org.apache.maven/maven-repository-metadata 3.8.8
      . org.codehaus.plexus/plexus-utils 3.3.1
    X org.apache.maven.resolver/maven-resolver-api 1.6.3 :older-version
    X org.apache.maven.resolver/maven-resolver-spi 1.6.3 :older-version
    X org.apache.maven.resolver/maven-resolver-util 1.6.3 :older-version
    X org.apache.maven.resolver/maven-resolver-impl 1.6.3 :older-version
    X org.codehaus.plexus/plexus-utils 3.3.1 :superseded
    . javax.inject/javax.inject 1
  . org.apache.maven/maven-core 3.8.8
    . org.apache.maven/maven-model 3.8.8
    . org.apache.maven/maven-settings 3.8.8
      . org.codehaus.plexus/plexus-utils 3.3.1
    . org.apache.maven/maven-settings-builder 3.8.8
      . org.apache.maven/maven-builder-support 3.8.8
      . javax.inject/javax.inject 1
      . org.codehaus.plexus/plexus-interpolation 1.26
      . org.codehaus.plexus/plexus-utils 3.3.1
      . org.apache.maven/maven-settings 3.8.8
      . org.codehaus.plexus/plexus-sec-dispatcher 2.0
        . org.codehaus.plexus/plexus-utils 3.4.1 :newer-version
        . org.codehaus.plexus/plexus-cipher 2.0
          . javax.inject/javax.inject 1
        . javax.inject/javax.inject 1
    . org.apache.maven/maven-builder-support 3.8.8
    . org.apache.maven/maven-repository-metadata 3.8.8
    . org.apache.maven/maven-artifact 3.8.8
      . org.codehaus.plexus/plexus-utils 3.3.1
      X org.apache.commons/commons-lang3 3.8.1 :older-version
    . org.apache.maven/maven-plugin-api 3.8.8
      . org.apache.maven/maven-model 3.8.8
      . org.apache.maven/maven-artifact 3.8.8
      . org.eclipse.sisu/org.eclipse.sisu.plexus 0.3.5
      . org.codehaus.plexus/plexus-utils 3.3.1
      . org.codehaus.plexus/plexus-classworlds 2.6.0
    . org.apache.maven/maven-model-builder 3.8.8
    . org.apache.maven/maven-resolver-provider 3.8.8
    X org.apache.maven.resolver/maven-resolver-impl 1.6.3 :older-version
    X org.apache.maven.resolver/maven-resolver-api 1.6.3 :older-version
    X org.apache.maven.resolver/maven-resolver-spi 1.6.3 :older-version
    X org.apache.maven.resolver/maven-resolver-util 1.6.3 :older-version
    . org.apache.maven.shared/maven-shared-utils 3.3.4
    . org.eclipse.sisu/org.eclipse.sisu.plexus 0.3.5
      X javax.annotation/javax.annotation-api 1.2 :older-version
      . org.eclipse.sisu/org.eclipse.sisu.inject 0.3.5
      X org.codehaus.plexus/plexus-component-annotations 1.5.5 :older-versi=
on
      X org.codehaus.plexus/plexus-classworlds 2.5.2 :older-version
      X org.codehaus.plexus/plexus-utils 3.0.24 :older-version
    . org.eclipse.sisu/org.eclipse.sisu.inject 0.3.5
    . com.google.inject/guice$no_aop 4.2.2
      . javax.inject/javax.inject 1
      . aopalliance/aopalliance 1.0
      X com.google.guava/guava 25.1-android :excluded
    . javax.inject/javax.inject 1
    . org.codehaus.plexus/plexus-utils 3.3.1
    . org.codehaus.plexus/plexus-classworlds 2.6.0
    . org.codehaus.plexus/plexus-interpolation 1.26
    . org.codehaus.plexus/plexus-component-annotations 2.1.0
    X org.apache.commons/commons-lang3 3.8.1 :older-version
    . org.slf4j/slf4j-api 1.7.36
  . org.clojure/data.xml 0.2.0-alpha9
  . org.clojure/tools.gitlibs 2.5.197
  . org.clojure/tools.cli 1.1.230
  . com.cognitect.aws/api 0.8.692
    . org.clojure/data.json 2.5.0
    . org.clojure/tools.logging 1.2.4
    . com.cognitect/http-client 1.0.127
      . org.clojure/core.async 1.6.681
      X org.eclipse.jetty/jetty-client 9.4.53.v20231009 :excluded
      X org.eclipse.jetty/jetty-http 9.4.53.v20231009 :excluded
      X org.eclipse.jetty/jetty-util 9.4.53.v20231009 :excluded
    X org.clojure/data.xml 0.2.0-alpha8 :older-version
    . org.clojure/core.async 1.6.681
      . org.clojure/tools.analyzer.jvm 1.2.3
        . org.clojure/tools.analyzer 1.1.1
        . org.clojure/core.memoize 1.0.253
          . org.clojure/core.cache 1.0.225
            . org.clojure/data.priority-map 1.1.0
        . org.ow2.asm/asm 9.2
        . org.clojure/tools.reader 1.3.6
  . org.eclipse.jetty/jetty-http 9.4.53.v20231009
    . org.eclipse.jetty/jetty-util 9.4.53.v20231009
    . org.eclipse.jetty/jetty-io 9.4.53.v20231009
      . org.eclipse.jetty/jetty-util 9.4.53.v20231009
  . org.eclipse.jetty/jetty-client 9.4.53.v20231009
    . org.eclipse.jetty/jetty-http 9.4.53.v20231009
    . org.eclipse.jetty/jetty-io 9.4.53.v20231009
  . com.cognitect.aws/endpoints 1.1.12.718
  . com.cognitect.aws/s3 868.2.1580.0
  . javax.inject/javax.inject 1
org.slf4j/slf4j-nop 1.7.36
  . org.slf4j/slf4j-api 1.7.36

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.