GNU bug report logs - #75008
[PATCH] gnu: elixir: Update to 1.18.0.

Previous Next

Package: guix-patches;

Reported by: Igor Goryachev <igor <at> goryachev.org>

Date: Sat, 21 Dec 2024 16:13:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75008 in the body.
You can then email your comments to 75008 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#75008; Package guix-patches. (Sat, 21 Dec 2024 16:13:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Igor Goryachev <igor <at> goryachev.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 21 Dec 2024 16:13:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Igor Goryachev <igor <at> goryachev.org>
To: guix-patches <at> gnu.org
Cc: Igor Goryachev <igor <at> goryachev.org>, Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
Subject: [PATCH] gnu: elixir: Update to 1.18.0.
Date: Sat, 21 Dec 2024 18:12:23 +0200
* gnu/packages/elixir.scm (elixir): Update to 1.18.0.
[arguments]: Remove obsolete code, reindent comments, make more deterministic.

Change-Id: I6cf8886339cbc4627fb5d89751462b492e7c62f3
---
 gnu/packages/elixir.scm | 37 +++++++++++++++++--------------------
 1 file changed, 17 insertions(+), 20 deletions(-)

diff --git a/gnu/packages/elixir.scm b/gnu/packages/elixir.scm
index 459e160830..eb6146cb11 100644
--- a/gnu/packages/elixir.scm
+++ b/gnu/packages/elixir.scm
@@ -41,7 +41,7 @@ (define-module (gnu packages elixir)
 (define-public elixir
   (package
     (name "elixir")
-    (version "1.17.3")
+    (version "1.18.0")
     (source
      (origin
        (method git-fetch)
@@ -50,7 +50,7 @@ (define-public elixir
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "171l6g304044yk6i0827hgl64vp122ygn1wa1xqdjhw08b5kl2pd"))
+        (base32 "1ki5wfkdidgkvcm3r6b547gkdpchah4r6z0y96frzf5f3prcjgbx"))
        (patches (search-patches "elixir-path-length.patch"))))
     (build-system gnu-build-system)
     (arguments
@@ -95,9 +95,9 @@ (define-public elixir
                 (copy-recursively
                  "lib"
                  (string-append (assoc-ref outputs "src") "/source/lib"))))
-            ;; Temporarily patch the compiler to place correct source
-            ;; locations into module info instead of build directory.
             (add-after 'pre-install-source 'patch-elixir-compiler
+              ;; Temporarily patch the compiler to place correct source
+              ;; locations into module info instead of build directory.
               (lambda* (#:key outputs #:allow-other-keys)
                 (copy-recursively compiler-path compiler-path-orig)
                 (let ((source (string-append "/tmp/guix-build-" #$name "-"
@@ -107,7 +107,18 @@ (define-public elixir
                     (("source, Source")
                      (string-append "source, string:replace(Source, \""
                                     source "\", \"" destination "\")"))))))
-            (add-before 'build 'make-current
+            (add-before 'build 'set-deterministic
+              (lambda _
+                ;; Set deterministic compiler option.
+                (setenv "ERL_COMPILER_OPTIONS" "deterministic")))
+            (add-after 'build 'restore-and-recompile
+              ;; Unpatch the compiler and recompile it.
+              (lambda _
+                (copy-recursively compiler-path-orig compiler-path)
+                (delete-file compiler-path-orig)
+                (invoke "erlc" "-I" "lib/elixir/include"
+                        "-o" "lib/elixir/ebin" compiler-path)))
+            (add-after 'restore-and-recompile 'make-current
               ;; The Elixir compiler checks whether or not to compile files
               ;; by inspecting their timestamps.  When the timestamp is
               ;; equal to the epoch no compilation will be performed.  Some
@@ -117,24 +128,10 @@ (define-public elixir
                             (let ((recent 1400000000))
                               (utime file recent recent 0 0)))
                           (find-files "." ".*"))))
-            ;; Unpatch the compiler and recompile it.
-            (add-after 'build 'restore-and-recompile
-              (lambda _
-                (copy-recursively compiler-path-orig compiler-path)
-                (delete-file compiler-path-orig)
-                (invoke "make")))
             (add-before 'check 'set-home
-              (lambda* (#:key inputs #:allow-other-keys)
+              (lambda _
                 ;; Some tests require access to a home directory.
                 (setenv "HOME" "/tmp")))
-            ;; Temporarily skip several tests related to logger to pass
-            ;; under Erlang 27.1. For more info see:
-            ;; https://elixirforum.com/t/elixir-v1-17-3-released/66156/2
-            (add-before 'check 'disable-some-logger-tests-for-erlang-27.1+
-              (lambda _
-                (substitute* "lib/logger/test/logger/translator_test.exs"
-                  (("test \"translates Supervisor progress")
-                   "@tag :skip\n  test \"translates Supervisor progress"))))
             (delete 'configure)
             (add-after 'install 'wrap-programs
               (lambda* (#:key inputs outputs #:allow-other-keys)

base-commit: 11855e1c2863c56d9a3364cdac614a529a1c7cc2
-- 
2.46.0





Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Sat, 04 Jan 2025 22:25:02 GMT) Full text and rfc822 format available.

Notification sent to Igor Goryachev <igor <at> goryachev.org>:
bug acknowledged by developer. (Sat, 04 Jan 2025 22:25:02 GMT) Full text and rfc822 format available.

Message #10 received at 75008-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Igor Goryachev <igor <at> goryachev.org>
Cc: 75008-done <at> debbugs.gnu.org, Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
Subject: Re: [bug#75008] [PATCH] gnu: elixir: Update to 1.18.0.
Date: Sat, 04 Jan 2025 23:23:40 +0100
Igor Goryachev <igor <at> goryachev.org> skribis:

> * gnu/packages/elixir.scm (elixir): Update to 1.18.0.
> [arguments]: Remove obsolete code, reindent comments, make more deterministic.
>
> Change-Id: I6cf8886339cbc4627fb5d89751462b492e7c62f3

Applied, thanks!




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 02 Feb 2025 12:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 39 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.