GNU logs - #75024, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#75024: [PATCH] Fix check for underlining capability on ttys
Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 22 Dec 2024 13:15:02 +0000
Resent-Message-ID: <handler.75024.B.173487324513268 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 75024 <at> debbugs.gnu.org
From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Date: Sun, 22 Dec 2024 14:13:54 +0100
Message-ID: <m234ifoo6l.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=2a00:1450:4864:20::52b;
 envelope-from=gerd.moellmann@HIDDEN; helo=mail-ed1-x52b.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

--=-=-=
Content-Type: text/plain

Tags: patch

With current master

emacs -nw -Q on Terminal.app, $TERM=xterm-256color

1. (display-supports-face-attributes-p '(underline t))
     => nil

2. C-h f context-menu-map RET
   => The separator line in *Help* in underlined, which
   means that term.c thinks that underlines can be used.

display-supports-face-attribute-p uses tty_capable_p in term.c.
This code in tty_capable_p looks wrong:

  TTY_CAPABLE_P_TRY (tty,
		     TTY_CAP_UNDERLINE,	  tty->TS_enter_underline_mode,
		     NC_UNDERLINE);
  TTY_CAPABLE_P_TRY (tty,
		     TTY_CAP_UNDERLINE_STYLED,	  tty->TF_set_underline_style,
		     NC_UNDERLINE);

It returns false as soon as it finds TS_enter_underline_mode is cannot
be used, and doesn't check TS_set_underline_style. The output code uses
one or the other

  if (face->underline && MAY_USE_WITH_COLORS_P (tty, NC_UNDERLINE))
    {
      if (face->underline == FACE_UNDERLINE_SINGLE
	  || !tty->TF_set_underline_style)
	OUTPUT1_IF (tty, tty->TS_enter_underline_mode);
      else if (tty->TF_set_underline_style)
	{
	  char *p;
	  p = tparam (tty->TF_set_underline_style, NULL, 0, face->underline, 0, 0, 0);
	  OUTPUT (tty, p);
	  xfree (p);
	}
    }

In GNU Emacs 31.0.50 (build 6, aarch64-apple-darwin24.2.0) of 2024-12-22
 built on pro2
Repository revision: d481da70010eab163d12f770ed11f8fef171406a
Repository branch: cl-packages
System Description:  macOS 15.2

Configured using:
 'configure --without-ns --cache-file
 /var/folders/1d/k_6t25f94sl83szqbf8gpkrh0000gn/T//config.cache.cl-packages
 --with-native-compilation --with-mps=yes CC=clang
 'CFLAGS=-Wgnu-imaginary-constant -Wunused-result -g
 -fno-omit-frame-pointer -F
 /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks
 -Wno-ignored-attributes -Wno-flag-enum -Wno-missing-method-return-type
 -Wno-variadic-macros -Wno-strict-prototypes -Wno-availability
 -Wno-nullability-completeness' --prefix=/Users/gerd/.local'


--=-=-=
Content-Type: text/patch
Content-Disposition: attachment;
 filename=0001-Fix-check-for-underlining-capability-on-ttys.patch

From 419a5fa0fd98f673660b123f5b37c99cd0b8c61b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gerd=20M=C3=B6llmann?= <gerd@HIDDEN>
Date: Sun, 22 Dec 2024 14:11:33 +0100
Subject: [PATCH] Fix check for underlining capability on ttys

* src/term.c (tty_capable_p): Check both possible terminal capabilities
for underlining.
---
 src/term.c | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/src/term.c b/src/term.c
index f2d1846e488..875d4d2deff 100644
--- a/src/term.c
+++ b/src/term.c
@@ -2113,18 +2113,20 @@ turn_off_face (struct frame *f, struct face *face)
 tty_capable_p (struct tty_display_info *tty, unsigned int caps)
 {
 #ifndef HAVE_ANDROID
-#define TTY_CAPABLE_P_TRY(tty, cap, TS, NC_bit)				\
-  if ((caps & (cap)) && (!(TS) || !MAY_USE_WITH_COLORS_P (tty, NC_bit)))	\
-    return 0;
+# define TTY_CAPABLE_P(tty, cap, TS, NC_bit) \
+   ((caps & (cap)) && (TS) && MAY_USE_WITH_COLORS_P (tty, NC_bit))
+# define TTY_CAPABLE_P_TRY(tty, cap, TS, NC_bit) \
+  if (!TTY_CAPABLE_P (tty, cap, TS, NC_bit)) \
+    return false;
+
+  if (!TTY_CAPABLE_P (tty, TTY_CAP_UNDERLINE, tty->TS_enter_underline_mode,
+		      NC_UNDERLINE)
+      && !TTY_CAPABLE_P (tty, TTY_CAP_UNDERLINE_STYLED,
+			 tty->TF_set_underline_style, NC_UNDERLINE))
+    return false;
 
   TTY_CAPABLE_P_TRY (tty,
 		     TTY_CAP_INVERSE,	  tty->TS_standout_mode, NC_REVERSE);
-  TTY_CAPABLE_P_TRY (tty,
-		     TTY_CAP_UNDERLINE,	  tty->TS_enter_underline_mode,
-		     NC_UNDERLINE);
-  TTY_CAPABLE_P_TRY (tty,
-		     TTY_CAP_UNDERLINE_STYLED,	  tty->TF_set_underline_style,
-		     NC_UNDERLINE);
   TTY_CAPABLE_P_TRY (tty,
 		     TTY_CAP_BOLD,	  tty->TS_enter_bold_mode, NC_BOLD);
   TTY_CAPABLE_P_TRY (tty,
@@ -2135,8 +2137,7 @@ #define TTY_CAPABLE_P_TRY(tty, cap, TS, NC_bit)				\
 		     TTY_CAP_STRIKE_THROUGH, tty->TS_enter_strike_through_mode,
 		     NC_STRIKE_THROUGH);
 
-  /* We can do it!  */
-  return 1;
+  return true;
 #else
   return false;
 #endif
-- 
2.47.1


--=-=-=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Subject: bug#75024: Acknowledgement ([PATCH] Fix check for underlining
 capability on ttys)
Message-ID: <handler.75024.B.173487324513268.ack <at> debbugs.gnu.org>
References: <m234ifoo6l.fsf@HIDDEN>
X-Gnu-PR-Message: ack 75024
X-Gnu-PR-Package: emacs
X-Gnu-PR-Keywords: patch
Reply-To: 75024 <at> debbugs.gnu.org
Date: Sun, 22 Dec 2024 13:15:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 75024 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
75024: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D75024
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#75024: [PATCH] Fix check for underlining capability on ttys
Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 23 Dec 2024 05:54:01 +0000
Resent-Message-ID: <handler.75024.B75024.17349332371173 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 75024 <at> debbugs.gnu.org
From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
In-Reply-To: <m234ifoo6l.fsf@HIDDEN> ("Gerd =?UTF-8?Q?M=C3=B6llmann?="'s message of "Sun, 22 Dec 2024 14:13:54 +0100")
References: <m234ifoo6l.fsf@HIDDEN>
Date: Mon, 23 Dec 2024 06:52:45 +0100
Message-ID: <m25xnbx7wy.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes:

> Tags: patch

Please disregard the patch. I'll send another one later.

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#75024: [PATCH] Fix check for underlining capability on ttys
Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 23 Dec 2024 07:56:02 +0000
Resent-Message-ID: <handler.75024.B75024.173494053425675 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 75024 <at> debbugs.gnu.org
Cc: Mohsin Kaleem <mohkale@HIDDEN>
From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
In-Reply-To: <m25xnbx7wy.fsf@HIDDEN> ("Gerd =?UTF-8?Q?M=C3=B6llmann?="'s message of "Mon, 23 Dec 2024 06:52:45 +0100")
References: <m234ifoo6l.fsf@HIDDEN> <m25xnbx7wy.fsf@HIDDEN>
Date: Mon, 23 Dec 2024 08:54:29 +0100
Message-ID: <m2ttauj0lm.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes:

> Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes:
>
>> Tags: patch
>
> Please disregard the patch. I'll send another one later.

I meanwhile found this, to my great surprise:

#define TTY_CAP_UNDERLINE_STYLED	(0x32 & TTY_CAP_UNDERLINE)

That makes TTY_CAP_UNDERLINE_STYLED =3D=3D TTY_CAP_UNDERLINE. And this test
in tty_capable_p

  TTY_CAPABLE_P_TRY (tty,
		     TTY_CAP_UNDERLINE,	  tty->TS_enter_underline_mode,
		     NC_UNDERLINE);
  TTY_CAPABLE_P_TRY (tty,
		     TTY_CAP_UNDERLINE_STYLED,	  tty->TF_set_underline_style,

fails because it tests TTY_CAP_UNDERLINE twice, and requires both
TS_enter_underline_mode and TF_set_underline_style to be usable for
underline support. In Terminal.app, only TS_enter_underline_mode is
available.

Maybe this should have been=20

#define TTY_CAP_UNDERLINE_STYLED	0x40

?

BTW, the 0x32 also also makes no sense to me because of=20

#define TTY_CAP_ITALIC  	0x10
#define TTY_CAP_STRIKE_THROUGH	0x20

CC to the original author to check.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#75024: [PATCH] Fix check for underlining capability on ttys
Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 05 Jan 2025 04:09:01 +0000
Resent-Message-ID: <handler.75024.B75024.173605009628057 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75024
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: 75024 <at> debbugs.gnu.org
Cc: Mohsin Kaleem <mohkale@HIDDEN>
Received: via spool by 75024-submit <at> debbugs.gnu.org id=B75024.173605009628057
          (code B ref 75024); Sun, 05 Jan 2025 04:09:01 +0000
Received: (at 75024) by debbugs.gnu.org; 5 Jan 2025 04:08:16 +0000
Received: from localhost ([127.0.0.1]:58266 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tUHvz-0007IT-U6
	for submit <at> debbugs.gnu.org; Sat, 04 Jan 2025 23:08:16 -0500
Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:52424)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>)
 id 1tUHvw-0007II-28
 for 75024 <at> debbugs.gnu.org; Sat, 04 Jan 2025 23:08:14 -0500
Received: by mail-wr1-x42e.google.com with SMTP id
 ffacd0b85a97d-3862ca8e0bbso10194694f8f.0
 for <75024 <at> debbugs.gnu.org>; Sat, 04 Jan 2025 20:08:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1736050090; x=1736654890; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:user-agent:message-id:date
 :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=xi1uFWVVzF9L3BUsWwjw342P+Yo/8ds5o6aURYv/sus=;
 b=KH7xug+9XTHK6AVwyAzh6CFPjqVe1z3HfMqN7kmcu7Wwz1Bn0Yhuh/pF368YhksT7w
 Bc32SCXVBXPvde+Y+XfsCwTUnahlN43T0qtGoVgn3XBwPtfZo2MeUgs5cZPFcK8YobUk
 G9wVVuay1tuqr6wOUkX8fk3Ko4mZWuE3SlYZtZPVufYhaKjpOJnIgv0T2fowUfprSxcY
 HItfrwF0HE210oNnsgamPblhWUZZKJjhVLz7yPLoMaqren8wSl+5v5lvu2PlEimfzcS2
 kumiv/xSOl2Ruj1fpuM0MebJzGZFMbBJvGGISEYIkKRxSCF2xcCbyzYjpHGVo57iNt9L
 OHLA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1736050090; x=1736654890;
 h=content-transfer-encoding:mime-version:user-agent:message-id:date
 :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
 :to:cc:subject:date:message-id:reply-to;
 bh=xi1uFWVVzF9L3BUsWwjw342P+Yo/8ds5o6aURYv/sus=;
 b=OziYfTIULaKNjermHXnFayTekAiSFVInvxO+K0iH1bDft+jmhHT9PHlnhZVlk3rwDI
 B7XT0aYLmenVNH3OS3z6lrrFPOXAAZiLlTDQ23uQAgQ+vKRht8KdkHMOIfPkO8Ns4N3y
 C5vW5wHzf9fE0LmLdfOsokmijYgYRRobXMubR+uf1GD6O+Ly3iC94R+PhIVJLtmdvkOg
 At1bg58BQUMd0Q8x6UnXYuJN8uBCP/zIi02/ztRmcpe0aLdFEsj5dXnosSUZPdkgefCG
 PUa6ypbrO4PorO5UE5BSIv2DkBAu0XlYEUOJ8r3et3QK4p+f2ESn2DBmmUHLHZf5MmhN
 w1jA==
X-Gm-Message-State: AOJu0YwH7wDYwxPkkwAz55AY1xmtnhL3/6iSV9L25htaojy3aPOHzQr4
 fcug+ofAH+GqGhnkjn1G9OOZY8s+ADIIbnZZux6hYQ+6jAmulmYH
X-Gm-Gg: ASbGncuvOlDilLjPxY9w5yeYtgco/vdrmEE9v9xYltWm8DjJeH23mB44rmjZdTuzvn4
 thn9yCUj8DLn06YJ3K4GvAtiAGzOpjomWTfLDjGopuEc581sidhkLfxdHzoOKyj6bRq4+bRwKxY
 lNBwjxIsS8SH1aft+NG9D1IvX/PabcHCqJz9ZzPD+ZLiCXqQgY3iDwvr4cFWG4unjrwCfWhbfpl
 FEhUJLLlH9KWOxPetURG91QY4XE8hqK0oSaOATW2SGvol3GQagCzG6aQgC5EPkRwmcEKSBAeM7c
 Wu5ShiKX4tEG2xQwXp9MfHoKy6uoYRhCFNPpPA+y2am9P+DIE66HQ9tv/HFa480pbw==
X-Google-Smtp-Source: AGHT+IEK7wDyXw+0vilVaV0+dN4iW6PiXgnnNj1oWKEGcBrtPAl0ZOENoMnLkp4GMzaZ09BdVWv62A==
X-Received: by 2002:a5d:5f4f:0:b0:386:375a:8322 with SMTP id
 ffacd0b85a97d-38a221ea68cmr46738957f8f.13.1736050090367; 
 Sat, 04 Jan 2025 20:08:10 -0800 (PST)
Received: from pro2 (p200300e0b747500078d774d9859911e7.dip0.t-ipconnect.de.
 [2003:e0:b747:5000:78d7:74d9:8599:11e7])
 by smtp.gmail.com with ESMTPSA id
 ffacd0b85a97d-38a1c8a8d32sm44901663f8f.99.2025.01.04.20.08.08
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 04 Jan 2025 20:08:09 -0800 (PST)
From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
In-Reply-To: <m2ttauj0lm.fsf@HIDDEN> ("Gerd =?UTF-8?Q?M=C3=B6llmann?="'s message of "Mon, 23 Dec 2024 08:54:29 +0100")
References: <m234ifoo6l.fsf@HIDDEN> <m25xnbx7wy.fsf@HIDDEN>
 <m2ttauj0lm.fsf@HIDDEN>
Date: Sun, 05 Jan 2025 05:08:07 +0100
Message-ID: <m25xmtx5qw.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


Hi Mohsin, friendly ping. Could you find the time to look at this?

Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes:

> Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes:
>
>> Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes:
>>
>>> Tags: patch
>>
>> Please disregard the patch. I'll send another one later.
>
> I meanwhile found this, to my great surprise:
>
> #define TTY_CAP_UNDERLINE_STYLED	(0x32 & TTY_CAP_UNDERLINE)
>
> That makes TTY_CAP_UNDERLINE_STYLED =3D=3D TTY_CAP_UNDERLINE. And this te=
st
> in tty_capable_p
>
>   TTY_CAPABLE_P_TRY (tty,
> 		     TTY_CAP_UNDERLINE,	  tty->TS_enter_underline_mode,
> 		     NC_UNDERLINE);
>   TTY_CAPABLE_P_TRY (tty,
> 		     TTY_CAP_UNDERLINE_STYLED,	  tty->TF_set_underline_style,
>
> fails because it tests TTY_CAP_UNDERLINE twice, and requires both
> TS_enter_underline_mode and TF_set_underline_style to be usable for
> underline support. In Terminal.app, only TS_enter_underline_mode is
> available.
>
> Maybe this should have been=20
>
> #define TTY_CAP_UNDERLINE_STYLED	0x40
>
> ?
>
> BTW, the 0x32 also also makes no sense to me because of=20
>
> #define TTY_CAP_ITALIC  	0x10
> #define TTY_CAP_STRIKE_THROUGH	0x20
>
> CC to the original author to check.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#75024: [PATCH] Fix check for underlining capability on ttys
Resent-From: Mohsin Kaleem <mohkale@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 05 Jan 2025 11:37:02 +0000
Resent-Message-ID: <handler.75024.B75024.173607702120823 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75024
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>, 75024 <at> debbugs.gnu.org
Received: via spool by 75024-submit <at> debbugs.gnu.org id=B75024.173607702120823
          (code B ref 75024); Sun, 05 Jan 2025 11:37:02 +0000
Received: (at 75024) by debbugs.gnu.org; 5 Jan 2025 11:37:01 +0000
Received: from localhost ([127.0.0.1]:60170 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tUOwH-0005Pk-3n
	for submit <at> debbugs.gnu.org; Sun, 05 Jan 2025 06:37:01 -0500
Received: from 119.ip-51-38-65.eu ([51.38.65.119]:54680 helo=kisara.moe)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <mohkale@HIDDEN>)
 id 1tUOwE-0005PP-3x
 for 75024 <at> debbugs.gnu.org; Sun, 05 Jan 2025 06:36:59 -0500
Received: from mk-desktop (unknown [143.58.198.125])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1)
 server-digest SHA256) (No client certificate requested)
 by kisara.moe (Postfix) with ESMTPSA id 375F5A2CF0;
 Sun, 05 Jan 2025 12:36:51 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kisara.moe;
 s=default; t=1736077011;
 bh=OG+5LsE+ymZ6PC9NqRZWkF/xTslPvVoSwEPLJyTYqCU=;
 h=From:To:Subject:In-Reply-To:References:Date:From;
 b=VXcu3BEfRDlGy1U89F1GpI+gtWWl0QJj/J1qzhsRWYHct+JNT2ktSaQMK4vxif5Se
 s/ZTwlwB/R50uBodX2gqXcZTQccxV8NHq7RjQs265W2RHCSt8eiCZ81wvDpy8jDT0+
 T6MFNNZDXEslfihNC5qSv/2dGDXyVO6NgTrZw80xLzKsmY9OqpgtsBipTdkPHrvf6D
 /Ec2KT+2SxM4BE14DTTVGPitKTJexzKECvBWyTknGdAcADyxRbfVjvvtUWO/YYKhNK
 6WMlfktFH7gqNbVmjRNDd3MVbms8ZvMK7jIWDuPUzuoiQuxkTeisAFEqYcDXJvkfhv
 pwuXjtLP6Mi0Q==
From: Mohsin Kaleem <mohkale@HIDDEN>
In-Reply-To: <m25xmtx5qw.fsf@HIDDEN>
References: <m234ifoo6l.fsf@HIDDEN> <m25xnbx7wy.fsf@HIDDEN>
 <m2ttauj0lm.fsf@HIDDEN> <m25xmtx5qw.fsf@HIDDEN>
Date: Sun, 05 Jan 2025 11:36:50 +0000
Message-ID: <874j2dh4q5.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.4 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.6 (/)

Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes:

Hi there,

Sorry for the late response.

>> I meanwhile found this, to my great surprise:
>>
>> #define TTY_CAP_UNDERLINE_STYLED	(0x32 & TTY_CAP_UNDERLINE)
>>
>> That makes TTY_CAP_UNDERLINE_STYLED =3D=3D TTY_CAP_UNDERLINE. And this t=
est
>> in tty_capable_p
>>
>>   TTY_CAPABLE_P_TRY (tty,
>> 		     TTY_CAP_UNDERLINE,	  tty->TS_enter_underline_mode,
>> 		     NC_UNDERLINE);
>>   TTY_CAPABLE_P_TRY (tty,
>> 		     TTY_CAP_UNDERLINE_STYLED,	  tty->TF_set_underline_style,
>>
>> fails because it tests TTY_CAP_UNDERLINE twice, and requires both
>> TS_enter_underline_mode and TF_set_underline_style to be usable for
>> underline support. In Terminal.app, only TS_enter_underline_mode is
>> available.
>>
>> Maybe this should have been=20
>>
>> #define TTY_CAP_UNDERLINE_STYLED	0x40
>>
>> ?

Ah, yep. The original intention was or a new bit flag with the existing
underline bit flag so that styled underlines were only available in
environments with at least regular underlines. In retrospect that was
probably excessive and simply checking for styled underline support by
itself (with a value of 0x40) is sufficient. I'd find it strange to have
a terminal that supported styled underlines but not regular ones but
there's no need to enforce this on the Emacs side.

>>
>> BTW, the 0x32 also also makes no sense to me because of=20
>>
>> #define TTY_CAP_ITALIC  	0x10
>> #define TTY_CAP_STRIKE_THROUGH	0x20
>>
>> CC to the original author to check.

Correct here as well, I should've confirmed the binary representation
:-(.

0b00000000000000000000000000010000 0o00000000020 0d0000000016 0x00000010
0b00000000000000000000000000100000 0o00000000040 0d0000000032 0x00000020
0b00000000000000000000000000110010 0o00000000062 0d0000000050 0x00000032
0b00000000000000000000000001000000 0o00000000100 0d0000000064 0x00000040

0x40 is what the next entry in the flag should have been.

--=20
Mohsin Kaleem

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#75024: [PATCH] Fix check for underlining capability on ttys
Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 05 Jan 2025 11:50:02 +0000
Resent-Message-ID: <handler.75024.B75024.173607774523273 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75024
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Mohsin Kaleem <mohkale@HIDDEN>
Cc: 75024 <at> debbugs.gnu.org
Received: via spool by 75024-submit <at> debbugs.gnu.org id=B75024.173607774523273
          (code B ref 75024); Sun, 05 Jan 2025 11:50:02 +0000
Received: (at 75024) by debbugs.gnu.org; 5 Jan 2025 11:49:05 +0000
Received: from localhost ([127.0.0.1]:60199 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tUP7x-00063J-5E
	for submit <at> debbugs.gnu.org; Sun, 05 Jan 2025 06:49:05 -0500
Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]:60604)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>)
 id 1tUP7v-00062Q-DR
 for 75024 <at> debbugs.gnu.org; Sun, 05 Jan 2025 06:49:04 -0500
Received: by mail-wm1-x32d.google.com with SMTP id
 5b1f17b1804b1-436202dd7f6so153705775e9.0
 for <75024 <at> debbugs.gnu.org>; Sun, 05 Jan 2025 03:49:03 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1736077737; x=1736682537; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:user-agent:message-id:date
 :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=2ilFNXWOgzZ+2Z9GAZT1rzdfBju8wjXbr3mf19uZt5w=;
 b=AEaHimgTgVI9ZRU4y0VBSV1xuIZz7DthiS38O/KzBhetUDrlKKDxYVuhC6nh/lBJtC
 cpukO4V9SIhMnM5EZcqt5FpLkiqwi/9rTeZz/5of/U056dsWM7AEglGckMIXlP4amuxF
 bim54PrrrIYdPjR8yEqWApDFXPHa7zd8/8rRI4jshaYmpxLSf1i+37Qw5w1tCdXA7Dea
 pEPUbrUJLCSaQ6t7NtZ3MG3WigfMsk8j/3oisHlbSJSrQzTNlKUWKS1yQjvPPO+Leqdv
 0no7BZGqy+jgsE0OBphzKjCd3At5Bfmu1M89V0cnz2qoS6ifZhtNwdNwEToC1GoRwQG4
 1GDg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1736077737; x=1736682537;
 h=content-transfer-encoding:mime-version:user-agent:message-id:date
 :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
 :to:cc:subject:date:message-id:reply-to;
 bh=2ilFNXWOgzZ+2Z9GAZT1rzdfBju8wjXbr3mf19uZt5w=;
 b=j1HtS6d5/XarxEfO9J3ltW4s40CsKoAs9EFPOBtzAZYOALgZ3ZoK6wFonchhr6GtcA
 F2bLU2MT97FNLA6qODJAPsa+g3PQeixbLuCHQJkbtFWHpRzrzSTKiKNVG8emuGYipkfv
 dJ12xzVlZo5TjQT3zpSpA8D4lYFll1KhKfVAWix2LHxOixy8Yig5gNoMrJ5f0KK59iMm
 cfmmxP6RGygHgbUNXk1RVBH6c3XosGLq1IVyJPg0soKvHzOmfAZkfSHRT7aBdOw1IduN
 6rbLs7g7pmC8uTbMHMfYEztG8pMI57UHZ1ZJ/N+7iwHso67GxtjlTroQUIUID0EUnghq
 5EoQ==
X-Gm-Message-State: AOJu0YzLgCNcad+6G1InuhriOKmUgIydqoqufjf+0JXcaqTFEgVjFO9q
 R+E0cVNIQr6nhoo76TpeNmQJjbth6GwNawufEGYY6x15bFYjPMAwmACKNw==
X-Gm-Gg: ASbGncvYiLjhPpGiubda/HFSzMZwLCVT01PXOpPmB5frX6+jQvAqrgokbupOuQzDKfn
 nU1aBsbRGunkkQBBwEQqTWl2j5cW9oz8F6QTG60c8E9zXZWR6tCqJ5dbIwjlTDyUB3VYbVpNSIY
 C6CtlATL0omZLKvo5tLs0z8qa28/oXFp2E3P+k/GqLg1mHANRfJSBpOfBf1VR99cvYF4WjcRnkl
 TJE4yx2vRxe/1dDu+4W/6S5dnw2u7ZtgeTt6czi6BrfTT/WjMgW/Co0gl5M1MJnHiC9mz8M0ijS
 AKodJfBkhwku3pwNJ2zA6AJ9OwyjNNze/p+Nyv+SehAS1qK2jjVfvlpQsFK3CIHUOA==
X-Google-Smtp-Source: AGHT+IFW9dKIY8mXtBUsVT8wYJ0dgXvDIZv+oK5bfu9UhnbqG0en4Y6GszP3vJrNZwYWKhkcHtrBsQ==
X-Received: by 2002:adf:a455:0:b0:385:df4e:366f with SMTP id
 ffacd0b85a97d-38a223f5c78mr33997469f8f.38.1736077736776; 
 Sun, 05 Jan 2025 03:48:56 -0800 (PST)
Received: from pro2 (p200300e0b747500078d774d9859911e7.dip0.t-ipconnect.de.
 [2003:e0:b747:5000:78d7:74d9:8599:11e7])
 by smtp.gmail.com with ESMTPSA id
 5b1f17b1804b1-4366127c639sm531862905e9.31.2025.01.05.03.48.55
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 05 Jan 2025 03:48:56 -0800 (PST)
From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
In-Reply-To: <874j2dh4q5.fsf@HIDDEN> (Mohsin Kaleem's message of "Sun, 05
 Jan 2025 11:36:50 +0000")
References: <m234ifoo6l.fsf@HIDDEN> <m25xnbx7wy.fsf@HIDDEN>
 <m2ttauj0lm.fsf@HIDDEN> <m25xmtx5qw.fsf@HIDDEN>
 <874j2dh4q5.fsf@HIDDEN>
Date: Sun, 05 Jan 2025 12:48:54 +0100
Message-ID: <m2bjwlv5uh.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Mohsin Kaleem <mohkale@HIDDEN> writes:

> Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes:
>
> Hi there,
>
> Sorry for the late response.
>
>>> I meanwhile found this, to my great surprise:
>>>
>>> #define TTY_CAP_UNDERLINE_STYLED	(0x32 & TTY_CAP_UNDERLINE)
>>>
>>> That makes TTY_CAP_UNDERLINE_STYLED =3D=3D TTY_CAP_UNDERLINE. And this =
test
>>> in tty_capable_p
>>>
>>>   TTY_CAPABLE_P_TRY (tty,
>>> 		     TTY_CAP_UNDERLINE,	  tty->TS_enter_underline_mode,
>>> 		     NC_UNDERLINE);
>>>   TTY_CAPABLE_P_TRY (tty,
>>> 		     TTY_CAP_UNDERLINE_STYLED,	  tty->TF_set_underline_style,
>>>
>>> fails because it tests TTY_CAP_UNDERLINE twice, and requires both
>>> TS_enter_underline_mode and TF_set_underline_style to be usable for
>>> underline support. In Terminal.app, only TS_enter_underline_mode is
>>> available.
>>>
>>> Maybe this should have been=20
>>>
>>> #define TTY_CAP_UNDERLINE_STYLED	0x40
>>>
>>> ?
>
> Ah, yep. The original intention was or a new bit flag with the existing
> underline bit flag so that styled underlines were only available in
> environments with at least regular underlines. In retrospect that was
> probably excessive and simply checking for styled underline support by
> itself (with a value of 0x40) is sufficient. I'd find it strange to have
> a terminal that supported styled underlines but not regular ones but
> there's no need to enforce this on the Emacs side.
>
>>>
>>> BTW, the 0x32 also also makes no sense to me because of=20
>>>
>>> #define TTY_CAP_ITALIC  	0x10
>>> #define TTY_CAP_STRIKE_THROUGH	0x20
>>>
>>> CC to the original author to check.
>
> Correct here as well, I should've confirmed the binary representation
> :-(.
>
> 0b00000000000000000000000000010000 0o00000000020 0d0000000016 0x00000010
> 0b00000000000000000000000000100000 0o00000000040 0d0000000032 0x00000020
> 0b00000000000000000000000000110010 0o00000000062 0d0000000050 0x00000032
> 0b00000000000000000000000001000000 0o00000000100 0d0000000064 0x00000040
>
> 0x40 is what the next entry in the flag should have been.

Thanks for checking, Mohsin!

Would you perhaps have the time to prepare a patch that fixes this?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#75024: [PATCH] Fix check for underlining capability on ttys
Resent-From: Mohsin Kaleem <mohkale@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 05 Jan 2025 11:54:01 +0000
Resent-Message-ID: <handler.75024.B75024.173607799624225 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75024
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Cc: 75024 <at> debbugs.gnu.org
Received: via spool by 75024-submit <at> debbugs.gnu.org id=B75024.173607799624225
          (code B ref 75024); Sun, 05 Jan 2025 11:54:01 +0000
Received: (at 75024) by debbugs.gnu.org; 5 Jan 2025 11:53:16 +0000
Received: from localhost ([127.0.0.1]:60212 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tUPC0-0006Ie-IY
	for submit <at> debbugs.gnu.org; Sun, 05 Jan 2025 06:53:16 -0500
Received: from 119.ip-51-38-65.eu ([51.38.65.119]:56716 helo=kisara.moe)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <mohkale@HIDDEN>)
 id 1tUPBz-0006IE-8K
 for 75024 <at> debbugs.gnu.org; Sun, 05 Jan 2025 06:53:16 -0500
Received: from mk-desktop (unknown [143.58.198.125])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1)
 server-digest SHA256) (No client certificate requested)
 by kisara.moe (Postfix) with ESMTPSA id ABAEDA2CF0;
 Sun, 05 Jan 2025 12:53:08 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kisara.moe;
 s=default; t=1736077988;
 bh=/A5+b1IMGS7uFJxPyhbY9eMCzA6LClNwHzmHWrR2S6I=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=kkpd5TZ7rEUDv+Vcm8bcmP5I3bCNfzYY83qleTMJs5H60iQORKU3Cf7Zco4tUO2qH
 muG5x9fQC/atlR1GJ6CZfyc2i3JUYcNEHqgy8wAcw9lzo+7c75ajqnuAjdi9Sqnblu
 WwUbN2y95mHTWRnS/P3bBsaUa3MExxnaSg+3Azhbm+nC29j381pZalUfh0mMZXDaJ/
 UwivyjNyqinnoh0Fjd3fhToG78S2/DQ8fEErXVTKPYRSypsdHU+46FU/6WIlePvgV0
 i4dBDSeeJBvFqFzP9/SND/kZ/KvJbtJT6REdvOycexGj2IS/fkd3k4ko6owJ8dxIAp
 KyqcNryB/OoWQ==
From: Mohsin Kaleem <mohkale@HIDDEN>
In-Reply-To: <m2bjwlv5uh.fsf@HIDDEN>
References: <m234ifoo6l.fsf@HIDDEN> <m25xnbx7wy.fsf@HIDDEN>
 <m2ttauj0lm.fsf@HIDDEN> <m25xmtx5qw.fsf@HIDDEN>
 <874j2dh4q5.fsf@HIDDEN> <m2bjwlv5uh.fsf@HIDDEN>
Date: Sun, 05 Jan 2025 11:53:08 +0000
Message-ID: <871pxhh3yz.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.4 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.6 (/)

Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes:

> Would you perhaps have the time to prepare a patch that fixes this?

I'm a bit swamped atm but could try prepping something in the next few
weeks. Hopefully shouldn't be too big of a change :-).

--=20
Mohsin Kaleem

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#75024: [PATCH] Fix check for underlining capability on ttys
Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 05 Jan 2025 11:56:01 +0000
Resent-Message-ID: <handler.75024.B75024.173607811024461 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75024
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Mohsin Kaleem <mohkale@HIDDEN>
Cc: 75024 <at> debbugs.gnu.org
Received: via spool by 75024-submit <at> debbugs.gnu.org id=B75024.173607811024461
          (code B ref 75024); Sun, 05 Jan 2025 11:56:01 +0000
Received: (at 75024) by debbugs.gnu.org; 5 Jan 2025 11:55:10 +0000
Received: from localhost ([127.0.0.1]:60216 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tUPDp-0006MS-06
	for submit <at> debbugs.gnu.org; Sun, 05 Jan 2025 06:55:09 -0500
Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]:48611)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>)
 id 1tUPDm-0006Le-N6
 for 75024 <at> debbugs.gnu.org; Sun, 05 Jan 2025 06:55:07 -0500
Received: by mail-wm1-x333.google.com with SMTP id
 5b1f17b1804b1-436ce2ab251so10990695e9.1
 for <75024 <at> debbugs.gnu.org>; Sun, 05 Jan 2025 03:55:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1736078100; x=1736682900; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:user-agent:message-id:date
 :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=SRH2FuwS/oAsD3WNEUtJGvXY6gOG2kjadAUu1u3YJ/M=;
 b=jWPd/pxck9o8udJrr6gvlOlQyC/XLmh0GCz37/75qfrv2za+TikvwlqWPjN7X2vg9A
 lvfFChHFqOgKG6NiQzgauFVn0hnccrCQfup/L0XMip4BHVKcnGafV0SX9rqrjcMezxHX
 C7pVnA6/GRHh0g45gT4YZhNA2xmkvPsueG+xROicVyagmMbk5FrUjNZxuuwZBlnhyynx
 jmQN23M6OoA9rQvdT8gXDlO3Chww/HFlOqcVHHzJJvvo8HmE6pYEQ83eejXGMsovs+3J
 oPiVzSzjnDsKLTb6YZJbQHHbEG9p1t3nQl0So7Oesiddfx7kdDDTRefEXTU1Zx40c4PY
 Q+bw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1736078100; x=1736682900;
 h=content-transfer-encoding:mime-version:user-agent:message-id:date
 :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
 :to:cc:subject:date:message-id:reply-to;
 bh=SRH2FuwS/oAsD3WNEUtJGvXY6gOG2kjadAUu1u3YJ/M=;
 b=jHTV1mTMCPsoxMCXg7SgSB03+dk1poO5E8g+SiWt9EzYPsusgrm4KgS1jUw4awOLEJ
 tfKRtBXt7s5ISt77yKG+qg6eO/X5Wvy/Zdbv2XidE1r2+3lt6rt4KhB1DN6QMeuw/1Se
 nFf2BkU5hLLpuz2ZcaWnKNnBO+InpUIpgrngc6CNPtaumdxl9hfH6npf4q8z/slHdkK5
 ZQ10SG517GWRmehlCagpxe8UNeDjfATMVSmwwYqFMD3bYv7kXcJ8nbNdngOC4z8m+WFS
 0N7QHAqD5nirr3K2TCQFXCQUdQHtgeaStw2x8VE0SZtUlM3LkFlew98D3ZNfUcOKYCKf
 49rw==
X-Gm-Message-State: AOJu0Yze6eFxScJkefPHx8J/EDOwz01qcmsyFBrKJq1ZAJjBmGVJDQ2l
 vGyDgewz/LZ5Grav3KtCfXEJ9NaOGo/HxqV6umP2jQLtD5FLg6SriYx+fg==
X-Gm-Gg: ASbGncuEBtnGjh4HlxlDRRqrhTC+blSp8rRu0rRnYa7b8yOUQj6LrkvI0XS1gkiWCPj
 /GcQtfhoInQe+gIi+ZwXiEX0fDah7afD979vrmxkzsS3smrvH/MTiSPQyPqXPRW/OHDJ2UCAYyc
 CWMX+NbBM5vcFzjdKmAPtjk6cZbh5y3fFUq7thOgttblvonwqKUYaTFno3m+jCZW1BTbtfiU9bO
 P3Dn99tOlphBV9B28iB4LfALYRw7BgBdLsKbH64XOMGlmzUaH5mjz09S6Buxh2nXLeOsN9I5tPz
 +UjTMlS1GAFPhvsaAaUTDzPqR9MuzSlabPnyzyxU4W+gN/+LttFtTPzq1+GvQh0RSA==
X-Google-Smtp-Source: AGHT+IGaT4Md5KpbQfR1EDzg68CmsCXiR+Aj6/ZT+ADRkPaKvIaNpU4XD/FZmgik3lFZc0/hlCKRbA==
X-Received: by 2002:a05:600c:45cd:b0:434:a7b6:10e9 with SMTP id
 5b1f17b1804b1-436686462f9mr505643755e9.17.1736078099584; 
 Sun, 05 Jan 2025 03:54:59 -0800 (PST)
Received: from pro2 (p200300e0b747500078d774d9859911e7.dip0.t-ipconnect.de.
 [2003:e0:b747:5000:78d7:74d9:8599:11e7])
 by smtp.gmail.com with ESMTPSA id
 ffacd0b85a97d-38a1c847263sm45172922f8f.50.2025.01.05.03.54.57
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 05 Jan 2025 03:54:58 -0800 (PST)
From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
In-Reply-To: <871pxhh3yz.fsf@HIDDEN> (Mohsin Kaleem's message of "Sun, 05
 Jan 2025 11:53:08 +0000")
References: <m234ifoo6l.fsf@HIDDEN> <m25xnbx7wy.fsf@HIDDEN>
 <m2ttauj0lm.fsf@HIDDEN> <m25xmtx5qw.fsf@HIDDEN>
 <874j2dh4q5.fsf@HIDDEN> <m2bjwlv5uh.fsf@HIDDEN>
 <871pxhh3yz.fsf@HIDDEN>
Date: Sun, 05 Jan 2025 12:54:56 +0100
Message-ID: <m27c79v5kf.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Mohsin Kaleem <mohkale@HIDDEN> writes:

> Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes:
>
>> Would you perhaps have the time to prepare a patch that fixes this?
>
> I'm a bit swamped atm but could try prepping something in the next few
> weeks. Hopefully shouldn't be too big of a change :-).

Thanks!

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 13 Feb 2025 09:58:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 13 04:58:37 2025
Received: from localhost ([127.0.0.1]:40618 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tiVzM-0007DR-9n
	for submit <at> debbugs.gnu.org; Thu, 13 Feb 2025 04:58:37 -0500
Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]:46265)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1tiVzJ-0007DA-Vu
 for control <at> debbugs.gnu.org; Thu, 13 Feb 2025 04:58:30 -0500
Received: by mail-ed1-x532.google.com with SMTP id
 4fb4d7f45d1cf-5de4c7720bcso965218a12.0
 for <control <at> debbugs.gnu.org>; Thu, 13 Feb 2025 01:58:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1739440704; x=1740045504; darn=debbugs.gnu.org;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=P6tYfqMjpqycMOUkVLEEak5qKfyer21N0lY4PtqgSrI=;
 b=E6hPBxNZQLBcJRpq864E3vtPPKlfPDX7j7GqedxUtBRav2WsNzEcW4UV+wNrZBMt0t
 z0DRSrhWd9Ynxgr0gxlJd8UKVRHr6z01VnpUIXbGTKC2i2Q8ApDMWjVp8u0gyFtjeW/i
 abh7C+cj2QhNvnYL1uF+yhLz8C+46cdxkeXY0sAxBWi6gwWH+jjYjW0l4X8h++OOCXV1
 v0JqZtsh9ccffS9bE4BOC5X6upfY6T61QZ6Maql5jc/5Mqnc52dLc7gs9u4woPskH3SD
 /ocwiqJ1fVjdJMmxTS+QERBHoTa0hfcU/9B1/uysgn8+Y4DuBXkjkPL+EzxMMizaFuFP
 RONQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1739440704; x=1740045504;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=P6tYfqMjpqycMOUkVLEEak5qKfyer21N0lY4PtqgSrI=;
 b=MhtVSMmJNCq7n6V4UU3nIbxWpo//QJ/0+BC1ssVmw0RXBJ+GRqrU5FmiSNjH8Chrjr
 FRDShx4Fm8SF5qXCRenkdqYGAgtLcPFuQI7vhi0i4EzvToe9HicFizMBmzgMg+Q8EWb3
 3bNvp59sLep/dXq53EcW8c4C82y3LYk0mc1zIXSV65u7TIfFlR3X/etaRiJdSwkHfVHE
 2VmAQi4EX8/57vA9IvvMm+KUxi7w9jusRSUi9NY4xgd5i/bb8vm0jAtyP2W/t/oCmK5h
 upomunrfFtyndxdjqksbKLHpEbP/f7erqDwrP5xp2DZ0hWATZKsLzpKE8CMAcs8remfT
 PWTQ==
X-Gm-Message-State: AOJu0YzIoIE9Gq+kO5zph3N+6RrJCf27NXjn8umdVZY4bzSliF6y4XPn
 PXMorfD34FWVC8idUFs+qOL0RvCyYui+aVRL0bCCkfjS3XpWEEoN6Mpid/EVctKmpK1Zf0XXSuO
 fwwlH7UeyyeIqsAw+lIOmjINPU9V1PKlVaSs/Fg==
X-Gm-Gg: ASbGncsfaeBKMoyKjIznIJw+CR4a6vuS9tz45VI1PYWk9O0ay0RYkJgAsfVqeTfvm2u
 VlXSDNwasF9b2PxY/tHlwqgEEMZPmfHvJ7zvSQvTtegLyHNSbK/W7lFI7es7V7tQuyIxD/wF9aL
 0=
X-Google-Smtp-Source: AGHT+IEo2OQ/Mg4HZSBXrsO7CkuYwc8Xyqc7JaXpEbf6eDz5B9sDh6Da3EDTDa312zUQtdwJQ26sXWENPnzxMGM5k/Q=
X-Received: by 2002:a17:907:3d87:b0:ab6:db3e:2649 with SMTP id
 a640c23a62f3a-ab7f33a3b39mr681032566b.14.1739440703712; Thu, 13 Feb 2025
 01:58:23 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Thu, 13 Feb 2025 01:58:22 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
MIME-Version: 1.0
Date: Thu, 13 Feb 2025 01:58:22 -0800
X-Gm-Features: AWEUYZmbmqUW-Amw6pyJkyfgq3RhZDCLze-rOPNhmHABaIT16soHbhqUEMMEnhc
Message-ID: <CADwFkm=Q_=Px63pmM+GRxbRmmMgGaGF9JZF6qSeWXCQ6cNFsTw@HIDDEN>
Subject: control message for bug #75024
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 75024 - patch
quit

Last modified: Thu, 13 Feb 2025 10:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.