X-Loop: help-debbugs@HIDDEN Subject: bug#75084: bug report with patch 0003-Fix-make-custom-port-in-case-encoding-is-f.patch Resent-From: Hannes =?UTF-8?Q?M=C3=BCller?= <h.c.f.mueller@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-guile@HIDDEN Resent-Date: Wed, 25 Dec 2024 12:51:02 +0000 Resent-Message-ID: <handler.75084.B.173513102310051 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 75084 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: 75084 <at> debbugs.gnu.org X-Debbugs-Original-To: bug-guile@HIDDEN Received: via spool by submit <at> debbugs.gnu.org id=B.173513102310051 (code B ref -1); Wed, 25 Dec 2024 12:51:02 +0000 Received: (at submit) by debbugs.gnu.org; 25 Dec 2024 12:50:23 +0000 Received: from localhost ([127.0.0.1]:36479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tQQqF-0002c3-29 for submit <at> debbugs.gnu.org; Wed, 25 Dec 2024 07:50:23 -0500 Received: from lists.gnu.org ([209.51.188.17]:51948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <h.c.f.mueller@HIDDEN>) id 1tQQqC-0002bv-I4 for submit <at> debbugs.gnu.org; Wed, 25 Dec 2024 07:50:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <h.c.f.mueller@HIDDEN>) id 1tQQqA-0006kt-U2 for bug-guile@HIDDEN; Wed, 25 Dec 2024 07:50:18 -0500 Received: from mout.gmx.net ([212.227.15.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <h.c.f.mueller@HIDDEN>) id 1tQQq8-0004eo-Mt for bug-guile@HIDDEN; Wed, 25 Dec 2024 07:50:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1735131013; x=1735735813; i=h.c.f.mueller@HIDDEN; bh=Drf/iPxc8tdGG3N5FHIGc+FxoHkQrpOXsqrcZEk/9D0=; h=X-UI-Sender-Class:MIME-Version:Message-ID:From:To:Subject: Content-Type:Date:cc:content-transfer-encoding:content-type:date: from:message-id:mime-version:reply-to:subject:to; b=njJ5/sgv58GdG9CgAyoOp1ndGcSoIEu5DrMMc55pG5KQiqYoX77Y15dAzLZetE8U +615XWBNA0F2sEh3mXD9psItHA8HKyuj9YDsdZ1XS7O4AKB6BcjMZwD/Vjhnh1hNm OX0lF0YOxGSexJCD+jUzKjjvQ7C83utU+hVeAcSTh3jM9bn0/zUuGn14L8bA3jTOB WLpK6pgAO11VISypz/k3PT72xRdmknCHJytPaZqTsiLjKaW86AUFfOC1AMzggA+hW efpKiEoedTcL6iqrmrmAJFuxj2OAJIXODoONizREMQf9T+135GLUy9KZFMf6TJUMj NAy3Eff+rkWKoyws+A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [79.194.58.247] ([79.194.58.247]) by trinity-msg-rest-gmx-gmx-live-bbc95d94c-jjgc7 (via HTTP); Wed, 25 Dec 2024 12:50:13 +0000 MIME-Version: 1.0 Message-ID: <trinity-93cfa7c9-d4e7-4104-b16c-2054c39da55e-1735131013674@trinity-msg-rest-gmx-gmx-live-bbc95d94c-jjgc7> From: Hannes =?UTF-8?Q?M=C3=BCller?= <h.c.f.mueller@HIDDEN> Content-Type: multipart/mixed; boundary=trekuen-7595b832-6b90-48d2-96cb-d16f6b92b5e0 Date: Wed, 25 Dec 2024 12:50:13 +0000 X-UI-CLIENT-META-MAIL-DROP: W10= X-Provags-ID: V03:K1:iF4yDcubdk6LGSJ9fAcB1cxV0fMr/JXUkLLapD28ryS7ByqdJmOi7j+ST8yxUug5K33Lp CSuNOQZ31x32Yu+mNu2iXxpfTsyAG1Cfej2nk6rrS16TJ1pQXBuGHCBKVO6mRkUiqUCZS2H52mkE iWgpP3Y5wto+bQlP0qpDd2I9uciBcxYW1wvAICv2uukCpx2sBggYeILq6lrVtuSYRA/E1iH0R6lQ dkX83DZC0eU7yYSgRysKNm6wGhkIu9iUU4my7F0YIHXzldrWAwC55hT/mAqWSC3+Vvc1aNr/4scy Q/nTF0EcRyy2gdgR1htIQ2KXxMePHGFT5jZcWcdihntRUY8+oCHc5p931i1CiHB8Yo= X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:vvxcPwt2QVU=;yziM7XjOOgWlYnmnEOmtqLB0E3D c4J3lNYqRXRxkiXGRNuhRMmyRg7pBBkp56VqHI59BNQWKrwd9+z+dosu4ITiYWHe2TE9tQGDk JhxfrPOjqE8zlJV1y+Jib2OTZRzJQlUar0V5gbDesVkpIC+s09Psha6jGfLHhvGPgSFcSAwca ZCmmeHaYulWXo7yEPpCVA2/tTM/IKZfrbGd4AcUuZPaBaeY3QrW8ri3ZPDuxGYUwx9AuDjPXs FRhvXZvFJyDi3B45xw5apUTsrUtOp7U6kO+EIuU5mtggbHOjgh87cszL3whTqMSXcHQ8ON5TO Jij/r7nH0Iy2lV9zAojuh0S7Rq4K64P6g5lblJndEv4jvYKTNAcq3bf5CWbMz9ECZmTFkcCOo vBv1YjCyNg9KdxGXkrOY4gTTyei6xT1IYWiB8vkVg64xaTesBVi1Gr/Jv2V7g/sR7RTcw9FzT KBnCjf2VI91Nh9fItUYs0GwGJpLoJwMJ1WOtNS0N/J7vLELrz+CayrYvVa+BSDFMQJFRytx0b WtfhhzyWyy3+b7wZlXYr2+S6Zm4b/2Z74GlnA7GZla3KaxgIh5FU3X2nS7HX98tJ63LTmJLRy fQQH70zuJX2UXRO6hYYI3/mekSnbP29fENggPp7XiN73DdPXEn7jfE8xhlScQWW69V1dUgflz nlEvDj7b4zszGsiJmlUB2/FKLeIwzLEZaSetAKC3Qgdjc6pQ/3IUYGj6t3bntjWTo32IML+nE SBou68u5j2Pn1y/ztksfHBXYYe0M9OU4jheYvCnVD1ZOm/iXjv8vjxH14LJp0sEdOSgsOnhF5 GzuC20V65WvXTEMqZIjVvtCdBEWRpFiQDECtX9caxV8R/Slq4hwIreGqTpZtgTZSLDOEJyEGT Nbb5ofDZ9d0nR7zqyZoFYrnwSiXL4TDEmsiI= Received-SPF: pass client-ip=212.227.15.18; envelope-from=h.c.f.mueller@HIDDEN; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) --trekuen-7595b832-6b90-48d2-96cb-d16f6b92b5e0 Content-Type: text/html; charset=UTF-8 <div style="font-family: 'verdana'; font-size: 12px; color: #000;"><span style="background-color: rgb(255, 255, 255);">Dear All,</span></div> <div style="font-family: 'verdana'; font-size: 12px; color: #000;"><span style="background-color: rgb(255, 255, 255);">Please review the attached patch.</span></div> <div style="font-family: 'verdana'; font-size: 12px; color: #000;"><span style="background-color: rgb(255, 255, 255);"> </span></div> <div style="font-family: 'verdana'; font-size: 12px; color: #000;"><span style="background-color: rgb(255, 255, 255);">Thanks,</span></div> <div style="font-family: 'verdana'; font-size: 12px; color: #000;"><span style="background-color: rgb(255, 255, 255);">Hannes</span></div> --trekuen-7595b832-6b90-48d2-96cb-d16f6b92b5e0 Content-Type: text/x-patch Content-Disposition: attachment; filename=0003-Fix-make-custom-port-in-case-encoding-is-f.patch X-UI-Content-Hash: 2034d527f647b7128267714c095ac0b38613b1b367e9959f5c6e8ff323a8a925 Content-Transfer-Encoding: quoted-printable =46rom 72b85f8e6a369e6aef4c6bd6bb233c0cacb80b03 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Hannes=3D20M=3DC3=3DBCller?=3D <> Date: Sat, 21 Dec 2024 16:55:13 +0100 Subject: [PATCH] Fix make-custom-port in case encoding is #f * module/ice-9/custom-ports.scm (make-custom-port): Code fails if (fluid-ref %default-port-encoding) returns #f. In fact this was the case why readline support on MSYS2 failed for guile 3.0.10, ref. https://github.com/msys2/MSYS2-packages/issues/5079 But later used canonicalize-encoding is prepared to handle #f for encoding. So allow encoding to also handle this case. =2D-- module/ice-9/custom-ports.scm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/module/ice-9/custom-ports.scm b/module/ice-9/custom-ports.scm index 6010fd94f..bc9de8f64 100644 =2D-- a/module/ice-9/custom-ports.scm +++ b/module/ice-9/custom-ports.scm @@ -127,7 +127,9 @@ (id "custom-port") (print (make-default-print #:id id)) (truncate default-truncate) - (encoding (string->symbol (fluid-ref %default-port-encoding))) + (encoding (if (string? (fluid-ref %default-port-encoding)) + (string->symbol (fluid-ref %default-port-encoding= )) + (fluid-ref %default-port-encoding))) (conversion-strategy (fluid-ref %default-port-conversion-strate= gy)) (close-on-gc? #f)) "Create a custom port whose behavior is determined by the methods passe= d =2D- 2.45.2 --trekuen-7595b832-6b90-48d2-96cb-d16f6b92b5e0--
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Hannes =?UTF-8?Q?M=C3=BCller?= <h.c.f.mueller@HIDDEN> Subject: bug#75084: Acknowledgement (bug report with patch 0003-Fix-make-custom-port-in-case-encoding-is-f.patch) Message-ID: <handler.75084.B.173513102310051.ack <at> debbugs.gnu.org> References: <trinity-93cfa7c9-d4e7-4104-b16c-2054c39da55e-1735131013674@trinity-msg-rest-gmx-gmx-live-bbc95d94c-jjgc7> X-Gnu-PR-Message: ack 75084 X-Gnu-PR-Package: guile Reply-To: 75084 <at> debbugs.gnu.org Date: Wed, 25 Dec 2024 12:51:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-guile@HIDDEN If you wish to submit further information on this problem, please send it to 75084 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 75084: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D75084 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.