GNU bug report logs - #75097
[PATCH rust-team 1/8] gnu: override-jemalloc: Add variable.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Herman Rimm <herman@HIDDEN>; Keywords: patch; dated Wed, 25 Dec 2024 20:22:01 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 75097 <at> debbugs.gnu.org:

Received: (at 75097) by debbugs.gnu.org; 26 Dec 2024 13:45:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Dec 26 08:45:39 2024
Received: from localhost ([127.0.0.1]:40514 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tQoBG-0006sV-Ui
	for submit <at> debbugs.gnu.org; Thu, 26 Dec 2024 08:45:39 -0500
Received: from mail-wr1-f49.google.com ([209.85.221.49]:44519)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <efraim.flashner@HIDDEN>) id 1tQoBD-0006sG-PA
 for 75097 <at> debbugs.gnu.org; Thu, 26 Dec 2024 08:45:36 -0500
Received: by mail-wr1-f49.google.com with SMTP id
 ffacd0b85a97d-385d7f19f20so2999287f8f.1
 for <75097 <at> debbugs.gnu.org>; Thu, 26 Dec 2024 05:45:35 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1735220670; x=1735825470; darn=debbugs.gnu.org;
 h=in-reply-to:content-disposition:mime-version:references
 :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to
 :cc:subject:date:message-id:reply-to;
 bh=ki3VRPoKm8ql4Q/tjft0SiD5Wn3r0qY4AqSPo6EByPk=;
 b=FJLzwpbsZd+u2z0i2OXGak7a3lcipIKuuzqouZ+SukT7xRKwI4KwgIsIdsFj3CdrqH
 957s1gCCWDCZnheexuus2sDELIskvf4HlPSufv+iXAgOjzjDDhQqCg2lrl6FQi4xNOpC
 A/8RsDsGIagxYnnsRXHNymJlolyZqYQpNvc2wATz+V0c/CklAmZEzMbd6Xj4f0Ks+Dff
 znXWtsao4igEr4WljHtPPh3Qfxbq1mnoiqYJZo8HQl3h2/k6WGeoNnvmHAEFUvtdG7JX
 eSSY5dXKig5R4gNfjsUezbjX8WbmCKrCTDBOWMn28Fmf0+VPs7Bl0O0ADfFvPt7fQYC+
 n8Wg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1735220670; x=1735825470;
 h=in-reply-to:content-disposition:mime-version:references
 :mail-followup-to:message-id:subject:cc:to:from:date:sender
 :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=ki3VRPoKm8ql4Q/tjft0SiD5Wn3r0qY4AqSPo6EByPk=;
 b=a+AcCnyAqfoefP8I1H6rL1dk+n6YkCvqGH0erKERQODygqM5pPcsJvi2oCNAnbXwiI
 h619VWYs/RylJRaHU+pRVC5A6AfzaNyo6QvvaXUFZsTsZ+V0XEII8/bKSooegNluWZ00
 NGnoBLhH/o0UezYqdzd9M2pA4TpQzhnmGpTOSN2RxSxH1faI4999C20M/GaDgrT0DzmR
 NsiSNqgD3Z+smpYsE76MCMmTkJpeXStP+pEiE/PmKZxLELnJ89Bmppzk9HwxaVvfLNoK
 yKtXWtbh8TLJ4EQf1muFUZbUTw7nxFdaxKEbMR3KTjjUbZSd9KacMVfsBmq3G56FeGXD
 dStw==
X-Gm-Message-State: AOJu0YyPCysEIISM1TdBW3jKlhq8yOAxNhe7c973/8PPb31LTZGaC2FM
 TvR883T0GbtYXyye3DCuM6hPLFhNB5EvZ0tTOVFB0JliPxn1pmJQ
X-Gm-Gg: ASbGncvLqOq5ISg551F+9od8SDVfS4AbBpeoRBn6W81j5uh+3UoIX+RnL1BtfnH0Rof
 9/aVdBixsLUut0SvugGzv4lFQTjHKje0q4X2OsUzTwOfjLf1jfoAr4BN4wEeSWjr5K4ZaKU7k11
 u/mGtlf7d/lV/IdYFJayOAVDHG8ao1QylZB8cYBDxhIrUlJ+Lehff58I0D3Sw6+mRMnbK9gDdrU
 4Ih/mHPbCEZRqxGtz4z6eomlhOFps6t9o1Qqt73IuHozDdLxZPrEpVWlw==
X-Google-Smtp-Source: AGHT+IGNh/uOWhihohyP3n0c+SB6DbaI4F2eqXmm9+0jfIOHg+prXmQIfDpayMF4pvUUmkcMXx3Inw==
X-Received: by 2002:a05:6000:1ac8:b0:385:f071:a1c9 with SMTP id
 ffacd0b85a97d-38a224049f1mr18455164f8f.50.1735220670010; 
 Thu, 26 Dec 2024 05:44:30 -0800 (PST)
Received: from localhost ([188.120.128.147]) by smtp.gmail.com with ESMTPSA id
 ffacd0b85a97d-38a1c89e2f9sm20027917f8f.81.2024.12.26.05.44.29
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 26 Dec 2024 05:44:29 -0800 (PST)
Date: Thu, 26 Dec 2024 15:44:28 +0200
From: Efraim Flashner <efraim@HIDDEN>
To: Herman Rimm <herman@HIDDEN>
Subject: Re: [bug#75097] [PATCH rust-team 1/8] gnu: override-jemalloc: Add
 variable.
Message-ID: <Z21dvOrma1li0WPe@3900XT>
Mail-Followup-To: Efraim Flashner <efraim@HIDDEN>,
 Herman Rimm <herman@HIDDEN>, 75097 <at> debbugs.gnu.org
References: <25cd151219b68e3f67148dbba6e3674249faee91.1735157957.git.herman@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="fbe4iSm5ZfA4XZeG"
Content-Disposition: inline
In-Reply-To: <25cd151219b68e3f67148dbba6e3674249faee91.1735157957.git.herman@HIDDEN>
X-PGP-Key-ID: 0x41AAE7DCCA3D8351
X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc
X-PGP-Fingerprint: A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
X-Spam-Score: 0.3 (/)
X-Debbugs-Envelope-To: 75097
Cc: 75097 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)


--fbe4iSm5ZfA4XZeG
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

This one I'm unconvinced about.  I could see adding CARGO_FEATURE... to
the cargo-build-system, but this seems like a temporary problem that I
hope gets fixed upstream.  If we move this out to a separate location
I'm worried we'll forget about it when it's no longer needed.

Plus we're using libjemalloc_pic.a here and libjemalloc.so in
rust-apps.scm, and I'd prefer to not hard-code one or the other.

On Wed, Dec 25, 2024 at 09:20:20PM +0100, Herman Rimm wrote:
> * gnu/packages/crates-io.scm (override-jemalloc): Add variable.
>=20
> Change-Id: I3e1666306c9f005072f9ed230f03386b2f78b0b2
> ---
>  gnu/packages/crates-io.scm | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>=20
> diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
> index b3d9bcd783..fb7710c5a9 100644
> --- a/gnu/packages/crates-io.scm
> +++ b/gnu/packages/crates-io.scm
> @@ -39209,6 +39209,19 @@ (define-public rust-javascriptcore-rs-sys-0.2
>       "Sys functions for the Rust bindings of the javacriptcore library.")
>      (license license:expat)))
> =20
> +(define override-jemalloc
> +  #~(modify-phases %standard-phases
> +      (add-after 'configure 'override-jemalloc
> +        (lambda* (#:key inputs #:allow-other-keys)
> +          ;; This flag is needed when not using the bundled jemalloc.
> +          ;; https://github.com/tikv/jemallocator/issues/19
> +          (setenv
> +            "CARGO_FEATURE_UNPREFIXED_MALLOC_ON_SUPPORTED_PLATFORMS"
> +            "1")
> +          (setenv "JEMALLOC_OVERRIDE"
> +                  (string-append (assoc-ref inputs "jemalloc")
> +                                 "/lib/libjemalloc_pic.a"))))))
> +
>  (define-public rust-jemalloc-ctl-0.5
>    (package
>      (name "rust-jemalloc-ctl")
>=20
> base-commit: 32ab343e03e998ada27c063ef7d8a00aa88436dd
> --=20
> 2.45.2
>=20
>=20
>=20

--=20
Efraim Flashner   <efraim@HIDDEN>   =D7=90=D7=A4=D7=A8=D7=99=D7=9D =
=D7=A4=D7=9C=D7=A9=D7=A0=D7=A8
GPG key =3D A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

--fbe4iSm5ZfA4XZeG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmdtXbwACgkQQarn3Mo9
g1G8+w//akYmsSa+jTDh/MiDPMLwQueiDAbMyIWokGNmk7Me7i9E8zd7oPY9kBcR
/Kzllc+TS/a69Xak8nSinjFh8+jLkCuETx7ydt9jPLvdqHwOBShjWq63mAJeppUH
GUhCubCHsf5jXIf0oEBHANyRYQYLWdvVWvDgJOtcsCDOoLOYq8DRLuis1fIFxLG0
Ds+RJdkV0yJ2T+k7h9NaoOVtr510Y2HRMPLLAgTJg3L7yTXV9Q1AK5T5650wkkz7
VCy+2Yr+Gf6PGijdYEGTqoiVtvbfvKu33iYzRbuc9Ly9Gs5EFZtxC3BfY2IyTlmW
bL3RSyDrty6PQbVwk7HRsmCGIUjVun7G5X0Eq1nkIh7q6Hc1bSCQHd3KAWnFtJqm
UXs4WekCMDZT520L5GBJrEnuFM3UGUcqti8LdfQbphqlUJLNcCh1XLbTId3u8BXK
SZKwsWu3jsmmJ/WuAvO/+3QTeZt+lxUlBS98fwSBMWTZmDu5EU6oIE20219YB8GR
G/Y4x5XFtr2HfMJ6OSnlIiH1jyVZ6ADah7G0eOSerc9ntl4QsGrvWSnchFNX9VIp
CzDNy2UGqQxxgDQ1Bz7XP0rgkhOnqL4FnGtHQyqim8j+U0Sx9ej4svzv7WfdPgh+
IYdkQx2BrMcIy3RkJMDkvvjYJRrgrA9uGHos9L4YHNwzu0MIKi4=
=B+Y0
-----END PGP SIGNATURE-----

--fbe4iSm5ZfA4XZeG--

Information forwarded to guix-patches@HIDDEN:
bug#75097; Package guix-patches. Full text available.