GNU bug report logs - #75101
[PATCH 0/2] Fix broken Retroarch while respecting FSDG

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75101 in the body.
You can then email your comments to 75101 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrew Wong <wongandj <at> icloud.com>
To: guix-patches <at> gnu.org
Cc: Andrew Wong <wongandj <at> icloud.com>
Subject: [PATCH 0/2] Fix broken Retroarch while respecting FSDG
Date: Wed, 25 Dec 2024 16:29:45 -0500

Retroarch's ability to download "cores" (libraries) to userspace was removed
recently because of non-free cores being available. However, I have found a
more sensible solution which enables the free-licensed cores (which make up
the majority of the list) to still be downloaded. All that is needed is for
the entries for nonfree cores in the retroarch-core-info package to be
removed; without these entries, Retroarch cannot download or update the
nonfree cores, and the FSDG are respected while keeping the software usable.

Andrew Wong (2):
  gnu: retroarch-core-info: Remove non-free core listings.
  gnu: retroarch-minimal: Enable core downloading with limited core
    info.

 gnu/packages/emulators.scm | 59 +++++++++++++++++++++++++++-----------
 1 file changed, 42 insertions(+), 17 deletions(-)

-- 
2.46.0

Message #8 received at 75101 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Wong <wongandj <at> icloud.com>
To: 75101 <at> debbugs.gnu.org
Cc: Andrew Wong <wongandj <at> icloud.com>
Subject: [PATCH 1/2] gnu: retroarch-core-info: Remove non-free core listings.
Date: Wed, 25 Dec 2024 16:39:30 -0500

Change-Id: Ic6f656dac299080eaa097df5375dd23b96966cfb
---
 gnu/packages/emulators.scm | 54 +++++++++++++++++++++++++++++---------
 1 file changed, 42 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/emulators.scm b/gnu/packages/emulators.scm
index ab3f28cfae..75d924253c 100644
--- a/gnu/packages/emulators.scm
+++ b/gnu/packages/emulators.scm
@@ -1584,22 +1584,52 @@ (define-public retroarch-core-info
     (package
       (name "retroarch-core-info")
       (version (git-version "1.19.0" revision commit))
-      (source (origin
-                (method git-fetch)
-                (uri (git-reference
-                      (url "https://github.com/libretro/libretro-core-info")
-                      (commit commit)))
-                (file-name (git-file-name name version))
-                (sha256
-                 (base32
-                  "11xpy3zhy2smp4a70fc0r1b76mvmjyabkaaipifsxm3j25drki5z"))))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/libretro/libretro-core-info")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "11xpy3zhy2smp4a70fc0r1b76mvmjyabkaaipifsxm3j25drki5z"))
+         (modules '((guix build utils)))
+         (snippet '(begin
+                     (for-each delete-file
+                               ;; incompatibly-licensed cores are
+                               ;; removed. When updating check the "license"
+                               ;; line of each file.
+                               '("duckstation_libretro.info"
+                                 "dinothawr_libretro.info"
+                                 "chimerasnes_libretro.info"
+                                 "cannonball_libretro.info"
+                                 "fmsx_libretro.info"
+                                 "fbalpha2012_cps3_libretro.info"
+                                 "fbalpha2012_cps2_libretro.info"
+                                 "fbalpha2012_cps1_libretro.info"
+                                 "mame2003_plus_libretro.info"
+                                 "fbneo_libretro.info"
+                                 "fbalpha2012_neogeo_libretro.info"
+                                 "fbalpha2012_libretro.info"
+                                 "mu_libretro.info"
+                                 "genesis_plus_gx_wide_libretro.info"
+                                 "genesis_plus_gx_libretro.info"
+                                 "opera_libretro.info"
+                                 "snes9x2005_plus_libretro.info"
+                                 "snes9x_libretro.info"
+                                 "px68k_libretro.info"
+                                 "snes9x2005_libretro.info"
+                                 "snes9x2010_libretro.info"
+                                 "snes9x2002_libretro.info"))))))
       (build-system copy-build-system)
       (arguments
-       (list #:install-plan #~'(("." "lib/libretro/"
-                                 #:include-regexp ("\\.info$")))))
+       (list
+        #:install-plan #~'(("." "lib/libretro/"
+                            #:include-regexp ("\\.info$")))))
       (home-page "https://github.com/libretro/libretro-core-info")
       (synopsis "Libretro core info files")
-      (description "This is a versioned snapshot of the files containing
+      (description
+       "This is a versioned snapshot of the files containing
 metadata about each known libretro core.  The snapshot is taken from the
 @url{https://github.com/libretro/libretro-super, libretro-super} repository.")
       (license license:expat))))
-- 
2.46.0

Message #11 received at 75101 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Wong <wongandj <at> icloud.com>
To: 75101 <at> debbugs.gnu.org
Cc: Andrew Wong <wongandj <at> icloud.com>
Subject: [PATCH 2/2] gnu: retroarch-minimal: Enable core downloading with
 limited core info.
Date: Wed, 25 Dec 2024 16:39:31 -0500

Change-Id: I5087bed9c7fd1747df6dd7debc7e606ab3aeb73c
---
 gnu/packages/emulators.scm | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/gnu/packages/emulators.scm b/gnu/packages/emulators.scm
index 75d924253c..2060b14ec3 100644
--- a/gnu/packages/emulators.scm
+++ b/gnu/packages/emulators.scm
@@ -2441,11 +2441,6 @@ (define (directory? x)
                  ;; D-Bus support is required for 'suspend screensaver' option
                  ;; to work.
                  "--enable-dbus"
-                 ;; Non-free software are available through the core updater,
-                 ;; disable it.  See <https://issues.guix.gnu.org/38360>.
-                 "--disable-update_cores"
-                 "--disable-update_core_info"
-                 "--disable-online_updater"
                  ;; The assets are provided via the `retroarch-assets' package.
                  "--disable-update_assets"
                  "--disable-builtinmbedtls"
-- 
2.46.0

Message #14 received at 75101 <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: Andrew Wong <wongandj <at> icloud.com>
Cc: 75101 <at> debbugs.gnu.org
Subject: Re: [bug#75101] [PATCH 0/2] Fix broken Retroarch while respecting FSDG
Date: Tue, 31 Dec 2024 15:57:20 +0800

Andrew Wong <wongandj <at> icloud.com> writes:

> Retroarch's ability to download "cores" (libraries) to userspace was removed
> recently because of non-free cores being available. However, I have found a
> more sensible solution which enables the free-licensed cores (which make up
> the majority of the list) to still be downloaded. All that is needed is for
> the entries for nonfree cores in the retroarch-core-info package to be
> removed; without these entries, Retroarch cannot download or update the
> nonfree cores, and the FSDG are respected while keeping the software usable.

Hello, thanks for the contributions.
>
> Andrew Wong (2):
>   gnu: retroarch-core-info: Remove non-free core listings.
LGTM!

>   gnu: retroarch-minimal: Enable core downloading with limited core info.
Despite FSDG requirements, I think downloading those cores / shared
libraries from internet is not a good idea, as there maybe compability
issues between their build environment and Guix:

- if they build cores against glibc newer than our retroarch.
- if the cores shared linked to other libraries than our retroarch.

And we have more trust and transparent with our packaged cores,
so I think we should keep cores downloading disable, also once we
package them there is no need to download.

Message #17 received at 75101 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Wong <brosasaki <at> gmail.com>
To: iyzsong <at> env.net, 75101 <at> debbugs.gnu.org
Subject: [bug#75101] [PATCH 0/2] Fix broken Retroarch while respecting FSDG
Date: Fri, 3 Jan 2025 21:02:16 -0500

宋文武 <iyzsong <at> env.net> writes:


> Despite FSDG requirements, I think downloading those cores / shared
> libraries from internet is not a good idea, as there maybe compability
> issues between their build environment and Guix

Unfortunately, packaging all the Retroarch cores is quite non-trivial,
as they do not have a consistent build system or source tree layout;
many of their upstream repositories are even lacking version numbers and
directions for building.

While I think we should still keep packaging the cores, I also think it
is better to offer imperfect functionality over almost none at all in
this case, since it is non-essential games software, and the cores'
functionality is entirely contained in the application; them not working
perfectly won't crash servers or poison scientific data, but it may help
retain a lot of users.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.