Stefan Kangas <stefankangas@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 75109) by debbugs.gnu.org; 13 Feb 2025 09:56:13 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 13 04:56:13 2025 Received: from localhost ([127.0.0.1]:40595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tiVx6-00078C-Ok for submit <at> debbugs.gnu.org; Thu, 13 Feb 2025 04:56:13 -0500 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:57387) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tiVx3-00077o-EL for 75109 <at> debbugs.gnu.org; Thu, 13 Feb 2025 04:56:10 -0500 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-5de594e2555so1037992a12.2 for <75109 <at> debbugs.gnu.org>; Thu, 13 Feb 2025 01:56:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739440563; x=1740045363; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=u13qD9Z6Ge+rQXEZvYBvJ2wuplH/nhSz/1Wtm52IFXQ=; b=jyjGhYAHvf3v7VBYywd9w8cckPgcDKbQ4wNYhzI0uj4R9DLP60gZqd1VmfvgrbeopU TOWe5H6r2kJG89wrEH+r72Txq+Q/lOOSSrSGFC3sgPIlLI/M90n5qEIBGazC3hpwuG00 2tASUWaKJwzhJhp+k/rnOkNCQQUSZ1KLR11OnpLhFOi6eW8/3UEVWvkaB2A0rGan8cMT fwCMnJA0cn6y5BnPWeQhd41dTk9Mn3C7dpduFmUBM/lgUWwdtb1pRdgP5RxDReovQ28x EG5FZzcIbupwjeK0klmAR6FGNbLwwuoKAM/+pJdhUzt7cOoPIelLFStTYDYG2mHjbrO1 5xGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739440563; x=1740045363; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=u13qD9Z6Ge+rQXEZvYBvJ2wuplH/nhSz/1Wtm52IFXQ=; b=vz2p8UDvLkpcEaj2xMyOu6KjZlgH4oAjjlDkoQU2lIyRu6LqUwKEf9DUwW8dVr7wN1 BB7Zbq3c9nDuYrrpuW2iP6T4QxjdyI4q5jw3P+ykm+cASb/G8okXTj7JBlfFdR2cxlhG SN53JvhFNCNGUdPu0G4rlO3mUCB0u5yAoyRar8hEs+eJYfWEhyh1HQmnjbdHRJr+Yeg0 zUZfiv4Yl5Nbtav2zthnNrpgWiQNdeuGPduITFJgEIOREMF3HqlGJ8OWILOOtccOW6SE qD5ZFD6yu49wV6Xp/nLf/U2HGTMhnyk4jXGsUbB7NjnAXEVqfHx0RSR3tcd9JsTf0kvg b+Uw== X-Forwarded-Encrypted: i=1; AJvYcCW1paITH6oQ90hI55tSQgADSMJAXmbVSccMrmAbaFoJ57naWAUBPBM0vPoIGJ0/RLFaShoRfg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxhgOyeOAkcpfl5qKLGIDuH5188ANP3WZypsCkoyWn03cFHHdCp 6fcYRGOPBB2ufndMB3gb4AwuvMMEqOVVrKRXOuHBCuTnRNhryEClS7lxPZHO+AbLgwgnoPdyQ5o 2c2OH9Niv44fL9RqN5Psp31U9VmOjUGvYZPA5wA== X-Gm-Gg: ASbGnctyrBdI/qP0HHTpyel7/SpnAnB6da1nhMIGAK4PKBcewP4rZ1gD2RdgUBS/l1k iagtihURNhXtkp4jSRgRKvV34ySPDHAXYxPx081jlpHphoryxBmUQc3bxgGdG5Tr6X1WrVlhih7 o= X-Google-Smtp-Source: AGHT+IF3SPBKwzbf6OJ+mYLZd+LSZ3qPmYMP66ahHNln+Z0ABhSvnJecJ/yRJAnrgw2SR55CqeJNEx78A9kLnSZO2Ls= X-Received: by 2002:a05:6402:4606:b0:5de:cbed:c955 with SMTP id 4fb4d7f45d1cf-5decbedcaf2mr1728130a12.17.1739440563260; Thu, 13 Feb 2025 01:56:03 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 13 Feb 2025 01:56:02 -0800 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <86a5c6eqth.fsf@HIDDEN> References: <87v7v7h1wp.fsf@HIDDEN> <87o70zph6d.fsf@HIDDEN> <86a5c6eqth.fsf@HIDDEN> MIME-Version: 1.0 Date: Thu, 13 Feb 2025 01:56:02 -0800 X-Gm-Features: AWEUYZka9peGSExgGyf5_pzIJ1VWePE2x_oWNxniyxxH9iCuBh4lQpafGfbH5pk Message-ID: <CADwFkm=YH_F09ogSw4sNpjtr9mXwkeT1LUpomy++QnrUBXU5sA@HIDDEN> Subject: Re: bug#75109: [PATCH] indent.el Comments for indent-for-tab-command as a first step for refactoring. To: Eli Zaretskii <eliz@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75109 Cc: Vitaliy <vitalij@HIDDEN>, 75109 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: >> Date: Wed, 25 Dec 2024 21:48:58 -0000 >> From: Vitaliy via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> >> >> Fixed "From" header inside of patch. >> >> Vitaliy <vitalij@HIDDEN> writes: >> >> >From 00c1dbbf729b1180963abb6743116ec4c8c6b5ad Mon Sep 17 00:00:00 2001 >> From: Vitaliy <vitalij@HIDDEN> >> Date: Wed, 25 Dec 2024 21:26:05 +0000 >> Subject: [PATCH] Comment for indent-for-tab-command as a first step to >> refactoring. > > Thanks, but we prefer to make such changes as part of the real > changes, not by themselves. So please include these in your followup > patches that do the real refactoring. > > P.S. I don't see your copyright assignment on file, so if you intend > to keep contributing changes to Emacs, I suggest to start your > assignment paperwork now. If this is fine with you, I will send you > the form to fill and the instructions to go with it. > > Thank you for your interest in Emacs. Ping. Has there been any progress here?
bug-gnu-emacs@HIDDEN:bug#75109; Package emacs.
Full text available.Received: (at 75109) by debbugs.gnu.org; 4 Jan 2025 11:55:49 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 04 06:55:49 2025 Received: from localhost ([127.0.0.1]:53712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tU2kv-0003n9-3i for submit <at> debbugs.gnu.org; Sat, 04 Jan 2025 06:55:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36208) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tU2ks-0003mt-CT for 75109 <at> debbugs.gnu.org; Sat, 04 Jan 2025 06:55:47 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tU2km-0000bl-R3; Sat, 04 Jan 2025 06:55:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=U4rjxvPOSnNFc+pf7qryIz8immAuo5P9cIOz0NZG5+w=; b=LZvWypxLOVaF 3j8flYjg5c0DGoak3F4EoQVVByFspMQrCVLRnV6hWiDWF51mRdrN7Xct7qs5KpwBGy/m8hqlBt5Xr E2oScKWiOemG3QtfSXEfeBeHvcPORZoHqD6qh0efixfsytuo3X1Hf8kJt7gw+IlpLuMtjGykXRN00 2tLP4LNQy+YT+3JKYd+ox7g9NehPRWEbUwaR+bmZnQjgUb1aI/vVUSgecAnFqK4djKd2VSiiHcy1P OGf0iYOsK4TqI2QYsqW6BLEFzVKfMmPBEM9rarkgeL2h0DDaSGzb95XCzYRKSq3moaDjbs/CNyasy lGF9jufJ9CjybLIboTDGCQ==; Date: Sat, 04 Jan 2025 13:55:38 +0200 Message-Id: <86a5c6eqth.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Vitaliy <vitalij@HIDDEN> In-Reply-To: <87o70zph6d.fsf@HIDDEN> (bug-gnu-emacs@HIDDEN) Subject: Re: bug#75109: [PATCH] indent.el Comments for indent-for-tab-command as a first step for refactoring. References: <87v7v7h1wp.fsf@HIDDEN> <87o70zph6d.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75109 Cc: 75109 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Wed, 25 Dec 2024 21:48:58 -0000 > From: Vitaliy via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > Fixed "From" header inside of patch. > > Vitaliy <vitalij@HIDDEN> writes: > > >From 00c1dbbf729b1180963abb6743116ec4c8c6b5ad Mon Sep 17 00:00:00 2001 > From: Vitaliy <vitalij@HIDDEN> > Date: Wed, 25 Dec 2024 21:26:05 +0000 > Subject: [PATCH] Comment for indent-for-tab-command as a first step to > refactoring. Thanks, but we prefer to make such changes as part of the real changes, not by themselves. So please include these in your followup patches that do the real refactoring. P.S. I don't see your copyright assignment on file, so if you intend to keep contributing changes to Emacs, I suggest to start your assignment paperwork now. If this is fine with you, I will send you the form to fill and the instructions to go with it. Thank you for your interest in Emacs.
bug-gnu-emacs@HIDDEN:bug#75109; Package emacs.
Full text available.Stefan Kangas <stefankangas@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at submit) by debbugs.gnu.org; 26 Dec 2024 04:33:57 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 25 23:33:57 2024
Received: from localhost ([127.0.0.1]:39687 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tQfZM-000622-SE
for submit <at> debbugs.gnu.org; Wed, 25 Dec 2024 23:33:57 -0500
Received: from lists.gnu.org ([209.51.188.17]:45044)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <vitalij@HIDDEN>) id 1tQZFm-0002bl-3p
for submit <at> debbugs.gnu.org; Wed, 25 Dec 2024 16:49:18 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <vitalij@HIDDEN>) id 1tQZFk-0005KW-Ok
for bug-gnu-emacs@HIDDEN; Wed, 25 Dec 2024 16:49:17 -0500
Received: from mout.gmx.net ([212.227.15.19])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <vitalij@HIDDEN>) id 1tQZFj-0007O1-07
for bug-gnu-emacs@HIDDEN; Wed, 25 Dec 2024 16:49:16 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.com;
s=s31663417; t=1735163353; x=1735768153; i=vitalij@HIDDEN;
bh=wxAQWqtgkfSHrSdQs+RluVj7JIBiFYO15PU4bNO0uxw=;
h=X-UI-Sender-Class:From:To:Subject:In-Reply-To:References:Date:
Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding:
content-type:date:from:message-id:mime-version:reply-to:subject:
to;
b=XgN8f4036jqfztHmVDEkkiEIMjkp8ZDsYDYNER2oldVJS3HXOqQsDZveluXuhFHU
Huz+CONrH5QWtlIThvkaUtAY8Q6Q/H1qtP9znrVkZm+mT1RCJDF49HtsO0IAu6hyP
IRIK6Thh9t8aWvgqpOnCmKiOft+ilS30g7Sb3VgsJmQ98oZd7QG+fnE2Ip4q1fmYu
RpPKFtxAUWdQ4f3xRlaOyugPXJlc/rr11TLoCv8CLZqDODmLywn/gXtYR5BNyg9D/
jzVOHwJX7L6YHXrm6I5qa6xcYr7GZo+PJ7j8s3NVMQgaXElG80z4amYDFT5rrIYTw
slTA1x+ApkJ3SCk50g==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from localhost ([202.179.32.225]) by mail.gmx.net (mrgmx005
[212.227.17.184]) with ESMTPSA (Nemesis) id 1MSbxD-1sy8DO3wRF-00P31C for
<bug-gnu-emacs@HIDDEN>; Wed, 25 Dec 2024 22:49:13 +0100
From: Vitaliy <vitalij@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: Re: [PATCH] indent.el Comments for indent-for-tab-command as a
first step for refactoring.
In-Reply-To: <87v7v7h1wp.fsf@HIDDEN>
References: <87v7v7h1wp.fsf@HIDDEN>
Date: Wed, 25 Dec 2024 21:48:58 -0000
Message-ID: <87o70zph6d.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Provags-ID: V03:K1:BjW1c5EigIyvhEaviObUqD8fmvXw/AIgF92TODVBzj+SzFNoeBe
dFj75jnP5Ah9bO2yXEPpokdPi//J805BT/A6lXYMOJv4wZNrnaEVtjGYKkmpDY9H02ufbo0
q0Nwl9Ql7zFl610MwScccncVBBFIjXjHfsdjOP9Hjfzwwt0t7BAhnclr+FnrtR3AVM4ZVW0
iCp0DV0/Up5dWCA26LLCQ==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:iCkac6caLy0=;k5HXLTrhM6tRS2PMNV5co3LxUvX
UDSs2RRgZM5hxH6z9OwW0ftzPmuKntLMQGWG5Pk5EbUXsyWBpf6McqScOv5FEUa0Vu7HusCIS
TlBikeH2/dQmcJgmGUjVxN+edvStCkvMWsQoDcYGw8o676XB7hYzmbcCRTY5G4SpVpG2oSs9e
6mINKYrN7tsmXIRXiSqVVEKKpi2jgphBV9sKLcqp4xZjQ8FItXdA71cw9T53pVNI+pFqaD58D
P8ccWj4uimJUtmdCKlKlcNzRqbHUeOb7pyZyYG/avhRAwAgurMKT4zVov5bScWewdBQvfa/O2
2Q8WM/0TbxLxK4he+VWEOUxfk0bJTpHHxBdYVdpo4o3iwJtWvDbfRjGycGlUUERuizWTTrRB/
LpnSnxw9Cjm265xz5SL8r28YOuDtflMz2Q8RgUIT/fEJRmVdwYKuwAbJxQ/MS+PQf+1STmMfi
3gpgGPlfi7eATtkYHJo72DeM6Ouu9WJMV4bl0JZ+fhP1ouTAluQI+7hFelcd7itBmKR464QHH
xGYywydIxVKLSxZ7Z4aeMhqlahiHgquCGEf/ivFokAUkNzwCAhMsuFfzNl7q3lAfrFqxOgibD
BxwqZBz2RiFgVCG6KxnjazqIDauMbutGjQaeQn2YdAEBgUJf5clgQhosFWvj9Sd0AoIVaj/TJ
dbfH8uFN4HaSMYmXgh9MxEd3f+vbj55y7eFHca+dwDYDXg2GNOOJMUrbEi3alln7DgoWHXXp4
IrpBvb88/q2XDLRzW6nrIvyKwOGjhtQRfkqCwL2Ae64K5LNtwAZFPSta5eAEB4LjwE6llpVgY
PjxfWiGVg4JQ22QrdI2W1t4bP3oth3HxEFoZyG6t5xgzgfHSXa+/uCdHbP0ToAVqOz3zE2rZG
GR49dArCjvBFElpSFHl7veP3gOlzIyGc/cbJchrLLFAPEiB7H8AEC5d/Of9jwobsbhv4XFNqo
tnpSGgIua+FFl8cVKCLz1zMPprxi1j2pO7+Dszb/BSjhf/xh2Xl5+i2p7TOsL6zwevX8M3cyf
qq6a6zd40Q7XLqRVACL5vAW8FHcLcQnOQER+mUHRMbo2XQDM3tY4+UJqZ07kYz/mvHbM9YgXn
kseyzUzj56O7Qk0rXXCIWWk/6zQPxs
Received-SPF: pass client-ip=212.227.15.19; envelope-from=vitalij@HIDDEN;
helo=mout.gmx.net
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001,
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Wed, 25 Dec 2024 23:33:54 -0500
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)
--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
Fixed "From" header inside of patch.
Vitaliy <vitalij@HIDDEN> writes:
--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline;
filename=0001-Comment-for-indent-for-tab-command-as-a-first-step-t.patch
From 00c1dbbf729b1180963abb6743116ec4c8c6b5ad Mon Sep 17 00:00:00 2001
From: Vitaliy <vitalij@HIDDEN>
Date: Wed, 25 Dec 2024 21:26:05 +0000
Subject: [PATCH] Comment for indent-for-tab-command as a first step to
refactoring.
---
lisp/indent.el | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/lisp/indent.el b/lisp/indent.el
index 74ef9183d95..613454918b8 100644
--- a/lisp/indent.el
+++ b/lisp/indent.el
@@ -160,6 +160,7 @@ prefix argument is ignored."
;; The region is active, indent it.
((use-region-p)
(indent-region (region-beginning) (region-end)))
+ ;; *1.* inserts a tab character for special indentation cases.
((or ;; indent-to-left-margin is only meant for indenting,
;; so we force it to always insert a tab here.
(eq indent-line-function 'indent-to-left-margin)
@@ -172,15 +173,17 @@ prefix argument is ignored."
(old-point (point))
(old-indent (current-indentation)))
- ;; Indent the line.
+ ;; *2.* Indent the line with specified function
(or (not (eq (indent--funcall-widened indent-line-function) 'noindent))
+ ;; *3.* Indent comment
(indent--default-inside-comment)
+ ;; *4.* Fallback to default indent function
(when (or (<= (current-column) (current-indentation))
(not (eq tab-always-indent 'complete)))
(indent--funcall-widened (default-value 'indent-line-function))))
(cond
- ;; If the text was already indented right, try completion.
+ ;; *5.* If the text was already indented right, try completion.
((and (eq tab-always-indent 'complete)
(eql old-point (point))
(eql old-tick (buffer-chars-modified-tick))
@@ -193,9 +196,9 @@ prefix argument is ignored."
('word-or-paren (not (memq syn '(2 4 5))))
('word-or-paren-or-punct (not (memq syn '(2 4 5 1))))))))
(completion-at-point))
-
- ;; If a prefix argument was given, rigidly indent the following
- ;; sexp to match the change in the current line's indentation.
+ ;; *6* If a prefix argument was given, rigidly indent the
+ ;; following sexp to match the change in the current line's
+ ;; indentation.
(arg
(let ((end-marker
(save-excursion
--
2.45.2
--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
> Tags: notabug
> Package: indent.el
> Version: master
> Severity: wishlist
>
> In GNU Emacs master.
>
> #'indent-for-tab-command function now have strict steps, I hope in
> future we will add ability to select on what orded they should go, as a
> first step I suggest to comment them to separate.
> This steps in unclear heap now:
> -. **Check for Active Region**: If there is an active region, it indents=
that region.
> 1. **Handle Special Indentation Cases**: If the indentation function is =
specific or certain conditions are met, it inserts a tab character.
> 2. **Default Indentation Handling**: If neither of the above, it perform=
s standard line indentation.
> 3. **Check for Completion Conditions**: If specific conditions are met a=
fter indentation, it triggers completion.
> 4. **Rigid Indentation with Prefix Argument**: If a prefix argument is p=
rovided, it rigidly indents the balanced expression to reflect the current=
line's indentation.
> From 00c1dbbf729b1180963abb6743116ec4c8c6b5ad Mon Sep 17 00:00:00 2001
> From: none <none>
> Date: Wed, 25 Dec 2024 21:26:05 +0000
> Subject: [PATCH] Comment for indent-for-tab-command as a first step to
> refactoring.
>
> ---
> lisp/indent.el | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/lisp/indent.el b/lisp/indent.el
> index 74ef9183d95..613454918b8 100644
> --- a/lisp/indent.el
> +++ b/lisp/indent.el
> @@ -160,6 +160,7 @@ prefix argument is ignored."
> ;; The region is active, indent it.
> ((use-region-p)
> (indent-region (region-beginning) (region-end)))
> + ;; *1.* inserts a tab character for special indentation cases.
> ((or ;; indent-to-left-margin is only meant for indenting,
> ;; so we force it to always insert a tab here.
> (eq indent-line-function 'indent-to-left-margin)
> @@ -172,15 +173,17 @@ prefix argument is ignored."
> (old-point (point))
> (old-indent (current-indentation)))
>
> - ;; Indent the line.
> + ;; *2.* Indent the line with specified function
> (or (not (eq (indent--funcall-widened indent-line-function) 'noin=
dent))
> + ;; *3.* Indent comment
> (indent--default-inside-comment)
> + ;; *4.* Fallback to default indent function
> (when (or (<=3D (current-column) (current-indentation))
> (not (eq tab-always-indent 'complete)))
> (indent--funcall-widened (default-value 'indent-line-functi=
on))))
>
> (cond
> - ;; If the text was already indented right, try completion.
> + ;; *5.* If the text was already indented right, try completion.
> ((and (eq tab-always-indent 'complete)
> (eql old-point (point))
> (eql old-tick (buffer-chars-modified-tick))
> @@ -193,9 +196,9 @@ prefix argument is ignored."
> ('word-or-paren (not (memq syn '(2 4 5))))
> ('word-or-paren-or-punct (not (memq syn '(2 4 5 1)=
)))))))
> (completion-at-point))
> -
> - ;; If a prefix argument was given, rigidly indent the following
> - ;; sexp to match the change in the current line's indentation.
> + ;; *6* If a prefix argument was given, rigidly indent the
> + ;; following sexp to match the change in the current line's
> + ;; indentation.
> (arg
> (let ((end-marker
> (save-excursion
> --
> 2.45.2
>
>
> --
> Best regards,
> Vitaliy
> Magic number: 7850B0B5E3F536601D2E6A9DE1C43E074A047699
=2D-
Best regards,
Magic number: 7850B0B5E3F536601D2E6A9DE1C43E074A047699
--=-=-=--
Vitaliy <vitalij@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#75109; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.