GNU bug report logs - #75243
[PATCH] gnu: Add emacs-binder.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75243 in the body.
You can then email your comments to 75243 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Divya Ranjan <divya <at> subvertising.org>
To: guix-patches <at> gnu.org
Cc: Divya Ranjan <divya <at> subvertising.org>
Subject: [PATCH] gnu: Add emacs-binder.
Date: Wed,  1 Jan 2025 15:29:19 +0000

* gnu/packages/emacs-xyz.scm (emacs-binder): New variable.
---
 gnu/packages/emacs-xyz.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 4e4ac5d4c4..73b6ad72b9 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -39712,6 +39712,25 @@ (define-public emacs-iter2
 original package.")
     (license license:gpl3+)))
 
+(define-public emacs-binder
+  (package
+    (name "emacs-binder")
+    (version "20241023.1154")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://melpa.org/packages/binder-" version ".tar"))
+       (sha256
+        (base32 "1nvsmmg9wwan5y38dpcpffzxxvivi4708ri64f03gwcq66g1k49m"))))
+    (build-system emacs-build-system)
+    (home-page "https://codeberg.org/divyaranjan/binder")
+    (synopsis
+     "Binder is a global minor mode to facilitate working on multiple files")
+    (description "Primarily, Binder provides a global minor mode binder-mode.
+This allows working with files in the current binder-project-directory.
+Data concerning these files is saved in a .binder.el file in the project directory.")
+    (license license:gpl3+)))
+
 (define-public emacs-bind-map
   (let ((commit "510a24138d8de3b8df0783f1ac493a551fc9bd74")
         (revision "0"))
-- 
2.47.1

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Divya Ranjan via Guix-patches via <guix-patches <at> gnu.org>
Cc: 75243 <at> debbugs.gnu.org, Divya Ranjan <divya <at> subvertising.org>
Subject: Re: [bug#75243] [PATCH] gnu: Add emacs-binder.
Date: Wed, 01 Jan 2025 17:40:27 +0100

Hello,

Divya Ranjan via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-binder): New variable.

Thank you. Some comments follow.

> +(define-public emacs-binder
> +  (package
> +    (name "emacs-binder")
> +    (version "20241023.1154")

Version should be "0.5.0", as set in "binder.el".

> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://melpa.org/packages/binder-" version ".tar"))

Guix does not use MELPA as upstream because tarballs are not reliable.
Please use Codeberg repository instead.

> +       (sha256
> +        (base32 "1nvsmmg9wwan5y38dpcpffzxxvivi4708ri64f03gwcq66g1k49m"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://codeberg.org/divyaranjan/binder")
> +    (synopsis
> +     "Binder is a global minor mode to facilitate working on multiple files")
> +    (description "Primarily, Binder provides a global minor mode
> binder-mode.

"binder-mode" -> "Binder mode".

> +This allows working with files in the current
> binder-project-directory.

"binder-project-directory" -> "@code{binder-project-directory}".

> +Data concerning these files is saved in a .binder.el file in the
> project directory.")

I don’t think the last sentence is useful in the description as it
merely describes the internals of the package. I suggest to remove it.
If you absolutely want to keep it, I suggest to apply proper markup:
".binder.el" -> "@file{.binder.el}".

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Divya Ranjan <divya <at> subvertising.org>
To: Nicolas Goaziou via Guix-patches via <guix-patches <at> gnu.org>
Cc: 75243 <at> debbugs.gnu.org, Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: Re: [bug#75243] [PATCH] gnu: Add emacs-binder.
Date: Wed, 01 Jan 2025 20:13:47 +0000

[Message part 1 (text/plain, inline)]

Hello Nicholas, I’ve made the necessary edits, the edited patch is attached below:

Nicolas Goaziou via Guix-patches via <guix-patches <at> gnu.org> writes:

> Hello,
>
> Divya Ranjan via Guix-patches via <guix-patches <at> gnu.org> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-binder): New variable.
>
> Thank you. Some comments follow.
>
>> +(define-public emacs-binder
>> +  (package
>> +    (name "emacs-binder")
>> +    (version "20241023.1154")
>
> Version should be "0.5.0", as set in "binder.el".
>
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append "https://melpa.org/packages/binder-" version ".tar"))
>
> Guix does not use MELPA as upstream because tarballs are not reliable.
> Please use Codeberg repository instead.
>
>> +       (sha256
>> +        (base32 "1nvsmmg9wwan5y38dpcpffzxxvivi4708ri64f03gwcq66g1k49m"))))
>> +    (build-system emacs-build-system)
>> +    (home-page "https://codeberg.org/divyaranjan/binder")
>> +    (synopsis
>> +     "Binder is a global minor mode to facilitate working on multiple files")
>> +    (description "Primarily, Binder provides a global minor mode
>> binder-mode.
>
> "binder-mode" -> "Binder mode".
>
>> +This allows working with files in the current
>> binder-project-directory.
>
> "binder-project-directory" -> "@code{binder-project-directory}".
>
>> +Data concerning these files is saved in a .binder.el file in the
>> project directory.")
>
> I don’t think the last sentence is useful in the description as it
> merely describes the internals of the package. I suggest to remove it.
> If you absolutely want to keep it, I suggest to apply proper markup:
> ".binder.el" -> "@file{.binder.el}".

[0001-gnu-Add-emacs-binder.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

>
> Could you send an updated patch?
>
> Regards,

-- 
Divya Ranjan,
Philosophy, Mathematics, Libre Software.

PGP Fingerprint: F0B3 1A69 8006 8FB8 096A  2F12 B245 10C6 108C 8D4A

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Divya Ranjan <divya <at> subvertising.org>
To: Nicolas Goaziou via Guix-patches via <guix-patches <at> gnu.org>
Cc: 75243 <at> debbugs.gnu.org, Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: Re: [bug#75243] [PATCH] gnu: Add emacs-binder.
Date: Thu, 02 Jan 2025 04:59:30 +0000

Also, Nicholas I forgot to include the Copyright signature in my patch, could you just include it yourself? "Divya Ranjan Pattanaik <divya <at> subvertising.org>".

Nicolas Goaziou via Guix-patches via <guix-patches <at> gnu.org> writes:

> Hello,
>
> Divya Ranjan via Guix-patches via <guix-patches <at> gnu.org> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-binder): New variable.
>
> Thank you. Some comments follow.
>
>> +(define-public emacs-binder
>> +  (package
>> +    (name "emacs-binder")
>> +    (version "20241023.1154")
>
> Version should be "0.5.0", as set in "binder.el".
>
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append "https://melpa.org/packages/binder-" version ".tar"))
>
> Guix does not use MELPA as upstream because tarballs are not reliable.
> Please use Codeberg repository instead.
>
>> +       (sha256
>> +        (base32 "1nvsmmg9wwan5y38dpcpffzxxvivi4708ri64f03gwcq66g1k49m"))))
>> +    (build-system emacs-build-system)
>> +    (home-page "https://codeberg.org/divyaranjan/binder")
>> +    (synopsis
>> +     "Binder is a global minor mode to facilitate working on multiple files")
>> +    (description "Primarily, Binder provides a global minor mode
>> binder-mode.
>
> "binder-mode" -> "Binder mode".
>
>> +This allows working with files in the current
>> binder-project-directory.
>
> "binder-project-directory" -> "@code{binder-project-directory}".
>
>> +Data concerning these files is saved in a .binder.el file in the
>> project directory.")
>
> I don’t think the last sentence is useful in the description as it
> merely describes the internals of the package. I suggest to remove it.
> If you absolutely want to keep it, I suggest to apply proper markup:
> ".binder.el" -> "@file{.binder.el}".
>
> Could you send an updated patch?
>
> Regards,

-- 
Divya Ranjan,
Philosophy, Mathematics, Libre Software.

PGP Fingerprint: F0B3 1A69 8006 8FB8 096A  2F12 B245 10C6 108C 8D4A

Message #26 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Divya Ranjan via Guix-patches via <guix-patches <at> gnu.org>
Cc: 75243-done <at> debbugs.gnu.org, Divya Ranjan <divya <at> subvertising.org>
Subject: Re: [bug#75243] [PATCH] gnu: Add emacs-binder.
Date: Fri, 03 Jan 2025 12:02:58 +0100

Hello,

Divya Ranjan via Guix-patches via <guix-patches <at> gnu.org> writes:

> Also, Nicholas I forgot to include the Copyright signature in my patch, could you just include it yourself? "Divya Ranjan Pattanaik <divya <at> subvertising.org>".

Applied and done. Thank you.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.