GNU bug report logs - #75381
[PATCH] gnu: pcb2gcode: Update to pre-release.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75381 in the body.
You can then email your comments to 75381 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Evgeny Pisemsky <mail <at> pisemsky.site>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: pcb2gcode: Update to pre-release.
Date: Sun, 05 Jan 2025 16:18:11 +0300

[0001-gnu-pcb2gcode-Update-to-pre-release.patch (text/x-patch, inline)]

From a3d86f0c6e89116b6a4840c69ff1ba2b6290e93c Mon Sep 17 00:00:00 2001
Message-ID: <a3d86f0c6e89116b6a4840c69ff1ba2b6290e93c.1736073815.git.mail <at> pisemsky.site>
From: Evgeny Pisemsky <mail <at> pisemsky.site>
Date: Sun, 5 Jan 2025 13:35:51 +0300
Subject: [PATCH] gnu: pcb2gcode: Update to pre-release.

* gnu/packages/engineering.scm (pcb2gcode): Update to pre-release, change
indentation, run guix style.
[version]: Use git-version.
[source]: Use specific commit, do not recurse submodules (there are none).

Change-Id: I97c5b6521c86606c572ce67efc60b13351b1b4cd
---
 gnu/packages/engineering.scm | 55 ++++++++++++++++++------------------
 1 file changed, 27 insertions(+), 28 deletions(-)

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index f9c4ac9bbd..15827c7fdc 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -3489,37 +3489,36 @@ (define-public emacs-poke
   (deprecated-package "emacs-poke" poke))
 
 (define-public pcb2gcode
-  (package
-   (name "pcb2gcode")
-   (version "2.5.0")
-   (source
-    (origin
-     (method git-fetch)
-     (uri (git-reference
-           (url "https://github.com/pcb2gcode/pcb2gcode")
-           (commit (string-append "v" version))
-           (recursive? #t)))
-     (file-name (git-file-name name version))
-     (sha256
-      (base32
-       "01s41znkcq9x1rinsdqrrdj8p35isckrcxs14ajsi7wr39n1m5kk"))))
-   (build-system gnu-build-system)
-   (inputs
-    (list boost
-          geos
-          gerbv
-          glibmm
-          gtkmm-2
-          (librsvg-for-system)))
-   (native-inputs
-    (list autoconf automake libtool pkg-config))
-   (home-page "https://github.com/pcb2gcode/pcb2gcode")
-   (synopsis "Generate G-code for milling PCBs")
-   (description "pcb2gcode is a command-line program for isolation routing
+  (let ((commit "8c084afd00c6653dfa9cbf24a1dbeeb24f592aa9")
+        (revision "0"))
+    (package
+      (name "pcb2gcode")
+      (version (git-version "2.5.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/pcb2gcode/pcb2gcode")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "19hyzd1601l51bwlv43j8l602nfacbjwqf54m5xsmj50718bcks2"))))
+      (build-system gnu-build-system)
+      (inputs (list boost
+                    geos
+                    gerbv
+                    glibmm
+                    gtkmm-2
+                    (librsvg-for-system)))
+      (native-inputs (list autoconf automake libtool pkg-config))
+      (home-page "https://github.com/pcb2gcode/pcb2gcode")
+      (synopsis "Generate G-code for milling PCBs")
+      (description
+       "pcb2gcode is a command-line program for isolation routing
 and drilling of PCBs.  It takes Gerber files as input and outputs G-code files
 for the milling of PCBs.  It also includes an autoleveller for the automatic
 dynamic calibration of the milling depth.")
-   (license license:gpl3+)))
+      (license license:gpl3+))))
 
 ;; libdxfrw has no readme, no version release, no tags.  Initial commit says
 ;; "libdxfrw-0.6.3 import", but it shares no git history with "upstream"

base-commit: e383e8e34097b064d4baa4207673c6ba30617347
-- 
2.47.1

Message #8 received at 75381 <at> debbugs.gnu.org (full text, mbox):

From: Evgeny Pisemsky <mail <at> pisemsky.site>
To: 75381 <at> debbugs.gnu.org
Cc: ludo <at> gnu.org
Subject: Re: [PATCH] gnu: pcb2gcode: Update to pre-release.
Date: Sat, 11 Jan 2025 20:00:44 +0300

This follows #72541 and fixes #68036.

More specifically, this commit

https://github.com/pcb2gcode/pcb2gcode/commit/a7c2ec216cb50fa4f01d61c358cb93e7a17b01d1

fixes incompatibility with newer geos that currently breaks build.

Message #13 received at 75381-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 75381-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: pcb2gcode: Update to pre-release.
Date: Sun, 09 Mar 2025 22:32:47 +0000

[Message part 1 (text/plain, inline)]

Hi,

Thank you for the fixing patch and sorry for the long wait time on
review (Guix team is working hard to improve patch review flow).

I could not apply patch as it is with mumi or git am directly; instead
changes were applied first and authored as Evgeny Pisemsky
<mail <at> pisemsky.site>.

--8<---------------cut here---------------start------------->8---
> $(./pre-inst-env guix build pcb2gcode)/bin/pcb2gcode --version
2.5.0
Git commit:
Boost: 108300
Gerbv: 2.10.0
Geos: 3.12.1
--8<---------------cut here---------------end--------------->8---

Pushed to master as b1a268fc540885052634ee075a37259408818e17.

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.