GNU bug report logs - #75425
[PATCH] gnu: appimage-type2-runtime: Fix cross-compiling.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75425 in the body.
You can then email your comments to 75425 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brian Kubisiak <brian <at> kubisiak.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: appimage-type2-runtime: Fix cross-compiling.
Date: Tue, 7 Jan 2025 14:07:16 -0800

* gnu/packages/appimage.scm (appimage-type2-runtime)[arguments]<#:make-flags>: Use
CC-FOR-TARGET and add "-Wno-int-conversion".

Change-Id: I5dd9c6cb81e30713f17d474e9a5e11817db7158e
---
 gnu/packages/appimage.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/appimage.scm b/gnu/packages/appimage.scm
index 1d0caada46..620628c053 100644
--- a/gnu/packages/appimage.scm
+++ b/gnu/packages/appimage.scm
@@ -49,11 +49,13 @@ (define-public appimage-type2-runtime
        (list
         #:make-flags
         #~(list "-Csrc/runtime" "runtime-fuse3"
+                (string-append "CC=" #$(cc-for-target))
                 (string-append
                  "CFLAGS=" "-I" #$(this-package-input "fuse") "/include/fuse/"
                  " -DGIT_COMMIT='\"" "guix-" #$version "\"'"
                  " -D_FILE_OFFSET_BITS=64"
-                 " -static"))
+                 " -static"
+                 " -Wno-int-conversion"))
         #:modules
         `((guix build gnu-build-system)
           (guix build utils)

base-commit: a76f2d5927c86e4a76a1d3b49c1a37054612f6c0
prerequisite-patch-id: b7500f0446826469bbf2f858e044cc3e0eae98c5
-- 
2.46.0

Message #8 received at 75425 <at> debbugs.gnu.org (full text, mbox):

From: Noé Lopez <noe <at> xn--no-cja.eu>
To: control <at> debbugs.gnu.org,75425 <at> debbugs.gnu.org
Cc: Brian Kubisiak <brian <at> kubisiak.com>
Subject: QA review for 75425
Date: Fri, 10 Jan 2025 11:06:10 +0100

user guix
usertag 75425 + reviewed-looks-good
thanks

Guix QA review form submission:
Cross build works for aarch64-linux-gnu and riscv-linux-gnu. I also checked that AppImage packs still work.

Thanks for the patch!

Items marked as checked: Lint warnings, Package builds, Commit messages

Message #13 received at 75425-done <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: Brian Kubisiak <brian <at> kubisiak.com>
Cc: 75425-done <at> debbugs.gnu.org
Subject: Re: [bug#75425] [PATCH] gnu: appimage-type2-runtime: Fix
 cross-compiling.
Date: Sat, 11 Jan 2025 23:22:55 +0800

[Message part 1 (text/plain, inline)]

Brian Kubisiak <brian <at> kubisiak.com> writes:

> * gnu/packages/appimage.scm (appimage-type2-runtime)[arguments]<#:make-flags>: Use
> CC-FOR-TARGET and add "-Wno-int-conversion".
>
> Change-Id: I5dd9c6cb81e30713f17d474e9a5e11817db7158e
> ---
>  gnu/packages/appimage.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/appimage.scm b/gnu/packages/appimage.scm
> index 1d0caada46..620628c053 100644
> --- a/gnu/packages/appimage.scm
> +++ b/gnu/packages/appimage.scm
> @@ -49,11 +49,13 @@ (define-public appimage-type2-runtime
>         (list
>          #:make-flags
>          #~(list "-Csrc/runtime" "runtime-fuse3"
> +                (string-append "CC=" #$(cc-for-target))
>                  (string-append
>                   "CFLAGS=" "-I" #$(this-package-input "fuse") "/include/fuse/"
>                   " -DGIT_COMMIT='\"" "guix-" #$version "\"'"
>                   " -D_FILE_OFFSET_BITS=64"
> -                 " -static"))
> +                 " -static"
> +                 " -Wno-int-conversion"))
>          #:modules
>          `((guix build gnu-build-system)
>            (guix build utils)
>
> base-commit: a76f2d5927c86e4a76a1d3b49c1a37054612f6c0
> prerequisite-patch-id: b7500f0446826469bbf2f858e044cc3e0eae98c5
pushed, closing.

And fix squashfuse-for-appimage's name, indentation.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.