GNU bug report logs - #75479
[PATCH] gnu: emacs-ledger-mode: Update to 4.0.0-1.356d804.

Previous Next

Package: guix-patches;

Reported by: Morgan Smith <Morgan.J.Smith <at> outlook.com>

Date: Fri, 10 Jan 2025 20:11:02 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75479 in the body.
You can then email your comments to 75479 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#75479; Package guix-patches. (Fri, 10 Jan 2025 20:11:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Morgan Smith <Morgan.J.Smith <at> outlook.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 10 Jan 2025 20:11:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
To: guix-patches <at> gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: [PATCH] gnu: emacs-ledger-mode: Update to 4.0.0-1.356d804.
Date: Fri, 10 Jan 2025 15:05:05 -0500
* gnu/packages/finance.scm (emacs-ledger-mode): Update to 4.0.0-1.356d804.

Change-Id: Id6d23dc7c2d7a32c91c69a9c26d0d2a47d3f9fa9
---
 gnu/packages/finance.scm | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index 149bebfa2f..a2992344d1 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -409,8 +409,8 @@ (define-public ledger
 
 (define-public emacs-ledger-mode
   ;; The last release was on Nov 8, 2019 and doesn't build with Emacs 28.
-  (let ((commit "11e850395448ee7012dba16bd6df103f5552ebfb")
-        (revision "0"))
+  (let ((commit "356d8049ede02c06db4f487d1d6076f74d6098c5")
+        (revision "1"))
     (package
       (name "emacs-ledger-mode")
       (version (git-version "4.0.0" revision commit))
@@ -422,18 +422,19 @@ (define-public emacs-ledger-mode
                (commit commit)))
          (file-name (git-file-name name version))
          (sha256
-          (base32 "0hzky36vrlb7kvpyz4gy3zn01zdlmlx0s58w6ggk5djbcvjc2rfx"))))
+          (base32 "1wssagczhils0nx12b2nq2jk2gp9j26jn8nrqdrj255nzl40aia1"))))
       (build-system emacs-build-system)
       (arguments
        (list
-        ;; ledger-test.el is needed at runtime (but probably not for a good reason).
-        #:exclude #~'()
         #:tests? #t
         #:phases
         #~(modify-phases %standard-phases
+            (add-after 'unpack 'do-not-require-tests-at-runtime
+              (lambda _
+                (substitute* "ledger-mode.el"
+                  (("\\(require 'ledger-test\\)") ""))))
             (add-after 'unpack 'patch-path
               (lambda* (#:key inputs #:allow-other-keys)
-                (make-file-writable "ledger-exec.el")
                 (emacs-substitute-variables "ledger-exec.el"
                   ("ledger-binary-path" (search-input-file inputs "/bin/ledger")))))
             (add-after 'build 'build-doc
@@ -446,7 +447,9 @@ (define-public emacs-ledger-mode
               (lambda* (#:key tests? #:allow-other-keys)
                 (when tests?
                   (with-directory-excursion "../source/test"
-                    (invoke "make" "test-batch"))))))))
+                    ;; Test does not respect `ledger-binary-path' and thus fails
+                    (delete-file-recursively "report-test.el")
+                    (invoke "make" "test"))))))))
       (inputs
        (list ledger))
       (native-inputs

base-commit: ef025dd4c4e8cc51498146ecde619cfef9eb0779
-- 
2.47.1





Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Sat, 25 Jan 2025 17:46:01 GMT) Full text and rfc822 format available.

Notification sent to Morgan Smith <Morgan.J.Smith <at> outlook.com>:
bug acknowledged by developer. (Sat, 25 Jan 2025 17:46:02 GMT) Full text and rfc822 format available.

Message #10 received at 75479-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: 75479-done <at> debbugs.gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: Re: [PATCH] gnu: emacs-ledger-mode: Update to 4.0.0-1.356d804.
Date: Sat, 25 Jan 2025 18:45:02 +0100
Hello,

> * gnu/packages/finance.scm (emacs-ledger-mode): Update to
> 4.0.0-1.356d804.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou






bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 23 Feb 2025 12:24:18 GMT) Full text and rfc822 format available.

This bug report was last modified 18 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.