Received: (at 75530) by debbugs.gnu.org; 5 Feb 2025 07:47:54 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 05 02:47:54 2025 Received: from localhost ([127.0.0.1]:48240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tfa8Y-0007lx-C7 for submit <at> debbugs.gnu.org; Wed, 05 Feb 2025 02:47:54 -0500 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]:46153) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1tfa8V-0007lc-Pv for 75530 <at> debbugs.gnu.org; Wed, 05 Feb 2025 02:47:52 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id BB760441F2; Wed, 5 Feb 2025 07:47:41 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Liam Hupfer <liam@HIDDEN> Subject: Re: bug#75530: [PATCH v2 2/3] Remap read-only-mode for Occur modes (bug#75530) In-Reply-To: <87wme57yh3.fsf@HIDDEN> Organization: LINKOV.NET References: <cover.1736729460.git.liam@HIDDEN> <cover.1738541428.git.liam@HIDDEN> <608c43362c724d3ca48d234cac46c23f81020ae6.1738541428.git.liam@HIDDEN> <lywme7y760.fsf@HIDDEN> <875xlq48hv.fsf@HIDDEN> <87r04eupat.fsf@HIDDEN> <87wme57yh3.fsf@HIDDEN> Date: Wed, 05 Feb 2025 09:33:14 +0200 Message-ID: <87pljwkfr9.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvvdekkecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefujghofhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecuggftrfgrthhtvghrnhepffegteefveelhfeljeefueehieduiedtfffhuddtkeeffffghfevheetgeeukeehnecukfhppeeluddruddvledrleeirdeltdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeluddruddvledrleeirdeltddphhgvlhhopehmrghilhdrghgrnhguihdrnhgvthdpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnsggprhgtphhtthhopeefpdhrtghpthhtohepjeehheeftdesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehhmhgvlhhmrghnsehgmhgrihhlrdgtohhmpdhrtghpthhtoheplhhirghmsehhphhfrhdrnhgvth X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75530 Cc: 75530 <at> debbugs.gnu.org, Howard Melman <hmelman@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >> Maybe we need to revert this change and find another solution. > > Seeing as nobody seemed to notice or care that this use case was broken > for three years and two major releases I think many people noticed this regression as I did, but the problem is that it takes too much time to analyze bug#53419 and find another solution, but there were many other more urgent things to do.
bug-gnu-emacs@HIDDEN:bug#75530; Package emacs.
Full text available.Received: (at 75530) by debbugs.gnu.org; 5 Feb 2025 06:01:33 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 05 01:01:33 2025 Received: from localhost ([127.0.0.1]:47911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tfYTc-0002aZ-KM for submit <at> debbugs.gnu.org; Wed, 05 Feb 2025 01:01:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:32776) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <ams@HIDDEN>) id 1tfYTZ-0002aJ-9j for 75530 <at> debbugs.gnu.org; Wed, 05 Feb 2025 01:01:30 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ams@HIDDEN>) id 1tfYTQ-0001EM-V2; Wed, 05 Feb 2025 01:01:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Date:References:Subject:In-Reply-To:To:From: mime-version; bh=4CGwEY/uYDt3aLcG9Ov7xnCoT62GZ4w4wqMcdK6yLKU=; b=Qax7KBvc2sRo qS/rrbIfzd3Z3qUgBCHc5oShKCjqtAaLDLJX4PFWtsa3eqTCZSt+DTmXx+sQTlr1RR9LdjQvenYJY SwzUo80YuKWJc97i8rqp71jP4DzTRNnwaR6xhI9XDsAeYesXzamX6A+e4qmKvTmA2racSyxaTYOIc VByc5CkLmHVlIpRqcHsc9sabxtAVAPR9Bw1W2VKljAN4DWmRBm5qHGpbxyLKYCnkbV0s11WnURFir FSLuY/joAZM2ef29rh+HQQV9ZPCr/Azf2oC628P1z1DSh2kUOPG04JzE88UrMbXxauVd/icNNVa8t juwf3M+cTaeMpjAtcV2uGg==; Received: from ams by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from <ams@HIDDEN>) id 1tfYTQ-000247-6D; Wed, 05 Feb 2025 01:01:20 -0500 From: "Alfred M. Szmidt" <ams@HIDDEN> To: Liam Hupfer <liam@HIDDEN> In-Reply-To: <87wme57yh3.fsf@HIDDEN> (message from Liam Hupfer on Tue, 04 Feb 2025 23:27:20 -0600) Subject: Re: bug#75530: [PATCH v2 2/3] Remap read-only-mode for Occur modes (bug#75530) References: <cover.1736729460.git.liam@HIDDEN> <cover.1738541428.git.liam@HIDDEN> <608c43362c724d3ca48d234cac46c23f81020ae6.1738541428.git.liam@HIDDEN> <lywme7y760.fsf@HIDDEN> <875xlq48hv.fsf@HIDDEN> <87r04eupat.fsf@HIDDEN> <87wme57yh3.fsf@HIDDEN> Message-Id: <E1tfYTQ-000247-6D@HIDDEN> Date: Wed, 05 Feb 2025 01:01:20 -0500 X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 75530 Cc: 75530 <at> debbugs.gnu.org, hmelman@HIDDEN, juri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.1 (---) > Indeed, unfortunately this use case was precluded after the change > that added the read-only property on line numbers was made recently > on 2022-01-23 in the commit 1bcbca3750d9e8c47bee7ac893b885ade584d783. Thanks for confirming! > Maybe we need to revert this change and find another solution. That would be amazing! Seeing as nobody seemed to notice or care that this use case was broken for three years and two major releases, I’m personally inclined to proceed further in the direction Lars set previously by considering Occur and Grep as proper special modes, with special C-x C-q behavior, like Dired. I don’t find the rationale particularly compelling that Occur and Grep buffer contents are more commonly edited as raw text than Dired. Not enough to justify the discrepancy, anyway. With special-mode’s bindings in mind, I think it makes more sense to change modes before editing the contents. Not everyone reads the bug lists, and asking for such feedback is better done elsewhere. That nobody commented for a few years does not mean nobody cared it was broken, such blaming is unkind to all who use Emacs. Many people also use older Emacsen, and might not even notice. Changing modes for occur/grep means you loose out on being able to jump to the place where there is a match, being able to flush-lines, or other maniupulation is useful and important. I reported about this issue several years ago, but come to live with it like with many other things. I might have to retract that comment about prescribing workflows. This series is tweaking defaults, so I guess that’s its whole purpose! Maybe others can chime in on their tastes here as well?
bug-gnu-emacs@HIDDEN:bug#75530; Package emacs.
Full text available.Received: (at 75530) by debbugs.gnu.org; 5 Feb 2025 05:27:38 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 05 00:27:38 2025 Received: from localhost ([127.0.0.1]:47830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tfXwo-0000z4-1s for submit <at> debbugs.gnu.org; Wed, 05 Feb 2025 00:27:38 -0500 Received: from out-183.mta0.migadu.com ([91.218.175.183]:51051) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <liam@HIDDEN>) id 1tfXwi-0000yb-PA for 75530 <at> debbugs.gnu.org; Wed, 05 Feb 2025 00:27:33 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpfr.net; s=key1; t=1738733244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DamLx4B4oQivTVnDD3ldEAQuzJpiUgcrk7HDj9U4DOI=; b=VdBs26GvlShwjWj1l54Bp+B4RsLMJOxsr0P2nPTSz0vvr685UZkVxu5PrgnH4RbT/nupyI Az96IURI+SbaYakvEXSCeLPlosdnRBwA/wGNLiPmFvPPjxvYoSeaiP2+A0lwA6d8gemyA7 Vls1FFM/TO5vVX8gvWmIHn2jFzTdQcYobAkszptndRZd9hX6Sizo0FEtSR5hwo62X9NnQF PJdN9HBj9iZ+zLkZwvJuJuXn9t4dkRubpSRvRkWGKb+akSYAI9rDMS8rZT2E1/t5gMKFj9 DrmM8h68d1VWGswMv/BTRQ4DXOYjeVsHWMXhq+nRVFUahssIqo7LbxMT64PRhQ== From: Liam Hupfer <liam@HIDDEN> To: Juri Linkov <juri@HIDDEN> Subject: Re: bug#75530: [PATCH v2 2/3] Remap read-only-mode for Occur modes (bug#75530) In-Reply-To: <87r04eupat.fsf@HIDDEN> References: <cover.1736729460.git.liam@HIDDEN> <cover.1738541428.git.liam@HIDDEN> <608c43362c724d3ca48d234cac46c23f81020ae6.1738541428.git.liam@HIDDEN> <lywme7y760.fsf@HIDDEN> <875xlq48hv.fsf@HIDDEN> <87r04eupat.fsf@HIDDEN> Date: Tue, 04 Feb 2025 23:27:20 -0600 Message-ID: <87wme57yh3.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75530 Cc: 75530 <at> debbugs.gnu.org, Howard Melman <hmelman@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Juri Linkov <juri@HIDDEN> writes: > One particular use case where it=E2=80=99s useful to disable the read-only > status with =E2=80=99C-x C-q=E2=80=99 is to use e.g. =E2=80=99M-x flush-l= ines=E2=80=99 to further > narrow down the results displayed in the Occur buffer. > >> Not to mention Occur uses text properties to make the >> line numbers read-only even when the buffer is writable. Maybe that >> wasn=E2=80=99t the case in 2013. > > Indeed, unfortunately this use case was precluded after the change > that added the read-only property on line numbers was made recently > on 2022-01-23 in the commit 1bcbca3750d9e8c47bee7ac893b885ade584d783. Thanks for confirming! > Maybe we need to revert this change and find another solution. Seeing as nobody seemed to notice or care that this use case was broken for three years and two major releases, I=E2=80=99m personally inclined to proceed further in the direction Lars set previously by considering Occur and Grep as proper special modes, with special C-x C-q behavior, like Dired. I don=E2=80=99t find the rationale particularly compelling that Occur and Grep buffer contents are more commonly edited as raw text than Dired. Not enough to justify the discrepancy, anyway. With special-mode=E2=80=99s bindings in mind, I think it makes more sense to cha= nge modes before editing the contents. I might have to retract that comment about prescribing workflows. This series is tweaking defaults, so I guess that=E2=80=99s its whole purpose! = Maybe others can chime in on their tastes here as well? Thanks for your input! --=-=-=--
bug-gnu-emacs@HIDDEN:bug#75530; Package emacs.
Full text available.Received: (at 75530) by debbugs.gnu.org; 4 Feb 2025 16:12:36 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 04 11:12:35 2025 Received: from localhost ([127.0.0.1]:46346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tfLXP-0000Fq-N2 for submit <at> debbugs.gnu.org; Tue, 04 Feb 2025 11:12:35 -0500 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:49250) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <drew.adams@HIDDEN>) id 1tfLXN-0000Fd-5O for 75530 <at> debbugs.gnu.org; Tue, 04 Feb 2025 11:12:34 -0500 Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 514DRfda029437; Tue, 4 Feb 2025 16:12:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2023-11-20; bh=JoneX+dwgzDeMnp0elhETOW0PWhNGBFedTVTJVyWZMs=; b= P9Iojq/HM0xkcHysxjZigK06QrZW79nqws5bWmi+Pze8OGBZvo3xMW5+5EossmLa nSYHDlc8MW1th3j6gLAg/trTO23odOoDp9asLa8EZ4/JOJZz/DscSRU1kSTWRELI 7W9VPc/u8C9QTNiZRtq92vyZ1Nx/EW2W0vDg7OD/OWf4a0ekIXt4Xe5cCnvt7jmG ykM01jpHvuaA6i2Lq8CW7UHlwPLum00OvGuhVMJKYLi74BN1V1PLsTV7SogRivFE GivBAG2apMomgXSUya4LIhoEsmKrSAxQNjcgrb2Kf37aZvhFv5OY3vuxPCFe+rQE Vytl4b2WBuozYR50jxIRJw== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 44kckxh2ys-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 04 Feb 2025 16:12:31 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 514EpErP029909; Tue, 4 Feb 2025 16:12:30 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2177.outbound.protection.outlook.com [104.47.55.177]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 44j8p36bav-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 04 Feb 2025 16:12:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iWNXKYH02wzQ8jQPecantujc17YQ9CHZSKpBw7aD65z8EcSTtQXG+LuujpKbzUCkpcg1sJt+GTzG5PJvCbZOalwddMoKFdsuryQ8npYOsc/OIx5tD9ofOmM8ss+Lsl2hw+BClFdrRC9ewE3bh0ZD3UipUlM7TJSzKCdTW/VVZzakIEK0L6teNCdu9EzRani8UI49fgIhpeybK4OQFWYR4lajeNnL7ZSX5klX0R5MnzBiqC/H6NM1McXr4IqftChZrERdVnkWBlvMJ6uVD/IZDo5499d8wu2maURid/ArwYSjuUVZ2unpa4F2uKuh7ghyhE1lN5Fiw8dltRu0kuo/Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JoneX+dwgzDeMnp0elhETOW0PWhNGBFedTVTJVyWZMs=; b=jXqMhWydI7dZfIIwl/EjI98OlQJ7d0PEj6whNRC2lm/XpGY4esqSjUdy/k3Bsb2IrdQmt1T1qKRmlw7FtCIwk/LVkoXZ6Rlr19W7tBb3NMHSc6PIGqkPLO+nV1eCeD62ZtKTT19V+rSvAD5OWk5KmuT/9Kb6pCA0bFoCGcq0vZrEOJNCbeHQ4eQjEZtsygpGC0VM7kHBIXFA79C5CmguLfDin3wW/JzGHgVOdsdOfwiVamMK5Hpn1Ttdm+oa0QuNqJxlITzzGG+D5aZIueVQwZAVvXgbUEncTCRJ32TIjj9yYNbzI7/1ckx12FzVZv6ku99MRYfI3tfNlL75W9lKzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JoneX+dwgzDeMnp0elhETOW0PWhNGBFedTVTJVyWZMs=; b=Stl4fc5kKrN4MiIj5azWm4nrh5h0Fitni/fXQUbAjGCZVYrO1HmwEZWWFwC1Cq42gP+AfCK0+EaDRgWVKAZ3bV+51JYRbI/3T0sP6CRGOJR0Y+nwID4saC5H35+uZCIVo0FOP6B6itXglxppEqzKuS18S7lQ8ZXOCRIHh+12H+Q= Received: from DS7PR10MB5232.namprd10.prod.outlook.com (2603:10b6:5:3aa::24) by MN6PR10MB8048.namprd10.prod.outlook.com (2603:10b6:208:4f4::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.23; Tue, 4 Feb 2025 16:12:29 +0000 Received: from DS7PR10MB5232.namprd10.prod.outlook.com ([fe80::8303:658f:14f8:2324]) by DS7PR10MB5232.namprd10.prod.outlook.com ([fe80::8303:658f:14f8:2324%4]) with mapi id 15.20.8398.021; Tue, 4 Feb 2025 16:12:29 +0000 From: Drew Adams <drew.adams@HIDDEN> To: Juri Linkov <juri@HIDDEN>, Liam Hupfer <liam@HIDDEN> Subject: RE: [External] : bug#75530: [PATCH v2 2/3] Remap read-only-mode for Occur modes (bug#75530) Thread-Topic: [External] : bug#75530: [PATCH v2 2/3] Remap read-only-mode for Occur modes (bug#75530) Thread-Index: AQHbdtkToUjL2pVmaUyVRmxeELFiVrM3UTpQ Date: Tue, 4 Feb 2025 16:12:29 +0000 Message-ID: <DS7PR10MB5232B2AAC342E542BE09D969F3F42@HIDDEN> References: <cover.1736729460.git.liam@HIDDEN> <cover.1738541428.git.liam@HIDDEN> <608c43362c724d3ca48d234cac46c23f81020ae6.1738541428.git.liam@HIDDEN> <lywme7y760.fsf@HIDDEN> <875xlq48hv.fsf@HIDDEN> <87r04eupat.fsf@HIDDEN> In-Reply-To: <87r04eupat.fsf@HIDDEN> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DS7PR10MB5232:EE_|MN6PR10MB8048:EE_ x-ms-office365-filtering-correlation-id: 5720f19b-0c16-45ff-77a6-08dd4536b928 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700018; x-microsoft-antispam-message-info: =?utf-8?B?UWRobFErajVJMjlETEhNU1dQRmMvcG0wR3hHT29Cc3p1VVh3ck5XQjRXNHlX?= =?utf-8?B?akFSbklqWG5nY2hKK1lQQkxQYTF6cFRYZnVMT2NmWldvaTA4YWRsczRwNnJY?= =?utf-8?B?UWNBMU5kb09QSTdZdnY3MW5NVGZtSnJpWnFOeWgwWVFVd0NuRUt0WDkwbEpU?= =?utf-8?B?djhsWDJpTmhFSDZ4bDR6SWt6OEwxeXpldkE4VDdWbXA2bGxmNnpkTlJ2RW4z?= =?utf-8?B?QXc3WHFLQTVqYXhjOFBoTkZHaE1NMVIxTXdQR2xxVEE2a2g1bW5HSUhLSC9Z?= =?utf-8?B?cEp2TXlrbUtKNEF4YjFscU5VTE5hSWJ2a0VkR3k5MzFuVXV1bzRCeU9OTXJR?= =?utf-8?B?dGY3K25TUkJTQndKSkIwRWJ2TkNZb1BrZ0NEMnFwYXhXcTNkMzY5NzNzL1Fl?= =?utf-8?B?TmhJK29NYW01VDluZkdMMWRjRHc2akdlRlBseVN5RnV4Szdaa3VKblFuYW10?= =?utf-8?B?UXVucmdrbTU2Qk5ZMzgvWDhyZFgzU1d2L2g3OWtUcG1mRktRQWRmK0RSYS80?= =?utf-8?B?SCtRbTQ0RUljM3krWDFiSitXRWowNk03T3NGNm1TRnpyS1MwWURnQlhuZWZJ?= =?utf-8?B?dnJQV2p4YTIzR2tXRmJ2dE1Na0F6RC9NVG5KbTFBUUwrZ3czY3JwMzJFUWJy?= =?utf-8?B?R0RndFRacHBPYUpnNVhkOXpNM2dhOEZSekJ5TER5OG1nSHNhdGpaRFFEUFZM?= =?utf-8?B?OTk1cmYyRWI1Rnpwc1hiS3pLaG5FSFByc21RamlYTnZqZnJOaTM2ajQxQUpL?= =?utf-8?B?azNjOUwydWFUSGYrcXQ2ODhQalN5R1lnZzZSNzlZY215QVprYm8zMTJ6Sm5U?= =?utf-8?B?bVZPMGNuTmZUVUhEZElvRzFWRzNwZmFFUUdKUnVoMTExa3MxZHp4Ym5XYnlS?= =?utf-8?B?aGg2VkdYd0t2NGVCQkZ1Y0kySERUTUVwTmFaNUEremNEazZvTkQ0K09IdkJP?= =?utf-8?B?VVdKSlAzR0tXbldudjViVWFBSVVSMGk5N1dINWI5dGViYlZ3Vjc4RkVydmpr?= =?utf-8?B?OUh2bWZYRjUyWkVyaDRnWkovQktJWnMzbnBRRzlRcTJUWldUSldObHh3NStv?= =?utf-8?B?eENDUzJUVEVlbzlscCtoQ3RQUnVubzduN2lBQmxPZzVNeXVHMEJyV3pXSi8y?= =?utf-8?B?ZFBhZXVxamlTTXV5M0t0Q2dHWUs5NFlpaWlCck00VkJoRHF2TUZFVGpKbTBS?= =?utf-8?B?bVZTNlFjZDZwM29WdGd4MmhRK3gxb3hFeVVDZmgreTc5UlIxNE5MU081S21r?= =?utf-8?B?NDhwQ2tDY2g2bDV1MWIvM09pQWlORDdTQVVCdWZqc1R0UUhQZWppMWRWUWg4?= =?utf-8?B?STRkUXE5M2RQLzlhUEVhZTBaZUx3dms3TGV3SHZnQ3puaFdOTWh1Y29ubElM?= =?utf-8?B?Z1pqYXBONHozU1pIZUhKMnFPR2ozeU5FdTRob0hYTjBQZDFTa0N5U1NRUWZi?= =?utf-8?B?T3NzcDJFUDVESndFeDJyZnllZFpvT00veUZpNW92SlcxMmUyNzIwbk8yOHN5?= =?utf-8?B?SFdXLzBjd2tzTVpvT0hqV1d4UEUwNjcvazNudGNXOTlFYmk2VnpSemxXTmti?= =?utf-8?B?dHFzb0M4REJSZXVtL3A0azU3K253ejJWeS9TR0xlakl6TzJBMVgzTllLZm1x?= =?utf-8?B?ZjV2UVdETHlHRHN2TXZvQ2tQRUErZDNpckdvU2ZCVW9NcnhaM0tvQysyckNo?= =?utf-8?B?RXpER1lUY3prOXdCNUwrekpoRjZPeVltaE9lYjc2UzNRSDB3R3I3aGRvZ0F4?= =?utf-8?B?N0p3TUc1eVRheUhEenBZQ1RjTXBVNFYxVHNNR25GSU1KUHJyKzhleWtia3k0?= =?utf-8?B?ZXZodkdOT0hwMi9JVURqdll0VWhGQVBEYis5SmIwR0lFMit2dGhNUC9oSTB4?= =?utf-8?B?QnFRM0ZEUEE1THZDa1luNjVsd3A5aThScDBRRWovaUlrK0grVW82Q0VDVUE2?= =?utf-8?Q?52pkq69eBt4GRFWNUfHd9xkSzocQoHP6?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS7PR10MB5232.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Tkp3aENVTmQzMTFaVU5SdFRyenFaL1FnQjFrRERZcFM2bSs5SzdqRkoyaTlo?= =?utf-8?B?bUo3R3NIQ2JCNVJIUXhxSWdlMnJIamJZZWNnVGlCUVFTdWw1UWRscTZRY1BD?= =?utf-8?B?cjNoVWt1Mzc5V1dlUlFjcFh1bCs2bllOZDBPTm1zaGJMbU0vOVhVR242MXNz?= =?utf-8?B?bk5HMDVHS2RwSG5NejdieU0xbjM3cFJFa0FaZTRrT05UVjU1QmhhdTZBN3Q5?= =?utf-8?B?TFVwbUlxeUp5RHhCakpWbmdsN2dzeWxSWXQyeVlxY0l4YXV1dGJmSGx4bG9q?= =?utf-8?B?b3VkdEljakI1V0xUcjMwbzRoZ3FGaENuaVhmcEpYT0RxYnB6eEJSUlpOalh3?= =?utf-8?B?a1FjNWlNcXV3cytTVUpjQTRQN2JyZDNHalp0YU9hNGlPNlVzc2xJUDR6d3NB?= =?utf-8?B?Uk94d0NXNXNVL0lIbEV6U2R2YlR4b2gwSnMya2dSMmRuNERuQXVhQlVMZDlk?= =?utf-8?B?eWZtRnFPdFhrWDlIc2I5VW9zRDJPMHhzdHZWQ2JLSjJNS2UzWWJzL0JWMlRX?= =?utf-8?B?dytlOGhTNngzYy82a0ZFWEY5VmJLR1MvVnpZWE1LOXFYU09IZ2RreTR6Q005?= =?utf-8?B?dThaaTRuY3Jzb0Y4R3B2ajRwV1lpMXR6bUV3czVBNzFtZGY1RVpqOVFNWmdq?= =?utf-8?B?Y1dGU0I5Y0g0TWNtb0ovbGE0bjI0V01YYWtCY2hYdEFORldpam5OSk5sOGlG?= =?utf-8?B?U1RGczMxWnN4MTFjUXU1RGtkbUZVWHRKUW5YREZ6ckF1RHU2L0hZdTN4SnV4?= =?utf-8?B?Rm5FL1JZRml1eDFGRGppejFPeFlRd1ZEVTJxM1p1MHlaNXpGVXRjdHBqR0Fx?= =?utf-8?B?aVdsR1dQbUN4NGZGc1UyamlQOXFpZ1YvNE1zekx0N3pFUmMxR0pUVnlla3dQ?= =?utf-8?B?eHV6dFB4RHNUc0g5aUFuR1I3K1lOVGN0TW5KL2tpN3YrYmxuMHVxQW94YnpM?= =?utf-8?B?UmNZZm0yREt6MlBVbTBSeVJ0bjlPb3R3STJrQ3JETDlrUTE2ZVRWU0lvTi9B?= =?utf-8?B?OXJYbkFHNVJmdGhXVUJQTitrUlE1Tmg1MFozemIxVEs5bWJNV21KVlFIRC9n?= =?utf-8?B?R1F4a0QvMjdYUERTTWdjSitxcW16NmdQcVpYenpSbUk0ZW5vSzB1TVdya1dM?= =?utf-8?B?eEVJUlZ3bmJkQ0xkcWx0c0hXVmc2SC9IZ1ZRZVgrQzRId3J3bGxkSWIwWUdm?= =?utf-8?B?KzdLUWFEbkhFemFGYytneUVzc2kxakNQSDE5NTJCdkw1eEltRFlsdVQ0Zmlt?= =?utf-8?B?YkpSemI3VTd0UE8rcDNWNWxGdFYwYnNwaGY4TFY4bHdZTEE3ejdOK0U5QXQx?= =?utf-8?B?SFY5Ym52dENMM3g1RFFTNzRoVWprRk1Db0NQcGJvRFQvODlwS3ZrVzYrbXJC?= =?utf-8?B?QVBuVEp2RVFabnBXMGczczRxeFd2OGNrcjZwdytyUTlZVGtNR0trMFZDV2FC?= =?utf-8?B?bjFGLzhhNW1ZYTlhY0JyNjRYSkF5c0ZFeHhYd3ZNVGJBb0tpK0ZaTnpIK2pD?= =?utf-8?B?dk92WmZvbzJ4UGdTMHRNWjVBUm4xRENCbEhpWUFuUUY1VmVLdHVGVzRKSFZj?= =?utf-8?B?TURNOU54bG9XTmh0TmZHcXFqQUJnaFJyZGtreTh2M1FqVUhPMnFEZERGVDQ4?= =?utf-8?B?LzA3NmRjeW9Ea21ncG9vWnBhMVF0bWNmbkRvTGd1cjNXZHViUFFEVHUxRmg4?= =?utf-8?B?NUp2NnZwRm8wT3VPTnZ0RlQ5eXRpUjFxNFI1NmJDNzRZdzBvYzd5ak9ZVHEv?= =?utf-8?B?eisyMGtzS3AzR1BraWozb1lEL3EzbmRLNU5rUzV6OHVEV202Q3VIZ0F3YzdP?= =?utf-8?B?bVFIWDdMVHhTOHU2TVNYK0p5UENLNXppWXNuak1UeCtxZWFDUTNCeENNb3lL?= =?utf-8?B?M25LaEFYY09LL1dreFRrVTlsUzFONG1zeGJ2U0IwWkVnVmtZcnNYKzEwdDFC?= =?utf-8?B?Q3JDOGxCTndGbmg0c2VaN0VuTDQ0VkU5eTYxaWk1eUd1VTlLNWN2akhxS21p?= =?utf-8?B?amhwZDZWLzBBekVkV0xUekduNVI2STlmMU1BYVY5bUpWRE1ZdEJEMVJrUGQz?= =?utf-8?B?bEFYcERMbnZGVHRoK2xqTmF2c01uSDl2WUEvdjZQU01ZZkpFeHZNNmxPU1pq?= =?utf-8?Q?HCmDXM5w5NR3ieoU44RJOWA6O?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: T16nIRzj3Wwh9OV9BP0rXowR2nUDPP6lzlbZwPae9TwrD638V/fFNdePwO/IFaw5nk1YRh9Xo3O1DCUw7pCVKf9pqcxA/5wc2WUY6AaO2nl7fkwtp+5ZYJ9cgEySspYAPXw9nBk0pbFyAP+rYsj891X4WDuCARIevyz7EEkkOUh93sGmAesJ7wF3YUmIprsLf8tocji9muXKwGVIEbO+SVxFpqWl+3rBsy6c3qAMp1D1vIxS27htbJyWS5kNEij8otKVv9+FIQBdU3yy4cQEevAUfCB9RMHHi699XgenyjbEPE+FfopaNZLnqqvDAEVxPRKALBEHNROVIn9gwMKoTvxRnhTIlzk3EVZJx6By+ngXC/8OAkfczsxrIQXQGsS1JBwaphUxBL655HjOcBak5vEBYm4xAlus6g0UaMT7OS0yVESmNbhliTa+pr91cRlqeFPGDkHavLsVcjqbm9V7VMbSRPr83g3j+9yOs5oD1HY+F1rxXBycXAl2s1+pCWNgyt5YswiJkoI1tTd6bcGsDdgvYMGsGhYBL/29L7EDUDJ5IylCjToLZfi7HOFDZQAaWSCkXsoFT5qPOhT1ROmWlUXTonH7oi5qPEey34aJvzI= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB5232.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5720f19b-0c16-45ff-77a6-08dd4536b928 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2025 16:12:29.2946 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rHxeHQpysp4J6biy8IRqYE6lqb5dauMbc/NtX/lcGoU3cuI5WTgwSB8ISQMULVuvakM2Sv0tLXzJ1fY4r/629A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR10MB8048 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-04_07,2025-02-04_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 suspectscore=0 adultscore=0 mlxscore=0 spamscore=0 malwarescore=0 mlxlogscore=948 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2501170000 definitions=main-2502040125 X-Proofpoint-GUID: F8j9a0or16BY98YTZ0E-8le2NFMoUlgT X-Proofpoint-ORIG-GUID: F8j9a0or16BY98YTZ0E-8le2NFMoUlgT X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75530 Cc: "75530 <at> debbugs.gnu.org" <75530 <at> debbugs.gnu.org>, Howard Melman <hmelman@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) PiBPbmUgcGFydGljdWxhciB1c2UgY2FzZSB3aGVyZSBpdCdzIHVzZWZ1bCB0byBkaXNhYmxlIHRo ZSByZWFkLW9ubHkNCj4gc3RhdHVzIHdpdGggJ0MteCBDLXEnIGlzIHRvIHVzZSBlLmcuICdNLXgg Zmx1c2gtbGluZXMnIHRvIGZ1cnRoZXINCj4gbmFycm93IGRvd24gdGhlIHJlc3VsdHMgZGlzcGxh eWVkIGluIHRoZSBPY2N1ciBidWZmZXIuDQoNCkFic29sdXRlbHkuDQo=
bug-gnu-emacs@HIDDEN:bug#75530; Package emacs.
Full text available.Received: (at 75530) by debbugs.gnu.org; 4 Feb 2025 07:46:19 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 04 02:46:19 2025 Received: from localhost ([127.0.0.1]:42452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tfDdT-00053t-B7 for submit <at> debbugs.gnu.org; Tue, 04 Feb 2025 02:46:19 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:36243) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1tfDdO-00053M-5q for 75530 <at> debbugs.gnu.org; Tue, 04 Feb 2025 02:46:14 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id DFD1C443F7; Tue, 4 Feb 2025 07:46:03 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Liam Hupfer <liam@HIDDEN> Subject: Re: bug#75530: [PATCH v2 2/3] Remap read-only-mode for Occur modes (bug#75530) In-Reply-To: <875xlq48hv.fsf@HIDDEN> (Liam Hupfer's message of "Mon, 03 Feb 2025 22:52:12 -0600") Organization: LINKOV.NET References: <cover.1736729460.git.liam@HIDDEN> <cover.1738541428.git.liam@HIDDEN> <608c43362c724d3ca48d234cac46c23f81020ae6.1738541428.git.liam@HIDDEN> <lywme7y760.fsf@HIDDEN> <875xlq48hv.fsf@HIDDEN> Date: Tue, 04 Feb 2025 09:44:42 +0200 Message-ID: <87r04eupat.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduleelgecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefujghofhffkfgfgggtgfesthekredttderjeenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeeiffetjeegheffjeeutdeihfdukeegjeetkeeigfevueehtedvfeegkeekveekudenucfkphepledurdduvdelrdeliedrledtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrdeliedrledtpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepfedprhgtphhtthhopeejheehfedtseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohephhhmvghlmhgrnhesghhmrghilhdrtghomhdprhgtphhtthhopehlihgrmheshhhpfhhrrdhnvght X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75530 Cc: 75530 <at> debbugs.gnu.org, Howard Melman <hmelman@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >> The difference is because it’s more useful to type `C-x C-q’ to change >> read-onlyness of an occur buffer and edit it textually than to do the >> same in a dired buffer where random edits (other than renaming file >> names) make less sense. > > This is a little confusing to me. ‘read-only-mode’ on its own will make > the buffer editable, but won’t it leave Occur or Grep’s special bindings > in place? So you can’t even insert text! Seems to me that > ‘fundamental-mode’ followed by ‘read-only-mode’ (which would then be > available on ‘C-x C-q’) would be needed? Or ‘switch-to-buffer’ plus > ‘insert-buffer’? One particular use case where it's useful to disable the read-only status with 'C-x C-q' is to use e.g. 'M-x flush-lines' to further narrow down the results displayed in the Occur buffer. > Not to mention Occur uses text properties to make the > line numbers read-only even when the buffer is writable. Maybe that > wasn’t the case in 2013. Indeed, unfortunately this use case was precluded after the change that added the read-only property on line numbers was made recently on 2022-01-23 in the commit 1bcbca3750d9e8c47bee7ac893b885ade584d783. Maybe we need to revert this change and find another solution.
bug-gnu-emacs@HIDDEN:bug#75530; Package emacs.
Full text available.Received: (at 75530) by debbugs.gnu.org; 4 Feb 2025 04:52:33 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 03 23:52:33 2025 Received: from localhost ([127.0.0.1]:42174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tfAvJ-0005ER-8d for submit <at> debbugs.gnu.org; Mon, 03 Feb 2025 23:52:33 -0500 Received: from out-180.mta0.migadu.com ([91.218.175.180]:56445) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <liam@HIDDEN>) id 1tfAvF-0005E9-K9 for 75530 <at> debbugs.gnu.org; Mon, 03 Feb 2025 23:52:31 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpfr.net; s=key1; t=1738644738; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sH8LQXgVNBbfqGH3IwJxJwDwVRajFBiqjTb3hbJ+NEQ=; b=lF/YaB0oE5Zm+jllxOppzwIdNnOt7gbuaV0wY0fFQFVTf5PZ6N/h/13uPpU9o0xXdIgLqR 9uuD+Qb5964GRJj7UZco6IC6Ce7ikuWjyZWbFAj5n+3bx4gyWckwI1Ny8Ao2JWRdVrBtQv 2CtzbD36f8v52atC17gliDH/JuWv/qpVemyTMQgwLtXybYCh/dQELrm61YhggLxOOWVRSv 3rzRGollswpiEQ7PEhkknrZC8nynRCGCXaZG7mVSxQ7ZOX1/zmRoqkbES3jDgxlINadRWf ODttjXvFByCkHcH+dvalABaqPX7FmZmOalAJ9dDyD6Qv5Fpjgfwr7R2L7kmmLA== From: Liam Hupfer <liam@HIDDEN> To: Howard Melman <hmelman@HIDDEN>, 75530 <at> debbugs.gnu.org Subject: Re: bug#75530: [PATCH v2 2/3] Remap read-only-mode for Occur modes (bug#75530) In-Reply-To: <lywme7y760.fsf@HIDDEN> References: <cover.1736729460.git.liam@HIDDEN> <cover.1738541428.git.liam@HIDDEN> <608c43362c724d3ca48d234cac46c23f81020ae6.1738541428.git.liam@HIDDEN> <lywme7y760.fsf@HIDDEN> Date: Mon, 03 Feb 2025 22:52:12 -0600 Message-ID: <875xlq48hv.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75530 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Howard, Don=E2=80=99t forget to reply all! Not everyone subscribes to bug-gnu-emacs= . I just happened to check this thread on <https://yhetil.org>. Fortunately [piem-inject-thread-into-maildir] makes it easy to correct this. Might have to make that a habit on my end. Howard Melman <hmelman@HIDDEN> writes: > I am all for consistency in these three mode, see Emacs bug#16214. But > in that discussion people brought up that unlike for dired, for occur > and grep, people sometimes use those commands to (1) search for and > collect text, and then edit into something (say a list or paragraph) > rather than wanting to (2) edit changes into the original sources > (which they also want to do some other times). So the proposal was to > leave C-x C-q to change read-only to cover the first case and to use > =E2=80=9Ce=E2=80=9D to enter the =E2=80=9Cwritable=E2=80=9D modes in all = three cases and for the > second case. C-x C-q in dired was fine to leave to enter wdired since > (1) it already does that and (2) people don=E2=80=99t edit the output the= re > much. Looks like you=E2=80=99re referring to [Juri=E2=80=99s reply]: > The difference is because it=E2=80=99s more useful to type `C-x C-q=E2=80= =99 to change > read-onlyness of an occur buffer and edit it textually than to do the > same in a dired buffer where random edits (other than renaming file > names) make less sense. This is a little confusing to me. =E2=80=98read-only-mode=E2=80=99 on its o= wn will make the buffer editable, but won=E2=80=99t it leave Occur or Grep=E2=80=99s spe= cial bindings in place? So you can=E2=80=99t even insert text! Seems to me that =E2=80=98fundamental-mode=E2=80=99 followed by =E2=80=98read-only-mode=E2= =80=99 (which would then be available on =E2=80=98C-x C-q=E2=80=99) would be needed? Or =E2=80=98switch= -to-buffer=E2=80=99 plus =E2=80=98insert-buffer=E2=80=99? Not to mention Occur uses text properties = to make the line numbers read-only even when the buffer is writable. Maybe that wasn=E2=80=99t the case in 2013. I don=E2=80=99t mean to prescribe people their [workflows], of course. Mayb= e I=E2=80=99m missing something? Thanks! [piem-inject-thread-into-maildir] <https://docs.kyleam.com/piem.html> [Juri=E2=80=99s reply] <https://yhetil.org/emacs/87sitl51un.fsf@HIDDEN= org/> [workflows] <https://xkcd.com/1172/> --=-=-=--
bug-gnu-emacs@HIDDEN:bug#75530; Package emacs.
Full text available.
Received: (at 75530) by debbugs.gnu.org; 4 Feb 2025 04:10:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 03 23:10:25 2025
Received: from localhost ([127.0.0.1]:42130 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tfAGW-0003I1-GO
for submit <at> debbugs.gnu.org; Mon, 03 Feb 2025 23:10:25 -0500
Received: from out-183.mta1.migadu.com ([95.215.58.183]:63632)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <liam@HIDDEN>) id 1tfAGT-0003GR-Sy
for 75530 <at> debbugs.gnu.org; Mon, 03 Feb 2025 23:10:22 -0500
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpfr.net; s=key1;
t=1738642215;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=w7+IjP/x/xpzf3s0iJi6TIg02aNXqYYpDpRNKI7l3Aw=;
b=LzX/eJhJFPlgoFcc1Tka0STbZhIaK3kcjo/eIK9Q4JXs5JX0mFFQHuGB+JN1nzS3k+OSBF
QAlcooIC33mW7tAJOwB8N3XZ4rXpIxfwm/S2ebWc3P3UJCOZ0d62o/Wbt+HguLdHxMtdar
+PJkgP90pYwiTUWqKfGact18ZfHvNEJFxXI3GMbLpAd9gy+F6FSKOjFCH1vPAafrjHqRSC
b+UU7yc1UE5VB+7Dm8D0zu60aVLrQVMqTlB79o6+SECGKWXulMYTHSCO8rwlERkSG7XZyY
Ck+MsiqnQOtUYot90je2o94g594b1roZUzIyMHpF8x/Ai0+5YhqomS25wxpVag==
From: Liam Hupfer <liam@HIDDEN>
To: 75530 <at> debbugs.gnu.org
Subject: [PATCH v2.1 0/3] Consistently remap read-only-mode for special edit
modes
Date: Mon, 3 Feb 2025 22:10:03 -0600
Message-ID: <20250204041003.423902-1-liam@HIDDEN>
In-Reply-To: <cover.1736729460.git.liam@HIDDEN>
References: <cover.1736729460.git.liam@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Migadu-Flow: FLOW_OUT
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 75530
Cc: Eli Zaretskii <eliz@HIDDEN>, Liam Hupfer <liam@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
v2.1 is v2 but in a single email per Eli’s preference. Apparently
git-send-email(1) doesn’t expose a way to create a single email with
multiple patches as MIME attachments, but the --output and --no-thread
options are sufficient to generate one long message that applies cleanly
with ‘git am --empty=drop’.
Thanks!
Liam Hupfer (3):
Remap read-only-mode in wdired-mode-map (bug#75530)
Remap read-only-mode for Occur modes (bug#75530)
Remap read-only-mode for Grep Edit (bug#75530)
etc/NEWS | 23 +++++++++++++++++++----
lisp/progmodes/grep.el | 6 ++++--
lisp/replace.el | 2 ++
lisp/wdired.el | 2 +-
4 files changed, 26 insertions(+), 7 deletions(-)
base-commit: c4a67a405072601b9d7dd95dc94c0b402e1e0ae6
--
2.47.1
From 551fcce44e2ea235cdae8da3d9afefe5e7a0a9b5 Mon Sep 17 00:00:00 2001
From: Liam Hupfer <liam@HIDDEN>
Date: Sun, 12 Jan 2025 12:24:38 -0600
Subject: [PATCH v2.1 1/3] Remap read-only-mode in wdired-mode-map (bug#75530)
dired-mode-map already remaps read-only-mode to dired-toggle-read-only.
Make wdired-mode-map remap as well, instead of hardcoding the default
C-x C-q.
* lisp/wdired.el (wdired-mode-map): Remap read-only-mode to wdired-exit.
* etc/NEWS (Dired): Document remap.
---
etc/NEWS | 6 ++++++
lisp/wdired.el | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/etc/NEWS b/etc/NEWS
index 8cf86d1375d..6893d71268a 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -892,6 +892,12 @@ Without 'dired-hide-details-hide-absolute-location':
When 'dired-make-directory-clickable' is non-nil, clicking on the base
name of the directory now reverts the Dired buffer.
+---
+*** 'wdired-exit' binding now respects user 'read-only-mode' bindings.
+If you add or change bindings for 'read-only-mode', 'wdired-exit' will
+respect those bindings. Previously, it used a fixed 'C-x C-q' binding
+regardless of 'read-only-mode' bindings.
+
** Grep
+++
diff --git a/lisp/wdired.el b/lisp/wdired.el
index c7409446b19..78d0c7e0716 100644
--- a/lisp/wdired.el
+++ b/lisp/wdired.el
@@ -160,7 +160,7 @@ nonexistent directory will fail."
"C-c C-c" #'wdired-finish-edit
"C-c C-k" #'wdired-abort-changes
"C-c C-[" #'wdired-abort-changes
- "C-x C-q" #'wdired-exit
+ "<remap> <read-only-mode>" #'wdired-exit
"RET" #'undefined
"C-j" #'undefined
"C-o" #'undefined
--
2.47.1
From 5fe91fc4cb5deebc38d8fca3d4ebda935cfe9e58 Mon Sep 17 00:00:00 2001
From: Liam Hupfer <liam@HIDDEN>
Date: Sun, 12 Jan 2025 12:31:17 -0600
Subject: [PATCH v2.1 2/3] Remap read-only-mode for Occur modes (bug#75530)
occur-edit-mode behaves similarly to wdired-mode. Dired remaps
read-only-mode to toggle wdired, so set up similar remaps for
occur-mode-map and occur-edit-mode-map.
* lisp/replace.el (occur-mode-map): Remap read-only-mode to
occur-edit-mode.
(occur-edit-mode-map): Remap read-only-mode to occur-cease-edit.
* etc/NEWS (Occur mode): Document Occur Edit entry/exit remaps.
---
etc/NEWS | 8 ++++++++
lisp/replace.el | 2 ++
2 files changed, 10 insertions(+)
diff --git a/etc/NEWS b/etc/NEWS
index 6893d71268a..ce78759849c 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -1082,6 +1082,14 @@ destination window is chosen using 'display-buffer-alist'. Example:
display-buffer-use-some-window)
(some-window . mru))))
+** Occur mode
+
+---
+*** New Occur Edit entry and exit based on 'read-only-mode' bindings.
+In addition to entering 'occur-edit-mode' with 'e' and exiting with 'C-c
+C-c', you can now use 'C-x C-q' (or anywhere you bind 'read-only-mode')
+for entry and exit.
+
* New Modes and Packages in Emacs 31.1
diff --git a/lisp/replace.el b/lisp/replace.el
index 3bd803ce347..724e54f256b 100644
--- a/lisp/replace.el
+++ b/lisp/replace.el
@@ -1304,6 +1304,7 @@ a previously found match."
(define-key map [mouse-2] 'occur-mode-mouse-goto)
(define-key map "\C-c\C-c" 'occur-mode-goto-occurrence)
(define-key map "e" 'occur-edit-mode)
+ (define-key map [remap read-only-mode] 'occur-edit-mode)
(define-key map "\C-m" 'occur-mode-goto-occurrence)
(define-key map "o" 'occur-mode-goto-occurrence-other-window)
(define-key map "\C-o" 'occur-mode-display-occurrence)
@@ -1366,6 +1367,7 @@ Alternatively, click \\[occur-mode-mouse-goto] on an item to go to it.
(set-keymap-parent map text-mode-map)
(define-key map [mouse-2] 'occur-mode-mouse-goto)
(define-key map "\C-c\C-c" 'occur-cease-edit)
+ (define-key map [remap read-only-mode] 'occur-cease-edit)
(define-key map "\C-o" 'occur-mode-display-occurrence)
(define-key map "\C-c\C-f" 'next-error-follow-minor-mode)
(define-key map [menu-bar occur] (cons "Occur" occur-menu-map))
--
2.47.1
From b1b4dc4816acb7a8727129c74fd1c9ce3538fa89 Mon Sep 17 00:00:00 2001
From: Liam Hupfer <liam@HIDDEN>
Date: Sun, 12 Jan 2025 17:16:13 -0600
Subject: [PATCH v2.1 3/3] Remap read-only-mode for Grep Edit (bug#75530)
Like Dired and Occur, Grep buffers now remap read-only-mode to a useful
editing mode.
* lisp/progmodes/grep.el (grep-mode-map): Remap read-only-mode to
grep-change-to-grep-edit-mode.
(grep-edit-mode-map): Remap read-only-mode to grep-edit-save-changes.
* etc/NEWS (Grep): Document remaps.
---
etc/NEWS | 9 +++++----
lisp/progmodes/grep.el | 6 ++++--
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/etc/NEWS b/etc/NEWS
index ce78759849c..45fff54f433 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -902,10 +902,11 @@ regardless of 'read-only-mode' bindings.
+++
*** Grep results can be edited to reflect changes in the originating file.
-Like Occur Edit mode, typing 'e' in the "*grep*" buffer will now make
-the 'grep' results editable. The edits will be reflected in the buffer
-visiting the originating file. Typing 'C-c C-c' will leave the Grep
-Edit mode.
+Like Occur Edit mode, typing 'e' or 'C-x C-q' (or your own
+'read-only-mode' binding) in the "*grep*" buffer will now make the
+'grep' results editable. The edits will be reflected in the buffer
+visiting the originating file. Typing 'C-c C-c' or 'C-x C-q' (or your
+own 'read-only-mode' binding) will leave the Grep Edit mode.
** time-stamp
diff --git a/lisp/progmodes/grep.el b/lisp/progmodes/grep.el
index d04e9945b0d..b29f56c9ed4 100644
--- a/lisp/progmodes/grep.el
+++ b/lisp/progmodes/grep.el
@@ -312,7 +312,8 @@ This keymap inherits from `compilation-minor-mode-map'."
"TAB" #'compilation-next-error
"<backtab>" #'compilation-previous-error
- "e" #'grep-change-to-grep-edit-mode)
+ "e" #'grep-change-to-grep-edit-mode
+ "<remap> <read-only-mode>" #'grep-change-to-grep-edit-mode)
(easy-menu-define grep-menu-map grep-mode-map
"Menu for grep buffers."
@@ -1083,7 +1084,8 @@ list is empty)."
(defvar-keymap grep-edit-mode-map
:doc "Keymap for `grep-edit-mode'."
:parent text-mode-map
- "C-c C-c" #'grep-edit-save-changes)
+ "C-c C-c" #'grep-edit-save-changes
+ "<remap> <read-only-mode>" #'grep-edit-save-changes)
(defvar grep-edit-mode-hook nil
"Hooks run when changing to Grep-Edit mode.")
--
2.47.1
bug-gnu-emacs@HIDDEN:bug#75530; Package emacs.
Full text available.Received: (at 75530) by debbugs.gnu.org; 4 Feb 2025 03:52:37 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 03 22:52:37 2025 Received: from localhost ([127.0.0.1]:42103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tf9zJ-0002OG-3T for submit <at> debbugs.gnu.org; Mon, 03 Feb 2025 22:52:37 -0500 Received: from out-174.mta1.migadu.com ([95.215.58.174]:49409) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <liam@HIDDEN>) id 1tf9zH-0002Nz-1l for 75530 <at> debbugs.gnu.org; Mon, 03 Feb 2025 22:52:35 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpfr.net; s=key1; t=1738641148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4krRVXO5iG3TIHtsctC/llMk+VroM7+By43LnOISAP0=; b=Ku7/vArh9pBYiPDjmbKT/TMJUJUJe2Qcji5xZFnS/AdgXBaBabTUeyGgRu3i1+MqlThdl1 V+Xi1PzeMOor31LQvaW3BRDrWM8fVZTm7ZAFhCJY367ys+L66uT2IncpASUJfY5sgVetP8 LnNvQoaNJvmPQq4l3Qg9oDKkIrGKFWCjRYT48IB5butY9LKCWo9HnKiuWMyKDqctJq5u0T 19R/UZnPqn77DOb+a9k0XWcmbUQ5RCj03eeysn5a+IDUjGR2tYE8SUzBtXBb+gn/K6s2eu E4Q5YAxONE0Sr4vUYJUf+uQAPhHGw0N67eHgh3YmBD8rGW4e82yorEICM1hdSQ== From: Liam Hupfer <liam@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#75530: [PATCH 3/3] Remap read-only-mode for Grep Edit In-Reply-To: <86cyfzckrr.fsf@HIDDEN> References: <cover.1736729460.git.liam@HIDDEN> <946f456c4d7b9e8b4db28c5f5c6737b289d14439.1736729460.git.liam@HIDDEN> <868qr8benh.fsf@HIDDEN> <87h65c9mbn.fsf@HIDDEN> <86ed0gcevs.fsf@HIDDEN> <87bjvk3xew.fsf@HIDDEN> <86cyfzckrr.fsf@HIDDEN> Date: Mon, 03 Feb 2025 21:52:23 -0600 Message-ID: <878qqm4b9k.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75530 Cc: 75530 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Eli Zaretskii <eliz@HIDDEN> writes: >> From: Liam Hupfer <liam@HIDDEN> >> Cc: 75530 <at> debbugs.gnu.org >> Date: Sun, 02 Feb 2025 14:27:03 -0600 >>=20 >> Aside: do you always prefer patch series as attachments to a single >> message rather than threaded messages, or just recommend it to stave off >> malformed patches from users who don=E2=80=99t use git-send-email? > > A single message is preferred, as that makes it easier for me to find > related messages (the Subject stays the same). But since you=E2=80=99ve > already sent the patches as separate messages without waiting for me > to reply, this sounds a moot point=E2=80=A6 I just wanted to get it out there in its current state in case you had more feedback while I was away. I=E2=80=99ll resend as a single message and= keep that in mind going forward! =E2=80=94Liam --=-=-=--
bug-gnu-emacs@HIDDEN:bug#75530; Package emacs.
Full text available.Received: (at 75530) by debbugs.gnu.org; 3 Feb 2025 11:47:50 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 03 06:47:50 2025 Received: from localhost ([127.0.0.1]:38084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1teuvd-0001oP-OS for submit <at> debbugs.gnu.org; Mon, 03 Feb 2025 06:47:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44220) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1teuva-0001o4-Sa for 75530 <at> debbugs.gnu.org; Mon, 03 Feb 2025 06:47:47 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1teuvV-00085V-D2; Mon, 03 Feb 2025 06:47:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=7hAh6VQUljJ5b/oZrP+AqahLJZ/mWeKFefumae0haHI=; b=cw47GdgqqoRwkdtLjjdt Ehxj6pe3gRnxyQJndDiFdGZgSrwhzw+aFwpaNsgiMrfHbd5t/EivBNVibUJ4SUxCUO14TZhpAuTWa 8tRdyBsgqnBgUpe10ec1BoVl+GBMfAxClm6wpunQiptzU7QjNagiMTM3AiE5XfKIUppmqaZlxgsWo O/Xo7h1ddaz2kiAt/wr7kVvtMr+hoLdBqitsMgoVksYPPd0d2rVus8NyGwCua7NRP3GqWZsCss5Kr M/Z3hLlWqZDdnQc0M10KD9NCXyTCv8t45d2vItXMmQZ9LxR0UMl4ckA9yEGI0B+MId5oKRKSKh3Jr tT08Zaa9j3tquA==; Date: Mon, 03 Feb 2025 13:47:36 +0200 Message-Id: <86cyfzckrr.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Liam Hupfer <liam@HIDDEN> In-Reply-To: <87bjvk3xew.fsf@HIDDEN> (message from Liam Hupfer on Sun, 02 Feb 2025 14:27:03 -0600) Subject: Re: bug#75530: [PATCH 3/3] Remap read-only-mode for Grep Edit References: <cover.1736729460.git.liam@HIDDEN> <946f456c4d7b9e8b4db28c5f5c6737b289d14439.1736729460.git.liam@HIDDEN> <868qr8benh.fsf@HIDDEN> <87h65c9mbn.fsf@HIDDEN> <86ed0gcevs.fsf@HIDDEN> <87bjvk3xew.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75530 Cc: 75530 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Liam Hupfer <liam@HIDDEN> > Cc: 75530 <at> debbugs.gnu.org > Date: Sun, 02 Feb 2025 14:27:03 -0600 > > Aside: do you always prefer patch series as attachments to a single > message rather than threaded messages, or just recommend it to stave off > malformed patches from users who don’t use git-send-email? A single message is preferred, as that makes it easier for me to find related messages (the Subject stays the same). But since you've already sent the patches as separate messages without waiting for me to reply, this sounds a moot point...
bug-gnu-emacs@HIDDEN:bug#75530; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 3 Feb 2025 04:38:37 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 02 23:38:37 2025 Received: from localhost ([127.0.0.1]:37192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1teoEH-0000GB-5l for submit <at> debbugs.gnu.org; Sun, 02 Feb 2025 23:38:37 -0500 Received: from lists.gnu.org ([2001:470:142::17]:55094) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <geb-bug-gnu-emacs@HIDDEN>) id 1teoEE-0000Fr-As for submit <at> debbugs.gnu.org; Sun, 02 Feb 2025 23:38:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>) id 1teoE8-0008Ob-Rq for bug-gnu-emacs@HIDDEN; Sun, 02 Feb 2025 23:38:28 -0500 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>) id 1teoE7-00021u-It for bug-gnu-emacs@HIDDEN; Sun, 02 Feb 2025 23:38:28 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from <geb-bug-gnu-emacs@HIDDEN>) id 1teoE5-0007QZ-1N for bug-gnu-emacs@HIDDEN; Mon, 03 Feb 2025 05:38:25 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@HIDDEN From: Howard Melman <hmelman@HIDDEN> Subject: Re: bug#75530: [PATCH v2 2/3] Remap read-only-mode for Occur modes (bug#75530) Date: Sun, 02 Feb 2025 23:38:15 -0500 Message-ID: <lywme7y760.fsf@HIDDEN> References: <cover.1736729460.git.liam@HIDDEN> <cover.1738541428.git.liam@HIDDEN> <608c43362c724d3ca48d234cac46c23f81020ae6.1738541428.git.liam@HIDDEN> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Cancel-Lock: sha1:KcJobcWL0SI/v/He+D94Gn8K/B4= Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@HIDDEN; helo=ciao.gmane.io X-Spam_score_int: 1 X-Spam_score: 0.1 X-Spam_bar: / X-Spam_report: (0.1 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.066, NML_ADSP_CUSTOM_MED=0.9, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Liam Hupfer writes: > occur-edit-mode behaves similarly to wdired-mode. Dired remaps > read-only-mode to toggle wdired, so set up similar remaps for > occur-mode-map and occur-edit-mode-map. I am all for consistency in these three mode, see Emacs bug#16214. But in that discussion people brought up that unlike for dired, for occur and grep, people sometimes use those commands to (1) search [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org] 1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received' headers -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 T_SPF_PERMERROR SPF: test of record failed (permerror) 0.1 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (hmelman[at]gmail.com) 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.1 (/) Liam Hupfer <liam@HIDDEN> writes: > occur-edit-mode behaves similarly to wdired-mode. Dired remaps > read-only-mode to toggle wdired, so set up similar remaps for > occur-mode-map and occur-edit-mode-map. I am all for consistency in these three mode, see Emacs bug#16214. But in that discussion people brought up that unlike for dired, for occur and grep, people sometimes use those commands to (1) search for and collect text, and then edit into something (say a list or paragraph) rather than wanting to (2) edit changes into the original sources (which they also want to do some other times). So the proposal was to leave C-x C-q to change read-only to cover the first case and to use "e" to enter the "writable" modes in all three cases and for the second case. C-x C-q in dired was fine to leave to enter wdired since (1) it already does that and (2) people don't edit the output there much. I'm all for using remap instead of hard coding a binding to C-x C-q, but I wanted to make sure these changes considered those use cases. -- Howard
bug-gnu-emacs@HIDDEN:bug#75530; Package emacs.
Full text available.Received: (at 75530) by debbugs.gnu.org; 3 Feb 2025 00:15:20 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 02 19:15:20 2025 Received: from localhost ([127.0.0.1]:36811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tek7T-0001nY-QC for submit <at> debbugs.gnu.org; Sun, 02 Feb 2025 19:15:20 -0500 Received: from out-188.mta1.migadu.com ([2001:41d0:203:375::bc]:15192) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <liam@HIDDEN>) id 1tek7R-0001hc-K8 for 75530 <at> debbugs.gnu.org; Sun, 02 Feb 2025 19:15:18 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpfr.net; s=key1; t=1738541710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=elHElgTngLEhGhCkTgyWhZDzBFH6rHazl7Pcjm2IsYI=; b=FlhA9WDwq4sQWXMdjcStLutoq9wT7vclqLPVKho+HMtitWTVuZ5dWOVYqUskD8mflQ0phn 3443Ku2gqx6im6ltYV8y99KX3tIrO3Dgee/UY9IVKsWOvG3E4LERflFWKRKovWE/73+sej lemaEZoVFGuZokdB9/naaweH7sldSfnmeop629Bo3bDAtyz9S5zI4+/zZnXn0GwfmeOTfe AU2GFrUPtXOkIFNSALJ9oiH4MAmNmjTb3xcBoBKa7cEhdrmj8CkK+sFA0VQ26gAeESNoPm 1vLIQBeNt1Lzm9F6TwdCemcdMrOwKlVyC4R81NT3GO+iGS+s6lUVSpmvZkp7aw== From: Liam Hupfer <liam@HIDDEN> To: 75530 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN> Subject: [PATCH v2 3/3] Remap read-only-mode for Grep Edit (bug#75530) Date: Sun, 2 Feb 2025 18:12:47 -0600 Message-ID: <4e534f93e782147080077526e90268d8b6bcb25d.1738541428.git.liam@HIDDEN> In-Reply-To: <cover.1738541428.git.liam@HIDDEN> References: <cover.1736729460.git.liam@HIDDEN> <cover.1738541428.git.liam@HIDDEN> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 75530 Cc: Liam Hupfer <liam@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Like Dired and Occur, Grep buffers now remap read-only-mode to a useful editing mode. * lisp/progmodes/grep.el (grep-mode-map): Remap read-only-mode to grep-change-to-grep-edit-mode. (grep-edit-mode-map): Remap read-only-mode to grep-edit-save-changes. * etc/NEWS (Grep): Document remaps. --- etc/NEWS | 9 +++++---- lisp/progmodes/grep.el | 6 ++++-- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index f25e8b2fe87..2e3c60799de 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -902,10 +902,11 @@ regardless of 'read-only-mode' bindings. +++ *** Grep results can be edited to reflect changes in the originating file. -Like Occur Edit mode, typing 'e' in the "*grep*" buffer will now make -the 'grep' results editable. The edits will be reflected in the buffer -visiting the originating file. Typing 'C-c C-c' will leave the Grep -Edit mode. +Like Occur Edit mode, typing 'e' or 'C-x C-q' (or your own +'read-only-mode' binding) in the "*grep*" buffer will now make the +'grep' results editable. The edits will be reflected in the buffer +visiting the originating file. Typing 'C-c C-c' or 'C-x C-q' (or your +own 'read-only-mode' binding) will leave the Grep Edit mode. ** TeX modes diff --git a/lisp/progmodes/grep.el b/lisp/progmodes/grep.el index d04e9945b0d..b29f56c9ed4 100644 --- a/lisp/progmodes/grep.el +++ b/lisp/progmodes/grep.el @@ -312,7 +312,8 @@ This keymap inherits from `compilation-minor-mode-map'." "TAB" #'compilation-next-error "<backtab>" #'compilation-previous-error - "e" #'grep-change-to-grep-edit-mode) + "e" #'grep-change-to-grep-edit-mode + "<remap> <read-only-mode>" #'grep-change-to-grep-edit-mode) (easy-menu-define grep-menu-map grep-mode-map "Menu for grep buffers." @@ -1083,7 +1084,8 @@ list is empty)." (defvar-keymap grep-edit-mode-map :doc "Keymap for `grep-edit-mode'." :parent text-mode-map - "C-c C-c" #'grep-edit-save-changes) + "C-c C-c" #'grep-edit-save-changes + "<remap> <read-only-mode>" #'grep-edit-save-changes) (defvar grep-edit-mode-hook nil "Hooks run when changing to Grep-Edit mode.") -- 2.47.1
bug-gnu-emacs@HIDDEN:bug#75530; Package emacs.
Full text available.
Received: (at 75530) by debbugs.gnu.org; 3 Feb 2025 00:15:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 02 19:15:13 2025
Received: from localhost ([127.0.0.1]:36804 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tek7N-0001ii-6o
for submit <at> debbugs.gnu.org; Sun, 02 Feb 2025 19:15:13 -0500
Received: from out-178.mta0.migadu.com ([91.218.175.178]:37284)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <liam@HIDDEN>) id 1tek7L-0001h4-1B
for 75530 <at> debbugs.gnu.org; Sun, 02 Feb 2025 19:15:11 -0500
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpfr.net; s=key1;
t=1738541701;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=Q0BdfiBUyP5ulkSaGITD3F74vHL3oETLoZzimyQGhp0=;
b=oPFzp02wldz0O89g9w9yW46jckmdpU6uMGnybT1vHy7q5mvrClZN/fUrvtH7klrRQgdI3p
o8WoYT8pBpDcrGrW6VUNsa9IzoYLgQfOfCxoSbcGdj9BWsmtxjr7SXl7MOwO3cpMabojYr
AeIMSBZztu0ykU3FbTTa+WSNxmV1bc+XSdCv7uZHPkix34t+hkeQVJwfw3Q+ALb70P3xS8
pNsTTw7gu7b/+gsuUwxBmLtc/OhDrGzVownmGweCL2w4fqP5ev4iGVQgP/qhVyoWhuWlN/
/mBC/OOTYVomeiJYI8JR7Ta1zPqZ4ZAwGPlWBXs/Ygv5w2L4epF82qQUyME1yA==
From: Liam Hupfer <liam@HIDDEN>
To: 75530 <at> debbugs.gnu.org,
Eli Zaretskii <eliz@HIDDEN>
Subject: [PATCH v2 2/3] Remap read-only-mode for Occur modes (bug#75530)
Date: Sun, 2 Feb 2025 18:12:46 -0600
Message-ID: <608c43362c724d3ca48d234cac46c23f81020ae6.1738541428.git.liam@HIDDEN>
In-Reply-To: <cover.1738541428.git.liam@HIDDEN>
References: <cover.1736729460.git.liam@HIDDEN>
<cover.1738541428.git.liam@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Migadu-Flow: FLOW_OUT
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 75530
Cc: Liam Hupfer <liam@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
occur-edit-mode behaves similarly to wdired-mode. Dired remaps
read-only-mode to toggle wdired, so set up similar remaps for
occur-mode-map and occur-edit-mode-map.
* lisp/replace.el (occur-mode-map): Remap read-only-mode to
occur-edit-mode.
(occur-edit-mode-map): Remap read-only-mode to occur-cease-edit.
* etc/NEWS (Occur mode): Document Occur Edit entry/exit remaps.
---
etc/NEWS | 8 ++++++++
lisp/replace.el | 2 ++
2 files changed, 10 insertions(+)
diff --git a/etc/NEWS b/etc/NEWS
index 188aaaf6e5b..f25e8b2fe87 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -1058,6 +1058,14 @@ destination window is chosen using 'display-buffer-alist'. Example:
display-buffer-use-some-window)
(some-window . mru))))
+** Occur mode
+
+---
+*** New Occur Edit entry and exit based on 'read-only-mode' bindings.
+In addition to entering 'occur-edit-mode' with 'e' and exiting with 'C-c
+C-c', you can now use 'C-x C-q' (or anywhere you bind 'read-only-mode')
+for entry and exit.
+
* New Modes and Packages in Emacs 31.1
diff --git a/lisp/replace.el b/lisp/replace.el
index 3bd803ce347..724e54f256b 100644
--- a/lisp/replace.el
+++ b/lisp/replace.el
@@ -1304,6 +1304,7 @@ a previously found match."
(define-key map [mouse-2] 'occur-mode-mouse-goto)
(define-key map "\C-c\C-c" 'occur-mode-goto-occurrence)
(define-key map "e" 'occur-edit-mode)
+ (define-key map [remap read-only-mode] 'occur-edit-mode)
(define-key map "\C-m" 'occur-mode-goto-occurrence)
(define-key map "o" 'occur-mode-goto-occurrence-other-window)
(define-key map "\C-o" 'occur-mode-display-occurrence)
@@ -1366,6 +1367,7 @@ Alternatively, click \\[occur-mode-mouse-goto] on an item to go to it.
(set-keymap-parent map text-mode-map)
(define-key map [mouse-2] 'occur-mode-mouse-goto)
(define-key map "\C-c\C-c" 'occur-cease-edit)
+ (define-key map [remap read-only-mode] 'occur-cease-edit)
(define-key map "\C-o" 'occur-mode-display-occurrence)
(define-key map "\C-c\C-f" 'next-error-follow-minor-mode)
(define-key map [menu-bar occur] (cons "Occur" occur-menu-map))
--
2.47.1
bug-gnu-emacs@HIDDEN:bug#75530; Package emacs.
Full text available.Received: (at 75530) by debbugs.gnu.org; 3 Feb 2025 00:15:08 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 02 19:15:08 2025 Received: from localhost ([127.0.0.1]:36800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tek7H-0001hC-Ox for submit <at> debbugs.gnu.org; Sun, 02 Feb 2025 19:15:08 -0500 Received: from out-170.mta0.migadu.com ([91.218.175.170]:27051) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <liam@HIDDEN>) id 1tek7F-0001gI-41 for 75530 <at> debbugs.gnu.org; Sun, 02 Feb 2025 19:15:05 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpfr.net; s=key1; t=1738541693; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ShEmeFwPiNSLtsy5wJkj/IM520vi5I5wXDGABo1VXLw=; b=lmc4MUqQq1WPi8Ud5K4WnQjQRGtHY0P4m2PQQd0ITqC8z3BcbnCK9dZYiQW9jQHkcmcQUO NbXnlhUdGzCzrtD7t+AQu0G6cFvq6DiwOorOPz49yl5iqAmvYcNyRhnkuIW/rW5DpFDnKM 8+fq0YBukUjbHoolEVHmED12AnfelsJIgeWMXuCFMUq0PHBx/FxBv1hNH6Wp7sr4qxForf YdShDR0VLOzOAj8wXEeXr5we7Tn6I0UG2dMulaLhwcBYyfnnEh2JZrSgsZRQ67z03ygrIH R3dWvc3cNOe4OHHfYpwb7JtTI6UYQKKL0WO1ZXTa6AKIsUvbS77eG6PUn0TgDA== From: Liam Hupfer <liam@HIDDEN> To: 75530 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN> Subject: [PATCH v2 1/3] Remap read-only-mode in wdired-mode-map (bug#75530) Date: Sun, 2 Feb 2025 18:12:45 -0600 Message-ID: <ee9a70507936c32c072c53c0372e4d3af5114689.1738541428.git.liam@HIDDEN> In-Reply-To: <cover.1738541428.git.liam@HIDDEN> References: <cover.1736729460.git.liam@HIDDEN> <cover.1738541428.git.liam@HIDDEN> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75530 Cc: Liam Hupfer <liam@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) dired-mode-map already remaps read-only-mode to dired-toggle-read-only. Make wdired-mode-map remap as well, instead of hardcoding the default C-x C-q. * lisp/wdired.el (wdired-mode-map): Remap read-only-mode to wdired-exit. * etc/NEWS (Dired): Document remap. --- etc/NEWS | 6 ++++++ lisp/wdired.el | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/etc/NEWS b/etc/NEWS index 259b6e03549..188aaaf6e5b 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -892,6 +892,12 @@ Without 'dired-hide-details-hide-absolute-location': When 'dired-make-directory-clickable' is non-nil, clicking on the base name of the directory now reverts the Dired buffer. +--- +*** 'wdired-exit' binding now respects user 'read-only-mode' bindings. +If you add or change bindings for 'read-only-mode', 'wdired-exit' will +respect those bindings. Previously, it used a fixed 'C-x C-q' binding +regardless of 'read-only-mode' bindings. + ** Grep +++ diff --git a/lisp/wdired.el b/lisp/wdired.el index c7409446b19..78d0c7e0716 100644 --- a/lisp/wdired.el +++ b/lisp/wdired.el @@ -160,7 +160,7 @@ nonexistent directory will fail." "C-c C-c" #'wdired-finish-edit "C-c C-k" #'wdired-abort-changes "C-c C-[" #'wdired-abort-changes - "C-x C-q" #'wdired-exit + "<remap> <read-only-mode>" #'wdired-exit "RET" #'undefined "C-j" #'undefined "C-o" #'undefined -- 2.47.1
bug-gnu-emacs@HIDDEN:bug#75530; Package emacs.
Full text available.Received: (at 75530) by debbugs.gnu.org; 3 Feb 2025 00:13:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 02 19:13:39 2025 Received: from localhost ([127.0.0.1]:36795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tek5r-0001dr-5a for submit <at> debbugs.gnu.org; Sun, 02 Feb 2025 19:13:39 -0500 Received: from out-179.mta0.migadu.com ([91.218.175.179]:16733) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <liam@HIDDEN>) id 1tek5p-0001da-1a for 75530 <at> debbugs.gnu.org; Sun, 02 Feb 2025 19:13:37 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpfr.net; s=key1; t=1738541606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EAHZhZXBlyeXoFw9AKKot+3uqAVFtukPS8MebrEDRko=; b=mwtHmWowAsLeEEMM6Eilww6AkCGcGRuoD0Dxm87HFPknc4gwdBNfEli3z9eNFF5NbPg1JS IZEsEZa5EW6s/sNhMvcQrwZwHUcWp6Nn1AYwrh6wb00PvTLxitS9izVBrgeSHwyMwjkB/c XHPkOABQttscYvpKxp4IfrMWHccmeo+A2D7AJL7UnL81Prxmnw4OueU9ha9e8E2DNeTNgH WOFZu5ffTFfVtO1ZB9MqYkOnErj9A3CpkaGfDqWLUN/dCzo0rD/LwXG3iQ6MJ/tJluNZu7 sIOtDjdt8RWWphkMT/h92pozEHDpjqG8db9TUsTFWD4wxWVHZsbkHmAkO5Z/5g== From: Liam Hupfer <liam@HIDDEN> To: 75530 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN> Subject: [PATCH v2 0/3] Consistently remap read-only-mode for special edit modes Date: Sun, 2 Feb 2025 18:12:44 -0600 Message-ID: <cover.1738541428.git.liam@HIDDEN> In-Reply-To: <cover.1736729460.git.liam@HIDDEN> References: <cover.1736729460.git.liam@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75530 Cc: Liam Hupfer <liam@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) v2 hopefully addresses Eli’s feedback on v1. Thanks! Liam Hupfer (3): Remap read-only-mode in wdired-mode-map (bug#75530) Remap read-only-mode for Occur modes (bug#75530) Remap read-only-mode for Grep Edit (bug#75530) etc/NEWS | 23 +++++++++++++++++++---- lisp/progmodes/grep.el | 6 ++++-- lisp/replace.el | 2 ++ lisp/wdired.el | 2 +- 4 files changed, 26 insertions(+), 7 deletions(-) base-commit: 669bb2eaf535728c58899ab56f0f7d5bdd3747c0 -- 2.47.1
bug-gnu-emacs@HIDDEN:bug#75530; Package emacs.
Full text available.Received: (at 75530) by debbugs.gnu.org; 2 Feb 2025 20:27:25 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 02 15:27:25 2025 Received: from localhost ([127.0.0.1]:36421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tegYu-0004oF-NY for submit <at> debbugs.gnu.org; Sun, 02 Feb 2025 15:27:24 -0500 Received: from out-180.mta0.migadu.com ([91.218.175.180]:35753) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <liam@HIDDEN>) id 1tegYs-0004ny-Lu for 75530 <at> debbugs.gnu.org; Sun, 02 Feb 2025 15:27:23 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpfr.net; s=key1; t=1738528029; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uPghWINSkGDG1+6T9mkg/5vlzXsT5PdBWdDSaY48kP4=; b=ow8KVurC3dR54zaOEg76RCdGOwf8OeEKjH3q9qWupPEpMmZ4u8q0YAY5JraN/DLaAF2lBl 72Zo90FbnUFTyqepU+SC5HAjNzZaukRx1YZU1LxToocPR/HBF32QIcikCov/i12h7bXEhR acqGeiBipgYmYcpsoL/79fwlMSl0qf4J3UCBgmt1u0z3za789SL04AYzxhfIxGPHFJUdei 7kiX5ia+yJQECANiJwnKAr8D69ookV/EvxVlv/Ge0lBhxNqxggeUChxNaTd/nkAyUpJjv7 jMAaK+MY0/8ZhUC2snTH1ziLLyVbsSdk3OptaygkMpMMH1wtrguGwLUxeIVw/w== From: Liam Hupfer <liam@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#75530: [PATCH 3/3] Remap read-only-mode for Grep Edit In-Reply-To: <86ed0gcevs.fsf@HIDDEN> References: <cover.1736729460.git.liam@HIDDEN> <946f456c4d7b9e8b4db28c5f5c6737b289d14439.1736729460.git.liam@HIDDEN> <868qr8benh.fsf@HIDDEN> <87h65c9mbn.fsf@HIDDEN> <86ed0gcevs.fsf@HIDDEN> Date: Sun, 02 Feb 2025 14:27:03 -0600 Message-ID: <87bjvk3xew.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75530 Cc: 75530 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Eli Zaretskii <eliz@HIDDEN> writes: > Then why does the Grep entry mention =E2=80=9CC-c C-c=E2=80=9D? Isn=E2= =80=99t =E2=80=9CC-x C-q=E2=80=9D no > less important? Good point. I=E2=80=99ll address this and the rest of your feedback (hopefu= lly) in a new revision. Aside: do you always prefer patch series as attachments to a single message rather than threaded messages, or just recommend it to stave off malformed patches from users who don=E2=80=99t use git-send-email? =E2=80=94Liam --=-=-=--
bug-gnu-emacs@HIDDEN:bug#75530; Package emacs.
Full text available.Received: (at 75530) by debbugs.gnu.org; 2 Feb 2025 19:42:42 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 02 14:42:42 2025 Received: from localhost ([127.0.0.1]:36382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tefre-0002ih-8Z for submit <at> debbugs.gnu.org; Sun, 02 Feb 2025 14:42:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57562) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tefrb-0002iR-LI for 75530 <at> debbugs.gnu.org; Sun, 02 Feb 2025 14:42:40 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tefrW-0000dt-9X; Sun, 02 Feb 2025 14:42:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ZgXjNPVF03IBkSDCawE0aXnn9F+gZAtQKbMkgMSzaZs=; b=JOKQLt2pieGGq2oqosLD tzBRypT8EI+tJxZkkDVS0817rVzyUfHCuS/m973QgXLOEYHcZ+W07YeHQVbPQNG/LAiUSnXHVGgHI USU3k5fTik/o0fA666FZ+UiL6iMZYI4+eWKwq9x7XX171JKBCni5GCaMUlOR8CDFYjm9RtWZ3YPON 7qDh7olfbU4wOO5tQhs/KiGEJGQq64q6fFVRYQHLqOpm9r8vmZh0hTPw1iQ4MjNR/m26dWMe8T/ZR xA3nkGm9r/pp0qbk0eNSZDQsD1KHiLEFKslnCd5xWrZbpg7sLOOuPPRfnUD3wmeB2NQdo8CSo67Ee T9LoS3IG1NQptw==; Date: Sun, 02 Feb 2025 21:42:31 +0200 Message-Id: <86ed0gcevs.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Liam Hupfer <liam@HIDDEN> In-Reply-To: <87h65c9mbn.fsf@HIDDEN> (message from Liam Hupfer on Sun, 02 Feb 2025 13:30:04 -0600) Subject: Re: bug#75530: [PATCH 3/3] Remap read-only-mode for Grep Edit References: <cover.1736729460.git.liam@HIDDEN> <946f456c4d7b9e8b4db28c5f5c6737b289d14439.1736729460.git.liam@HIDDEN> <868qr8benh.fsf@HIDDEN> <87h65c9mbn.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75530 Cc: 75530 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Liam Hupfer <liam@HIDDEN> > Cc: 75530 <at> debbugs.gnu.org > Date: Sun, 02 Feb 2025 13:30:04 -0600 > > > Thanks, but why there’s no NEWS entry here? > > >From the cover letter: > > > No entry for Grep Edit since it’s new anyway. But adding to the Grep entry something about this is not out of the question, is it? > I assume the NEWS files are release notes written for users when they > upgrade to a new release. From the perspective of a user switching from > a past release to 31 (after it releases, of course), this tiny binding > change is not noteworthy, since the entire Grep Edit mode is new anyway > and already has a dedicated entry. And anyone living on master can be > expected to understand its volatility and to understand how to browse > commits, no? Otherwise, how is NEWS different from ‘git log’? Then why does the Grep entry mention "C-c C-c"? Isn't "C-x C-q" no less important?
bug-gnu-emacs@HIDDEN:bug#75530; Package emacs.
Full text available.Received: (at 75530) by debbugs.gnu.org; 2 Feb 2025 19:38:27 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 02 14:38:27 2025 Received: from localhost ([127.0.0.1]:36370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tefnW-0002Uy-Kk for submit <at> debbugs.gnu.org; Sun, 02 Feb 2025 14:38:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48608) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tefnU-0002Ui-J8 for 75530 <at> debbugs.gnu.org; Sun, 02 Feb 2025 14:38:24 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tefnO-0000H5-W4; Sun, 02 Feb 2025 14:38:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=/PbrUJC5Eszogqd/nUQ+0ougu1ph71ggXTX0Q4sFx5Q=; b=oGcmthWutV5DnwBdqkeR /eIJveR4ey6YYJJWtbQVt/bpwD4RBFMi07iFSP04MwSxPXGrqOb482CTemxGrjZtYBFWjlFsyFlQY ijLxu6XQf80lio1lPrqkYByemWoXoWq44iyI3z2KHtMT0p6SFNVDYPvHikvzvGvTSLXv0kOvSB+g/ bJhldOo/iYm0P2pwfrYepGO2WvuRP5aA31mk1RDYxty5YDnvi6YHwSpuNNPAKteeZRO81V8LFqc0S cKkQ8FAe+nvjMFgzLBBv1tQYCA8pWfwZ7XRwiqWwiWdhvZcjTCkp2gJuBbDaxw9DoOMp8BPv0XOH9 L2RUNKdXIsNX7g==; Date: Sun, 02 Feb 2025 21:38:16 +0200 Message-Id: <86frkwcf2v.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Liam Hupfer <liam@HIDDEN> In-Reply-To: <87lduo9mom.fsf@HIDDEN> (message from Liam Hupfer on Sun, 02 Feb 2025 13:22:17 -0600) Subject: Re: bug#75530: [PATCH 1/3] Remap read-only-mode in wdired-mode-map References: <cover.1736729460.git.liam@HIDDEN> <2e21e7de8dfcacf6aa5342ae0bfaa0c3087fcd65.1736729460.git.liam@HIDDEN> <86bjw4beux.fsf@HIDDEN> <87lduo9mom.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75530 Cc: 75530 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Liam Hupfer <liam@HIDDEN> > Cc: 75530 <at> debbugs.gnu.org > Date: Sun, 02 Feb 2025 13:22:17 -0600 > > >> +— > >> +*** wdired-exit binding now respects changes to read-only-mode. > >> +Previously ’wdired-mode-map’ bound ’wdired-exit’ to ’C-x C-q’. Now a > >> +remap of ’read-only-mode’ is used. This matches Dired’s > >> +’wdired-change-to-wdired-mode’ binding. > > > > Also, this entry should mention the key bindings explicitly, since > > that is what is being remapped. And the last sentence is not needed, > > since NEWS doesn’t normally need to justify the changes, only to > > describe them. > > Can you give an example of what you expect here? Since the default > ‘read-only-mode’ binding is also C-x C-q, the only user-facing aspect of > this change is the remap itself. Users who don’t change their > ‘read-only-mode’ binding will not notice any difference. Instead of talking about remapping read-only-mode, I'd like NEWS to explain what that means from the user POV. I presume you wanted to allow users bind read-only-mode to something other than "C-x C-q", and have wdired-exit binding to follow suit. This is what the NEWS entry should say. Talking about remapping describes the implementation, not the user-facing changes in behavior. Thanks.
bug-gnu-emacs@HIDDEN:bug#75530; Package emacs.
Full text available.Received: (at 75530) by debbugs.gnu.org; 2 Feb 2025 19:30:20 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 02 14:30:20 2025 Received: from localhost ([127.0.0.1]:36362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1teffg-0002Au-Be for submit <at> debbugs.gnu.org; Sun, 02 Feb 2025 14:30:20 -0500 Received: from out-179.mta0.migadu.com ([2001:41d0:1004:224b::b3]:34605) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <liam@HIDDEN>) id 1teffe-00025Q-DB for 75530 <at> debbugs.gnu.org; Sun, 02 Feb 2025 14:30:19 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpfr.net; s=key1; t=1738524607; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VaebmonLxONUAo3k7k9aN+J9wtdWs1zAy/jamf7hU7s=; b=B4PJsVJh3GEvFv828E7YUVxUla0cAA5sNyhLuQ5tL/NJz30Kdq5OIgdRR+566lV6nGbXWo kDNaaDdbwacbo/VHwwneRPIcDtqFcIeEEE5Evtl1K8ykxzLsDBs+JsvSjYtooTQuyOevHw XawjPGIz5Z44G6IZ1W4DBcyyIFj0daGzMjRj0XW7Jy1kIWrz0vc2ZJGgCL042iptPt9Lu6 E2wsxqDoJ28merQiC1vWTsBBBcLibWvYwmvRluw7K1bE/F64Rr8iADKrMtdXb7LMRVdvC+ C4K3UnSXXAjb14rORQicuE3JlXybWLxqBLCB34mBk8s9bHeMPjHZhigKDfnw4g== From: Liam Hupfer <liam@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#75530: [PATCH 3/3] Remap read-only-mode for Grep Edit In-Reply-To: <868qr8benh.fsf@HIDDEN> References: <cover.1736729460.git.liam@HIDDEN> <946f456c4d7b9e8b4db28c5f5c6737b289d14439.1736729460.git.liam@HIDDEN> <868qr8benh.fsf@HIDDEN> Date: Sun, 02 Feb 2025 13:30:04 -0600 Message-ID: <87h65c9mbn.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 75530 Cc: 75530 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Eli Zaretskii <eliz@HIDDEN> writes: >> Cc: Liam Hupfer <liam@HIDDEN> >> From: Liam Hupfer <liam@HIDDEN> >> Date: Sun, 12 Jan 2025 19:00:36 -0600 >>=20 >> Like Dired and Occur, writable Grep buffers can now remap read-only-mode >> to a useful editing mode. > > Thanks, but why there=E2=80=99s no NEWS entry here? From the cover letter: > No entry for Grep Edit since it=E2=80=99s new anyway. I assume the NEWS files are release notes written for users when they upgrade to a new release. From the perspective of a user switching from a past release to 31 (after it releases, of course), this tiny binding change is not noteworthy, since the entire Grep Edit mode is new anyway and already has a dedicated entry. And anyone living on master can be expected to understand its volatility and to understand how to browse commits, no? Otherwise, how is NEWS different from =E2=80=98git log=E2=80= =99? Thanks! =E2=80=94Liam --=-=-=--
bug-gnu-emacs@HIDDEN:bug#75530; Package emacs.
Full text available.Received: (at 75530) by debbugs.gnu.org; 2 Feb 2025 19:22:37 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 02 14:22:37 2025 Received: from localhost ([127.0.0.1]:36344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tefYD-0001jf-1C for submit <at> debbugs.gnu.org; Sun, 02 Feb 2025 14:22:37 -0500 Received: from out-189.mta0.migadu.com ([2001:41d0:1004:224b::bd]:18174) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <liam@HIDDEN>) id 1tefYA-0001jM-Cn for 75530 <at> debbugs.gnu.org; Sun, 02 Feb 2025 14:22:35 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpfr.net; s=key1; t=1738524143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zxdXWSG+ijPpyrPYc8OLfAgZk2PTgkxP7wArgDGS9b0=; b=prVLXeiWTe7lHvJp4CA3l2YHQXj6Aey6uH7LLJIsrJjQr8F7YZdZ5gmEDdzXsh2jA1VZ7S 9NcLyqUZoKwTuKBeVR8mUHw6+GiQDTrx0hfFPXJ8FqiNgFp1o18UV2/Xqjl+IksQvN1tjJ KJGM7H/dtYTBflFLrvZoadNDKYEI5h+xkmQ31gcnQq1fjf43vMcbaKsc/kknZrcFvCkbIg s6Qjqn4TOzNn/Up08YnxtjWTBggNYfbeccC9a6Q/LOimrQzevRmNmYVyhItkOoSLf6DZtr eDg2665a48NzlBMX/yobzTN3Z1TR3Am8NGN2qc1yiEBO43FSzaBjYFKBuTv1jA== From: Liam Hupfer <liam@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#75530: [PATCH 1/3] Remap read-only-mode in wdired-mode-map In-Reply-To: <86bjw4beux.fsf@HIDDEN> References: <cover.1736729460.git.liam@HIDDEN> <2e21e7de8dfcacf6aa5342ae0bfaa0c3087fcd65.1736729460.git.liam@HIDDEN> <86bjw4beux.fsf@HIDDEN> Date: Sun, 02 Feb 2025 13:22:17 -0600 Message-ID: <87lduo9mom.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 75530 Cc: 75530 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Thanks for the review Eli! Eli Zaretskii <eliz@HIDDEN> writes: >> diff =E2=80=93git a/etc/NEWS b/etc/NEWS >> index d017c872fa3..220730c2cc0 100644 >> =E2=80=94 a/etc/NEWS >> +++ b/etc/NEWS >> @@ -785,6 +785,12 @@ Without =E2=80=99dired-hide-details-hide-absolute-l= ocation=E2=80=99: >> When =E2=80=99dired-make-directory-clickable=E2=80=99 is non-nil, click= ing on the base >> name of the directory now reverts the Dired buffer. >>=20=20 >> +=E2=80=94 >> +*** wdired-exit binding now respects changes to read-only-mode. >> +Previously =E2=80=99wdired-mode-map=E2=80=99 bound =E2=80=99wdired-exit= =E2=80=99 to =E2=80=99C-x C-q=E2=80=99. Now a >> +remap of =E2=80=99read-only-mode=E2=80=99 is used. This matches Dired= =E2=80=99s >> +=E2=80=99wdired-change-to-wdired-mode=E2=80=99 binding. > > Also, this entry should mention the key bindings explicitly, since > that is what is being remapped. And the last sentence is not needed, > since NEWS doesn=E2=80=99t normally need to justify the changes, only to > describe them. Can you give an example of what you expect here? Since the default =E2=80=98read-only-mode=E2=80=99 binding is also C-x C-q, the only user-fac= ing aspect of this change is the remap itself. Users who don=E2=80=99t change their =E2=80=98read-only-mode=E2=80=99 binding will not notice any difference. =E2=80=94Liam --=-=-=--
bug-gnu-emacs@HIDDEN:bug#75530; Package emacs.
Full text available.Received: (at 75530) by debbugs.gnu.org; 18 Jan 2025 10:27:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 18 05:27:46 2025 Received: from localhost ([127.0.0.1]:40320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tZ63O-0007Oi-MM for submit <at> debbugs.gnu.org; Sat, 18 Jan 2025 05:27:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58060) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tZ63M-0007OQ-0y for 75530 <at> debbugs.gnu.org; Sat, 18 Jan 2025 05:27:44 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tZ63G-0001vz-I2; Sat, 18 Jan 2025 05:27:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jnroWs2NQBJchG5cUYhsjsqP2ZHEniVlhtCeEdt2/mM=; b=KWBqRNRujxlw +olG597MlAfl0ewJ+d1qngH76LU0Oc0e/4fBmFP068GGTonxcKBesB6xnX/G62Azbt6iqwh6wm83C T6I/obnXVeVf57jMPr88VDfkpnO8Hym+VCgBc1dHsUdA9ih7zo2EAt83/nHDXFrAUGhjKBHwPpLoL TlRyhFb+2muZH+4RlIwbc8bwJZ0kKKOSTw4VMJ5kHvp19IWeHR6Ec9tJUnQFeLucPbBPhoOv/wlx0 z7BfRQHddgZHFMGqq+0LCUXcSXqEYs+qe0QAaN+TnLqeezUqZ7w4g+A527Ao8ckMnnrO8Wzt9/GOT lV2/jD0Os9I34AX5vaYgHQ==; Date: Sat, 18 Jan 2025 12:27:30 +0200 Message-Id: <868qr8benh.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Liam Hupfer <liam@HIDDEN> In-Reply-To: <946f456c4d7b9e8b4db28c5f5c6737b289d14439.1736729460.git.liam@HIDDEN> (message from Liam Hupfer on Sun, 12 Jan 2025 19:00:36 -0600) Subject: Re: bug#75530: [PATCH 3/3] Remap read-only-mode for Grep Edit References: <cover.1736729460.git.liam@HIDDEN> <946f456c4d7b9e8b4db28c5f5c6737b289d14439.1736729460.git.liam@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75530 Cc: 75530 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: Liam Hupfer <liam@HIDDEN> > From: Liam Hupfer <liam@HIDDEN> > Date: Sun, 12 Jan 2025 19:00:36 -0600 > > Like Dired and Occur, writable Grep buffers can now remap read-only-mode > to a useful editing mode. Thanks, but why there's no NEWS entry here?
bug-gnu-emacs@HIDDEN:bug#75530; Package emacs.
Full text available.Received: (at 75530) by debbugs.gnu.org; 18 Jan 2025 10:26:45 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 18 05:26:45 2025 Received: from localhost ([127.0.0.1]:40314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tZ62P-0007MQ-4f for submit <at> debbugs.gnu.org; Sat, 18 Jan 2025 05:26:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41730) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tZ62N-0007MC-6C for 75530 <at> debbugs.gnu.org; Sat, 18 Jan 2025 05:26:43 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tZ62H-0001jv-LM; Sat, 18 Jan 2025 05:26:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RJ+3UFJggoco8fuZrY81fzl/0LeMFTzoqJagdd3lxmI=; b=DbBJWYqPZ9zc E8Bsx6n8O777lX2h6uyoDrhX6zErF9B6EZNrI/7ShqaSwCRsk8y1I+kGSAOFyePVVXRnenqUL71rn vpnXyWF356ItQTnfBZm7+zpeG+ipMAVB0r6QFh74NggdO/KCoe03T9+I5jGmPosC2++X5eg9ToOmg rRlc9Ggo/wfIRrT+NhfguK0ZgkXkE/d7t8UkgA0sWTHrJpzdV/fChvY/+vkmUW9HyJyJsm+w657ES TZC9s2DG2/dKBrjiKP3uuQA+yZY4wPFECCt7QCHhY/IRJIq2A3BAw/Y5C54etGxe9FkzCqXeoZ5Im pIYAg6zHqLR41l5aurAiMg==; Date: Sat, 18 Jan 2025 12:26:34 +0200 Message-Id: <86a5bobep1.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Liam Hupfer <liam@HIDDEN> In-Reply-To: <96e7f13d2faff513d00bef6ecaa13e0f657fdd94.1736729460.git.liam@HIDDEN> (message from Liam Hupfer on Sun, 12 Jan 2025 19:00:35 -0600) Subject: Re: bug#75530: [PATCH 2/3] Remap read-only-mode for Occur modes References: <cover.1736729460.git.liam@HIDDEN> <96e7f13d2faff513d00bef6ecaa13e0f657fdd94.1736729460.git.liam@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75530 Cc: 75530 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: Liam Hupfer <liam@HIDDEN> > From: Liam Hupfer <liam@HIDDEN> > Date: Sun, 12 Jan 2025 19:00:35 -0600 > > +** Occur mode > + > +--- > +*** Occur Edit entry and exit points remap 'read-only-mode'. > +Like Wdired, 'read-only-mode' is remapped in 'occur-mode-map' and > +'occur-edit-mode-map' to enter and exit 'occur-edit-mode', respectively. Please make this description stand-alone, without referring to Wdired. People frequently read only the parts of NEWS that are of interest to them. And the same comments as for the previous patch: the NEWS entry should explain the change in terms of key bindings, not in technical terms of remapping, since this is a user-level change. Thanks.
bug-gnu-emacs@HIDDEN:bug#75530; Package emacs.
Full text available.Received: (at 75530) by debbugs.gnu.org; 18 Jan 2025 10:23:31 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 18 05:23:31 2025 Received: from localhost ([127.0.0.1]:40306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tZ5zH-0007Av-1f for submit <at> debbugs.gnu.org; Sat, 18 Jan 2025 05:23:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35982) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tZ5zF-0007Ah-0D for 75530 <at> debbugs.gnu.org; Sat, 18 Jan 2025 05:23:29 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tZ5z8-0001RB-7R; Sat, 18 Jan 2025 05:23:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Prw1ZBkTLSJ9uqLyV00Fp5lQhlVVCegkTpmbjm1W0Jk=; b=g7mhBpmSGPrF s5+Y66snc+tMSNFK+l0i1M6l0kj/7K1jUBnh5kPhQWEgw0V+rzx0XwpzjUAIOtuF29HtaIhIPneP0 ysCKXkf8QI0Z9GcXq7oBO8BnY5clbpbSRQ5b4htqqKUXbt0GBKPYLxnycUCcPwXIHBtG2OmSuv5Ty fRqKRPYEL2/fEm7sOgvt73b7fRFNZgIpGO3Z/BkHnJknrEVgwlEq0gP1SoMTRtFy/EtZ38DFseWIG MnKUc46CpQamJLbe4GhCEYDGwXOVnt/hR+8bXu1qrMEMf6hNZGe2OOJ5UBXYKO01jieJa7+GkHyBU 84fiDY9gy89p6vQXs48OZw==; Date: Sat, 18 Jan 2025 12:23:02 +0200 Message-Id: <86bjw4beux.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Liam Hupfer <liam@HIDDEN> In-Reply-To: <2e21e7de8dfcacf6aa5342ae0bfaa0c3087fcd65.1736729460.git.liam@HIDDEN> (message from Liam Hupfer on Sun, 12 Jan 2025 19:00:34 -0600) Subject: Re: bug#75530: [PATCH 1/3] Remap read-only-mode in wdired-mode-map References: <cover.1736729460.git.liam@HIDDEN> <2e21e7de8dfcacf6aa5342ae0bfaa0c3087fcd65.1736729460.git.liam@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75530 Cc: 75530 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: Liam Hupfer <liam@HIDDEN> > From: Liam Hupfer <liam@HIDDEN> > Date: Sun, 12 Jan 2025 19:00:34 -0600 > > dired-mode-map already remaps read-only-mode to dired-toggle-read-only. > Make wdired-mode-map remap as well, instead of hardcoding the default > C-x C-q. Thanks. > * lisp/wdired.el (wdired-mode-map): Remap read-only-mode to wdired-exit. > * etc/NEWS (Dired): Document remap. > --- > etc/NEWS | 6 ++++++ > lisp/wdired.el | 2 +- > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/etc/NEWS b/etc/NEWS > index d017c872fa3..220730c2cc0 100644 > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -785,6 +785,12 @@ Without 'dired-hide-details-hide-absolute-location': > When 'dired-make-directory-clickable' is non-nil, clicking on the base > name of the directory now reverts the Dired buffer. > > +--- > +*** wdired-exit binding now respects changes to read-only-mode. > +Previously 'wdired-mode-map' bound 'wdired-exit' to 'C-x C-q'. Now a > +remap of 'read-only-mode' is used. This matches Dired's > +'wdired-change-to-wdired-mode' binding. Please leave two spaces between sentences, per our conventions. Also, this entry should mention the key bindings explicitly, since that is what is being remapped. And the last sentence is not needed, since NEWS doesn't normally need to justify the changes, only to describe them. P.S. When you submit modified patches, please mention the bug number in the commit log message.
bug-gnu-emacs@HIDDEN:bug#75530; Package emacs.
Full text available.Received: (at 75530) by debbugs.gnu.org; 15 Jan 2025 07:29:17 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 15 02:29:17 2025 Received: from localhost ([127.0.0.1]:56812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tXxq1-0005W1-Da for submit <at> debbugs.gnu.org; Wed, 15 Jan 2025 02:29:17 -0500 Received: from mail.elken.dev ([165.22.120.78]:36653) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <me@HIDDEN>) id 1tXxpy-0005Vn-1n for 75530 <at> debbugs.gnu.org; Wed, 15 Jan 2025 02:29:15 -0500 Received: from authenticated-user (mail.elken.dev [165.22.120.78]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by mail.elken.dev (Postfix) with ESMTPSA id 7EBBA4632D for <75530 <at> debbugs.gnu.org>; Wed, 15 Jan 2025 08:29:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=elken.dev; s=mail; t=1736926147; bh=WpBAXT431kB4HRwWS2FiyICzpd/sXdZ87HUdQEblLrQ=; h=Date:From:To:Subject:From; b=ScG+bCdwl3n4PjUEKogn1wT79WdFURasW2QaB2VgZ8Sbo1gY2zDdgnuOsIIG7WCY4 AXLn1XB1wHW7EcONe/UVjSpYJC0K6VI8G+Ml8pNlLSHLrk0CGUFuhm5ZPokPIG45Lg j/av9nYf2wCcccA1tN+zYyQI4fAuh2A5p6bbyW9wqWgkJ5j77rrDaHzQPBfCXPxZOq lIzqeX8FyH4HNKpEylFKuNrsmQ01cXQIvufNmu+aI8G/aFRjOhGhN5bcnNtZ803Wv7 t57WLiDzo52/SVf5poq1qoMEakXaD6IR3RsLOocMuTh5Ipj1ncO0LmByAfbUyNOx/+ O0i5MEKvOGhUA== MIME-Version: 1.0 Date: Wed, 15 Jan 2025 07:29:07 +0000 From: me@HIDDEN To: 75530 <at> debbugs.gnu.org Subject: liam@HIDDEN Message-ID: <569a93eed4be645b7afd020b09953caa@HIDDEN> X-Sender: me@HIDDEN Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75530 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) This looks great! Would be really sweet to get this one merged.
bug-gnu-emacs@HIDDEN:bug#75530; Package emacs.
Full text available.Received: (at 75530) by debbugs.gnu.org; 13 Jan 2025 01:01:32 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 12 20:01:32 2025 Received: from localhost ([127.0.0.1]:49595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tX8pf-0003ou-OG for submit <at> debbugs.gnu.org; Sun, 12 Jan 2025 20:01:32 -0500 Received: from out-182.mta0.migadu.com ([91.218.175.182]:13343) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <liam@HIDDEN>) id 1tX8pd-0003oY-5h for 75530 <at> debbugs.gnu.org; Sun, 12 Jan 2025 20:01:29 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpfr.net; s=key1; t=1736730081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yelekuqlg+ORB2KHnCYQlSzz8ivw6L+2/VngXurThtk=; b=ij6wxFiDpschxCfJyTJZqCEK9eieuxtacB9XfJqGfF3X0WaVtxxRpFv0mxgVZPCtsyeQCo PDZEHRGzK2PMHiwaMxq6FgL7Suc8k3cw7oU7dndc356LE+nFRNEchbnPQtQNUCccwf9gPD bDqM1lM5WFhqm2rwlkI+JIU/l/vgYPdea8OHSvAp6m/vE9WCUTyWq/P7P0awy0i24I36ZR xXq6onIOgUMKhkr2YYz4fGpH37xUlpDEIVRiTvM1t7jYnE71mC0oPwy9uRvho6WRrNwf8f tiuyenO54o8xCJmdsCOJlA/mPnPRJUrEQf3QJ3VwX32+nGSZQ7f9/SY+YozLAg== From: Liam Hupfer <liam@HIDDEN> To: 75530 <at> debbugs.gnu.org Subject: [PATCH 3/3] Remap read-only-mode for Grep Edit Date: Sun, 12 Jan 2025 19:00:36 -0600 Message-ID: <946f456c4d7b9e8b4db28c5f5c6737b289d14439.1736729460.git.liam@HIDDEN> In-Reply-To: <cover.1736729460.git.liam@HIDDEN> References: <cover.1736729460.git.liam@HIDDEN> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75530 Cc: Liam Hupfer <liam@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Like Dired and Occur, writable Grep buffers can now remap read-only-mode to a useful editing mode. * lisp/progmodes/grep.el (grep-mode-map): Remap read-only-mode to grep-change-to-grep-edit-mode. (grep-edit-mode-map): Remap read-only-mode to grep-edit-save-changes. --- lisp/progmodes/grep.el | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lisp/progmodes/grep.el b/lisp/progmodes/grep.el index 72c0f871e0b..c1d626016b0 100644 --- a/lisp/progmodes/grep.el +++ b/lisp/progmodes/grep.el @@ -312,7 +312,8 @@ grep-mode-map "TAB" #'compilation-next-error "<backtab>" #'compilation-previous-error - "e" #'grep-change-to-grep-edit-mode) + "e" #'grep-change-to-grep-edit-mode + "<remap> <read-only-mode>" #'grep-change-to-grep-edit-mode) (easy-menu-define grep-menu-map grep-mode-map "Menu for grep buffers." @@ -1083,7 +1084,8 @@ grep-edit--prepare-buffer (defvar-keymap grep-edit-mode-map :doc "Keymap for `grep-edit-mode'." :parent text-mode-map - "C-c C-c" #'grep-edit-save-changes) + "C-c C-c" #'grep-edit-save-changes + "<remap> <read-only-mode>" #'grep-edit-save-changes) (defvar grep-edit-mode-hook nil "Hooks run when changing to Grep-Edit mode.") -- 2.47.1
bug-gnu-emacs@HIDDEN:bug#75530; Package emacs.
Full text available.
Received: (at 75530) by debbugs.gnu.org; 13 Jan 2025 01:01:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 12 20:01:24 2025
Received: from localhost ([127.0.0.1]:49591 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tX8pY-0003oa-8b
for submit <at> debbugs.gnu.org; Sun, 12 Jan 2025 20:01:24 -0500
Received: from out-174.mta0.migadu.com ([2001:41d0:1004:224b::ae]:15597)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <liam@HIDDEN>) id 1tX8pV-0003oJ-Mx
for 75530 <at> debbugs.gnu.org; Sun, 12 Jan 2025 20:01:22 -0500
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpfr.net; s=key1;
t=1736730068;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=Pgd4HWwKqDQUfk52rbUG2uDhuojWrZdj++I0FQJU4CM=;
b=mV9wRriZlIHHM2ssA+MmAeAl1RwQq5lCExNG/e3kg+6b+5ciDZ6YgcX5yPQ0rEvt0WdwcK
x+dqSbJkcZtsIEeENmOztSkfI1RHk4c/Gj0dSOgVTrMquv8LqnLIRu1EhVLu6OfZ4iKCXG
1P8SrgxPEGCw57eHkAKJbX6tTMui8kIaE8bi65BCA0j++C8q6zTl5mvOPnoczMIOp9d/v2
aTRxvbjaV5DXExAZCxGOt38l77S27F62VsAvV5xyOCVYWVjItlU316tvzZNxE4lhddtAtz
ktLkprq/3bb99TnK/X+yZVQoTPSfbRDlPrP1rd+HgMCbBJCUVjDDZ9Y5UtaRNw==
From: Liam Hupfer <liam@HIDDEN>
To: 75530 <at> debbugs.gnu.org
Subject: [PATCH 2/3] Remap read-only-mode for Occur modes
Date: Sun, 12 Jan 2025 19:00:35 -0600
Message-ID: <96e7f13d2faff513d00bef6ecaa13e0f657fdd94.1736729460.git.liam@HIDDEN>
In-Reply-To: <cover.1736729460.git.liam@HIDDEN>
References: <cover.1736729460.git.liam@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Migadu-Flow: FLOW_OUT
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 75530
Cc: Liam Hupfer <liam@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
occur-edit-mode behaves similarly to wdired-mode. Dired remaps
read-only-mode to toggle wdired, so set up similar remaps for
occur-mode-map and occur-edit-mode-map.
* lisp/replace.el (occur-mode-map): Remap read-only-mode to
occur-edit-mode.
(occur-edit-mode-map): Remap read-only-mode to occur-cease-edit.
* etc/NEWS (Occur mode): Document Occur Edit entry/exit remaps.
---
etc/NEWS | 7 +++++++
lisp/replace.el | 2 ++
2 files changed, 9 insertions(+)
diff --git a/etc/NEWS b/etc/NEWS
index 220730c2cc0..ec9d8b058e1 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -946,6 +946,13 @@ destination window is chosen using 'display-buffer-alist'. Example:
display-buffer-use-some-window)
(some-window . mru))))
+** Occur mode
+
+---
+*** Occur Edit entry and exit points remap 'read-only-mode'.
+Like Wdired, 'read-only-mode' is remapped in 'occur-mode-map' and
+'occur-edit-mode-map' to enter and exit 'occur-edit-mode', respectively.
+
* New Modes and Packages in Emacs 31.1
diff --git a/lisp/replace.el b/lisp/replace.el
index cde3686dd12..4db069a1193 100644
--- a/lisp/replace.el
+++ b/lisp/replace.el
@@ -1304,6 +1304,7 @@ occur-mode-map
(define-key map [mouse-2] 'occur-mode-mouse-goto)
(define-key map "\C-c\C-c" 'occur-mode-goto-occurrence)
(define-key map "e" 'occur-edit-mode)
+ (define-key map [remap read-only-mode] 'occur-edit-mode)
(define-key map "\C-m" 'occur-mode-goto-occurrence)
(define-key map "o" 'occur-mode-goto-occurrence-other-window)
(define-key map "\C-o" 'occur-mode-display-occurrence)
@@ -1366,6 +1367,7 @@ occur-edit-mode-map
(set-keymap-parent map text-mode-map)
(define-key map [mouse-2] 'occur-mode-mouse-goto)
(define-key map "\C-c\C-c" 'occur-cease-edit)
+ (define-key map [remap read-only-mode] 'occur-cease-edit)
(define-key map "\C-o" 'occur-mode-display-occurrence)
(define-key map "\C-c\C-f" 'next-error-follow-minor-mode)
(bindings--define-key map [menu-bar occur] (cons "Occur" occur-menu-map))
--
2.47.1
bug-gnu-emacs@HIDDEN:bug#75530; Package emacs.
Full text available.Received: (at 75530) by debbugs.gnu.org; 13 Jan 2025 01:01:06 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 12 20:01:06 2025 Received: from localhost ([127.0.0.1]:49587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tX8pF-0003o5-OM for submit <at> debbugs.gnu.org; Sun, 12 Jan 2025 20:01:06 -0500 Received: from out-177.mta1.migadu.com ([2001:41d0:203:375::b1]:64484) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <liam@HIDDEN>) id 1tX8pD-0003nP-L5 for 75530 <at> debbugs.gnu.org; Sun, 12 Jan 2025 20:01:04 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpfr.net; s=key1; t=1736730056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NS7tEpBUB32FTKthEBVUYCVeSc5vLd8jFNX35bTx2XE=; b=IIwEKMFjEObgUw2LPfFLb/j8QYUpUzqVx0fIsJ5qCJNwD8PnAVD3vaqhORL+8lVToaeS1K ua+d0cby7r3vEs4Tb73YccTENpUsjAmUB9KAjcqCfVgfEBmWDgN7HuF0EMPUUseEe3u+Sx mNxUTGayklRDxws1iWQPwQrShbDRj1JxWq7wMZ7IQTJ+M030hlBtVXm3GYFJ+Xq7lsUc5J LRRQKuVj35MZh2FrA07pXlTqosou4kkBKkFRWCl5TeiuZKeczIi7SdQX+QLeJrs5Y/jWkL iEVrbrdyZhDtJhiHMgib4byCY8jonR9UV9cutC+nkmUyakgBdNbRmc151O8Fzw== From: Liam Hupfer <liam@HIDDEN> To: 75530 <at> debbugs.gnu.org Subject: [PATCH 1/3] Remap read-only-mode in wdired-mode-map Date: Sun, 12 Jan 2025 19:00:34 -0600 Message-ID: <2e21e7de8dfcacf6aa5342ae0bfaa0c3087fcd65.1736729460.git.liam@HIDDEN> In-Reply-To: <cover.1736729460.git.liam@HIDDEN> References: <cover.1736729460.git.liam@HIDDEN> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 75530 Cc: Liam Hupfer <liam@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) dired-mode-map already remaps read-only-mode to dired-toggle-read-only. Make wdired-mode-map remap as well, instead of hardcoding the default C-x C-q. * lisp/wdired.el (wdired-mode-map): Remap read-only-mode to wdired-exit. * etc/NEWS (Dired): Document remap. --- etc/NEWS | 6 ++++++ lisp/wdired.el | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/etc/NEWS b/etc/NEWS index d017c872fa3..220730c2cc0 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -785,6 +785,12 @@ Without 'dired-hide-details-hide-absolute-location': When 'dired-make-directory-clickable' is non-nil, clicking on the base name of the directory now reverts the Dired buffer. +--- +*** wdired-exit binding now respects changes to read-only-mode. +Previously 'wdired-mode-map' bound 'wdired-exit' to 'C-x C-q'. Now a +remap of 'read-only-mode' is used. This matches Dired's +'wdired-change-to-wdired-mode' binding. + ** Grep +++ diff --git a/lisp/wdired.el b/lisp/wdired.el index c7409446b19..78d0c7e0716 100644 --- a/lisp/wdired.el +++ b/lisp/wdired.el @@ -160,7 +160,7 @@ wdired-mode-map "C-c C-c" #'wdired-finish-edit "C-c C-k" #'wdired-abort-changes "C-c C-[" #'wdired-abort-changes - "C-x C-q" #'wdired-exit + "<remap> <read-only-mode>" #'wdired-exit "RET" #'undefined "C-j" #'undefined "C-o" #'undefined -- 2.47.1
bug-gnu-emacs@HIDDEN:bug#75530; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 13 Jan 2025 00:57:09 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 12 19:57:09 2025 Received: from localhost ([127.0.0.1]:49578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tX8lQ-0003Z8-MI for submit <at> debbugs.gnu.org; Sun, 12 Jan 2025 19:57:09 -0500 Received: from lists.gnu.org ([2001:470:142::17]:54360) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <liam@HIDDEN>) id 1tX8lM-0003YV-Or for submit <at> debbugs.gnu.org; Sun, 12 Jan 2025 19:57:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <liam@HIDDEN>) id 1tX8lG-0001vK-UR for bug-gnu-emacs@HIDDEN; Sun, 12 Jan 2025 19:56:59 -0500 Received: from out-171.mta0.migadu.com ([2001:41d0:1004:224b::ab]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <liam@HIDDEN>) id 1tX8lF-0004Yo-0p for bug-gnu-emacs@HIDDEN; Sun, 12 Jan 2025 19:56:58 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpfr.net; s=key1; t=1736729808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AR/xcO5AV/mScpowmpL9LXVTkLnTOmSs5b+gyfwbiNg=; b=V5Xyo3BykZgWIcfxq9vsrTv/gNjOJ5oIXnJqAVft9UE2mN8LxOmBVweuhr1UjhDJ7+BNEs MGa4fUl4RnHLuXPOSe0m+KPoqphzEg/Zwadc2AkdTeWGFZeoL2lKdUInjruC6eIRTrOmxc wLORvaaAnbT++HzC8B2di6/+zCC2Y58GZ++jZT5oMu5JgW1K0dWwCY69PwWmnU+nhnZ/OX styfJuGARHNc5FS/bORziD91i2cSCmWl/bmXRsprZLkrp8hzqsZo0/nR/drcRcO5d5wI3C b3cwdb7/m0PxfgcmunbgHtSlPIFpf9yWXRv1r/xqexmP9UHY9GO+QCq2E1WfxQ== From: Liam Hupfer <liam@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: [PATCH 0/3] Consistently remap read-only-mode for special edit modes Date: Sun, 12 Jan 2025 18:56:23 -0600 Message-ID: <cover.1736729460.git.liam@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:1004:224b::ab; envelope-from=liam@HIDDEN; helo=out-171.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: Liam Hupfer <liam@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.1 (/) Hi, These patches remap read-only-mode consistently for Dired/Wdired, Occur/Occur Edit, and Grep/Grep Edit. While Dired already has this remap defined, Wdired binds to C-x C-q, meaning users who change their read-only-mode binding get an inconsistent experience. I went ahead and applied the same remap to Occur and Grep, since it seems intuitive for these modes to behave similarly. There are other entry/exit points documented in the relevant manual sections, so I did not change them for now, but let me know what you think. The dedicated bindings for Occur and Grep (e and C-c C-c) are shorter or simpler than the typical read-only-mode binding but aren’t global, so they have to be learned. I stuck with a simple NEWS entry for now. No entry for Grep Edit since it’s new anyway. Thanks! Liam Hupfer (3): Remap read-only-mode in wdired-mode-map Remap read-only-mode for Occur modes Remap read-only-mode for Grep Edit etc/NEWS | 13 +++++++++++++ lisp/progmodes/grep.el | 6 ++++-- lisp/replace.el | 2 ++ lisp/wdired.el | 2 +- 4 files changed, 20 insertions(+), 3 deletions(-) base-commit: 7648faedd3aeabadc66c67630809ef6178f4851a -- 2.47.1
Liam Hupfer <liam@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#75530; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.