GNU bug report logs - #75598
[PATCH] Quote identifiers in SQL queries in sqlite-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75598 in the body.
You can then email your comments to 75598 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: git <at> cy.md
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Quote identifiers in SQL queries in sqlite-mode
Date: Wed, 15 Jan 2025 18:38:51 +0000

[Message part 1 (text/plain, inline)]

Tags: patch


The sqlite-mode package does not quote identifiers (table and column
names) in the SQL queries it performs. As a result, it e.g. cannot open
databases which have a table called "values".

Here is a patch which fixes it for me.

Reference: https://www.sqlite.org/lang_keywords.html

In GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
version 1.18.0, Xaw3d scroll bars)
Windowing system distributor 'The X.Org Foundation', version 11.0.12101015
System Description: Arch Linux

Configured using:
 'configure
 --prefix=/nix/store/mzdvpxzkhlryxmbxwbih7bgvkzkw1ly7-emacs-29.1
 --disable-build-details --with-modules --with-x-toolkit=lucid
 --with-xft --with-cairo --with-compress-install
 --with-toolkit-scroll-bars --with-native-compilation
 --without-imagemagick --without-small-ja-dic --with-tree-sitter
 --with-xinput2 --without-xwidgets'

[0001-Quote-identifiers-in-SQL-queries-in-sqlite-mode.patch (text/patch, attachment)]

Message #12 received at 75598-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: git <at> cy.md
Cc: 75598-done <at> debbugs.gnu.org
Subject: Re: bug#75598: [PATCH] Quote identifiers in SQL queries in sqlite-mode
Date: Sat, 25 Jan 2025 11:16:28 +0200

> Date: Wed, 15 Jan 2025 18:38:51 +0000
> From: git--- via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> The sqlite-mode package does not quote identifiers (table and column
> names) in the SQL queries it performs. As a result, it e.g. cannot open
> databases which have a table called "values".
> 
> Here is a patch which fixes it for me.
> 
> Reference: https://www.sqlite.org/lang_keywords.html

Thanks, installed on the master branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.