GNU bug report logs - #75644
[PATCH] gnu: Add rtorrent-xml-rpc.

Previous Next

To reply to this bug, email your comments to 75644 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Divya Ranjan <divya <at> subvertising.org>
To: guix-patches <at> gnu.org
Cc: Divya Ranjan <divya <at> subvertising.org>
Subject: [PATCH] gnu: Add rtorrent-xml-rpc.
Date: Sat, 18 Jan 2025 08:05:46 +0000

* gnu/packages/bittorrent.scm (rtorrent-xml-rpc): New variable.
---
 gnu/packages/bittorrent.scm | 72 ++++++++++++++++++++++---------------
 1 file changed, 43 insertions(+), 29 deletions(-)

diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm
index 0d52d25e08..1e2e42f064 100644
--- a/gnu/packages/bittorrent.scm
+++ b/gnu/packages/bittorrent.scm
@@ -20,6 +20,7 @@
 ;;; Copyright © 2023 Clément Lassieur <clement <at> lassieur.org>
 ;;; Copyright © 2024 Noisytoot <ron <at> noisytoot.org>
 ;;; Copyright © 2024 Zheng Junjie <873216071 <at> qq.com>
+;;; Copyright © 2025 Divya Ranjan Pattanaik <divya <at> subvertising.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -256,39 +257,52 @@ (define-public rtorrent
     (home-page "https://github.com/rakshasa/rtorrent")
     (license l:gpl2+)))
 
-(define-public tremc
-  (let ((commit "d8deaa5ac25bb45a2ca3a930309d6ecc74836a54")
-        (revision "1"))
+(define-public rtorrent-xml-rpc
   (package
-    (name "tremc")
-    (version (git-version "0.9.3" revision commit))
-    (source
-     (origin
-       (method git-fetch)
-       (uri (git-reference
-             (url "https://github.com/tremc/tremc")
-             (commit commit)))
-       (file-name (git-file-name name version))
-       (sha256
-        (base32
-         "08kpqmgisja98918f2hlmdrld5662dqlkssp0pqlki38l6fvbj7r"))))
-    (build-system gnu-build-system)
+    (inherit rtorrent)
+    (name "rtorrent-xml-rpc")
     (arguments
-     `(#:tests? #f                      ; no test suite
-       #:make-flags
-       (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
-       #:phases
-       (modify-phases %standard-phases
-         ;; The software is just a Python script that must be copied into place.
-         (delete 'configure)
-         (delete 'build))))
+     `(#:configure-flags '("--with-xmlrpc-c")))
     (inputs
-     (list python))
-    (synopsis "Console client for the Transmission BitTorrent daemon")
-    (description "Tremc is a console client, with a curses interface, for the
+     (modify-inputs (package-inputs rtorrent)
+       (append xmlrpc-c)))
+    (description
+     "rTorrent is a BitTorrent client with an ncurses interface.  It supports
+full encryption, DHT, PEX, and Magnet Links.  Built with XML-RPC support.")))
+
+(define-public tremc
+  (let ((commit "d8deaa5ac25bb45a2ca3a930309d6ecc74836a54")
+        (revision "1"))
+    (package
+      (name "tremc")
+      (version (git-version "0.9.3" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/tremc/tremc")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "08kpqmgisja98918f2hlmdrld5662dqlkssp0pqlki38l6fvbj7r"))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:tests? #f                    ; no test suite
+         #:make-flags
+         (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
+         #:phases
+         (modify-phases %standard-phases
+           ;; The software is just a Python script that must be copied into place.
+           (delete 'configure)
+           (delete 'build))))
+      (inputs
+       (list python))
+      (synopsis "Console client for the Transmission BitTorrent daemon")
+      (description "Tremc is a console client, with a curses interface, for the
 Transmission BitTorrent daemon.")
-    (home-page "https://github.com/tremc/tremc")
-    (license l:gpl3+))))
+      (home-page "https://github.com/tremc/tremc")
+      (license l:gpl3+))))
 
 (define-public aria2
   (package
-- 
2.47.1

Message #8 received at 75644 <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: Divya Ranjan <divya <at> subvertising.org>
Cc: 75644 <at> debbugs.gnu.org
Subject: Re: [bug#75644] [PATCH] gnu: Add rtorrent-xml-rpc.
Date: Thu, 13 Feb 2025 13:54:24 +0000

Hi Divya,

On 2025-01-18 08:05, Divya Ranjan via Guix-patches via wrote:
> * gnu/packages/bittorrent.scm (rtorrent-xml-rpc): New variable.

Is it worth defining a package variant just for the XML-RPC support?
Why not just build rtorrent with XML-RPC baked in? Unless there's a cycle
or XML-RPC addition increases the package size by intolerable amounts,
I'd say you should simply enable the feature in the base rtorrent package
otherwise if everyone starts defining "minimalist" package variants its going
to result in a combinatorial explosion.

My 2¢,

-- 
Cheers,
Bruno.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.