Stefan Kangas <stefankangas@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 75655) by debbugs.gnu.org; 24 Jan 2025 14:50:11 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 24 09:50:11 2025 Received: from localhost ([127.0.0.1]:44354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tbL0d-0003ib-71 for submit <at> debbugs.gnu.org; Fri, 24 Jan 2025 09:50:11 -0500 Received: from mail-10630.protonmail.ch ([79.135.106.30]:57681) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <pipcet@HIDDEN>) id 1tbL0b-0003hs-D3 for 75655 <at> debbugs.gnu.org; Fri, 24 Jan 2025 09:50:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1737730201; x=1737989401; bh=bAPGfNe4cObzgsEplGT/OBmi/C2gJxPbfd2XAr3q/8k=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=djuoYBWcbPbqPm0Z9jsak61Rj8AKclIFQHeIAZic8PtOQqm03eRs1/8gJUvqV9QtJ Vttuu6VUZgjTR42xZDTMMNmi+IwrAtjAFn3FZEC98cnpC+xJ4OXJUnNrPTRGWXvm/3 CJES7gFJPjV9pVOl2XzszMIABI/dVwxftBt48jBpW8dYz6mhxY5Pdecex6O7oyYt63 QzVAhTcWntUlhPs3jLqhZ76y+N7BGymiqxYz1FXbk42EbC7kCOwWGGvwFPUVWN/bj+ Dp4MHfFKngXq7eo3CfCroCOnXLV4o1VSuF3yvFFHt0WpRokGqtCPVoeBDRzIAM9Umi l2uoRK93TcrTw== Date: Fri, 24 Jan 2025 14:49:58 +0000 To: Eli Zaretskii <eliz@HIDDEN> From: Pip Cet <pipcet@HIDDEN> Subject: Re: bug#75655: configure doesn't update Makefile Message-ID: <87o6zwxo51.fsf@HIDDEN> In-Reply-To: <868qr0xq3x.fsf@HIDDEN> References: <87bjw3c3uf.fsf@HIDDEN> <87cyge8toe.fsf@HIDDEN> <868qr22hd9.fsf@HIDDEN> <87jzal63d6.fsf@HIDDEN> <CADwFkmnDaK0V1ACK=TCOrAVMA6jX-DitevGxhk_dadVbEiweow@HIDDEN> <87ed0t2sw6.fsf@HIDDEN> <86y0z0y8nv.fsf@HIDDEN> <87y0z0z74p.fsf@HIDDEN> <868qr0xq3x.fsf@HIDDEN> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: cdd8d8498e94ac0f0947e78465c7dc1cba14ce43 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 75655 Cc: stefankangas@HIDDEN, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) "Eli Zaretskii" <eliz@HIDDEN> writes: >> Date: Fri, 24 Jan 2025 13:14:26 +0000 >> From: Pip Cet <pipcet@HIDDEN> >> Cc: stefankangas@HIDDEN, schwab@HIDDEN, 75655 <at> debbugs.gnu.org >> >> "Eli Zaretskii" <eliz@HIDDEN> writes: >> >> > IMO, this loses useful information about the aclocal.m4 problem. It >> >> My understanding is this problem was fixed long ago (see below!) > > [...] > > Look, you asked for extensive criticism, so I took time to examine the > new text and provide criticism. If all you wanted was to reject every > single comment, then why didn't you say so in the first place? It > would have saved me some time during a busy day. No, sorry, I did ask for it, and you correctly pointed out unexplained changes. I tried to explain them, but I shouldn't have: if it's not explained in the ChangeLog entry, the patch is unacceptable and should be rejected. I'm sorry this came over the wrong way! > (Btw, all this sub-thread about INSTALL.REPO is a tangent in the > context of this bug report. One other evidence for the futility of > this argument, if you ask me.) If it's futile, let's abandon it. Sorry again, Pip
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at 75655) by debbugs.gnu.org; 24 Jan 2025 14:07:44 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 24 09:07:44 2025 Received: from localhost ([127.0.0.1]:44250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tbKLX-0001hN-US for submit <at> debbugs.gnu.org; Fri, 24 Jan 2025 09:07:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44808) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tbKLV-0001hA-Lj for 75655 <at> debbugs.gnu.org; Fri, 24 Jan 2025 09:07:42 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tbKLP-00081q-72; Fri, 24 Jan 2025 09:07:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=nfxm5crDcHqydDDt2M7W70eXNhI+okfjqeXxPCu/O/w=; b=gnBGXbgM7xnM 7iFaFrvvZTxuBsxEGcAcDPo4uCeolMPXiAT55uefQY8KWwBD6UhQoU1oJf+Eq8SQKwXhEuOQ8yVxB j/NQuhtorBEqZymIR56ps3lWjt0+cY5JWO+391nnr/fCBGoweeuSzevheesv62KORB/ZyZK5dwg/p u4WsCCcysHjBPltapcwW4YHpkGKo04DUDg41xEJqxMKMo47ClQVEG8T79ow7bi6AtF6yNuuFKiVeY oLyEcJSXyM9E1bqVTDHXbaV3E7rHX2WE0gs2qWvmgB9IT2uXEGGYPssr1xS5cFzLr2mxNDxAQL5oD L+KxAl2rqP02I/Uq2sd5KA==; Date: Fri, 24 Jan 2025 16:07:14 +0200 Message-Id: <868qr0xq3x.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Pip Cet <pipcet@HIDDEN> In-Reply-To: <87y0z0z74p.fsf@HIDDEN> (message from Pip Cet on Fri, 24 Jan 2025 13:14:26 +0000) Subject: Re: bug#75655: configure doesn't update Makefile References: <87bjw3c3uf.fsf@HIDDEN> <87r04xyt84.fsf@HIDDEN> <87frld9ink.fsf@HIDDEN> <87cyge8toe.fsf@HIDDEN> <868qr22hd9.fsf@HIDDEN> <87jzal63d6.fsf@HIDDEN> <CADwFkmnDaK0V1ACK=TCOrAVMA6jX-DitevGxhk_dadVbEiweow@HIDDEN> <87ed0t2sw6.fsf@HIDDEN> <86y0z0y8nv.fsf@HIDDEN> <87y0z0z74p.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75655 Cc: stefankangas@HIDDEN, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Fri, 24 Jan 2025 13:14:26 +0000 > From: Pip Cet <pipcet@HIDDEN> > Cc: stefankangas@HIDDEN, schwab@HIDDEN, 75655 <at> debbugs.gnu.org > > "Eli Zaretskii" <eliz@HIDDEN> writes: > > > IMO, this loses useful information about the aclocal.m4 problem. It > > My understanding is this problem was fixed long ago (see below!) [...] Look, you asked for extensive criticism, so I took time to examine the new text and provide criticism. If all you wanted was to reject every single comment, then why didn't you say so in the first place? It would have saved me some time during a busy day. Anyway, I stand by my comments. I hoped (and still hope!) they will be useful to you and to others, but I have no intention to keep arguing about this. FWIW, I consider this file to be of relatively low importance to the project, certainly compared to other issues we have on the table. (Btw, all this sub-thread about INSTALL.REPO is a tangent in the context of this bug report. One other evidence for the futility of this argument, if you ask me.)
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at 75655) by debbugs.gnu.org; 24 Jan 2025 13:14:42 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 24 08:14:42 2025 Received: from localhost ([127.0.0.1]:44130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tbJWD-0007bq-Hk for submit <at> debbugs.gnu.org; Fri, 24 Jan 2025 08:14:42 -0500 Received: from mail-40134.protonmail.ch ([185.70.40.134]:22807) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <pipcet@HIDDEN>) id 1tbJW9-0007bW-Nv for 75655 <at> debbugs.gnu.org; Fri, 24 Jan 2025 08:14:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1737724470; x=1737983670; bh=xR0UHjmf6RDY2l7t3fFMpKoVOz87JMqlR6UJY1XAu28=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=aUh9H9F8xxEFA6hFvf7wvhn8zm5OajEYwGOJZgNGLzlyi6BCx5j5yJA4t8fRi7iTI dbczvxnTXbK9DetMAPQAYSbLEKBMD3MEkG2wiRyikENxlt2SxG2FTpqvgcwKIwAhqJ Zj4sk+kXnlKF5RvkJoBwO4SPsTv4qRXiWIf7k8mt/sxQLlIfpFwqd5sb15hXA2WiHG rAFDn1K/x0pfVFaSugtXUpWX9o+ACl0Khva0mf42NFm8kb5a4OBuHTpe658be2sz0+ p2SYDNKOuImrmJ85pmHuOQRfUOPPANIC92Tuw0KpqUY4eKhABvHQQtC/JeMnBbzgBN 7zDo49dotFiHA== Date: Fri, 24 Jan 2025 13:14:26 +0000 To: Eli Zaretskii <eliz@HIDDEN> From: Pip Cet <pipcet@HIDDEN> Subject: Re: bug#75655: configure doesn't update Makefile Message-ID: <87y0z0z74p.fsf@HIDDEN> In-Reply-To: <86y0z0y8nv.fsf@HIDDEN> References: <87bjw3c3uf.fsf@HIDDEN> <87r04xyt84.fsf@HIDDEN> <87frld9ink.fsf@HIDDEN> <87cyge8toe.fsf@HIDDEN> <868qr22hd9.fsf@HIDDEN> <87jzal63d6.fsf@HIDDEN> <CADwFkmnDaK0V1ACK=TCOrAVMA6jX-DitevGxhk_dadVbEiweow@HIDDEN> <87ed0t2sw6.fsf@HIDDEN> <86y0z0y8nv.fsf@HIDDEN> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: af21fa764b80ca3fcea5f3ff10ef40728a83fd51 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75655 Cc: schwab@HIDDEN, stefankangas@HIDDEN, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) "Eli Zaretskii" <eliz@HIDDEN> writes: >> Date: Thu, 23 Jan 2025 20:10:44 +0000 >> From: Pip Cet <pipcet@HIDDEN> >> Cc: Eli Zaretskii <eliz@HIDDEN>, schwab@HIDDEN, 75655@HIDDEN= nu.org >> >> --- a/INSTALL.REPO >> +++ b/INSTALL.REPO >> @@ -75,18 +75,19 @@ To rebuild Emacs with the default configuration opti= ons, you can use: >> >> $ make bootstrap configure=3Ddefault >> >> -Occasionally, there are changes that 'make bootstrap' won't be able to >> -handle. The most thorough cleaning can be achieved by 'git clean -fdx' >> -which will leave you with only files from the git repository. Here >> -are some faster methods for a couple of particular error cases: >> +Rarely, after a git update, all 'make' commands will fail because the >> +Makefile itself is no longer usable. Error messages such as: >> >> - /usr/bin/m4:aclocal.m4:9: cannot open `m4/stdbit_h.m4': No such fil= e or directory >> + make: *** No rule to make target 'benchmarks/Makefile.in', needed b= y 'Makefile'. Stop. >> >> -This can be fixed with 'rm aclocal.m4'. >> +indicate this. You should delete and rebuild the Makefile: >> >> - make: *** No rule to make target 'lib/Makefile.am', needed by 'lib/= Makefile.in' >> + $ rm -f Makefile >> + $ make >> + >> +If this doesn't fix the problem, you can clean the git repo: >> >> -This can be fixed with 'rm lib/Makefile Makefile'. >> + $ git clean -idX > > IMO, this loses useful information about the aclocal.m4 problem. It My understanding is this problem was fixed long ago (see below!), when this rule was changed to include a $(wildcard) (later replaced by a simple glob, which makes the code less readable and seem obviously incorrect to the casual reader): $(srcdir)/configure: $(srcdir)/configure.ac $(srcdir)/m4/*.m4 =09cd $(srcdir) && ./autogen.sh autoconf Even if I'm wrong about that, I expected the reader to try the "git clean -idX" trick anyway, which should help. However, I now suggest replacing "fix the problem" by "fix this or similar problems" to make it more likely the reader will try the second fix rather than rm -rf emacs. In summary: 1. definitely fixed now 2. fixed so long ago it won't break 'git bisect' anymore 3. if it does break, we'll still be covered > was there because it happened to people, and users who are not experts > in Automake will have trouble coping with it. I do agree that it > should be very rare, so making it the last problem we describe is > okay. The command to build aclocal.m4 (in autogen.sh) was changed to use wildcards, and the Makefile.in rule to rerun autogen.sh autoconf also uses wildcards. > Moving "git -fdx" to the end and changing it to "git -idx" is also a It doesn't make sense to tell people to try the more drastic solution first, then suggest they might get away with a less drastic and more dangerous solution afterwards. Specifying a --force option and abbreviating it so it isn't obvious that something is being forced that the Git authors did not think should happen by default is a mistake, IMHO. Developers will refuse to specify --force, I would hope. > mistake, IMO. It is a much simpler operation to do, and cannot > possibly mistakenly delete required files. In a clean tree, it is > also TRT. I'm okay with Stefan's suggestion to explain that this In an unclean tree, "git clean" won't revert uncommitted changes in files that DO exist in the base version. An additional git reset is required for that. > command removes uncommitted changes, and saying that if there are > uncommitted changes one wants to keep, one should use the interactive > "git -idx" instead. But let's not spare the important details; The problem is that when I said "uncommitted changes", I was referring to new files. People will not expect a new lisp file they're working on to be permanently removed if they previously ran a command to identify "uncommitted changes", which usually skips new files. > instead, let's describe them, along with the supporting information > that would allow people to make informed decisions what to do in their > particular case. I don't think INSTALL.REPO is the right place for even more text. > The text about removing Makefile's should also be amended to explain > that the Makefile file to be removed is in the directory spelled out > by the error message. The intention was that the user would run $ rm -f Makefile in the emacs directory. What you're saying sounds like $ rm -f benchmarks/Makefile which wouldn't do anything. > The lib/Makefile.am example was better for that We switched from automake long ago :-) > because it included a directory name, but we should amend the text to > say explicitly that the Makefile to be deleted is in the same > directory. The Makefile to be deleted is the one in the emacs/ directory. Nothing should be done in the benchmarks/ directory, which doesn't exist at this point. > Last, but not least: if we are going to expand INSTALL.REPO to include > a significant amount of additional information for special cases, we I ensured my change added no text overall. > should consider dividing it into sections. The first section should > just show the nominal sequence of commands to build Emacs, because > that's what the absolute majority of readers will need. The rest > should have appropriate headings, to allow finding the required > information easily and quickly. For example, the part we are > discussing here could have a heading like "If you encounter a build > failure" or something to that effect. Adding more text to INSTALL.REPO in an attempt to structure it seems a separate issue. I'm okay with removing the "rm -f Makefile" trick, particularly if we make it unnecessary for future generations by using $(wildcard) in Makefile.in. Pip
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at 75655) by debbugs.gnu.org; 24 Jan 2025 07:26:43 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 24 02:26:43 2025 Received: from localhost ([127.0.0.1]:43424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tbE5T-0007x3-4t for submit <at> debbugs.gnu.org; Fri, 24 Jan 2025 02:26:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44872) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tbE5P-0007wl-Dz for 75655 <at> debbugs.gnu.org; Fri, 24 Jan 2025 02:26:41 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tbE5J-0003HB-7C; Fri, 24 Jan 2025 02:26:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Ft81vwp6X7prqHTQNZRbhacLcLHmWZdItCrEoh1zud8=; b=YAv9lRWO1VjV aK1zvtTfTHTRNjJbD+KiPgINWONrTVGH268l7UWSTz4nzavPBM6m7TYm7DD9Jtj7wPMt8Wd2AL6Yw iFg9ge2p1f0hE6rsGeQ2+doQUWUzPy2hXptptd3PIApFgmcCcRq6YskpquEHFYlPKP870173QSOOo 800+NerQopCz+pAQXT0dPO2He95SgIC7yLGjNDW+TTzduwxTaGjnqkrG/9l+o4hgvqZeEADbeYPr8 LUEpK2Z7A3zkXui39x52dvB0P1GAUfo38OFodkW5Hv5VfebfIHTmYue/Qeff7w1TzMsisU98IjCIx FXUGbsrDTH0hiF6k8ge+gg==; Date: Fri, 24 Jan 2025 09:26:28 +0200 Message-Id: <86y0z0y8nv.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Pip Cet <pipcet@HIDDEN> In-Reply-To: <87ed0t2sw6.fsf@HIDDEN> (message from Pip Cet on Thu, 23 Jan 2025 20:10:44 +0000) Subject: Re: bug#75655: configure doesn't update Makefile References: <87bjw3c3uf.fsf@HIDDEN> <87plkh19s7.fsf@HIDDEN> <87jzap9lpj.fsf@HIDDEN> <87r04xyt84.fsf@HIDDEN> <87frld9ink.fsf@HIDDEN> <87cyge8toe.fsf@HIDDEN> <868qr22hd9.fsf@HIDDEN> <87jzal63d6.fsf@HIDDEN> <CADwFkmnDaK0V1ACK=TCOrAVMA6jX-DitevGxhk_dadVbEiweow@HIDDEN> <87ed0t2sw6.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75655 Cc: schwab@HIDDEN, stefankangas@HIDDEN, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Thu, 23 Jan 2025 20:10:44 +0000 > From: Pip Cet <pipcet@HIDDEN> > Cc: Eli Zaretskii <eliz@HIDDEN>, schwab@HIDDEN, 75655 <at> debbugs.gnu.org > > --- a/INSTALL.REPO > +++ b/INSTALL.REPO > @@ -75,18 +75,19 @@ To rebuild Emacs with the default configuration options, you can use: > > $ make bootstrap configure=default > > -Occasionally, there are changes that 'make bootstrap' won't be able to > -handle. The most thorough cleaning can be achieved by 'git clean -fdx' > -which will leave you with only files from the git repository. Here > -are some faster methods for a couple of particular error cases: > +Rarely, after a git update, all 'make' commands will fail because the > +Makefile itself is no longer usable. Error messages such as: > > - /usr/bin/m4:aclocal.m4:9: cannot open `m4/stdbit_h.m4': No such file or directory > + make: *** No rule to make target 'benchmarks/Makefile.in', needed by 'Makefile'. Stop. > > -This can be fixed with 'rm aclocal.m4'. > +indicate this. You should delete and rebuild the Makefile: > > - make: *** No rule to make target 'lib/Makefile.am', needed by 'lib/Makefile.in' > + $ rm -f Makefile > + $ make > + > +If this doesn't fix the problem, you can clean the git repo: > > -This can be fixed with 'rm lib/Makefile Makefile'. > + $ git clean -idX IMO, this loses useful information about the aclocal.m4 problem. It was there because it happened to people, and users who are not experts in Automake will have trouble coping with it. I do agree that it should be very rare, so making it the last problem we describe is okay. Moving "git -fdx" to the end and changing it to "git -idx" is also a mistake, IMO. It is a much simpler operation to do, and cannot possibly mistakenly delete required files. In a clean tree, it is also TRT. I'm okay with Stefan's suggestion to explain that this command removes uncommitted changes, and saying that if there are uncommitted changes one wants to keep, one should use the interactive "git -idx" instead. But let's not spare the important details; instead, let's describe them, along with the supporting information that would allow people to make informed decisions what to do in their particular case. The text about removing Makefile's should also be amended to explain that the Makefile file to be removed is in the directory spelled out by the error message. The lib/Makefile.am example was better for that because it included a directory name, but we should amend the text to say explicitly that the Makefile to be deleted is in the same directory. Last, but not least: if we are going to expand INSTALL.REPO to include a significant amount of additional information for special cases, we should consider dividing it into sections. The first section should just show the nominal sequence of commands to build Emacs, because that's what the absolute majority of readers will need. The rest should have appropriate headings, to allow finding the required information easily and quickly. For example, the part we are discussing here could have a heading like "If you encounter a build failure" or something to that effect.
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at 75655) by debbugs.gnu.org; 24 Jan 2025 07:13:37 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 24 02:13:37 2025 Received: from localhost ([127.0.0.1]:43402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tbDsm-0007Jp-Su for submit <at> debbugs.gnu.org; Fri, 24 Jan 2025 02:13:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35470) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tbDsj-0007JQ-LJ for 75655 <at> debbugs.gnu.org; Fri, 24 Jan 2025 02:13:34 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tbDsb-0001Cn-DC; Fri, 24 Jan 2025 02:13:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=wpmxugEcF1FNUulaqLDbOv/QOt0e3ZuJS7pZP/zp+h4=; b=pA3L71t+mgb4 Q7cQxyrRpN+Epfanb9+GSnjQRINtNgMClwqzExVxsR9bXHxR7c4nnZp8r3N6z3qXfEbsnhu7FACG+ Z3/bz764gb14Lg9rlvxTQsCo7K375G67i5HYyms/fvMA0d2lC7P9S2FLT5RV69Bk9wFxmTZZ0dtn/ pCKfDrgBVQZbS6yZ9n69qLw1Osd6ZJWnsNsJ0URFyfQktlfWqNHeCeIg4LvsKFpCVH4nSF9IeAaxT +m5UBQudaXA6Q8PoqZbEIMFuw5smfrjc5/cs+0ttR/m7gNktJRhvAPFVFuSHYQ+0xuqrt2fCcr6FB sr2gtrVtuAzy3VI8feGdNA==; Date: Fri, 24 Jan 2025 09:13:21 +0200 Message-Id: <86zfjgy99q.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Pip Cet <pipcet@HIDDEN> In-Reply-To: <8734h92quf.fsf@HIDDEN> (message from Pip Cet on Thu, 23 Jan 2025 20:54:59 +0000) Subject: Re: bug#75655: configure doesn't update Makefile References: <87bjw3c3uf.fsf@HIDDEN> <87r04xyt84.fsf@HIDDEN> <87frld9ink.fsf@HIDDEN> <87cyge8toe.fsf@HIDDEN> <868qr22hd9.fsf@HIDDEN> <87jzal63d6.fsf@HIDDEN> <8634h91sc3.fsf@HIDDEN> <877c6l4dyi.fsf@HIDDEN> <86ed0tz8vk.fsf@HIDDEN> <8734h92quf.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75655 Cc: schwab@HIDDEN, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Thu, 23 Jan 2025 20:54:59 +0000 > From: Pip Cet <pipcet@HIDDEN> > Cc: schwab@HIDDEN, 75655 <at> debbugs.gnu.org > > "Eli Zaretskii" <eliz@HIDDEN> writes: > > >> For this problem, the behavior is even worse for out-of-tree builds: the > >> problem occurs the same way, but one of the suggested fixes from > >> INSTALL.REPO leaves you without a Makefile, and the other one won't work > >> but will probably delete valuable data. > > > > I don't see how this is relevant. "git clean" should be run in the > > source tree (the build tree is not a Git checkout), and the other > > fixes are for very specific problems. > > I think it is relevant: The fixes in INSTALL.REPO will not work in the > out-of-tree case, no matter where you run them. If INSTALL.REPO doesn't take out-of-tree builds into account, then the instructions should be fixed or expanded to cover that case. But it's a separate issue. This thread started by your describing build problems, not problems with advice in INSTALL.REPO. If there are build problems, they should be fixed first, because INSTALL.REPO is just an advisory; if someone succeed in building Emacs from Git without reading that file, it's still a win. IOW, let's please separate the issues that need to be handled independently, otherwise this discussion will diverge even more than it has already, and we will be unable to fix whatever the problems we have. > You suggested "out-of-tree" builds to me, and it sounded like you > thought they'd help fix or avoid this issue. They don't. The suggestion was for the case where you need to produce several builds from the same sources, which will help you to avoid the need of removing artifacts of building for a different configuration, since each configuration has its artifacts in a different directory. In particular, such an arrangement should greatly reduce the need for "make bootstrap". When you say "they don't", does that mean you tried my suggestion and it failed to do what you need, i.e. avoid having irrelevant artifacts in the build tree, or does it only mean you found that INSTALL.REPO doesn't cover that case well enough? > >> Sorry I can't address the general git comments/"out of tree" builds in > >> detail right now. I find git hard enough to use without committing > >> changes so I don't actually push them (that one's confusing), and > >> certainly won't use multiple clones. "Out of tree" builds are useless > >> *to me* as long as they create thousands of files in the "source" tree; > >> in this case, they make the problem worse. > > > > Fair enough, but you are proposing changes to Emacs's build machinery, > > so this is not just about you and your personal workflows, right? > > Absolutely. I seriously do think that several other people will run > into this issue when scratch/elisp-benchmarks is (rebuilt and) merged. Maybe. But you described quite unique workflows, so I have my doubts. > OOT builds are unrelated. Unless I can chmod a-w my emacs source > directory and build from it, they're not "out of tree", and they're not > for me. I think you are mistaken. But then you haven't shown any details of why these builds are not for you, so maybe I'm missing something and you are right.
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at 75655) by debbugs.gnu.org; 24 Jan 2025 06:59:19 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 24 01:59:19 2025 Received: from localhost ([127.0.0.1]:43379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tbDex-0006ed-DJ for submit <at> debbugs.gnu.org; Fri, 24 Jan 2025 01:59:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51674) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tbDeu-0006eO-9K for 75655 <at> debbugs.gnu.org; Fri, 24 Jan 2025 01:59:17 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tbDen-0007ja-Ap; Fri, 24 Jan 2025 01:59:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=HtSv4yeT3TCgFyz71ALAt9znjGjoxA/1dnv7HSpGthY=; b=ddWz01fjgZnn SHBuRVajA6D8HKNJWr6byciGxQiUmqERsUG2OIW5lGhjl/CmriO3679fNpG9ZeSVpgdjKrijxmXIK Xl22C0+n4tPDytdz2ob/aXbtsCnwfNrAdb6fkiTbzrMgvUEpIWes54/UsfCyhg7mqRgs0gmMxFPI4 KI2FptfYwpqcDIgg+4jvuQVNuiNCEfUsMp+9+1TYyzBCETacNX3+zeUIRbH5zocivpRxwhk7IWd7A GmLeLnaljfu3sStSisDGCVdE6eQhQlqXTcVHwynHSXtFJ4+c+qh0KyNDNeBZ0rjd/VHCUapiFA5jY Cp/N57r1+Yqid9Y0No5WvA==; Date: Fri, 24 Jan 2025 08:59:07 +0200 Message-Id: <8634h8zohw.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Pip Cet <pipcet@HIDDEN> In-Reply-To: <878qr12san.fsf@HIDDEN> (message from Pip Cet on Thu, 23 Jan 2025 20:23:39 +0000) Subject: Re: bug#75655: configure doesn't update Makefile References: <87bjw3c3uf.fsf@HIDDEN> <87jzap9lpj.fsf@HIDDEN> <87r04xyt84.fsf@HIDDEN> <87frld9ink.fsf@HIDDEN> <87cyge8toe.fsf@HIDDEN> <868qr22hd9.fsf@HIDDEN> <87jzal63d6.fsf@HIDDEN> <8634h91sc3.fsf@HIDDEN> <CADwFkmnro1J122KXUbS1S1A1BousSQFRF6KJrC=kPiWPXc4RrA@HIDDEN> <878qr12san.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75655 Cc: schwab@HIDDEN, stefankangas@HIDDEN, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Thu, 23 Jan 2025 20:23:39 +0000 > From: Pip Cet <pipcet@HIDDEN> > Cc: Eli Zaretskii <eliz@HIDDEN>, schwab@HIDDEN, 75655 <at> debbugs.gnu.org > > "Stefan Kangas" <stefankangas@HIDDEN> writes: > > > Eli Zaretskii <eliz@HIDDEN> writes: > > > >> You should not have uncommitted changes, ever. Always either commit > >> them (on a local branch if needed) or stash them. Keeping uncommitted > >> changes runs the risk of pushing them inadvertently with unrelated > >> changes (it happened to me and to others). > > > > FWIW, while you're probably right in the abstract, I have a habit of > > doing exactly that. This is for various reasons: it's impractical to > > commit them only to a specific branch, stashing gets old quick, and it's > > also quite inconvenient to keep them outside the repository. Right now, > > for instance, I have nine important yet untracked files in my > > repository. > > I'm still not sure why of those two scenarios: > > A: > 1. make some changes > 2. commit them to a local branch > 3. accidentally push that brach > > is more likely than > > B: > 1. make some changes > 2. accidentally run "git add" > 3. accidentally run "git commit" > 4. accidentally push the changes > > It seems that (B) requires three mistakes, (A) only one. First, I said "or stash". That has the advantage that changes cannot be pushed by mistake. And second, since "git add" is a nuisance, at least IMO, I expect people to use "git commit -a", which then requires only 1 mistake, not 2 (I don't understand how you counted 3, since the commit step is not a mistake). > Those differences might explain a lot. I use magit, too (but not for > pushing; I have a well-ingrained sequence of commands starting with > "git push --dry-run savannah HEAD:feature/igc" for that.) I don't use magit.
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at 75655) by debbugs.gnu.org; 23 Jan 2025 20:55:12 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 23 15:55:12 2025 Received: from localhost ([127.0.0.1]:42587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tb4EK-000496-9Q for submit <at> debbugs.gnu.org; Thu, 23 Jan 2025 15:55:12 -0500 Received: from mail-40133.protonmail.ch ([185.70.40.133]:62371) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <pipcet@HIDDEN>) id 1tb4EH-00048R-4h for 75655 <at> debbugs.gnu.org; Thu, 23 Jan 2025 15:55:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1737665702; x=1737924902; bh=JLyv9+ZdMx2JKF2J8mW0hkHZtTH4w+je1FdOeenZgkg=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=zOfm3DB8ZEd0jTli2YabVJqYZxAASQAWgjpe/CP99bEAGkTmJU90Nk7Ja9FTq+xU6 ilFwrjinTfE/vN9793GfkVyx/nJe9YWlDY9/BCzYRfrnBS6kERwzGEDus/8Y0jJvZ4 Xqt6uYCseG6Yb7/V7dFb/w+HooiyAtiGTdsZM+cs0MJG9vTIzX3HWBWCHZH5yAZ9XG DExhd7zDaGOVJ+jtrs4GnNy84tCIewnzpQjINKtWDVCftE/ji9+UktQChC9aBmo7Ck RSxLblQvV6R+pu8l5XZU0wXvWBzvpiou/CWD+SwUMQCgoLTkaFQKM8dbwLMHiJgLHa 8ZuVSA3f3j0zA== Date: Thu, 23 Jan 2025 20:54:59 +0000 To: Eli Zaretskii <eliz@HIDDEN> From: Pip Cet <pipcet@HIDDEN> Subject: Re: bug#75655: configure doesn't update Makefile Message-ID: <8734h92quf.fsf@HIDDEN> In-Reply-To: <86ed0tz8vk.fsf@HIDDEN> References: <87bjw3c3uf.fsf@HIDDEN> <87r04xyt84.fsf@HIDDEN> <87frld9ink.fsf@HIDDEN> <87cyge8toe.fsf@HIDDEN> <868qr22hd9.fsf@HIDDEN> <87jzal63d6.fsf@HIDDEN> <8634h91sc3.fsf@HIDDEN> <877c6l4dyi.fsf@HIDDEN> <86ed0tz8vk.fsf@HIDDEN> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: d328036d5a16f6134975d0b8e40225d6cf418de2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75655 Cc: schwab@HIDDEN, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) "Eli Zaretskii" <eliz@HIDDEN> writes: >> Date: Thu, 23 Jan 2025 17:50:23 +0000 >> From: Pip Cet <pipcet@HIDDEN> >> Cc: schwab@HIDDEN, 75655 <at> debbugs.gnu.org >> >> "Eli Zaretskii" <eliz@HIDDEN> writes: >> >> >> Date: Thu, 23 Jan 2025 13:56:15 +0000 >> >> From: Pip Cet <pipcet@HIDDEN> >> >> Cc: schwab@HIDDEN, 75655 <at> debbugs.gnu.org >> >> >> >> The problem is that we might eventually push this to the master branc= h, >> >> and then it becomes a problem of switching between revisions, not >> >> branches. It'd effectively break "git bisect" if a directory is adde= d >> >> in the bisection range. >> > >> > If you mean different builds from the same source tree, then I suggest >> > an out-of-tree builds. You use one source tree and several build >> >> For this problem, the behavior is even worse for out-of-tree builds: the >> problem occurs the same way, but one of the suggested fixes from >> INSTALL.REPO leaves you without a Makefile, and the other one won't work >> but will probably delete valuable data. > > I don't see how this is relevant. "git clean" should be run in the > source tree (the build tree is not a Git checkout), and the other > fixes are for very specific problems. I think it is relevant: The fixes in INSTALL.REPO will not work in the out-of-tree case, no matter where you run them. You suggested "out-of-tree" builds to me, and it sounded like you thought they'd help fix or avoid this issue. They don't. >> Sorry I can't address the general git comments/"out of tree" builds in >> detail right now. I find git hard enough to use without committing >> changes so I don't actually push them (that one's confusing), and >> certainly won't use multiple clones. "Out of tree" builds are useless >> *to me* as long as they create thousands of files in the "source" tree; >> in this case, they make the problem worse. > > Fair enough, but you are proposing changes to Emacs's build machinery, > so this is not just about you and your personal workflows, right? Absolutely. I seriously do think that several other people will run into this issue when scratch/elisp-benchmarks is (rebuilt and) merged. They'll try to bisect something, test a post-merge revision, try to test a pre-merge revision, it'll fail to build with a strange error message, they'll try 'make bootstrap', it'll fail with the same message, bug hunt stymied. I'd feel responsible for that, and I want to save them the troubles I had. That we have instructions hintin at this case indicates this isn't the first time it's happened, so it's unlikely to be the last time unless we fix it for good. OOT builds are unrelated. Unless I can chmod a-w my emacs source directory and build from it, they're not "out of tree", and they're not for me. Pip
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at 75655) by debbugs.gnu.org; 23 Jan 2025 20:23:55 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 23 15:23:55 2025 Received: from localhost ([127.0.0.1]:42527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tb3k2-0002ev-Ug for submit <at> debbugs.gnu.org; Thu, 23 Jan 2025 15:23:55 -0500 Received: from mail-10630.protonmail.ch ([79.135.106.30]:12635) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <pipcet@HIDDEN>) id 1tb3jz-0002ee-O0 for 75655 <at> debbugs.gnu.org; Thu, 23 Jan 2025 15:23:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1737663824; x=1737923024; bh=zGNyDl7tEOfDLLCBR3hK+HQB0c717CzhVjuzW5GGBj0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=wyAUHmf/+gEzKtXKHZxpmmEVySdhe+ibOiIfv9HUMEl10wk2Yr0NRGbtTCL9vO5wX YXTydcXHg/8OihrpmjUyqXgDnh+ve6X9Pi/9Kz2A65x85GC0wZL1B3pOnhjGjPR7L8 rx8H7M+mwL3Q1FdfkSIH5zDKypTeDxlRQRz6cjv1vke+7Z/AVMZozrTvKF1Qb/CuC1 BwZDhfwg10/jqk0oelWliqsbdWVfN+QAND5x/2PllItd+RXDQjqhs90hXyWlV+ccyw xmFdzdNLjcZ4rKHfaFqyKxCynUkTdyvZ/15hQ5XReMUuMhKbNd1/Q14GljGwDms6/l DpMJbjltXLsnQ== Date: Thu, 23 Jan 2025 20:23:39 +0000 To: Stefan Kangas <stefankangas@HIDDEN> From: Pip Cet <pipcet@HIDDEN> Subject: Re: bug#75655: configure doesn't update Makefile Message-ID: <878qr12san.fsf@HIDDEN> In-Reply-To: <CADwFkmnro1J122KXUbS1S1A1BousSQFRF6KJrC=kPiWPXc4RrA@HIDDEN> References: <87bjw3c3uf.fsf@HIDDEN> <87jzap9lpj.fsf@HIDDEN> <87r04xyt84.fsf@HIDDEN> <87frld9ink.fsf@HIDDEN> <87cyge8toe.fsf@HIDDEN> <868qr22hd9.fsf@HIDDEN> <87jzal63d6.fsf@HIDDEN> <8634h91sc3.fsf@HIDDEN> <CADwFkmnro1J122KXUbS1S1A1BousSQFRF6KJrC=kPiWPXc4RrA@HIDDEN> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: b1c678d6cbc2a871a4d1b96490d3294a84e877ca MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75655 Cc: Eli Zaretskii <eliz@HIDDEN>, schwab@HIDDEN, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) "Stefan Kangas" <stefankangas@HIDDEN> writes: > Eli Zaretskii <eliz@HIDDEN> writes: > >> You should not have uncommitted changes, ever. Always either commit >> them (on a local branch if needed) or stash them. Keeping uncommitted >> changes runs the risk of pushing them inadvertently with unrelated >> changes (it happened to me and to others). > > FWIW, while you're probably right in the abstract, I have a habit of > doing exactly that. This is for various reasons: it's impractical to > commit them only to a specific branch, stashing gets old quick, and it's > also quite inconvenient to keep them outside the repository. Right now, > for instance, I have nine important yet untracked files in my > repository. I'm still not sure why of those two scenarios: A: 1. make some changes 2. commit them to a local branch 3. accidentally push that brach is more likely than B: 1. make some changes 2. accidentally run "git add" 3. accidentally run "git commit" 4. accidentally push the changes It seems that (B) requires three mistakes, (A) only one. > I can't remember that I have ever committed any unrelated files by > accident. It seems hard to make that mistake in Magit, but what do I > know. Those differences might explain a lot. I use magit, too (but not for pushing; I have a well-ingrained sequence of commands starting with "git push --dry-run savannah HEAD:feature/igc" for that.) Pip
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at 75655) by debbugs.gnu.org; 23 Jan 2025 20:10:59 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 23 15:10:59 2025 Received: from localhost ([127.0.0.1]:42513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tb3XW-00025N-C0 for submit <at> debbugs.gnu.org; Thu, 23 Jan 2025 15:10:58 -0500 Received: from mail-4316.protonmail.ch ([185.70.43.16]:39965) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <pipcet@HIDDEN>) id 1tb3XS-000255-OM for 75655 <at> debbugs.gnu.org; Thu, 23 Jan 2025 15:10:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1737663048; x=1737922248; bh=EQysSq4UFY+Yse/uFslgiCkcTblfTG2lgVRpnNlk/pE=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=mihBxNb8lgSxtK5opDigBuJwhmUYB9CF+Q5DDs36HkMXrEcSbuKUdvQfuJZkLelck Ggudm910e2UyS2G6qaO1m9FzDksdi5sbVCvQSDi8TcyDACbd7p5Kn/w3MV7k0WpYTL RWZNteGoupk1q9tdA0L1mH/K20FXmSNlRdR1hGQX1l5TqN0gK/8/XfrTN+Bhrtnxts XrE7eEQyLN/mDBC5WQgi8YjiZWrJfgUNBZMiQlvrwylYFXgkEWpJDyT1h0AQhuTiYW NO9C5J8ffvSFhFudF8t8IdsuNyWN3vnVsPdDZL+p6r7o+bCvtPNs5B/72rLPaqLaYM Bi2chk4OrR9Cg== Date: Thu, 23 Jan 2025 20:10:44 +0000 To: Stefan Kangas <stefankangas@HIDDEN> From: Pip Cet <pipcet@HIDDEN> Subject: Re: bug#75655: configure doesn't update Makefile Message-ID: <87ed0t2sw6.fsf@HIDDEN> In-Reply-To: <CADwFkmnDaK0V1ACK=TCOrAVMA6jX-DitevGxhk_dadVbEiweow@HIDDEN> References: <87bjw3c3uf.fsf@HIDDEN> <87plkh19s7.fsf@HIDDEN> <87jzap9lpj.fsf@HIDDEN> <87r04xyt84.fsf@HIDDEN> <87frld9ink.fsf@HIDDEN> <87cyge8toe.fsf@HIDDEN> <868qr22hd9.fsf@HIDDEN> <87jzal63d6.fsf@HIDDEN> <CADwFkmnDaK0V1ACK=TCOrAVMA6jX-DitevGxhk_dadVbEiweow@HIDDEN> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 22119d611ec72b97c3838399b8e6c698b9355c3e MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75655 Cc: Eli Zaretskii <eliz@HIDDEN>, schwab@HIDDEN, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) "Stefan Kangas" <stefankangas@HIDDEN> writes: > Pip Cet via "Bug reports for GNU Emacs, the Swiss army knife of text > editors" <bug-gnu-emacs@HIDDEN> writes: > >> If we can't remove the advice (the first case has already been made >> unnecessary (commit 4939f58d2c45062d5eac3f4c845b4494cf113f1f); the >> $(wildcard) proposal merely does the same thing for the second case), we >> should, at least, recommend "git clean --interactive -dX" instead. >> >> -i rather than -f asks the user for confirmation; -X instead of -x will >> avoid the unnecessary deletion of files we're almost certain are >> valuable. This option and the "-d" option don't have long equivalents. >> >> Confirmed to work in this case. > > +1 > > I think the advice is occasionally useful, but making it safe is even > better. > > At the very least, we should write in big bold letters to be careful > with this command, but I'd prefer just changing it to the safe version > as I fail to see any drawbacks. Proposed patch. Please criticize hard: this is the second file a person building Emacs from git for the first time will read, and it's worth it to get this right. This patch is independent of fixing the issue; if we decide to do the wildcard thing, we might eventually be able to remove the first suggestion and go straight to "git clean -idX", but as the problem cannot be fixed retroactively, we should definitely keep this hint for a few years. We can think of this as a new section; some content remains, but the order and wording changed significantly, the examples were replaced, the instructions were simplified. As all commands should be safe to run now (assuming the user didn't edit autogenerated files), present them like the other safe commands. The error message mentions benchmarks/Makefile.in because that's likely the first one people will see, and because that is the precise messsage I actually saw. From c97a5e0f5e1467e2e3bbbf2a53a2190c2d083b3f Mon Sep 17 00:00:00 2001 From: Pip Cet <pipcet@HIDDEN> Subject: [PATCH] Improve instructions for Makefile regeneration (bug#75655) The scratch/elisp-benchmarks branch will add benchmarks/Makefile.in. Switching back to an older revision that doesn't have the directory will result in a broken Makefile which can be manually deleted to make the tree buildable again. * INSTALL.REPO (configuration): Remove outdated examples. Add current example. Recommend safer switches for "git clean". --- INSTALL.REPO | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/INSTALL.REPO b/INSTALL.REPO index 6a6c7a2187b..68d11ba9756 100644 --- a/INSTALL.REPO +++ b/INSTALL.REPO @@ -75,18 +75,19 @@ To rebuild Emacs with the default configuration options= , you can use: =20 $ make bootstrap configure=3Ddefault =20 -Occasionally, there are changes that 'make bootstrap' won't be able to -handle. The most thorough cleaning can be achieved by 'git clean -fdx' -which will leave you with only files from the git repository. Here -are some faster methods for a couple of particular error cases: +Rarely, after a git update, all 'make' commands will fail because the +Makefile itself is no longer usable. Error messages such as: =20 - /usr/bin/m4:aclocal.m4:9: cannot open `m4/stdbit_h.m4': No such file o= r directory + make: *** No rule to make target 'benchmarks/Makefile.in', needed by '= Makefile'. Stop. =20 -This can be fixed with 'rm aclocal.m4'. +indicate this. You should delete and rebuild the Makefile: =20 - make: *** No rule to make target 'lib/Makefile.am', needed by 'lib/Mak= efile.in' + $ rm -f Makefile + $ make + +If this doesn't fix the problem, you can clean the git repo: =20 -This can be fixed with 'rm lib/Makefile Makefile'. + $ git clean -idX =20 Because the repository version of Emacs is a work in progress, it will sometimes fail to build. Please wait a day or so (and check the --=20 2.47.1
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at 75655) by debbugs.gnu.org; 23 Jan 2025 18:24:36 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 23 13:24:36 2025 Received: from localhost ([127.0.0.1]:42318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tb1sU-0005D8-R9 for submit <at> debbugs.gnu.org; Thu, 23 Jan 2025 13:24:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56662) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tb1sO-0005Cj-0a for 75655 <at> debbugs.gnu.org; Thu, 23 Jan 2025 13:24:27 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tb1sG-0001Yd-GI; Thu, 23 Jan 2025 13:24:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=sLo7Hqhw423BdqdXqsEBYEqV3fTLmVkKeeCO9tDXQOo=; b=AA2CiRVDrdOg KZZTdQEU1uWRzGVX7IdUhWcxosMEU7exXE4iGcrFyfDz1zyz9bDCIyiWx/leJVm2tY0F8JRo2JQE8 NfgwjQY7tmTenkh44Osm1awVC57HWFJg6rN2/iRPz/8mOstO/o98NQDW6uwzWxhyA7iMTJKg6vV+Y dXAIjHQQpUIGs4ZzsiMpAkTOnpUeOmBJFcDNdsslxVKR+PF8okAersi+RpDAqA0WUyksVQIKCSGaj fP/hl3NKJTEL4fkNlHUYEvJI2P7UX9eEIMwTUgD3/7tnaERc1iUFpWu7GFo9jSH1H/1HNSv/IhFPC DXYFsbowYgeaa+mHKw3yYg==; Date: Thu, 23 Jan 2025 20:24:15 +0200 Message-Id: <86ed0tz8vk.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Pip Cet <pipcet@HIDDEN> In-Reply-To: <877c6l4dyi.fsf@HIDDEN> (message from Pip Cet on Thu, 23 Jan 2025 17:50:23 +0000) Subject: Re: bug#75655: configure doesn't update Makefile References: <87bjw3c3uf.fsf@HIDDEN> <87plkh19s7.fsf@HIDDEN> <87jzap9lpj.fsf@HIDDEN> <87r04xyt84.fsf@HIDDEN> <87frld9ink.fsf@HIDDEN> <87cyge8toe.fsf@HIDDEN> <868qr22hd9.fsf@HIDDEN> <87jzal63d6.fsf@HIDDEN> <8634h91sc3.fsf@HIDDEN> <877c6l4dyi.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75655 Cc: schwab@HIDDEN, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Thu, 23 Jan 2025 17:50:23 +0000 > From: Pip Cet <pipcet@HIDDEN> > Cc: schwab@HIDDEN, 75655 <at> debbugs.gnu.org > > "Eli Zaretskii" <eliz@HIDDEN> writes: > > >> Date: Thu, 23 Jan 2025 13:56:15 +0000 > >> From: Pip Cet <pipcet@HIDDEN> > >> Cc: schwab@HIDDEN, 75655 <at> debbugs.gnu.org > >> > >> The problem is that we might eventually push this to the master branch, > >> and then it becomes a problem of switching between revisions, not > >> branches. It'd effectively break "git bisect" if a directory is added > >> in the bisection range. > > > > If you mean different builds from the same source tree, then I suggest > > an out-of-tree builds. You use one source tree and several build > > For this problem, the behavior is even worse for out-of-tree builds: the > problem occurs the same way, but one of the suggested fixes from > INSTALL.REPO leaves you without a Makefile, and the other one won't work > but will probably delete valuable data. I don't see how this is relevant. "git clean" should be run in the source tree (the build tree is not a Git checkout), and the other fixes are for very specific problems. > > trees, each one configured differently. That is supported by the > > current Makefiles. > > I meant "git bisect". If you build from a separate directory, your git bisect procedure should involve a script that switches to the build directory after each checkout. > Sorry I can't address the general git comments/"out of tree" builds in > detail right now. I find git hard enough to use without committing > changes so I don't actually push them (that one's confusing), and > certainly won't use multiple clones. "Out of tree" builds are useless > *to me* as long as they create thousands of files in the "source" tree; > in this case, they make the problem worse. Fair enough, but you are proposing changes to Emacs's build machinery, so this is not just about you and your personal workflows, right?
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at 75655) by debbugs.gnu.org; 23 Jan 2025 18:13:27 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 23 13:13:27 2025 Received: from localhost ([127.0.0.1]:42300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tb1hn-0004hD-8u for submit <at> debbugs.gnu.org; Thu, 23 Jan 2025 13:13:27 -0500 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:59527) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tb1hi-0004gx-NQ for 75655 <at> debbugs.gnu.org; Thu, 23 Jan 2025 13:13:23 -0500 Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-5d3bbb0f09dso2243149a12.2 for <75655 <at> debbugs.gnu.org>; Thu, 23 Jan 2025 10:13:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737655996; x=1738260796; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=/uhNHrKAg0wAYjzm3yaCg8jSVCN1KumK0PtuDnBKqWc=; b=hKdjtP0UCypCTbQ1yq3G3PVy8W9FntDkVlEEeTrkWKHZnfAa6tm1B8+aeY5sWBMkiX CWEwdyT3G47RMn5/PblwRRgv6DnZUt9SCZhWx9BRXziJHu60T4JeE0Cham55XIE/w2Ej CdmkUn2YldQEQfgFWbhz+/uyG9GZ3g2U0wSJ4CyTMtDvs17Ba1bUUYdnw83wqCb+hXPy Q3aSNw4upPP+0dQhcporspdlbQxC+PN/u0mlMlQx3s2TLKncFHAXRKzQgaOcKQZodzk/ /Pk+0sUrXPWqEbN+LCjcKPhPx9UvN4UDikJNOJt1EAqwUoli7PPDCGcpBwtRJa9NkA3+ n1wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737655996; x=1738260796; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/uhNHrKAg0wAYjzm3yaCg8jSVCN1KumK0PtuDnBKqWc=; b=sq8VfwDbY9dgUhzo8OCqAFSs2DYFpHzcehvo3r+5/PaElG3Jur92V3hTCsSYleUq1P IWapxAv/yszRaTVW+EQbpiUS0Pgnwp5DvyK07+adnl/4G85N/odaTjwOGYoqqQIVQOZS CB/xSBkkKLaARLKt2CImHAdku9P8WVI4WrYPu6hdSLrqbLdVcWNrxw1emmzCWHIvkpEB EUF/smrKmnrsgEKevWXF/If8RsSExz7//72MQ0p9YTYC8nhYMcw1SJAHQA11jwwHN56j fXEtuaKXN5GakX+e8zEh+vGNn8cLhUWzCJjGMpd5gPKyH1e3C+caZRMC82bYk4K1Rso1 0pmA== X-Forwarded-Encrypted: i=1; AJvYcCX0olSK1yV78axEFU1P8BRuzgoRNguPP4XP4o92mSXzHK9UeUIn83edywohp4DuWUweCqA5tA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwdUVmGchKen0Wo/FlPLMsW9JLhRRFXPhi3XAcKas5C6Wq+quKw sUDXXYSA8nf/JIMUTYB8KT50L/VcY/DwrOsSj851f6gfW0FHgT9OovLK8PjbduljGD0MqU6EMY3 bm5tz3Yyf89b+rJJERN12Bs4hDhI= X-Gm-Gg: ASbGncvjUfz+jPMqQNddTK/wnoRO0dkaQ7n3zsd7hedFkUBdtx9M9auc/a8G0CyCHzS +GbowDPj4aNquJWgSCr1qZ2dG7fAr+3J1LqVqV+m+X5896V7s61/iwq8tW7EX X-Google-Smtp-Source: AGHT+IHGJFgveGsfuLjG9xiBTJabScasIWyFZ57deryuAJQDONQ4YLx0EJNVQ6ZHUUrbxi5dZn2edjDrlvcX6TxC4os= X-Received: by 2002:a05:6402:2347:b0:5d0:e2c8:dc8d with SMTP id 4fb4d7f45d1cf-5db7d3392d6mr25273609a12.20.1737655996327; Thu, 23 Jan 2025 10:13:16 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 23 Jan 2025 12:13:16 -0600 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <8634h91sc3.fsf@HIDDEN> References: <87bjw3c3uf.fsf@HIDDEN> <87jzarcfqg.fsf@HIDDEN> <874j1t5zvr.fsf@HIDDEN> <87o701a1b3.fsf@HIDDEN> <87plkh19s7.fsf@HIDDEN> <87jzap9lpj.fsf@HIDDEN> <87r04xyt84.fsf@HIDDEN> <87frld9ink.fsf@HIDDEN> <87cyge8toe.fsf@HIDDEN> <868qr22hd9.fsf@HIDDEN> <87jzal63d6.fsf@HIDDEN> <8634h91sc3.fsf@HIDDEN> MIME-Version: 1.0 Date: Thu, 23 Jan 2025 12:13:15 -0600 X-Gm-Features: AWEUYZkUOLlVokjMo86xBGxysmB_BthT0IMug8n4f4Z4hIwNefOx24gsHJBEXgQ Message-ID: <CADwFkmnro1J122KXUbS1S1A1BousSQFRF6KJrC=kPiWPXc4RrA@HIDDEN> Subject: Re: bug#75655: configure doesn't update Makefile To: Eli Zaretskii <eliz@HIDDEN>, Pip Cet <pipcet@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75655 Cc: schwab@HIDDEN, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: > You should not have uncommitted changes, ever. Always either commit > them (on a local branch if needed) or stash them. Keeping uncommitted > changes runs the risk of pushing them inadvertently with unrelated > changes (it happened to me and to others). FWIW, while you're probably right in the abstract, I have a habit of doing exactly that. This is for various reasons: it's impractical to commit them only to a specific branch, stashing gets old quick, and it's also quite inconvenient to keep them outside the repository. Right now, for instance, I have nine important yet untracked files in my repository. I can't remember that I have ever committed any unrelated files by accident. It seems hard to make that mistake in Magit, but what do I know.
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at 75655) by debbugs.gnu.org; 23 Jan 2025 18:06:52 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 23 13:06:51 2025 Received: from localhost ([127.0.0.1]:42267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tb1bP-0004Nu-9q for submit <at> debbugs.gnu.org; Thu, 23 Jan 2025 13:06:51 -0500 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:46140) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tb1bB-0004NM-0d for 75655 <at> debbugs.gnu.org; Thu, 23 Jan 2025 13:06:47 -0500 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5d96944401dso2216817a12.0 for <75655 <at> debbugs.gnu.org>; Thu, 23 Jan 2025 10:06:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737655591; x=1738260391; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=4qryQxPmTKOYD6shoQuHHk29D79gHVfOJGxmgNZXkeE=; b=HHLMH6b84bc76Tgo/n/xJAb/WovMlDlzF3hofbga3ObHm7RlVRhO5YFAYu313+TmDH EqR3sMyfH5rSYWC+XS/qSOe/VqL970xY4V4ZcLfVv20kQgNaw6wLl+2EkdK0/mg/RE6p b9Kxd5SNnNy7xS9NvV/XgUHsDA7OSeHl0HMhSIT0RIU/YpinFOke5/KkJ+aj0x1rVlXL AR3xjeKlVMWDLI52WV6nGWxESdkK6tRcPg/0vel0qTKaHWmzoGjiRoyiUNbgWWgl/OiI WjLkNnBNP4veH/Y6SZ2sBcuNFjP2jYbTyWgPSAC2mFZDtK6gxfMGzzRjUjP09HqQtEdh kcOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737655591; x=1738260391; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4qryQxPmTKOYD6shoQuHHk29D79gHVfOJGxmgNZXkeE=; b=FGoLwAhlb/dKOd80foULCwTUt4tVriT/D6G8qr9JcuX5kLO3hQG6atpjmRf+V4UIoy 80bYK7FvsY8kVjGBH90dm+JBZL37huGT6SpddQnNEoS7ju7f5jOttcrjU0V3UVk1vS0X QydoC5l0XM8ryxC1Wn+Cnq2RJiKTTVnYl7QNdr1kdYyrYEFUXgXjorRPl3FZqUusTXL+ EJ/qBEjGpWT+2C/0kImofcGbodHvTUsCB6yXhOi4M7+9FhZDPightkPxeJ2pUffkvBiV 6XyUZ2GvnlrVkVMEmeAOdUg8ArSlmh47TeSJ7Sv0tEmToDCi/dJMtb6WuG4zagAgOtRi UZeg== X-Forwarded-Encrypted: i=1; AJvYcCURQkdFZx6yoCvJ2YhOBY/FqvGCb2Q6aAp3xeyYJZx18nMS8o5aI9Wg52JtZk/W0L5SZAWGIw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxitFm54OXahKEp9gjRLxmO63VptfPnr6D5CrwFnu7ah7FU5FIH meOBjapA+Us+Dp68ttqzDrHnZuq7UZBz4yd3KLCy6mFu5/330gq9qy20uTUzxTzlgurmHPET09h hBG+HjPzLJQtfmvU/KmeOK0zZNcw= X-Gm-Gg: ASbGncu+CTa7EBrN3TGcZwL/76rPgYaZ4ActiuShZbWYPJlsnh9S6lBlUKoG9hn9ErV vekix+C6X6vxbtfspIexkU1Pq413yGeVLSf8ieze7pqvxckyHMKS1OT/8cyp2 X-Google-Smtp-Source: AGHT+IH8HgclXu1YVS3OU8xN7dL96nLTUwgcjzaOFB5BSk+8GJR7lO++ki12X0h17+s1QUrQ9u7oj/0jI05XuCU1X1s= X-Received: by 2002:a05:6402:278d:b0:5dc:106e:9b20 with SMTP id 4fb4d7f45d1cf-5dc106e9f8amr2356674a12.28.1737655590474; Thu, 23 Jan 2025 10:06:30 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 23 Jan 2025 12:06:30 -0600 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <87jzal63d6.fsf@HIDDEN> References: <87bjw3c3uf.fsf@HIDDEN> <87jzarcfqg.fsf@HIDDEN> <874j1t5zvr.fsf@HIDDEN> <87o701a1b3.fsf@HIDDEN> <87plkh19s7.fsf@HIDDEN> <87jzap9lpj.fsf@HIDDEN> <87r04xyt84.fsf@HIDDEN> <87frld9ink.fsf@HIDDEN> <87cyge8toe.fsf@HIDDEN> <868qr22hd9.fsf@HIDDEN> <87jzal63d6.fsf@HIDDEN> MIME-Version: 1.0 Date: Thu, 23 Jan 2025 12:06:30 -0600 X-Gm-Features: AWEUYZkYPfUPc0YzZiTWUVrIuivmTsH5U382AXFWj7QVgYsUxUXaPMqDlw-MWgU Message-ID: <CADwFkmnDaK0V1ACK=TCOrAVMA6jX-DitevGxhk_dadVbEiweow@HIDDEN> Subject: Re: bug#75655: configure doesn't update Makefile To: Pip Cet <pipcet@HIDDEN>, Eli Zaretskii <eliz@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75655 Cc: schwab@HIDDEN, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Pip Cet via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> writes: > If we can't remove the advice (the first case has already been made > unnecessary (commit 4939f58d2c45062d5eac3f4c845b4494cf113f1f); the > $(wildcard) proposal merely does the same thing for the second case), we > should, at least, recommend "git clean --interactive -dX" instead. > > -i rather than -f asks the user for confirmation; -X instead of -x will > avoid the unnecessary deletion of files we're almost certain are > valuable. This option and the "-d" option don't have long equivalents. > > Confirmed to work in this case. +1 I think the advice is occasionally useful, but making it safe is even better. At the very least, we should write in big bold letters to be careful with this command, but I'd prefer just changing it to the safe version as I fail to see any drawbacks.
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at 75655) by debbugs.gnu.org; 23 Jan 2025 17:50:37 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 23 12:50:37 2025 Received: from localhost ([127.0.0.1]:42225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tb1Lg-0003as-IL for submit <at> debbugs.gnu.org; Thu, 23 Jan 2025 12:50:36 -0500 Received: from mail-10631.protonmail.ch ([79.135.106.31]:21329) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <pipcet@HIDDEN>) id 1tb1Le-0003ae-3r for 75655 <at> debbugs.gnu.org; Thu, 23 Jan 2025 12:50:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1737654626; x=1737913826; bh=52TvyMSjpPS5SsYePv8klV0PryXL/LPsRYypYG8FHVI=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=rBjMprTHJFaKXrX9AvGuo3nWOHbJv0yhHDAepa+l8vZK/ACAGOUGyhePwyn1HUL1X 2mBSputN92JABAYfWq1p8pxH8WxXcA70Vg9xJYggF9VUORuZbZgZWld3Br27/HIBvg RnijLxa26pI+aTl/K3tvfpO60V92CJQtVSbbGSVWNYBSjBXZhO72ZzK+hHv+H0HjK6 fD8kpn+G2l7Jf9Tba3gou2YHfzrtgJ8r+/PL1HTvFddSa0mZCAHw5RXpGZFuAFh5/L l5GhtFDd3yfuTtXBM62QZU7DXHQwpv8rEnFZRSllsFtURpNTOnDu29iJcRK5/VCARx hDeuWlEIf+X0Q== Date: Thu, 23 Jan 2025 17:50:23 +0000 To: Eli Zaretskii <eliz@HIDDEN> From: Pip Cet <pipcet@HIDDEN> Subject: Re: bug#75655: configure doesn't update Makefile Message-ID: <877c6l4dyi.fsf@HIDDEN> In-Reply-To: <8634h91sc3.fsf@HIDDEN> References: <87bjw3c3uf.fsf@HIDDEN> <87plkh19s7.fsf@HIDDEN> <87jzap9lpj.fsf@HIDDEN> <87r04xyt84.fsf@HIDDEN> <87frld9ink.fsf@HIDDEN> <87cyge8toe.fsf@HIDDEN> <868qr22hd9.fsf@HIDDEN> <87jzal63d6.fsf@HIDDEN> <8634h91sc3.fsf@HIDDEN> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 5bb70d5e4a7fc887bd2ebeae8eda198abe242c5b MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75655 Cc: schwab@HIDDEN, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) "Eli Zaretskii" <eliz@HIDDEN> writes: >> Date: Thu, 23 Jan 2025 13:56:15 +0000 >> From: Pip Cet <pipcet@HIDDEN> >> Cc: schwab@HIDDEN, 75655 <at> debbugs.gnu.org >> >> The problem is that we might eventually push this to the master branch, >> and then it becomes a problem of switching between revisions, not >> branches. It'd effectively break "git bisect" if a directory is added >> in the bisection range. > > If you mean different builds from the same source tree, then I suggest > an out-of-tree builds. You use one source tree and several build For this problem, the behavior is even worse for out-of-tree builds: the problem occurs the same way, but one of the suggested fixes from INSTALL.REPO leaves you without a Makefile, and the other one won't work but will probably delete valuable data. > trees, each one configured differently. That is supported by the > current Makefiles. I meant "git bisect". The idea is that something changed between two revisions N revisions apart, and you test ceil(log2(N)) revisions until you find the (hopefully) single commit which broke things. That's tedious if N is large, and the only reason it's usable at all is that once we're down to a small-ish range, we can just run "make" and it'll either work or won't. If there's a directory-adding commit "near" the one we're trying to bisect to, we'll jump back and forth across it several times while bisecting, so we need to check each commit with a full git clean cycle. >> > My tendency is not to support these cases if the price is significant >> > complications in our Makefiles >> >> Using a wildcard is what we do for m4/*.m4, so my preference, given this >> constraint, would be to do the $(wildcard) thing. > > Like I said: if the changes don't cause complications, I won't object. Thanks for repeating that. Sorry I can't address the general git comments/"out of tree" builds in detail right now. I find git hard enough to use without committing changes so I don't actually push them (that one's confusing), and certainly won't use multiple clones. "Out of tree" builds are useless *to me* as long as they create thousands of files in the "source" tree; in this case, they make the problem worse. Pip
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at 75655) by debbugs.gnu.org; 23 Jan 2025 15:08:32 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 23 10:08:32 2025 Received: from localhost ([127.0.0.1]:41870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tayop-0003va-KE for submit <at> debbugs.gnu.org; Thu, 23 Jan 2025 10:08:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58536) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tayom-0003vE-6C for 75655 <at> debbugs.gnu.org; Thu, 23 Jan 2025 10:08:29 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tayoe-00060H-S1; Thu, 23 Jan 2025 10:08:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=D95Jv+WGWMT8Nh121GUwaqjfXUNO4CiL5hhpHm/1JYI=; b=m3Vcs28jseWI QxSQY62c2AQbw7p0mFZ5gYLUHpFavGOLGO8nhOYRjzq85/aZZIqO0lUOavXqXYRCTXfWWbiGL0D2F wG26rZQhFhWxb+sPkSNx9iW024KMK+w3f5I2HXGaPGzXHvKBgD6nNpwCOKe+zPxAdtKMcyWL4y6V6 FsOXtJ4rWWZBU2iLI+SjoudNUyO+pef2VjqTknntBPiPXwkLOtUyExug37byR4UBPhrrg/5y5tdMm wfeVlc8lbt+ZhuxMX7nKHXPNjYLaNvk5OAqWPBPtdzKQh02WAz40j1QyUVQ551gUqxMNRuW0ymPFW BZkwW3r8JierxsxtpsspaA==; Date: Thu, 23 Jan 2025 17:07:56 +0200 Message-Id: <8634h91sc3.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Pip Cet <pipcet@HIDDEN> In-Reply-To: <87jzal63d6.fsf@HIDDEN> (message from Pip Cet on Thu, 23 Jan 2025 13:56:15 +0000) Subject: Re: bug#75655: configure doesn't update Makefile References: <87bjw3c3uf.fsf@HIDDEN> <87jzarcfqg.fsf@HIDDEN> <874j1t5zvr.fsf@HIDDEN> <87o701a1b3.fsf@HIDDEN> <87plkh19s7.fsf@HIDDEN> <87jzap9lpj.fsf@HIDDEN> <87r04xyt84.fsf@HIDDEN> <87frld9ink.fsf@HIDDEN> <87cyge8toe.fsf@HIDDEN> <868qr22hd9.fsf@HIDDEN> <87jzal63d6.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75655 Cc: schwab@HIDDEN, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Thu, 23 Jan 2025 13:56:15 +0000 > From: Pip Cet <pipcet@HIDDEN> > Cc: schwab@HIDDEN, 75655 <at> debbugs.gnu.org > > The problem is that we might eventually push this to the master branch, > and then it becomes a problem of switching between revisions, not > branches. It'd effectively break "git bisect" if a directory is added > in the bisection range. If you mean different builds from the same source tree, then I suggest an out-of-tree builds. You use one source tree and several build trees, each one configured differently. That is supported by the current Makefiles. > > So my advice is to use separate directories for different branches. > > Git supports this even if you don't want to have separate clones > > (which is always a possibility): you can use "git worktree" commands. > > I have to use submodules; git submodule and git worktree don't work in > concert. (There are many other problems with it; my advice is not to > advise people to use "git worktree", as it's a poorly-implemented > command which should be used with great care). Then use separate clones. That's what I do. > > My tendency is not to support these cases if the price is significant > > complications in our Makefiles > > Using a wildcard is what we do for m4/*.m4, so my preference, given this > constraint, would be to do the $(wildcard) thing. Like I said: if the changes don't cause complications, I won't object. > However, I must confess I only just found the documentation at the end > of INSTALL.REPO, plainly advising developers to run "git clean -fdx" in > such cases, unconditionally destroying uncommitted changes and new > files. You should not have uncommitted changes, ever. Always either commit them (on a local branch if needed) or stash them. Keeping uncommitted changes runs the risk of pushing them inadvertently with unrelated changes (it happened to me and to others).
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at 75655) by debbugs.gnu.org; 23 Jan 2025 13:56:32 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 23 08:56:32 2025 Received: from localhost ([127.0.0.1]:39887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1taxh9-0008KW-K8 for submit <at> debbugs.gnu.org; Thu, 23 Jan 2025 08:56:32 -0500 Received: from mail-10631.protonmail.ch ([79.135.106.31]:11517) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <pipcet@HIDDEN>) id 1taxh4-0008KC-GD for 75655 <at> debbugs.gnu.org; Thu, 23 Jan 2025 08:56:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1737640579; x=1737899779; bh=y1LYJ23dTARGnTmWHzZwlnN5FSKyyOa+8WGFa1FfChQ=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=d1hlxr7sUeWzucuDQJpNlbj1QxoZGNu/YhyFFPL56vrJkYxs8PRHopkMZJa/TEurW EnoEHl/O96UDf3msHMYpCyoT11PJCJ/carbR4FQCp6AWDJ0zxLNvLq1z+vWf3vmvM4 PHUgpZ0vmEIYQDcjdCVqrYo9t+OAHIZpTZLXwGkXauKDzG5pN51I98d/FjtMeTY/kg MJ7Rke220I3JqN0L1mfgbYHO04/0cOr5yDAmiXoPXCxHCmlywxEPiKTuyVZRqz84zl zwg9eU88jE5zVhcbQjJr63fg4b8XqSH9RUvU2R3FStXzMuaqGZtxwX1MXl4zlt9UyA KCesWv5ExCt2w== Date: Thu, 23 Jan 2025 13:56:15 +0000 To: Eli Zaretskii <eliz@HIDDEN> From: Pip Cet <pipcet@HIDDEN> Subject: Re: bug#75655: configure doesn't update Makefile Message-ID: <87jzal63d6.fsf@HIDDEN> In-Reply-To: <868qr22hd9.fsf@HIDDEN> References: <87bjw3c3uf.fsf@HIDDEN> <87jzarcfqg.fsf@HIDDEN> <874j1t5zvr.fsf@HIDDEN> <87o701a1b3.fsf@HIDDEN> <87plkh19s7.fsf@HIDDEN> <87jzap9lpj.fsf@HIDDEN> <87r04xyt84.fsf@HIDDEN> <87frld9ink.fsf@HIDDEN> <87cyge8toe.fsf@HIDDEN> <868qr22hd9.fsf@HIDDEN> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 66719473e0c0795f97d673482a9f432cbeaf2bc5 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75655 Cc: schwab@HIDDEN, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) "Eli Zaretskii" <eliz@HIDDEN> writes: >> Cc: 75655 <at> debbugs.gnu.org >> Date: Wed, 22 Jan 2025 20:44:59 +0000 >> From: Pip Cet via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> >> >> I switch between revisions a lot, and it's not obvious how to fix this >> from the error message: > > My advice: don't switch Emacs branches in the same directory. Emacs Thanks! The problem is that we might eventually push this to the master branch, and then it becomes a problem of switching between revisions, not branches. It'd effectively break "git bisect" if a directory is added in the bisection range. > branches are usually quite divergent, and making our build machinery > 110% resistant to such switches would add complications that are > unjustified, especially since some dependencies are inherently hard to > track given the functionality of Make programs. Thanks. Some comments below. > Switching branches in the same directory only works well if the > branches are similar enough. Once you get to the situation where > directories and/or many files are being added/removed by one of the > branches (something that happens a lot here), problems begin that are > hard to fix using Make. > So my advice is to use separate directories for different branches. > Git supports this even if you don't want to have separate clones > (which is always a possibility): you can use "git worktree" commands. I have to use submodules; git submodule and git worktree don't work in concert. (There are many other problems with it; my advice is not to advise people to use "git worktree", as it's a poorly-implemented command which should be used with great care). About the "110%", "works well", etc: this case doesn't work at all. It produces an error message which only very vaguely hints at the real problem. The result will be that most users will start over with a fresh checkout, which almost certainly results in the loss of commits and other data once in a while. (While "git clean" works, it's hard to use it properly, too). I'm mostly concerned that "git bisect" will require a full "git clean" to test each revision while there are added directories in the branch, or fail mysteriously, meaning we'd incorrectly mark a good commit as bad. About the "hard to fix using Make": autogen.sh and configure also fail to fix this problem unless they're used precisely in one (apparently redundant) way. >> A third option would be to use the recipe I proposed, only instead of >> running config.status, we'd tell the user to, then fail the rule. > > My tendency is not to support these cases if the price is significant > complications in our Makefiles Using a wildcard is what we do for m4/*.m4, so my preference, given this constraint, would be to do the $(wildcard) thing. We can explain it with a comment in both places or neither, because wildcard prerequisites are usally a very bad idea and we should justify the exception. This would allow "make bootstrap" to work again, but wouldn't automatically detect the problem if a Makefile.in file was accidentally removed from the tree but not from configure.ac. > and/or redundant regenerations of files/targets (like loaddefs.el > etc.) that don't need to be regenerated. The $(wildcard) change would reduce rebuilds, sometimes skipping one which is arguably necessary, not increase them. The other patch I proposed would never cause extra rebuilds either, AFAICT. However, I must confess I only just found the documentation at the end of INSTALL.REPO, plainly advising developers to run "git clean -fdx" in such cases, unconditionally destroying uncommitted changes and new files. This is extremely dangerous advice! This is particularly true since we know that it is likely development work just happened in that directory. If we can't remove the advice (the first case has already been made unnecessary (commit 4939f58d2c45062d5eac3f4c845b4494cf113f1f); the $(wildcard) proposal merely does the same thing for the second case), we should, at least, recommend "git clean --interactive -dX" instead. -i rather than -f asks the user for confirmation; -X instead of -x will avoid the unnecessary deletion of files we're almost certain are valuable. This option and the "-d" option don't have long equivalents. Confirmed to work in this case. Pip
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at 75655) by debbugs.gnu.org; 23 Jan 2025 06:07:30 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 23 01:07:30 2025 Received: from localhost ([127.0.0.1]:38702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1taqNG-0006Vd-Dh for submit <at> debbugs.gnu.org; Thu, 23 Jan 2025 01:07:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49668) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1taqNC-0006VN-Gp for 75655 <at> debbugs.gnu.org; Thu, 23 Jan 2025 01:07:28 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1taqN5-00081V-NB; Thu, 23 Jan 2025 01:07:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=IEJId2+8F4i8KWCVbUJ47kXvvaegHeWpi0FKsKrZQNY=; b=K5ePF0nA7Co1 m3xmTCdRKLrLy4luAK3p30eBhuqkwy2JU49wmBrpsym0vbLsTLG1CK6e6Fe+i7lavf2xPhmqfuxmr XAenPd61hXIcdhd5zdoJKrX8ZReswvF8eyQUGQAf/lDNmmIlOFbZLMBpjOp7EvSXr+AmcJHkA3UJI o0HCjZDZYsLi6c7tds+AsC5tErkUx++GTK9etTXFsm4Kv1f07CMnDqh4pPip/akak2Pn7Pz+6nxzQ Sl1YqZPUc+kWZsto+grX5PdCjumexuO6x2nGn70v491Vs/Ds5Gt8gqqNVFHMh5QFR6xfCykF1fyi5 6oEs3YK7eWinsav7Fq0q5w==; Date: Thu, 23 Jan 2025 08:07:14 +0200 Message-Id: <868qr22hd9.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Pip Cet <pipcet@HIDDEN> In-Reply-To: <87cyge8toe.fsf@HIDDEN> (bug-gnu-emacs@HIDDEN) Subject: Re: bug#75655: configure doesn't update Makefile References: <87bjw3c3uf.fsf@HIDDEN> <87jzarcfqg.fsf@HIDDEN> <874j1t5zvr.fsf@HIDDEN> <87o701a1b3.fsf@HIDDEN> <87plkh19s7.fsf@HIDDEN> <87jzap9lpj.fsf@HIDDEN> <87r04xyt84.fsf@HIDDEN> <87frld9ink.fsf@HIDDEN> <87cyge8toe.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75655 Cc: schwab@HIDDEN, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: 75655 <at> debbugs.gnu.org > Date: Wed, 22 Jan 2025 20:44:59 +0000 > From: Pip Cet via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > I switch between revisions a lot, and it's not obvious how to fix this > from the error message: My advice: don't switch Emacs branches in the same directory. Emacs branches are usually quite divergent, and making our build machinery 110% resistant to such switches would add complications that are unjustified, especially since some dependencies are inherently hard to track given the functionality of Make programs. Switching branches in the same directory only works well if the branches are similar enough. Once you get to the situation where directories and/or many files are being added/removed by one of the branches (something that happens a lot here), problems begin that are hard to fix using Make. So my advice is to use separate directories for different branches. Git supports this even if you don't want to have separate clones (which is always a possibility): you can use "git worktree" commands. > A third option would be to use the recipe I proposed, only instead of > running config.status, we'd tell the user to, then fail the rule. My tendency is not to support these cases if the price is significant complications in our Makefiles and/or redundant regenerations of files/targets (like loaddefs.el etc.) that don't need to be regenerated.
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at 75655) by debbugs.gnu.org; 22 Jan 2025 20:45:14 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 22 15:45:14 2025 Received: from localhost ([127.0.0.1]:36756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tahb8-0008GE-0Z for submit <at> debbugs.gnu.org; Wed, 22 Jan 2025 15:45:14 -0500 Received: from mail-10630.protonmail.ch ([79.135.106.30]:21521) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <pipcet@HIDDEN>) id 1tahb4-0008BW-Ql for 75655 <at> debbugs.gnu.org; Wed, 22 Jan 2025 15:45:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1737578704; x=1737837904; bh=Bk2r70Ty7JA3PgkgXptR9e+TAV1QSeZDL/Y9u/zXwxc=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=lx9UQFdENC8d21zXc7Bu5iaT3HdMkKu9WRTD/0QKV4gWY+SY953HdM4T+K38CJjBl Ho2Ec45Uu8Cc3Y5Nnd8/7eeEeIQ1wuFky3PdT9HmrM/rhseQyP93v22T7K+tvt9Mzd WphLh/aymINSvwC3/lDp6ZEI2vfFbtmFZxOaW/87DwGzLV7Vjl3sLDZN3CNHoK5CYX geC2njJGJHiUEVUANUZO6LXiH50yI7KdsRmD5YA9rNDzgVJoOvGz9gVeZT1EDQtwpS URsqZE9URM3GcrhrluHX0L6LYSdIXU2TB6Kt/CTDHYBcfdYybeOW1etSD028gcsbUi hMW0X0iqd1RpQ== Date: Wed, 22 Jan 2025 20:44:59 +0000 To: Andreas Schwab <schwab@HIDDEN> From: Pip Cet <pipcet@HIDDEN> Subject: Re: bug#75655: configure doesn't update Makefile Message-ID: <87cyge8toe.fsf@HIDDEN> In-Reply-To: <87frld9ink.fsf@HIDDEN> References: <87bjw3c3uf.fsf@HIDDEN> <87jzarcfqg.fsf@HIDDEN> <874j1t5zvr.fsf@HIDDEN> <87o701a1b3.fsf@HIDDEN> <87plkh19s7.fsf@HIDDEN> <87jzap9lpj.fsf@HIDDEN> <87r04xyt84.fsf@HIDDEN> <87frld9ink.fsf@HIDDEN> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 40266796a33650f30e9b98d0362614f2904bb5c9 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75655 Cc: "Pip Cet via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\"" <bug-gnu-emacs@HIDDEN>, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) "Andreas Schwab" <schwab@HIDDEN> writes: > On Jan 20 2025, Pip Cet wrote: > >> If it is, I'm confused because the target $@ of this rule is, in my >> case, benchmark/Makefile.in. > > If config.status cannot create that file then it is not the right > command to create it. That's a tautology, yes :-) I think it is perfectly permissible to rebuild the Makefile and return without making the target if there is good reason to believe that the rule was invoked as a prerequisite for building the Makefile. I don't think there is a way to check whether that's true; maybe there should be. The only real alternative I see is to use $(wildcard) and depend only on those Makefile.in files which still exist. While I've always been told to avoid wildcard prerequisites, we do so in this Makefile anyway, and it seems to work. I switch between revisions a lot, and it's not obvious how to fix this from the error message: bisecting would be much harder if we insisted on a full git clean for every iteration. I suppose the problem isn't that great because new directories aren't created that often. Still, I'd hate to leave it unfixed. A third option would be to use the recipe I proposed, only instead of running config.status, we'd tell the user to, then fail the rule. Pip
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 22 Jan 2025 20:45:28 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 22 15:45:28 2025 Received: from localhost ([127.0.0.1]:36760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tahbL-0008Gl-K4 for submit <at> debbugs.gnu.org; Wed, 22 Jan 2025 15:45:28 -0500 Received: from lists.gnu.org ([2001:470:142::17]:48154) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <pipcet@HIDDEN>) id 1tahbA-0008Fy-Gg for submit <at> debbugs.gnu.org; Wed, 22 Jan 2025 15:45:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <pipcet@HIDDEN>) id 1tahb4-0003FL-0p for bug-gnu-emacs@HIDDEN; Wed, 22 Jan 2025 15:45:10 -0500 Received: from mail-10630.protonmail.ch ([79.135.106.30]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <pipcet@HIDDEN>) id 1tahb1-0003Yk-75 for bug-gnu-emacs@HIDDEN; Wed, 22 Jan 2025 15:45:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1737578704; x=1737837904; bh=Bk2r70Ty7JA3PgkgXptR9e+TAV1QSeZDL/Y9u/zXwxc=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=lx9UQFdENC8d21zXc7Bu5iaT3HdMkKu9WRTD/0QKV4gWY+SY953HdM4T+K38CJjBl Ho2Ec45Uu8Cc3Y5Nnd8/7eeEeIQ1wuFky3PdT9HmrM/rhseQyP93v22T7K+tvt9Mzd WphLh/aymINSvwC3/lDp6ZEI2vfFbtmFZxOaW/87DwGzLV7Vjl3sLDZN3CNHoK5CYX geC2njJGJHiUEVUANUZO6LXiH50yI7KdsRmD5YA9rNDzgVJoOvGz9gVeZT1EDQtwpS URsqZE9URM3GcrhrluHX0L6LYSdIXU2TB6Kt/CTDHYBcfdYybeOW1etSD028gcsbUi hMW0X0iqd1RpQ== Date: Wed, 22 Jan 2025 20:44:59 +0000 To: Andreas Schwab <schwab@HIDDEN> From: Pip Cet <pipcet@HIDDEN> Subject: Re: bug#75655: configure doesn't update Makefile Message-ID: <87cyge8toe.fsf@HIDDEN> In-Reply-To: <87frld9ink.fsf@HIDDEN> References: <87bjw3c3uf.fsf@HIDDEN> <87jzarcfqg.fsf@HIDDEN> <874j1t5zvr.fsf@HIDDEN> <87o701a1b3.fsf@HIDDEN> <87plkh19s7.fsf@HIDDEN> <87jzap9lpj.fsf@HIDDEN> <87r04xyt84.fsf@HIDDEN> <87frld9ink.fsf@HIDDEN> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 40266796a33650f30e9b98d0362614f2904bb5c9 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=79.135.106.30; envelope-from=pipcet@HIDDEN; helo=mail-10630.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: "Pip Cet via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\"" <bug-gnu-emacs@HIDDEN>, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) "Andreas Schwab" <schwab@HIDDEN> writes: > On Jan 20 2025, Pip Cet wrote: > >> If it is, I'm confused because the target $@ of this rule is, in my >> case, benchmark/Makefile.in. > > If config.status cannot create that file then it is not the right > command to create it. That's a tautology, yes :-) I think it is perfectly permissible to rebuild the Makefile and return without making the target if there is good reason to believe that the rule was invoked as a prerequisite for building the Makefile. I don't think there is a way to check whether that's true; maybe there should be. The only real alternative I see is to use $(wildcard) and depend only on those Makefile.in files which still exist. While I've always been told to avoid wildcard prerequisites, we do so in this Makefile anyway, and it seems to work. I switch between revisions a lot, and it's not obvious how to fix this from the error message: bisecting would be much harder if we insisted on a full git clean for every iteration. I suppose the problem isn't that great because new directories aren't created that often. Still, I'd hate to leave it unfixed. A third option would be to use the recipe I proposed, only instead of running config.status, we'd tell the user to, then fail the rule. Pip
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 21 Jan 2025 00:02:32 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 20 19:02:31 2025 Received: from localhost ([127.0.0.1]:52286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ta1ix-0002af-9b for submit <at> debbugs.gnu.org; Mon, 20 Jan 2025 19:02:31 -0500 Received: from lists.gnu.org ([2001:470:142::17]:43108) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <pipcet@HIDDEN>) id 1ta1iu-0002aD-NJ for submit <at> debbugs.gnu.org; Mon, 20 Jan 2025 19:02:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <pipcet@HIDDEN>) id 1tZysA-0000zr-BY for bug-gnu-emacs@HIDDEN; Mon, 20 Jan 2025 15:59:50 -0500 Received: from mail-4316.protonmail.ch ([185.70.43.16]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <pipcet@HIDDEN>) id 1tZys8-0002Mq-6N for bug-gnu-emacs@HIDDEN; Mon, 20 Jan 2025 15:59:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1737406785; x=1737665985; bh=voPQfk1D7MX14dsadNddXz8aRuLiCd4eMUiWkCs4JhA=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=cdcygzk/fO3rtMUzZ7uhNaaN1EYyqTg9Gmo+Zhd0JJw1r6IgPr1GyUp4yhmbjZ8uJ uQCPJAktelyuNSvRNHuyw04xQ5VBvo3j6kzjZYGgj8iDkfsdKqd+K5IIL8jQDwtnuZ whUhkJplMEKK16qvTzYpbR+uK9R7h9fRWJWiOkX6rPuJgdAZZyfkteWQQVfU96XbrQ sUviYx2fRV33RmNGXhhYxykNFir4ZoYiLAYlXHOSEKFm4IkjMtCJMJTg66dOBYg/Wb I7Yh4IPBbG6PsM1Uuz52dDgnzwH5HQLwf9khvayq932+iq6Q5UoQbbFe9Q4rqACtDS vpjzyHgOgAQjg== Date: Mon, 20 Jan 2025 20:59:42 +0000 To: Andreas Schwab <schwab@HIDDEN> From: Pip Cet <pipcet@HIDDEN> Subject: Re: bug#75655: configure doesn't update Makefile Message-ID: <87plkh19s7.fsf@HIDDEN> In-Reply-To: <87o701a1b3.fsf@HIDDEN> References: <87bjw3c3uf.fsf@HIDDEN> <87jzarcfqg.fsf@HIDDEN> <874j1t5zvr.fsf@HIDDEN> <87o701a1b3.fsf@HIDDEN> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 7119a5223d424f502ccbeb00b689a1a6f05369c5 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.43.16; envelope-from=pipcet@HIDDEN; helo=mail-4316.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: "Pip Cet via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\"" <bug-gnu-emacs@HIDDEN>, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) "Andreas Schwab" <schwab@HIDDEN> writes: > On Jan 20 2025, Pip Cet wrote: > >> I believe that needs an additional order-only prerequisite >> (config.status) to work properly in parallel make: calling config.status >> twice in parallel seems like a very bad idea. And, of course, a comment >> explaining it. > > The right way to solve this is to tell config.status to only update the > current target. Do you mean "./config.status --recheck", or "MAKE=3D'$(MAKE)' ./config.status"? I may be being very dense, but the second one is never run so modifying it won't fix the problem. The first one is run, but doesn't modify Makefile. That is right and proper, and I don't see how modifying it to update "only the current target" (i.e. config.status itself) would help things in any way. Here's what I'm currently planning to insert into the Makefile: # We attempted to use a Makefile.in, but it doesn't exist. Most likely, # we were configured in a different tree which uses a different set of # Makefile.in files, and then the git branch was changed: in that case, # wait for config.status to be rebuilt and run it. Then return without # generating the target: make will reload the new Makefile and the # problem will have resolved itself. # # If the Makefile.in was accidentally deleted, config.status will fail # with an error message indicating this to the user, and make will # terminate. $(SUBDIR_MAKEFILES_IN) $(CONFIG_STATUS_FILES_IN): | config.status =09MAKE=3D'$(MAKE)' ./config.status This doesn't work if "make -B" is used, but the current Makefile also fails in that case. In all other cases I've found, this does the right thing. Pip
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 21 Jan 2025 00:00:01 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 20 19:00:01 2025 Received: from localhost ([127.0.0.1]:52269 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ta1gX-0002Ns-3J for submit <at> debbugs.gnu.org; Mon, 20 Jan 2025 19:00:01 -0500 Received: from lists.gnu.org ([2001:470:142::17]:57482) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <whitebox@HIDDEN>) id 1ta1gV-0002NU-4E for submit <at> debbugs.gnu.org; Mon, 20 Jan 2025 19:00:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <whitebox@HIDDEN>) id 1ta14h-0006HN-55 for bug-gnu-emacs@HIDDEN; Mon, 20 Jan 2025 18:20:55 -0500 Received: from mail-out.m-online.net ([212.18.0.10]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <whitebox@HIDDEN>) id 1ta14e-0008I8-Uv for bug-gnu-emacs@HIDDEN; Mon, 20 Jan 2025 18:20:54 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4YcRCj0LSYz1s953; Tue, 21 Jan 2025 00:20:48 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 4YcRCh4y3nz1qqlW; Tue, 21 Jan 2025 00:20:48 +0100 (CET) X-Virus-Scanned: amavis at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavis, port 10024) with ESMTP id MnU11ZQ-Gt8h; Tue, 21 Jan 2025 00:20:48 +0100 (CET) X-Auth-Info: yPzUxOFX89NObYSF8aMLEZ5hFFFpLRRyHRl9EnObH/4j+cgDW9r+oHz29aB8NpDa Received: from igel.home (aftr-82-135-83-171.dynamic.mnet-online.de [82.135.83.171]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 21 Jan 2025 00:20:47 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id A72A02C19A4; Tue, 21 Jan 2025 00:20:47 +0100 (CET) From: Andreas Schwab <schwab@HIDDEN> To: Pip Cet <pipcet@HIDDEN> Subject: Re: bug#75655: configure doesn't update Makefile In-Reply-To: <87r04xyt84.fsf@HIDDEN> (Pip Cet's message of "Mon, 20 Jan 2025 23:13:20 +0000") References: <87bjw3c3uf.fsf@HIDDEN> <87jzarcfqg.fsf@HIDDEN> <874j1t5zvr.fsf@HIDDEN> <87o701a1b3.fsf@HIDDEN> <87plkh19s7.fsf@HIDDEN> <87jzap9lpj.fsf@HIDDEN> <87r04xyt84.fsf@HIDDEN> Date: Tue, 21 Jan 2025 00:20:47 +0100 Message-ID: <87frld9ink.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=212.18.0.10; envelope-from=whitebox@HIDDEN; helo=mail-out.m-online.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: "Pip Cet via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\"" <bug-gnu-emacs@HIDDEN>, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) On Jan 20 2025, Pip Cet wrote: > If it is, I'm confused because the target $@ of this rule is, in my > case, benchmark/Makefile.in. If config.status cannot create that file then it is not the right command to create it. -- Andreas Schwab, schwab@HIDDEN GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.
Received: (at 75655) by debbugs.gnu.org; 20 Jan 2025 23:53:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 20 18:53:14 2025
Received: from localhost ([127.0.0.1]:52246 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ta1Zy-00025d-Js
for submit <at> debbugs.gnu.org; Mon, 20 Jan 2025 18:53:14 -0500
Received: from mail-out.m-online.net ([2001:a60:0:28:0:1:25:1]:54929)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <whitebox@HIDDEN>)
id 1ta1Zv-00025S-3K
for 75655 <at> debbugs.gnu.org; Mon, 20 Jan 2025 18:53:13 -0500
Received: from frontend01.mail.m-online.net (unknown [192.168.8.182])
by mail-out.m-online.net (Postfix) with ESMTP id 4YcPlZ4q5mz1sBpn;
Mon, 20 Jan 2025 23:14:49 +0100 (CET)
Received: from localhost (dynscan1.mnet-online.de [192.168.6.68])
by mail.m-online.net (Postfix) with ESMTP id 4YcPlY1XHCz1qqlS;
Mon, 20 Jan 2025 23:14:49 +0100 (CET)
X-Virus-Scanned: amavis at mnet-online.de
Received: from mail.mnet-online.de ([192.168.8.182])
by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavis, port 10024)
with ESMTP id S57O4omoM-yk; Mon, 20 Jan 2025 23:14:48 +0100 (CET)
X-Auth-Info: iCo7ZpooexBaTppfiCmv8wdM+BjqOfV26BmnJOkkUNQKrnOpryUuxLYRWjxl6dCN
Received: from igel.home (aftr-82-135-83-171.dynamic.mnet-online.de
[82.135.83.171])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by mail.mnet-online.de (Postfix) with ESMTPSA;
Mon, 20 Jan 2025 23:14:48 +0100 (CET)
Received: by igel.home (Postfix, from userid 1000)
id 430DB2C19A0; Mon, 20 Jan 2025 23:14:48 +0100 (CET)
From: Andreas Schwab <schwab@HIDDEN>
To: Pip Cet <pipcet@HIDDEN>
Subject: Re: bug#75655: configure doesn't update Makefile
In-Reply-To: <87plkh19s7.fsf@HIDDEN> (Pip Cet's message of "Mon, 20
Jan 2025 20:59:42 +0000")
References: <87bjw3c3uf.fsf@HIDDEN> <87jzarcfqg.fsf@HIDDEN>
<874j1t5zvr.fsf@HIDDEN> <87o701a1b3.fsf@HIDDEN>
<87plkh19s7.fsf@HIDDEN>
Date: Mon, 20 Jan 2025 23:14:48 +0100
Message-ID: <87jzap9lpj.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 75655
Cc: "Pip Cet via \"Bug reports for GNU Emacs, the Swiss army knife of text
editors\"" <bug-gnu-emacs@HIDDEN>, 75655 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
On Jan 20 2025, Pip Cet wrote:
> "Andreas Schwab" <schwab@HIDDEN> writes:
>
>> On Jan 20 2025, Pip Cet wrote:
>>
>>> I believe that needs an additional order-only prerequisite
>>> (config.status) to work properly in parallel make: calling config.status
>>> twice in parallel seems like a very bad idea. And, of course, a comment
>>> explaining it.
>>
>> The right way to solve this is to tell config.status to only update the
>> current target.
>
> Do you mean "./config.status --recheck", or "MAKE='$(MAKE)'
> ./config.status"?
$ ./config.status --help
[...]
--file=FILE[:TEMPLATE]
instantiate the configuration file FILE
--header=FILE[:TEMPLATE]
instantiate the configuration header FILE
[...]
--
Andreas Schwab, schwab@HIDDEN
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 20 Jan 2025 23:30:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 20 18:30:05 2025
Received: from localhost ([127.0.0.1]:52059 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ta1DX-0000nl-Uy
for submit <at> debbugs.gnu.org; Mon, 20 Jan 2025 18:30:05 -0500
Received: from lists.gnu.org ([2001:470:142::17]:34896)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <pipcet@HIDDEN>)
id 1ta1DT-0000mN-TY
for submit <at> debbugs.gnu.org; Mon, 20 Jan 2025 18:30:00 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <pipcet@HIDDEN>)
id 1ta0xW-0005RE-Bs
for bug-gnu-emacs@HIDDEN; Mon, 20 Jan 2025 18:13:30 -0500
Received: from mail-4316.protonmail.ch ([185.70.43.16])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <pipcet@HIDDEN>)
id 1ta0xU-0007Ru-5p
for bug-gnu-emacs@HIDDEN; Mon, 20 Jan 2025 18:13:30 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
s=protonmail3; t=1737414805; x=1737674005;
bh=4anJPt9bHJq13D1LX0pO9/l+EjZklz80KoHTj1DVnAE=;
h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;
b=fBq5ESinQT6AAn8SXCumkyG7uOiwNFQHY8XU1J5NZk6POjxXb4a5gtkpAXHks93mi
77d75zqtmu4KAQTt+tdNGlCVc2BOxgt+vbW1MOtRbujjmZ2qlNPQdhjn4NkKvcEHd4
1ds0YeN5lpJNCOoqnwdmDGxG7tqk6hepSIwtyOHckz4eoQkAlv1p1lobop22rsm/zL
fsfk6INOSt4+hIEKe4dje43wiuUcd5HYtfNv225voDfXF5CPJKwn6WyWpdgnxK8zrm
9VTA+kcRr1aJZrUcXTVvUR1K1JgYo3eyyr69eZI5sdNu4xU8m1KYDc5i6uLTTuSKXz
ExFE0tk4VEtdQ==
Date: Mon, 20 Jan 2025 23:13:20 +0000
To: Andreas Schwab <schwab@HIDDEN>
From: Pip Cet <pipcet@HIDDEN>
Subject: Re: bug#75655: configure doesn't update Makefile
Message-ID: <87r04xyt84.fsf@HIDDEN>
In-Reply-To: <87jzap9lpj.fsf@HIDDEN>
References: <87bjw3c3uf.fsf@HIDDEN> <87jzarcfqg.fsf@HIDDEN>
<874j1t5zvr.fsf@HIDDEN> <87o701a1b3.fsf@HIDDEN>
<87plkh19s7.fsf@HIDDEN> <87jzap9lpj.fsf@HIDDEN>
Feedback-ID: 112775352:user:proton
X-Pm-Message-ID: 9a131ea38a560b7da4a911b236aeedada4d03fbe
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=185.70.43.16; envelope-from=pipcet@HIDDEN;
helo=mail-4316.protonmail.ch
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
Cc: "Pip Cet via \"Bug reports for GNU Emacs,
the Swiss army knife of text editors\"" <bug-gnu-emacs@HIDDEN>,
75655 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
"Andreas Schwab" <schwab@HIDDEN> writes:
> On Jan 20 2025, Pip Cet wrote:
>
>> "Andreas Schwab" <schwab@HIDDEN> writes:
>>
>>> On Jan 20 2025, Pip Cet wrote:
>>>
>>>> I believe that needs an additional order-only prerequisite
>>>> (config.status) to work properly in parallel make: calling config.stat=
us
>>>> twice in parallel seems like a very bad idea. And, of course, a comme=
nt
>>>> explaining it.
>>>
>>> The right way to solve this is to tell config.status to only update the
>>> current target.
I'm sorry, I misread your message at first. Let me summarize it to make
sure I got it right:
One problem with the first solution I proposed:
$(SUBDIR_MAKEFILES_IN) $(CONFIG_STATUS_FILES_IN):
=09MAKE=3D'$(MAKE)' ./config.status
is that config.status may be run before, or while, it is being built
(either by configure, or by config.status --recheck);
this won't happen with ordinary "make", but "make -j" would do the
trick.
My proposal was to use an order-only prerequisite:
$(SUBDIR_MAKEFILES_IN) $(CONFIG_STATUS_FILES_IN): | config.status
=09MAKE=3D'$(MAKE)' ./config.status
This fixes the problem if there is a single Makefile.in that we're
trying to rebuild, but if more than one Makefile.in simultaneously goes
missing, config.status might be run twice by this code, in parallel.
This can happen and produces confusing output, but I'm not sure it
causes errors: at first glance, config.status appears to create a
temporary new file and move it to "Makefile" atomically.
Your proposal is to modify the line
MAKE=3D'$(MAKE)' ./config.status
so it builds only the current target $@ of this rule.
Is that accurate so far?
If it is, I'm confused because the target $@ of this rule is, in my
case, benchmark/Makefile.in.
That file does not exist before the rule is executed, and it is not
created by the rule: the effect of the rule is to regenerate "Makefile",
which make will notice and reload the Makefile. The "target" merely
indicates which file was missing and made us decide to recreate the
Makefile. The new Makefile will hopefully no longer refer to the
"target" and work.
Did you mean we restrict config.status to generate only Makefile?
As far as I can tell, that modification works, and it saves some output
and presumably some CPU cycles, but it still means we'll invoke
=09MAKE=3D'$(MAKE)' ./config.status --file=3DMakefile
twice for "make -j" if two of the targets are missing.
So I'm not sure what you are suggesting. My best guess is that you're
suggesting we somehow pick a single one of the rule's prerequisites
which will cause config.status to run, and ignore all others. Is that
correct?
MISSING_MAKEFILE_IN :=3D $(firstword $(filter-out $(addprefix ./,$(wildcard=
$(SUBDIR_MAKEFILES_IN))),$(SUBDIR_MAKEFILES_IN)))
$(SUBDIR_MAKEFILES_IN) $(CONFIG_STATUS_FILES_IN): | config.status
=09if [ ./"$@" =3D "$(MISSING_MAKEFILE_IN)" ]; then sleep 1m; MAKE=3D'$(MAK=
E)' ./config.status; fi
appears to work, at least, but I don't know what to replace ./ by.
Pip
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 20 Jan 2025 23:29:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 20 18:29:56 2025
Received: from localhost ([127.0.0.1]:52053 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ta1DQ-0000mP-IO
for submit <at> debbugs.gnu.org; Mon, 20 Jan 2025 18:29:56 -0500
Received: from lists.gnu.org ([2001:470:142::17]:34880)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <whitebox@HIDDEN>)
id 1ta1DN-0000m8-LH
for submit <at> debbugs.gnu.org; Mon, 20 Jan 2025 18:29:54 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <whitebox@HIDDEN>)
id 1ta02q-0004So-AE
for bug-gnu-emacs@HIDDEN; Mon, 20 Jan 2025 17:14:56 -0500
Received: from mail-out.m-online.net ([212.18.0.10])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <whitebox@HIDDEN>)
id 1ta02n-0000YZ-SI
for bug-gnu-emacs@HIDDEN; Mon, 20 Jan 2025 17:14:55 -0500
Received: from frontend01.mail.m-online.net (unknown [192.168.8.182])
by mail-out.m-online.net (Postfix) with ESMTP id 4YcPlZ4q5mz1sBpn;
Mon, 20 Jan 2025 23:14:49 +0100 (CET)
Received: from localhost (dynscan1.mnet-online.de [192.168.6.68])
by mail.m-online.net (Postfix) with ESMTP id 4YcPlY1XHCz1qqlS;
Mon, 20 Jan 2025 23:14:49 +0100 (CET)
X-Virus-Scanned: amavis at mnet-online.de
Received: from mail.mnet-online.de ([192.168.8.182])
by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavis, port 10024)
with ESMTP id S57O4omoM-yk; Mon, 20 Jan 2025 23:14:48 +0100 (CET)
X-Auth-Info: iCo7ZpooexBaTppfiCmv8wdM+BjqOfV26BmnJOkkUNQKrnOpryUuxLYRWjxl6dCN
Received: from igel.home (aftr-82-135-83-171.dynamic.mnet-online.de
[82.135.83.171])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by mail.mnet-online.de (Postfix) with ESMTPSA;
Mon, 20 Jan 2025 23:14:48 +0100 (CET)
Received: by igel.home (Postfix, from userid 1000)
id 430DB2C19A0; Mon, 20 Jan 2025 23:14:48 +0100 (CET)
From: Andreas Schwab <schwab@HIDDEN>
To: Pip Cet <pipcet@HIDDEN>
Subject: Re: bug#75655: configure doesn't update Makefile
In-Reply-To: <87plkh19s7.fsf@HIDDEN> (Pip Cet's message of "Mon, 20
Jan 2025 20:59:42 +0000")
References: <87bjw3c3uf.fsf@HIDDEN> <87jzarcfqg.fsf@HIDDEN>
<874j1t5zvr.fsf@HIDDEN> <87o701a1b3.fsf@HIDDEN>
<87plkh19s7.fsf@HIDDEN>
Date: Mon, 20 Jan 2025 23:14:48 +0100
Message-ID: <87jzap9lpj.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=212.18.0.10; envelope-from=whitebox@HIDDEN;
helo=mail-out.m-online.net
X-Spam_score_int: -25
X-Spam_score: -2.6
X-Spam_bar: --
X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9,
HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_LOW=-0.7,
RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
Cc: "Pip Cet via \"Bug reports for GNU Emacs, the Swiss army knife of text
editors\"" <bug-gnu-emacs@HIDDEN>, 75655 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
On Jan 20 2025, Pip Cet wrote:
> "Andreas Schwab" <schwab@HIDDEN> writes:
>
>> On Jan 20 2025, Pip Cet wrote:
>>
>>> I believe that needs an additional order-only prerequisite
>>> (config.status) to work properly in parallel make: calling config.status
>>> twice in parallel seems like a very bad idea. And, of course, a comment
>>> explaining it.
>>
>> The right way to solve this is to tell config.status to only update the
>> current target.
>
> Do you mean "./config.status --recheck", or "MAKE='$(MAKE)'
> ./config.status"?
$ ./config.status --help
[...]
--file=FILE[:TEMPLATE]
instantiate the configuration file FILE
--header=FILE[:TEMPLATE]
instantiate the configuration header FILE
[...]
--
Andreas Schwab, schwab@HIDDEN
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at 75655) by debbugs.gnu.org; 20 Jan 2025 23:28:14 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 20 18:28:14 2025 Received: from localhost ([127.0.0.1]:52048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ta1Bl-0000jg-VP for submit <at> debbugs.gnu.org; Mon, 20 Jan 2025 18:28:14 -0500 Received: from mail-out.m-online.net ([2001:a60:0:28:0:1:25:1]:35943) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <whitebox@HIDDEN>) id 1ta1Bh-0000jN-08 for 75655 <at> debbugs.gnu.org; Mon, 20 Jan 2025 18:28:09 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4YcRCj0LSYz1s953; Tue, 21 Jan 2025 00:20:48 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 4YcRCh4y3nz1qqlW; Tue, 21 Jan 2025 00:20:48 +0100 (CET) X-Virus-Scanned: amavis at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavis, port 10024) with ESMTP id MnU11ZQ-Gt8h; Tue, 21 Jan 2025 00:20:48 +0100 (CET) X-Auth-Info: yPzUxOFX89NObYSF8aMLEZ5hFFFpLRRyHRl9EnObH/4j+cgDW9r+oHz29aB8NpDa Received: from igel.home (aftr-82-135-83-171.dynamic.mnet-online.de [82.135.83.171]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 21 Jan 2025 00:20:47 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id A72A02C19A4; Tue, 21 Jan 2025 00:20:47 +0100 (CET) From: Andreas Schwab <schwab@HIDDEN> To: Pip Cet <pipcet@HIDDEN> Subject: Re: bug#75655: configure doesn't update Makefile In-Reply-To: <87r04xyt84.fsf@HIDDEN> (Pip Cet's message of "Mon, 20 Jan 2025 23:13:20 +0000") References: <87bjw3c3uf.fsf@HIDDEN> <87jzarcfqg.fsf@HIDDEN> <874j1t5zvr.fsf@HIDDEN> <87o701a1b3.fsf@HIDDEN> <87plkh19s7.fsf@HIDDEN> <87jzap9lpj.fsf@HIDDEN> <87r04xyt84.fsf@HIDDEN> Date: Tue, 21 Jan 2025 00:20:47 +0100 Message-ID: <87frld9ink.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75655 Cc: "Pip Cet via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\"" <bug-gnu-emacs@HIDDEN>, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On Jan 20 2025, Pip Cet wrote: > If it is, I'm confused because the target $@ of this rule is, in my > case, benchmark/Makefile.in. If config.status cannot create that file then it is not the right command to create it. -- Andreas Schwab, schwab@HIDDEN GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at 75655) by debbugs.gnu.org; 20 Jan 2025 23:26:56 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 20 18:26:56 2025 Received: from localhost ([127.0.0.1]:52031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ta1AW-0000gE-2w for submit <at> debbugs.gnu.org; Mon, 20 Jan 2025 18:26:56 -0500 Received: from mail-41104.protonmail.ch ([185.70.41.104]:47031) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <pipcet@HIDDEN>) id 1ta1AT-0000g0-Ca for 75655 <at> debbugs.gnu.org; Mon, 20 Jan 2025 18:26:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1737406785; x=1737665985; bh=voPQfk1D7MX14dsadNddXz8aRuLiCd4eMUiWkCs4JhA=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=cdcygzk/fO3rtMUzZ7uhNaaN1EYyqTg9Gmo+Zhd0JJw1r6IgPr1GyUp4yhmbjZ8uJ uQCPJAktelyuNSvRNHuyw04xQ5VBvo3j6kzjZYGgj8iDkfsdKqd+K5IIL8jQDwtnuZ whUhkJplMEKK16qvTzYpbR+uK9R7h9fRWJWiOkX6rPuJgdAZZyfkteWQQVfU96XbrQ sUviYx2fRV33RmNGXhhYxykNFir4ZoYiLAYlXHOSEKFm4IkjMtCJMJTg66dOBYg/Wb I7Yh4IPBbG6PsM1Uuz52dDgnzwH5HQLwf9khvayq932+iq6Q5UoQbbFe9Q4rqACtDS vpjzyHgOgAQjg== Date: Mon, 20 Jan 2025 20:59:42 +0000 To: Andreas Schwab <schwab@HIDDEN> From: Pip Cet <pipcet@HIDDEN> Subject: Re: bug#75655: configure doesn't update Makefile Message-ID: <87plkh19s7.fsf@HIDDEN> In-Reply-To: <87o701a1b3.fsf@HIDDEN> References: <87bjw3c3uf.fsf@HIDDEN> <87jzarcfqg.fsf@HIDDEN> <874j1t5zvr.fsf@HIDDEN> <87o701a1b3.fsf@HIDDEN> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 7119a5223d424f502ccbeb00b689a1a6f05369c5 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75655 Cc: "Pip Cet via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\"" <bug-gnu-emacs@HIDDEN>, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) "Andreas Schwab" <schwab@HIDDEN> writes: > On Jan 20 2025, Pip Cet wrote: > >> I believe that needs an additional order-only prerequisite >> (config.status) to work properly in parallel make: calling config.status >> twice in parallel seems like a very bad idea. And, of course, a comment >> explaining it. > > The right way to solve this is to tell config.status to only update the > current target. Do you mean "./config.status --recheck", or "MAKE=3D'$(MAKE)' ./config.status"? I may be being very dense, but the second one is never run so modifying it won't fix the problem. The first one is run, but doesn't modify Makefile. That is right and proper, and I don't see how modifying it to update "only the current target" (i.e. config.status itself) would help things in any way. Here's what I'm currently planning to insert into the Makefile: # We attempted to use a Makefile.in, but it doesn't exist. Most likely, # we were configured in a different tree which uses a different set of # Makefile.in files, and then the git branch was changed: in that case, # wait for config.status to be rebuilt and run it. Then return without # generating the target: make will reload the new Makefile and the # problem will have resolved itself. # # If the Makefile.in was accidentally deleted, config.status will fail # with an error message indicating this to the user, and make will # terminate. $(SUBDIR_MAKEFILES_IN) $(CONFIG_STATUS_FILES_IN): | config.status =09MAKE=3D'$(MAKE)' ./config.status This doesn't work if "make -B" is used, but the current Makefile also fails in that case. In all other cases I've found, this does the right thing. Pip
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.
Received: (at 75655) by debbugs.gnu.org; 20 Jan 2025 23:22:33 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 20 18:22:33 2025
Received: from localhost ([127.0.0.1]:52012 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ta16G-0000Rm-HU
for submit <at> debbugs.gnu.org; Mon, 20 Jan 2025 18:22:33 -0500
Received: from mail-41103.protonmail.ch ([185.70.41.103]:13995)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <pipcet@HIDDEN>)
id 1ta165-0000RA-CV
for 75655 <at> debbugs.gnu.org; Mon, 20 Jan 2025 18:22:22 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
s=protonmail3; t=1737414805; x=1737674005;
bh=4anJPt9bHJq13D1LX0pO9/l+EjZklz80KoHTj1DVnAE=;
h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;
b=fBq5ESinQT6AAn8SXCumkyG7uOiwNFQHY8XU1J5NZk6POjxXb4a5gtkpAXHks93mi
77d75zqtmu4KAQTt+tdNGlCVc2BOxgt+vbW1MOtRbujjmZ2qlNPQdhjn4NkKvcEHd4
1ds0YeN5lpJNCOoqnwdmDGxG7tqk6hepSIwtyOHckz4eoQkAlv1p1lobop22rsm/zL
fsfk6INOSt4+hIEKe4dje43wiuUcd5HYtfNv225voDfXF5CPJKwn6WyWpdgnxK8zrm
9VTA+kcRr1aJZrUcXTVvUR1K1JgYo3eyyr69eZI5sdNu4xU8m1KYDc5i6uLTTuSKXz
ExFE0tk4VEtdQ==
Date: Mon, 20 Jan 2025 23:13:20 +0000
To: Andreas Schwab <schwab@HIDDEN>
From: Pip Cet <pipcet@HIDDEN>
Subject: Re: bug#75655: configure doesn't update Makefile
Message-ID: <87r04xyt84.fsf@HIDDEN>
In-Reply-To: <87jzap9lpj.fsf@HIDDEN>
References: <87bjw3c3uf.fsf@HIDDEN> <87jzarcfqg.fsf@HIDDEN>
<874j1t5zvr.fsf@HIDDEN> <87o701a1b3.fsf@HIDDEN>
<87plkh19s7.fsf@HIDDEN> <87jzap9lpj.fsf@HIDDEN>
Feedback-ID: 112775352:user:proton
X-Pm-Message-ID: 9a131ea38a560b7da4a911b236aeedada4d03fbe
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75655
Cc: "Pip Cet via \"Bug reports for GNU Emacs,
the Swiss army knife of text editors\"" <bug-gnu-emacs@HIDDEN>,
75655 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
"Andreas Schwab" <schwab@HIDDEN> writes:
> On Jan 20 2025, Pip Cet wrote:
>
>> "Andreas Schwab" <schwab@HIDDEN> writes:
>>
>>> On Jan 20 2025, Pip Cet wrote:
>>>
>>>> I believe that needs an additional order-only prerequisite
>>>> (config.status) to work properly in parallel make: calling config.stat=
us
>>>> twice in parallel seems like a very bad idea. And, of course, a comme=
nt
>>>> explaining it.
>>>
>>> The right way to solve this is to tell config.status to only update the
>>> current target.
I'm sorry, I misread your message at first. Let me summarize it to make
sure I got it right:
One problem with the first solution I proposed:
$(SUBDIR_MAKEFILES_IN) $(CONFIG_STATUS_FILES_IN):
=09MAKE=3D'$(MAKE)' ./config.status
is that config.status may be run before, or while, it is being built
(either by configure, or by config.status --recheck);
this won't happen with ordinary "make", but "make -j" would do the
trick.
My proposal was to use an order-only prerequisite:
$(SUBDIR_MAKEFILES_IN) $(CONFIG_STATUS_FILES_IN): | config.status
=09MAKE=3D'$(MAKE)' ./config.status
This fixes the problem if there is a single Makefile.in that we're
trying to rebuild, but if more than one Makefile.in simultaneously goes
missing, config.status might be run twice by this code, in parallel.
This can happen and produces confusing output, but I'm not sure it
causes errors: at first glance, config.status appears to create a
temporary new file and move it to "Makefile" atomically.
Your proposal is to modify the line
MAKE=3D'$(MAKE)' ./config.status
so it builds only the current target $@ of this rule.
Is that accurate so far?
If it is, I'm confused because the target $@ of this rule is, in my
case, benchmark/Makefile.in.
That file does not exist before the rule is executed, and it is not
created by the rule: the effect of the rule is to regenerate "Makefile",
which make will notice and reload the Makefile. The "target" merely
indicates which file was missing and made us decide to recreate the
Makefile. The new Makefile will hopefully no longer refer to the
"target" and work.
Did you mean we restrict config.status to generate only Makefile?
As far as I can tell, that modification works, and it saves some output
and presumably some CPU cycles, but it still means we'll invoke
=09MAKE=3D'$(MAKE)' ./config.status --file=3DMakefile
twice for "make -j" if two of the targets are missing.
So I'm not sure what you are suggesting. My best guess is that you're
suggesting we somehow pick a single one of the rule's prerequisites
which will cause config.status to run, and ignore all others. Is that
correct?
MISSING_MAKEFILE_IN :=3D $(firstword $(filter-out $(addprefix ./,$(wildcard=
$(SUBDIR_MAKEFILES_IN))),$(SUBDIR_MAKEFILES_IN)))
$(SUBDIR_MAKEFILES_IN) $(CONFIG_STATUS_FILES_IN): | config.status
=09if [ ./"$@" =3D "$(MISSING_MAKEFILE_IN)" ]; then sleep 1m; MAKE=3D'$(MAK=
E)' ./config.status; fi
appears to work, at least, but I don't know what to replace ./ by.
Pip
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 20 Jan 2025 16:38:13 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 20 11:38:13 2025 Received: from localhost ([127.0.0.1]:52104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tZumz-0003k5-Ev for submit <at> debbugs.gnu.org; Mon, 20 Jan 2025 11:38:13 -0500 Received: from lists.gnu.org ([2001:470:142::17]:40636) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <whitebox@HIDDEN>) id 1tZumx-0003jJ-W8 for submit <at> debbugs.gnu.org; Mon, 20 Jan 2025 11:38:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <whitebox@HIDDEN>) id 1tZumn-0006e2-2M for bug-gnu-emacs@HIDDEN; Mon, 20 Jan 2025 11:38:01 -0500 Received: from mail-out.m-online.net ([212.18.0.9]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <whitebox@HIDDEN>) id 1tZumk-0008Up-UD for bug-gnu-emacs@HIDDEN; Mon, 20 Jan 2025 11:38:00 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4YcGGn4hkSz1qsNr; Mon, 20 Jan 2025 17:37:53 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 4YcGGn2x8vz1qqlW; Mon, 20 Jan 2025 17:37:53 +0100 (CET) X-Virus-Scanned: amavis at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavis, port 10024) with ESMTP id oXfPF2GrKZOV; Mon, 20 Jan 2025 17:37:52 +0100 (CET) X-Auth-Info: eW8W2AcaN1m4LOzy3egBj+BTIWqPn+b6x0Z4rtKM95C1CIvnVaNTR+hHbkJ+jZ58 Received: from igel.home (aftr-82-135-83-171.dynamic.mnet-online.de [82.135.83.171]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 20 Jan 2025 17:37:52 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 768D92C1997; Mon, 20 Jan 2025 17:37:52 +0100 (CET) From: Andreas Schwab <schwab@HIDDEN> To: Pip Cet <pipcet@HIDDEN> Subject: Re: bug#75655: configure doesn't update Makefile In-Reply-To: <874j1t5zvr.fsf@HIDDEN> (Pip Cet's message of "Mon, 20 Jan 2025 14:22:37 +0000") References: <87bjw3c3uf.fsf@HIDDEN> <87jzarcfqg.fsf@HIDDEN> <874j1t5zvr.fsf@HIDDEN> Date: Mon, 20 Jan 2025 17:37:52 +0100 Message-ID: <87o701a1b3.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=212.18.0.9; envelope-from=whitebox@HIDDEN; helo=mail-out.m-online.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: "Pip Cet via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\"" <bug-gnu-emacs@HIDDEN>, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) On Jan 20 2025, Pip Cet wrote: > I believe that needs an additional order-only prerequisite > (config.status) to work properly in parallel make: calling config.status > twice in parallel seems like a very bad idea. And, of course, a comment > explaining it. The right way to solve this is to tell config.status to only update the current target. -- Andreas Schwab, schwab@HIDDEN GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at 75655) by debbugs.gnu.org; 20 Jan 2025 16:38:00 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 20 11:38:00 2025 Received: from localhost ([127.0.0.1]:52100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tZumm-0003j5-1M for submit <at> debbugs.gnu.org; Mon, 20 Jan 2025 11:38:00 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:48736) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <whitebox@HIDDEN>) id 1tZumh-0003is-O2 for 75655 <at> debbugs.gnu.org; Mon, 20 Jan 2025 11:37:57 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4YcGGn4hkSz1qsNr; Mon, 20 Jan 2025 17:37:53 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 4YcGGn2x8vz1qqlW; Mon, 20 Jan 2025 17:37:53 +0100 (CET) X-Virus-Scanned: amavis at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavis, port 10024) with ESMTP id oXfPF2GrKZOV; Mon, 20 Jan 2025 17:37:52 +0100 (CET) X-Auth-Info: eW8W2AcaN1m4LOzy3egBj+BTIWqPn+b6x0Z4rtKM95C1CIvnVaNTR+hHbkJ+jZ58 Received: from igel.home (aftr-82-135-83-171.dynamic.mnet-online.de [82.135.83.171]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 20 Jan 2025 17:37:52 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 768D92C1997; Mon, 20 Jan 2025 17:37:52 +0100 (CET) From: Andreas Schwab <schwab@HIDDEN> To: Pip Cet <pipcet@HIDDEN> Subject: Re: bug#75655: configure doesn't update Makefile In-Reply-To: <874j1t5zvr.fsf@HIDDEN> (Pip Cet's message of "Mon, 20 Jan 2025 14:22:37 +0000") References: <87bjw3c3uf.fsf@HIDDEN> <87jzarcfqg.fsf@HIDDEN> <874j1t5zvr.fsf@HIDDEN> Date: Mon, 20 Jan 2025 17:37:52 +0100 Message-ID: <87o701a1b3.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75655 Cc: "Pip Cet via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\"" <bug-gnu-emacs@HIDDEN>, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On Jan 20 2025, Pip Cet wrote: > I believe that needs an additional order-only prerequisite > (config.status) to work properly in parallel make: calling config.status > twice in parallel seems like a very bad idea. And, of course, a comment > explaining it. The right way to solve this is to tell config.status to only update the current target. -- Andreas Schwab, schwab@HIDDEN GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at 75655) by debbugs.gnu.org; 20 Jan 2025 14:23:05 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 20 09:23:05 2025 Received: from localhost ([127.0.0.1]:49481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tZsgC-0006ZQ-RA for submit <at> debbugs.gnu.org; Mon, 20 Jan 2025 09:23:05 -0500 Received: from mail-10629.protonmail.ch ([79.135.106.29]:37183) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <pipcet@HIDDEN>) id 1tZsfy-0006Xx-P1 for 75655 <at> debbugs.gnu.org; Mon, 20 Jan 2025 09:22:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1737382963; x=1737642163; bh=KWOmAx4GQDianV78VzTlG+A4Qa2uYfEIk6twUf+CQpA=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=TMbGKy4FrpwFVxHo376ZwykQ6m67VNZ1c1CmiyZFHrRJuIQu6EbWTTYGsIQ+Ro0TB 0E0XePkokbCZQOzpUSVkzuKA7CyB95Uxj/mNSKJx1U5tGscFnQ3OynqAFWgikir3hT MAHJGmU0RzG1SHrqdkMv07RqF3Pd8RwYSHsHijjDWZmBrE62Tf4QNYFY2zYBGcdl6/ lNAJxtZ+pByv/Od+cph9cFhvw1uV6J6fhIajo4NTUprEjJ1d0PqGIeZNnx1T3dR4Xc VhiXo5ingmjrfmemTJNckqbJdZUNjB38E9t3otktUP0Kcnwug9MmgWGwXy8m83/EVm fbqRMNboYFrlA== Date: Mon, 20 Jan 2025 14:22:37 +0000 To: Andreas Schwab <schwab@HIDDEN> From: Pip Cet <pipcet@HIDDEN> Subject: Re: bug#75655: configure doesn't update Makefile Message-ID: <874j1t5zvr.fsf@HIDDEN> In-Reply-To: <87jzarcfqg.fsf@HIDDEN> References: <87bjw3c3uf.fsf@HIDDEN> <87jzarcfqg.fsf@HIDDEN> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: e5bd6afc6c39f1b81666b1b14be30541adc155ba MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 75655 Cc: "Pip Cet via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\"" <bug-gnu-emacs@HIDDEN>, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.0 (--) Pip Cet <pipcet@HIDDEN> writes: > "Andreas Schwab" <schwab@HIDDEN> writes: > >> On Jan 18 2025, Pip Cet via "Bug reports for GNU Emacs, the Swiss army k= nife of text editors" wrote: >> >>> If config.status exists, it is rerun, and regenerates the Makefile; but >>> if it doesn't, configure is run but config.status isn't. > >> Configure always runs config.status after it created it, unless it is >> called with --no-create. > > Thanks, I was confused there. > > How about: > > modified Makefile.in > # Don't erase these files if make is interrupted while refreshing them. > .PRECIOUS: Makefile config.status > =20 > +$(SUBDIR_MAKEFILES_IN) $(CONFIG_STATUS_FILES_IN): I believe that needs an additional order-only prerequisite (config.status) to work properly in parallel make: calling config.status twice in parallel seems like a very bad idea. And, of course, a comment explaining it. Pip
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 20 Jan 2025 14:22:55 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 20 09:22:55 2025 Received: from localhost ([127.0.0.1]:49478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tZsg3-0006YP-BA for submit <at> debbugs.gnu.org; Mon, 20 Jan 2025 09:22:55 -0500 Received: from lists.gnu.org ([2001:470:142::17]:60612) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <pipcet@HIDDEN>) id 1tZsg1-0006Y2-6s for submit <at> debbugs.gnu.org; Mon, 20 Jan 2025 09:22:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <pipcet@HIDDEN>) id 1tZsfv-0006uv-PG for bug-gnu-emacs@HIDDEN; Mon, 20 Jan 2025 09:22:47 -0500 Received: from mail-10629.protonmail.ch ([79.135.106.29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <pipcet@HIDDEN>) id 1tZsfu-0003zd-74 for bug-gnu-emacs@HIDDEN; Mon, 20 Jan 2025 09:22:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1737382963; x=1737642163; bh=KWOmAx4GQDianV78VzTlG+A4Qa2uYfEIk6twUf+CQpA=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=TMbGKy4FrpwFVxHo376ZwykQ6m67VNZ1c1CmiyZFHrRJuIQu6EbWTTYGsIQ+Ro0TB 0E0XePkokbCZQOzpUSVkzuKA7CyB95Uxj/mNSKJx1U5tGscFnQ3OynqAFWgikir3hT MAHJGmU0RzG1SHrqdkMv07RqF3Pd8RwYSHsHijjDWZmBrE62Tf4QNYFY2zYBGcdl6/ lNAJxtZ+pByv/Od+cph9cFhvw1uV6J6fhIajo4NTUprEjJ1d0PqGIeZNnx1T3dR4Xc VhiXo5ingmjrfmemTJNckqbJdZUNjB38E9t3otktUP0Kcnwug9MmgWGwXy8m83/EVm fbqRMNboYFrlA== Date: Mon, 20 Jan 2025 14:22:37 +0000 To: Andreas Schwab <schwab@HIDDEN> From: Pip Cet <pipcet@HIDDEN> Subject: Re: bug#75655: configure doesn't update Makefile Message-ID: <874j1t5zvr.fsf@HIDDEN> In-Reply-To: <87jzarcfqg.fsf@HIDDEN> References: <87bjw3c3uf.fsf@HIDDEN> <87jzarcfqg.fsf@HIDDEN> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: e5bd6afc6c39f1b81666b1b14be30541adc155ba MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=79.135.106.29; envelope-from=pipcet@HIDDEN; helo=mail-10629.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: "Pip Cet via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\"" <bug-gnu-emacs@HIDDEN>, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) Pip Cet <pipcet@HIDDEN> writes: > "Andreas Schwab" <schwab@HIDDEN> writes: > >> On Jan 18 2025, Pip Cet via "Bug reports for GNU Emacs, the Swiss army k= nife of text editors" wrote: >> >>> If config.status exists, it is rerun, and regenerates the Makefile; but >>> if it doesn't, configure is run but config.status isn't. > >> Configure always runs config.status after it created it, unless it is >> called with --no-create. > > Thanks, I was confused there. > > How about: > > modified Makefile.in > # Don't erase these files if make is interrupted while refreshing them. > .PRECIOUS: Makefile config.status > =20 > +$(SUBDIR_MAKEFILES_IN) $(CONFIG_STATUS_FILES_IN): I believe that needs an additional order-only prerequisite (config.status) to work properly in parallel make: calling config.status twice in parallel seems like a very bad idea. And, of course, a comment explaining it. Pip
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at 75655) by debbugs.gnu.org; 20 Jan 2025 11:00:06 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 20 06:00:05 2025 Received: from localhost ([127.0.0.1]:49134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tZpVl-0001p4-Bf for submit <at> debbugs.gnu.org; Mon, 20 Jan 2025 06:00:05 -0500 Received: from mail-40134.protonmail.ch ([185.70.40.134]:14687) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <pipcet@HIDDEN>) id 1tZpVi-0001np-OK for 75655 <at> debbugs.gnu.org; Mon, 20 Jan 2025 06:00:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1737370795; x=1737629995; bh=q+24QD4rL6YUpcS+VC5veMoCy9IWUwcRpGsqIP+MJkE=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=uq/sVkuDQex3UEAHj3YHrvHciUebAYyULNAlR3I/fZMcmpbTgICY7IAw6n0mNlyOW 3147umGwEuQh2NdprV5Q+mjPpgELbU2VTuU5GR7RWt+AzyVSx1ySlsYiF91KkbMsyQ OEcgFCg7dcSFFM2zGxsK36xBa1sbHtKl9Al9+5Np2avCyaX4iau/7kOSlaExmsBZAe x2slVXb0QMulhZ4UZ/d00C+ot2Bp+cJu6QAyODSPLWYpkfVuqjUyG5fsph6Sc1FpFR TUO5ZGNbaK8RjkBGqes2yuzqT3Mdg/fakVs6nvrO84Iel7gHhdRhWlU+swnurdFULA KahbF4aMll7qA== Date: Mon, 20 Jan 2025 10:59:51 +0000 To: Andreas Schwab <schwab@HIDDEN> From: Pip Cet <pipcet@HIDDEN> Subject: Re: bug#75655: configure doesn't update Makefile Message-ID: <87o701wy25.fsf@HIDDEN> In-Reply-To: <87jzarcfqg.fsf@HIDDEN> References: <87bjw3c3uf.fsf@HIDDEN> <87jzarcfqg.fsf@HIDDEN> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 80201ee7373dfa60706179c56294b92f6d4909f5 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 75655 Cc: "Pip Cet via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\"" <bug-gnu-emacs@HIDDEN>, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) "Andreas Schwab" <schwab@HIDDEN> writes: > On Jan 18 2025, Pip Cet via "Bug reports for GNU Emacs, the Swiss army kn= ife of text editors" wrote: > >> If config.status exists, it is rerun, and regenerates the Makefile; but >> if it doesn't, configure is run but config.status isn't. > Configure always runs config.status after it created it, unless it is > called with --no-create. Thanks, I was confused there. How about: modified Makefile.in # Don't erase these files if make is interrupted while refreshing them. .PRECIOUS: Makefile config.status =20 +$(SUBDIR_MAKEFILES_IN) $(CONFIG_STATUS_FILES_IN): +=09MAKE=3D'$(MAKE)' ./config.status + # Note that calling config.status --recheck is insufficient on Android # due to the recursive calls to configure. That works in my case: 1. make tries to rebuild Makefile 2. make tries to rebuild benchmarks/Makefile.in 3. Makefile is updated, but benchmarks/Makefile.in isn't created 4. magic happens 5. make rereads the new Makefile 6. everything works Does it break other cases? Pip
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 20 Jan 2025 11:00:13 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 20 06:00:13 2025 Received: from localhost ([127.0.0.1]:49138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tZpVs-0001rf-VJ for submit <at> debbugs.gnu.org; Mon, 20 Jan 2025 06:00:13 -0500 Received: from lists.gnu.org ([2001:470:142::17]:45410) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <pipcet@HIDDEN>) id 1tZpVo-0001oi-Eh for submit <at> debbugs.gnu.org; Mon, 20 Jan 2025 06:00:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <pipcet@HIDDEN>) id 1tZpVh-0007b2-Pc for bug-gnu-emacs@HIDDEN; Mon, 20 Jan 2025 06:00:01 -0500 Received: from mail-40133.protonmail.ch ([185.70.40.133]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <pipcet@HIDDEN>) id 1tZpVf-0007Yz-4l for bug-gnu-emacs@HIDDEN; Mon, 20 Jan 2025 06:00:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1737370795; x=1737629995; bh=q+24QD4rL6YUpcS+VC5veMoCy9IWUwcRpGsqIP+MJkE=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=uq/sVkuDQex3UEAHj3YHrvHciUebAYyULNAlR3I/fZMcmpbTgICY7IAw6n0mNlyOW 3147umGwEuQh2NdprV5Q+mjPpgELbU2VTuU5GR7RWt+AzyVSx1ySlsYiF91KkbMsyQ OEcgFCg7dcSFFM2zGxsK36xBa1sbHtKl9Al9+5Np2avCyaX4iau/7kOSlaExmsBZAe x2slVXb0QMulhZ4UZ/d00C+ot2Bp+cJu6QAyODSPLWYpkfVuqjUyG5fsph6Sc1FpFR TUO5ZGNbaK8RjkBGqes2yuzqT3Mdg/fakVs6nvrO84Iel7gHhdRhWlU+swnurdFULA KahbF4aMll7qA== Date: Mon, 20 Jan 2025 10:59:51 +0000 To: Andreas Schwab <schwab@HIDDEN> From: Pip Cet <pipcet@HIDDEN> Subject: Re: bug#75655: configure doesn't update Makefile Message-ID: <87o701wy25.fsf@HIDDEN> In-Reply-To: <87jzarcfqg.fsf@HIDDEN> References: <87bjw3c3uf.fsf@HIDDEN> <87jzarcfqg.fsf@HIDDEN> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 80201ee7373dfa60706179c56294b92f6d4909f5 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.40.133; envelope-from=pipcet@HIDDEN; helo=mail-40133.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: "Pip Cet via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\"" <bug-gnu-emacs@HIDDEN>, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) "Andreas Schwab" <schwab@HIDDEN> writes: > On Jan 18 2025, Pip Cet via "Bug reports for GNU Emacs, the Swiss army kn= ife of text editors" wrote: > >> If config.status exists, it is rerun, and regenerates the Makefile; but >> if it doesn't, configure is run but config.status isn't. > Configure always runs config.status after it created it, unless it is > called with --no-create. Thanks, I was confused there. How about: modified Makefile.in # Don't erase these files if make is interrupted while refreshing them. .PRECIOUS: Makefile config.status =20 +$(SUBDIR_MAKEFILES_IN) $(CONFIG_STATUS_FILES_IN): +=09MAKE=3D'$(MAKE)' ./config.status + # Note that calling config.status --recheck is insufficient on Android # due to the recursive calls to configure. That works in my case: 1. make tries to rebuild Makefile 2. make tries to rebuild benchmarks/Makefile.in 3. Makefile is updated, but benchmarks/Makefile.in isn't created 4. magic happens 5. make rereads the new Makefile 6. everything works Does it break other cases? Pip
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at 75655) by debbugs.gnu.org; 19 Jan 2025 09:31:11 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 19 04:31:11 2025 Received: from localhost ([127.0.0.1]:44902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tZReB-0005PZ-7R for submit <at> debbugs.gnu.org; Sun, 19 Jan 2025 04:31:11 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:54861) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <whitebox@HIDDEN>) id 1tZRe6-0005Dd-MS for 75655 <at> debbugs.gnu.org; Sun, 19 Jan 2025 04:31:09 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4YbSrm6pk2z1qsP5; Sun, 19 Jan 2025 10:31:04 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 4YbSrm53lWz1qqlS; Sun, 19 Jan 2025 10:31:04 +0100 (CET) X-Virus-Scanned: amavis at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavis, port 10024) with ESMTP id TpIMjwsT1tu5; Sun, 19 Jan 2025 10:31:03 +0100 (CET) X-Auth-Info: fxBDMHxgUWQvlhyt5edZF4AH2OjdbUi1AvmbUCbB0S1bsozOBF/3fW8tHZ5sMd0M Received: from tiger.home (aftr-82-135-83-240.dynamic.mnet-online.de [82.135.83.240]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sun, 19 Jan 2025 10:31:03 +0100 (CET) Received: by tiger.home (Postfix, from userid 1000) id 10EF8325D88; Sun, 19 Jan 2025 10:31:03 +0100 (CET) From: Andreas Schwab <schwab@HIDDEN> To: Pip Cet via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> Subject: Re: bug#75655: configure doesn't update Makefile In-Reply-To: <87bjw3c3uf.fsf@HIDDEN> (Pip Cet via's message of "Sat, 18 Jan 2025 19:35:54 +0000") References: <87bjw3c3uf.fsf@HIDDEN> X-Yow: Dizzy, are we "REAL PEOPLE" or "AMAZING ANIMALS"? Date: Sun, 19 Jan 2025 10:31:03 +0100 Message-ID: <87jzarcfqg.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 75655 Cc: Pip Cet <pipcet@HIDDEN>, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.4 (-) On Jan 18 2025, Pip Cet via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: > If config.status exists, it is rerun, and regenerates the Makefile; but > if it doesn't, configure is run but config.status isn't. Configure always runs config.status after it created it, unless it is called with --no-create. -- Andreas Schwab, schwab@HIDDEN GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 19 Jan 2025 09:31:20 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 19 04:31:20 2025 Received: from localhost ([127.0.0.1]:44905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tZReJ-0005d3-NO for submit <at> debbugs.gnu.org; Sun, 19 Jan 2025 04:31:19 -0500 Received: from lists.gnu.org ([2001:470:142::17]:48852) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <whitebox@HIDDEN>) id 1tZReH-0005R2-Ae for submit <at> debbugs.gnu.org; Sun, 19 Jan 2025 04:31:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <whitebox@HIDDEN>) id 1tZReB-0002vM-LG for bug-gnu-emacs@HIDDEN; Sun, 19 Jan 2025 04:31:11 -0500 Received: from mail-out.m-online.net ([212.18.0.9]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <whitebox@HIDDEN>) id 1tZRe9-0005ow-Th for bug-gnu-emacs@HIDDEN; Sun, 19 Jan 2025 04:31:11 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4YbSrm6pk2z1qsP5; Sun, 19 Jan 2025 10:31:04 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 4YbSrm53lWz1qqlS; Sun, 19 Jan 2025 10:31:04 +0100 (CET) X-Virus-Scanned: amavis at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavis, port 10024) with ESMTP id TpIMjwsT1tu5; Sun, 19 Jan 2025 10:31:03 +0100 (CET) X-Auth-Info: fxBDMHxgUWQvlhyt5edZF4AH2OjdbUi1AvmbUCbB0S1bsozOBF/3fW8tHZ5sMd0M Received: from tiger.home (aftr-82-135-83-240.dynamic.mnet-online.de [82.135.83.240]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sun, 19 Jan 2025 10:31:03 +0100 (CET) Received: by tiger.home (Postfix, from userid 1000) id 10EF8325D88; Sun, 19 Jan 2025 10:31:03 +0100 (CET) From: Andreas Schwab <schwab@HIDDEN> To: Pip Cet via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> Subject: Re: bug#75655: configure doesn't update Makefile In-Reply-To: <87bjw3c3uf.fsf@HIDDEN> (Pip Cet via's message of "Sat, 18 Jan 2025 19:35:54 +0000") References: <87bjw3c3uf.fsf@HIDDEN> X-Yow: Dizzy, are we "REAL PEOPLE" or "AMAZING ANIMALS"? Date: Sun, 19 Jan 2025 10:31:03 +0100 Message-ID: <87jzarcfqg.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=212.18.0.9; envelope-from=whitebox@HIDDEN; helo=mail-out.m-online.net X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Jan 18 2025, Pip Cet via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: > If config.status exists, it is rerun, and regenerates the Makefile; but > if it doesn't, configure is run but config.status isn't. Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org] X-Debbugs-Envelope-To: submit Cc: Pip Cet <pipcet@HIDDEN>, 75655 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.2 (/) On Jan 18 2025, Pip Cet via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: > If config.status exists, it is rerun, and regenerates the Makefile; but > if it doesn't, configure is run but config.status isn't. Configure always runs config.status after it created it, unless it is called with --no-create. -- Andreas Schwab, schwab@HIDDEN GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.
Received: (at 75655) by debbugs.gnu.org; 19 Jan 2025 05:20:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 19 00:20:03 2025
Received: from localhost ([127.0.0.1]:44499 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tZNj8-0007C7-Rw
for submit <at> debbugs.gnu.org; Sun, 19 Jan 2025 00:20:03 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:60218)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tZNj6-0007BL-9Y
for 75655 <at> debbugs.gnu.org; Sun, 19 Jan 2025 00:20:01 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1tZNj0-0007rR-TF; Sun, 19 Jan 2025 00:19:54 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=0pYwJhwpbsi3taWPzXazzRSCrBXsDRoj79jSJIjYSvA=; b=mDcgqHn8gXzK
xhvhadbhrLPl+oat7WEz8sZgyJAp9HWpLo+bof29wqEC/bVz2a4+Olx7JEhNQu2pH8ilUydB2la/n
LnkggWUpIXf+RPW6ybif3iw5Op0O6ylMf/jWkBOQui4XzPGO6EcyD/gLxSYDrki3zXJypaRV0UX4e
unpDXiQSndlQWd4r/mBywbwPeNczykLj6LPN3m/8jHE3hGfD/Wfb5JXnF+8G9NfBLAJC50yxLK31P
xDRppZZHSjUhxYNrUGNVNNyHVpJUy+Wper/bapNZrDrwDmunGfK7jc50adRnmTaAqzn30Hy/PUHjG
7J68LvItDpq4GreRjTqYbQ==;
Date: Sun, 19 Jan 2025 07:19:53 +0200
Message-Id: <86y0z78jnq.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Pip Cet <pipcet@HIDDEN>
In-Reply-To: <87tt9vama5.fsf@HIDDEN> (message from Pip Cet on Sat, 18
Jan 2025 20:40:36 +0000)
Subject: Re: bug#75655: configure doesn't update Makefile
References: <87bjw3c3uf.fsf@HIDDEN> <8634hfanvq.fsf@HIDDEN>
<87tt9vama5.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 75655
Cc: 75655 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Date: Sat, 18 Jan 2025 20:40:36 +0000
> From: Pip Cet <pipcet@HIDDEN>
> Cc: 75655 <at> debbugs.gnu.org
>
> "Eli Zaretskii" <eliz@HIDDEN> writes:
>
> >> Date: Sat, 18 Jan 2025 19:35:54 +0000
> >> From: Pip Cet via "Bug reports for GNU Emacs,
> >> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
> >>
> >> I'm confused by this recipe in Makefile.in:
> >>
> >> config.status: ${srcdir}/configure
> >> if [ -x ./config.status ]; then \
> >> $(CFG) ./config.status --recheck; \
> >> else \
> >> $(CFG) $(srcdir)/configure $(CONFIGURE_FLAGS); \
> >> fi
> >>
> >> If config.status exists, it is rerun, and regenerates the Makefile; but
> >> if it doesn't, configure is run but config.status isn't.
> >
> > config.status is run, after creating it, by the 'Makefile' rule:
> >
> > configure: creating ./config.status
> > configure: WARNING: This configuration installs a 'movemail' program
> > that retrieves POP3 email via only insecure channels.
> > To omit insecure POP3, you can use './configure --without-pop'.
> > MAKE='make' ./config.status
> > config.status: creating src/verbose.mk
> > config.status: creating nt/emacs.rc
> > config.status: creating nt/emacsclient.rc
>
> As far as I can tell, the 'Makefile' rule calls a recursive make with
> the 'config.status' target (but it also lists config.status as a
> dependency); 'config.status' is a file target, not a phony target, so
> if config.status is more recent than configure (which is usually the
> case), nothing happens.
>
> If config.status has been deleted, we run configure but not
> config.status. This means the Makefile won't be modified.
How come config.status is deleted in the first place?
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.
Received: (at 75655) by debbugs.gnu.org; 18 Jan 2025 20:40:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 18 15:40:50 2025
Received: from localhost ([127.0.0.1]:43904 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tZFcf-0003P9-KR
for submit <at> debbugs.gnu.org; Sat, 18 Jan 2025 15:40:49 -0500
Received: from mail-4316.protonmail.ch ([185.70.43.16]:37123)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <pipcet@HIDDEN>)
id 1tZFcc-0003Ok-W4
for 75655 <at> debbugs.gnu.org; Sat, 18 Jan 2025 15:40:47 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
s=protonmail3; t=1737232840; x=1737492040;
bh=zBtL3CQyf5PT1EdF2/KQO2fWF8Es6keV91lb2jdE1G8=;
h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;
b=Ge0NMZ43w/SPWm4IzdhpGo2cuO5zU0zJLoMHEz2ZEdXm7srFhngyAb1OBtfoax6+B
wWf20u79P9e7AIPSpVML+z329x7CNulWJGmWRC8cd541rRnw3op9UhX2bBO9wzk/9G
fSelwiIc+YG1rAqFgF+jW4Qp/rDlu+HS8vkLORXtlAHn96BvMK7IhMWNouL5PHwKjd
I2cX066ORlO+v2QKgxmBV6jyDyyp13kSBh/NqeCW6B92nfVW3MwstgTePfzX3I8znA
QXmQWXUBi9shANuZrsMAIzJxuhWoeh2zs6Afxly11evXDlrd/BIy+A4zX725rSsFFZ
qa9WeVGxrNmBA==
Date: Sat, 18 Jan 2025 20:40:36 +0000
To: Eli Zaretskii <eliz@HIDDEN>
From: Pip Cet <pipcet@HIDDEN>
Subject: Re: bug#75655: configure doesn't update Makefile
Message-ID: <87tt9vama5.fsf@HIDDEN>
In-Reply-To: <8634hfanvq.fsf@HIDDEN>
References: <87bjw3c3uf.fsf@HIDDEN> <8634hfanvq.fsf@HIDDEN>
Feedback-ID: 112775352:user:proton
X-Pm-Message-ID: faa217ed55a5392b89509c71d21fab116fb115e1
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75655
Cc: 75655 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
"Eli Zaretskii" <eliz@HIDDEN> writes:
>> Date: Sat, 18 Jan 2025 19:35:54 +0000
>> From: Pip Cet via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>>
>> I'm confused by this recipe in Makefile.in:
>>
>> config.status: ${srcdir}/configure
>> =09if [ -x ./config.status ]; then=09=09\
>> =09 $(CFG) ./config.status --recheck;=09\
>> =09else=09=09=09=09=09\
>> =09 $(CFG) $(srcdir)/configure $(CONFIGURE_FLAGS); \
>> =09fi
>>
>> If config.status exists, it is rerun, and regenerates the Makefile; but
>> if it doesn't, configure is run but config.status isn't.
>
> config.status is run, after creating it, by the 'Makefile' rule:
>
> configure: creating ./config.status
> configure: WARNING: This configuration installs a 'movemail' program
> that retrieves POP3 email via only insecure channels.
> To omit insecure POP3, you can use './configure --without-pop'.
> MAKE=3D'make' ./config.status
> config.status: creating src/verbose.mk
> config.status: creating nt/emacs.rc
> config.status: creating nt/emacsclient.rc
As far as I can tell, the 'Makefile' rule calls a recursive make with
the 'config.status' target (but it also lists config.status as a
dependency); 'config.status' is a file target, not a phony target, so
if config.status is more recent than configure (which is usually the
case), nothing happens.
If config.status has been deleted, we run configure but not
config.status. This means the Makefile won't be modified.
Pip
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.
Received: (at 75655) by debbugs.gnu.org; 18 Jan 2025 20:06:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 18 15:06:10 2025
Received: from localhost ([127.0.0.1]:43855 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tZF58-0001nr-6N
for submit <at> debbugs.gnu.org; Sat, 18 Jan 2025 15:06:10 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:54510)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tZF55-0001nQ-Cb
for 75655 <at> debbugs.gnu.org; Sat, 18 Jan 2025 15:06:08 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1tZF4y-00007L-Ve; Sat, 18 Jan 2025 15:06:01 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=7/iLVxNTauhHezwRwP42/G4oPIt7aXelmnGTEv3EOBw=; b=jxqEDzL0AVxr
3Jw8Wq+t7EDJUUzP1xZi3WmDhrbONOkypo/qn0QNeo8hbbE1YKxD+oV5Zxob9zV3hK3zd3CxLf8Qs
MWZyuvPS8Q3w1Ve3RbAY3dNXgRsKBe9xQgqURm0EHNTvBNLCBPamHbwsv77o/yxV5uaJRFsCrrouK
glkDATxiKPLiiIHoORQF26qMRNy4XX97mGm5RWVu1Q+mi4/q86fC5JmP/82liaHdnO59veQODcuJ2
VosSPO2RCR8rSNzwJ7E/7vqjEjpKzT7chu6Xjgab0UK1sHSHqXiXi04CAlqmyak1d44Vp1FT5s82k
9WNlhBe1pq5rye47LPLXKA==;
Date: Sat, 18 Jan 2025 22:05:45 +0200
Message-Id: <8634hfanvq.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Pip Cet <pipcet@HIDDEN>
In-Reply-To: <87bjw3c3uf.fsf@HIDDEN> (bug-gnu-emacs@HIDDEN)
Subject: Re: bug#75655: configure doesn't update Makefile
References: <87bjw3c3uf.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 75655
Cc: 75655 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Date: Sat, 18 Jan 2025 19:35:54 +0000
> From: Pip Cet via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>
> I'm confused by this recipe in Makefile.in:
>
> config.status: ${srcdir}/configure
> if [ -x ./config.status ]; then \
> $(CFG) ./config.status --recheck; \
> else \
> $(CFG) $(srcdir)/configure $(CONFIGURE_FLAGS); \
> fi
>
> If config.status exists, it is rerun, and regenerates the Makefile; but
> if it doesn't, configure is run but config.status isn't.
config.status is run, after creating it, by the 'Makefile' rule:
configure: creating ./config.status
configure: WARNING: This configuration installs a 'movemail' program
that retrieves POP3 email via only insecure channels.
To omit insecure POP3, you can use './configure --without-pop'.
MAKE='make' ./config.status
config.status: creating src/verbose.mk
config.status: creating nt/emacs.rc
config.status: creating nt/emacsclient.rc
bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 18 Jan 2025 19:36:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 18 14:36:16 2025
Received: from localhost ([127.0.0.1]:43817 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tZEcC-0000OJ-06
for submit <at> debbugs.gnu.org; Sat, 18 Jan 2025 14:36:16 -0500
Received: from lists.gnu.org ([2001:470:142::17]:48956)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <pipcet@HIDDEN>)
id 1tZEc7-0000O1-05
for submit <at> debbugs.gnu.org; Sat, 18 Jan 2025 14:36:14 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <pipcet@HIDDEN>)
id 1tZEc1-0002hM-EB
for bug-gnu-emacs@HIDDEN; Sat, 18 Jan 2025 14:36:05 -0500
Received: from mail-40131.protonmail.ch ([185.70.40.131])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <pipcet@HIDDEN>)
id 1tZEbx-0004qV-AC
for bug-gnu-emacs@HIDDEN; Sat, 18 Jan 2025 14:36:05 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
s=protonmail3; t=1737228958; x=1737488158;
bh=6mf+3gwwNwlGQxXTVoZ94DHsM+e2OS33e2Vy3bXeTIc=;
h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:
Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector:
List-Unsubscribe:List-Unsubscribe-Post;
b=tTOCVBarXQLujzmT5jmJ5YtK50UdNAJvTR//PTCApjwXVzUIZRBRkuBdITe4DSMxK
/SrafYB0NxhLgjytdlUL1MJaUuhwH/HM1WBHngwEgp/FsZNpvmzNtquuYnrM5fahF+
elGkyvbkVoGm0o76FaKz0b7krynWXslbH6efreMIHlsW78povhk7csl/d9DGFW7eB8
nFjylQ0TsMXa+tRmWrZ6s1oowlwt+E9A0WVUhIulk8th0EhhzF9UxVIURWqJ29JmQz
YRiVNJ5nw38KigA+TUYfsw1ygEK3ijktp7B4CxwlyugXTVECzjVooQeX5GpQ17d9TS
f554h8NdYDcUw==
Date: Sat, 18 Jan 2025 19:35:54 +0000
To: bug-gnu-emacs@HIDDEN
From: Pip Cet <pipcet@HIDDEN>
Subject: configure doesn't update Makefile
Message-ID: <87bjw3c3uf.fsf@HIDDEN>
Feedback-ID: 112775352:user:proton
X-Pm-Message-ID: 100e094942be9a3b5ab0d4d667512ab5c9bf0bb5
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=185.70.40.131; envelope-from=pipcet@HIDDEN;
helo=mail-40131.protonmail.ch
X-Spam_score_int: -38
X-Spam_score: -3.9
X-Spam_bar: ---
X-Spam_report: (-3.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1.787,
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
This is a minor issue; I have a workaround, and it's only an issue if a
directory that's used in an Emacs build disappears.
I'm running into a strange bug sometimes when switching between the
scratch/elisp-benchmarks and master trees.
The symptom is that "make" sometimes fails after switching from
elisp-benchmarks (where benchmarks/Makefile.in exists and is mentioned
in Makefile) to master (where it doesn't):
make: *** No rule to make target 'benchmarks/Makefile.in', needed by 'Makef=
ile'. Stop.
The error message makes sense: the Makefile refers to
benchmarks/Makefile.in, which doesn't exist after the branch switch, so
I need to regenerate the Makefile.
These commands fail to fix things:
make Makefile
make bootstrap
./configure && make
sh ./autogen.sh && make
But this one fixes things:
sh ./autogen.sh && ./configure && make
It took me a while to figure out that last one, because it looks almost
exactly like a plain "sh ./autogen.sh && make": in both cases,
autogen.sh is run, then configure, but in the second case, configure
only creates ./config.status, which isn't run.
I'm confused by this recipe in Makefile.in:
config.status: ${srcdir}/configure
=09if [ -x ./config.status ]; then=09=09\
=09 $(CFG) ./config.status --recheck;=09\
=09else=09=09=09=09=09\
=09 $(CFG) $(srcdir)/configure $(CONFIGURE_FLAGS); \
=09fi
If config.status exists, it is rerun, and regenerates the Makefile; but
if it doesn't, configure is run but config.status isn't. That's okay if
the point is to generate config.status, but from the rule above:
MAKEFILE_NAME =3D Makefile
$(MAKEFILE_NAME): config.status $(srcdir)/configure \
=09 $(srcdir)/lib/gnulib.mk.in \
$(srcdir)/Makefile.in $(SUBDIR_MAKEFILES_IN) $(CONFIG_STATUS_FILES=
_IN)
=09MAKE=3D'$(MAKE)' ./config.status
the point might be to regenerate and run it. Changing this:
diff --git a/Makefile.in b/Makefile.in
index 342bec11d81..238d3c5a83b 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -575,6 +575,7 @@ $(MAKEFILE_NAME):
=09 $(srcdir)/lib/gnulib.mk.in \
$(srcdir)/Makefile.in $(SUBDIR_MAKEFILES_IN) $(CONFIG_STATUS_FILE=
S_IN)
=09MAKE=3D'$(MAKE)' ./config.status
+=09$(CFG) ./config.status
=20
# Don't erase these files if make is interrupted while refreshing them.
.PRECIOUS: Makefile config.status
@@ -588,6 +589,7 @@ config.status:
=09else=09=09=09=09=09\
=09 $(CFG) $(srcdir)/configure $(CONFIGURE_FLAGS); \
=09fi
+=09$(CFG) ./config.status
=20
$(srcdir)/configure: $(srcdir)/configure.ac $(srcdir)/m4/*.m4
=09cd $(srcdir) && ./autogen.sh autoconf
fixes things, but it's redundant and I'm not sure why either change on
its own isn't sufficient.
Pip Cet <pipcet@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#75655; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.