GNU bug report logs - #75661
[PATCH 0/1] gnu: lsof: Skip LTlock test

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75661 in the body.
You can then email your comments to 75661 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jordan Moore <lockbox <at> struct.foo>
To: guix-patches <at> gnu.org
Cc: Jordan Moore <lockbox <at> struct.foo>
Subject: [PATCH 0/1] gnu: lsof: Skip LTlock test
Date: Sat, 18 Jan 2025 18:33:30 -0500

lsof check stage fails on CoW filesystems (eg. btrfs, zfs).
This unconditionally skips the check. I was looking at how
to work around this and checked Gentoo's source builds, but
noticed they explicity opt out of lsof tests [1]. This patch
removes the single failing test, and allows builds on CoW
filesystems.

Note: I ran into this while standing up a build farm.

1: https://gitweb.gentoo.org/repo/gentoo.git/tree/sys-process/lsof/lsof-4.99.4.ebuild

Jordan Moore (1):
  gnu: lsof: Skip LTlock test

 gnu/packages/lsof.scm | 2 ++
 1 file changed, 2 insertions(+)


base-commit: 42295555ca9648e894569f40e9b28768be3f788a
-- 
2.46.0

Message #8 received at 75661 <at> debbugs.gnu.org (full text, mbox):

From: Jordan Moore <lockbox <at> struct.foo>
To: 75661 <at> debbugs.gnu.org
Cc: Jordan Moore <lockbox <at> struct.foo>
Subject: [PATCH] gnu: lsof: Skip LTlock test
Date: Sat, 18 Jan 2025 18:59:08 -0500

Change-Id: I074247549c34992ccc17840d196fbb00f79cc39f
---
 gnu/packages/lsof.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/lsof.scm b/gnu/packages/lsof.scm
index a6ac0306de..f9b2906ec6 100644
--- a/gnu/packages/lsof.scm
+++ b/gnu/packages/lsof.scm
@@ -73,6 +73,8 @@ (define-public lsof
                      ;; Fails with ‘ERROR!!! client gethostbyaddr() failure’.
                      (("(TESTS \\+=.*) tests/LTsock" _ prefix)
                       prefix)
+                     ;; Fails on CoW filesystems (eg. btrfs)
+                     (("tests/LTlock") "")
                      ;; Fails because /proc not mounted in sandbox
                      (("\tdialects/linux/tests/case-20-epoll.bash \\\\")
                       "\\")))))))

base-commit: 42295555ca9648e894569f40e9b28768be3f788a
-- 
2.46.0

Message #11 received at 75661 <at> debbugs.gnu.org (full text, mbox):

From: "Jordan Moore" <lockbox <at> struct.foo>
To: 75661 <at> debbugs.gnu.org
Subject: Re: [PATCH 0/1] gnu: lsof: Skip LTlock test
Date: Sat, 18 Jan 2025 19:02:33 -0500

[Message part 1 (text/plain, inline)]

This might need to get bumped to another branch like core-packages-team (if accepted), but that was just merged iirc.

- Jordan

[Message part 2 (text/html, inline)]

Message #14 received at 75661 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Jordan Moore <lockbox <at> struct.foo>
Cc: 75661 <at> debbugs.gnu.org
Subject: Re: [bug#75661] [PATCH 0/1] gnu: lsof: Skip LTlock test
Date: Sun, 19 Jan 2025 01:31:22 -0500

On Sat, Jan 18, 2025 at 07:02:33PM -0500, Jordan Moore wrote:
> Subject: [bug#75661] [PATCH 0/1] gnu: lsof: Skip LTlock test

Thanks, I can reproduce the failure and it is fixed with your patch.

> This might need to get bumped to another branch like core-packages-team (if accepted), but that was just merged iirc.

`guix refresh -l lsof` reports approximately 225 dependents, which I
think is fine on the master branch for a "safe" change like this. Is
there more to the story that would require this to go through the
core-packages-team branch?

Message #17 received at 75661 <at> debbugs.gnu.org (full text, mbox):

From: "Jordan Moore" <lockbox <at> struct.foo>
To: "Leo Famulari" <leo <at> famulari.name>
Cc: 75661 <at> debbugs.gnu.org
Subject: Re: [bug#75661] [PATCH 0/1] gnu: lsof: Skip LTlock test
Date: Sun, 19 Jan 2025 10:39:31 -0500

[Message part 1 (text/plain, inline)]

> `guix refresh -l lsof` reports approximately 225 dependents, which I
> think is fine on the master branch for a "safe" change like this. Is
> there more to the story that would require this to go through the
> core-packages-team branch?
> 
Oh no go ahead, I misread that as 2200 packages when I checked

- Jordan

[Message part 2 (text/html, inline)]

Message #22 received at 75661-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Jordan Moore <lockbox <at> struct.foo>
Cc: 75661-done <at> debbugs.gnu.org
Subject: Re: [bug#75661] [PATCH 0/1] gnu: lsof: Skip LTlock test
Date: Sun, 19 Jan 2025 21:40:14 -0500

On Sun, Jan 19, 2025 at 10:39:31AM -0500, Jordan Moore wrote:
> Oh no go ahead, I misread that as 2200 packages when I checked

Great! Pushed as eeabdd8eb346f5fb332385c11292ab3bd1ca12a5

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.