GNU logs - #75712, boring messages

Message sent to pipcet@HIDDEN, bug-gnu-emacs@HIDDEN:

Subject: bug#75712: HAVE_RSVG: svg_css_length_to_pixels doesn't handle RSVG_UNIT_CH
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: pipcet@HIDDEN, bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 21 Jan 2025 00:00:02 +0000
Resent-Message-ID: <handler.75712.B.17374175969152 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 75712 <at> debbugs.gnu.org
Cc: Pip Cet <pipcet@HIDDEN>
From: Stefan Kangas <stefankangas@HIDDEN>
MIME-Version: 1.0
Date: Mon, 20 Jan 2025 14:26:22 -0600
Message-ID: <CADwFkmkQd5gd24ZqFMz7BNf1bKf4s6hv_AmaBdvpy7Z2rbJx8w@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Received-SPF: pass client-ip=2a00:1450:4864:20::532;
 envelope-from=stefankangas@HIDDEN; helo=mail-ed1-x532.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

In Bug#75451, Pip Cet <pipcet@HIDDEN> writes:

> svg_css_length_to_pixels doesn't handle the RSVG_UNIT_CH case.  I don't
> know at which version rsvg started to offer this unit; it's not
> indicated in the header file.

It seems to have been added in 2.58:

https://gnome.pages.gitlab.gnome.org/librsvg/Rsvg-2.0/enum.Unit.html

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Stefan Kangas <stefankangas@HIDDEN>
Subject: bug#75712: Acknowledgement (HAVE_RSVG: svg_css_length_to_pixels
 doesn't handle RSVG_UNIT_CH)
Message-ID: <handler.75712.B.17374175969152.ack <at> debbugs.gnu.org>
References: <CADwFkmkQd5gd24ZqFMz7BNf1bKf4s6hv_AmaBdvpy7Z2rbJx8w@HIDDEN>
X-Gnu-PR-Message: ack 75712
X-Gnu-PR-Package: emacs
Reply-To: 75712 <at> debbugs.gnu.org
Date: Tue, 21 Jan 2025 00:00:03 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  Pip Cet <pipcet@HIDDEN>
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 75712 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
75712: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D75712
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#75712: HAVE_RSVG: svg_css_length_to_pixels doesn't handle RSVG_UNIT_CH
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 21 Jan 2025 02:26:01 +0000
Resent-Message-ID: <handler.75712.B75712.173742633716898 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 75712 <at> debbugs.gnu.org
Cc: Pip Cet <pipcet@HIDDEN>
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <CADwFkmkQd5gd24ZqFMz7BNf1bKf4s6hv_AmaBdvpy7Z2rbJx8w@HIDDEN>
 (Stefan Kangas's message of "Mon, 20 Jan 2025 14:26:22 -0600")
References: <CADwFkmkQd5gd24ZqFMz7BNf1bKf4s6hv_AmaBdvpy7Z2rbJx8w@HIDDEN>
MIME-Version: 1.0
Date: Mon, 20 Jan 2025 20:25:18 -0600
Message-ID: <CADwFkm=SP4mLJztfQ4CVEmQ3emFm4BGbWYnPrG86CH3hUah69w@HIDDEN>
Content-Type: multipart/mixed; boundary="000000000000afa7bc062c2e169f"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--000000000000afa7bc062c2e169f
Content-Type: text/plain; charset="UTF-8"

Stefan Kangas <stefankangas@HIDDEN> writes:

> In Bug#75451, Pip Cet <pipcet@HIDDEN> writes:
>
>> svg_css_length_to_pixels doesn't handle the RSVG_UNIT_CH case.  I don't
>> know at which version rsvg started to offer this unit; it's not
>> indicated in the header file.
>
> It seems to have been added in 2.58:
>
> https://gnome.pages.gitlab.gnome.org/librsvg/Rsvg-2.0/enum.Unit.html

I came up with the following patch, but it's not ideal.

With CSS 3, "the ch unit falls back to 0.5em in the general case, and to
1em when it would be typeset upright".
https://www.w3.org/TR/css-values-3/#ch

Unfortunately, this patch doesn't take into account the "direction" or
"writing-mode" CSS attributes, which is what seems to specify the above.
I couldn't find a way to easily get these CSS attributes using librsvg.

Instead, I just naively assume that they are set to their default
non-vertical value, and thus use 0.5em.  That's not always going to
work, obviously.

While the "ch" attribute seems to be rarely used, it would be nice to
get this detail right.  I'm just not sure how to do it.  Maybe look
through the CSS by hand, searching for these strings and then parsing it
out?  But that's likely to be brittle, ugly, and hard to maintain.

Anyone have any good ideas here?  It's my first time fiddling with
librsvg, so it's quite possible that I'm overlooking something.

That said, I guess this could be installed as a stopgap, to have a
better result than we have now for the common case.

--000000000000afa7bc062c2e169f
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="0001-Support-SVG-ch-length-values.patch"
Content-Disposition: attachment; 
	filename="0001-Support-SVG-ch-length-values.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: a8492e24481c33d0_0.1

RnJvbSA2M2YwZGMwZTJhYmJkNzdjMWM2YTZiM2U0NDU1OTFkMDAwZTkxY2YxIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t
PgpEYXRlOiBUdWUsIDIxIEphbiAyMDI1IDAzOjA0OjQ5ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g
U3VwcG9ydCBTVkcgImNoIiBsZW5ndGggdmFsdWVzCgoqIHNyYy9pbWFnZS5jIChzdmdfY3NzX2xl
bmd0aF90b19waXhlbHMpOiBTdXBwb3J0IFNWRyAiY2giIGxlbmd0aAp2YWx1ZXMuICAoQnVnIzc1
NzEyKQotLS0KIHNyYy9pbWFnZS5jIHwgMTIgKysrKysrKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwg
OSBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9pbWFnZS5j
IGIvc3JjL2ltYWdlLmMKaW5kZXggYjg0MDVkODExMTEuLmI2Mjg1N2M3MTBhIDEwMDY0NAotLS0g
YS9zcmMvaW1hZ2UuYworKysgYi9zcmMvaW1hZ2UuYwpAQCAtMTIwMDgsOSArMTIwMDgsMTUgQEAg
c3ZnX2Nzc19sZW5ndGhfdG9fcGl4ZWxzIChSc3ZnTGVuZ3RoIGxlbmd0aCwgZG91YmxlIGRwaSwg
aW50IGZvbnRfc2l6ZSkKIAkgd2hhdCBzaXplIHdlIG1ha2UgdGhlIGltYWdlLiAgKi8KICAgICAg
IHZhbHVlID0gMDsKICAgICAgIGJyZWFrOwotICAgIGRlZmF1bHQ6Ci0gICAgICAvKiBXZSBzaG91
bGQgbmV2ZXIgcmVhY2ggdGhpcy4gICovCi0gICAgICB2YWx1ZSA9IDA7CisjaWYgTElCUlNWR19D
SEVDS19WRVJTSU9OICgyLCA1OCwgMCkKKyAgICBjYXNlIFJTVkdfVU5JVF9DSDoKKyAgICAgIC8q
IEZJWE1FOiBXaXRoIENTUyAzLCAidGhlIGNoIHVuaXQgZmFsbHMgYmFjayB0byAwLjVlbSBpbiB0
aGUKKwkgZ2VuZXJhbCBjYXNlLCBhbmQgdG8gMWVtIHdoZW4gaXQgd291bGQgYmUgdHlwZXNldCB1
cHJpZ2h0Ii4KKwkgSG93ZXZlciwgSSBjb3VsZCBub3QgZmluZCBhIHdheSB0byBlYXNpbHkgZ2V0
IHRoZSByZWxldmFudCBDU1MKKwkgYXR0cmlidXRlcyB1c2luZyBsaWJyc3ZnLiAgVGh1cywgd2Ug
c2ltcGx5IHdyb25nbHkgYXNzdW1lIHRoZQorCSBnZW5lcmFsIGNhc2UgaXMgYWx3YXlzIHRydWUg
aGVyZS4gIFNlZSBCdWcjNzU3MTIuICAqLworICAgICAgdmFsdWUgPSB2YWx1ZSAqIGZvbnRfc2l6
ZSAvIDIuMDsKKyNlbmRpZgogICAgIH0KIAogICByZXR1cm4gdmFsdWU7Ci0tIAoyLjQ4LjEKCg==
--000000000000afa7bc062c2e169f--

Last modified: Tue, 21 Jan 2025 02:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.