Received: (at 75755) by debbugs.gnu.org; 25 Jan 2025 00:02:20 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 24 19:02:20 2025 Received: from localhost ([127.0.0.1]:47682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tbTcx-0003Yn-Mm for submit <at> debbugs.gnu.org; Fri, 24 Jan 2025 19:02:20 -0500 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:47614) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tbTcv-0003YX-MB for 75755 <at> debbugs.gnu.org; Fri, 24 Jan 2025 19:02:18 -0500 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5d3d143376dso3716816a12.3 for <75755 <at> debbugs.gnu.org>; Fri, 24 Jan 2025 16:02:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737763331; x=1738368131; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=5TkOwvRiLMpkvJSO6v1R09gln7uF0kSbe19qJXOnKo8=; b=LUNIGePMVPKggmvgs8jqow8L2YL0qII5m+kh0ZKpX8ml1Qdjpod14B5AZRtbYNxFdk 6MOWFU/Our4H1yVeqkeysj5+22La6TiLYp/69JrTZZVBpg4saqEsoN7L0E6s+62kPv6T tziTLzPaLqFBIupdm/zlsH4zuMhaoKYavttOBDnZSCdF4f3UCnCjpljnOkqsLvUHiflh d0E3ReVAsfRBl5ktC4tYUUNycQFxfvM/6tkmhTZUtkhqE/EzZWUK7d+DYmfZYBgylSuV ejnddfhshVmkYF8vPAMYr0D/w8MPU0sgO6M9XM4rBigSTSm/nrbtaRxUVmMNVZVZQNEQ 7Uyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737763331; x=1738368131; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5TkOwvRiLMpkvJSO6v1R09gln7uF0kSbe19qJXOnKo8=; b=I+02bkmWKaQtKsTPVPuxMQ9IdH2T1iFOMSGU+09MZ39IvMiAQiP+2Fy51CU4bOxX/d O/ybkaDdf96wY4YcODJRQpnJz/bHbbnjbJ7V7KIsumjUlLDjJHREnx6SGvOgCVjRpiK6 c+xz0AMsNx2ZIjF34VpBwBdFDHU+9MkXGSJb3DIjxe2JzeY0ID0Dm1nubL7xWA10dTC6 TfSHVWfpppukHh8Miy5R/BMdBqU4f4o4nAjqtMpaz11EQcVX/DGI8srKvHi6cSNFZ9Pj FMOL5uhXvAedLky37EbRQlIhnnUwqRc+upxNDyzL3/8Msj/L81xfI056bi5vjiZ4E3Cs NoFw== X-Forwarded-Encrypted: i=1; AJvYcCVJ/GKe3JVoE5jvAhcPrv3ZiBRDkSR4XqExA4IANLSZvu+Dfqw34oV75rT5i1b8gz0R+6yRjg==@debbugs.gnu.org X-Gm-Message-State: AOJu0Ywt8848nUkhE22O/MfLHrSeCsmfl9YO1Pv8bBtoi51TaTWh4vp1 OC+imhVAruVZfbFNByH1d+aFHkPl3ru3MREiH55NCEjGJkXbbMQL21bdRMsqy4pwZjwjq0VjUfw LbXRUi/xkdY5vg/JqOtDDQi7c+vg= X-Gm-Gg: ASbGncuS8kXTxTSgdliGMjRTmGjZQB1YTguzx/OFd9yfjzFTsCRIz6pw86n9dLmpX7T LURxvpqS2/MfPU1kHlP18xRBqTT312Q7r1LZOkU4qb3Eq4bj+1FEzT8oRrS9XMAQ= X-Google-Smtp-Source: AGHT+IGmq6a71px+p+VpKpMIsk4VvnKeZnbvRVwWJetVgFD7+LVryPdRPR1Gj93t0/4UzUuvSELk/KjVuMp3R8akW60= X-Received: by 2002:a05:6402:3508:b0:5dc:1ec6:12bc with SMTP id 4fb4d7f45d1cf-5dc1ec613b2mr2446458a12.28.1737763331338; Fri, 24 Jan 2025 16:02:11 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 24 Jan 2025 18:02:11 -0600 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <86wmeky8i5.fsf@HIDDEN> References: <CADwFkmn9BViN83WBCOMNZZo78PQga0Zf9nODUm_MrigndM0jtA@HIDDEN> <CADwFkmmxmcBVD1JJh+avrJzU8RJgbJCFMv9Kfmhcoo5=s2RfWg@HIDDEN> <874j1q8sw2.fsf@HIDDEN> <CADwFkmnYJ2Dtcdw49--=ppO4XgNt6Dxs-HVAjChyRkv=y_8oRg@HIDDEN> <865xm62fik.fsf@HIDDEN> <878qr161kp.fsf@HIDDEN> <86y0z1zhqx.fsf@HIDDEN> <87r04t4fgm.fsf@HIDDEN> <86plkdzak4.fsf@HIDDEN> <871pwt4du5.fsf@HIDDEN> <86cygdz8qz.fsf@HIDDEN> <CADwFkmk37ThraCpUYh7_fu7rQp0JMYzhFM58HPgXEn6seCz1JA@HIDDEN> <86a5bhz4i7.fsf@HIDDEN> <CADwFkmkTzzavrcUixwH2L1KAJnYCK305TrdJV6-hq8FXAv039w@HIDDEN> <86wmeky8i5.fsf@HIDDEN> MIME-Version: 1.0 Date: Fri, 24 Jan 2025 18:02:11 -0600 X-Gm-Features: AWEUYZlz9JXVPBw78cOszDc05na9DkchlF_Rye71y-0jOBckJfweD3y0r4fxSZc Message-ID: <CADwFkm=WRHAKeDcONhXri=cYQLvkxS3txF9+T6FaZHgTUgWz1Q@HIDDEN> Subject: Re: bug#75755: feature/igc: Missing IGC_CHECK_RES? To: Eli Zaretskii <eliz@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 75755 Cc: pipcet@HIDDEN, eller.helmut@HIDDEN, gerd@HIDDEN, gerd.moellmann@HIDDEN, 75755 <at> debbugs.gnu.org, acorallo@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: >> From: Stefan Kangas <stefankangas@HIDDEN> >> Date: Thu, 23 Jan 2025 15:32:16 -0600 >> Cc: pipcet@HIDDEN, gerd.moellmann@HIDDEN, 75755 <at> debbugs.gnu.org, >> gerd@HIDDEN, eller.helmut@HIDDEN, acorallo@HIDDEN >> >> >> Please let me know what you think of my most recent patch. If you want >> >> something different, may I ask that you send a patch? I don't think >> >> I understand if your idea is different from what I posted. Thanks. >> > >> > Your patch still uses _mps_RES_ENUM, which is a macro that's not >> > supposed to be used outside of MPS. Isn't that so? I thought all >> > this discussion was how to avoid using that macro, wasn't it? >> >> AFAIU, the patch I proposed removes that macro. I just now grepped for >> _mps_RES_ENUM after applying it, and couldn't find any matches in my >> tree. Are you seeing something different? > > Yes, I was looking at a stale igc.c, so I didn't see that > mps_res_to_string was modified exactly as I suggested to do. No problem, and thanks. Installed on feature/igc as commit 2ce718a5274.
bug-gnu-emacs@HIDDEN:bug#75755; Package emacs.
Full text available.Received: (at 75755) by debbugs.gnu.org; 24 Jan 2025 07:30:15 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 24 02:30:15 2025 Received: from localhost ([127.0.0.1]:43434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tbE8t-0008AO-Ac for submit <at> debbugs.gnu.org; Fri, 24 Jan 2025 02:30:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48968) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tbE8r-00087b-Lb for 75755 <at> debbugs.gnu.org; Fri, 24 Jan 2025 02:30:14 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tbE8k-0003xN-9d; Fri, 24 Jan 2025 02:30:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=p4iD5w2ByRUq2cqiD+1wkW/oHrDZR0xOpwzU3NbZ4AI=; b=h3mYaPJQKWwy iEUN2QDRDBO8wC63FwpZrQ6hzNKRkWu8fQP6uoEUNVcs+l9ZP3ru15ysIwM+WmHMDh+1znlkGrnQU YV6Nz2z2AvOj63uBsLKAKKw1iYt7pZxpcKGl63yTsobkCMRwVEB/CPDihWjTzxszerydC+AaN8WuI yKJbocE3ZWZNfiHE2qgW8B3aXPfAKcc1prcyWJlH9Tqvbs1xol2OT0rYKL3b7cz9VP4+Lj5I531c0 9pquYjqhKqanaSysiXBdh4Tkq1hdMOKU7exHNvagMe+suS7MGF1k/T8py4WLfJENOA1fHlFGyekRn Xg+j0IceO477QXxqN6sw8w==; Date: Fri, 24 Jan 2025 09:29:54 +0200 Message-Id: <86wmeky8i5.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <CADwFkmkTzzavrcUixwH2L1KAJnYCK305TrdJV6-hq8FXAv039w@HIDDEN> (message from Stefan Kangas on Thu, 23 Jan 2025 15:32:16 -0600) Subject: Re: bug#75755: feature/igc: Missing IGC_CHECK_RES? References: <CADwFkmn9BViN83WBCOMNZZo78PQga0Zf9nODUm_MrigndM0jtA@HIDDEN> <CADwFkmmxmcBVD1JJh+avrJzU8RJgbJCFMv9Kfmhcoo5=s2RfWg@HIDDEN> <874j1q8sw2.fsf@HIDDEN> <CADwFkmnYJ2Dtcdw49--=ppO4XgNt6Dxs-HVAjChyRkv=y_8oRg@HIDDEN> <865xm62fik.fsf@HIDDEN> <878qr161kp.fsf@HIDDEN> <86y0z1zhqx.fsf@HIDDEN> <87r04t4fgm.fsf@HIDDEN> <86plkdzak4.fsf@HIDDEN> <871pwt4du5.fsf@HIDDEN> <86cygdz8qz.fsf@HIDDEN> <CADwFkmk37ThraCpUYh7_fu7rQp0JMYzhFM58HPgXEn6seCz1JA@HIDDEN> <86a5bhz4i7.fsf@HIDDEN> <CADwFkmkTzzavrcUixwH2L1KAJnYCK305TrdJV6-hq8FXAv039w@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75755 Cc: pipcet@HIDDEN, eller.helmut@HIDDEN, gerd@HIDDEN, gerd.moellmann@HIDDEN, 75755 <at> debbugs.gnu.org, acorallo@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Stefan Kangas <stefankangas@HIDDEN> > Date: Thu, 23 Jan 2025 15:32:16 -0600 > Cc: pipcet@HIDDEN, gerd.moellmann@HIDDEN, 75755 <at> debbugs.gnu.org, > gerd@HIDDEN, eller.helmut@HIDDEN, acorallo@HIDDEN > > >> Please let me know what you think of my most recent patch. If you want > >> something different, may I ask that you send a patch? I don't think > >> I understand if your idea is different from what I posted. Thanks. > > > > Your patch still uses _mps_RES_ENUM, which is a macro that's not > > supposed to be used outside of MPS. Isn't that so? I thought all > > this discussion was how to avoid using that macro, wasn't it? > > AFAIU, the patch I proposed removes that macro. I just now grepped for > _mps_RES_ENUM after applying it, and couldn't find any matches in my > tree. Are you seeing something different? Yes, I was looking at a stale igc.c, so I didn't see that mps_res_to_string was modified exactly as I suggested to do. Sorry.
bug-gnu-emacs@HIDDEN:bug#75755; Package emacs.
Full text available.Received: (at 75755) by debbugs.gnu.org; 23 Jan 2025 21:32:26 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 23 16:32:26 2025 Received: from localhost ([127.0.0.1]:42649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tb4oM-0005y7-DA for submit <at> debbugs.gnu.org; Thu, 23 Jan 2025 16:32:26 -0500 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:51366) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tb4oK-0005xp-N6 for 75755 <at> debbugs.gnu.org; Thu, 23 Jan 2025 16:32:25 -0500 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-5d7e3f1fc01so2881105a12.2 for <75755 <at> debbugs.gnu.org>; Thu, 23 Jan 2025 13:32:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737667938; x=1738272738; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=L6B3PQrEpzZljUkO4uXSR5OvCEjAXi/ytOOQ16wtRig=; b=CBQ8OnWVrgd+3y1ceM+/lfmfR4w58MKLw1vDcFUSI0Kf3ICbjiVwV6hFSx0/i7whIj 8ZJ44XPqy/EZvH1/X/lCFmZxhrj4TKvtLjLKFJ/iX9pc/SMactcA/YKNKYK9QxKzOxwk zg+SE5JuU5x+gdMvlEvQteka/ZfZenXxFt9mJuxszrzj0u5rLCCQW/l6UrjzW+QyPN9n TjCC46vYVDDZ8yjAJtivLavlwNCOkjn3mzQIQxkhE2dRInXc5AyWFGRq24QzSbiabh+Q 7+FOzu3ZSEM70y9WsV53NNZuebzMOPjmqzruKwlnVPoy1CfRUYe7X4PS3H1zoU2fjRtr f+uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737667938; x=1738272738; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=L6B3PQrEpzZljUkO4uXSR5OvCEjAXi/ytOOQ16wtRig=; b=YtZ0bU9yFXCvOCdNRR6W1HbFjeYMgDvrlfKkIQ8u10j+oQDZtMuaZj+gDrhZCwK2EI b+0KbYtWijmRT5CCketKnjc5vO2RTyjzuTH4YYAeP777NmHgmRsSfeToHyFSLfxxC+zR IcCoSRfuyg3pe1F8NTP7sFp47Jj88FGfGkuNrP6z7vVFWZAEbMoiffNIY+VmQ4U3o5H8 uM5UZDr/wWsbRc4T8I4oT5Q4hVeJIKNqvBG0KsZeoBakB8nb4JcZW/inXT5SFO7eC+iO hB6noNhV680JGovEh27fsHFR1R3VWUmBEmJwhfirDNqC6B+Bw7KoAMcyTU4gGrdodSf/ zo0w== X-Forwarded-Encrypted: i=1; AJvYcCXq2JV4SmwgHrIYjFvWbeggws0mg0agZsKnDAve/SPsl5ULiMcN86GTii5DIpPTJ0BA9ayHhQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxD6/cNbbseubWI9ohp6uO3sm3yyiPH6Km1eJxhhZX2jH03R5VS v4vBlKgC7AQGIQrBQ9LRsA3kK6AcOHaI7JNUN1d6qoURKcr18t6U1mGJ7NNq7Loj5NpRtfp4RMB LBd+elrzCd3sW6FKlQlH2q9vOje0= X-Gm-Gg: ASbGncuY5PyTMz7/II4RlF6iwroZ0r/uDXn2Klcd++3efzd6eyBcplAwam/einBSswz kvaqImnpqKu4WnO4S0wsTxvj047+JCV7ffk78wIkJX3EZwlqC5+pm8fmh626WznPL X-Google-Smtp-Source: AGHT+IGMAdatL1B7OKa4vSvPl6KES7Ny1fZdUM0ZLVEf2T0jNZRxnfGLYrWfprZXGhyFSGtfNblVey7pbf5uQo+Ffkg= X-Received: by 2002:a05:6402:42ce:b0:5d0:8359:7a49 with SMTP id 4fb4d7f45d1cf-5db7d100348mr25900050a12.0.1737667937530; Thu, 23 Jan 2025 13:32:17 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 23 Jan 2025 15:32:16 -0600 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <86a5bhz4i7.fsf@HIDDEN> References: <CADwFkmn9BViN83WBCOMNZZo78PQga0Zf9nODUm_MrigndM0jtA@HIDDEN> <CADwFkmmxmcBVD1JJh+avrJzU8RJgbJCFMv9Kfmhcoo5=s2RfWg@HIDDEN> <874j1q8sw2.fsf@HIDDEN> <CADwFkmnYJ2Dtcdw49--=ppO4XgNt6Dxs-HVAjChyRkv=y_8oRg@HIDDEN> <865xm62fik.fsf@HIDDEN> <878qr161kp.fsf@HIDDEN> <86y0z1zhqx.fsf@HIDDEN> <87r04t4fgm.fsf@HIDDEN> <86plkdzak4.fsf@HIDDEN> <871pwt4du5.fsf@HIDDEN> <86cygdz8qz.fsf@HIDDEN> <CADwFkmk37ThraCpUYh7_fu7rQp0JMYzhFM58HPgXEn6seCz1JA@HIDDEN> <86a5bhz4i7.fsf@HIDDEN> MIME-Version: 1.0 Date: Thu, 23 Jan 2025 15:32:16 -0600 X-Gm-Features: AWEUYZkBrJPm-3kuxNEd1ebTlf9bcpFLVpHV31IYW_v7eTaHw00raOc770d_I6k Message-ID: <CADwFkmkTzzavrcUixwH2L1KAJnYCK305TrdJV6-hq8FXAv039w@HIDDEN> Subject: Re: bug#75755: feature/igc: Missing IGC_CHECK_RES? To: Eli Zaretskii <eliz@HIDDEN> Content-Type: multipart/mixed; boundary="00000000000027a994062c6658ee" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75755 Cc: pipcet@HIDDEN, eller.helmut@HIDDEN, gerd@HIDDEN, gerd.moellmann@HIDDEN, 75755 <at> debbugs.gnu.org, acorallo@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --00000000000027a994062c6658ee Content-Type: text/plain; charset="UTF-8" Eli Zaretskii <eliz@HIDDEN> writes: >> Please let me know what you think of my most recent patch. If you want >> something different, may I ask that you send a patch? I don't think >> I understand if your idea is different from what I posted. Thanks. > > Your patch still uses _mps_RES_ENUM, which is a macro that's not > supposed to be used outside of MPS. Isn't that so? I thought all > this discussion was how to avoid using that macro, wasn't it? AFAIU, the patch I proposed removes that macro. I just now grepped for _mps_RES_ENUM after applying it, and couldn't find any matches in my tree. Are you seeing something different? To simplify the review, I've attached the patch with a proper commit message below. Thanks. --00000000000027a994062c6658ee Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Don-t-use-MPS-internal-macro-in-mps_res_to_string.patch" Content-Disposition: attachment; filename="0001-Don-t-use-MPS-internal-macro-in-mps_res_to_string.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 6d0519ef9aecc66_0.1 RnJvbSAxNTRmMTQzZjM2MTI0NjE1NzMwMjRiY2JhYzM1YjkxNmIxOTNhZDUzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBUaHUsIDIzIEphbiAyMDI1IDE4OjUyOjMwICswMTAwClN1YmplY3Q6IFtQQVRDSF0g RG9uJ3QgdXNlIE1QUyBpbnRlcm5hbCBtYWNybyBpbiBtcHNfcmVzX3RvX3N0cmluZwoKKiBzcmMv aWdjLmMgKG1wc19yZXNfZW51bSk6IFJlbW92ZSBlbnVtLgoobXBzX3Jlc190b19zdHJpbmcpOiBE b24ndCB1c2UgTVBTIGludGVybmFsIG1hY3JvIGluCm1wc19yZXNfdG9fc3RyaW5nLiAgKEJ1ZyM3 NTc1NSkKLS0tCiBzcmMvaWdjLmMgfCAxNiArLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdl ZCwgMSBpbnNlcnRpb24oKyksIDE1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9pZ2Mu YyBiL3NyYy9pZ2MuYwppbmRleCA1N2MxMzYxNGY3My4uYjAyZDI5Y2E0ZGEgMTAwNjQ0Ci0tLSBh L3NyYy9pZ2MuYworKysgYi9zcmMvaWdjLmMKQEAgLTI1MiwxOCArMjUyLDYgQEAKIHN0YXRpYyBl bnVtIGlnY19zdGF0ZSBpZ2Nfc3RhdGUgPSBJR0NfU1RBVEVfSU5JVElBTDsKIHN0YXRpYyB2b2lk IHNldF9zdGF0ZSAoZW51bSBpZ2Nfc3RhdGUgc3RhdGUpOwogCi0vKiBEZWZpbmUgYSBuYW1lZCBl bnVtZXJhdGlvbiBjb250YWluaW5nIGFsbCBjYXNlcyB0aGF0IHRoZSBpbnRlZ2VyIHR5cGUKLSAg IG1wc19yZXNfdCBpcyBrbm93biB0byBjb3Zlci4gICovCi0KLSNkZWZpbmUgUkVTX0NBU0UocHJl Zml4LCBpZCwgZG9jKSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg XAotICBpZCwKLQotZW51bSBtcHNfcmVzX2VudW0KLXsKLSAgX21wc19SRVNfRU5VTSAoUkVTX0NB U0UsIE1QU19SRVNfKQotfTsKLSN1bmRlZiBSRVNfQ0FTRQotCiAvKiBDb252ZXJ0IGFuIG1wcyBy ZXN1bHQgY29kZSBpbnRvIGEgcmVzdWx0IHN0cmluZy4gIFRoaXMgc2hvdWxkbid0CiAgICBhbGxv Y2F0ZSBtZW1vcnkgYmVjYXVzZSBpdCdzIGNhbGxlZCB3aGVuIGEgZmF0YWwgbWVtb3J5IG1hbmFn ZW1lbnQKICAgIGVycm9yIG9jY3Vycy4gKi8KQEAgLTI3MSw5ICsyNTksNyBAQCAjZGVmaW5lIFJF U19DQVNFKHByZWZpeCwgaWQsIGRvYykgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIFwKIHN0YXRpYyBjb25zdCBjaGFyICoKIG1wc19yZXNfdG9fc3RyaW5nIChtcHNf cmVzX3QgcmVzKQogewotICAvKiBtcHNfcmVzX3QgaXMgdHlwZWRlZidkIHRvIGludCwgd2Ugd2Fu dCBhbiBlbnVtIHNvIEdDQyB3YXJucyBhYm91dAotICAgICBuZXcgY2FzZXMuICAqLwotICBzd2l0 Y2ggKChlbnVtIG1wc19yZXNfZW51bSkgcmVzKQorICBzd2l0Y2ggKHJlcykKICAgICB7CiAgICAg Y2FzZSBNUFNfUkVTX09LOgogICAgICAgcmV0dXJuICJvcGVyYXRpb24gc3VjY2VlZGVkIjsKLS0g CjIuNDguMQoK --00000000000027a994062c6658ee--
bug-gnu-emacs@HIDDEN:bug#75755; Package emacs.
Full text available.Received: (at 75755) by debbugs.gnu.org; 23 Jan 2025 19:58:54 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 23 14:58:54 2025 Received: from localhost ([127.0.0.1]:42488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tb3Lq-0001QT-7d for submit <at> debbugs.gnu.org; Thu, 23 Jan 2025 14:58:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42032) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tb3Ln-0001QF-7c for 75755 <at> debbugs.gnu.org; Thu, 23 Jan 2025 14:58:51 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tb3Lh-0001Mx-OI; Thu, 23 Jan 2025 14:58:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=suw1iPPJZiZgRSdvKzB7Wrp3vZIM/fjogo1lkNwVIPE=; b=e95Vn+zNPS5a C6YAMHC8RAuz/Oj4rGRYEgwMS9D84Q0bLqvtN9iyUo6CBF9F9uaZaoON6BK6iCgfA6+R5MbHGwaB4 sPv6OJ+nn3pC9vP0URw6QsjgGRv8+rdcSmm6o1PoQaJmFN4tZCpTe+3Sf0CV10VSyWTT+uQWSOsVD 3cgq7AlqT7exNtxHGvJMvyst1cj/LVf15WtTkkTokdOivNhuP2iAc/yXXSteCejUY65Rg3R016l6H hYlcVnvSWx0yqzw6+YOa4XmZsaOQ4HRVQKIDZVLP9EVibIA+fHZ067TwOKiCIwrPe6x6U/pYRFJSE nRdWEM6mIdmY+n7KZw3eqw==; Date: Thu, 23 Jan 2025 21:58:40 +0200 Message-Id: <86a5bhz4i7.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <CADwFkmk37ThraCpUYh7_fu7rQp0JMYzhFM58HPgXEn6seCz1JA@HIDDEN> (message from Stefan Kangas on Thu, 23 Jan 2025 13:28:18 -0600) Subject: Re: bug#75755: feature/igc: Missing IGC_CHECK_RES? References: <CADwFkmn9BViN83WBCOMNZZo78PQga0Zf9nODUm_MrigndM0jtA@HIDDEN> <CADwFkmmxmcBVD1JJh+avrJzU8RJgbJCFMv9Kfmhcoo5=s2RfWg@HIDDEN> <874j1q8sw2.fsf@HIDDEN> <CADwFkmnYJ2Dtcdw49--=ppO4XgNt6Dxs-HVAjChyRkv=y_8oRg@HIDDEN> <865xm62fik.fsf@HIDDEN> <878qr161kp.fsf@HIDDEN> <86y0z1zhqx.fsf@HIDDEN> <87r04t4fgm.fsf@HIDDEN> <86plkdzak4.fsf@HIDDEN> <871pwt4du5.fsf@HIDDEN> <86cygdz8qz.fsf@HIDDEN> <CADwFkmk37ThraCpUYh7_fu7rQp0JMYzhFM58HPgXEn6seCz1JA@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75755 Cc: pipcet@HIDDEN, eller.helmut@HIDDEN, gerd@HIDDEN, gerd.moellmann@HIDDEN, 75755 <at> debbugs.gnu.org, acorallo@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Stefan Kangas <stefankangas@HIDDEN> > Date: Thu, 23 Jan 2025 13:28:18 -0600 > Cc: gerd.moellmann@HIDDEN, 75755 <at> debbugs.gnu.org, gerd@HIDDEN, > eller.helmut@HIDDEN, acorallo@HIDDEN > > Eli Zaretskii <eliz@HIDDEN> writes: > > > I'm proposing to define, in igc.c, a set of strings, one each for > > every value of the enumeration. And then to use that in > > mps_res_to_string to produce a human-readable error message describing > > each mps_res_t value. > > Please let me know what you think of my most recent patch. If you want > something different, may I ask that you send a patch? I don't think > I understand if your idea is different from what I posted. Thanks. Your patch still uses _mps_RES_ENUM, which is a macro that's not supposed to be used outside of MPS. Isn't that so? I thought all this discussion was how to avoid using that macro, wasn't it?
bug-gnu-emacs@HIDDEN:bug#75755; Package emacs.
Full text available.Received: (at 75755) by debbugs.gnu.org; 23 Jan 2025 19:32:34 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 23 14:32:34 2025 Received: from localhost ([127.0.0.1]:42426 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tb2wI-00007I-Co for submit <at> debbugs.gnu.org; Thu, 23 Jan 2025 14:32:34 -0500 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:50384) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tb2wD-000072-SJ for 75755 <at> debbugs.gnu.org; Thu, 23 Jan 2025 14:32:26 -0500 Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-5d3cf094768so2590656a12.0 for <75755 <at> debbugs.gnu.org>; Thu, 23 Jan 2025 11:32:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737660740; x=1738265540; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=5iStuMJewVw9lV5sJHqobpposa0Jl3ZFKwBrPY8mgKg=; b=Csdnw/Oy7+yBCP65d6zKBFxJ341h4x0NMpWYUOI4suNOrWV4a6lj7xdkxT2sxET3UZ IJdh3ISXsGcpls6xL5+eibmJ6e6eJuLWlA4EYM7cW3xlsFVRWo5nM3TNTz8BxNmsNfY+ zH4oRoQDnTna04mAnVEyOpjWRicd/jXmHHqfxiilQ4RYhob5LwpCTwecyMb8J0WhmJ39 qp3Hjg/HVArx2FBtdox8zIjwNSLlSDiCfSdT7ySiIoFgyeWKdYcznRLHCZVhTs3ZBALd cP5aTwchwaEiPet6pNeBGRFVEotSk6C3mawcOkxk0+5qkgohkqGHuQVt7a0D+bgAaLx8 uBgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737660740; x=1738265540; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5iStuMJewVw9lV5sJHqobpposa0Jl3ZFKwBrPY8mgKg=; b=TRMJ7dEFFccKVDcuaoEJ/tKuh3XDjg+mS2wOzV5W3kv398hKbUAuMhF1M5RMwBeaTz s7soV/IyDpJJ97/jrUOnb0SCFurD7RDiLtPVWjW+Jyf2rk3AO1GUr7+KYghmS03Q2ZDH 8G1ZKP+sHOu3CSuNh51wFPC3+Us5XYUg+RUjCxdxTgDucnykgTwdiIxftAKBd+lZrQXw ExHaBdkW40977VMbk3AMo5IqrBdoVLcnWONHvATR9ydm+r1yYGW0qbZ6KFE6H+/9pGB5 EEtBOpywXtUfGiweaoh3z8eax2+Ne4w6IpJ5D+M8ta6Vl6l6sMBBFpKxLuaNe9t0HZH7 UwFQ== X-Forwarded-Encrypted: i=1; AJvYcCUc3lI3OqaXbI8j9AR41qvToMiyFbLIJrdssrkWBJjo39XcPYvWHmmR6nLXj4S+6Ae9WIFyRw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyLhBqG8Fbpowg6l/XWhfEHLEmSMC7Lz9dIS+5omwp3vzsV+f63 Xqcp6GsICx75lhjahOwqvImmTLYMUOslYR0qAPAMAr6Dx0+68/mXSngzmt9sQyco/58Mxy3W9iN mg7KVlrOSyvrAWyiy9mlGxrCcYks= X-Gm-Gg: ASbGncu3u4OOAiSPctWLjwKI5PXd4l8GeQF5XOzy6wRLqKzG4eHEQadCYH0CK346GSM YOa6B9+IvCveazaVmxeoq+epg1idIuQjsln1UT0BY8TYFGU9xC6Lzh+tGZ8+lQWA= X-Google-Smtp-Source: AGHT+IG1CnePe7nD1DW5QrTbORyGJuP0JuC2pkNU0TSYFH+Pa9eDXS0T8A16+9DjxDx7qGHZk1TfrwMWKAUupDNNjeY= X-Received: by 2002:a05:6402:5206:b0:5d0:f904:c23d with SMTP id 4fb4d7f45d1cf-5db7db1d558mr29708804a12.28.1737660739615; Thu, 23 Jan 2025 11:32:19 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 23 Jan 2025 13:32:19 -0600 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <87v7u52z3v.fsf@HIDDEN> References: <CADwFkmn9BViN83WBCOMNZZo78PQga0Zf9nODUm_MrigndM0jtA@HIDDEN> <CADwFkmmxmcBVD1JJh+avrJzU8RJgbJCFMv9Kfmhcoo5=s2RfWg@HIDDEN> <874j1q8sw2.fsf@HIDDEN> <CADwFkmnYJ2Dtcdw49--=ppO4XgNt6Dxs-HVAjChyRkv=y_8oRg@HIDDEN> <865xm62fik.fsf@HIDDEN> <878qr161kp.fsf@HIDDEN> <86y0z1zhqx.fsf@HIDDEN> <87r04t4fgm.fsf@HIDDEN> <CADwFkm=Lp1E8DSxuVC4vHw1_JzM_UnSTxfiFvv=pajeZ9kkPkw@HIDDEN> <87v7u52z3v.fsf@HIDDEN> MIME-Version: 1.0 Date: Thu, 23 Jan 2025 13:32:19 -0600 X-Gm-Features: AWEUYZk-fWPjxeVx2amm_xUGfGqm3u2TD6QZ4qwovUYkQDxG-itSd-gH0ry9mZo Message-ID: <CADwFkmnbKMhvJZ5Y+xTLqcYnMj90FpDZX-frQz0LAmXbki92Ug@HIDDEN> Subject: Re: bug#75755: feature/igc: Missing IGC_CHECK_RES? To: Pip Cet <pipcet@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75755 Cc: gerd@HIDDEN, eller.helmut@HIDDEN, gerd.moellmann@HIDDEN, 75755 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, acorallo@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Pip Cet <pipcet@HIDDEN> writes: > Please do. Thanks, I'm waiting to hear back from Eli as well. > I confess I tried to find a solution for the general case > here; unnamed enums are rare so worrying about that was inappropriate. No problem at all. It can be useful to take a broad look at things. My conclusion from our discussions about this is that I'd be happy to see improvements to GCC in this area. :-)
bug-gnu-emacs@HIDDEN:bug#75755; Package emacs.
Full text available.Received: (at 75755) by debbugs.gnu.org; 23 Jan 2025 19:28:37 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 23 14:28:37 2025 Received: from localhost ([127.0.0.1]:42415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tb2sS-0008Ki-Vx for submit <at> debbugs.gnu.org; Thu, 23 Jan 2025 14:28:37 -0500 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]:57814) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tb2sM-0008KA-RB for 75755 <at> debbugs.gnu.org; Thu, 23 Jan 2025 14:28:30 -0500 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5dbfab8a2b0so2550188a12.3 for <75755 <at> debbugs.gnu.org>; Thu, 23 Jan 2025 11:28:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737660499; x=1738265299; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=4Rt+YaF9Szx0souhtpo28ougW4ZP33gzLQIdLi1aL8M=; b=R20dwiNKcz+dCecwq3rt2HlE8IAGgpCe3YFncEzlLuE+8XnmqszvrAkYpHDoqaWl/R RDn60kp/dGnGEalf+0m+huvAT9MiG91tnjpOn+qIfMQnMiark2uDIGpLEFIf2n6id5Md vXHDw1+EBwbLO+EaAY5SshWrlqjuZdIIN3G+8Cu4ftbNQHJHXTus6q2iMSOV4sMN2uLK XaA8/JjL+TLRhpzD+JcVrmJFgD3G9penuWenKUHdd1VgE76GXEhEvS7+EqWFlGMHkDyV +xlB9sDSK14wZubCf4Yjy+PHFkcH8AYWilmk9dXacrY4EqrpW7DRUBiOJ5rB/XohYSX1 pO8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737660499; x=1738265299; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4Rt+YaF9Szx0souhtpo28ougW4ZP33gzLQIdLi1aL8M=; b=F/322qEaN7O0+1JOFYDViafb6+IAj2XROnMwEaIYquL+OyffDEfU8DLtDtaC0gY9P1 YpHA8KamwZMbQHbN2tQEFArIIBQ4yMBbEHBqa5U5dp0qsNRtztzezDVHElDVTQEOivcj QiovEhreiRxQ3cj5hoxWhZhb0gfMeybG0rzx5LlwGedTOFP1C03nMur7WgL6qWNuq0wm 6bfHmx8WEOfZ0kiVbbOvY1JX9h3ubSp90xGO+ASAo+jAOXu0uVXdSlb6ogHpLuuhjp2U QAXtpa22gwwOVdiavnsHZGMniOnq9ZDI9G3G4baZhp2G54QK0bhqUzOMy/wb53Xks2Tp V1sw== X-Forwarded-Encrypted: i=1; AJvYcCV87xjkKwD8bwGES6/8NaYHnqHyuLGscTh/3XZc2SX0f8kR6zgVFf6r+zLunS+P9je9oV4B8A==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyoqWfbvr5yYg5asyQikFNBU33iLzRJn+I3o5FgvFEOxNFqsnzp MxL2BnqqOm01pBsatTrzFo8UgxQ9Qe5t/BBT/uYJNWC/cjHyOCpkDQDJQHTrIeFlLWOGFn0Fz2G EWHgcly0Tq03l4R4EXq0VYLfKGBoHB6tFVNs= X-Gm-Gg: ASbGncuf0VO8wn8A0Pgzp7ymLuaqPMDYb1ra5lLePQqmsCk8bTevz/5paoY7lDRbDXz JK2JMoYr6e55DfOi/Uq6sLJx8a0ev/BDnSSJHtHuo/oJKRNn1OcqnOSmo/xjceATmcbSTrJ42uw == X-Google-Smtp-Source: AGHT+IGA/iJxqDlA2D1qSIA+MQw43SmFXFxte2CSLQXZbbkfaK9LDkHoU+hHl5pkw16snxHHsZGSQ/qXZG5vv7xZRJE= X-Received: by 2002:a05:6402:520e:b0:5cf:420a:9 with SMTP id 4fb4d7f45d1cf-5db7d2e8ff7mr26401688a12.5.1737660498589; Thu, 23 Jan 2025 11:28:18 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 23 Jan 2025 13:28:18 -0600 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <86cygdz8qz.fsf@HIDDEN> References: <CADwFkmn9BViN83WBCOMNZZo78PQga0Zf9nODUm_MrigndM0jtA@HIDDEN> <CADwFkmmxmcBVD1JJh+avrJzU8RJgbJCFMv9Kfmhcoo5=s2RfWg@HIDDEN> <874j1q8sw2.fsf@HIDDEN> <CADwFkmnYJ2Dtcdw49--=ppO4XgNt6Dxs-HVAjChyRkv=y_8oRg@HIDDEN> <865xm62fik.fsf@HIDDEN> <878qr161kp.fsf@HIDDEN> <86y0z1zhqx.fsf@HIDDEN> <87r04t4fgm.fsf@HIDDEN> <86plkdzak4.fsf@HIDDEN> <871pwt4du5.fsf@HIDDEN> <86cygdz8qz.fsf@HIDDEN> MIME-Version: 1.0 Date: Thu, 23 Jan 2025 13:28:18 -0600 X-Gm-Features: AWEUYZmXqYr2K_-Q8FRdFuc9L7C6Wl0qgvRFvluALAxmheHLyGwtJWTbCYzmb1E Message-ID: <CADwFkmk37ThraCpUYh7_fu7rQp0JMYzhFM58HPgXEn6seCz1JA@HIDDEN> Subject: Re: bug#75755: feature/igc: Missing IGC_CHECK_RES? To: Eli Zaretskii <eliz@HIDDEN>, Pip Cet <pipcet@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75755 Cc: gerd.moellmann@HIDDEN, 75755 <at> debbugs.gnu.org, acorallo@HIDDEN, eller.helmut@HIDDEN, gerd@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: > I'm proposing to define, in igc.c, a set of strings, one each for > every value of the enumeration. And then to use that in > mps_res_to_string to produce a human-readable error message describing > each mps_res_t value. Please let me know what you think of my most recent patch. If you want something different, may I ask that you send a patch? I don't think I understand if your idea is different from what I posted. Thanks.
bug-gnu-emacs@HIDDEN:bug#75755; Package emacs.
Full text available.Received: (at 75755) by debbugs.gnu.org; 23 Jan 2025 18:27:28 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 23 13:27:27 2025 Received: from localhost ([127.0.0.1]:42327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tb1vL-0005Nq-6s for submit <at> debbugs.gnu.org; Thu, 23 Jan 2025 13:27:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38454) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tb1vH-0005NX-EV for 75755 <at> debbugs.gnu.org; Thu, 23 Jan 2025 13:27:24 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tb1vA-0002Di-VI; Thu, 23 Jan 2025 13:27:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Xih2E10VscY1stlY5CIEKsSSSj9d8oG7LoS7vweeVBU=; b=HBGIYllmejyp VkzUIwTPErspHWEL9+v86w73HwWHRFSjkn1QqRe2Z8MYBi87LYvB4DpzHAGHX6lrVqKly9hRUeZv/ rx3ehvwGePjDVgiMlU1n9ottePjOlWDP1Ww0xO7ZrDBZa+8HdxeraCQAn3xMJvjLT/Zu838rdDccp i7T0AXeQIe83fyZKIujjV1VuncHgY9VBcfkbSMyBkrFqcjBETJg6VvQjXJt/oFmNp0C0E6I0xtV9t Pm1IjeNg8GEFiPR64qlHy+H5Tr7pE3fW/YGVcLW0F6k3yGwJRZDBAtmBUTcirNyUnhw01m/RmiHO+ 48zqvhoYd3RlGKUej7IcIA==; Date: Thu, 23 Jan 2025 20:27:00 +0200 Message-Id: <86cygdz8qz.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Pip Cet <pipcet@HIDDEN> In-Reply-To: <871pwt4du5.fsf@HIDDEN> (message from Pip Cet on Thu, 23 Jan 2025 17:53:01 +0000) Subject: Re: bug#75755: feature/igc: Missing IGC_CHECK_RES? References: <CADwFkmn9BViN83WBCOMNZZo78PQga0Zf9nODUm_MrigndM0jtA@HIDDEN> <CADwFkmmxmcBVD1JJh+avrJzU8RJgbJCFMv9Kfmhcoo5=s2RfWg@HIDDEN> <874j1q8sw2.fsf@HIDDEN> <CADwFkmnYJ2Dtcdw49--=ppO4XgNt6Dxs-HVAjChyRkv=y_8oRg@HIDDEN> <865xm62fik.fsf@HIDDEN> <878qr161kp.fsf@HIDDEN> <86y0z1zhqx.fsf@HIDDEN> <87r04t4fgm.fsf@HIDDEN> <86plkdzak4.fsf@HIDDEN> <871pwt4du5.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75755 Cc: gerd@HIDDEN, eller.helmut@HIDDEN, gerd.moellmann@HIDDEN, 75755 <at> debbugs.gnu.org, stefankangas@HIDDEN, acorallo@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Thu, 23 Jan 2025 17:53:01 +0000 > From: Pip Cet <pipcet@HIDDEN> > Cc: stefankangas@HIDDEN, gerd.moellmann@HIDDEN, 75755 <at> debbugs.gnu.org, gerd@HIDDEN, eller.helmut@HIDDEN, acorallo@HIDDEN > > "Eli Zaretskii" <eliz@HIDDEN> writes: > > >> Date: Thu, 23 Jan 2025 17:17:54 +0000 > >> From: Pip Cet <pipcet@HIDDEN> > >> Cc: stefankangas@HIDDEN, gerd.moellmann@HIDDEN, 75755 <at> debbugs.gnu.org, gerd@HIDDEN, eller.helmut@HIDDEN, acorallo@HIDDEN > >> > >> "Eli Zaretskii" <eliz@HIDDEN> writes: > >> > >> >> Date: Thu, 23 Jan 2025 14:34:56 +0000 > >> >> From: Pip Cet <pipcet@HIDDEN> > >> >> Cc: Stefan Kangas <stefankangas@HIDDEN>, gerd.moellmann@HIDDEN, 75755 <at> debbugs.gnu.org, gerd@HIDDEN, eller.helmut@HIDDEN, acorallo@HIDDEN > >> >> > >> >> "Eli Zaretskii" <eliz@HIDDEN> writes: > >> >> > >> >> > IMO, the single use of this macro is not worth of the complications > >> >> > due to relying on an internal enumeration macro. The single function > >> >> > which uses this is a testing tool, which on top of that warns in its > >> >> > doc string not to use it. Introducing significant complexity and > >> >> > breakage potential into Emacs due to this is IMO a tail wagging the > >> >> > dog. > >> >> > >> >> I agree with this paragraph; it's not worth it, let's drop the code. > >> >> > >> >> > So I suggest that we define our own enumeration. We could copy some > >> >> > >> >> Why? > >> > > >> > Because it's easy, and will still give us human-readable error > >> > messages. > >> > >> How does defining an enum give us that? Did you mean "our own switch > >> statement"? If so, what's wrong with the one on the current branch? > > > > We are talking past each other. I meant the readable text that comes > > with each enum value: > > > > #define _mps_RES_ENUM(R, X) \ > > R(X, OK, "success (always zero)") \ > > R(X, FAIL, "unspecified failure") \ > > R(X, RESOURCE, "unable to obtain resources") \ > > R(X, MEMORY, "unable to obtain memory") \ > > R(X, LIMIT, "limitation reached") \ > > R(X, UNIMPL, "unimplemented facility") \ > > R(X, IO, "system I/O error") \ > > R(X, COMMIT_LIMIT, "arena commit limit exceeded") \ > > R(X, PARAM, "illegal user parameter value") > > > > which mps_res_to_string uses to produce a string for each value of > > mps_res_t. > > > > IOW, I was not talking about defining an enum, I was talking about > > defining a text string for each value of enum. > > So what are you suggesting be changed? We do that with a switch > statement, in mps_res_to_string. Are you proposing to do it another > way? I'm proposing to define, in igc.c, a set of strings, one each for every value of the enumeration. And then to use that in mps_res_to_string to produce a human-readable error message describing each mps_res_t value.
bug-gnu-emacs@HIDDEN:bug#75755; Package emacs.
Full text available.Received: (at 75755) by debbugs.gnu.org; 23 Jan 2025 17:56:45 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 23 12:56:45 2025 Received: from localhost ([127.0.0.1]:42248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tb1Rc-0003sZ-OW for submit <at> debbugs.gnu.org; Thu, 23 Jan 2025 12:56:45 -0500 Received: from mail-40131.protonmail.ch ([185.70.40.131]:60449) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <pipcet@HIDDEN>) id 1tb1RZ-0003sC-EF for 75755 <at> debbugs.gnu.org; Thu, 23 Jan 2025 12:56:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1737654994; x=1737914194; bh=IAnKpD9RN8nDgTDHIbewMYM56HZY7VBCu3H3GuTMEO0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=TcwOJiCrYGYlxZdotNW9NGVPD/Q+6WZsGFkHgY8rx7mpiRuMD7wQCmXX2lU/LbiaU TmvSkuxP0eKKweEeW1z23XqgXY/fqDnU3LRjx1bFnWLIapEHxkeqxmrDZZA5u10A4w NiX5AJifCubBWpH1ZqkUi72q2Xu4YYpB7roWrAe7bexD6zrcrhCyFleSgWn3jJk74c 8t4aRpnCQ9xghbjySa7bk3wCvPcbQXr4mnCB60InirDaaQMTG3NmM/eF6EXxV/GpGB auEqwzlPwLnWPEKUVPgNvhk0RXVtSaqnlZk8Tc8LChzqhXxXFG8ZF0UJQ6TzHxGERO 23T5c9sRwN78A== Date: Thu, 23 Jan 2025 17:56:31 +0000 To: Stefan Kangas <stefankangas@HIDDEN> From: Pip Cet <pipcet@HIDDEN> Subject: Re: bug#75755: feature/igc: Missing IGC_CHECK_RES? Message-ID: <87v7u52z3v.fsf@HIDDEN> In-Reply-To: <CADwFkm=Lp1E8DSxuVC4vHw1_JzM_UnSTxfiFvv=pajeZ9kkPkw@HIDDEN> References: <CADwFkmn9BViN83WBCOMNZZo78PQga0Zf9nODUm_MrigndM0jtA@HIDDEN> <CADwFkmmxmcBVD1JJh+avrJzU8RJgbJCFMv9Kfmhcoo5=s2RfWg@HIDDEN> <874j1q8sw2.fsf@HIDDEN> <CADwFkmnYJ2Dtcdw49--=ppO4XgNt6Dxs-HVAjChyRkv=y_8oRg@HIDDEN> <865xm62fik.fsf@HIDDEN> <878qr161kp.fsf@HIDDEN> <86y0z1zhqx.fsf@HIDDEN> <87r04t4fgm.fsf@HIDDEN> <CADwFkm=Lp1E8DSxuVC4vHw1_JzM_UnSTxfiFvv=pajeZ9kkPkw@HIDDEN> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 696891740a5f0a61eb96bfa9fae0cde45c80147a MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 75755 Cc: gerd@HIDDEN, eller.helmut@HIDDEN, gerd.moellmann@HIDDEN, 75755 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, acorallo@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) "Stefan Kangas" <stefankangas@HIDDEN> writes: > Pip Cet <pipcet@HIDDEN> writes: > >> "Eli Zaretskii" <eliz@HIDDEN> writes: >> >>>> Date: Thu, 23 Jan 2025 14:34:56 +0000 >>>> From: Pip Cet <pipcet@HIDDEN> >>>> Cc: Stefan Kangas <stefankangas@HIDDEN>, gerd.moellmann@HIDDEN, = 75755 <at> debbugs.gnu.org, gerd@HIDDEN, eller.helmut@HIDDEN, acorallo@HIDDEN= rg >>>> >>>> "Eli Zaretskii" <eliz@HIDDEN> writes: >>>> >>>> > IMO, the single use of this macro is not worth of the complications >>>> > due to relying on an internal enumeration macro. The single functio= n >>>> > which uses this is a testing tool, which on top of that warns in its >>>> > doc string not to use it. Introducing significant complexity and >>>> > breakage potential into Emacs due to this is IMO a tail wagging the >>>> > dog. >>>> >>>> I agree with this paragraph; it's not worth it, let's drop the code. >>>> >>>> > So I suggest that we define our own enumeration. We could copy some >>>> >>>> Why? >>> >>> Because it's easy, and will still give us human-readable error >>> messages. >> >> How does defining an enum give us that? Did you mean "our own switch >> statement"? If so, what's wrong with the one on the current branch? > > FWIW, I'd keep it simple here and just install this. At the end of the Please do. I confess I tried to find a solution for the general case here; unnamed enums are rare so worrying about that was inappropriate. Pip
bug-gnu-emacs@HIDDEN:bug#75755; Package emacs.
Full text available.Received: (at 75755) by debbugs.gnu.org; 23 Jan 2025 17:53:16 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 23 12:53:16 2025 Received: from localhost ([127.0.0.1]:42240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tb1OG-0003gE-41 for submit <at> debbugs.gnu.org; Thu, 23 Jan 2025 12:53:16 -0500 Received: from mail-10630.protonmail.ch ([79.135.106.30]:44049) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <pipcet@HIDDEN>) id 1tb1OD-0003fu-LB for 75755 <at> debbugs.gnu.org; Thu, 23 Jan 2025 12:53:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1737654786; x=1737913986; bh=WLFoJhvsVBaQ0opyQYHHqArB0vGXny0ZdEUggSGjmv8=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=QYdiu/lpohUFYvKjoLaTnOj8xLkA9g7GEr0l5aYoUiOnmuwsnL0m4WKxYoT9svTaU t2KPulhAt/2As6pxhY2a5NtqdSwgUedpmBwozFKT3FmxSx1qu8iQ3vxJ6/1fsaItXZ IoeT2LIalDJWxDI5Sg+ZG3lfZhEbABls2WLBwhgn4JB3bSH2myeyLuAMfBAv9S3+q/ eIZ4o9O5suh8xAPfs7kbP7uSGALaTnR/EXWJ+EiFBHSL/JEiEI4sbnxGC2AK3PEVuI PQ61t5ndIcUgsICCnXyRhlWI7+QQBdjVyyhbQOzVoTPmdwJU+Vanj8loXIar0DqII+ 4dq45ac/YE+eg== Date: Thu, 23 Jan 2025 17:53:01 +0000 To: Eli Zaretskii <eliz@HIDDEN> From: Pip Cet <pipcet@HIDDEN> Subject: Re: bug#75755: feature/igc: Missing IGC_CHECK_RES? Message-ID: <871pwt4du5.fsf@HIDDEN> In-Reply-To: <86plkdzak4.fsf@HIDDEN> References: <CADwFkmn9BViN83WBCOMNZZo78PQga0Zf9nODUm_MrigndM0jtA@HIDDEN> <CADwFkmmxmcBVD1JJh+avrJzU8RJgbJCFMv9Kfmhcoo5=s2RfWg@HIDDEN> <874j1q8sw2.fsf@HIDDEN> <CADwFkmnYJ2Dtcdw49--=ppO4XgNt6Dxs-HVAjChyRkv=y_8oRg@HIDDEN> <865xm62fik.fsf@HIDDEN> <878qr161kp.fsf@HIDDEN> <86y0z1zhqx.fsf@HIDDEN> <87r04t4fgm.fsf@HIDDEN> <86plkdzak4.fsf@HIDDEN> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 89e5ae8cfab1fabcc805d00a26001b265a9beea7 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75755 Cc: gerd@HIDDEN, eller.helmut@HIDDEN, gerd.moellmann@HIDDEN, 75755 <at> debbugs.gnu.org, stefankangas@HIDDEN, acorallo@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) "Eli Zaretskii" <eliz@HIDDEN> writes: >> Date: Thu, 23 Jan 2025 17:17:54 +0000 >> From: Pip Cet <pipcet@HIDDEN> >> Cc: stefankangas@HIDDEN, gerd.moellmann@HIDDEN, 75755@HIDDEN= org, gerd@HIDDEN, eller.helmut@HIDDEN, acorallo@HIDDEN >> >> "Eli Zaretskii" <eliz@HIDDEN> writes: >> >> >> Date: Thu, 23 Jan 2025 14:34:56 +0000 >> >> From: Pip Cet <pipcet@HIDDEN> >> >> Cc: Stefan Kangas <stefankangas@HIDDEN>, gerd.moellmann@HIDDEN,= 75755 <at> debbugs.gnu.org, gerd@HIDDEN, eller.helmut@HIDDEN, acorallo@gnu.= org >> >> >> >> "Eli Zaretskii" <eliz@HIDDEN> writes: >> >> >> >> > IMO, the single use of this macro is not worth of the complications >> >> > due to relying on an internal enumeration macro. The single functi= on >> >> > which uses this is a testing tool, which on top of that warns in it= s >> >> > doc string not to use it. Introducing significant complexity and >> >> > breakage potential into Emacs due to this is IMO a tail wagging the >> >> > dog. >> >> >> >> I agree with this paragraph; it's not worth it, let's drop the code. >> >> >> >> > So I suggest that we define our own enumeration. We could copy som= e >> >> >> >> Why? >> > >> > Because it's easy, and will still give us human-readable error >> > messages. >> >> How does defining an enum give us that? Did you mean "our own switch >> statement"? If so, what's wrong with the one on the current branch? > > We are talking past each other. I meant the readable text that comes > with each enum value: > > #define _mps_RES_ENUM(R, X) \ > R(X, OK, "success (always zero)") \ > R(X, FAIL, "unspecified failure") \ > R(X, RESOURCE, "unable to obtain resources") \ > R(X, MEMORY, "unable to obtain memory") \ > R(X, LIMIT, "limitation reached") \ > R(X, UNIMPL, "unimplemented facility") \ > R(X, IO, "system I/O error") \ > R(X, COMMIT_LIMIT, "arena commit limit exceeded") \ > R(X, PARAM, "illegal user parameter value") > > which mps_res_to_string uses to produce a string for each value of > mps_res_t. > > IOW, I was not talking about defining an enum, I was talking about > defining a text string for each value of enum. So what are you suggesting be changed? We do that with a switch statement, in mps_res_to_string. Are you proposing to do it another way? Pip
bug-gnu-emacs@HIDDEN:bug#75755; Package emacs.
Full text available.
Received: (at 75755) by debbugs.gnu.org; 23 Jan 2025 17:52:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 23 12:52:02 2025
Received: from localhost ([127.0.0.1]:42230 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tb1N3-0003dP-Kb
for submit <at> debbugs.gnu.org; Thu, 23 Jan 2025 12:52:02 -0500
Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:49462)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
id 1tb1Mz-0003d1-Nl
for 75755 <at> debbugs.gnu.org; Thu, 23 Jan 2025 12:51:59 -0500
Received: by mail-ed1-x52e.google.com with SMTP id
4fb4d7f45d1cf-5da135d3162so2053738a12.3
for <75755 <at> debbugs.gnu.org>; Thu, 23 Jan 2025 09:51:57 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1737654711; x=1738259511; darn=debbugs.gnu.org;
h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
:from:from:to:cc:subject:date:message-id:reply-to;
bh=fZpDVjbm2b94iYJo4cV+ZFJsdm9YzeMqzWZ51AcrwFM=;
b=mx69zzivtKRsMfZxm2FQxzzNEwWuF6cKosqOvazOwjiT+Ki9cwkGZNRvTRUfVFQQ3E
RjRtnfq45iIKSXVmC+3EZ15ggMJLaH3IW3ZJs9AUiTE76dTf0nm3Ng03dmwQO7Uv04G4
dRPozakNALfiQaJXtBzeEjcRhNN0BmLaDgy0/uSuif5JpNJ52/AMzh4fPPsRb93HOKi0
ro+l4Uv8JZRb+2sfLji8kyifjJL7zJPlSZLMgT60AC4YoNDtCRucIyi6B7S5pSAJLn9s
p845Y3I0vUlTHbtYWJsJ3J7yHt+u2FNmTY1qDc7hELmrv4qzvt1UwsKtBb4I4mMMQbpE
C3Wg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1737654711; x=1738259511;
h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
:from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=fZpDVjbm2b94iYJo4cV+ZFJsdm9YzeMqzWZ51AcrwFM=;
b=c0LMNuhSvMPTHgPN7FLmPvlA/9XLjzpq7ZkzHorfMzA0owXSt2RhODAOIUAEIGcSGN
mhrO/XGSKez9KwqEgItJXB3lM+dBRxMOLzdUtyWU69t9OntT25qcusmA1c6E6HjhKLf0
55ahu2rEuPv+q5lmyKwGDF6Zjvkbj7CIL8JeEOgmn3Sbw+DeBAW5WrO8AMhQXfZXm4A8
ywtowtZu5bTnG/EJ2sqFqaCd7OCpv1AKRi5QJH7bmqNJ7bm7kdCLaHB43+uJQA/6Adep
RczDWNwH5xCiT0pgrkqv2jPUMWA6UW2vAr2FTsPd7HZC9AGTtViRA7ZQujiar6ZrU2rp
EqHg==
X-Forwarded-Encrypted: i=1;
AJvYcCWvFqUYoEdQvMGq286FWxXUrL6mtB8RKk08j+xRDJ2SSeferlzbF9PVaKKz0hyv5xqiNAdNvA==@debbugs.gnu.org
X-Gm-Message-State: AOJu0Yz8UBhaYoJXz+T4cbGAZTNd9nh2pNZPpBJWOVMPbSWWu9hvLsWi
y7Yp0tZkIW91q+HGVP2euoIsAmnaFVIXTcQWelMRe8klwQpSWL4coWLuXQp8TVZ1L7unpp7l6QE
3iFl5Vb+sKlTG/CUBGCJjTO/QsNSZgyTvPNE=
X-Gm-Gg: ASbGncvS5o44qevPl32BmrXa01xFF7ppVX+/UkZXaZh2HltwOOl4xLPm+rK3gDR9X6S
9H8C5I5mvWVjyzxwKX3oQi3tVEnqkyaG1eVlVBUgzT1g81ah+fod8GEoHCD0/229W8YuR5P8=
X-Google-Smtp-Source: AGHT+IGspHIfWv+0Q2U1AcLmPjr+1sq4/R1cYoNNltLE5aRVgxoyqY9AhNY04htgteiWpGI1dgnsBqi//EJUV6wKbwo=
X-Received: by 2002:a05:6402:2807:b0:5db:7316:6309 with SMTP id
4fb4d7f45d1cf-5db7d2dc140mr24665066a12.7.1737654711283; Thu, 23 Jan 2025
09:51:51 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
HTTPREST; Thu, 23 Jan 2025 11:51:50 -0600
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <87r04t4fgm.fsf@HIDDEN>
References: <CADwFkmn9BViN83WBCOMNZZo78PQga0Zf9nODUm_MrigndM0jtA@HIDDEN>
<878qr3dr3j.fsf@HIDDEN> <87zfjjca9o.fsf@HIDDEN>
<m25xm7vtuz.fsf@HIDDEN>
<CADwFkmmxmcBVD1JJh+avrJzU8RJgbJCFMv9Kfmhcoo5=s2RfWg@HIDDEN>
<874j1q8sw2.fsf@HIDDEN>
<CADwFkmnYJ2Dtcdw49--=ppO4XgNt6Dxs-HVAjChyRkv=y_8oRg@HIDDEN>
<865xm62fik.fsf@HIDDEN> <878qr161kp.fsf@HIDDEN>
<86y0z1zhqx.fsf@HIDDEN> <87r04t4fgm.fsf@HIDDEN>
MIME-Version: 1.0
Date: Thu, 23 Jan 2025 11:51:50 -0600
X-Gm-Features: AWEUYZkXFJFinc1uovllkdACOIs9dzMohLBpSvNaDt2E3mS3fTwppqG_n1-GI9s
Message-ID: <CADwFkm=Lp1E8DSxuVC4vHw1_JzM_UnSTxfiFvv=pajeZ9kkPkw@HIDDEN>
Subject: Re: bug#75755: feature/igc: Missing IGC_CHECK_RES?
To: Pip Cet <pipcet@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75755
Cc: gerd.moellmann@HIDDEN, 75755 <at> debbugs.gnu.org, acorallo@HIDDEN,
eller.helmut@HIDDEN, gerd@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Pip Cet <pipcet@HIDDEN> writes:
> "Eli Zaretskii" <eliz@HIDDEN> writes:
>
>>> Date: Thu, 23 Jan 2025 14:34:56 +0000
>>> From: Pip Cet <pipcet@HIDDEN>
>>> Cc: Stefan Kangas <stefankangas@HIDDEN>, gerd.moellmann@HIDDEN, 75755 <at> debbugs.gnu.org, gerd@HIDDEN, eller.helmut@HIDDEN, acorallo@HIDDEN
>>>
>>> "Eli Zaretskii" <eliz@HIDDEN> writes:
>>>
>>> > IMO, the single use of this macro is not worth of the complications
>>> > due to relying on an internal enumeration macro. The single function
>>> > which uses this is a testing tool, which on top of that warns in its
>>> > doc string not to use it. Introducing significant complexity and
>>> > breakage potential into Emacs due to this is IMO a tail wagging the
>>> > dog.
>>>
>>> I agree with this paragraph; it's not worth it, let's drop the code.
>>>
>>> > So I suggest that we define our own enumeration. We could copy some
>>>
>>> Why?
>>
>> Because it's easy, and will still give us human-readable error
>> messages.
>
> How does defining an enum give us that? Did you mean "our own switch
> statement"? If so, what's wrong with the one on the current branch?
FWIW, I'd keep it simple here and just install this. At the end of the
day, while suboptimal, it's also not the end of the world if a new error
returns the "unknown error" string. We do get the numerical error code,
so we can always decipher it.
diff --git a/src/igc.c b/src/igc.c
index 57c13614f73..b02d29ca4da 100644
--- a/src/igc.c
+++ b/src/igc.c
@@ -252,18 +252,6 @@
static enum igc_state igc_state = IGC_STATE_INITIAL;
static void set_state (enum igc_state state);
-/* Define a named enumeration containing all cases that the integer type
- mps_res_t is known to cover. */
-
-#define RES_CASE(prefix, id, doc) \
- id,
-
-enum mps_res_enum
-{
- _mps_RES_ENUM (RES_CASE, MPS_RES_)
-};
-#undef RES_CASE
-
/* Convert an mps result code into a result string. This shouldn't
allocate memory because it's called when a fatal memory management
error occurs. */
@@ -271,9 +259,7 @@ #define RES_CASE(prefix, id, doc)
\
static const char *
mps_res_to_string (mps_res_t res)
{
- /* mps_res_t is typedef'd to int, we want an enum so GCC warns about
- new cases. */
- switch ((enum mps_res_enum) res)
+ switch (res)
{
case MPS_RES_OK:
return "operation succeeded";
bug-gnu-emacs@HIDDEN:bug#75755; Package emacs.
Full text available.
Received: (at 75755) by debbugs.gnu.org; 23 Jan 2025 17:48:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 23 12:48:14 2025
Received: from localhost ([127.0.0.1]:42211 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tb1JO-0003QX-5C
for submit <at> debbugs.gnu.org; Thu, 23 Jan 2025 12:48:14 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:59770)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tb1JJ-0003QF-N2
for 75755 <at> debbugs.gnu.org; Thu, 23 Jan 2025 12:48:11 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1tb1JE-0002l3-9R; Thu, 23 Jan 2025 12:48:04 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=Pf6KB08+2CxnWrf9l2cFzBeLZ1vaEP+aixaVYjc6kUo=; b=olm5bhoTs4Lp
PLkRKoynoNCDbTWXSciM40tnK/JeVztnN2JCWKyuzRBuYTqNFhwY6idW26fbHPrg4qDUdl+PZ4XE2
goiWuWOCh3/yE/+zawpY+78tYSrIWAQmQdpXXVDU/qXCfduXmDOatoXi/XKqyvOVc3MRE5y5pSvZO
Kpm9QllDOVgm4CaFLhfKyn+WSPEi5krreDkLetNBgOgy+XdlxL4bDviclT/e3ZgfFpAwEZTHsOGnz
bPBrCrfjkTmIO8g2TRrYlH1fcW4tMJR/CcWsargOaicClzp6jQaS9XfyedYOE0solPaj5wCLALi4H
X0HoLmH0fyEUSQd4PcSq9Q==;
Date: Thu, 23 Jan 2025 19:47:55 +0200
Message-Id: <86plkdzak4.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Pip Cet <pipcet@HIDDEN>
In-Reply-To: <87r04t4fgm.fsf@HIDDEN> (message from Pip Cet on Thu, 23
Jan 2025 17:17:54 +0000)
Subject: Re: bug#75755: feature/igc: Missing IGC_CHECK_RES?
References: <CADwFkmn9BViN83WBCOMNZZo78PQga0Zf9nODUm_MrigndM0jtA@HIDDEN>
<878qr3dr3j.fsf@HIDDEN> <87zfjjca9o.fsf@HIDDEN>
<m25xm7vtuz.fsf@HIDDEN>
<CADwFkmmxmcBVD1JJh+avrJzU8RJgbJCFMv9Kfmhcoo5=s2RfWg@HIDDEN>
<874j1q8sw2.fsf@HIDDEN>
<CADwFkmnYJ2Dtcdw49--=ppO4XgNt6Dxs-HVAjChyRkv=y_8oRg@HIDDEN>
<865xm62fik.fsf@HIDDEN> <878qr161kp.fsf@HIDDEN>
<86y0z1zhqx.fsf@HIDDEN> <87r04t4fgm.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 75755
Cc: gerd@HIDDEN, eller.helmut@HIDDEN, gerd.moellmann@HIDDEN,
75755 <at> debbugs.gnu.org, stefankangas@HIDDEN, acorallo@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Date: Thu, 23 Jan 2025 17:17:54 +0000
> From: Pip Cet <pipcet@HIDDEN>
> Cc: stefankangas@HIDDEN, gerd.moellmann@HIDDEN, 75755 <at> debbugs.gnu.org, gerd@HIDDEN, eller.helmut@HIDDEN, acorallo@HIDDEN
>
> "Eli Zaretskii" <eliz@HIDDEN> writes:
>
> >> Date: Thu, 23 Jan 2025 14:34:56 +0000
> >> From: Pip Cet <pipcet@HIDDEN>
> >> Cc: Stefan Kangas <stefankangas@HIDDEN>, gerd.moellmann@HIDDEN, 75755 <at> debbugs.gnu.org, gerd@HIDDEN, eller.helmut@HIDDEN, acorallo@HIDDEN
> >>
> >> "Eli Zaretskii" <eliz@HIDDEN> writes:
> >>
> >> > IMO, the single use of this macro is not worth of the complications
> >> > due to relying on an internal enumeration macro. The single function
> >> > which uses this is a testing tool, which on top of that warns in its
> >> > doc string not to use it. Introducing significant complexity and
> >> > breakage potential into Emacs due to this is IMO a tail wagging the
> >> > dog.
> >>
> >> I agree with this paragraph; it's not worth it, let's drop the code.
> >>
> >> > So I suggest that we define our own enumeration. We could copy some
> >>
> >> Why?
> >
> > Because it's easy, and will still give us human-readable error
> > messages.
>
> How does defining an enum give us that? Did you mean "our own switch
> statement"? If so, what's wrong with the one on the current branch?
We are talking past each other. I meant the readable text that comes
with each enum value:
#define _mps_RES_ENUM(R, X) \
R(X, OK, "success (always zero)") \
R(X, FAIL, "unspecified failure") \
R(X, RESOURCE, "unable to obtain resources") \
R(X, MEMORY, "unable to obtain memory") \
R(X, LIMIT, "limitation reached") \
R(X, UNIMPL, "unimplemented facility") \
R(X, IO, "system I/O error") \
R(X, COMMIT_LIMIT, "arena commit limit exceeded") \
R(X, PARAM, "illegal user parameter value")
which mps_res_to_string uses to produce a string for each value of
mps_res_t.
IOW, I was not talking about defining an enum, I was talking about
defining a text string for each value of enum.
bug-gnu-emacs@HIDDEN:bug#75755; Package emacs.
Full text available.Received: (at 75755) by debbugs.gnu.org; 23 Jan 2025 17:18:11 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 23 12:18:11 2025 Received: from localhost ([127.0.0.1]:42133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tb0qJ-0001zM-DJ for submit <at> debbugs.gnu.org; Thu, 23 Jan 2025 12:18:11 -0500 Received: from mail-40133.protonmail.ch ([185.70.40.133]:24315) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <pipcet@HIDDEN>) id 1tb0qF-0001yu-JS for 75755 <at> debbugs.gnu.org; Thu, 23 Jan 2025 12:18:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1737652680; x=1737911880; bh=nQa+L+zY4sK4acKehewV93Ndxrg4ao4Yw0vl10QDdVQ=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=QiyUBeylNdSgV5nBPcUMRsZzrhgQfCM+zUmpXl1WflXYreNpjk32ob6beg1zSH7nQ jDbYpf78vJsBfEcHkaqs7ngc4w3KlcBSVdqop//kbR7L1oKSJ3DtH431dor2RCV43z gjICABVjZ4xBG+aPOwijJvVHfbHw9zn/vr2KtzY+ByD6K+PbJq05UMuZnzoSHtV1r7 8sdWdX0hxoTL1j54i5m04lV+aXPfJkkbU0je1KuQ96kpGSMv9PjUgG6B0tEehrNpEV UvEnIfde/XHPeVtBf4cWR025bu7Gs+EMcl7DTyLvArxHEgQaJUuW+wqT5K8kuWj/bt dJkswcl7QjFxQ== Date: Thu, 23 Jan 2025 17:17:54 +0000 To: Eli Zaretskii <eliz@HIDDEN> From: Pip Cet <pipcet@HIDDEN> Subject: Re: bug#75755: feature/igc: Missing IGC_CHECK_RES? Message-ID: <87r04t4fgm.fsf@HIDDEN> In-Reply-To: <86y0z1zhqx.fsf@HIDDEN> References: <CADwFkmn9BViN83WBCOMNZZo78PQga0Zf9nODUm_MrigndM0jtA@HIDDEN> <878qr3dr3j.fsf@HIDDEN> <87zfjjca9o.fsf@HIDDEN> <m25xm7vtuz.fsf@HIDDEN> <CADwFkmmxmcBVD1JJh+avrJzU8RJgbJCFMv9Kfmhcoo5=s2RfWg@HIDDEN> <874j1q8sw2.fsf@HIDDEN> <CADwFkmnYJ2Dtcdw49--=ppO4XgNt6Dxs-HVAjChyRkv=y_8oRg@HIDDEN> <865xm62fik.fsf@HIDDEN> <878qr161kp.fsf@HIDDEN> <86y0z1zhqx.fsf@HIDDEN> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: dc6876662703d2500f98a78383ccf92acb85bd95 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75755 Cc: gerd@HIDDEN, eller.helmut@HIDDEN, gerd.moellmann@HIDDEN, 75755 <at> debbugs.gnu.org, stefankangas@HIDDEN, acorallo@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) "Eli Zaretskii" <eliz@HIDDEN> writes: >> Date: Thu, 23 Jan 2025 14:34:56 +0000 >> From: Pip Cet <pipcet@HIDDEN> >> Cc: Stefan Kangas <stefankangas@HIDDEN>, gerd.moellmann@HIDDEN, 75= 755 <at> debbugs.gnu.org, gerd@HIDDEN, eller.helmut@HIDDEN, acorallo@HIDDEN >> >> "Eli Zaretskii" <eliz@HIDDEN> writes: >> >> > IMO, the single use of this macro is not worth of the complications >> > due to relying on an internal enumeration macro. The single function >> > which uses this is a testing tool, which on top of that warns in its >> > doc string not to use it. Introducing significant complexity and >> > breakage potential into Emacs due to this is IMO a tail wagging the >> > dog. >> >> I agree with this paragraph; it's not worth it, let's drop the code. >> >> > So I suggest that we define our own enumeration. We could copy some >> >> Why? > > Because it's easy, and will still give us human-readable error > messages. How does defining an enum give us that? Did you mean "our own switch statement"? If so, what's wrong with the one on the current branch? Pip
bug-gnu-emacs@HIDDEN:bug#75755; Package emacs.
Full text available.Received: (at 75755) by debbugs.gnu.org; 23 Jan 2025 15:13:16 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 23 10:13:16 2025 Received: from localhost ([127.0.0.1]:41896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1taytP-0004Bg-KW for submit <at> debbugs.gnu.org; Thu, 23 Jan 2025 10:13:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44828) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1taytN-0004BN-AS for 75755 <at> debbugs.gnu.org; Thu, 23 Jan 2025 10:13:13 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1taytH-0006s3-F7; Thu, 23 Jan 2025 10:13:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=imq42pr5czrj3VQkw9NEBm+dAeI7hMJtZbiuwrb1qqw=; b=h5Tf+h7mmHsI iHAGnFJrCaGBXJpZ5QKUPf/+85JXMAY7+xBNvfZaJQLphydIDUV6Ee5lWkrDW678OSnX1u/+jYuaL /LJ7oN3popjxTRewzzrtq7PzIbDA2FeOiYCrlCXNJhWqhin97JObKXnMMPKUr7gzqmYthdxOT9fC/ oiCNi3QnYtCXdII+yCgVbGGxcj1rMH7pjecJKAxlbS37ufAaZKyTg3Gli+Uog031qhon8n3PQXS9B lqiU9Cdly4liYrNZ6wNE7zCVb3ot+zZvGbI+HZ601MbB4zcyGmz9rSvLC+Ck8Dv+ZaxlemEIYJHmO M7mMswvasHAqfVHb8xLx8A==; Date: Thu, 23 Jan 2025 17:12:38 +0200 Message-Id: <86y0z1zhqx.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Pip Cet <pipcet@HIDDEN> In-Reply-To: <878qr161kp.fsf@HIDDEN> (message from Pip Cet on Thu, 23 Jan 2025 14:34:56 +0000) Subject: Re: bug#75755: feature/igc: Missing IGC_CHECK_RES? References: <CADwFkmn9BViN83WBCOMNZZo78PQga0Zf9nODUm_MrigndM0jtA@HIDDEN> <878qr3dr3j.fsf@HIDDEN> <87zfjjca9o.fsf@HIDDEN> <m25xm7vtuz.fsf@HIDDEN> <CADwFkmmxmcBVD1JJh+avrJzU8RJgbJCFMv9Kfmhcoo5=s2RfWg@HIDDEN> <874j1q8sw2.fsf@HIDDEN> <CADwFkmnYJ2Dtcdw49--=ppO4XgNt6Dxs-HVAjChyRkv=y_8oRg@HIDDEN> <865xm62fik.fsf@HIDDEN> <878qr161kp.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75755 Cc: gerd@HIDDEN, eller.helmut@HIDDEN, gerd.moellmann@HIDDEN, 75755 <at> debbugs.gnu.org, stefankangas@HIDDEN, acorallo@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Thu, 23 Jan 2025 14:34:56 +0000 > From: Pip Cet <pipcet@HIDDEN> > Cc: Stefan Kangas <stefankangas@HIDDEN>, gerd.moellmann@HIDDEN, 75755 <at> debbugs.gnu.org, gerd@HIDDEN, eller.helmut@HIDDEN, acorallo@HIDDEN > > "Eli Zaretskii" <eliz@HIDDEN> writes: > > > IMO, the single use of this macro is not worth of the complications > > due to relying on an internal enumeration macro. The single function > > which uses this is a testing tool, which on top of that warns in its > > doc string not to use it. Introducing significant complexity and > > breakage potential into Emacs due to this is IMO a tail wagging the > > dog. > > I agree with this paragraph; it's not worth it, let's drop the code. > > > So I suggest that we define our own enumeration. We could copy some > > Why? Because it's easy, and will still give us human-readable error messages. > So my preference is to remove the code and cast to typeof (MPS_RES_OK), > briefly mentioning in a comment that this approach does not work yet, > but might work in the future. I'm fine with that as well, this being an obscure internal function. > > maintenance work on our hands, but it doesn't seem a significant > > problem for an internal function that almost no one should be using. > > Just so we don't forget this isn't about this specific case only: No, what I wrote was _only_ about this one case. The other cases should be considered separately, and the conclusion might well be different.
bug-gnu-emacs@HIDDEN:bug#75755; Package emacs.
Full text available.
Received: (at 75755) by debbugs.gnu.org; 23 Jan 2025 14:35:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 23 09:35:24 2025
Received: from localhost ([127.0.0.1]:39934 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tayIk-0001qi-H9
for submit <at> debbugs.gnu.org; Thu, 23 Jan 2025 09:35:23 -0500
Received: from mail-10631.protonmail.ch ([79.135.106.31]:61655)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <pipcet@HIDDEN>)
id 1tayIY-0001l7-Ib
for 75755 <at> debbugs.gnu.org; Thu, 23 Jan 2025 09:35:18 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
s=protonmail3; t=1737642903; x=1737902103;
bh=9lcOPKIy5Til7nQ4ndz4kioAgPKSSQtk82uFDUL2dO8=;
h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;
b=G+O4bPCwXKyDmbMXL60BotIF0CWOZ82dPx2M1JIx2rf4X9lAlQsGBRzy8fZ9+hgVU
yoTolBXDD3o3bSlTsZcrV9nR19PWve5jexlI+ryyJzrTWYwd81PjRuTihI04qESpZd
E0FsUmXikXdhb7j/F50JHGB6FIBrkHNlqwOKCDEkwypndAZthJhorb7c11865l1JDR
JVu5qf6Lbcepi4c/GAzFl1iFa/GsSw0+N9gL5t46K9L1H6JpFmhSVC0E9MyeOCUEDW
1lcIblnct+xlzgA76tlsuwxx2jti1GyBKU9tO+YT/+Aa9bB3LVBh3K/m0innqYnEDV
tDOgX7I6HEjmQ==
Date: Thu, 23 Jan 2025 14:34:56 +0000
To: Eli Zaretskii <eliz@HIDDEN>
From: Pip Cet <pipcet@HIDDEN>
Subject: Re: bug#75755: feature/igc: Missing IGC_CHECK_RES?
Message-ID: <878qr161kp.fsf@HIDDEN>
In-Reply-To: <865xm62fik.fsf@HIDDEN>
References: <CADwFkmn9BViN83WBCOMNZZo78PQga0Zf9nODUm_MrigndM0jtA@HIDDEN>
<878qr3dr3j.fsf@HIDDEN> <87zfjjca9o.fsf@HIDDEN>
<m25xm7vtuz.fsf@HIDDEN>
<CADwFkmmxmcBVD1JJh+avrJzU8RJgbJCFMv9Kfmhcoo5=s2RfWg@HIDDEN>
<874j1q8sw2.fsf@HIDDEN>
<CADwFkmnYJ2Dtcdw49--=ppO4XgNt6Dxs-HVAjChyRkv=y_8oRg@HIDDEN>
<865xm62fik.fsf@HIDDEN>
Feedback-ID: 112775352:user:proton
X-Pm-Message-ID: bb70b2442e5ae00893c09118342756cfdb058ecf
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75755
Cc: gerd@HIDDEN, eller.helmut@HIDDEN, gerd.moellmann@HIDDEN,
75755 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN>,
acorallo@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
"Eli Zaretskii" <eliz@HIDDEN> writes:
>> From: Stefan Kangas <stefankangas@HIDDEN>
>> Date: Wed, 22 Jan 2025 13:52:07 -0800
>> Cc: Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN>,
>> =0975755 <at> debbugs.gnu.org, gerd@HIDDEN, Helmut Eller <eller.helmut@gmail=
.com>,
>> =09Eli Zaretskii <eliz@HIDDEN>, Andrea Corallo <acorallo@HIDDEN>
>>
>> Pip Cet <pipcet@HIDDEN> writes:
>>
>> > "Stefan Kangas" <stefankangas@HIDDEN> writes:
>> >
>> >> Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes:
>> >>
>> >>> Pip Cet <pipcet@HIDDEN> writes:
>> >>>
>> >>>> "Pip Cet" <pipcet@HIDDEN> writes:
>> >>>>
>> >>>> My preference would be to add this code before result_string:
>> >>>>
>> >>>> /* Define a named enumeration containing all cases that the integer=
type
>> >>>> mps_res_t is known to cover. */
>> >>>>
>> >>>> enum mps_res_enum
>> >>>> {
>> >>>> _mps_RES_ENUM (RES_CASE, MPS_RES_)
>> >>>> };
>> >>>> #undef RES_CASE
>> >>>
>> >>> That would be nice, indeed.
>> >>
>> >> Can we rely on this or is it an internal API?
>> >
>> > It's an internal API. The header has this to say:
>> >
>> > * .naming.internal: Any identifier beginning with an underscore is fo=
r
>> > * internal use within the interface and may change or be withdrawn wi=
thout
>> > * warning.
>> >
>> > I don't think that it's always horrible to rely on internal APIs,
>> > though. Maybe we can put it inside "#ifdef _mps_RES_ENUM", with a
>> > comment explaining that if in some distant future there are compilatio=
n
>> > errors because _mps_RES_ENUM is defined differently, the #ifdef block
>> > can safely be omitted?
>>
>> AFAICT, being non-exhaustive risks that people will get suboptimal
>> errors, and being exhaustive means that we can get optimal errors on
>> master sooner.
>>
>> OTOH, the situation I'm concerned about is if someone is trying to build
>> an old Emacs tarball with the latest MPS. If the internal identifier
>> disappears, or its interface changes, the build will be broken. The MPS
>> developers warn that such a change could happen "without warning".
>>
>> Are the benefits of using it large enough to be worth the risks? I'm
>> currently leaning towards "no", but it's possible that I'm missing
>> something.
>
> IMO, the single use of this macro is not worth of the complications
> due to relying on an internal enumeration macro. The single function
> which uses this is a testing tool, which on top of that warns in its
> doc string not to use it. Introducing significant complexity and
> breakage potential into Emacs due to this is IMO a tail wagging the
> dog.
I agree with this paragraph; it's not worth it, let's drop the code.
> So I suggest that we define our own enumeration. We could copy some
Why?
mps.h does define an enumeration, it just fails to give it a name (we'd
use it then), or use it in a typedef (we could use it then), and we
can't cast to typeof (MPS_RES_OK) because, well, that's a gcc bug.
(Yes, C defines typeof(ENUM_VALUE) to be equivalent to int; but the C
standard also doesn't prohibit the compiler from remembering where that
"int" came from, that it refers to the underlying type of a specific
enum, and adding extra warnings based on this memory)
So my preference is to remove the code and cast to typeof (MPS_RES_OK),
briefly mentioning in a comment that this approach does not work yet,
but might work in the future.
(I still think the GCC people should warn if a switch statement contains
labels for some but not all elements of an enum, even if the switch
value is cast to int. It's the labels that matter, not the matched
value. Works, see patch. I assume GCC folks will disagree.)
> information from the MPS headers if needed (or not: I'm not sure we
> should be wedded to their strings in this case). Yes, that would mean
We should use our strings, which Stefan Kangas provided (and which are
in use by the current code).
> if they add or remove enumeration values, we will have some
^^^^^^^^^
If they remove enumeration values, that's a breaking change, and the
build will break, as it should. (Warning about non-breaking changes is
better than breaking the build, but breaking the build is still better
than silently accepting a situation which is likely to result in runtime
errors).
> maintenance work on our hands, but it doesn't seem a significant
> problem for an internal function that almost no one should be using.
Just so we don't forget this isn't about this specific case only:
We've yet to add the TSQueryErrorLanguage case to treesit.c because
there was no compile-time warning. It's a lot more work than it would
have been if the warning had been present.
diff --git a/src/treesit.c b/src/treesit.c
index d4090b949ea..7f34ef085dd 100644
--- a/src/treesit.c
+++ b/src/treesit.c
@@ -1446,9 +1446,13 @@ treesit_query_error_to_string (TSQueryError error)
return "Capture error at";
case TSQueryErrorStructure:
return "Structure error at";
- default:
- return "Unknown error";
+ /* FIXME: what's a "language error"? Do all versions of
+=09 treesitter we support define this enumeration value?
+ case TSQueryErrorLanguage:
+ return "Language error at";
+ */
}
+ return "Unknown error";
}
=20
static Lisp_Object
In the case of treesit.c, the problem would have been printed by
-Wswitch-enum, or by writing treesit_query_error_to_string more
carefully.
Switching to -Wswitch-enum would be good, but cause a number of warnings
for code which is perfectly acceptable because it uses a local or
logically complete enum instead of one which is subject to unexpected
changes.
And, yes, two or three places would require #pragma's to avoid the
warning because an external enum we cannot control or establish the
potential values of in a preprocessor macro might change under us and
otherwise cause noise.
I'm volunteering to do this, except for bidi.c; I'll put a #pragma in to
avoid the warning, and then someone who understands the code better can
decide whether to make the code comply to -Wswitch-enum or not. Let me
know if this is desirable and I'll send a patch (which will be large
because things like the switch (XTYPE (elt)) in xdisp.c change
indentation levels).
Pip
bug-gnu-emacs@HIDDEN:bug#75755; Package emacs.
Full text available.
Received: (at 75755) by debbugs.gnu.org; 23 Jan 2025 06:47:41 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 23 01:47:41 2025
Received: from localhost ([127.0.0.1]:38795 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tar08-00009q-Jv
for submit <at> debbugs.gnu.org; Thu, 23 Jan 2025 01:47:41 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:49430)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tar05-00009b-Nr
for 75755 <at> debbugs.gnu.org; Thu, 23 Jan 2025 01:47:38 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1taqzz-00075c-Ra; Thu, 23 Jan 2025 01:47:31 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
Date; bh=uwayr1pR36Rr1SH7lIyuMpInwMDLRxfMgvefPUAEcMQ=; b=fvfRaKCLyvOFrmjTt+iF
84Af+0bxN5rslIQh3v2uq/uekX2vh6frLFON2ukxTE7OTxKJODvwhri1H/Y+IF1fRlh48ONvlIBLB
jNv7mWLKjlqBB0/ldVfXkeRN+74MuiUJTQb1Q3ZNB0iXmfvaU1AK7b9ovBiixj7rX0YBIFuSeR8hb
9lBy9q0pwCPFQhKk4lRyFbnlyplMr0nihMr7kgOz+Md1PFYxdwYKU8QEBXCiGtS8V5dk3gbmQIy2K
LCiJ7dAlj2aw97FVMPWWC8RVKCRaV+IuisztnFvH/M+0Ry69iPCqe5GZRXz3jzJFOHK3tmexGfoX9
/D5IVz0yA1MDGg==;
Date: Thu, 23 Jan 2025 08:47:15 +0200
Message-Id: <865xm62fik.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <CADwFkmnYJ2Dtcdw49--=ppO4XgNt6Dxs-HVAjChyRkv=y_8oRg@HIDDEN>
(message from Stefan Kangas on Wed, 22 Jan 2025 13:52:07 -0800)
Subject: Re: bug#75755: feature/igc: Missing IGC_CHECK_RES?
References: <CADwFkmn9BViN83WBCOMNZZo78PQga0Zf9nODUm_MrigndM0jtA@HIDDEN>
<878qr3dr3j.fsf@HIDDEN> <87zfjjca9o.fsf@HIDDEN>
<m25xm7vtuz.fsf@HIDDEN>
<CADwFkmmxmcBVD1JJh+avrJzU8RJgbJCFMv9Kfmhcoo5=s2RfWg@HIDDEN>
<874j1q8sw2.fsf@HIDDEN>
<CADwFkmnYJ2Dtcdw49--=ppO4XgNt6Dxs-HVAjChyRkv=y_8oRg@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 75755
Cc: pipcet@HIDDEN, eller.helmut@HIDDEN, gerd@HIDDEN,
gerd.moellmann@HIDDEN, 75755 <at> debbugs.gnu.org, acorallo@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Stefan Kangas <stefankangas@HIDDEN>
> Date: Wed, 22 Jan 2025 13:52:07 -0800
> Cc: Gerd Möllmann <gerd.moellmann@HIDDEN>,
> 75755 <at> debbugs.gnu.org, gerd@HIDDEN, Helmut Eller <eller.helmut@HIDDEN>,
> Eli Zaretskii <eliz@HIDDEN>, Andrea Corallo <acorallo@HIDDEN>
>
> Pip Cet <pipcet@HIDDEN> writes:
>
> > "Stefan Kangas" <stefankangas@HIDDEN> writes:
> >
> >> Gerd Möllmann <gerd.moellmann@HIDDEN> writes:
> >>
> >>> Pip Cet <pipcet@HIDDEN> writes:
> >>>
> >>>> "Pip Cet" <pipcet@HIDDEN> writes:
> >>>>
> >>>> My preference would be to add this code before result_string:
> >>>>
> >>>> /* Define a named enumeration containing all cases that the integer type
> >>>> mps_res_t is known to cover. */
> >>>>
> >>>> enum mps_res_enum
> >>>> {
> >>>> _mps_RES_ENUM (RES_CASE, MPS_RES_)
> >>>> };
> >>>> #undef RES_CASE
> >>>
> >>> That would be nice, indeed.
> >>
> >> Can we rely on this or is it an internal API?
> >
> > It's an internal API. The header has this to say:
> >
> > * .naming.internal: Any identifier beginning with an underscore is for
> > * internal use within the interface and may change or be withdrawn without
> > * warning.
> >
> > I don't think that it's always horrible to rely on internal APIs,
> > though. Maybe we can put it inside "#ifdef _mps_RES_ENUM", with a
> > comment explaining that if in some distant future there are compilation
> > errors because _mps_RES_ENUM is defined differently, the #ifdef block
> > can safely be omitted?
>
> AFAICT, being non-exhaustive risks that people will get suboptimal
> errors, and being exhaustive means that we can get optimal errors on
> master sooner.
>
> OTOH, the situation I'm concerned about is if someone is trying to build
> an old Emacs tarball with the latest MPS. If the internal identifier
> disappears, or its interface changes, the build will be broken. The MPS
> developers warn that such a change could happen "without warning".
>
> Are the benefits of using it large enough to be worth the risks? I'm
> currently leaning towards "no", but it's possible that I'm missing
> something.
IMO, the single use of this macro is not worth of the complications
due to relying on an internal enumeration macro. The single function
which uses this is a testing tool, which on top of that warns in its
doc string not to use it. Introducing significant complexity and
breakage potential into Emacs due to this is IMO a tail wagging the
dog.
So I suggest that we define our own enumeration. We could copy some
information from the MPS headers if needed (or not: I'm not sure we
should be wedded to their strings in this case). Yes, that would mean
if they add or remove enumeration values, we will have some
maintenance work on our hands, but it doesn't seem a significant
problem for an internal function that almost no one should be using.
bug-gnu-emacs@HIDDEN:bug#75755; Package emacs.
Full text available.
Received: (at 75755) by debbugs.gnu.org; 22 Jan 2025 22:42:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 22 17:42:15 2025
Received: from localhost ([127.0.0.1]:37258 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tajQN-0006no-74
for submit <at> debbugs.gnu.org; Wed, 22 Jan 2025 17:42:15 -0500
Received: from mail-10631.protonmail.ch ([79.135.106.31]:64553)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <pipcet@HIDDEN>)
id 1tajQK-0006mS-FZ
for 75755 <at> debbugs.gnu.org; Wed, 22 Jan 2025 17:42:13 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
s=protonmail3; t=1737585725; x=1737844925;
bh=oW92N8Hjjyf4A4lPZlwrj/9icIMtpRr6JYFgfEqLPPo=;
h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;
b=Kb7/erBhIRESaOruunNJQt2VquJn4/ORluHd9vhwNU+9OhjMzhI3xrKKtNWknlmUv
RkIW+GkgQt72+xd0dL8RWFTW40uBUsEnXYE+gAswfwzpmEUQYuMgjTH1OlRogA/HBr
hQOktXeon9oM4sbDV1dmeQOttRXTQXGJSGcF8NVtEYd6mdC9ELTnXT/2+Vsa5Gaoq+
d/b1+5In2+3kAlBt6BHGZ0tq0vNwGz0BEGFv7lM2hcZF544yHfH9IlzkDY06yjkKRG
fCrwx6NfbdMnG6d1f5IrYv1XxiCj5Y09vF3bMRt+Hx8qFeJYYr2RnEz8ljcfKh0v1V
pl2glIOLtT0Vw==
Date: Wed, 22 Jan 2025 22:42:01 +0000
To: Stefan Kangas <stefankangas@HIDDEN>
From: Pip Cet <pipcet@HIDDEN>
Subject: Re: bug#75755: feature/igc: Missing IGC_CHECK_RES?
Message-ID: <87h65q79oz.fsf@HIDDEN>
In-Reply-To: <CADwFkmnYJ2Dtcdw49--=ppO4XgNt6Dxs-HVAjChyRkv=y_8oRg@HIDDEN>
References: <CADwFkmn9BViN83WBCOMNZZo78PQga0Zf9nODUm_MrigndM0jtA@HIDDEN>
<878qr3dr3j.fsf@HIDDEN> <87zfjjca9o.fsf@HIDDEN>
<m25xm7vtuz.fsf@HIDDEN>
<CADwFkmmxmcBVD1JJh+avrJzU8RJgbJCFMv9Kfmhcoo5=s2RfWg@HIDDEN>
<874j1q8sw2.fsf@HIDDEN>
<CADwFkmnYJ2Dtcdw49--=ppO4XgNt6Dxs-HVAjChyRkv=y_8oRg@HIDDEN>
Feedback-ID: 112775352:user:proton
X-Pm-Message-ID: 3c072a3a45f74ec5f0958297df32c31a9a746936
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75755
Cc: gerd@HIDDEN, Helmut Eller <eller.helmut@HIDDEN>,
=?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>,
75755 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>,
Andrea Corallo <acorallo@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
"Stefan Kangas" <stefankangas@HIDDEN> writes:
> Pip Cet <pipcet@HIDDEN> writes:
>
>> "Stefan Kangas" <stefankangas@HIDDEN> writes:
>>
>>> Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes:
>>>
>>>> Pip Cet <pipcet@HIDDEN> writes:
>>>>
>>>>> "Pip Cet" <pipcet@HIDDEN> writes:
>>>>>
>>>>> My preference would be to add this code before result_string:
>>>>>
>>>>> /* Define a named enumeration containing all cases that the integer t=
ype
>>>>> mps_res_t is known to cover. */
>>>>>
>>>>> enum mps_res_enum
>>>>> {
>>>>> _mps_RES_ENUM (RES_CASE, MPS_RES_)
>>>>> };
>>>>> #undef RES_CASE
>>>>
>>>> That would be nice, indeed.
>>>
>>> Can we rely on this or is it an internal API?
>>
>> It's an internal API. The header has this to say:
>>
>> * .naming.internal: Any identifier beginning with an underscore is for
>> * internal use within the interface and may change or be withdrawn with=
out
>> * warning.
>>
>> I don't think that it's always horrible to rely on internal APIs,
>> though. Maybe we can put it inside "#ifdef _mps_RES_ENUM", with a
>> comment explaining that if in some distant future there are compilation
>> errors because _mps_RES_ENUM is defined differently, the #ifdef block
>> can safely be omitted?
>
> AFAICT, being non-exhaustive risks that people will get suboptimal
> errors, and being exhaustive means that we can get optimal errors on
> master sooner.
>
> OTOH, the situation I'm concerned about is if someone is trying to build
> an old Emacs tarball with the latest MPS. If the internal identifier
> disappears,
The #ifdef block will simply not be evaluated, and the build will
continue to work. It'll behave differently in this minor way, but
that's to be expected when a header changes.
> or its interface changes, the build will be broken. The MPS
That is correct; I hope this is much less likely to happen, but if it
does, we're stuck with unbuildable old Emacs-new MPS combinations.
> developers warn that such a change could happen "without warning".
> Are the benefits of using it large enough to be worth the risks? I'm
> currently leaning towards "no", but it's possible that I'm missing
> something.
I did not introduce the dependency; I moved it around and had some
preprocessor fun while doing so. I think it's time to remove it now,
though, but that's not a strong opinion. Please feel free to do what
you think is best on the branch. If you have a hard time deciding,
there's always the option of keeping it behind a usually-deactivated
#ifdef, like the BYTE_CODE_SAFE code.
Pip
bug-gnu-emacs@HIDDEN:bug#75755; Package emacs.
Full text available.
Received: (at 75755) by debbugs.gnu.org; 22 Jan 2025 21:52:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 22 16:52:16 2025
Received: from localhost ([127.0.0.1]:36934 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1taie0-0003G8-EY
for submit <at> debbugs.gnu.org; Wed, 22 Jan 2025 16:52:16 -0500
Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]:57798)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
id 1taidy-0003Fr-FD
for 75755 <at> debbugs.gnu.org; Wed, 22 Jan 2025 16:52:15 -0500
Received: by mail-ed1-x52b.google.com with SMTP id
4fb4d7f45d1cf-5dbfab8a2b0so496313a12.3
for <75755 <at> debbugs.gnu.org>; Wed, 22 Jan 2025 13:52:14 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1737582728; x=1738187528; darn=debbugs.gnu.org;
h=content-transfer-encoding:cc:to:subject:message-id:date
:mime-version:references:in-reply-to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=tD0iEOU4hBWjeHX70nswnCb3H0RaP1prc2kMvjmBtVE=;
b=dOTSoCZ/j67nQZPFiq8d0+/cE3kLrjbnOo1jreSCgVZ0lvVcuRb7va+O5cNrfId9yc
KzI0t6T/+PVYgkVbmCkMUzT9vFnB4vN6bvvlWr29Ym6yqRlK2RZHdORDErPSFSVKE00d
1u+u8nx8+eO2UpJ/1jUcr1y10nYtvNw1mS6H9sQJUPV+8tu1fLVyoNrHDFEhAj6rVk5C
aG+JXKo4AF1wmwiMcZRLjS0bzgieV5s8T5zuiIez/RBv2ahROwOFnqNgr1YHNrlX5zms
Xfaynv8HcBWa2Vj8Omj8W9Dh4NqX4bvYiSzVmaxaAdCxovMxy2qV2rNavhg3yBCgvWzu
MGlA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1737582728; x=1738187528;
h=content-transfer-encoding:cc:to:subject:message-id:date
:mime-version:references:in-reply-to:from:x-gm-message-state:from:to
:cc:subject:date:message-id:reply-to;
bh=tD0iEOU4hBWjeHX70nswnCb3H0RaP1prc2kMvjmBtVE=;
b=cWHk4x403mUT1yg7LF0ITH9TwrBIiI6bhAYs8l8/mNuWsJ4kZVPq+ZzgLRsq7jPXhB
dxkvefAy9KtT4/exjfi5/XYWhNjMQMKCxikV0u9dg2HbcxGMMpOk0dAi40454Lr7Y2dw
P7c0queAbLovW8AeGRlIjUAsyzkXLaAMWjmmJUZK0HzkLMgz3HoPb2ZpQEj+97FhtWpV
EtlRCtF/yWp4AWSWlRD0X/Vp9O/27jy2lOm1RXhv70zSNOBpjA7D1Hr6FPw6pVwOPCl/
0GjR56jSD0nqINs5L/0ol9gHD1bo8J/8aJ/eSIiQOtqjUp4bFa91WxFqjEMYNLZL0NY4
6kbA==
X-Forwarded-Encrypted: i=1;
AJvYcCXWBVDglq9JZ0Tj+PFtEg1VAD0Pv9ub4G+bT2vGaL+yjZbUZ+clMHWzvhyxC8bnz74jTG7xMQ==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YzrBsYpQbfFt5Lj+ugsv1BnFEsEFHWX+Y4T53dtloY/ULRRg+L6
zvIkPdCwD2amrtq/+m8YmoamqswYnk7TGovtwHWoZBKIsqy7rA9aBXx6p3/GyQ07WHt3DfxxJ57
TaHsmCduQBQdnlwlQFNMiLI2mr2o=
X-Gm-Gg: ASbGnctwSuvp6Fb+LVDzKZ7u1X1bB+hnbPxbbiGw6LL12E3ZcOSi6wSQf7/BlZuSA0D
GG5AxwZqc4BfKx983RnKHEW4zTNOhXox5SF1wA3iWW+oq6ClG17lN
X-Google-Smtp-Source: AGHT+IEIZL9nmg3q/qfxyOT10vxW3Q7U3QYbm+sQY1SbRiJLjNE9tUfzBI022VUhV0LOg83qvnrTi6R8WPTU9YJDaD8=
X-Received: by 2002:a05:6402:2744:b0:5d9:f1f8:e726 with SMTP id
4fb4d7f45d1cf-5db7d2e8f9bmr18606700a12.2.1737582728225; Wed, 22 Jan 2025
13:52:08 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
HTTPREST; Wed, 22 Jan 2025 13:52:07 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <874j1q8sw2.fsf@HIDDEN>
References: <CADwFkmn9BViN83WBCOMNZZo78PQga0Zf9nODUm_MrigndM0jtA@HIDDEN>
<878qr3dr3j.fsf@HIDDEN> <87zfjjca9o.fsf@HIDDEN>
<m25xm7vtuz.fsf@HIDDEN>
<CADwFkmmxmcBVD1JJh+avrJzU8RJgbJCFMv9Kfmhcoo5=s2RfWg@HIDDEN>
<874j1q8sw2.fsf@HIDDEN>
MIME-Version: 1.0
Date: Wed, 22 Jan 2025 13:52:07 -0800
X-Gm-Features: AWEUYZmEnYfvhBY4rhQjbWojv7lE9G1japvLpr1ncs9ES525n7YO7VtZI65VyLQ
Message-ID: <CADwFkmnYJ2Dtcdw49--=ppO4XgNt6Dxs-HVAjChyRkv=y_8oRg@HIDDEN>
Subject: Re: bug#75755: feature/igc: Missing IGC_CHECK_RES?
To: Pip Cet <pipcet@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75755
Cc: gerd@HIDDEN, Helmut Eller <eller.helmut@HIDDEN>,
=?UTF-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>,
75755 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>,
Andrea Corallo <acorallo@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Pip Cet <pipcet@HIDDEN> writes:
> "Stefan Kangas" <stefankangas@HIDDEN> writes:
>
>> Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes:
>>
>>> Pip Cet <pipcet@HIDDEN> writes:
>>>
>>>> "Pip Cet" <pipcet@HIDDEN> writes:
>>>>
>>>> My preference would be to add this code before result_string:
>>>>
>>>> /* Define a named enumeration containing all cases that the integer ty=
pe
>>>> mps_res_t is known to cover. */
>>>>
>>>> enum mps_res_enum
>>>> {
>>>> _mps_RES_ENUM (RES_CASE, MPS_RES_)
>>>> };
>>>> #undef RES_CASE
>>>
>>> That would be nice, indeed.
>>
>> Can we rely on this or is it an internal API?
>
> It's an internal API. The header has this to say:
>
> * .naming.internal: Any identifier beginning with an underscore is for
> * internal use within the interface and may change or be withdrawn witho=
ut
> * warning.
>
> I don't think that it's always horrible to rely on internal APIs,
> though. Maybe we can put it inside "#ifdef _mps_RES_ENUM", with a
> comment explaining that if in some distant future there are compilation
> errors because _mps_RES_ENUM is defined differently, the #ifdef block
> can safely be omitted?
AFAICT, being non-exhaustive risks that people will get suboptimal
errors, and being exhaustive means that we can get optimal errors on
master sooner.
OTOH, the situation I'm concerned about is if someone is trying to build
an old Emacs tarball with the latest MPS. If the internal identifier
disappears, or its interface changes, the build will be broken. The MPS
developers warn that such a change could happen "without warning".
Are the benefits of using it large enough to be worth the risks? I'm
currently leaning towards "no", but it's possible that I'm missing
something.
bug-gnu-emacs@HIDDEN:bug#75755; Package emacs.
Full text available.
Received: (at 75755) by debbugs.gnu.org; 22 Jan 2025 21:02:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 22 16:02:15 2025
Received: from localhost ([127.0.0.1]:36828 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tahrb-0000io-12
for submit <at> debbugs.gnu.org; Wed, 22 Jan 2025 16:02:15 -0500
Received: from mail-4316.protonmail.ch ([185.70.43.16]:62687)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <pipcet@HIDDEN>)
id 1tahrW-0000iW-QE
for 75755 <at> debbugs.gnu.org; Wed, 22 Jan 2025 16:02:12 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
s=protonmail3; t=1737579724; x=1737838924;
bh=pvrmxh9ZMXAatZK6Ajifvaq+nXMtCPB64HFKEmRLG38=;
h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;
b=aQQ7Oq6H1Y0BYkW8yMgbmkmXpRye2WC/KepXLmy4ruDirYYTmiw1/vQ4yjPODZHFg
dc0F2ZnkmUAn1QRqyrKd0E/MsFnG8dhPt6nVT0eVbpFsLEXf8K2lpctgU7u9lxQ1Z8
eS1OnEN6Gn9JgMt4Qx21I3ieDX0tzUwSoUDVZRDMZslxkWV6WDPT/5GT2SBLveLPZi
Ht3WzkkTLcw7GP/RL01sCLjOW3DdF3k05Y9Vvu+Luk9PGPbngbStBq/Qswj9SiffAn
TyhXdHeWWjABkRLq/Zw5+Grx1Qr/ehXnAb23ybE0yhb2awb5+eFrM27G/ITv79B+CN
57boMXdIHxlsA==
Date: Wed, 22 Jan 2025 21:01:59 +0000
To: Stefan Kangas <stefankangas@HIDDEN>
From: Pip Cet <pipcet@HIDDEN>
Subject: Re: bug#75755: feature/igc: Missing IGC_CHECK_RES?
Message-ID: <874j1q8sw2.fsf@HIDDEN>
In-Reply-To: <CADwFkmmxmcBVD1JJh+avrJzU8RJgbJCFMv9Kfmhcoo5=s2RfWg@HIDDEN>
References: <CADwFkmn9BViN83WBCOMNZZo78PQga0Zf9nODUm_MrigndM0jtA@HIDDEN>
<878qr3dr3j.fsf@HIDDEN> <87zfjjca9o.fsf@HIDDEN>
<m25xm7vtuz.fsf@HIDDEN>
<CADwFkmmxmcBVD1JJh+avrJzU8RJgbJCFMv9Kfmhcoo5=s2RfWg@HIDDEN>
Feedback-ID: 112775352:user:proton
X-Pm-Message-ID: 147c31889c6fc4edd058214074deb6e18c7b98ce
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75755
Cc: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>,
75755 <at> debbugs.gnu.org, Helmut Eller <eller.helmut@HIDDEN>, gerd@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
"Stefan Kangas" <stefankangas@HIDDEN> writes:
> Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes:
>
>> Pip Cet <pipcet@HIDDEN> writes:
>>
>>> "Pip Cet" <pipcet@HIDDEN> writes:
>>>
>>> My preference would be to add this code before result_string:
>>>
>>> /* Define a named enumeration containing all cases that the integer typ=
e
>>> mps_res_t is known to cover. */
>>>
>>> enum mps_res_enum
>>> {
>>> _mps_RES_ENUM (RES_CASE, MPS_RES_)
>>> };
>>> #undef RES_CASE
>>
>> That would be nice, indeed.
>
> Can we rely on this or is it an internal API?
It's an internal API. The header has this to say:
* .naming.internal: Any identifier beginning with an underscore is for
* internal use within the interface and may change or be withdrawn without
* warning.
I don't think that it's always horrible to rely on internal APIs,
though. Maybe we can put it inside "#ifdef _mps_RES_ENUM", with a
comment explaining that if in some distant future there are compilation
errors because _mps_RES_ENUM is defined differently, the #ifdef block
can safely be omitted?
Pip
bug-gnu-emacs@HIDDEN:bug#75755; Package emacs.
Full text available.
Received: (at 75755) by debbugs.gnu.org; 22 Jan 2025 20:53:17 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 22 15:53:17 2025
Received: from localhost ([127.0.0.1]:36788 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tahiu-0000CN-U6
for submit <at> debbugs.gnu.org; Wed, 22 Jan 2025 15:53:17 -0500
Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:48307)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
id 1tahis-0000C0-QM
for 75755 <at> debbugs.gnu.org; Wed, 22 Jan 2025 15:53:15 -0500
Received: by mail-ed1-x535.google.com with SMTP id
4fb4d7f45d1cf-5d7e3f1fdafso477003a12.0
for <75755 <at> debbugs.gnu.org>; Wed, 22 Jan 2025 12:53:14 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1737579189; x=1738183989; darn=debbugs.gnu.org;
h=content-transfer-encoding:cc:to:subject:message-id:date
:mime-version:references:in-reply-to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=YLcGG/FlDkt1Dfwc0fjTTes2EY2A80+YIP0GWcu8n2c=;
b=HjbAttGnNj6NdkT+IcpZLaml8RL+IxIE4V8DJUBFqNwXNnWnHCScdmLZ2Yh0LpEXYH
Yk3dau4j1VDMoX1M246F2bfzKEqSoxEJ1be//Dwss66mvBFm9CBXSSjEy0V0u9oKRw+v
AWkU1rgMMQA8GuPsnOYA07A5eB2ZTquAROngwpapXqMguDA7lhgCJAi8NPkeAQrLAt5Y
VOnLHrwkqDaaH3gGD95yg1bu+L52hEfnViYxrYHlLvDCHzgaOjFUM/TJFh0zCA0lwFYB
Ti0lpp40Mw3I/Nfar1SHDPAQE4GTvtxHQ6xRhj8LS1b1cK8O5cLx/McUpVx/VuaTPdX2
gDeg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1737579189; x=1738183989;
h=content-transfer-encoding:cc:to:subject:message-id:date
:mime-version:references:in-reply-to:from:x-gm-message-state:from:to
:cc:subject:date:message-id:reply-to;
bh=YLcGG/FlDkt1Dfwc0fjTTes2EY2A80+YIP0GWcu8n2c=;
b=eLCjYBTRYk7SVO9zP/J8WF8OQDiTTv8zXs2NwU+mFs3R+PWN7/MdF+IvnSJpyMbjS4
CKbWmWLQZ1UNCRC3cXepkMwkIseFPqbpZZMQMqnnzhi7MZKZn2lMVV3S+tMopmYYYJEq
mQcMZ99ccLp91b/RiGeY5Ovpp7uWVupFTSOWlCQULOmSJNhloOXXFQ2LPCOZP1FbHUpP
Wij0CiOSsrRwpSAtX0C+G6ZxU9mfOVVrhs8eojeJUfhAIDAo9PAlDhZZBFzWjDZxUGl1
rb+yqS9sbwwsXsGhXtwV2adtzdbMZxioM8lG2xToCdoZo33XmLWu2wKFsiwM5OZSiH95
g/zg==
X-Gm-Message-State: AOJu0YyS9YpS/q86Pc6DMzrcOfNl6FC9svBkpgj8WDYw1fW78Yr0+IL7
FaAJWTOU0PxQzNRZC92BVRS6dxxhgfkrvRdMFCxuFQb/Tkos8d/mFM++ugwS9/NeItP9nBRFJgE
fsnxphNCGdOn+hi5erK+aflVgOLI=
X-Gm-Gg: ASbGncvnl/olywokY9kE5bJtX9Aa/gmW2/kVKSx914L8FgqL9ztgDYtCFMs/1H/qmLl
dElYjnxI0H1Z49LJqdnZBQeR9KDFngw8bWei6OGpp8TYXxsqirXgz
X-Google-Smtp-Source: AGHT+IGnX5/l/3WDeDYtEzK+k83mRAlbOR1GX1OyCiwabdtfh0wC1gameROkHaAlL+3ElrYI5F5eFWedhmXkjqRK/0A=
X-Received: by 2002:a05:6402:42cf:b0:5d9:a55:810c with SMTP id
4fb4d7f45d1cf-5db7d2dc320mr22626979a12.5.1737579188384; Wed, 22 Jan 2025
12:53:08 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
HTTPREST; Wed, 22 Jan 2025 14:53:07 -0600
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <m25xm7vtuz.fsf@HIDDEN>
References: <CADwFkmn9BViN83WBCOMNZZo78PQga0Zf9nODUm_MrigndM0jtA@HIDDEN>
<878qr3dr3j.fsf@HIDDEN> <87zfjjca9o.fsf@HIDDEN>
<m25xm7vtuz.fsf@HIDDEN>
MIME-Version: 1.0
Date: Wed, 22 Jan 2025 14:53:07 -0600
X-Gm-Features: AWEUYZkLXg6soB7-ZNzx-425hItYbfi4CqaLc--RpCpiifcXuXwge7nv8vddoJI
Message-ID: <CADwFkmmxmcBVD1JJh+avrJzU8RJgbJCFMv9Kfmhcoo5=s2RfWg@HIDDEN>
Subject: Re: bug#75755: feature/igc: Missing IGC_CHECK_RES?
To: =?UTF-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>,
Pip Cet <pipcet@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75755
Cc: 75755 <at> debbugs.gnu.org, Helmut Eller <eller.helmut@HIDDEN>, gerd@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Pip Cet <pipcet@HIDDEN> writes:
> Fixed. Thanks again.
Thanks.
Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes:
> Pip Cet <pipcet@HIDDEN> writes:
>
>> "Pip Cet" <pipcet@HIDDEN> writes:
>>
>> My preference would be to add this code before result_string:
>>
>> /* Define a named enumeration containing all cases that the integer type
>> mps_res_t is known to cover. */
>>
>> enum mps_res_enum
>> {
>> _mps_RES_ENUM (RES_CASE, MPS_RES_)
>> };
>> #undef RES_CASE
>
> That would be nice, indeed.
Can we rely on this or is it an internal API?
bug-gnu-emacs@HIDDEN:bug#75755; Package emacs.
Full text available.
Received: (at 75755) by debbugs.gnu.org; 22 Jan 2025 13:52:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 22 08:52:32 2025
Received: from localhost ([127.0.0.1]:60943 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tab9j-0002dy-VP
for submit <at> debbugs.gnu.org; Wed, 22 Jan 2025 08:52:32 -0500
Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:53625)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>)
id 1tab9g-0002dh-G3
for 75755 <at> debbugs.gnu.org; Wed, 22 Jan 2025 08:52:30 -0500
Received: by mail-wr1-x42a.google.com with SMTP id
ffacd0b85a97d-38a88ba968aso6460751f8f.3
for <75755 <at> debbugs.gnu.org>; Wed, 22 Jan 2025 05:52:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1737553942; x=1738158742; darn=debbugs.gnu.org;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=QT27ydP9tHR3vk8+b2B8BFLpksQPeM8E2Yuoz4u1ioI=;
b=g50QIh0WNT8PlvSiz4vTOBYRnmfRGjz2hRR3lzuX8qVfVqEJsfwV9H21JaIIJjRYcB
rTYjJOXOO+TDuOX2bYsUkiwLtA7lT4cC5rau/33LcKNFfI24hn9It+VWeOZV5noqg7tq
l0uAJGaFOvSGJ5GntXc3geyVPCnOtHGnImn+Ba+Td4S6lp3HCoXyAkg13LTj/vFB7xeU
rJFFIJu/FGm85sCKAPvOFZ4jXSlHFkFNCheXy+rsKhkyP/KEmXYYAuzh9GwHQf5qIRR+
Sb9GL2ypsZ2Wc1whTGzrejLnrkxXjR98zanBXBkHO922lqNZ9EF02TV5C0ldoHt+nrwp
YnYg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1737553942; x=1738158742;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
:message-id:reply-to;
bh=QT27ydP9tHR3vk8+b2B8BFLpksQPeM8E2Yuoz4u1ioI=;
b=wNATlVQYht7QAK04zt9gmZiZlMbhGAX4b7s7Ecu0I+SzvIdkRk85+klkMWHFZEvdxl
AVT3MKPcJNLs7Uuk7XtqGZlKwmMOAJeddKR0/aZNEWI68hmK37yGwkPXQ64a3zHtcPRG
//c1MAjpCw0tp3FYJe/dxCR9o8UkO4gR1nwP35VpowXt1IfCs6Ni+xdOp4pOYZBszbsB
ontAEauxtJZR3rnYeTCpLwwonqxKEp8g+u30eKFkoTUagxBOJnnrLYgcUBx4ASw3jfXD
OU6Nt43tYfdNctitDdoTCVDJzJcIBf5zTPRNq816yP6xOBUL4DgpzLtI6AtzzaVCATRD
ZIiw==
X-Forwarded-Encrypted: i=1;
AJvYcCUxtR9fIP+Nhl16w8UscG+yKUCOW5rg0rzOiKHUh/gjlA2lnVNWZow56rtS3nwjI4RoB8tK+A==@debbugs.gnu.org
X-Gm-Message-State: AOJu0Yzx8k6k3zJtZcacOJo/srpmltpIZxFAPlK3e0pF4fuWCXvsPfTu
5/7tx+9Jk1sf9OvQxwxZsuJzUTXwktu4ItwNbmgzeVo0C+wKRpLz
X-Gm-Gg: ASbGncv+epKdvDAh8RB3ZVQue2I5pbeNYhXfWsejcFN6y6QJb2RB/XfvQdvChNtXCjI
sisp0ORucAjTZUfl9jKD5chAZLpYeoo8YZMbiiupZCmh93B/CQn9pMoVDi+ktZ1ZN6jh3jkoZuD
aVIvr3mrXe8whdgiZt35jlFKcTx1e3tfvMFDvRWFU3/ibTcCqxRZTSIczBsmxiOlVcMIW4uv0hd
HkmPWZmOkEiNcy6Bw0Ixey+ZDjzt7W0a6zT/pXRDJsee0VI2i+G07UCO5STyj1b/oW0wktRGEc+
Bmf8pnZ/rUryGzr5qI2QDJ47658xEJev3g/j772xDMqLOiUc2ZhgviUdbtQsQVLBgqvpGd7T3Xg
cVw==
X-Google-Smtp-Source: AGHT+IGPnIMDue9Qz7O5MYv49uhtnfexSXCYADCWarYS2kaiFBhH07stf9mZWaORlZ6Jvre9mUGmUw==
X-Received: by 2002:a05:6000:1786:b0:385:d7f9:f16c with SMTP id
ffacd0b85a97d-38bf57be11bmr22104309f8f.46.1737553942134;
Wed, 22 Jan 2025 05:52:22 -0800 (PST)
Received: from pro2 (p200300e0b70c0300a51c5b839e69c119.dip0.t-ipconnect.de.
[2003:e0:b70c:300:a51c:5b83:9e69:c119])
by smtp.gmail.com with ESMTPSA id
ffacd0b85a97d-38bf322b51bsm16572072f8f.60.2025.01.22.05.52.21
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 22 Jan 2025 05:52:21 -0800 (PST)
From: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
To: Pip Cet <pipcet@HIDDEN>
Subject: Re: bug#75755: feature/igc: Missing IGC_CHECK_RES?
In-Reply-To: <87zfjjca9o.fsf@HIDDEN> (Pip Cet's message of "Wed, 22
Jan 2025 12:18:20 +0000")
References: <CADwFkmn9BViN83WBCOMNZZo78PQga0Zf9nODUm_MrigndM0jtA@HIDDEN>
<878qr3dr3j.fsf@HIDDEN> <87zfjjca9o.fsf@HIDDEN>
Date: Wed, 22 Jan 2025 14:52:20 +0100
Message-ID: <m25xm7vtuz.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75755
Cc: gerd@HIDDEN, 75755 <at> debbugs.gnu.org, Helmut Eller <eller.helmut@HIDDEN>,
Stefan Kangas <stefankangas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Pip Cet <pipcet@HIDDEN> writes:
> "Pip Cet" <pipcet@HIDDEN> writes:
>
> My preference would be to add this code before result_string:
>
> /* Define a named enumeration containing all cases that the integer type
> mps_res_t is known to cover. */
>
> enum mps_res_enum
> {
> _mps_RES_ENUM (RES_CASE, MPS_RES_)
> };
> #undef RES_CASE
That would be nice, indeed.
bug-gnu-emacs@HIDDEN:bug#75755; Package emacs.
Full text available.
Received: (at 75755) by debbugs.gnu.org; 22 Jan 2025 12:18:35 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 22 07:18:35 2025
Received: from localhost ([127.0.0.1]:60526 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1taZgp-0003AP-0i
for submit <at> debbugs.gnu.org; Wed, 22 Jan 2025 07:18:35 -0500
Received: from mail-4316.protonmail.ch ([185.70.43.16]:18129)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <pipcet@HIDDEN>)
id 1taZgm-0003A4-5P
for 75755 <at> debbugs.gnu.org; Wed, 22 Jan 2025 07:18:32 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
s=protonmail3; t=1737548305; x=1737807505;
bh=s69oz7i/LJegrtRteO5AKRuvybz/f7NUJqnAqnwHm7M=;
h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;
b=DYP4GX21bvPYmLuhXHE+GFzEIXxw3SNqSfl0y1GB3/nu6tcv8fyJdWihNddfrha+F
0t4hh6Fqb0CyVQF+CqrV4aXKK5PbFBSTB3ZZMgVmLwch4pnkXTX4eFG9WCBgg8NcXb
bvnX2BXjwRb1/Dk9mkJNo25410/8noeNVWh4x+DD/LSGM9Vj00DlhFszYtn+suD/CD
LzTMGYPJcoX3Rd8fqBMnEf6krGD1Y8M+lBHOA3AP7H+lV8ucQ4nwjqGgfKHuEccwIn
YPf+HagBujob9iPLzE6a2+nUzQ0n3k31qrE567CKKC+Sl54mJmlorRI3WaU5TmeETB
aQZxEGaU5mWoA==
Date: Wed, 22 Jan 2025 12:18:20 +0000
To: Stefan Kangas <stefankangas@HIDDEN>
From: Pip Cet <pipcet@HIDDEN>
Subject: Re: bug#75755: feature/igc: Missing IGC_CHECK_RES?
Message-ID: <87zfjjca9o.fsf@HIDDEN>
In-Reply-To: <878qr3dr3j.fsf@HIDDEN>
References: <CADwFkmn9BViN83WBCOMNZZo78PQga0Zf9nODUm_MrigndM0jtA@HIDDEN>
<878qr3dr3j.fsf@HIDDEN>
Feedback-ID: 112775352:user:proton
X-Pm-Message-ID: 0a0326ba7e3f9f3a91f61cdeae7d0ec291a41adf
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75755
Cc: 75755 <at> debbugs.gnu.org, Helmut Eller <eller.helmut@HIDDEN>, gerd@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
"Pip Cet" <pipcet@HIDDEN> writes:
> "Stefan Kangas" <stefankangas@HIDDEN> writes:
>
>> Gerd, do you remember why you didn't add CHECK_RES here? Was there a
>> reason for that or just an oversight?
>
> My mistake (c6a3eb01f7acf9ccd00b38e0ef2ab05164e48635). Please fix, or
> I'll do it in a bit.
Fixed. Thanks again. Checked the other mps calls, but what I found is
only this:
static const char *
mps_res_to_string (mps_res_t res)
{
switch (res)
{
#define RES_CASE(prefix, id, doc) =
\
case prefix##id: =
\
return #prefix #id " " doc;
_mps_RES_ENUM (RES_CASE, MPS_RES_);
#undef RES_CASE
default:
return NULL;
}
}
It would be nice if we could settle on just one function to convert
mps_t to a string, and use it consistently.
My preference would be to add this code before result_string:
/* Define a named enumeration containing all cases that the integer type
mps_res_t is known to cover. */
enum mps_res_enum
{
_mps_RES_ENUM (RES_CASE, MPS_RES_)
};
#undef RES_CASE
then cast to that type in our switch statement, which would remain
explicit, exhaustive, and default-free.
That way, we get warnings if the enum is extended.
Pip
bug-gnu-emacs@HIDDEN:bug#75755; Package emacs.
Full text available.Received: (at 75755) by debbugs.gnu.org; 22 Jan 2025 11:29:44 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 22 06:29:44 2025 Received: from localhost ([127.0.0.1]:60229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1taYvY-0005zm-C3 for submit <at> debbugs.gnu.org; Wed, 22 Jan 2025 06:29:44 -0500 Received: from mail-4322.protonmail.ch ([185.70.43.22]:14649) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <pipcet@HIDDEN>) id 1taYvV-0005zN-Ae for 75755 <at> debbugs.gnu.org; Wed, 22 Jan 2025 06:29:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1737545373; x=1737804573; bh=hZBuTONE46fALWSDfEOOzz2VOZFNE/evtizx5c6LP/8=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=VVa6xdFQ2ermFzgvuC1kW2GsPwonhh/VjnJ5B80vn0/ZnxM2LVwcJ2584zWD+5j1n xYdmjB/kYXUg/gA2EiPnSufbJHmBXBOgl1v38ElyOUXrbYyFwQjVWYFsfBhT33TZWm 1U9FuE4ry3M//3FdlYjisFqVte6igndyU4f5yPdSiHT9N3mHkJlGVmIIIyEzq1En43 +jHZ3IR9PdULBArq6H7NSryCvl1WjkKr03TEtu+PbkA7mMU0IIxe8FUE2h5WseGvCk gddGdIWVXgb9YmmZMRuTweBsxq3AjNcffsAtu1eeWfcRBdbkshnPXkE66qm7fmB2Z7 6e6RUbhLU1n2A== Date: Wed, 22 Jan 2025 11:29:29 +0000 To: Stefan Kangas <stefankangas@HIDDEN> From: Pip Cet <pipcet@HIDDEN> Subject: Re: bug#75755: feature/igc: Missing IGC_CHECK_RES? Message-ID: <878qr3dr3j.fsf@HIDDEN> In-Reply-To: <CADwFkmn9BViN83WBCOMNZZo78PQga0Zf9nODUm_MrigndM0jtA@HIDDEN> References: <CADwFkmn9BViN83WBCOMNZZo78PQga0Zf9nODUm_MrigndM0jtA@HIDDEN> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: f9a11841ed4723c29a878f83d0bad144efd4fbb1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 75755 Cc: 75755 <at> debbugs.gnu.org, gerd@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.1 (-) "Stefan Kangas" <stefankangas@HIDDEN> writes: > Gerd, do you remember why you didn't add CHECK_RES here? Was there a > reason for that or just an oversight? My mistake (c6a3eb01f7acf9ccd00b38e0ef2ab05164e48635). Please fix, or I'll do it in a bit. Thanks for pointing that out! Pip
bug-gnu-emacs@HIDDEN:bug#75755; Package emacs.
Full text available.Received: (at 75755) by debbugs.gnu.org; 22 Jan 2025 10:59:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 22 05:59:18 2025 Received: from localhost ([127.0.0.1]:60126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1taYS5-0004QR-Rh for submit <at> debbugs.gnu.org; Wed, 22 Jan 2025 05:59:18 -0500 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:46328) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1taYS3-0004QA-PH for 75755 <at> debbugs.gnu.org; Wed, 22 Jan 2025 05:59:16 -0500 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-38632b8ae71so5428866f8f.0 for <75755 <at> debbugs.gnu.org>; Wed, 22 Jan 2025 02:59:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737543550; x=1738148350; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=g8YUl8n15Ngb81ugEKz5m0eArO4VjHQy4KcJ+IuajbM=; b=Oh3WP7Dstse7ZrKg0iaAau0vjYo0dGItvRGj2QqBOUC9qiGaLD0pYFImJ96yYgbGLa JG1S74d46yO+XP82O4a9BSXPxosofTVM/8gZsYmvz1pL+eS7M6sk9uI0vEsclTIPlzv0 Vq5jwLs+vIzpWslrYVnGr7Ra0AiZZrWiiHh4chdDjdKnVeWos7Rf858dIAgVTq2hW8rv 0KBEnQazbZssc+wC53hOqJTG/suFUZyjBb+NXvG0LQ/zrlokE6ChSsAGeML8nXo4bCTc 3xAA6IdlX0HytQDIWPdDCww6aHMgMhKu5N0uUsPjQZn6X8CU4hBmdCiydlzKjxSWHdx5 4FSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737543550; x=1738148350; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=g8YUl8n15Ngb81ugEKz5m0eArO4VjHQy4KcJ+IuajbM=; b=lXm8E296+jhaZ7mmX5GOkD95enNxuXFQyglaXNx9gVh42YadMQ6LmtJYHrSEFnnYAg zhKXZRbUkCi8qY4EDUYYi3fhm3KYKY+khK8b0pfXVasO65IdrwmVAmx5XWAKZOcJhPmT KAe0GAazusKxbzDP3xknwRMJdgtNc5ZaIn4688sZctV3C4uGXa5D9i6HwgaoK9qfxU44 k4Zjq9M/A+byd0MAkwSDliJG9aOREjEEo8stuoPfZaNEfARjTNsfetZMtsABqB+psSkd uVr5XgxXFO5rPXZgcm+FEV7GKu4Ph2AfFR8vghqLKBa0TnHBxDnyiCd/I0+SxPZMhXoy YhvA== X-Gm-Message-State: AOJu0Ywah5GcyQZWMJmEUTh5czwblSGBuDqx4L7i/E6QWDIg6B5JIvUm jv5yObTs2nSBVc7jKqzPJw9q6DvcEh479yuhPiBEA/vlaA14LLVg X-Gm-Gg: ASbGncsIgmB12Ur4gatO5at/S4UV8bMzR8c4PjT6W9cljk4IsoCEuu/6p0Ig9gR8VRi rmZcEWIlz678FyQdnFTizRToyxE0pvbvgy8ErQ2AOzCNTuLRLJ/L3unWl8OwwM5I30eXuwWdfVi GhUzIA7cN849YbTiIuRyfdOP5Xmuox/bSJSK7t3k+vEWWN2oPkjgo2BWTNQgDqjDaZWoaKcw40M aO0oZldCUapnKT2n+CSOzYDQULigHFJ7HHen+xjWz/zD/8mXrS/pOvw4gBooO7Zzc3x8s9KhDUl 7BjmB+iZdEaVuOOXCW7lxTYnkUwEqjpg5ZFaDyYN4YdiQXAX4VrR7f3GTaAqhvhHju7Jmf71u0Q 4KA== X-Google-Smtp-Source: AGHT+IEyvbq+EKPcq1n8SXTYQDqw8Iu2O18PcOkq7SdI4sKMw62IN4nGoWIqIEdvmTQo47EWIU4FUQ== X-Received: by 2002:a5d:438c:0:b0:38a:2b39:679d with SMTP id ffacd0b85a97d-38bf57a9d66mr13949357f8f.32.1737543549597; Wed, 22 Jan 2025 02:59:09 -0800 (PST) Received: from pro2 (p200300e0b70c0300a51c5b839e69c119.dip0.t-ipconnect.de. [2003:e0:b70c:300:a51c:5b83:9e69:c119]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf327e118sm15658042f8f.82.2025.01.22.02.59.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jan 2025 02:59:09 -0800 (PST) From: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN> To: Stefan Kangas <stefankangas@HIDDEN> Subject: Re: bug#75755: feature/igc: Missing IGC_CHECK_RES? In-Reply-To: <CADwFkmn9BViN83WBCOMNZZo78PQga0Zf9nODUm_MrigndM0jtA@HIDDEN> (Stefan Kangas's message of "Wed, 22 Jan 2025 04:27:35 -0600") References: <CADwFkmn9BViN83WBCOMNZZo78PQga0Zf9nODUm_MrigndM0jtA@HIDDEN> Date: Wed, 22 Jan 2025 11:59:08 +0100 Message-ID: <m2a5bjw1vn.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75755 Cc: 75755 <at> debbugs.gnu.org, gerd@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Stefan Kangas <stefankangas@HIDDEN> writes: > Gerd, do you remember why you didn't add CHECK_RES here? Was there a > reason for that or just an oversight? > > diff --git a/src/igc.c b/src/igc.c > index 257e7dc53f7..b6d42c9fbe1 100644 > --- a/src/igc.c > +++ b/src/igc.c > @@ -3129,9 +3129,11 @@ create_thread_aps (struct igc_thread *t) > res = mps_ap_create_k (&t->immovable_ap, gc->immovable_pool, mps_args_none); > IGC_CHECK_RES (res); > res = create_weak_ap (&t->weak_strong_ap, t, false); > + IGC_CHECK_RES (res); > res = create_weak_hash_ap (&t->weak_hash_strong_ap, t, false); > IGC_CHECK_RES (res); > res = create_weak_ap (&t->weak_weak_ap, t, true); > + IGC_CHECK_RES (res); > res = create_weak_hash_ap (&t->weak_hash_weak_ap, t, true); > IGC_CHECK_RES (res); > } Looks like Pip added new APs in 9c9b7a293f27eab3382c434b29eb9c97cb673432 and forgot the checks.
bug-gnu-emacs@HIDDEN:bug#75755; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 22 Jan 2025 10:27:52 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 22 05:27:52 2025 Received: from localhost ([127.0.0.1]:60059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1taXxf-0008Mz-TA for submit <at> debbugs.gnu.org; Wed, 22 Jan 2025 05:27:52 -0500 Received: from lists.gnu.org ([2001:470:142::17]:55356) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1taXxc-0008Mi-Eq for submit <at> debbugs.gnu.org; Wed, 22 Jan 2025 05:27:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <stefankangas@HIDDEN>) id 1taXxU-0001CY-8a for bug-gnu-emacs@HIDDEN; Wed, 22 Jan 2025 05:27:40 -0500 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <stefankangas@HIDDEN>) id 1taXxS-00049A-Iv for bug-gnu-emacs@HIDDEN; Wed, 22 Jan 2025 05:27:39 -0500 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5d41848901bso1600877a12.0 for <bug-gnu-emacs@HIDDEN>; Wed, 22 Jan 2025 02:27:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737541656; x=1738146456; darn=gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=kxVW0d4Q24QmpYJzmGy7Q5Ls1t/xrrf64CIJFo4dmDI=; b=BP6bwfHExDgNkrq6j5oggwVLspPGLT7THrEl9DTc1mDflcHoGwCWkcSK8Mcrczo90c 4MWChf6c26fKNyOFoWtqzRtnKwQloSyHQr4VqzTLLaeL+hS6g5Mp7/4tqp7UJBVIuy/5 2B4l73K4sNS0dZaR3RuHuSlwzqcg0XKYU9DqDwCMOLvUgvV0g70XqtgmjMRVQZeQ9c15 6ViQR1dC3BokzkPLhPb35M+c8uxzvUkOiOOCmK3ChFL34vGQbswr8t8BfbdZ+MazbzGV h+M4fgtG2bDr55c7DuxLIyJdAuw3CPvmPB9cE/Ro1GJFt7Lw3Rn3TJ+ECHY47xHLoHzJ snZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737541656; x=1738146456; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kxVW0d4Q24QmpYJzmGy7Q5Ls1t/xrrf64CIJFo4dmDI=; b=k7Eo4jE6S0FDtKV6eJrthFLpVjIl33KzF5ulvKUcjgtu+IwFHYo1Oqlm4/WPneAKKh 4G3hKHngKiycE1Helh8fR54v8WTP2YBIx8oQeut91hWnmo6f3SC/Bd1j8fTpYvxxxT00 JFbJsMV0knlpAYhJ484ksGFtBD0+bn3qj66CxCgZEt/GC6BgXeh200TJxoiJA97kQz53 VnRZp9GOQs2D0UoXYzU/Kozp2v5R/71utSn3jiwA3dHjSMU342fWHedeNKB3yRVcnSx2 NdZRnXg6Ridn39hE3MBB055hqavdraR3ruo1TKFvrWXGSIHxWxwCAMYMuTPpAVUYINBO f0iQ== X-Gm-Message-State: AOJu0YzLJD4NiPRKdQoqxNefTFqQvGKNUnyaOCs3hF4efH2J82sEx+0K mggDiDfYCD0bvsA7lkQjNCEAywo0ZwS+VVXkriWgCPE6CMHz3nFanDgbmTx3UTmMIT7Ud3V449C Ik3Mn9YNg1EvkY4YKHAGtv0kLO3jA4FSiotk= X-Gm-Gg: ASbGnct8KGGgnty9tt3hV9WUNfOh1th9brk7G7zp52uxVFlrhoOSB7KnCNVTvYJn3nR NGkmYVbwZzf7IqJ5AHdyM/T5SEW2N3A8Sj2ocSVJRbPPAF69FXZ61 X-Google-Smtp-Source: AGHT+IGVP40eiBDDclocvhaRolS+HC1SMuI07uk76JnxKMKV+UCJT9KxPUHG8MgdU7DBUGfXbwvbb92q7hgVFde2sto= X-Received: by 2002:a05:6402:51d3:b0:5d4:c0c:70f9 with SMTP id 4fb4d7f45d1cf-5da0c27e591mr25477608a12.6.1737541656257; Wed, 22 Jan 2025 02:27:36 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 22 Jan 2025 04:27:35 -0600 From: Stefan Kangas <stefankangas@HIDDEN> X-Debbugs-CC: gerd@HIDDEN MIME-Version: 1.0 Date: Wed, 22 Jan 2025 04:27:35 -0600 X-Gm-Features: AbW1kvZYhUno-xiJbyaRKDrzWYTWkLgWukUxZORDVQeRFQ-UznJCgi4UXdOmA2Q Message-ID: <CADwFkmn9BViN83WBCOMNZZo78PQga0Zf9nODUm_MrigndM0jtA@HIDDEN> Subject: feature/igc: Missing IGC_CHECK_RES? To: bug-gnu-emacs@HIDDEN Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::534; envelope-from=stefankangas@HIDDEN; helo=mail-ed1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) Gerd, do you remember why you didn't add CHECK_RES here? Was there a reason for that or just an oversight? diff --git a/src/igc.c b/src/igc.c index 257e7dc53f7..b6d42c9fbe1 100644 --- a/src/igc.c +++ b/src/igc.c @@ -3129,9 +3129,11 @@ create_thread_aps (struct igc_thread *t) res = mps_ap_create_k (&t->immovable_ap, gc->immovable_pool, mps_args_none); IGC_CHECK_RES (res); res = create_weak_ap (&t->weak_strong_ap, t, false); + IGC_CHECK_RES (res); res = create_weak_hash_ap (&t->weak_hash_strong_ap, t, false); IGC_CHECK_RES (res); res = create_weak_ap (&t->weak_weak_ap, t, true); + IGC_CHECK_RES (res); res = create_weak_hash_ap (&t->weak_hash_weak_ap, t, true); IGC_CHECK_RES (res); }
Stefan Kangas <stefankangas@HIDDEN>:gerd@HIDDEN, bug-gnu-emacs@HIDDEN.
Full text available.gerd@HIDDEN, bug-gnu-emacs@HIDDEN:bug#75755; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.