GNU bug report logs - #75775
30.0.93; [PATCH] Restore the old behavior of `bookmark-write-file'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75775 in the body.
You can then email your comments to 75775 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Zhengyi Fu  <i <at> fuzy.me>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.93; [PATCH] Restore the old behavior of `bookmark-write-file'
Date: Thu, 23 Jan 2025 13:45:11 +0800

[Message part 1 (text/plain, inline)]

`pp' now defaults to fill the code to fit in `fill-column', which is
great.  However, this changed the bookmark format and made it less
human-readable and unfriendly to version control.   This small patch
restores the old behavior of `bookmark-write-file'.

[0001-Restore-the-old-behavior-of-bookmark-write-file.patch (text/x-diff, attachment)]

Message #8 received at 75775 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Zhengyi Fu <i <at> fuzy.me>, "75775 <at> debbugs.gnu.org" <75775 <at> debbugs.gnu.org>
Subject: RE: [External] : bug#75775: 30.0.93; [PATCH] Restore the old behavior
 of `bookmark-write-file'
Date: Thu, 23 Jan 2025 17:52:24 +0000

> `pp' now defaults to fill the code to fit in `fill-column', which is
> great.  However, this changed the bookmark format and made it less
> human-readable and unfriendly to version control.   This small patch
> restores the old behavior of `bookmark-write-file'.

1. Thanks for reporting this.

2. Seriously?  pp.el now has a function named
"pp-28"?  And the (only? best?) way to prevent
filling and obtain the longstanding behavior is
to bind `pp-default-function' to `pp-28'?  What
kind of progress is this?

What happened to adding new behavior as optional?

PP _defaults_ to filling now?  Since when does
pretty-printing, in general, imply filling?

Message #13 received at 75775 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Zhengyi Fu <i <at> fuzy.me>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 75775 <at> debbugs.gnu.org
Subject: Re: bug#75775: 30.0.93;
 [PATCH] Restore the old behavior of `bookmark-write-file'
Date: Sat, 25 Jan 2025 13:00:03 +0200

> From: Zhengyi Fu  <i <at> fuzy.me>
> Date: Thu, 23 Jan 2025 13:45:11 +0800
> 
> `pp' now defaults to fill the code to fit in `fill-column', which is
> great.  However, this changed the bookmark format and made it less
> human-readable and unfriendly to version control.   This small patch
> restores the old behavior of `bookmark-write-file'.

I'm not sure we should use such kludges just because the new default
changes the whitespace.  But if we do make any changes, we should do
it ASAP, since the change in pp's behavior was introduced in Emacs 30.

Stefan, WDYT?

Message #16 received at 75775 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Zhengyi Fu <i <at> fuzy.me>, 75775 <at> debbugs.gnu.org,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#75775: 30.0.93;
 [PATCH] Restore the old behavior of `bookmark-write-file'
Date: Sat, 25 Jan 2025 06:43:51 -0500

[Message part 1 (text/plain, inline)]

On Sat, Jan 25, 2025 at 6:01 AM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Zhengyi Fu  <i <at> fuzy.me>
> > Date: Thu, 23 Jan 2025 13:45:11 +0800
> >
> > `pp' now defaults to fill the code to fit in `fill-column', which is
> > great.  However, this changed the bookmark format and made it less
> > human-readable and unfriendly to version control.   This small patch
> > restores the old behavior of `bookmark-write-file'.
>
> I'm not sure we should use such kludges just because the new default
> changes the whitespace.  But if we do make any changes, we should do
> it ASAP, since the change in pp's behavior was introduced in Emacs 30.
>
> Stefan, WDYT?
>

(I know you meant one of the other 200 Stefans Stevens Stephans Stephanes)

I often hand edit my bookmark files due to one of the packages I help
maintain that relies on bookmarks.

I prefer easier to harder and I prefer the original format.

-Stephane

[Message part 2 (text/html, inline)]

Message #19 received at 75775 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Zhengyi Fu <i <at> fuzy.me>, 75775 <at> debbugs.gnu.org,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#75775: 30.0.93;
 [PATCH] Restore the old behavior of `bookmark-write-file'
Date: Sat, 25 Jan 2025 07:13:04 -0500

[Message part 1 (text/plain, inline)]

Aha, I spoke to soon about Tramp. Looks like someone put in (non-essential
t) so that takes care of that.

In any case, it seems would be better would be to defer the translation
work rather than do it in the defcustom.

On Sat, Jan 25, 2025 at 6:43 AM Ship Mints <shipmints <at> gmail.com> wrote:

> On Sat, Jan 25, 2025 at 6:01 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
>
>> > From: Zhengyi Fu  <i <at> fuzy.me>
>> > Date: Thu, 23 Jan 2025 13:45:11 +0800
>> >
>> > `pp' now defaults to fill the code to fit in `fill-column', which is
>> > great.  However, this changed the bookmark format and made it less
>> > human-readable and unfriendly to version control.   This small patch
>> > restores the old behavior of `bookmark-write-file'.
>>
>> I'm not sure we should use such kludges just because the new default
>> changes the whitespace.  But if we do make any changes, we should do
>> it ASAP, since the change in pp's behavior was introduced in Emacs 30.
>>
>> Stefan, WDYT?
>>
>
> (I know you meant one of the other 200 Stefans Stevens Stephans Stephanes)
>
> I often hand edit my bookmark files due to one of the packages I help
> maintain that relies on bookmarks.
>
> I prefer easier to harder and I prefer the original format.
>
> -Stephane
>

[Message part 2 (text/html, inline)]

Message #22 received at 75775 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Zhengyi Fu <i <at> fuzy.me>, 75775 <at> debbugs.gnu.org
Subject: Re: bug#75775: 30.0.93; [PATCH] Restore the old behavior of
 `bookmark-write-file'
Date: Sat, 25 Jan 2025 07:18:43 -0500

> I'm not sure we should use such kludges just because the new default
> changes the whitespace.  But if we do make any changes, we should do
> it ASAP, since the change in pp's behavior was introduced in Emacs 30.
>
> Stefan, WDYT?

No specific opinion.  My understanding is that we should introduce some
kind of `pp-fast` function, but in the mean time hacks like this patch
seem fine to me.


        Stefan

Message #27 received at 75775-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: i <at> fuzy.me, 75775-done <at> debbugs.gnu.org
Subject: Re: bug#75775: 30.0.93; [PATCH] Restore the old behavior of
 `bookmark-write-file'
Date: Sat, 25 Jan 2025 15:59:13 +0200

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Cc: Zhengyi Fu <i <at> fuzy.me>,  75775 <at> debbugs.gnu.org
> Date: Sat, 25 Jan 2025 07:18:43 -0500
> 
> > I'm not sure we should use such kludges just because the new default
> > changes the whitespace.  But if we do make any changes, we should do
> > it ASAP, since the change in pp's behavior was introduced in Emacs 30.
> >
> > Stefan, WDYT?
> 
> No specific opinion.  My understanding is that we should introduce some
> kind of `pp-fast` function, but in the mean time hacks like this patch
> seem fine to me.

Thanks, installed on the emacs-30 branch, and closing the bug.

Message #30 received at 75775 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Ship Mints <shipmints <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>
Cc: Zhengyi Fu <i <at> fuzy.me>, "75775 <at> debbugs.gnu.org" <75775 <at> debbugs.gnu.org>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: RE: [External] : bug#75775: 30.0.93; [PATCH] Restore the old behavior
 of `bookmark-write-file'
Date: Sat, 25 Jan 2025 23:10:30 +0000

> I often hand edit my bookmark files due to one of
> the packages I help maintain that relies on bookmarks.
>
> I prefer easier to harder and I prefer the original format.

+1.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.