GNU bug report logs - #75826
[PATCH] New variable 'bookmark-bmenu-type-column-width'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75826 in the body.
You can then email your comments to 75826 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] New variable 'bookmark-bmenu-type-column-width'
Date: Sat, 25 Jan 2025 08:45:53 -0500

[Message part 1 (text/plain, inline)]

*** New variable 'bookmark-bmenu-type-column-width'.

This variable allows a user to control the width of the type column
on the bookmark menu 'bookmark-bmenu-list'. The default value is 8
which is backwards compatible.

I marked this new variable as of 31.1 but could also be for 30.2.

Rationale: In one package I co-maintain, we have custom bookmark handlers
with appropriate properties set. The limit of 8 characters for display in
the bookmark menu can lead to cumbersome naming for handler abbreviations.

-Stephane

[Message part 2 (text/html, inline)]

[0001-Add-new-custom-variable-bookmark-bmenu-type-column-w.patch (application/octet-stream, attachment)]

Message #8 received at 75826 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Ship Mints <shipmints <at> gmail.com>
Cc: 75826 <at> debbugs.gnu.org
Subject: Re: bug#75826: [PATCH] New variable 'bookmark-bmenu-type-column-width'
Date: Sun, 26 Jan 2025 12:30:16 +0100

>>>>> On Sat, 25 Jan 2025 08:45:53 -0500, Ship Mints <shipmints <at> gmail.com> said:

    Ship> *** New variable 'bookmark-bmenu-type-column-width'.
    Ship> This variable allows a user to control the width of the type column
    Ship> on the bookmark menu 'bookmark-bmenu-list'. The default value is 8
    Ship> which is backwards compatible.

    Ship> I marked this new variable as of 31.1 but could also be for 30.2.

If itʼs a defcustom we call it a "user option". Putting on my
wordsmithing hat:

*** New user option 'bookmark-bmenu-type-column-width'.
Specifies the width of the type column in the bookmark menu shown by
'bookmark-bmenu-list'. Default value is 8, which is backwards
compatible.


    Ship> Rationale: In one package I co-maintain, we have custom bookmark handlers
    Ship> with appropriate properties set. The limit of 8 characters for display in
    Ship> the bookmark menu can lead to cumbersome naming for handler abbreviations.

    Ship> -Stephane
    Ship> From b4cc1e055755ceaaa348776f1c2fe40b67f02511 Mon Sep 17 00:00:00 2001
    Ship> From: shipmints <shipmints <at> gmail.com>
    Ship> Date: Sat, 25 Jan 2025 08:36:12 -0500
    Ship> Subject: [PATCH] Add new custom variable bookmark-bmenu-type-column-width

    Ship> This variable allows a user to control the width of the type column
    Ship> on the bookmark menu 'bookmark-bmenu-list'. The default value is 8
    Ship> which is backwards compatible.

    Ship> * lisp/bookmark.el (bookmark-bmenu-mode):
    Ship> Honor bookmark-bmenu-type-column-width when creating the
    Ship> tabulated list.

The commit message should mention the new defcustom.

Robert
-- 

Message #11 received at 75826 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 75826 <at> debbugs.gnu.org
Subject: Re: bug#75826: [PATCH] New variable 'bookmark-bmenu-type-column-width'
Date: Mon, 27 Jan 2025 11:20:25 -0500

[Message part 1 (text/plain, inline)]

Thank you for the feedback. Revised patch attached.

On Sun, Jan 26, 2025 at 6:30 AM Robert Pluim <rpluim <at> gmail.com> wrote:

> >>>>> On Sat, 25 Jan 2025 08:45:53 -0500, Ship Mints <shipmints <at> gmail.com>
> said:
>
>     Ship> *** New variable 'bookmark-bmenu-type-column-width'.
>     Ship> This variable allows a user to control the width of the type
> column
>     Ship> on the bookmark menu 'bookmark-bmenu-list'. The default value is
> 8
>     Ship> which is backwards compatible.
>
>     Ship> I marked this new variable as of 31.1 but could also be for 30.2.
>
> If itʼs a defcustom we call it a "user option". Putting on my
> wordsmithing hat:
>
> *** New user option 'bookmark-bmenu-type-column-width'.
> Specifies the width of the type column in the bookmark menu shown by
> 'bookmark-bmenu-list'. Default value is 8, which is backwards
> compatible.
>
>
>     Ship> Rationale: In one package I co-maintain, we have custom bookmark
> handlers
>     Ship> with appropriate properties set. The limit of 8 characters for
> display in
>     Ship> the bookmark menu can lead to cumbersome naming for handler
> abbreviations.
>
>     Ship> -Stephane
>     Ship> From b4cc1e055755ceaaa348776f1c2fe40b67f02511 Mon Sep 17
> 00:00:00 2001
>     Ship> From: shipmints <shipmints <at> gmail.com>
>     Ship> Date: Sat, 25 Jan 2025 08:36:12 -0500
>     Ship> Subject: [PATCH] Add new custom variable
> bookmark-bmenu-type-column-width
>
>     Ship> This variable allows a user to control the width of the type
> column
>     Ship> on the bookmark menu 'bookmark-bmenu-list'. The default value is
> 8
>     Ship> which is backwards compatible.
>
>     Ship> * lisp/bookmark.el (bookmark-bmenu-mode):
>     Ship> Honor bookmark-bmenu-type-column-width when creating the
>     Ship> tabulated list.
>
> The commit message should mention the new defcustom.
>
> Robert
> --
>

[Message part 2 (text/html, inline)]

[0001-Add-new-user-option-bookmark-bmenu-type-column-width.patch (application/octet-stream, attachment)]

Message #16 received at 75826-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ship Mints <shipmints <at> gmail.com>
Cc: 75826-done <at> debbugs.gnu.org, rpluim <at> gmail.com
Subject: Re: bug#75826: [PATCH] New variable 'bookmark-bmenu-type-column-width'
Date: Sat, 01 Feb 2025 12:35:10 +0200

> Cc: 75826 <at> debbugs.gnu.org
> From: Ship Mints <shipmints <at> gmail.com>
> Date: Mon, 27 Jan 2025 11:20:25 -0500
> 
> Thank you for the feedback. Revised patch attached.

Thanks, installed on the master branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.