GNU bug report logs - #75841
[PATCH] Fix mouse click on flymake

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Ergus <spacibba@HIDDEN>; Keywords: patch; dated Sat, 25 Jan 2025 21:28:02 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Changed bug title to '[PATCH] Fix mouse click on flymake' from '[PATCH] [UPDATE3] Fix mouse click on flymake' Request was from Stefan Kangas <stefankangas@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 75841 <at> debbugs.gnu.org:

Received: (at 75841) by debbugs.gnu.org; 25 Feb 2025 00:37:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 24 19:37:03 2025
Received: from localhost ([127.0.0.1]:43618 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tmiwY-0000tv-0r
	for submit <at> debbugs.gnu.org; Mon, 24 Feb 2025 19:37:03 -0500
Received: from sonic302-3.consmr.mail.bf2.yahoo.com ([74.6.135.42]:35301)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <spacibba@HIDDEN>) id 1tmiwV-0000tY-Nq
 for 75841 <at> debbugs.gnu.org; Mon, 24 Feb 2025 19:37:00 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048;
 t=1740443812; bh=Aq5MQKX9JgtdF9q+Q6tvqOsnvMFEvvJE9HLZv91hTgw=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To;
 b=VDrO+tr0tKKj4PsiZWX2rPYPc+NcOHTErir+CMxKExiyHJYfwU9YBSbE04wtieT0l8ApPZMILYQzfg4oLMegspTnIhPsdDg89qFz7SF7lrCyI7lenpp3kamBocP4q602sGnNw0VlEfgTpYKyUEAUR/MdhW1O/BkfJhNWcmo638zgfNFH3iHszU0fofRL9j+qYWbpNMYFRxLe8Fzou7PZ4cCJh4CjNRqo4vfEyYwBO5gOWH/QgK/D9Fn+zhftcxnYakZUvV86RCefQEmFopB5H88D5kWokWQ2KGlnpcwMzn/ao1azlLBD2mus2peily1UAtNNWM7lAq4qNBvv3haxMg==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
 t=1740443812; bh=6vmfkkos11kKRAseLVWK8a1OvwHG6Je8c0rY2wDFTGs=;
 h=X-Sonic-MF:Date:From:To:Subject:From:Subject;
 b=awFSp1dQbGxpqm6NE82EVltw0dTqwNG7WTpeD4dK3EkoG9EIwtotHS5/uIDijTvkz9mWm2e2SsmXIzd3A8X74D8TBp2CT66OZKekgs0Y++oX0oEYFT9jiwMnJ7tgnKpUzw4FS5/9bJnbL3CSIi0scVx1jSLOYgmPZfJ++0glr7lsC9ZTJheVcy95x9F2KulLF07lYYiofBOKw6BssSKxJ9UW+WKZy+7mf2w5Fu2N+szdZX9OZk572R2sT8zyXMZMc7tcb3MOaEg7AgUCTXkcQAkmJtihYDtFeCrdq+E129GaZXh+3wGJpGB+mzQxPPHTBP13U81NYg/62+yBkqJguw==
X-YMail-OSG: SvkmVjAVM1m_kb6lmeq6KG7gYyTwqTnNEArIjz0gSIStVzti0bUhF4hnIVyDDeu
 2_eZCvPqQsbO6J6bOGAqx_mCNN7ZJXTxw149ATdsf90A_7DxZcBflIB4zgwY42T7M4qs5RL4OQGq
 WwzhElO3.TSsA7ydyLy.sRm_kGp67J0GB2FWXf4m4Z7JX9wOK90nKpMm5f.Ht2yXChZ.Sa519reR
 ekov_YAdnTGdMXWieHFPzKJ3ihfJuqr0m2m7mRmnlX4ZDJaQVUcIiz_bHNb1C6D_l1_zJQ74h7in
 yvHQcV3i8Pdv487h23pciiAwXnoUVMHNjjOE5EvvQpeh76PzSlFu4W3rGbB.ywTiIm0m1S2p5JZc
 yWn0bkl4muoSlNvo7MjCfW949fJOyMUdOJ5Ha.uYNgDCfZyDO4VIOu_bvrsNbjdknHSJh7MSoE3j
 mO4f2X_7fm1jQyj0WjUSqaTb4VrTHOtXba60jQK0lwn0lon8NAI_gz5fb3Lq1umnB_E.oNFdD0KN
 MnvK9p6iJmhI8YgHi4nJGOTKwzVJ8vtLZ2aTw59EH2dNHKJlLfHIQKLnPs3dgFsUeilvOT1X4lj4
 I5wWv5la.WNWLNL0m0VYknVXXtc0aJ9Lpnacux9eqgyvG6gfitc9jkUF8xxWxS8ITb9HO_sPEIps
 .1nEVX0Wbjgxnr5FrrqYsprTbuDRtSY9FbbQBPyjRuy7d1eGpeUEak1pGqgCnr65L9F5rJHu52IY
 bAeL8Si2JpfGDXKuqU8LPCu6xtkh_JPkiX2JVGd.dmeZPl.ZtxoghMxuvMV_bnghoX3Ze1VCuE97
 5uOJiXzDBYIZAGfdK5LjhKIHWMTzcMoiYaDtHnChbA3gAid31z7CmgOe4eUIN7gg0KSMHfgvjlWw
 iXu9tre.dgr_m4MlAtMXM.q9_NgA7tQvLVRubYl68GdVsLsjNlSHNvIAwe3f5tIu.hlmKlqOXqbg
 4yoR2qJXNnZtTtdZar_ofuk.ZgPPiIcQscuVWQ9l01iee5dP1Y9PoksSpOU3Tsp2r8ShCei1GAjt
 LK1jOpckwzfqigLKmtBdRZfglFSket04.IexdezvZ4s96xGKdBSU8kXF0h_93svQeo4SMxh.K2Ep
 V.lMiXiTeaNSF9lI4oh3uaahAq0SrZaRRr0L5UFjFIr.p1PtKP1vHiJUl_mWeKBTuZ2KzqUMa6z1
 SvknYmGg1HY8fmAG7yv14LQa79roU.KTGK4juh.Bp28QkPJt_mxQ7.7FvSBOZbAgOMVYNE6hNVQl
 e1gM4bP2eqdT_ckqvm4erXpPEoVs6p7wcYBBnQ4G1M2Cxr2bsK_Rtl6mBtSKv1zblR6yipnjZ8sR
 uPyrmnB0oa.720NcCZAiirhm9v2xTYEqwEnhdKrEgmTAB8yE.cIlyMUIIUtOnwYHy7_L6pffAWO7
 JG2o6oAJKuTza8E3HriltXS0ffkfg.ulIF8ruKiBp5ECjlzwviWl7A3rRF2cTfnx7kpTJm7y5aCy
 qATLkTJhRfCvxvIIN5nGeDwEiZjl7Z.kBVmvpLQUsxs.CVmQWO2MbBZIUdKbXx85y4qESboACqAP
 44NlgA5H3_sgFyEZyL2p9irmwfuj2Yj59dO7nVA26kRAKonHg_qimV64Tm9giA9u9W9V8ewJKjWR
 kGUz.VKjyx82WD.NeJz.k2JP9eWjb0TJ3MUX_3gv.5h9hRIB8YesBUTAnB485o8KVjUCQhuOrqIu
 njIey5AYs7lS_vxVg0Mnm3Gr0ceH8896h..kOFxhAHPZwULb9sLm9xlIHmTsps5QMLkvKdrm2r2u
 UXQBfv7Q3jCijEaRx8zE3x60kS8pTd1YtL7xvlHSD5PrhQ7Mif9Q.j0Lsub3LM_7AhvqEoj04xdw
 OTTMYbMOCcC87xjltbqymhoqI4ll57.3WDvba4Qh9bTt6puRZrWwvMq54yD3ugoelcrdlA3aYvqj
 hZhl0egjGQcxFbQvkWnNhC861DINcDTBTQKFmEE_gs94e08YXbgHEyBDhsou7ZA1O6pe8snyXtZV
 ZDRSIir6JOKTPJWCbjhrtSGMNSGKMrrzpxbHf1HjgjHlGcsFINcyBRMMtes._KBDh071f0Lrg86i
 54cK5cXWv_1iZ82.goIkZ0NW.RDPDLxbXpBvp0juV1a7kFfQUqJkL8azjX4mLpRL4ZA1w4KW9SpI
 oL7uZDJAM2YHUfXWMUXtjKGTEksnjbTQ2YwxrNZcC6PmPPR28MS62xDxp5hIHOBr1iam_dB3Pg3K
 Ewf0-
X-Sonic-MF: <spacibba@HIDDEN>
X-Sonic-ID: 1123c2a0-a9bb-4e08-8690-8a415444c01b
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic302.consmr.mail.bf2.yahoo.com with HTTP; Tue, 25 Feb 2025 00:36:52 +0000
Received: by hermes--production-ir2-c694d79d9-qdvzb (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID 60afcfa37958c1153c954cd2b8a15e2a; 
 Tue, 25 Feb 2025 00:36:49 +0000 (UTC)
Date: Tue, 25 Feb 2025 01:36:47 +0100
From: Ergus <spacibba@HIDDEN>
To: Stefan Kangas <stefankangas@HIDDEN>
Subject: Re: bug#75841: [PATCH] [UPDATE4] Fix mouse click on flymake
Message-ID: <odhqkhqcbmz34rbqbb2orrgw24squg63q2k72ua4pvc4777ibi@dxxx7x3jpcsz>
References: <87tt9m95hy.fsf@HIDDEN>
 <whcg5olmy43oygl5jcjklgdiqxaih5ql2qf2sk4nej2ilpo6oj@slx7vkyud3jm>
 <87y0ywulnm.fsf@HIDDEN>
 <4cazxxxaihei5aswrs7xwy3drgwsqt4faa4phn7ydnwzsodkpr@di6usnoc7axv>
 <87sep2950w.fsf@HIDDEN>
 <xqpehs3emkudayauh533bk3kob5b235mzee3nvzm5nnfl2jdym@iijed6mnjazs>
 <87wme3wlyu.fsf@HIDDEN>
 <gtlziq5wtmfxo7b2p5ib63dusyvkykru2cdiiknkcomnagyynf@kft6yia6sjx2>
 <87tt909w1u.fsf@HIDDEN>
 <CADwFkmniD8tjbE-EbT-HLZps_D1L4WsaUbgA2K70VgVCnAUn3w@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="s7gyvc4nx4uzldcm"
Content-Disposition: inline
In-Reply-To: <CADwFkmniD8tjbE-EbT-HLZps_D1L4WsaUbgA2K70VgVCnAUn3w@HIDDEN>
X-Mailer: WebService/1.1.23369
 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol
Content-Length: 11650
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75841
Cc: sbaugh@HIDDEN, eliz@HIDDEN, 75841 <at> debbugs.gnu.org,
 Juri Linkov <juri@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--s7gyvc4nx4uzldcm
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline

Hi Stefan:

Please find attached the patch.

Best,
Ergus

>
>Ergus, could you please resend the patch as an attachment as formatted
>by
>
>    git format-patch -1
>
>and preferably also with a ChangeLog message as per CONTRIBUTE?
>
>Thanks in advance.

--s7gyvc4nx4uzldcm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename="0001-Add-jump-action-to-margin-indicators-in-flymake.patch"

From d5be93a2848ef638d6366566f0da25f8ea2bedb5 Mon Sep 17 00:00:00 2001
From: Jimmy Aguilar Mena <kratsbinovish@HIDDEN>
Date: Tue, 25 Feb 2025 01:32:16 +0100
Subject: [PATCH] Add jump action to margin indicators in flymake

(flymake--indicator-overlay-spec): Receive type instead of prepossessed
indicator
(flymake--resize-margins): Update reference call to
flymake--indicator-overlay-spec
(flymake-show-buffer-diagnostics-at-event-line):
(flymake-diagnostics-at-mouse-event):
(flymake-show-buffer-diagnostics-at-event-position): New functions
(flymake-after-show-buffer-diagnostics-hook): New custom with actions
when jumping to an error line
(flymake-pulse-momentary-highlight-region):
(flymake-show-buffer-diagnostics): Receive new optional argument with
current diagnostic information. Add code to jump and execute the new hook
after jumping.
---
 lisp/progmodes/flymake.el | 138 +++++++++++++++++++++++++++-----------
 1 file changed, 100 insertions(+), 38 deletions(-)

diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index 9dda53713f5..6141fd46c6e 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -748,34 +748,41 @@ flymake--severity
   (flymake--lookup-type-property type 'severity
                                  (warning-numeric-level :error)))
 
-(defun flymake--indicator-overlay-spec (indicator)
+(defun flymake--indicator-overlay-spec (type)
   "Return INDICATOR as propertized string to use in error indicators."
-  (let* ((value (if (symbolp indicator)
+  (let* ((indicator (flymake--lookup-type-property
+                     type
+                     (cond ((eq flymake-indicator-type 'fringes)
+                            'flymake-bitmap)
+                           ((eq flymake-indicator-type 'margins)
+                            'flymake-margin-string))
+                     (alist-get 'bitmap (alist-get type ; backward compat
+                                                   flymake-diagnostic-types-alist))))
+         (value (if (symbolp indicator)
                     (symbol-value indicator)
                   indicator))
-         (indicator-car (if (listp value)
-                            (car value)
-                          value))
-         (indicator-cdr (if (listp value)
-                            (cdr value))))
+         (valuelist (if (listp value)
+                        value
+                      (list value)))
+         (indicator-car (car valuelist)))
+
     (cond
      ((and (symbolp indicator-car)
            flymake-fringe-indicator-position)
       (propertize "!" 'display
-                  (cons flymake-fringe-indicator-position
-                        (if (listp value)
-                            value
-                          (list value)))))
+                  (cons flymake-fringe-indicator-position valuelist)))
      ((and (stringp indicator-car)
            flymake-margin-indicator-position)
       (propertize "!"
                   'display
                   `((margin ,flymake-margin-indicator-position)
-                    ,(propertize
-                      indicator-car
-                      'face
-                      `(:inherit (,indicator-cdr
-                                  default)))))))))
+                    ,(propertize indicator-car
+                                 'face `(:inherit (,(cdr valuelist) default))
+                                 'mouse-face 'highlight
+                                 'help-echo "Open Flymake diagnostics"
+                                 'keymap `,(define-keymap
+                                             (format "<%s> <mouse-1>" flymake-margin-indicator-position)
+                                             #'flymake-show-buffer-diagnostics-at-event-line))))))))
 
 (defun flymake--resize-margins (&optional orig-width)
   "Resize current window margins according to `flymake-margin-indicator-position'.
@@ -941,16 +948,7 @@ flymake--highlight-line
                   (overlay-put ov prop (flymake--lookup-type-property
                                         type prop value)))))
       (default-maybe 'face 'flymake-error)
-      (default-maybe 'before-string
-        (flymake--indicator-overlay-spec
-         (flymake--lookup-type-property
-          type
-          (cond ((eq flymake-indicator-type 'fringes)
-                 'flymake-bitmap)
-                ((eq flymake-indicator-type 'margins)
-                 'flymake-margin-string))
-          (alist-get 'bitmap (alist-get type ; backward compat
-                                        flymake-diagnostic-types-alist)))))
+      (default-maybe 'before-string (flymake--indicator-overlay-spec type))
       ;; (default-maybe 'after-string
       ;;                (flymake--diag-text diagnostic))
       (default-maybe 'help-echo
@@ -1369,12 +1367,28 @@ flymake-start
                   nil)))
              (flymake--import-foreign-diagnostics))))))
 
-(defvar flymake-mode-map
-  (let ((map (make-sparse-keymap)))
-    (define-key map `[,flymake-fringe-indicator-position mouse-1]
-                #'flymake-show-buffer-diagnostics)
-    map)
-  "Keymap for `flymake-mode'.")
+(defun flymake-show-buffer-diagnostics-at-event-line (event)
+  "Show diagnostics buffer on mouse click in the margin or fringe.
+This uses two different approaches to work.
+For margin it is set as a char property of the margin character directly.
+While in the fringe it is set as part of the `flymake-mode-map'."
+  (interactive "e")
+  (when-let* ((diagnostics (flymake-diagnostics-at-mouse-event event t))
+              (first-diag (car diagnostics)))
+    (with-selected-window (posn-window (event-end event))
+      (with-current-buffer (window-buffer)
+        (when (or (< (point) (flymake-diagnostic-beg first-diag))
+                  (> (point) (flymake-diagnostic-end first-diag)))
+          (goto-char (flymake-diagnostic-beg first-diag)))
+
+        (flymake-show-buffer-diagnostics first-diag)))))
+
+;; Set the fringe mouse-1 action directly and perform the filtering
+;; latter iterating over the overlays.
+(defvar-keymap flymake-mode-map
+               :doc "Keymap for `flymake-mode'."
+               (format "<%s> <mouse-1>" flymake-fringe-indicator-position)
+               #'flymake-show-buffer-diagnostics-at-event-line)
 
 ;;;###autoload
 (define-minor-mode flymake-mode
@@ -1616,6 +1630,28 @@ flymake-goto-prev-error
                      t))
   (flymake-goto-next-error (- (or n 1)) filter interactive))
 
+(defun flymake-diagnostics-at-mouse-event (event full-line)
+  "Get the flymake diagnostics for a position given by a mouse EVENT.
+When FULL-LINE is not nil it gives all the diagnostics in the EVENT's
+line. The function does not move the cursor position."
+  (mouse-minibuffer-check event)
+  (let* ((posn (event-end event))
+	 (pos (posn-point posn)))
+    (when (and (numberp pos)
+               (< pos (point-max))) ;; pos is == (point-max) when the click is after the buffer end.
+      (with-selected-window (posn-window posn)
+	(with-current-buffer (window-buffer)
+          (save-excursion
+            (goto-char pos)
+            (if full-line
+                (flymake-diagnostics (line-beginning-position) (line-end-position))
+              (flymake-diagnostics pos (1+ pos)))))))))
+
+(defun flymake-show-buffer-diagnostics-at-event-position (event)
+  (interactive "e")
+  (flymake-show-buffer-diagnostics
+   (car (flymake-diagnostics-at-mouse-event event nil))))
+
 
 ;;; Mode-line and menu
 ;;;
@@ -1624,7 +1660,7 @@ flymake-menu
     [ "Go to next problem"      flymake-goto-next-error t ]
     [ "Go to previous problem"  flymake-goto-prev-error t ]
     [ "Check now"               flymake-start t ]
-    [ "List all problems"       flymake-show-buffer-diagnostics t ]
+    [ "List all problems"       flymake-show-buffer-diagnostics-at-event-position t ]
     "--"
     [ "Go to log buffer"        flymake-switch-to-log-buffer t ]
     [ "Turn off Flymake"        flymake-mode t ]))
@@ -1652,6 +1688,15 @@ flymake-mode-line-lighter
   :type 'string
   :version "29.1")
 
+(defcustom flymake-after-show-buffer-diagnostics-hook '(flymake-pulse-momentary-highlight-region)
+  "Hook called after jumping to a diagnostic line.
+
+This hooks are called when `flymake-show-buffer-diagnostics' receives an
+the optional `diagnostic' argument and it matches an entry in the
+diagnostic's buffer."
+  :type 'hook
+  :version "31.0")
+
 (defvar flymake-mode-line-title '(:eval (flymake--mode-line-title))
   "Mode-line construct to show Flymake's mode name and menu.")
 
@@ -1822,6 +1867,17 @@ flymake-diagnostics-buffer-mode-map
     (define-key map (kbd "SPC") 'flymake-show-diagnostic)
     map))
 
+
+(defun flymake-pulse-momentary-highlight-region (&optional start end)
+  "Helper function to highlight region.
+This uses the point `line-beginning-position' and `line-end-position' to
+determine the optional START and END when the optional values are not
+specified."
+  (pulse-momentary-highlight-region (or start (line-beginning-position))
+                                    (or end (line-end-position))
+                                    'highlight))
+
+
 (defun flymake-show-diagnostic (pos &optional other-window)
   "Show location of diagnostic at POS."
   (interactive (list (point) t))
@@ -1833,9 +1889,7 @@ flymake-show-diagnostic
          (end (flymake--diag-end diag))
          (visit (lambda (b e)
                   (goto-char b)
-                  (pulse-momentary-highlight-region (point)
-                                                    (or e (line-end-position))
-                                                    'highlight))))
+                  (flymake-pulse-momentary-highlight-region b e))))
     (with-current-buffer (cond ((bufferp locus) locus)
                                (t (find-file-noselect locus)))
       (with-selected-window
@@ -1969,7 +2023,7 @@ flymake--diagnostics-buffer-name
 (define-obsolete-function-alias 'flymake-show-diagnostics-buffer
   'flymake-show-buffer-diagnostics "1.2.1")
 
-(defun flymake-show-buffer-diagnostics ()
+(defun flymake-show-buffer-diagnostics (&optional diagnostic)
   "Show a list of Flymake diagnostics for current buffer."
   (interactive)
   (unless flymake-mode
@@ -1987,7 +2041,15 @@ flymake-show-buffer-diagnostics
                       `((display-buffer-reuse-window
                          display-buffer-below-selected)
                         (window-height . (lambda (window)
-                          (fit-window-to-buffer window 10))))))))
+                                           (fit-window-to-buffer window 10)))))
+      (when (and diagnostic flymake-after-show-buffer-diagnostics-hook)
+        (goto-char (point-min))
+        (catch 'done
+          (while-let ((id (tabulated-list-get-id (point))))
+            (if (eq (plist-get id :diagnostic) diagnostic)
+                (progn (run-hooks 'flymake-after-show-buffer-diagnostics-hook)
+                       (throw 'done nil))
+              (forward-line))))))))
 
 
 ;;; Per-project diagnostic listing
-- 
2.48.1


--s7gyvc4nx4uzldcm--

Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75841; Package emacs. Full text available.

Message received at 75841 <at> debbugs.gnu.org:

Received: (at 75841) by debbugs.gnu.org; 23 Feb 2025 00:18:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 22 19:18:54 2025
Received: from localhost ([127.0.0.1]:57955 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tlzhu-00047L-1g
	for submit <at> debbugs.gnu.org; Sat, 22 Feb 2025 19:18:54 -0500
Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:57411)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1tlzhr-000473-8S
 for 75841 <at> debbugs.gnu.org; Sat, 22 Feb 2025 19:18:52 -0500
Received: by mail-ed1-x52f.google.com with SMTP id
 4fb4d7f45d1cf-5e0452f859cso5126965a12.2
 for <75841 <at> debbugs.gnu.org>; Sat, 22 Feb 2025 16:18:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1740269925; x=1740874725; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=Qv+ME8B1VaFCAY+TuBXuHw54fkfFwKswp6agf8cG1MA=;
 b=mEP20prYOPKw1Zvyljm+kzSL+qVS4ILr7+ajzyvqYwi492WKWG+6DTACRd1prHwdTV
 yDY3g7qpjobaRhpc4QaPOQy2mcMcrh9AWWv9UmONRzChdCrrA/KAj+Unka3ijO/F9w09
 yZGduc5NyhcP2bXZ3WqFL+dH8oLjlFGPgKl2m073iuCvsC/VoAxlCEG5H258DkTKRioG
 jvnXMZmaqgDbwX4RIC+rYumArHo6zDknTH4fOq6nx45XjtxVnpR14FPxITW3BgVIcm2J
 BwWdfhc49o43AF4Nal3lTRxnM8vQm7zf5c0OMJO3fK/3XJQjPOe7MPPLd7RVD7x8EPhE
 2k0g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1740269925; x=1740874725;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=Qv+ME8B1VaFCAY+TuBXuHw54fkfFwKswp6agf8cG1MA=;
 b=Kqu5SHZ5k63kaNqk6vVhWcTnGIjqxq7LhXSScg2ixdHRiWpaLyWzHl2gHHCLMBbPRz
 eytD5SCxq8VOWsHS6s5mSllQiDRwDaKBztmcqyYkCzcKxZju0AW8j6XYKmKjQDkD3lfz
 tlBY7fLT8XIBnnkNO2fe7MJzL9uEBTytLIEoIOEDpYEYZ8K7ZjQIkKOHlT+Z4ChkI9i3
 9sJ9ElIN/sQBhrj9FKV1rJ8xJ81gbWTowsZk4CvjvpUvT4Zonj/g0GHlNTAGZefmLGBH
 srL3qrEf3/WHIzZ3qkdbkFdgde8gLq1MaXwfi8i7DmcB47PEuzRtqsKAXHPO+fobTqtL
 JuMw==
X-Forwarded-Encrypted: i=1;
 AJvYcCXgGIzhqDynbIZls7fHvZHnhU0e6hI7Wr2V7yqgogGufjlf8Bbf5LItkIr4Dqwj1cF1z8FINg==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YzCb+5T/EPWs8jLadEEZDtXwAlsfwBaHHc1crjsxacLP2Upoh39
 AM59Nc83JE5PyHS8iGZPWOZzOLkTpTDvKdvGFQe1RAqxsDTzTCHaGYvlrVVdrMivH8/IynQionX
 weDyruD7P/oXtNv1VZH71YlJRN7M=
X-Gm-Gg: ASbGncsu+eb38OinYxm1DYR5emxhk+kG16Cc7q4ynPmKWucVrVfGVWEqNbGxM9U9t5b
 T77yb1Lweo1WmdksZ8BlayjI2cdkch11k1T8UfggrwquvIWJVi7zz3wRMOakxJr5tYA047hcMfu
 mI3odsj9SI
X-Google-Smtp-Source: AGHT+IHOlWkJsCzWXh73VkV1zxM73op60X7CAljDilrxVFlWFg9WT02F6vTkQFMmn0kJHF2cVbqiKg0hQMrDMGv5UeU=
X-Received: by 2002:a05:6402:50c7:b0:5dc:a44d:36bd with SMTP id
 4fb4d7f45d1cf-5e0b70d5790mr7009054a12.8.1740269925014; Sat, 22 Feb 2025
 16:18:45 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sun, 23 Feb 2025 00:18:44 +0000
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <87tt909w1u.fsf@HIDDEN>
References: <86sep8y7iw.fsf@HIDDEN>
 <vlzgulkvp6hok6xipvpnwexbs5zhawsucphxdfk4p5obqbhlml@kdsbelm6u72u>
 <zzncrjvcfdp4g27k77xyva2mjy4s75iowf52jss57vianohdap@6rgszjwtgi2q>
 <87tt9m95hy.fsf@HIDDEN>
 <whcg5olmy43oygl5jcjklgdiqxaih5ql2qf2sk4nej2ilpo6oj@slx7vkyud3jm>
 <87y0ywulnm.fsf@HIDDEN>
 <4cazxxxaihei5aswrs7xwy3drgwsqt4faa4phn7ydnwzsodkpr@di6usnoc7axv>
 <87sep2950w.fsf@HIDDEN>
 <xqpehs3emkudayauh533bk3kob5b235mzee3nvzm5nnfl2jdym@iijed6mnjazs>
 <87wme3wlyu.fsf@HIDDEN>
 <gtlziq5wtmfxo7b2p5ib63dusyvkykru2cdiiknkcomnagyynf@kft6yia6sjx2>
 <87tt909w1u.fsf@HIDDEN>
MIME-Version: 1.0
Date: Sun, 23 Feb 2025 00:18:44 +0000
X-Gm-Features: AWEUYZnDb56OEbYLvfVlI0gKZQiXAf_MDRK6krtFFLXLbYM5F-KD9eZADtk_TKM
Message-ID: <CADwFkmniD8tjbE-EbT-HLZps_D1L4WsaUbgA2K70VgVCnAUn3w@HIDDEN>
Subject: Re: bug#75841: [PATCH] [UPDATE4] Fix mouse click on flymake
To: Juri Linkov <juri@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 75841
Cc: 75841 <at> debbugs.gnu.org, sbaugh@HIDDEN, Ergus <spacibba@HIDDEN>,
 eliz@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

Juri Linkov <juri@HIDDEN> writes:

>>>> This version also fixes what I consider an issue which is moving the
>>>> cursor to the mouse click in the cases where there is not diagnostic
>>>> (and no action is expected to take place.)
>>>
>>>Is this patch ready to push?
>>
>> I think so. I haven't detected any new issue.
>>
>>>Can we push it now?  I have more issues with flymake indicators to
>>>report, not related to this patch.
>>
>> If you could add a couple of lines in NEWS and check the dockstrings it
>> is very welcome.
>
> Sorry, still not pushed.  Whereas I could write a couple of lines in NEWS,
> also we need the ChangeLog message that is much longer.

Ergus, could you please resend the patch as an attachment as formatted
by

    git format-patch -1

and preferably also with a ChangeLog message as per CONTRIBUTE?

Thanks in advance.

Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75841; Package emacs. Full text available.

Message received at 75841 <at> debbugs.gnu.org:

Received: (at 75841) by debbugs.gnu.org; 11 Feb 2025 18:28:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 11 13:28:13 2025
Received: from localhost ([127.0.0.1]:58560 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1thuzU-0000vO-S7
	for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 13:28:13 -0500
Received: from relay8-d.mail.gandi.net ([217.70.183.201]:56203)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1thuzS-0000v9-GJ
 for 75841 <at> debbugs.gnu.org; Tue, 11 Feb 2025 13:28:10 -0500
Received: by mail.gandi.net (Postfix) with ESMTPSA id 0EFBD4342A;
 Tue, 11 Feb 2025 18:27:59 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Ergus <spacibba@HIDDEN>
Subject: Re: bug#75841: [PATCH] [UPDATE4] Fix mouse click on flymake
In-Reply-To: <gtlziq5wtmfxo7b2p5ib63dusyvkykru2cdiiknkcomnagyynf@kft6yia6sjx2>
Organization: LINKOV.NET
References: <86sep8y7iw.fsf@HIDDEN>
 <vlzgulkvp6hok6xipvpnwexbs5zhawsucphxdfk4p5obqbhlml@kdsbelm6u72u>
 <zzncrjvcfdp4g27k77xyva2mjy4s75iowf52jss57vianohdap@6rgszjwtgi2q>
 <87tt9m95hy.fsf@HIDDEN>
 <whcg5olmy43oygl5jcjklgdiqxaih5ql2qf2sk4nej2ilpo6oj@slx7vkyud3jm>
 <87y0ywulnm.fsf@HIDDEN>
 <4cazxxxaihei5aswrs7xwy3drgwsqt4faa4phn7ydnwzsodkpr@di6usnoc7axv>
 <87sep2950w.fsf@HIDDEN>
 <xqpehs3emkudayauh533bk3kob5b235mzee3nvzm5nnfl2jdym@iijed6mnjazs>
 <87wme3wlyu.fsf@HIDDEN>
 <gtlziq5wtmfxo7b2p5ib63dusyvkykru2cdiiknkcomnagyynf@kft6yia6sjx2>
Date: Tue, 11 Feb 2025 20:20:09 +0200
Message-ID: <87tt909w1u.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-State: clean
X-GND-Score: 0
X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdegudejvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrdelkedrheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeluddruddvledrleekrdehpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepgedprhgtphhtthhopeejheekgeduseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepshgsrghughhhsehjrghnvghsthhrvggvthdrtghomhdprhgtphhtthhopehsphgrtghisggsrgesrgholhdrtghomh
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 75841
Cc: sbaugh@HIDDEN, eliz@HIDDEN, 75841 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

>>> This version also fixes what I consider an issue which is moving the
>>> cursor to the mouse click in the cases where there is not diagnostic
>>> (and no action is expected to take place.)
>>
>>Is this patch ready to push?
>
> I think so. I haven't detected any new issue.
>
>>Can we push it now?  I have more issues with flymake indicators to
>>report, not related to this patch.
>
> If you could add a couple of lines in NEWS and check the dockstrings it
> is very welcome.

Sorry, still not pushed.  Whereas I could write a couple of lines in NEWS,
also we need the ChangeLog message that is much longer.

Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75841; Package emacs. Full text available.

Message received at 75841 <at> debbugs.gnu.org:

Received: (at 75841) by debbugs.gnu.org; 10 Feb 2025 15:46:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 10 10:46:43 2025
Received: from localhost ([127.0.0.1]:52041 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1thVze-00076s-O8
	for submit <at> debbugs.gnu.org; Mon, 10 Feb 2025 10:46:42 -0500
Received: from sonic315-13.consmr.mail.bf2.yahoo.com ([74.6.134.123]:42467)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <spacibba@HIDDEN>) id 1thVzb-00076W-Sd
 for 75841 <at> debbugs.gnu.org; Mon, 10 Feb 2025 10:46:40 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048;
 t=1739202393; bh=OpGKQ3CqjbIl33r+qaF/eNmsHeXVwOrvjAQYWPn7Y64=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To;
 b=UzPOQVoK06LiNJX3UfI/K95I20BT73FhWqwnMmI/zzGdxnUVhEQrbs9hCiIKogf9zOHkEWi/Me/XKbocQ+YHZhKO1oWcGoKTE7Kl/hRHKcLuHK5SkrhDLhRuqe2waYMJ58wGJRGiH+lHYwanRloMZbfkq9woT+RyrjljwQtTIK0t+i2DhW7LX1f9U1KWlndOZlYZUzcgMCLA1T3YinoBwBsALMCjtcsZguSb+f/nEJ+YoXKigCDVPPewK/RlzfjzxUmkaQZ4xmogogbrnnetqBol5ff9G08v92JYndSlC807j6suyrPVE/kqXhgcJ7GiDulgO61D3fI5ar/SJ0NtHw==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
 t=1739202393; bh=LBGBvq8/MuvUq5P3z35oW5bvUc4nvCjUlnaNNRGbMSA=;
 h=X-Sonic-MF:Date:From:To:Subject:From:Subject;
 b=ThWerhFlWT0wpP9ljuOTm624CF9qJsG/KjwjUhliVecgHl04bCUJp0Lr2+d8fUoOEovuaim1laumZA5/2RLWLDIRcsYdeb+L83ct7cYhHU8Q2HLX2rVQ8n42zE+dFlqFo5qXCJ/gLLC9L6o83g6Fd7P+vPHu7ndABrON4Skr2K1XsRK2XO1a5m8lhp+PJhQaNumBEmnqirqw21ZmqFa6L2HdvdAvrxBn94f1U3huaDzJQXeWjdJt9Tqz5s4CyTt86vTB7oZtSJ6cXlwL+UJnmrQ9BvPjAkn0qoChN2QI9T4AW5HxvQG9qyfQuvNl/C9qrk8co7XnM6DQ7+kAJFhJew==
X-YMail-OSG: ZFwpKokVM1mHIclp1g5P2Q5wpK59v16EhIfn1B3NvzG2DXkecagHMCC1UxLEaS8
 V3keNsuaOxQ9XhbjD8fWPb2PgLEQ0F7twVdfOeg6voQ2oumEG487YgBLNUTJ4die5BBxOcDHwmzD
 My36HLAGckhCEdnb.A4tCVgN6PTNjH_gyduns.PqgCUTqeJVXY3pYMQ3CspgDkUblrXj5g6fc7SO
 PDfQrOdDc0pHdf2GlvnnGXTIDKawCGn9X3rrKw0xp0.56K0Z8tDDlUOwXEAxNj72TTMMU7SQs2ov
 d9KZFWxbAc7THxZsWyIxC7ILRXjs_Ohn4mud12OSP.tICvka8tj0ymRvb2R53KNj7jLnCKtZxnWy
 3g.QEX4pxl0C8ZjLJsm5OqsODn2k5y_me9fOcN_GbHK6ISUtvSkEYhll52clCm9TVdHQuwsbkS73
 0Rf4ABk.Q_wE.OA5HcVRKWkSELuJndcH7GJQ360j66Yh24r2wcVSJrCVD36V9QzH4xApkUXFvJWc
 TYgBYTtwFaX4VnYaNnC.94HgMpWZ40BultgUjRd9.jRZS761tJy6uvPviQXyxB8RYTyD63YoXBfs
 NjgLjEjczfgHWvcK1jUYFiiEajjzybIBQZ8vZ.ynL5Rge9SUKPcPLhB6aeL._4.1Sh_InF2V_qkR
 kVYe.EmHSM_Roh5hkrq24MLHPrWwS6wTFQwTfCFqhJTi.qK8E8AOxUNNGBEEDD.cQJe88vGO0saL
 7aGhitxLDgYD.zVIkHWt.cLl_5sRKlp41S0iEKBM489Z.Fp7aJL_wgbxBEx2zG7ynElOizK8YIEd
 WqHb1iregZtcFXw4VkI_9d9c0eVKZFr4Hd4eXHquN27.GdPElQN2RtEibGUpVy1MdeI7a2awPBfE
 AQ0d0Ny.x4pNfL_uB2b6sYdETZs8fYv4VmL1m79ltHawO81jfG2ZZ9zmTJkuRvSqMDvUc_PRzlWU
 xx.K_ekw92NSxh2StU8S.fKm.wvVVMhTDz46M8gcaIww4ib_4AnaKR1rRHYIc1Qm4NYS45UE6Odf
 egSsfcQn595BIrz0DqqSFqhF26gsiRXXAvT_7VSrf6CvQ8f.FN5S3_sdh31IKOHacly7HpIkgcww
 XdxgbVA11cvlCRTQ6tP.xeJSHvEv8i_5xZXLRcPv8QSacuWi_L.Nizic5Xs7tgIfFLjjCOdp93xK
 g5TYuXJGaKgQsQOjZj9bH_.QDJuKyhqjfhWzf9ts9.UfqZtAmH21TovLCD4I4aMZkzc1OCp3wT.l
 a_cx_EkBsuHwBdn0qa35XzEZlbhDiGOPnRWu16zzcVoi_8f8gkfg2L2ZyErJea8f0bEp7wQB.L94
 3PrGvtpSUZejnxhDqNR.ldqBPODNQ13FyOy_kLKgGk33NLfduhhbjC3bkuS0uKqTuoavyp0RMz5e
 CaYd875XrNDWeHfA_HDwBheEIKfWOuDVyw33aAQQe0sF4P_Q6c_4tMbafOA.ae1aL4pDRRTW.etk
 7Cgv6zPbL6vB3DcEIJ8_6lmdC2beYeDwLzT9vxYMwFRd5QLOw6JhH3WQwl.8rOGFDfnV5sLfgkL5
 Rl97u0qfyNTLNiQmV_IZWkFIXOZ2LYxnvCbly.ZHdkpPDPQk6ZZV_YHR9iVvwgyizBsfizOVEbWn
 I.QQtCiEU.7PNtSXdTDfestDOkNj6GPdjnT7BPZCS7qqs8ysDKqD_lhI5ISuF6QSrGdANx5mjwDF
 tqPTyDQeKGH9Fm8.u7c1R6zn640HZEtV0Cbk_iea.uifMKN1o4lVBlzEtwyiuAJEsKOgZreUNTZ4
 yNMX6uAm8BMDf7eEJiIh40m.6_EkTALT8UqfCpPvSujUm.d6EnMUav_pUZoMzHIXXCv6ir20lsmj
 ZTTnN18C0_cy9rIHXy49fOWrpYlOBbg7XgfE1P0giT02OdJ3GE3Y6u0urJaOV4YEJJlJcK4WHfpZ
 8uLUKT1AKglVZ6GAlVHkfeqC4s_SSJVHnEzR5AI7cCAdgfvv2r14eaHyH3ckG4_btepRo1NmRvM7
 5AGR9B1nHDQty54DSA2utWIH0WCzdRido.Q49ZHohrdNsKJv3DbpYUcFmi.txxlOCoxaiIyLg5qs
 ozmUMXP9K78x4IR.L6wn2OGctIkdaY_BjjEr2iko2aIQfd4qEpfaLdL3RDWFkoMNs34AAhxqqb3I
 9YDDMuzxrQaY8..YJry_2ER6HQJw.eH1sAMRH_24v8zI5D3.13LTfGc_aty13xuVEjqsISCmfokq
 Y2Q--
X-Sonic-MF: <spacibba@HIDDEN>
X-Sonic-ID: a5505d38-bcb1-4df4-8a5e-2677fead3c6e
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic315.consmr.mail.bf2.yahoo.com with HTTP; Mon, 10 Feb 2025 15:46:33 +0000
Received: by hermes--production-ir2-c694d79d9-qjs6q (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID c57faf722bcaf8d33244ee5099b4ff54; 
 Mon, 10 Feb 2025 15:46:32 +0000 (UTC)
Date: Mon, 10 Feb 2025 16:46:30 +0100
From: Ergus <spacibba@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
Subject: Re: bug#75841: [PATCH] [UPDATE4] Fix mouse click on flymake
Message-ID: <iop2jagykar3d6kotkw3jt6p3tuda2h4u6ultumnf4o3u3aeaf@smkfwi4urisv>
References: <86sep8y7iw.fsf@HIDDEN>
 <vlzgulkvp6hok6xipvpnwexbs5zhawsucphxdfk4p5obqbhlml@kdsbelm6u72u>
 <zzncrjvcfdp4g27k77xyva2mjy4s75iowf52jss57vianohdap@6rgszjwtgi2q>
 <87tt9m95hy.fsf@HIDDEN>
 <whcg5olmy43oygl5jcjklgdiqxaih5ql2qf2sk4nej2ilpo6oj@slx7vkyud3jm>
 <87y0ywulnm.fsf@HIDDEN>
 <4cazxxxaihei5aswrs7xwy3drgwsqt4faa4phn7ydnwzsodkpr@di6usnoc7axv>
 <87sep2950w.fsf@HIDDEN>
 <xqpehs3emkudayauh533bk3kob5b235mzee3nvzm5nnfl2jdym@iijed6mnjazs>
 <87wme3wlyu.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <87wme3wlyu.fsf@HIDDEN>
X-Mailer: WebService/1.1.23187
 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol
Content-Length: 426
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75841
Cc: sbaugh@HIDDEN, eliz@HIDDEN, 75841 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Juri:

Are you going to push this?

On Thu, Feb 06, 2025 at 09:50:33AM +0200, Juri Linkov wrote:
>> This version also fixes what I consider an issue which is moving the
>> cursor to the mouse click in the cases where there is not diagnostic
>> (and no action is expected to take place.)
>
>Is this patch ready to push?  Can we push it now?  I have more
>issues with flymake indicators to report, not related to this patch.

Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75841; Package emacs. Full text available.

Message received at 75841 <at> debbugs.gnu.org:

Received: (at 75841) by debbugs.gnu.org; 7 Feb 2025 12:55:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 07 07:55:26 2025
Received: from localhost ([127.0.0.1]:33363 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tgNtF-00027L-Mz
	for submit <at> debbugs.gnu.org; Fri, 07 Feb 2025 07:55:26 -0500
Received: from sonic305-2.consmr.mail.bf2.yahoo.com ([74.6.133.41]:40809)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <spacibba@HIDDEN>) id 1tgNtC-000274-1N
 for 75841 <at> debbugs.gnu.org; Fri, 07 Feb 2025 07:55:23 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048;
 t=1738932916; bh=wqxWH5icfKG0EMeoiApjDh8WNyto0Xcx1ww+X+Xj0V4=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To;
 b=QdwYUKtociViK7XZBaMO9Xqk8/GzZFARz+L7+VGmSUi7aPGYitidKsMt9m5NuD8qm82w9QNGC8q9iyQHEINZ+PwPblI4b7w/mpBJPK+NAtk34dl9ywbOdkwLHhV6wDeFvSpsiR2YGSqbpw48rwg0OI3aH5fxdlOmkoLgaWE/2tM6isO5K34KMSdRLwkBh6LLMx97Z5cLMYSwtSoTq8fv1OfL5NyHYkkky6zWr+0lnCndC2OsBgCnj11bRyFXm0t29EVuqIWipVCRYIGcB5vbjH1irqJBtplaW+Zzea4OxGU6QcawaabmNbym+fZgISLh6GfKgOE7C/Zzl7fYI0SuXg==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
 t=1738932916; bh=rAuTrtdLqG0dfadlP05+UdjW0O+LSBLy1Gz+naJrCSB=;
 h=X-Sonic-MF:Date:From:To:Subject:From:Subject;
 b=N0fT16ViX4lwrtVQsmwXL4DjeMu5MzBFvO3lBgbEu+hKSg4o6gFnOIuACGOhu6lket77Bkyr/aR+JjLWFJDKNLsGcaHgC65dMsJmgS568DN4z56NzOxWZwrS/r1mTr0lq6hdjYM+liWRVdyR93+u/o1TN7ZLXgmu2GKnUeTTBen6Vq8U7Y7JTBexTRlpnGauvmkh2qxA35rp9JR0Ve01uVCuGrEqRicLQXFmK15UND5OG+pLk1i1UbOJOdoXNjSVSKFkZHVyQnwlvqFwiiHOlonr9ubBJXCwrUQEtNIFctwiNi3HtzL8IKWWbKJBxadHH9ngd4L93YFAb44FXJfbYg==
X-YMail-OSG: 5.3cljIVM1n73uiTvnHYTPFnpCZdRGU5YnsFy84tf8OI0A0dVw7FPcZ8opjqCQs
 4EIAk9jgtpghLpS53Kf2QP30h1Z1oP1tydmdHkd6A4pLnxVcog8g2gRuQwheVBVTkI1WL.yiWepZ
 c3Qh_uzyke_9MYKY.v8ObKyWVSxDV18gpkFbLDU6RQ68JkaYYXNSD7n6JrG3AG42UyYWEI146MSh
 aUs0PAWjor8._2hreyG_KPjYaSuBaxBioF4tcdNRLGhV_3fC4Vn644.Y7.PK_MTKu4vP_h7RF26E
 DAtxGFN.WFCbCrjfhlsUASJixsAm5s3UXE7hJyJBhtlz_t6tbJHjP8CLBPJ92zJjUszbEUIFQ5oj
 Jl0YUNOD3onLlQTuYGhSVWoUZjxAXcQkK4KMuI6.hS2ufPikN76eMnAbPMNJ2iKZqqNcyM9np4OM
 f68RTJAYwhgFhX2xQZOxYTxS63RU9HnO1wNa4zEmPFcdSZlD8KDXXJY5ORlOECFVwQFHc2rLCq4.
 HJ1C5hti1y4Pp_DXLUl1weAWCFefcCWqzu76loYW8E8leWSHeCAzWWQAhmGcXBiXYiYeDpKWOIi7
 .zKN_kYsv0CPdAnyw9FXEC2Gtp_Ca5fNFh1LWt9wMI7Mce_yLGkJ0uxbazZYDaxq5moJhDuuCQky
 G2bx.NaHN3NnnUdPFMJDAocVZcgEpfyb4C1Cb8JI_vWf2lRenkzw2JcZKfZo0h9h9k_fmg.V4S9O
 NABQlkKBrhmWXM9uB_4BqUKJHAtQv9qURNiUhZj3yWNOjlJNxhuJBGuDeMeA6InMyTj__OLUCS7b
 Tz6Uf9HvnEfOy7ua.WOl70S84dkWsV.ALER4FYec6knawQix2rMfZe4WFH.WfrvTtqF.Wnwhn2rm
 VGPKW24uIf9kwGQvxLFYUWX_lEfAv2x2yMUGk9su0t3qWVdpauSqqVPCjr7uigVtFA7jqJwwMlDf
 nG7DPDO0AEyI_68y.qTECcpRlvpxHeZYI0F2Tx8vvZF2t628WWx.WfrKIWoKcbpoiSJdWxAzYSAC
 _ZHBO6lFeARLBPgP8tJLSnf820Bv1pXmmqC9t7b1Ti.FMlYG7zViWR6J.MGG1.ujznwBhd3WSeFN
 Q3ZnffeSaTzCLvTZMRugXvBYv556IYxWIFhEp78VNzcIwkay07O9_njSpq62CIu7haUvC0EF41Nx
 Ctnsf2FrEogu.xtIRKlEEP0KD0Ben60t68o7dRWDGTJBEB1M7FF0j4bhhKI..NUr8sr3IJ10JsOO
 vvwblyQNawF.MdhMRO8St5yceRTffTpzpMBUaK5yBDTfhlqX_iarq9oJ4jgRfxL83QfEmTmih1Xi
 jceGSj6nHZkT7DWZL9jWV_xkSbwNvoe5OqWTJ5WxWBmJrs7Ub_B28qMJSGGdigHpXjybk_U_JE0W
 sxvT1RcMQuhhJyG3HdY1crne668YIbhM34csjq77BTAhADqTmU4s5ZsgLuJY0jlnYY8_QEb13yfE
 UmJwlOWzFdldaCwryihpYk9IyvpA1UUK8iL4kspq7ORO.Lk.ToVCezs_p2vLE6A_XQ112uCDsPnI
 h51uzjiCMygVmHdK5bv5izpRhQaMsIiYSNEglhwh_yQG_83F80Rv9KmXIHkxrJPPCd3knjfk7ivR
 7npJsaAVh_L3mKLUG3f0NvrdlwW0pFBnvNekKO8I09UYJ8Kx_DdN8Yt7mhGk1p5Yns6LLpT2QW.B
 GJ4E6wYnW06un29D6840B5_B_2iBk8Rj.2oKZvPO758KRHgMyqaI3RkCQ9QrgKL1cd02FMfyRQMN
 TypNbb9CiteUg7.Y024R3Y_WvxtATdfT5IRjh_xnFn.nv9GF6pgvaKFvuzavxhnwRm5VOvquER7X
 kSKlOviV0AlI3AYHBHgpY53YH9V6tf.iiOgslhR23WuoRKhKJymtonk8BV3KHhaiG2veFhfl3Ri3
 VjlPEJeWtuGqpMFWS4DspWvTn.kLF8jnR1vOodKRTr0Egg1iwJfACuV3x67GG5f8p9aR5bKiPfsv
 iWwBy5lnDX6YJ5t0k8FqsTePwwZ5ETpx05OOAg2AqwhrUI7qQ0WkQM4UOvICEGk_um4eC1HLkCJX
 NXlwKW5oNfDjmfelOAoijkwsreXxAhBjx3Zt5JQdssE8JWswQ42OZ38gjtnyKl2g2bPkBNxw8Nr_
 CXwjrlptnvNaKfxlrum5UOSiGXewt6OJ8avuM40YuvLkjalRrLmNuSPdzgFPDVA9DGrMBYDaIkPD
 GcA--
X-Sonic-MF: <spacibba@HIDDEN>
X-Sonic-ID: ca9c4164-8b1e-4eed-bc48-fa642b3880b5
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic305.consmr.mail.bf2.yahoo.com with HTTP; Fri, 7 Feb 2025 12:55:16 +0000
Received: by hermes--production-ir2-c694d79d9-nbvqz (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID c1051dd97aac6288d29eb4cf962064ae; 
 Fri, 07 Feb 2025 12:55:13 +0000 (UTC)
Date: Fri, 7 Feb 2025 13:55:11 +0100
From: Ergus <spacibba@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
Subject: Re: bug#75841: [PATCH] [UPDATE4] Fix mouse click on flymake
Message-ID: <gtlziq5wtmfxo7b2p5ib63dusyvkykru2cdiiknkcomnagyynf@kft6yia6sjx2>
References: <86sep8y7iw.fsf@HIDDEN>
 <vlzgulkvp6hok6xipvpnwexbs5zhawsucphxdfk4p5obqbhlml@kdsbelm6u72u>
 <zzncrjvcfdp4g27k77xyva2mjy4s75iowf52jss57vianohdap@6rgszjwtgi2q>
 <87tt9m95hy.fsf@HIDDEN>
 <whcg5olmy43oygl5jcjklgdiqxaih5ql2qf2sk4nej2ilpo6oj@slx7vkyud3jm>
 <87y0ywulnm.fsf@HIDDEN>
 <4cazxxxaihei5aswrs7xwy3drgwsqt4faa4phn7ydnwzsodkpr@di6usnoc7axv>
 <87sep2950w.fsf@HIDDEN>
 <xqpehs3emkudayauh533bk3kob5b235mzee3nvzm5nnfl2jdym@iijed6mnjazs>
 <87wme3wlyu.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <87wme3wlyu.fsf@HIDDEN>
X-Mailer: WebService/1.1.23187
 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol
Content-Length: 538
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75841
Cc: sbaugh@HIDDEN, eliz@HIDDEN, 75841 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Thu, Feb 06, 2025 at 09:50:33AM +0200, Juri Linkov wrote:
>> This version also fixes what I consider an issue which is moving the
>> cursor to the mouse click in the cases where there is not diagnostic
>> (and no action is expected to take place.)
>
>Is this patch ready to push?

I think so. I haven't detected any new issue.

>Can we push it now?  I have more issues with flymake indicators to
>report, not related to this patch.

If you could add a couple of lines in NEWS and check the dockstrings it
is very welcome.

Best,
Ergus

Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75841; Package emacs. Full text available.

Message received at 75841 <at> debbugs.gnu.org:

Received: (at 75841) by debbugs.gnu.org; 6 Feb 2025 07:52:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 06 02:52:10 2025
Received: from localhost ([127.0.0.1]:54131 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tfwgE-0001j2-2b
	for submit <at> debbugs.gnu.org; Thu, 06 Feb 2025 02:52:10 -0500
Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]:55537)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1tfwgB-0001iQ-9N
 for 75841 <at> debbugs.gnu.org; Thu, 06 Feb 2025 02:52:08 -0500
Received: by mail.gandi.net (Postfix) with ESMTPSA id 789FC44467;
 Thu,  6 Feb 2025 07:51:58 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Ergus <spacibba@HIDDEN>
Subject: Re: bug#75841: [PATCH] [UPDATE4] Fix mouse click on flymake
In-Reply-To: <xqpehs3emkudayauh533bk3kob5b235mzee3nvzm5nnfl2jdym@iijed6mnjazs>
Organization: LINKOV.NET
References: <86ed0t23l9.fsf@HIDDEN>
 <cghqipziqfestwlqma6khqomrzvgw3kc4v3wgdko254o53wy5p@rniq2y7cm7jh>
 <86sep8y7iw.fsf@HIDDEN>
 <vlzgulkvp6hok6xipvpnwexbs5zhawsucphxdfk4p5obqbhlml@kdsbelm6u72u>
 <zzncrjvcfdp4g27k77xyva2mjy4s75iowf52jss57vianohdap@6rgszjwtgi2q>
 <87tt9m95hy.fsf@HIDDEN>
 <whcg5olmy43oygl5jcjklgdiqxaih5ql2qf2sk4nej2ilpo6oj@slx7vkyud3jm>
 <87y0ywulnm.fsf@HIDDEN>
 <4cazxxxaihei5aswrs7xwy3drgwsqt4faa4phn7ydnwzsodkpr@di6usnoc7axv>
 <87sep2950w.fsf@HIDDEN>
 <xqpehs3emkudayauh533bk3kob5b235mzee3nvzm5nnfl2jdym@iijed6mnjazs>
Date: Thu, 06 Feb 2025 09:50:33 +0200
Message-ID: <87wme3wlyu.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-State: clean
X-GND-Score: 0
X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvheekfecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrdeliedrledtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrdeliedrledtpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepgedprhgtphhtthhopeejheekgeduseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepshgsrghughhhsehjrghnvghsthhrvggvthdrtghomhdprhgtphhtthhopehsphgrtghisggsrgesrgholhdrtghomh
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 75841
Cc: sbaugh@HIDDEN, eliz@HIDDEN, 75841 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

> This version also fixes what I consider an issue which is moving the
> cursor to the mouse click in the cases where there is not diagnostic
> (and no action is expected to take place.)

Is this patch ready to push?  Can we push it now?  I have more
issues with flymake indicators to report, not related to this patch.

Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75841; Package emacs. Full text available.

Message received at 75841 <at> debbugs.gnu.org:

Received: (at 75841) by debbugs.gnu.org; 29 Jan 2025 07:51:07 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 29 02:51:07 2025
Received: from localhost ([127.0.0.1]:39777 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1td2qo-0005rK-QI
	for submit <at> debbugs.gnu.org; Wed, 29 Jan 2025 02:51:07 -0500
Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]:44375)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1td2qh-0005qL-DL
 for 75841 <at> debbugs.gnu.org; Wed, 29 Jan 2025 02:50:59 -0500
Received: by mail.gandi.net (Postfix) with ESMTPSA id 4AF8C201D1;
 Wed, 29 Jan 2025 07:50:52 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Ergus <spacibba@HIDDEN>
Subject: Re: bug#75841: [PATCH] [UPDATE4] Fix mouse click on flymake
In-Reply-To: <xqpehs3emkudayauh533bk3kob5b235mzee3nvzm5nnfl2jdym@iijed6mnjazs>
 (Ergus's message of "Tue, 28 Jan 2025 23:04:12 +0100")
Organization: LINKOV.NET
References: <86ed0t23l9.fsf@HIDDEN>
 <cghqipziqfestwlqma6khqomrzvgw3kc4v3wgdko254o53wy5p@rniq2y7cm7jh>
 <86sep8y7iw.fsf@HIDDEN>
 <vlzgulkvp6hok6xipvpnwexbs5zhawsucphxdfk4p5obqbhlml@kdsbelm6u72u>
 <zzncrjvcfdp4g27k77xyva2mjy4s75iowf52jss57vianohdap@6rgszjwtgi2q>
 <87tt9m95hy.fsf@HIDDEN>
 <whcg5olmy43oygl5jcjklgdiqxaih5ql2qf2sk4nej2ilpo6oj@slx7vkyud3jm>
 <87y0ywulnm.fsf@HIDDEN>
 <4cazxxxaihei5aswrs7xwy3drgwsqt4faa4phn7ydnwzsodkpr@di6usnoc7axv>
 <87sep2950w.fsf@HIDDEN>
 <xqpehs3emkudayauh533bk3kob5b235mzee3nvzm5nnfl2jdym@iijed6mnjazs>
Date: Wed, 29 Jan 2025 09:48:01 +0200
Message-ID: <87o6zqawni.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-State: clean
X-GND-Score: 0
X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvgeegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecunecujfgurhephffvvefujghofhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecuggftrfgrthhtvghrnhepffegteefveelhfeljeefueehieduiedtfffhuddtkeeffffghfevheetgeeukeehnecukfhppeeluddruddvledrleeirdeltdenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepihhnvghtpeeluddruddvledrleeirdeltddphhgvlhhopehmrghilhdrghgrnhguihdrnhgvthdpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnsggprhgtphhtthhopeegpdhrtghpthhtohepjeehkeegudesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphhtthhopehssggruhhghhesjhgrnhgvshhtrhgvvghtrdgtohhmpdhrtghpthhtohepshhprggtihgssggrsegrohhlrdgtohhm
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 75841
Cc: sbaugh@HIDDEN, eliz@HIDDEN, 75841 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

> Please try it now.
>
> This version also fixes what I consider an issue which is moving the
> cursor to the mouse click in the cases where there is not diagnostic
> (and no action is expected to take place.)

Thanks, I have tried it, and everything work nicely.

Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75841; Package emacs. Full text available.

Message received at 75841 <at> debbugs.gnu.org:

Received: (at 75841) by debbugs.gnu.org; 28 Jan 2025 22:04:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 28 17:04:27 2025
Received: from localhost ([127.0.0.1]:38977 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tcth4-0003qh-Q4
	for submit <at> debbugs.gnu.org; Tue, 28 Jan 2025 17:04:27 -0500
Received: from sonic316-12.consmr.mail.bf2.yahoo.com ([74.6.130.122]:41819)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <spacibba@HIDDEN>) id 1tcth2-0003qQ-DG
 for 75841 <at> debbugs.gnu.org; Tue, 28 Jan 2025 17:04:25 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048;
 t=1738101858; bh=M66/T01mrxLGTvUuPLzJRBQcpWwzCtdurLxgrbRFx8I=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To;
 b=LamZD4WnrDWCoy+h3zauWvZhZ9upg6qTOPvePm5uU7OdU2UwZZhSimfgYENpa4l469vw7EZERjVkZ2/pxqIL1Fayuw8yJxFZPWusDWhjiFwPv/db/MDdabf6jH5xo89mccY7qb3ZOHhaWwNEZIk85cirbovNLfgI5ShXuiaVc4hx7j1MfzgeFCq6Jh5/6LPzUP/bySbyaSDoyvIkNHcDr7sadEv7ZVi5kG6j7qw4d0rFZKmUcQlF/puVNAaNMavdelhogvtvII8qJfbePuB1Ca20IrhQSzunin+xXLukQO4VPnYPQa/1PyUCCyIPd9FxO8/bOR8Ldwhess4YKAWfvA==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
 t=1738101858; bh=LI8EFVjZkcLBipmxguOf1lZqBnFbvE4yuNeSTqrp7jf=;
 h=X-Sonic-MF:Date:From:To:Subject:From:Subject;
 b=qlvztY1NZFwgQtgLuARKLfJIRIeHsJJPYrfA7yIYu3hHQUXaM5/2MQ3n9HooOqALk1yyRjF2QGxWD1XrgVqq2F76gwxnhtjUDeatGtcw1pxzbCFI9R8i0RTHIdHcRpeuzKZa30bh81MC+0I49HZRxRKYJztZ9fGzmDCFymBVthJWdtekEwf4izjbmUeoeh7sZq6UmQJ57/xd4oyPBFyveqcwV8GHGENnVZ8RRFHLthipF4YimsxvYEb9qs8pzA0LXjybAsVPCHOdZrG9xoU/3hZtqD4tWciOFzNZNMQF4lEWrBVGP44AwuV2TnUavtWacoBqkcmPljv20cERvInx7Q==
X-YMail-OSG: LkhDABMVM1n7T1k_LSQObu4DvyNWB9XXrr.Ly_dBAEnsPNa9C7o0Q7XvmUMavqf
 d.pfijjSHI2pOo.n.NCMeDEmtWI41JnFvJO5Wz_GITeRAihndPtGQKALhohRW2aoIR_ONrTWeWl3
 GsouOd5N7biKm0L2rELy3018EnJoExSZshArHfdLy52ttpTYGmy4DlLrUSnI2eOIkHe1JPZlwE7X
 MseSNL2YUb.p6ICPW.FlX18QkFuA.xyWrKkL8LPD9HXiUhtx.rQ7TXuF_GL5oN0Tve77sbieA2oX
 0BxWu72n8brVlcYfB9KnKV0cfFTKM0tc2wNFpxdkWjigSTvNCGLUMaApyxUCqCjKX49IjhCp8mSK
 EnsaWvjWzHBwM3qarS1Va03KoSzJsGm8WNU5KcjUQ2IGNf8gUlzQfQRW6mB_JGnJYFgBXEBqANAe
 DzEkhzXRiWw4_iPAQXtRqWIJjCvLbUtxLt9J0uAMsOXbvw_xI91xLQEvfGDtGZov3A.uGeVoWHan
 eW5_bXHSb5F0blTeOZ35HUJtSJrjZDiUhALYkd9rKBMvCzBthd4fD4Yz3eW9zYp2Q4JtDUOIcy06
 tVxsmMPaxLtCPS863bq6hkfVOdGzAX1SvPAx73CragHYdMK9NW_SU6IJ3Uvvr.enPFnLoOWfZq1N
 jM8lB2rfLt5yDVaizwj8AKpUnYDvoDcAyiIkaVIlAhwHc6zIUXlwqZW7DGtMhdUOfdfuaguEWCy8
 jvPOSIeJRRRJH0rMVBapwoNjotImFeIt98l0prKba4DdUbU82CzGyKtS8S7WFmSyTa7cPe.RfM9I
 kqJ.PQ2.pHYkY2CmhhXIYJBIiP1nAJRc.tRyn77O0EPxp_LZ.iwperFa8CdzMsEztqRB8NOL.iZG
 lJaWkbAXPxTqWDkrbzYR5O0R2UlMMFenXUZd2tBnNtM51MptIY31K4rV.xwiX9arKcgAl9ozKYci
 ZC5FUvnZIgofdK9zRKqws.nsEy3cXw2.__quA5N.W8pEoz7Eio0d38PG6jk4fDsWBuqmAz6Oi9r5
 sYiILYyq7tUawWGadoOKUoIYDfOp_qggKzdcq394Vh5CouWd4ZBlhcMZxo.xMDFna3vhvDkZ94uG
 4.S2rfhP3P1m_Pykh9_lZss8ACY6tX.4yOn_O1xVP8E3AKGs39F1Q7C8PcbCaenK7XItctXe7WHl
 W5VxqHdft5pa2LhYFMyRBoprI7CznTVb206ij0SihO4rOF89S.n7P4EOMG7RDgd92v0Gtj6Vn1wy
 EwauccnraATrUCiOOIn07mRKpsUCd4MBwnnLw_LZvWrqFJtoMHOgLlw3gkT.se5a3dPZ.uTb1CXi
 lsrs_TTGXTnGKvUU8Av5yF0DtMVBae2Y1b9DK3ZRLR2qz30MJAAgwHEgejjkjzHHggYUy.1AgB8.
 6JsERDnHt1IUvNpJDyOiA6891UcwgwrsebUXx_tbF80UB3p5bmFp86Z1vtKFFTwlvbACQdirUifd
 t9VVXpCmNuR0TUj09KfEtqMntW2JzoKFchyi1oF6SPQMPGQujvkDGzPdJECc9J8VVi.2mOUHlWYO
 UwreqptzM9ZLA97MiVu1mbGhYtzdcu3B3HkklU4h_A.AbjiXHNwJGVCnUcIGfxBdhvj7z.4P8Vlp
 0bDM56oIKdy3UdOnkQSv.5Mp8_yl_WjOLX4FyQIrz377kWPPB136GWeynWybaLsmPlo0yhXK2AbJ
 sxIv0VyBFXSiL.5QH3_MZMaI46fxEXTIj9y7Dto5on2nC7V2.PGiij7Ev1R1yPWx1hNH2SfY8NHj
 rooR9ThnLck_l1Hlzaev.dM7eXUJSoMoC34acfO.MdSVrx54d6PB0M_U1nZ2H15ks_okifPuD8_8
 tI_9QJZUuZXPXIHPwZpr.Pq3gl8ReUic4AMyohYwhwUG6X1M66tey8Zsz9xr0C01dWwIxgqYy3mh
 IOw5HlYvc94LPtZWbQBQKJJKDzWej4Hzv9YSsVOUzbKoPSRuoAY_OWf5PMYKi_SahvYqzYYeZQI8
 0XeVMxn_nOAPPVvt_x61SwivOTybovR4ZOxpyEOXsocOQ8mMEqhijoqXwqi5LwqakQdhmv5chdx_
 Diuh6RsB5AS0wD7YuNFTvmMtjSIez3EjwCch9Tg9fRRhKTssJsEokRJ00mrFjg2YEHDWh3spcHyZ
 VRqd5WH1CnDg39rACPeCZmF1Go2AHDv99SEOzblQTslgwF3KOKXICknqQDX7x85b6ZAVLrp7Zkvt
 6TKiNyYsg
X-Sonic-MF: <spacibba@HIDDEN>
X-Sonic-ID: 1542a1dc-6a05-44e1-ad4e-650ecc66592b
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic316.consmr.mail.bf2.yahoo.com with HTTP; Tue, 28 Jan 2025 22:04:18 +0000
Received: by hermes--production-ir2-c694d79d9-2zgj2 (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID cdc3f2a8b9d1aa6d1a834abcb25206e1; 
 Tue, 28 Jan 2025 22:04:14 +0000 (UTC)
Date: Tue, 28 Jan 2025 23:04:12 +0100
From: Ergus <spacibba@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
Subject: Re: bug#75841: [PATCH] [UPDATE4] Fix mouse click on flymake
Message-ID: <xqpehs3emkudayauh533bk3kob5b235mzee3nvzm5nnfl2jdym@iijed6mnjazs>
References: <86ed0t23l9.fsf@HIDDEN>
 <cghqipziqfestwlqma6khqomrzvgw3kc4v3wgdko254o53wy5p@rniq2y7cm7jh>
 <86sep8y7iw.fsf@HIDDEN>
 <vlzgulkvp6hok6xipvpnwexbs5zhawsucphxdfk4p5obqbhlml@kdsbelm6u72u>
 <zzncrjvcfdp4g27k77xyva2mjy4s75iowf52jss57vianohdap@6rgszjwtgi2q>
 <87tt9m95hy.fsf@HIDDEN>
 <whcg5olmy43oygl5jcjklgdiqxaih5ql2qf2sk4nej2ilpo6oj@slx7vkyud3jm>
 <87y0ywulnm.fsf@HIDDEN>
 <4cazxxxaihei5aswrs7xwy3drgwsqt4faa4phn7ydnwzsodkpr@di6usnoc7axv>
 <87sep2950w.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="piplhkfwybxosyx6"
Content-Disposition: inline
In-Reply-To: <87sep2950w.fsf@HIDDEN>
X-Mailer: WebService/1.1.23187
 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol
Content-Length: 13421
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 75841
Cc: sbaugh@HIDDEN, eliz@HIDDEN, 75841 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--piplhkfwybxosyx6
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline

Hi Juri:

Please try it now.

This version also fixes what I consider an issue which is moving the
cursor to the mouse click in the cases where there is not diagnostic
(and no action is expected to take place.)

Best,
Ergus

On Tue, Jan 28, 2025 at 08:17:51PM +0200, Juri Linkov wrote:
>>>> +(defvar-keymap flymake-mode-map
>>>> +               :doc "Keymap for `flymake-mode'."
>>>> +               (format "<%s> <mouse-1>" flymake-fringe-indicator-position)
>>>> +               #'flymake-show-buffer-diagnostics-at-event-line)
>>>
>>>This dependency on 'flymake-fringe-indicator-position' can break
>>>in the case when the user customizes the value
>>>of 'flymake-fringe-indicator-position' to 'right-fringe'.
>>>Then clicking will fail with "<right-fringe> <mouse-1> is undefined".
>>>
>> This works the same way. The previous code didn't support dynamically
>> change the flymake-fringe-indicator-position. We can try to solve it,
>> but we go back to the same issue tan in my first patch. We cannot change
>> the map.
>
>Do you see a problem with binding both initially:
>'left-fringe' and 'right-fringe'?
>
>>>> +      (with-selected-window (posn-window posn)
>>>> +	(with-current-buffer (window-buffer)
>>>> +	  (goto-char pos)
>>>> +          (if full-line
>>>> +              (flymake-diagnostics (line-beginning-position) (line-end-position))
>>>> +            (flymake-diagnostics pos (1+ pos))))))))
>>>
>>>I don't know if '(with-selected-window (posn-window posn)' was intended
>>>to handle this case, but clicking on the fringe still raises the error
>>>"Flymake mode is not enabled in the current buffer" when clicking
>>>from the diagnostics buffer.
>>>
>> I haven't seen this, please tell me how to reproduce it.
>
>The previous code didn't support this case, so no need to handle this.
>I just thought why with-selected-window can't handle the case
>when the selected window was the diagnostics buffer, and then
>can't click the fringe in the source buffer.
>
>>>> +(defcustom flymake-after-jump-hook '(pulse-momentary-highlight-one-line)
>>>> +  "Hook called after jumping to a diagnostic line.
>>>> +
>>>> +This hooks are called when `flymake-show-buffer-diagnostics' receives an
>>>> +the optional `diagnostic' argument and it matches an entry in the
>>>> +diagnostic's buffer."
>>>> +  :type 'hook
>>>> +  :version "31.0")
>>>
>>>Please note that this is not direct equivalent to xref-after-jump-hook.
>>>xref-after-jump-hook is more like flymake-show-diagnostic and
>>>flymake-goto-diagnostic that jumps from the diagnostic buffer to the
>>>source buffer.  But this hook is about showing the diagnostic buffer.
>>>So a less ambiguous name would be 'flymake-after-show-buffer-diagnostics-hook'.
>>>
>>>Then 'pulse-momentary-highlight-one-line' works nicely.
>>>For consistency it could use the same face 'highlight'
>>>as 'pulse-momentary-highlight-region' in 'flymake-show-diagnostic'.
>>
>> I will include these in the next patch. When I fix the
>> with-selected-window issue you mention before.
>
>Thanks.

--piplhkfwybxosyx6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename="flymake-indicator-margin-click_v4.patch"

diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index 9dda53713f5..6141fd46c6e 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -748,34 +748,41 @@ flymake--severity
   (flymake--lookup-type-property type 'severity
                                  (warning-numeric-level :error)))
 
-(defun flymake--indicator-overlay-spec (indicator)
+(defun flymake--indicator-overlay-spec (type)
   "Return INDICATOR as propertized string to use in error indicators."
-  (let* ((value (if (symbolp indicator)
+  (let* ((indicator (flymake--lookup-type-property
+                     type
+                     (cond ((eq flymake-indicator-type 'fringes)
+                            'flymake-bitmap)
+                           ((eq flymake-indicator-type 'margins)
+                            'flymake-margin-string))
+                     (alist-get 'bitmap (alist-get type ; backward compat
+                                                   flymake-diagnostic-types-alist))))
+         (value (if (symbolp indicator)
                     (symbol-value indicator)
                   indicator))
-         (indicator-car (if (listp value)
-                            (car value)
-                          value))
-         (indicator-cdr (if (listp value)
-                            (cdr value))))
+         (valuelist (if (listp value)
+                        value
+                      (list value)))
+         (indicator-car (car valuelist)))
+
     (cond
      ((and (symbolp indicator-car)
            flymake-fringe-indicator-position)
       (propertize "!" 'display
-                  (cons flymake-fringe-indicator-position
-                        (if (listp value)
-                            value
-                          (list value)))))
+                  (cons flymake-fringe-indicator-position valuelist)))
      ((and (stringp indicator-car)
            flymake-margin-indicator-position)
       (propertize "!"
                   'display
                   `((margin ,flymake-margin-indicator-position)
-                    ,(propertize
-                      indicator-car
-                      'face
-                      `(:inherit (,indicator-cdr
-                                  default)))))))))
+                    ,(propertize indicator-car
+                                 'face `(:inherit (,(cdr valuelist) default))
+                                 'mouse-face 'highlight
+                                 'help-echo "Open Flymake diagnostics"
+                                 'keymap `,(define-keymap
+                                             (format "<%s> <mouse-1>" flymake-margin-indicator-position)
+                                             #'flymake-show-buffer-diagnostics-at-event-line))))))))
 
 (defun flymake--resize-margins (&optional orig-width)
   "Resize current window margins according to `flymake-margin-indicator-position'.
@@ -941,16 +948,7 @@ flymake--highlight-line
                   (overlay-put ov prop (flymake--lookup-type-property
                                         type prop value)))))
       (default-maybe 'face 'flymake-error)
-      (default-maybe 'before-string
-        (flymake--indicator-overlay-spec
-         (flymake--lookup-type-property
-          type
-          (cond ((eq flymake-indicator-type 'fringes)
-                 'flymake-bitmap)
-                ((eq flymake-indicator-type 'margins)
-                 'flymake-margin-string))
-          (alist-get 'bitmap (alist-get type ; backward compat
-                                        flymake-diagnostic-types-alist)))))
+      (default-maybe 'before-string (flymake--indicator-overlay-spec type))
       ;; (default-maybe 'after-string
       ;;                (flymake--diag-text diagnostic))
       (default-maybe 'help-echo
@@ -1369,12 +1367,28 @@ flymake-start
                   nil)))
              (flymake--import-foreign-diagnostics))))))
 
-(defvar flymake-mode-map
-  (let ((map (make-sparse-keymap)))
-    (define-key map `[,flymake-fringe-indicator-position mouse-1]
-                #'flymake-show-buffer-diagnostics)
-    map)
-  "Keymap for `flymake-mode'.")
+(defun flymake-show-buffer-diagnostics-at-event-line (event)
+  "Show diagnostics buffer on mouse click in the margin or fringe.
+This uses two different approaches to work.
+For margin it is set as a char property of the margin character directly.
+While in the fringe it is set as part of the `flymake-mode-map'."
+  (interactive "e")
+  (when-let* ((diagnostics (flymake-diagnostics-at-mouse-event event t))
+              (first-diag (car diagnostics)))
+    (with-selected-window (posn-window (event-end event))
+      (with-current-buffer (window-buffer)
+        (when (or (< (point) (flymake-diagnostic-beg first-diag))
+                  (> (point) (flymake-diagnostic-end first-diag)))
+          (goto-char (flymake-diagnostic-beg first-diag)))
+
+        (flymake-show-buffer-diagnostics first-diag)))))
+
+;; Set the fringe mouse-1 action directly and perform the filtering
+;; latter iterating over the overlays.
+(defvar-keymap flymake-mode-map
+               :doc "Keymap for `flymake-mode'."
+               (format "<%s> <mouse-1>" flymake-fringe-indicator-position)
+               #'flymake-show-buffer-diagnostics-at-event-line)
 
 ;;;###autoload
 (define-minor-mode flymake-mode
@@ -1616,6 +1630,28 @@ flymake-goto-prev-error
                      t))
   (flymake-goto-next-error (- (or n 1)) filter interactive))
 
+(defun flymake-diagnostics-at-mouse-event (event full-line)
+  "Get the flymake diagnostics for a position given by a mouse EVENT.
+When FULL-LINE is not nil it gives all the diagnostics in the EVENT's
+line. The function does not move the cursor position."
+  (mouse-minibuffer-check event)
+  (let* ((posn (event-end event))
+	 (pos (posn-point posn)))
+    (when (and (numberp pos)
+               (< pos (point-max))) ;; pos is == (point-max) when the click is after the buffer end.
+      (with-selected-window (posn-window posn)
+	(with-current-buffer (window-buffer)
+          (save-excursion
+            (goto-char pos)
+            (if full-line
+                (flymake-diagnostics (line-beginning-position) (line-end-position))
+              (flymake-diagnostics pos (1+ pos)))))))))
+
+(defun flymake-show-buffer-diagnostics-at-event-position (event)
+  (interactive "e")
+  (flymake-show-buffer-diagnostics
+   (car (flymake-diagnostics-at-mouse-event event nil))))
+
 
 ;;; Mode-line and menu
 ;;;
@@ -1624,7 +1660,7 @@ flymake-menu
     [ "Go to next problem"      flymake-goto-next-error t ]
     [ "Go to previous problem"  flymake-goto-prev-error t ]
     [ "Check now"               flymake-start t ]
-    [ "List all problems"       flymake-show-buffer-diagnostics t ]
+    [ "List all problems"       flymake-show-buffer-diagnostics-at-event-position t ]
     "--"
     [ "Go to log buffer"        flymake-switch-to-log-buffer t ]
     [ "Turn off Flymake"        flymake-mode t ]))
@@ -1652,6 +1688,15 @@ flymake-mode-line-lighter
   :type 'string
   :version "29.1")
 
+(defcustom flymake-after-show-buffer-diagnostics-hook '(flymake-pulse-momentary-highlight-region)
+  "Hook called after jumping to a diagnostic line.
+
+This hooks are called when `flymake-show-buffer-diagnostics' receives an
+the optional `diagnostic' argument and it matches an entry in the
+diagnostic's buffer."
+  :type 'hook
+  :version "31.0")
+
 (defvar flymake-mode-line-title '(:eval (flymake--mode-line-title))
   "Mode-line construct to show Flymake's mode name and menu.")
 
@@ -1822,6 +1867,17 @@ flymake-diagnostics-buffer-mode-map
     (define-key map (kbd "SPC") 'flymake-show-diagnostic)
     map))
 
+
+(defun flymake-pulse-momentary-highlight-region (&optional start end)
+  "Helper function to highlight region.
+This uses the point `line-beginning-position' and `line-end-position' to
+determine the optional START and END when the optional values are not
+specified."
+  (pulse-momentary-highlight-region (or start (line-beginning-position))
+                                    (or end (line-end-position))
+                                    'highlight))
+
+
 (defun flymake-show-diagnostic (pos &optional other-window)
   "Show location of diagnostic at POS."
   (interactive (list (point) t))
@@ -1833,9 +1889,7 @@ flymake-show-diagnostic
          (end (flymake--diag-end diag))
          (visit (lambda (b e)
                   (goto-char b)
-                  (pulse-momentary-highlight-region (point)
-                                                    (or e (line-end-position))
-                                                    'highlight))))
+                  (flymake-pulse-momentary-highlight-region b e))))
     (with-current-buffer (cond ((bufferp locus) locus)
                                (t (find-file-noselect locus)))
       (with-selected-window
@@ -1969,7 +2023,7 @@ flymake--diagnostics-buffer-name
 (define-obsolete-function-alias 'flymake-show-diagnostics-buffer
   'flymake-show-buffer-diagnostics "1.2.1")
 
-(defun flymake-show-buffer-diagnostics ()
+(defun flymake-show-buffer-diagnostics (&optional diagnostic)
   "Show a list of Flymake diagnostics for current buffer."
   (interactive)
   (unless flymake-mode
@@ -1987,7 +2041,15 @@ flymake-show-buffer-diagnostics
                       `((display-buffer-reuse-window
                          display-buffer-below-selected)
                         (window-height . (lambda (window)
-                          (fit-window-to-buffer window 10))))))))
+                                           (fit-window-to-buffer window 10)))))
+      (when (and diagnostic flymake-after-show-buffer-diagnostics-hook)
+        (goto-char (point-min))
+        (catch 'done
+          (while-let ((id (tabulated-list-get-id (point))))
+            (if (eq (plist-get id :diagnostic) diagnostic)
+                (progn (run-hooks 'flymake-after-show-buffer-diagnostics-hook)
+                       (throw 'done nil))
+              (forward-line))))))))
 
 
 ;;; Per-project diagnostic listing

--piplhkfwybxosyx6--

Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75841; Package emacs. Full text available.

Message received at 75841 <at> debbugs.gnu.org:

Received: (at 75841) by debbugs.gnu.org; 28 Jan 2025 18:19:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 28 13:19:34 2025
Received: from localhost ([127.0.0.1]:38472 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tcqBR-0006vC-GP
	for submit <at> debbugs.gnu.org; Tue, 28 Jan 2025 13:19:33 -0500
Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]:48687)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1tcqBN-0006up-U1
 for 75841 <at> debbugs.gnu.org; Tue, 28 Jan 2025 13:19:30 -0500
Received: by mail.gandi.net (Postfix) with ESMTPSA id AF5A4443BE;
 Tue, 28 Jan 2025 18:19:22 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Ergus <spacibba@HIDDEN>
Subject: Re: bug#75841: [PATCH] [UPDATE3] Fix mouse click on flymake
In-Reply-To: <4cazxxxaihei5aswrs7xwy3drgwsqt4faa4phn7ydnwzsodkpr@di6usnoc7axv>
 (Ergus's message of "Tue, 28 Jan 2025 13:59:22 +0100")
Organization: LINKOV.NET
References: <8634hc5lqr.fsf@HIDDEN>
 <EB9073DD-31C1-4A19-A601-563042041ADA@HIDDEN>
 <86ed0t23l9.fsf@HIDDEN>
 <cghqipziqfestwlqma6khqomrzvgw3kc4v3wgdko254o53wy5p@rniq2y7cm7jh>
 <86sep8y7iw.fsf@HIDDEN>
 <vlzgulkvp6hok6xipvpnwexbs5zhawsucphxdfk4p5obqbhlml@kdsbelm6u72u>
 <zzncrjvcfdp4g27k77xyva2mjy4s75iowf52jss57vianohdap@6rgszjwtgi2q>
 <87tt9m95hy.fsf@HIDDEN>
 <whcg5olmy43oygl5jcjklgdiqxaih5ql2qf2sk4nej2ilpo6oj@slx7vkyud3jm>
 <87y0ywulnm.fsf@HIDDEN>
 <4cazxxxaihei5aswrs7xwy3drgwsqt4faa4phn7ydnwzsodkpr@di6usnoc7axv>
Date: Tue, 28 Jan 2025 20:17:51 +0200
Message-ID: <87sep2950w.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-State: clean
X-GND-Score: 0
X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdektdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrdeliedrledtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrdeliedrledtpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepgedprhgtphhtthhopeejheekgeduseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepshgsrghughhhsehjrghnvghsthhrvggvthdrtghomhdprhgtphhtthhopehsphgrtghisggsrgesrgholhdrtghomh
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 75841
Cc: sbaugh@HIDDEN, eliz@HIDDEN, 75841 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

>>> +(defvar-keymap flymake-mode-map
>>> +               :doc "Keymap for `flymake-mode'."
>>> +               (format "<%s> <mouse-1>" flymake-fringe-indicator-position)
>>> +               #'flymake-show-buffer-diagnostics-at-event-line)
>>
>>This dependency on 'flymake-fringe-indicator-position' can break
>>in the case when the user customizes the value
>>of 'flymake-fringe-indicator-position' to 'right-fringe'.
>>Then clicking will fail with "<right-fringe> <mouse-1> is undefined".
>>
> This works the same way. The previous code didn't support dynamically
> change the flymake-fringe-indicator-position. We can try to solve it,
> but we go back to the same issue tan in my first patch. We cannot change
> the map.

Do you see a problem with binding both initially:
'left-fringe' and 'right-fringe'?

>>> +      (with-selected-window (posn-window posn)
>>> +	(with-current-buffer (window-buffer)
>>> +	  (goto-char pos)
>>> +          (if full-line
>>> +              (flymake-diagnostics (line-beginning-position) (line-end-position))
>>> +            (flymake-diagnostics pos (1+ pos))))))))
>>
>>I don't know if '(with-selected-window (posn-window posn)' was intended
>>to handle this case, but clicking on the fringe still raises the error
>>"Flymake mode is not enabled in the current buffer" when clicking
>>from the diagnostics buffer.
>>
> I haven't seen this, please tell me how to reproduce it.

The previous code didn't support this case, so no need to handle this.
I just thought why with-selected-window can't handle the case
when the selected window was the diagnostics buffer, and then
can't click the fringe in the source buffer.

>>> +(defcustom flymake-after-jump-hook '(pulse-momentary-highlight-one-line)
>>> +  "Hook called after jumping to a diagnostic line.
>>> +
>>> +This hooks are called when `flymake-show-buffer-diagnostics' receives an
>>> +the optional `diagnostic' argument and it matches an entry in the
>>> +diagnostic's buffer."
>>> +  :type 'hook
>>> +  :version "31.0")
>>
>>Please note that this is not direct equivalent to xref-after-jump-hook.
>>xref-after-jump-hook is more like flymake-show-diagnostic and
>>flymake-goto-diagnostic that jumps from the diagnostic buffer to the
>>source buffer.  But this hook is about showing the diagnostic buffer.
>>So a less ambiguous name would be 'flymake-after-show-buffer-diagnostics-hook'.
>>
>>Then 'pulse-momentary-highlight-one-line' works nicely.
>>For consistency it could use the same face 'highlight'
>>as 'pulse-momentary-highlight-region' in 'flymake-show-diagnostic'.
>
> I will include these in the next patch. When I fix the
> with-selected-window issue you mention before.

Thanks.

Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75841; Package emacs. Full text available.

Message received at 75841 <at> debbugs.gnu.org:

Received: (at 75841) by debbugs.gnu.org; 28 Jan 2025 12:59:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 28 07:59:42 2025
Received: from localhost ([127.0.0.1]:35884 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tclBt-0001Px-TV
	for submit <at> debbugs.gnu.org; Tue, 28 Jan 2025 07:59:42 -0500
Received: from sonic312-20.consmr.mail.bf2.yahoo.com ([74.6.128.82]:41160)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <spacibba@HIDDEN>) id 1tclBn-0001Pb-6d
 for 75841 <at> debbugs.gnu.org; Tue, 28 Jan 2025 07:59:40 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048;
 t=1738069168; bh=OXXr0TPnjPyICIlcvKo7ZWXGuxp0lg5/3pJ3ZG+DQp0=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To;
 b=rBz1PzEHIliT5BoTg0tVA7fnTdV4YZwLQv88+71XEqiVXoj2kbxc1/M7gj0EVnH8VC0fJgZQcb2xwafIHDCX1O+gQhHRt0Fb/X6ipaJ2bbeIoA7dhmxsNtQQ+tjDX1HvFAiPNakrFoxWfhNHjEtEaQhcRSqbjkwE3RiyTLzZE39nO8H62I8c2hzOm8dHP9dUrY5hkZGw7L+1b4Z+CVzoI7a4XhSQRqlSEfnkItNBVdEFgxrKtvgyd70J5wPEUTIw/qvU1pJ0xgIihNBLadOIew58oCwv9nkBMrZ8RZQMkryQTKR90LDpAk9IL9GjKNisWu2k/Kdb6ILobOatTkb82w==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
 t=1738069168; bh=VKuc3CPH+F9ZCqmTnZh7Yf8lmelLqsAcTyl7WZwZGQ5=;
 h=X-Sonic-MF:Date:From:To:Subject:From:Subject;
 b=Yw1XITL6+MB7QCOYmkeMcVERxfOMnzlP7RBBy/gxVlF493aSY6VkL01doXibvZBNJNdqFby0MZd2SaQ0Y1jYCKpUnVIfnJ8cB0ou/jMEW+t8apENKXnCnuo16zBglO+PwT3v92lqBcoiWsNr+mWcgYkzzniRKwXwB2LuRND9hAGsZNBGzt4mCISBaxfdbVEAF4Oc0pN2QZ/0ohCf7xyq5KRdv89PfpXbgTRh3WOnEru83wXW16MLHVTOGWLcbI1WR4+hkA25mxHh9CMVIsXZxOVSnCRpokXOzg9sK6j7PjzNJMqOC3HOFTgcRPv3bRMsTtjlbca42JWGr3iHePBtsg==
X-YMail-OSG: 56FPDw8VM1lowev0lwLiUdVu153nuZ.3Lb8ReUKlm96CMWfPFpIgfY5eDwwG.wL
 gOKW0Edf3wreEaPWhV1pfmJ4UxKFfWjDvlYiY1062WycvomJ5IoWYLKYlBWSSBsWkBYRci3gIsgs
 2t2z3uP7CUcsL.teblnCfLoJd29WsXpRtC5gBXZzbJOQAh.tssz6yvR1CNhCLVKF0cXToTWUhOI7
 CDpyoTm8rrcS0FBxqRxB4x7APWuQOdVbuo_QC_UaqLKerOZifpfWxpQPYWfER7Gjk5.oGuu2g3bC
 Kpe.NeThjCjuKGbFelEhLngOSYyF.ycKs_53iUQibZYKb4Mfih4KFLpe3uOpxDb9QvxdiWzPSr4O
 a1DVRy9bRGhD4JjHUAYFExX3.Oq9cnfpNkhFWIE_ZG0J8b3_Heozv1WHxlpkmzdI_PJcxurMI620
 yvHOEiwMh93Dy7yxKGIi5ZEXU924eusZmpl0I.y5s8Ia7JHY9_6bpy3WfIMnq_NK_Snfzv5A_UQe
 WIpqXnFxHKSmnWlPxB8IyUuhmX1Ns5f1F3iAPV2Nn_R3feSI0PnNoJ68Y96DWVgXQc4VAC_sIED0
 ViVYWCa9LlhYdkzLiJb1fadEN0uVMdKHrrS1JixTlSbEbMjJC.BBBD6O3WTsEpexByAtAd0PSgfl
 iVJCNN8GPjOkKopJQIXpvPv0UdHT4G.vo.CbVA6QLw7O..Ey33FGBgYs.afxR.Oud_NL3JuS3L1E
 7tleSQDvXeUCZhkBK4ykP2h4qGtxKDT4hqzMpu4rfefrWCCWzk.Vl4QLOK51730gD.RwpGKy2vid
 IJnpbHOxgDIfiro9w.Bwxuc8wWoe03Frl2XXnx1OGKMPMGl7ml2aOV9nRCnipDTYkVXG8n2O6D6V
 Hn3W5i288zKncwoSSfMFdm7HB76uuQytR7QJ_8En4bOffleBPkE.FAhNIyPv5_WC2jnPGNR2hQWt
 ntiTJU7H_70l5QFd8kl4rI2bvbYcEdu_HCmD.rqd3BQm6wzCEuyQWrghq7nVvWzTJaGwyWiR7UTZ
 Vc_5hsnSqMxNs1aykhIifKN8ifOrNP6W4CRbvbqrgb0RJLDTuQURexKuxrxQuuVgToYF80T8JaGJ
 0Epkln0XLjDcsEjiPpx1aA8iDG34eTbBquWS0pBM6UsjPW5ukhRtMVBF6dLL.3hdSg_AzFrGnbph
 NDcI5HOhg..RirVXGd26zUcguo.LXB8MIi.E61D_o35rCBWMdiyp2dyj2N4_8nt73tkRa.28v.BI
 hfkbqKAxiHkBLJq5gKJf8COKUBw2Py77O7tQmwcc11QS8LRIzbk0hhivWh2.V6wPaWCB62C63_to
 mUD2PPMJdGUWoMSu_X6SCKR.JYeSFVuA17lmkeZgKfVxBtDu2EGPtFQrNh3ouLUZlzVHABf6Kh1O
 WDeI3cfrrLIdRAjFhRJ1D4kgHolAexopb8VdexGdj9Z014TgJ_HqDMtk_HPfpIj6dckaSLXELssC
 bNdIwZHnAuvNgKQHYMev2Q6ROYzMc9fwXnkTVMiY7ZAsXGNWR1IJmrJ4hG5VXTimpegnNlRjm_dK
 .YfuOdcHYOhDV6LPnXC3USt_TiEsLCLP0abwgJdGM3V4JEuxnNoMd4KfnpCAvH4amyodxCyFrxnH
 wOcne7OcWf1pr3lIAHF.5Lov3OmUJh5jvmHtexVoXjoba35yKHEDaTFTRIA1WAkqJV0gCE593tTg
 WHhi4csYZcrn3jv8F1N1h0szMcQHjwJ1_0ul8Rsfy27eUOqEScn.rKffgeuX0GHTaSpjuE2tA071
 gua4otBuEDllM0dZH2LvhKCZ3_dg_4KDqO_TkWo3VxawVaP.eOre97wtYAcNbZCSqL3_GnH1Zp2y
 h4IeK_osg9tIM0_GkkjlXPZk3j03LEzgNjtqX1Io2LoS6X6tkhde0r1LMeGLGESayaOvhr.pH7m2
 yeD8LbAuLME4QjFFEXwjJCRTTSOb62I1utWgWYZRIz9GDaoBWa2IJVrE5YIB4.Hns4u54n.PcAMq
 smbDCQ208RYAxRV9Yn1CqBYcJEc19AgMa224ZoA_mn0FOgJFofUMFvyMAvRkbRxCf3aTnor0riA7
 QME4G0P4b1Oar5ZNAfAy8lgOA60xLLrAt2zQWwHB.l3F5jPbEEskiBFqfKrxaBiRgjFvxfg3awqY
 KcBaX1hvnV67MOQI.z06mL0WhRjaqMqsii4IY9Uq.eZQ4LUyIBEeF4ZUBFGN5LXxfmOrUEfmp7iN
 lEuBh3A--
X-Sonic-MF: <spacibba@HIDDEN>
X-Sonic-ID: a190fbae-1434-4f04-b429-a79433d825a9
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic312.consmr.mail.bf2.yahoo.com with HTTP; Tue, 28 Jan 2025 12:59:28 +0000
Received: by hermes--production-ir2-c694d79d9-rpm9f (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID eb414b33a40062457f5836489e5a0c97; 
 Tue, 28 Jan 2025 12:59:24 +0000 (UTC)
Date: Tue, 28 Jan 2025 13:59:22 +0100
From: Ergus <spacibba@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
Subject: Re: bug#75841: [PATCH] [UPDATE3] Fix mouse click on flymake
Message-ID: <4cazxxxaihei5aswrs7xwy3drgwsqt4faa4phn7ydnwzsodkpr@di6usnoc7axv>
References: <8634hc5lqr.fsf@HIDDEN>
 <EB9073DD-31C1-4A19-A601-563042041ADA@HIDDEN>
 <86ed0t23l9.fsf@HIDDEN>
 <cghqipziqfestwlqma6khqomrzvgw3kc4v3wgdko254o53wy5p@rniq2y7cm7jh>
 <86sep8y7iw.fsf@HIDDEN>
 <vlzgulkvp6hok6xipvpnwexbs5zhawsucphxdfk4p5obqbhlml@kdsbelm6u72u>
 <zzncrjvcfdp4g27k77xyva2mjy4s75iowf52jss57vianohdap@6rgszjwtgi2q>
 <87tt9m95hy.fsf@HIDDEN>
 <whcg5olmy43oygl5jcjklgdiqxaih5ql2qf2sk4nej2ilpo6oj@slx7vkyud3jm>
 <87y0ywulnm.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <87y0ywulnm.fsf@HIDDEN>
X-Mailer: WebService/1.1.23187
 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol
Content-Length: 3100
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 75841
Cc: sbaugh@HIDDEN, eliz@HIDDEN, 75841 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Mon, Jan 27, 2025 at 09:00:45PM +0200, Juri Linkov wrote:
>>>> Please find attached the patch with the fix + the new feature.
>>>
>>>Your previous patch worked at least for margins, but new one doesn't work.
>>>
>> Try it now please. I actually detected the issue just now and was
>> planning to submit a new patch. when I saw your message
>
>Thanks for the patch.  I tested it, and now it works.
>Please see some comments below.
>
>> I actually prefer to create a branch and so on, but I thought that this
>> patch would be just a couple of lines (like in my first message). But
>> things are never as simple as I would like ;)
>
>Too many troubles with the branch because it requires recompilation
>every time after switching the branch.  The patch is much simpler ;)
>
It depends ;)

>> +(defvar-keymap flymake-mode-map
>> +               :doc "Keymap for `flymake-mode'."
>> +               (format "<%s> <mouse-1>" flymake-fringe-indicator-position)
>> +               #'flymake-show-buffer-diagnostics-at-event-line)
>
>This dependency on 'flymake-fringe-indicator-position' can break
>in the case when the user customizes the value
>of 'flymake-fringe-indicator-position' to 'right-fringe'.
>Then clicking will fail with "<right-fringe> <mouse-1> is undefined".
>
This works the same way. The previous code didn't support dynamically
change the flymake-fringe-indicator-position. We can try to solve it,
but we go back to the same issue tan in my first patch. We cannot change
the map.

>> +      (with-selected-window (posn-window posn)
>> +	(with-current-buffer (window-buffer)
>> +	  (goto-char pos)
>> +          (if full-line
>> +              (flymake-diagnostics (line-beginning-position) (line-end-position))
>> +            (flymake-diagnostics pos (1+ pos))))))))
>
>I don't know if '(with-selected-window (posn-window posn)' was intended
>to handle this case, but clicking on the fringe still raises the error
>"Flymake mode is not enabled in the current buffer" when clicking
>from the diagnostics buffer.
>
I haven't seen this, please tell me how to reproduce it.

>> +(defcustom flymake-after-jump-hook '(pulse-momentary-highlight-one-line)
>> +  "Hook called after jumping to a diagnostic line.
>> +
>> +This hooks are called when `flymake-show-buffer-diagnostics' receives an
>> +the optional `diagnostic' argument and it matches an entry in the
>> +diagnostic's buffer."
>> +  :type 'hook
>> +  :version "31.0")
>
>Please note that this is not direct equivalent to xref-after-jump-hook.
>xref-after-jump-hook is more like flymake-show-diagnostic and
>flymake-goto-diagnostic that jumps from the diagnostic buffer to the
>source buffer.  But this hook is about showing the diagnostic buffer.
>So a less ambiguous name would be 'flymake-after-show-buffer-diagnostics-hook'.
>
>Then 'pulse-momentary-highlight-one-line' works nicely.
>For consistency it could use the same face 'highlight'
>as 'pulse-momentary-highlight-region' in 'flymake-show-diagnostic'.

I will include these in the next patch. When I fix the
with-selected-window issue you mention before.


Best,
Ergus

Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75841; Package emacs. Full text available.

Message received at 75841 <at> debbugs.gnu.org:

Received: (at 75841) by debbugs.gnu.org; 27 Jan 2025 19:03:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 27 14:03:47 2025
Received: from localhost ([127.0.0.1]:34458 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tcUOh-00035e-4X
	for submit <at> debbugs.gnu.org; Mon, 27 Jan 2025 14:03:47 -0500
Received: from relay5-d.mail.gandi.net ([217.70.183.197]:57061)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1tcUOf-00035P-1u
 for 75841 <at> debbugs.gnu.org; Mon, 27 Jan 2025 14:03:45 -0500
Received: by mail.gandi.net (Postfix) with ESMTPSA id E1DDD1C0002;
 Mon, 27 Jan 2025 19:03:34 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Ergus <spacibba@HIDDEN>
Subject: Re: bug#75841: [PATCH] [UPDATE3] Fix mouse click on flymake
In-Reply-To: <whcg5olmy43oygl5jcjklgdiqxaih5ql2qf2sk4nej2ilpo6oj@slx7vkyud3jm>
 (Ergus's message of "Sat, 25 Jan 2025 22:26:38 +0100")
Organization: LINKOV.NET
References: <877c6pjtqe.fsf@HIDDEN>
 <285D34FD-8F62-4C49-83EB-1F8E3D486793@HIDDEN>
 <8634hc5lqr.fsf@HIDDEN>
 <EB9073DD-31C1-4A19-A601-563042041ADA@HIDDEN>
 <86ed0t23l9.fsf@HIDDEN>
 <cghqipziqfestwlqma6khqomrzvgw3kc4v3wgdko254o53wy5p@rniq2y7cm7jh>
 <86sep8y7iw.fsf@HIDDEN>
 <vlzgulkvp6hok6xipvpnwexbs5zhawsucphxdfk4p5obqbhlml@kdsbelm6u72u>
 <zzncrjvcfdp4g27k77xyva2mjy4s75iowf52jss57vianohdap@6rgszjwtgi2q>
 <87tt9m95hy.fsf@HIDDEN>
 <whcg5olmy43oygl5jcjklgdiqxaih5ql2qf2sk4nej2ilpo6oj@slx7vkyud3jm>
Date: Mon, 27 Jan 2025 21:00:45 +0200
Message-ID: <87y0ywulnm.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 75841
Cc: sbaugh@HIDDEN, eliz@HIDDEN, 75841 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

>>> Please find attached the patch with the fix + the new feature.
>>
>>Your previous patch worked at least for margins, but new one doesn't work.
>>
> Try it now please. I actually detected the issue just now and was
> planning to submit a new patch. when I saw your message

Thanks for the patch.  I tested it, and now it works.
Please see some comments below.

> I actually prefer to create a branch and so on, but I thought that this
> patch would be just a couple of lines (like in my first message). But
> things are never as simple as I would like ;)

Too many troubles with the branch because it requires recompilation
every time after switching the branch.  The patch is much simpler ;)

> +(defvar-keymap flymake-mode-map
> +               :doc "Keymap for `flymake-mode'."
> +               (format "<%s> <mouse-1>" flymake-fringe-indicator-position)
> +               #'flymake-show-buffer-diagnostics-at-event-line)

This dependency on 'flymake-fringe-indicator-position' can break
in the case when the user customizes the value
of 'flymake-fringe-indicator-position' to 'right-fringe'.
Then clicking will fail with "<right-fringe> <mouse-1> is undefined".

> +      (with-selected-window (posn-window posn)
> +	(with-current-buffer (window-buffer)
> +	  (goto-char pos)
> +          (if full-line
> +              (flymake-diagnostics (line-beginning-position) (line-end-position))
> +            (flymake-diagnostics pos (1+ pos))))))))

I don't know if '(with-selected-window (posn-window posn)' was intended
to handle this case, but clicking on the fringe still raises the error
"Flymake mode is not enabled in the current buffer" when clicking
from the diagnostics buffer.

> +(defcustom flymake-after-jump-hook '(pulse-momentary-highlight-one-line)
> +  "Hook called after jumping to a diagnostic line.
> +
> +This hooks are called when `flymake-show-buffer-diagnostics' receives an
> +the optional `diagnostic' argument and it matches an entry in the
> +diagnostic's buffer."
> +  :type 'hook
> +  :version "31.0")

Please note that this is not direct equivalent to xref-after-jump-hook.
xref-after-jump-hook is more like flymake-show-diagnostic and
flymake-goto-diagnostic that jumps from the diagnostic buffer to the
source buffer.  But this hook is about showing the diagnostic buffer.
So a less ambiguous name would be 'flymake-after-show-buffer-diagnostics-hook'.

Then 'pulse-momentary-highlight-one-line' works nicely.
For consistency it could use the same face 'highlight'
as 'pulse-momentary-highlight-region' in 'flymake-show-diagnostic'.

Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75841; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 25 Jan 2025 21:27:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 25 16:27:05 2025
Received: from localhost ([127.0.0.1]:52899 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tbngH-00054g-1X
	for submit <at> debbugs.gnu.org; Sat, 25 Jan 2025 16:27:05 -0500
Received: from lists.gnu.org ([2001:470:142::17]:41134)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <spacibba@HIDDEN>) id 1tbngE-000546-D1
 for submit <at> debbugs.gnu.org; Sat, 25 Jan 2025 16:27:03 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <spacibba@HIDDEN>) id 1tbng7-0000Pa-SE
 for bug-gnu-emacs@HIDDEN; Sat, 25 Jan 2025 16:26:55 -0500
Received: from sonic316-12.consmr.mail.bf2.yahoo.com ([74.6.130.122])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <spacibba@HIDDEN>) id 1tbng5-000094-8g
 for bug-gnu-emacs@HIDDEN; Sat, 25 Jan 2025 16:26:55 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048;
 t=1737840409; bh=ByZAcDzeyDY/iSg8Dn8MbOu1eTiKbAmRwnpH6Rr2Bl8=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To;
 b=HK0QMMnUvQivFtnDIM/gskJ7iUU6fWL61pKVMJ8Old5rlM4C1f59kjiI+H2YHfRSJewuPg1iJVA1hLPDybXKwxKmVsNZbZ1zfn6MYiHR50q8N1ptJv/nCeBJ2Zli4iMnEAXSDRvJlosj68dShzsEpQgfQ2NmfGWcZMGAmrbZkAWf6x22L6t5bXPjDW99UktpARaKfOD4SQ2i1T3UbY1ATMptHZB5qznUC1At8EiEz90CAJYHc9SnA6f7fNOda9GfE4p/L4iNw2w/xo61inTKegimqaKOqvvQFNpW/PWgxM/pi0V/FySt+ZbHnuypDxcdMcjDfBmEF5hBwkwDVTFbLw==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
 t=1737840409; bh=Ef0lMCMfu/WeP//pL2aOBBDVKr1+FvQg7xPTZvbRduL=;
 h=X-Sonic-MF:Date:From:To:Subject:From:Subject;
 b=SNusl5J3UrqeHchbTY3l8cT76WGkUKt3zFw7BifwhhAW2Uej49JnECpyxLfGuOzxskWljjJokFE47tc1Mu8HFJPDYFO7QL/jBQ5YbmkFwIOCkn0Yq7bvYn3bFHMLge6KvsggHnuIyQB6V6WoxcAtw23kCH1YiJG4S4s2CbPieHMpuQdx8NMLxvRNabkvKUk9T3qZQLhnkmxlmO+hU09O4OXBBpu91oTHnFM/i6FwqCmV9vPVd0EZXfZt2bl7RmRDOxiD5yk2TSNQOmZkSTX7LEIzQq2xtMh9lp8IaltRovq2mhprP2+zg3MAOqQBOejm/NUzKByzFgStG4Tj3X+IxQ==
X-YMail-OSG: bsMEaEIVM1mwHY79yJ2cSGJlqnny9.cu1RB9PGicxn7Gi1_OEoObpKjyfwUoDd1
 ._uNTvH4P1SevXBrbAhjX3jLgGy1OhJT8tlbG38X94YU4mtk5xrLwgwt.gGR.z8HJlfHGyNvf2WU
 Vaq4S8rCNTJhUznNHfN22jN0Kb8nMahghejAeuPJBxtJyzYAnmc4Lh3vfq9Gt._4x9zJA5urB4Kh
 BeZsXN5M4lgC0j4jmMQJnmfvmTMgp177fEcVHJSsGZho0F4VJoZ3WENOyahb.zXVHWHxflNdV1Ct
 Pp1XIVyN8PjVbifQIpfAWeCvW9TNZKr5PoEaEPNIRuNb2BxRZusRmiRpsOkkF69G_EHuvQRRIo4E
 7fT.KbKfOQQeFYfF39RIU3M5ZDWeN_aTf9ms4A7FiD9TCYWirRwWW.3ynQm6TS_RrFzI4NZBfzja
 2qHtnPUdHXfaYPOuCi75f8Dv5gLAxh_bDkLIiz7r1GNMZB3I4T1_42xPLNULifZOyhKcLyqsiY8Z
 t8UdziinICZiJ1c3JaAbP6fIxaFV3wjvJnCgiSjTqe_6mhf54RAT.T0okojDkfO5F_vbp7LD9Z5_
 _FWL5kb0H1ukSVYHn6W6F5M_1AHBpkj0fAULi7OF2Wpm76e8P9bbdNh85QjfUzkLn_NHxJwlyV79
 4r.1.eTGPUxNKSm0E0g0kcpwVQ4Zd4hpOqVwQbLtqYEDIL5ynqzwLNRcMvTuOM1nv.9UFW73_U8x
 Q5pZP4noIaPDenGMthT4unjzq50uWiaJQDBodkAIzdPKEOY2oHDeE36O9pgC8t6t6ohkSxhV.llf
 kCpuiJtPqzEPkJ1yfLzxRnvZ5jVJTs9aAg2kVhLMkriXhPNu8iP4KPwTDC3zuDXxWOPyg9HkklJO
 YDc8VfpTAtaOH4KleUDAcXvuQn_Zt68PZTQRN6TCIUUoYNhrqNVJnRJaO_0Q7BnONKTgAOMgoLQy
 SEEokUYBxdB8x6vT2AOedlNimAsTM8_kL2758tnXhAU5RVey9Z3UvooyujvjD3TMjp7zLH8SBVXw
 LEHb7gRUgb57rQIG4gsGiFG.De_KnRRtEhOYSIuacorjBJepu2pO2LpurYgSFdYztfYpVm0SRs8D
 g4eAX1BDSZwdHY5tB4qdYgSNUb0SXqLtMEZ6SyAMFXxgc_gJrTf_eeTZgaDoMnzl2twBX.GBiz4D
 PqCtk6RzgU9uLFZSxe4cNDl8plxufDxXIe4vsv..FLie..MVj7Pqvw0bKQ_JP9_oGPRPgd5UJhX1
 yIsi2.JdkuG51V_g9aR7Po.UxHj_cgDxTlHBQsGhUgMaxFxZt8gRaRxod1Sg16OMY5p3_snCME5D
 OPiW5pbyZu0gMlsBjcd.I2zpp93WvhgX3AC7b1xjOz71rkD0l6G.zUVFB0smw8zAY44o4zhj1Tda
 hNcK_AnTsqa7ZGZfMcjO4MbPb0bfgQNwetjdHJ0i8vtI923Ik3llzv0_GDWt_Et8qgsnFassJx2F
 O.zDmIYGMDXF5ybOhEZHa1e.If3Y36pwYceBsiLLU5CLsU69Xs5jx.RgNd1vjHGxIRynbTO7T.rY
 FyyBeFXao25OmluAMKeuFnswrX3gjFgy3ZW5OAFrPtilm0Qo3zInd37cYlOifnq5QxLx1L9l1rBa
 Pc2HNP4cRYbcs2J9h_3uzsapqtmx3ADs_bc7c8oeKwcUPFt0YJAribR3CBnYMhuw_yq_5wCfjfVS
 t9P4H32zYFlYV9reygizgt1zlOj8ZHdVAmf1un3FVZU_U_gUOxKS6ryRrOBPRP4FqXrc4iKZq7Dz
 xJ1cUyT9EeE2h6LcWL_0bdMOqP1Hny.Kdo05xRapJV.Jzh6aRQ00PtKhuG.esiGis9AzvYa.WsAQ
 UUGx2_A88F3Cp21swKhyxnVYhbMlJiaEJvFqdOBNqhOF1grCoEE2CsdNh3EqDIgjyDIr_wMy2tDu
 4G6REOUJ61MFjTvIu8_S2.bz5H63NtNhYKQ44KpXcn38wwGMO0vryzyvmJlyNcqfe73mCceBBiN2
 bQIEbAh1IUcHYeSOAkSjCJfx5wGxJ0h8mwi4oQdmCHRqbzE2NIMjQyt5NuTGNjlIjLL5WmDcEQeT
 _UB1CLPxC_WfKBf5ZvpLmSW.9kvl4w2Ga_mVVW5TTgh.tMHkorrDEMUgXk_KnByerpAk2bKg.QRP
 I84dcv3ss5Q6I8rKKN2gpSmFBQbqp1czJkRBa1ks3GqkafH3yl.iFXUvsErut_1M21qbgO9nObJl
 _MV6ChL12dRaM
X-Sonic-MF: <spacibba@HIDDEN>
X-Sonic-ID: 730bd6cf-bc6b-4a2e-852f-83222b6104b8
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic316.consmr.mail.bf2.yahoo.com with HTTP; Sat, 25 Jan 2025 21:26:49 +0000
Received: by hermes--production-ir2-c694d79d9-f7l2b (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID 3d0e5bfb8cf9e450cb8d136dcb64a42d; 
 Sat, 25 Jan 2025 21:26:45 +0000 (UTC)
Date: Sat, 25 Jan 2025 22:26:38 +0100
From: Ergus <spacibba@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
Subject: Re: [PATCH] [UPDATE3] Fix mouse click on flymake
Message-ID: <whcg5olmy43oygl5jcjklgdiqxaih5ql2qf2sk4nej2ilpo6oj@slx7vkyud3jm>
References: <877c6pjtqe.fsf@HIDDEN>
 <285D34FD-8F62-4C49-83EB-1F8E3D486793@HIDDEN>
 <8634hc5lqr.fsf@HIDDEN>
 <EB9073DD-31C1-4A19-A601-563042041ADA@HIDDEN>
 <86ed0t23l9.fsf@HIDDEN>
 <cghqipziqfestwlqma6khqomrzvgw3kc4v3wgdko254o53wy5p@rniq2y7cm7jh>
 <86sep8y7iw.fsf@HIDDEN>
 <vlzgulkvp6hok6xipvpnwexbs5zhawsucphxdfk4p5obqbhlml@kdsbelm6u72u>
 <zzncrjvcfdp4g27k77xyva2mjy4s75iowf52jss57vianohdap@6rgszjwtgi2q>
 <87tt9m95hy.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="yti5t2tvs2sjo6sy"
Content-Disposition: inline
In-Reply-To: <87tt9m95hy.fsf@HIDDEN>
X-Mailer: WebService/1.1.23187
 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol
Content-Length: 10347
Received-SPF: pass client-ip=74.6.130.122; envelope-from=spacibba@HIDDEN;
 helo=sonic316-12.consmr.mail.bf2.yahoo.com
X-Spam_score_int: -17
X-Spam_score: -1.8
X-Spam_bar: -
X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1,
 DKIM_SIGNED=0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001,
 RCVD_IN_MSPIKE_H2=-0.049, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.6 (/)
X-Debbugs-Envelope-To: submit
Cc: sbaugh@HIDDEN, Eli Zaretskii <eliz@HIDDEN>, bug-gnu-emacs@HIDDEN,
 emacs-devel@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.4 (/)


--yti5t2tvs2sjo6sy
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline

Hi Juri:

On Sat, Jan 25, 2025 at 07:48:33PM +0200, Juri Linkov wrote:
>> Please find attached the patch with the fix + the new feature.
>
>Your previous patch worked at least for margins, but new one doesn't work.
>
Try it now please. I actually detected the issue just now and was
planning to submit a new patch. when I saw your message

The issue was that I was checking for errors only in the event
position. But on fringe events `pos' is always the line start position,
where not necessarily needs to be any error overlay.

Now the code considers the whole line when the event is from the fringe
or margin and uses only pos in the flymake-menu's command.

If the line has more than one error, it highlights the first one
returned by flymake-diagnostics.

>> It includes:
>
>> 1. A new defcustom equivalent to xref-after-jump-hook.
>> 2. An optional argument to flymake-show-buffer-diagnostics.
>> 3. Modification to flymake-menu to use a new function that also highlights
>> the candidate when possible.
>
>Thanks, nice idea.
>
>> They look like too many, but are actually just a few lines, so I put
>> them together.
>
>I wonder why you don't send patches to bug-gnu-emacs
>where it's easier to track them.

I actually prefer to create a branch and so on, but I thought that this
patch would be just a couple of lines (like in my first message). But
things are never as simple as I would like ;)

Best,
Ergus

--yti5t2tvs2sjo6sy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename="flymake-indicator-margin-click_v3.patch"

diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index 9dda53713f5..b7a68e382ef 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -748,34 +748,41 @@ flymake--severity
   (flymake--lookup-type-property type 'severity
                                  (warning-numeric-level :error)))
 
-(defun flymake--indicator-overlay-spec (indicator)
+(defun flymake--indicator-overlay-spec (type)
   "Return INDICATOR as propertized string to use in error indicators."
-  (let* ((value (if (symbolp indicator)
+  (let* ((indicator (flymake--lookup-type-property
+                     type
+                     (cond ((eq flymake-indicator-type 'fringes)
+                            'flymake-bitmap)
+                           ((eq flymake-indicator-type 'margins)
+                            'flymake-margin-string))
+                     (alist-get 'bitmap (alist-get type ; backward compat
+                                                   flymake-diagnostic-types-alist))))
+         (value (if (symbolp indicator)
                     (symbol-value indicator)
                   indicator))
-         (indicator-car (if (listp value)
-                            (car value)
-                          value))
-         (indicator-cdr (if (listp value)
-                            (cdr value))))
+         (valuelist (if (listp value)
+                        value
+                      (list value)))
+         (indicator-car (car valuelist)))
+
     (cond
      ((and (symbolp indicator-car)
            flymake-fringe-indicator-position)
       (propertize "!" 'display
-                  (cons flymake-fringe-indicator-position
-                        (if (listp value)
-                            value
-                          (list value)))))
+                  (cons flymake-fringe-indicator-position valuelist)))
      ((and (stringp indicator-car)
            flymake-margin-indicator-position)
       (propertize "!"
                   'display
                   `((margin ,flymake-margin-indicator-position)
-                    ,(propertize
-                      indicator-car
-                      'face
-                      `(:inherit (,indicator-cdr
-                                  default)))))))))
+                    ,(propertize indicator-car
+                                 'face `(:inherit (,(cdr valuelist) default))
+                                 'mouse-face 'highlight
+                                 'help-echo "Open Flymake diagnostics"
+                                 'keymap `,(define-keymap
+                                             (format "<%s> <mouse-1>" flymake-margin-indicator-position)
+                                             #'flymake-show-buffer-diagnostics-at-event-line))))))))
 
 (defun flymake--resize-margins (&optional orig-width)
   "Resize current window margins according to `flymake-margin-indicator-position'.
@@ -941,16 +948,7 @@ flymake--highlight-line
                   (overlay-put ov prop (flymake--lookup-type-property
                                         type prop value)))))
       (default-maybe 'face 'flymake-error)
-      (default-maybe 'before-string
-        (flymake--indicator-overlay-spec
-         (flymake--lookup-type-property
-          type
-          (cond ((eq flymake-indicator-type 'fringes)
-                 'flymake-bitmap)
-                ((eq flymake-indicator-type 'margins)
-                 'flymake-margin-string))
-          (alist-get 'bitmap (alist-get type ; backward compat
-                                        flymake-diagnostic-types-alist)))))
+      (default-maybe 'before-string (flymake--indicator-overlay-spec type))
       ;; (default-maybe 'after-string
       ;;                (flymake--diag-text diagnostic))
       (default-maybe 'help-echo
@@ -1369,12 +1367,21 @@ flymake-start
                   nil)))
              (flymake--import-foreign-diagnostics))))))
 
-(defvar flymake-mode-map
-  (let ((map (make-sparse-keymap)))
-    (define-key map `[,flymake-fringe-indicator-position mouse-1]
-                #'flymake-show-buffer-diagnostics)
-    map)
-  "Keymap for `flymake-mode'.")
+(defun flymake-show-buffer-diagnostics-at-event-line (event)
+  "Show diagnostics buffer on mouse click in the margin or fringe.
+This uses two different approaches to work.
+For margin it is set as a char property of the margin character directly.
+While in the fringe it is set as part of the `flymake-mode-map'."
+  (interactive "e")
+  (when-let* ((diagnostics (flymake-diagnostics-at-mouse-event event t)))
+    (flymake-show-buffer-diagnostics (car diagnostics))))
+
+;; Set the fringe mouse-1 action directly and perform the filtering
+;; latter iterating over the overlays.
+(defvar-keymap flymake-mode-map
+               :doc "Keymap for `flymake-mode'."
+               (format "<%s> <mouse-1>" flymake-fringe-indicator-position)
+               #'flymake-show-buffer-diagnostics-at-event-line)
 
 ;;;###autoload
 (define-minor-mode flymake-mode
@@ -1616,6 +1623,27 @@ flymake-goto-prev-error
                      t))
   (flymake-goto-next-error (- (or n 1)) filter interactive))
 
+(defun flymake-diagnostics-at-mouse-event (event full-line)
+  "Get the flymake diagnostics for a position given by a mouse EVENT.
+When FULL-LINE is not nil if gives all the diagnostics in the EVENT's
+line.
+"
+  (mouse-minibuffer-check event)
+  (let* ((posn (event-end event))
+	 (pos (posn-point posn)))
+    (when (numberp pos)
+      (with-selected-window (posn-window posn)
+	(with-current-buffer (window-buffer)
+	  (goto-char pos)
+          (if full-line
+              (flymake-diagnostics (line-beginning-position) (line-end-position))
+            (flymake-diagnostics pos (1+ pos))))))))
+
+(defun flymake-show-buffer-diagnostics-at-event-position (event)
+  (interactive "e")
+  (flymake-show-buffer-diagnostics
+   (car (flymake-diagnostics-at-mouse-event event nil))))
+
 
 ;;; Mode-line and menu
 ;;;
@@ -1624,7 +1652,7 @@ flymake-menu
     [ "Go to next problem"      flymake-goto-next-error t ]
     [ "Go to previous problem"  flymake-goto-prev-error t ]
     [ "Check now"               flymake-start t ]
-    [ "List all problems"       flymake-show-buffer-diagnostics t ]
+    [ "List all problems"       flymake-show-buffer-diagnostics-at-event-position t ]
     "--"
     [ "Go to log buffer"        flymake-switch-to-log-buffer t ]
     [ "Turn off Flymake"        flymake-mode t ]))
@@ -1652,6 +1680,15 @@ flymake-mode-line-lighter
   :type 'string
   :version "29.1")
 
+(defcustom flymake-after-jump-hook '(pulse-momentary-highlight-one-line)
+  "Hook called after jumping to a diagnostic line.
+
+This hooks are called when `flymake-show-buffer-diagnostics' receives an
+the optional `diagnostic' argument and it matches an entry in the
+diagnostic's buffer."
+  :type 'hook
+  :version "31.0")
+
 (defvar flymake-mode-line-title '(:eval (flymake--mode-line-title))
   "Mode-line construct to show Flymake's mode name and menu.")
 
@@ -1969,7 +2006,7 @@ flymake--diagnostics-buffer-name
 (define-obsolete-function-alias 'flymake-show-diagnostics-buffer
   'flymake-show-buffer-diagnostics "1.2.1")
 
-(defun flymake-show-buffer-diagnostics ()
+(defun flymake-show-buffer-diagnostics (&optional diagnostic)
   "Show a list of Flymake diagnostics for current buffer."
   (interactive)
   (unless flymake-mode
@@ -1987,7 +2024,15 @@ flymake-show-buffer-diagnostics
                       `((display-buffer-reuse-window
                          display-buffer-below-selected)
                         (window-height . (lambda (window)
-                          (fit-window-to-buffer window 10))))))))
+                                           (fit-window-to-buffer window 10)))))
+      (when (and diagnostic flymake-after-jump-hook)
+        (goto-char (point-min))
+        (catch 'done
+          (while-let ((id (tabulated-list-get-id (point))))
+            (if (eq (plist-get id :diagnostic) diagnostic)
+                (progn (run-hooks 'flymake-after-jump-hook)
+                       (throw 'done nil))
+              (forward-line))))))))
 
 
 ;;; Per-project diagnostic listing
diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index 263b980ac18..791aeef5765 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -1559,7 +1559,6 @@ project-compile-helper
 ;;;###autoload (autoload 'project-test "project")
 (project-compile-helper project-test :test-command)
 
-
 ;;;###autoload
 (defun project-recompile (&optional edit-command)
   "Run `recompile' in the project root with an appropriate buffer."

--yti5t2tvs2sjo6sy--

Acknowledgement sent to Ergus <spacibba@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.

Report forwarded to bug-gnu-emacs@HIDDEN:
bug#75841; Package emacs. Full text available.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Last modified: Tue, 25 Feb 2025 01:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.