GNU bug report logs - #75886
31.0.50; read-multiple-choice / read-key and input-decode-map

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Gerd Möllmann <gerd.moellmann@HIDDEN>; dated Mon, 27 Jan 2025 06:09:02 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 75886 <at> debbugs.gnu.org:


Received: (at 75886) by debbugs.gnu.org; 6 Feb 2025 04:30:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 05 23:30:23 2025
Received: from localhost ([127.0.0.1]:53678 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tftWx-0003jh-1J
	for submit <at> debbugs.gnu.org; Wed, 05 Feb 2025 23:30:23 -0500
Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:46304)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>)
 id 1tftWt-0003Kk-VJ
 for 75886 <at> debbugs.gnu.org; Wed, 05 Feb 2025 23:30:20 -0500
Received: by mail-ed1-x52f.google.com with SMTP id
 4fb4d7f45d1cf-5dcef821092so367666a12.0
 for <75886 <at> debbugs.gnu.org>; Wed, 05 Feb 2025 20:30:19 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1738816213; x=1739421013; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=u62Dfzg/lbYOO/qaKuxKtj/ghc6EHPlRX2/8dS59DY4=;
 b=B2GrM+dVEVcZ9xP4rIuagwRJp2gtSZhgpjou7arXrnSBwi8+7MyKkwu1P7P7Unmcbd
 KTnHEr7dukgAWUF63wW3uFQnYwK4TbLkNkfMIm84nS8wY9Asi0xDPr3d+q+584L1dvkx
 zXmTgfMPOrWtv9GjEFUlhoc0UzIT9khBogd39gfg5yVz15yP4Ygdw7DKXGstcshPcWVh
 aVsn6N6bmENmQnuPmjKMLyMb7mkTy3Ag8ZnrfwWNIi+3K9AN4DGxPd9J5Ei2AOgErkXM
 /sAyDFOcXxw8FVla6XwM4H127w8YUMT0IxNYM6Ks53I14ZCkkUdL1cYcFr3rB4ZyjdGo
 klPQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1738816213; x=1739421013;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=u62Dfzg/lbYOO/qaKuxKtj/ghc6EHPlRX2/8dS59DY4=;
 b=UGGr3g/fgnDc4rYPLgYcSYe2tXL+2KN0JyP+SM06vbn3p13rk3gKxmvZKqaBEVMsPi
 x7luhO/e8n2vOCJNN3NWMQ2Hsm1vlyy7taCOtC5fn9Dqxc4ni6apyMSdYaMkwMM7jXI3
 bG2ULtnP8dJbytH7Ywp0r+rb6zdbaHMcaKA4cGYMnzkJAMOaVuuVsMI9vvESagQTqzRQ
 6yWM2czcL3om3K+3LhvQw2WXkBYobVtJT0KSTWo21D6ADYg3QqcCcvclUwHk2KYpUeum
 cSv+2xWwwa92Fw/as8fonpHsfwWe7+vW6J9+2wGPhMDeyeTEY9IDxB+Lei6qrYlpkjfJ
 47Bw==
X-Gm-Message-State: AOJu0Yz8/B/Z+xFSTSZGMpwDJH0CBXxKqiOLLfv0UGEZT9yewvWVzzmM
 6lalGVWKTCPeBiobhSKcH1rWSdcUmzEqJOIA7WnE0bKQawGiyRl790brIQ==
X-Gm-Gg: ASbGncvr43V4naeFy/r/bITDdwS4RZDL7m7XGnzmqpWeV8VucRLWVVJFuW8idg5tgho
 uc2l9x7utOtNysEJ7UqSinThjQhFMLqFFd8rvjYN0unBgLr0q3ASueT6C+I+7v57B+AaR806DgV
 YnQxLnfGuBSSjmnGwDec8QRHAvF8NlDlSo4N5JTAt6m262Ziq9fKfiX5dgaiQna0QR7mxn9uw25
 EbV+e7pazJ5vtmTaYO+Z0PfF+qMtkKG76pl6ofKiTjxTBnFGEp7SVQw+xSPtW9I9nzxcBCGygf4
 V7FQzhUiMSxLZaAy/bUBP1oKuK2mN4noEsGj7AMIrka52JS+xJF+iEQcym5t+VUKApipA/fWtLE
 7dhkd/ICIpQcUFqNOqJYp6hwk
X-Google-Smtp-Source: AGHT+IGpUIuTtMgeXwxQQpk54rBkipG4mLO/LA256rJCypM6/vjZfqpFW7PcsrrC5RB3cDBOyb5o9g==
X-Received: by 2002:a05:6402:370c:b0:5dc:57a5:c414 with SMTP id
 4fb4d7f45d1cf-5dcdb779d70mr5656114a12.30.1738816213261; 
 Wed, 05 Feb 2025 20:30:13 -0800 (PST)
Received: from pro2 (p200300e0b705d700203c9d7d662e58a6.dip0.t-ipconnect.de.
 [2003:e0:b705:d700:203c:9d7d:662e:58a6])
 by smtp.gmail.com with ESMTPSA id
 4fb4d7f45d1cf-5dcf6c9f9cfsm209193a12.57.2025.02.05.20.30.11
 for <75886 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 05 Feb 2025 20:30:12 -0800 (PST)
From: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
To: 75886 <at> debbugs.gnu.org
Subject: Re: bug#75886: 31.0.50; read-multiple-choice / read-key and
 input-decode-map
In-Reply-To: <m2bjvsssb1.fsf@HIDDEN>
References: <m2bjvsssb1.fsf@HIDDEN>
Date: Thu, 06 Feb 2025 05:30:10 +0100
Message-ID: <m2bjvf3dbh.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75886
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Re-opened because map-y-or-n-p has the exact same problem.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75886; Package emacs. Full text available.
bug No longer marked as fixed in versions 31.1 and reopened. Request was from Debbugs Internal Request <help-debbugs@HIDDEN> to internal_control <at> debbugs.gnu.org. Full text available.
bug marked as fixed in version 31.1, send any further explanations to 75886 <at> debbugs.gnu.org and Gerd Möllmann <gerd.moellmann@HIDDEN> Request was from Gerd Möllmann <gerd.moellmann@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 75886 <at> debbugs.gnu.org:


Received: (at 75886) by debbugs.gnu.org; 4 Feb 2025 14:42:17 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 04 09:42:17 2025
Received: from localhost ([127.0.0.1]:43343 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tfK80-00060l-Li
	for submit <at> debbugs.gnu.org; Tue, 04 Feb 2025 09:42:17 -0500
Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:42085)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>)
 id 1tfK7w-00060G-6L
 for 75886 <at> debbugs.gnu.org; Tue, 04 Feb 2025 09:42:13 -0500
Received: by mail-wr1-x436.google.com with SMTP id
 ffacd0b85a97d-38db0146119so335191f8f.0
 for <75886 <at> debbugs.gnu.org>; Tue, 04 Feb 2025 06:42:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1738680125; x=1739284925; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=wOTtyqGcs3qqh1vpxI2HMoJQHmQJAhO865EYWmUijBw=;
 b=Zj/3tmji9uZm0gM5k2MItKIXaPWbXM5ZK31m/TXGTc1pz4fNdZHZkA9ck62nW6GMKL
 9koWWvfAfB9d3dT+4rc+wRJIYbcZ7tmPkOmqRL25y+ftzbQvarRCDs1faJkeQjvJPUii
 lGkyxOuQpyVSb17wHF8QrTpw2G9e7oWv4pJWJiSoa7vXnQmURKraz7HBBmF3PJ08AwAQ
 yiJSmzlV9v0VrDM5OOSBhXQu/Ib064ydhkWWAxo8ZZ2X/yIwt/Vb9RX70XTmnAK/yyxx
 /hjcXgPvmhKM1Ai1d4eUHmdehQp2UazBxY7+xLp+RJrj8UYJJRTYI4pMFTnKMCAxw1JP
 Z+4w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1738680125; x=1739284925;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=wOTtyqGcs3qqh1vpxI2HMoJQHmQJAhO865EYWmUijBw=;
 b=LWLi95XgggQpwof8UKwzgZpYjUdBpzGsqOo/YcDzoltI3TXTCZltvnF1nJ31xGe7/d
 aKh7J1d30OLhEEZYMtUoABVdIvUNIAlAOS557wzmKRzWSVTpa0/YMrumrbcXEIzKA2bN
 XnDH4m3CAnoYKXXm7uqjikMK+WvB1SWQEi2Iah4DrswAjhpxJEIVFXcfkX++u3eDO07G
 FHOxx5zgBkuAoXJpb1ZZJav1YEF7A6NTBitEfgyprURoxU39Zt2CQ5TaNqIA6lHo8ylT
 r4eeVpv7eyQNWeQMr4o4WTZ3/hdgGXb60wSmktziUe3r+Y4bcZXH1NM6WZvd5zvJkOYm
 HUJw==
X-Forwarded-Encrypted: i=1;
 AJvYcCX+WgvvuJIUmrJHzxgwEQWBo3Jo1xMob9lAn2l2b9UWrnCrwS0wqC2Y85Y6HAvtwFNIRmCxXg==@debbugs.gnu.org
X-Gm-Message-State: AOJu0Yy3V7N80VzIO5iA+pJFGqUdQD1vRR37ja92XU81vBv9i04Tyf9h
 ywRifrCGK+URFRHcG9XtFbOYz603GaZouN4+MgHsbxYGgQ4eICinx5aNPg==
X-Gm-Gg: ASbGncv/PvmuJeYPEn2b6kQ6nElgxlN8Lab0Cqd1UZ5E8In89ST/IveNii6MjaCR58b
 U12wQBsWiAkHMhtLajXEpzd0qD4hmTt9z40qlNDiEDDin9c+jCVdTshJ+H/gQt6wCjeVc58PCXB
 P/Ec+pZT1Uuiv1Rbxo2YjxAZrazyL5RGFYjuR/9vEckbxCKWPMNc20Agj+/55boKzUb/ujwa6pl
 Peklzh8tOz3GhtEo2DWxuuCfj9uOixujA0Eghd15pkZm5heXHoCKs9aDNgyKM4Rax8704oza1Qr
 mmGWAwuWfEYJvMh8xu91nTSBRjz7UmHCOIuJvAWd6grjTb+mpb8G3UyXUm+lTtVEw8uNzGtY+6W
 URPTvTWndnWRDQ/Ofr1+gG14+
X-Google-Smtp-Source: AGHT+IEWcuiNxQm2PV8GzAVQs8uMjakFRISfAd3OBAh9DSWk5SATwRYawowPKepk4WAqNT+Cr2xgOQ==
X-Received: by 2002:a5d:6d85:0:b0:386:3afc:14a7 with SMTP id
 ffacd0b85a97d-38da5394ebdmr2354816f8f.7.1738680125373; 
 Tue, 04 Feb 2025 06:42:05 -0800 (PST)
Received: from pro2 (p200300e0b705a00058413e49c0284fb2.dip0.t-ipconnect.de.
 [2003:e0:b705:a000:5841:3e49:c028:4fb2])
 by smtp.gmail.com with ESMTPSA id
 ffacd0b85a97d-38c5c1cfa2fsm16338908f8f.91.2025.02.04.06.42.04
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 04 Feb 2025 06:42:05 -0800 (PST)
From: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
To: Stefan Monnier <monnier@HIDDEN>
Subject: Re: bug#75886: 31.0.50; read-multiple-choice / read-key and
 input-decode-map
In-Reply-To: <jwvseotomr5.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message
 of "Tue, 04 Feb 2025 08:40:19 -0500")
References: <m2bjvsssb1.fsf@HIDDEN> <86y0ywph4b.fsf@HIDDEN>
 <jwvfrkwlyx0.fsf-monnier+emacs@HIDDEN> <m2seovy5ze.fsf@HIDDEN>
 <jwvldunp9mg.fsf-monnier+emacs@HIDDEN> <m2ed0e7sf1.fsf@HIDDEN>
 <jwvseotomr5.fsf-monnier+emacs@HIDDEN>
Date: Tue, 04 Feb 2025 15:42:04 +0100
Message-ID: <m234gtixfn.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75886
Cc: 75886 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Stefan Monnier <monnier@HIDDEN> writes:

>>>> Should read-key be changed to signal quit?
>>> I think this would break the use of `C-g` to exit from the minibuffer.
>> Too bad :-(.
>
> Of course, there's probably some way to fix the breakage, but basically,
> it's a non-trivial change messing with a "delicate" issue (meaning one
> where we currently have an undocumented balance of behaviors accumulated
> over the years, and we're not even aware of it).

Yeah :-/.

>
>> Do you mind if I replace read-event with read-key in
>> read-multiple-choice?
>
> Not at all!

Now done and closing in a minute.

>> Maybe it sticks if I put a prominent comments why.
>
> I suggest you add a test for it as well (ideally in a separate commit so
> `git revert` won't remove the test).

Slick idea, but I "trust" people to not want to drive me mad :-).





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75886; Package emacs. Full text available.

Message received at 75886 <at> debbugs.gnu.org:


Received: (at 75886) by debbugs.gnu.org; 4 Feb 2025 13:40:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 04 08:40:30 2025
Received: from localhost ([127.0.0.1]:43176 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tfJAE-0002p9-IV
	for submit <at> debbugs.gnu.org; Tue, 04 Feb 2025 08:40:30 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:44182)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
 id 1tfJAC-0002os-MM
 for 75886 <at> debbugs.gnu.org; Tue, 04 Feb 2025 08:40:29 -0500
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BCBA0100724;
 Tue,  4 Feb 2025 08:40:22 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1738676422;
 bh=8i4qjDDPuB+de7qTuem9eiQUugjBl4IZPYDAj9s28JM=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=TV1MsglTWa596UJA4sV/DUF8ko63Lca9jtL+mZMK6QMvL32GdTooCuKucI1Wt0Xc9
 2ffOBaOenhxY9VNRpRdROgzxsqpQPC/p1mNlE9LjPTBNNa5GHbcxpZv45rywQWGdkx
 z+9JdQQWs+CEEb6iU/4RRq5ZwO2fzaDrfBjyIZgTAPvUaTY+McZlwjlp/97Z+PzIp/
 Rm3RdamsyBNzZin5LRgy5jobT046DXb9pB/6yJlqQmluji9y2fZ/BgvL41RXUOaHf1
 /nfTYDt7MmFsZMIVZatz/UvLayxXfhHjRWFp4IOW1WAYXtlTSRZxudSSnpSiyQb7tm
 uqbcVwgUmieHw==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2476E100128;
 Tue,  4 Feb 2025 08:40:22 -0500 (EST)
Received: from pastel (104-195-232-86.cpe.teksavvy.com [104.195.232.86])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E9DB31204EE;
 Tue,  4 Feb 2025 08:40:21 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Gerd =?windows-1252?Q?M=F6llmann?= <gerd.moellmann@HIDDEN>
Subject: Re: bug#75886: 31.0.50; read-multiple-choice / read-key and
 input-decode-map
In-Reply-To: <m2ed0e7sf1.fsf@HIDDEN> ("Gerd =?windows-1252?Q?M=F6llmann?=
 =?windows-1252?Q?=22's?= message of "Mon, 03
 Feb 2025 20:13:38 +0100")
Message-ID: <jwvseotomr5.fsf-monnier+emacs@HIDDEN>
References: <m2bjvsssb1.fsf@HIDDEN> <86y0ywph4b.fsf@HIDDEN>
 <jwvfrkwlyx0.fsf-monnier+emacs@HIDDEN> <m2seovy5ze.fsf@HIDDEN>
 <jwvldunp9mg.fsf-monnier+emacs@HIDDEN> <m2ed0e7sf1.fsf@HIDDEN>
Date: Tue, 04 Feb 2025 08:40:19 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL -0.071 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 75886
Cc: 75886 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

>>> Should read-key be changed to signal quit?
>> I think this would break the use of `C-g` to exit from the minibuffer.
> Too bad :-(.

Of course, there's probably some way to fix the breakage, but basically,
it's a non-trivial change messing with a "delicate" issue (meaning one
where we currently have an undocumented balance of behaviors accumulated
over the years, and we're not even aware of it).

> Do you mind if I replace read-event with read-key in
> read-multiple-choice?

Not at all!

> Maybe it sticks if I put a prominent comments why.

I suggest you add a test for it as well (ideally in a separate commit so
`git revert` won't remove the test).


        Stefan





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75886; Package emacs. Full text available.

Message received at 75886 <at> debbugs.gnu.org:


Received: (at 75886) by debbugs.gnu.org; 3 Feb 2025 19:13:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 03 14:13:48 2025
Received: from localhost ([127.0.0.1]:41256 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tf1tE-00039t-Gz
	for submit <at> debbugs.gnu.org; Mon, 03 Feb 2025 14:13:48 -0500
Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]:46277)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>)
 id 1tf1tC-00039a-B6
 for 75886 <at> debbugs.gnu.org; Mon, 03 Feb 2025 14:13:47 -0500
Received: by mail-ej1-x629.google.com with SMTP id
 a640c23a62f3a-ab34a170526so753900166b.0
 for <75886 <at> debbugs.gnu.org>; Mon, 03 Feb 2025 11:13:46 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1738610020; x=1739214820; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=/LikQFHrQRzkopkopUebPaf58HLujBWb+su559ZGN5Q=;
 b=E7Zv5pU/915+o3nkJdKP1e3XRv4CthT4rwOwQPUJZmddvocgyca0d0krGHxQiKm8tS
 FAKRKc1PPfJ+cmc37AjpQUFNDLTeWf5yU1qRDvVZk7DmhunMEaRKWoKByrR7juMnft4r
 NCpx7aJmOq9h0ozFBnXuD8D/jX5Zfs6AaR3/gRvCBbQReh0eUMR4nJNZelrdRoj/ttar
 yRnSNIdCKtUNcRYh6vCXQzEGTjmk+HxSQbriuWcT8qOCYYj5GsDa8I7vj4AtVJhI4rYX
 ScutSaAT6Z2tFATUu81O44WzMqwflq/C3cauC1qLBKulh05N0U4y4P2ZZp21fYomFDV2
 3QgA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1738610020; x=1739214820;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=/LikQFHrQRzkopkopUebPaf58HLujBWb+su559ZGN5Q=;
 b=Duj+66Fi25BwMw5V2ZZvRn+uhDTxksgIrvNjkCX9yfk2ZGSShmCH/ZeSYt9NJpvIKE
 4k2OnvDMfgjUWEKxV3N6koT5Zci+n43RNZcSU8f5yvqHcjTxZ/R55lEYAZRqzENc99ZA
 quNN4vusLJ25QILpIWDX8COGlL7f1C9aG01b13+bLno5sGAat7tkOYEk+DOB5QyI5/79
 LR1P5IhqnmkzGjlY+EHMy8rqMNMlSYthZs7i701bBexpPmOWPlf3ZAI+Xfi3decgg1Q8
 h0RgwcUE2jlMS9dsAuYPzO9/r6aRdziXyJg//Ogs9hohFllt8wAQVrXX2yw+qP88y9Dk
 tQ5Q==
X-Forwarded-Encrypted: i=1;
 AJvYcCVhJaFCc0YBA3N3mQ2yqE8ZJxZ8lvCJWr6ntilu49JQVSKbJgIyP5sd2pFeWl3JCH6D4qsIGQ==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YxJ7CA/VnZ5wXq01nT+tMSADQqE+UjxWFrRrLsVVW780jy629SL
 gWESVVbLHMthvVq+xYIzh6zlZopZ9R7mKMbNLVTwJyHJVQBF4qUMiuBu2w==
X-Gm-Gg: ASbGncsC5gbFJjHntCe9m0jOmdbSUsoYOahy5OZalvw1b1ZohXbi514e3NjqcPjzWAW
 KUmRSyOEaWzbRS1DE4qkNqiiKP8isdeF/pDXSU1Eo6jIp8oQqWoq20NXMsupKC66aY6rCOtvAy7
 4BkQ+BWWyPkfs9fBLNsDKePzSDj9MdPh+DETlBEuWWNJoOosYDEm8/n+0Q6Ee2rjPZ7r7GPU2FY
 qSZsLH5vfyzJ/6zCKIor15FrGb5TP1nhLYh3YOQAMLoq3eCPlIPdycM7x4Y1JPib4Mv2oyUMyTc
 RX5sx2LBpk2IY3qS+AVxYl0LVPKaskZlY81cJW+bjoXvXr3OOkhgrBGIm7XGmMyuyV4p1jgPqUZ
 nhwy3daMsHOVMrSB+eI1jQl92
X-Google-Smtp-Source: AGHT+IG3HEuRhUyuIODZB/H+J1Lud8zkVAjq2mbzJV7YVsiXfD6m+bwtMYJwUs7iIxQJe2YFHOJ09Q==
X-Received: by 2002:a17:906:f58c:b0:aaf:86a2:651f with SMTP id
 a640c23a62f3a-ab6cfdbd07emr2285917966b.38.1738610019628; 
 Mon, 03 Feb 2025 11:13:39 -0800 (PST)
Received: from pro2 (p200300e0b7285e007cabc7148d4ef104.dip0.t-ipconnect.de.
 [2003:e0:b728:5e00:7cab:c714:8d4e:f104])
 by smtp.gmail.com with ESMTPSA id
 a640c23a62f3a-ab6e47f18e8sm796402066b.76.2025.02.03.11.13.38
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 03 Feb 2025 11:13:39 -0800 (PST)
From: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
To: Stefan Monnier <monnier@HIDDEN>
Subject: Re: bug#75886: 31.0.50; read-multiple-choice / read-key and
 input-decode-map
In-Reply-To: <jwvldunp9mg.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message
 of "Mon, 03 Feb 2025 06:13:14 -0500")
References: <m2bjvsssb1.fsf@HIDDEN> <86y0ywph4b.fsf@HIDDEN>
 <jwvfrkwlyx0.fsf-monnier+emacs@HIDDEN> <m2seovy5ze.fsf@HIDDEN>
 <jwvldunp9mg.fsf-monnier+emacs@HIDDEN>
Date: Mon, 03 Feb 2025 20:13:38 +0100
Message-ID: <m2ed0e7sf1.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75886
Cc: 75886 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Stefan Monnier <monnier@HIDDEN> writes:

>>>> This is a dark corner in Emacs, so I'm adding Stefan to the discussion
>>>> in the hope that he might have comments and ideas to suggest.
>>> Indeed `C-g` is handled (read: hard coded) at a very low-level.
>> In light of input-decode-map, it seems to me that using read-event is
>> always wrong. Should read-event be deprecated, maybe?
>
> I introduced `read-key` in the hope to replace `read-char` and
> `read-event`.  But so far it's been hard to switch existing code (some
> of those switches have been reverted, for example (and often without
> understanding the root of the problem)).
>
>> Should read-key be changed to signal quit?
>
> I think this would break the use of `C-g` to exit from the minibuffer.

Too bad :-(.

Do you mind if I replace read-event with read-key in
read-multiple-choice? Maybe it sicks if I put a prominent comments why.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75886; Package emacs. Full text available.

Message received at 75886 <at> debbugs.gnu.org:


Received: (at 75886) by debbugs.gnu.org; 3 Feb 2025 11:13:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 03 06:13:24 2025
Received: from localhost ([127.0.0.1]:37985 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1teuOJ-00006q-Nv
	for submit <at> debbugs.gnu.org; Mon, 03 Feb 2025 06:13:24 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:36461)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
 id 1teuOI-00006b-DL
 for 75886 <at> debbugs.gnu.org; Mon, 03 Feb 2025 06:13:22 -0500
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D2009100180;
 Mon,  3 Feb 2025 06:13:16 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1738581195;
 bh=4dtJH1LP2Tei3GR4cUBDoPhMsC8JSYen/s+eu23/tWc=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=f7Vrxtpd1lt1eA+2NvgOTXYs+ta9MiQxxC60uGLzxNJCYIFxf/CUkRibFIaErWgtk
 /R5jwJdQeU7UVvzy9qhZf0ag1vSN1q5EPBiUzOJZB6e6WGQfLSguETE9cWY6+b3fGN
 JI9PFrgaocPO+tXeNHkZe8eobB26J348WR3FGyur+CQJYRHH2khiPVBhsnOp0kcQ8V
 MAp8jv/C1KvDW/ss0vDyppl96cFWU1BC7bjCa/E8RRuT/B3g3DqZlzaS+Jd9T+T5Ae
 4hTugwjoxoTKT4tfB7n9rIByxxlaw44Xqhrln855aZ/quUW43AbbGlX8nhBPopMmBV
 +N/nxb9kTjyhw==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BF51610011E;
 Mon,  3 Feb 2025 06:13:15 -0500 (EST)
Received: from pastel (104-195-232-86.cpe.teksavvy.com [104.195.232.86])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9139D12055E;
 Mon,  3 Feb 2025 06:13:15 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Gerd =?windows-1252?Q?M=F6llmann?= <gerd.moellmann@HIDDEN>
Subject: Re: bug#75886: 31.0.50; read-multiple-choice / read-key and
 input-decode-map
In-Reply-To: <m2seovy5ze.fsf@HIDDEN> ("Gerd =?windows-1252?Q?M=F6llmann?=
 =?windows-1252?Q?=22's?= message of "Mon, 03
 Feb 2025 06:03:49 +0100")
Message-ID: <jwvldunp9mg.fsf-monnier+emacs@HIDDEN>
References: <m2bjvsssb1.fsf@HIDDEN> <86y0ywph4b.fsf@HIDDEN>
 <jwvfrkwlyx0.fsf-monnier+emacs@HIDDEN> <m2seovy5ze.fsf@HIDDEN>
Date: Mon, 03 Feb 2025 06:13:14 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL -0.072 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 75886
Cc: 75886 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

>>> This is a dark corner in Emacs, so I'm adding Stefan to the discussion
>>> in the hope that he might have comments and ideas to suggest.
>> Indeed `C-g` is handled (read: hard coded) at a very low-level.
> In light of input-decode-map, it seems to me that using read-event is
> always wrong. Should read-event be deprecated, maybe?

I introduced `read-key` in the hope to replace `read-char` and
`read-event`.  But so far it's been hard to switch existing code (some
of those switches have been reverted, for example (and often without
understanding the root of the problem)).

> Should read-key be changed to signal quit?

I think this would break the use of `C-g` to exit from the minibuffer.


        Stefan





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75886; Package emacs. Full text available.

Message received at 75886 <at> debbugs.gnu.org:


Received: (at 75886) by debbugs.gnu.org; 3 Feb 2025 05:04:01 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 03 00:04:01 2025
Received: from localhost ([127.0.0.1]:37230 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1teocq-0001Sq-TS
	for submit <at> debbugs.gnu.org; Mon, 03 Feb 2025 00:04:01 -0500
Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]:55675)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>)
 id 1teoco-0001SV-8g
 for 75886 <at> debbugs.gnu.org; Mon, 03 Feb 2025 00:03:59 -0500
Received: by mail-ej1-x632.google.com with SMTP id
 a640c23a62f3a-ab6ed8a5a04so637291266b.3
 for <75886 <at> debbugs.gnu.org>; Sun, 02 Feb 2025 21:03:58 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1738559032; x=1739163832; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=vffoCL/xpKtMS1ihKBpIfjsVGg+U6RMUBLqfuZW9ZCg=;
 b=ZqX9G/66jQ1zQwPwdPUln4xECv9kfDmmnuKCTCoc8/B9ydb8Jl6YrMnKb8fREpye4V
 QXj4Hp7RL0N1oUtxrLXzHAqoM7FAGCiqCD2xVnwzQbIvz1c5pI8WiaiQ/WhoTjCcf6u1
 9r2SsLN+7LMw4oQ5yPnGHrhPq+WjcHT4kW3lJR7e5gXyEzGYl/576jftZgO/B8CNhhDk
 fsZmfL446KSL9lz3Nlog3FXOQxZx/IuOQbyl7CXb3INR8InYL9JJT4tu+XZZ+IZZLA9c
 UFiZyCQss1sp5CJ/kJzz2KvQqMvd69ZU0nwR4AeZxASA9uqk6Ly6qLtPzKwyWJA6NSuc
 qcGw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1738559032; x=1739163832;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=vffoCL/xpKtMS1ihKBpIfjsVGg+U6RMUBLqfuZW9ZCg=;
 b=aNSRQVHbkaMChr2JAG6ZFy4FkBaugAgKhLlc89rkvhJPDV2dDOksBFQly8P4Hl3Nbe
 PTtxZphwFThYYXNhgJ9nr2fMnOYvEzPU4kbxqfxrA4voE3SuPneFhkFosTV6EOeR0qKW
 9lQvi/qML32ZyOZKxHQOxHuWlQA1juTtNC74Sjz1biI7redvhTGiHKiWWBbGd3Kkf/ns
 xNjBakkYKBL2NZIgLTrGhLQ89A7bQv2w9PPvX/CJTZCDKiEHdYcSPHsqQ5cgCxQz9nx4
 M6w28TtpYKN2IFsFbS40RbRgOoEmhuws69tNo6u9fUksB3rAMi3K9qkVGhHHWSZYVmz1
 /Myg==
X-Forwarded-Encrypted: i=1;
 AJvYcCWbb37gaZC/1PeBxv3oc9TLFM4o0i5vpecbVGsa78+0e4LzjEk/9k1rrMswbo0vb2iNGev47g==@debbugs.gnu.org
X-Gm-Message-State: AOJu0Yw0tZ37DdcEUXfBtxdkxOaUj89/3mZLCWzqWBCEanabJPFZ4KHS
 tgcrh3uyEI+p2whQbHXdzGAJ14KXoHIyWd1IJiPokWmf8Vv3cZKFCiT/Jg==
X-Gm-Gg: ASbGncsdtf/Q4F+MnXrte6EZ4FKYn8GoTPRvnbQz0nxJyIWP61aimEbZtCe2B3l0Xdj
 R/jIJ/KFvDQbyZKR3jN1NmyWNJYC9FaDhSG7AZBUAmzK72YWuTSPAE+uH7s8P2hNga690MCifHV
 TS6Ch9GIK+SyDVdDqwdV5r46icKRQpsH7X6gUEN7yngQbevzl0zlul5VXjCm2WQ2QIKieB7Ozsy
 nLlSKJS6aZpuK/0cipCapRpccJBYBOxiqaqWr6zfjMNQEp7r5dXjxckRb9RJs0+cVds4Gheqebr
 r665ybNwgUaanaEJQUu/YIMeER1J1FLbNOaMe9RiYZqct21YuGKsVVs73Z3gFtNQEwO2bLNr0A8
 St8If33S45EWwG030SAiw7i0R
X-Google-Smtp-Source: AGHT+IHNgbxwApjA6CNMdmQhbs/i7TdNsAukzcOPoqqpfbhWmjDNaix1yH2jntZL+1c8gvvZM/Gnzw==
X-Received: by 2002:a17:907:6ea7:b0:a9e:b150:a99d with SMTP id
 a640c23a62f3a-ab6cfc87b20mr2361655666b.5.1738559031484; 
 Sun, 02 Feb 2025 21:03:51 -0800 (PST)
Received: from pro2 (p200300e0b7285e007cabc7148d4ef104.dip0.t-ipconnect.de.
 [2003:e0:b728:5e00:7cab:c714:8d4e:f104])
 by smtp.gmail.com with ESMTPSA id
 a640c23a62f3a-ab6e47a7dcfsm691831266b.17.2025.02.02.21.03.50
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 02 Feb 2025 21:03:50 -0800 (PST)
From: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
To: Stefan Monnier <monnier@HIDDEN>
Subject: Re: bug#75886: 31.0.50; read-multiple-choice / read-key and
 input-decode-map
In-Reply-To: <jwvfrkwlyx0.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message
 of "Sun, 02 Feb 2025 18:25:50 -0500")
References: <m2bjvsssb1.fsf@HIDDEN> <86y0ywph4b.fsf@HIDDEN>
 <jwvfrkwlyx0.fsf-monnier+emacs@HIDDEN>
Date: Mon, 03 Feb 2025 06:03:49 +0100
Message-ID: <m2seovy5ze.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75886
Cc: 75886 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Stefan Monnier <monnier@HIDDEN> writes:

>
>>> Without input-decode-map for C-g.
>>> 
>>> #+begin_src emacs-lisp
>>>   (read-key) ;; press C-g
>>>   => Quit
>>> #+end_src
>
> That's not what I see here.  I get 7 (aka `C-g`) in an `emacs -Q`.

Right, sorry. I corrected that else-mail.

>
>> This is a dark corner in Emacs, so I'm adding Stefan to the discussion
>> in the hope that he might have comments and ideas to suggest.
>
> Indeed `C-g` is handled (read: hard coded) at a very low-level.

In light of input-decode-map, it seems to me that using read-event is
always wrong. Should read-event be deprecated, maybe?

Should read-key be changed to signal quit? I find it a bit strange that
one can write Lisp that one cannot C-g out.





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75886; Package emacs. Full text available.

Message received at 75886 <at> debbugs.gnu.org:


Received: (at 75886) by debbugs.gnu.org; 2 Feb 2025 23:26:01 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 02 18:26:01 2025
Received: from localhost ([127.0.0.1]:36694 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tejLl-0004pV-GP
	for submit <at> debbugs.gnu.org; Sun, 02 Feb 2025 18:26:01 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:14405)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
 id 1tejLi-0004pB-Bf
 for 75886 <at> debbugs.gnu.org; Sun, 02 Feb 2025 18:25:59 -0500
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A2826440A4D;
 Sun,  2 Feb 2025 18:25:52 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1738538751;
 bh=uMcaBI9E69xnvmbUbE0a9plNSpRUtyG/qRdspjxMgQY=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=Q1PeBl2MKS2y7dcs3T0hPj1ljAJXzeXx5RIxux0EIJ634lvk/kVRlkF2xHBoJLk2p
 BoaSAssZ7Ml22SHqf37CuRv99K5d08gdWO29+UY5EpGcNxfpRiqe6bGVRUovDQRaSp
 gkANc4cZvVqM1qQvDkmRNXZAhW28+b63GteR2urSwM/6GjgfXqYxdy4wo5sZ2xqLfd
 OYJY4V09PjXPX+FL6u1JTueyYBJJ41eZi7M9/7IplQhaCs9u98/vSMMkQlTP3/3Pcr
 lSqvDIKqqj9mogXENnitzaiimdhRXOUhr//TovxOsDf46XRLcqYX9agNBh0Fs9MZmI
 Wgd4QL2hCwsUg==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 805D7440A27;
 Sun,  2 Feb 2025 18:25:51 -0500 (EST)
Received: from alfajor (104-195-232-86.cpe.teksavvy.com [104.195.232.86])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4748F120717;
 Sun,  2 Feb 2025 18:25:51 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#75886: 31.0.50; read-multiple-choice / read-key and
 input-decode-map
In-Reply-To: <86y0ywph4b.fsf@HIDDEN> (Eli Zaretskii's message of "Mon, 27 Jan
 2025 14:37:40 +0200")
Message-ID: <jwvfrkwlyx0.fsf-monnier+emacs@HIDDEN>
References: <m2bjvsssb1.fsf@HIDDEN> <86y0ywph4b.fsf@HIDDEN>
Date: Sun, 02 Feb 2025 18:25:50 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL -0.002 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 75886
Cc: Gerd =?windows-1252?Q?M=F6llmann?= <gerd.moellmann@HIDDEN>,
 75886 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

>> I am running emacs -nw on a terminal supporting the Kitty Keyboard
>> Protocol, and I am using the kkp package from MELPA to make use of the
>> additional keys KKP makes possible to use.
>> 
>> Must know:
>> 
>> 1. Kkp works by adding entries to input-decode-map, among them a binding
>> for C-g, which arrives from the terminal as an escape sequence which
>> input-decode-map maps to ^G.
>> 
>> 2. read-event does not consult input-decode-map:
>> 
>>   #+begin_src eemacs-lisp
>>     (read-event) ;; press C-g
>>     => 27
>>  [103;5u
>>   #+end_src
>> 
>> 3. read-multiple-choice uses read-event.
>> 
>> Bug 1:
>> 
>> Modify a buffer and C-x k it. A prompt appears asking what to do. The
>> prompt comes from read-multiple-choice. Press C-g. That results in
>> "invalid choice" because read-multiple-choice gets (part of) the escape
>> sequence the terminal sends from read-event.

`read_char` usually doesn't return `C-g` but signals `quit` instead.
IOW the handling that makes `C-g` abort `C-x k` and friends is done at
a very low-level.  IIRC whether it (should) return(s) `C-g` or signal(s)
quit depends on `immediate_quit` which is not reflected in ELisp.

>> Without input-decode-map for C-g.
>> 
>> #+begin_src emacs-lisp
>>   (read-key) ;; press C-g
>>   => Quit
>> #+end_src

That's not what I see here.  I get 7 (aka `C-g`) in an `emacs -Q`.

> This is a dark corner in Emacs, so I'm adding Stefan to the discussion
> in the hope that he might have comments and ideas to suggest.

Indeed `C-g` is handled (read: hard coded) at a very low-level.


        Stefan





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75886; Package emacs. Full text available.

Message received at 75886 <at> debbugs.gnu.org:


Received: (at 75886) by debbugs.gnu.org; 27 Jan 2025 12:38:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 27 07:38:08 2025
Received: from localhost ([127.0.0.1]:59790 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tcONU-0005pi-33
	for submit <at> debbugs.gnu.org; Mon, 27 Jan 2025 07:38:08 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:56192)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tcONR-0005p5-TO
 for 75886 <at> debbugs.gnu.org; Mon, 27 Jan 2025 07:38:06 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1tcONL-0005TN-Ld; Mon, 27 Jan 2025 07:37:59 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=Ziril0lBSUf/C47aJcvlTUmAP7HTqHJooQBhXIhjmbU=; b=iKo7CjGA7Yxt3Id0juxP
 ZKHX7ifvjp1o4fgGWya5NUHg2tBMXMgGtifMELyufXV/AJC0av+R7bEgSantnFp3aV2I7RAUX3fU6
 yGSw1zT44+R6uJkkvL+/iE6B3r87YFoJ0Y9Gx6olaCoO70noyznSi+fJ3HXZv2kq8rOGP+vbGrN93
 yqD+iAf7RxZYEN55ihHDFYcmh8wMnUMDMFMQBuyABrDhJwaxsnIw3lE3KAuDpmNl8Hmy0ILnJti8m
 pZiMP/4DEFs+Xk22JbKSDgRhBjlwh+zxsFCf1QvPIH6XwCo54/IIjNV/ElFsBJoUaI3LtNX0/V9yt
 ySw+/VMvPVjKRg==;
Date: Mon, 27 Jan 2025 14:37:40 +0200
Message-Id: <86y0ywph4b.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Gerd =?iso-8859-1?Q?M=F6llmann?= <gerd.moellmann@HIDDEN>,
 Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <m2bjvsssb1.fsf@HIDDEN> (message from Gerd
 =?iso-8859-1?Q?M=F6llmann?= on Mon, 27 Jan 2025 07:07:46 +0100)
Subject: Re: bug#75886: 31.0.50;
 read-multiple-choice / read-key and input-decode-map
References: <m2bjvsssb1.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 75886
Cc: 75886 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Gerd Möllmann <gerd.moellmann@HIDDEN>
> Date: Mon, 27 Jan 2025 07:07:46 +0100
> 
> I am running emacs -nw on a terminal supporting the Kitty Keyboard
> Protocol, and I am using the kkp package from MELPA to make use of the
> additional keys KKP makes possible to use.
> 
> Must know:
> 
> 1. Kkp works by adding entries to input-decode-map, among them a binding
> for C-g, which arrives from the terminal as an escape sequence which
> input-decode-map maps to ^G.
> 
> 2. read-event does not consult input-decode-map:
> 
>   #+begin_src eemacs-lisp
>     (read-event) ;; press C-g
>     => 27
>  [103;5u
>   #+end_src
> 
> 3. read-multiple-choice uses read-event.
> 
> Bug 1:
> 
> Modify a buffer and C-x k it. A prompt appears asking what to do. The
> prompt comes from read-multiple-choice. Press C-g. That results in
> "invalid choice" because read-multiple-choice gets (part of) the escape
> sequence the terminal sends from read-event.
> 
> Bug 2:
> 
> I would have thought that replacing read-event with read-key in
> reac-multiple-choice would have solved this, because read-key consults
> input-decode-map. But that is not the case because read-key behaves
> differently if input-decode-map has an entry for C-g or not.
> 
> Without input-decode-map for C-g.
> 
> #+begin_src emacs-lisp
>   (read-key) ;; press C-g
>   => Quit
> #+end_src
> 
> With input-decode-map setting for C-g:
> 
> #+begin_src emacs-lisp
>   (read-key) ;; press C-g
>   => 7
> #+end_src
> 
> Sorry for lumping these two bugs together, but I think it's easier to
> understand this way.

This is a dark corner in Emacs, so I'm adding Stefan to the discussion
in the hope that he might have comments and ideas to suggest.

Thanks.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75886; Package emacs. Full text available.

Message received at 75886 <at> debbugs.gnu.org:


Received: (at 75886) by debbugs.gnu.org; 27 Jan 2025 08:04:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 27 03:04:10 2025
Received: from localhost ([127.0.0.1]:59182 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tcK6L-0003OL-PH
	for submit <at> debbugs.gnu.org; Mon, 27 Jan 2025 03:04:10 -0500
Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]:54595)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>)
 id 1tcK6J-0003Nn-4z
 for 75886 <at> debbugs.gnu.org; Mon, 27 Jan 2025 03:04:07 -0500
Received: by mail-wm1-x333.google.com with SMTP id
 5b1f17b1804b1-4361815b96cso26641055e9.1
 for <75886 <at> debbugs.gnu.org>; Mon, 27 Jan 2025 00:04:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1737965041; x=1738569841; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=FwBf6zDyAlPAfahphCX2Hnj4z10mkp+oEjCHMqKZ4lA=;
 b=F8FRjUXSHv8wAYmMbeh+k5OOLYImPJHbukGg7iDcA1hHHL3u4Ckp8QikTGZTHDuo6h
 ge4JDA+QDm1uiUn3W5m0VxAUaAv7CiVzfo3/ry0MOwHEyL1eZb90O5AAOtoTzEqQzQBK
 s80loWUgmWAsY+zytW06KVYKiyXtfQEoinJnwCh6h8V362uWoSJdMLWAAznsxfc3rAuZ
 dgBjKwNFb+QlN28ZpXtn94dpir6FL+94BdYdBP1gieeAjAJ+ISwBDEMtPcqO0Jg/wH2n
 nVGaKwdgs/R/P7ZBqTvxumR2f33d7r3OiZ7Z76J1xnhUXLUeRHNVZywZx0sbxxZM345E
 KxSQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1737965041; x=1738569841;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=FwBf6zDyAlPAfahphCX2Hnj4z10mkp+oEjCHMqKZ4lA=;
 b=f31gUM9zjZWuQroqIIT7tXlZUxWo4mAjk5BaWwdUK7FnRDqchfFGUHe970IjR1Rd9m
 TVcK2rd/EgyPAeCNS3ffuerF4Mj0vJ6ecXEI7ZPaGs5oqiBq/qQX0i9hM/XeS33Wl0z8
 5LNIMJN3M3BeVkP/TCYlgdReGfOpUh3Ohn7ynT31XT+xXRNVkdwo8fOqVxr0R/QPYind
 y2TYp5sPAl2YuoRiWp+dpNXheEDGt2V2bUtv6RV9uxxs8Cr/9FdesbY8QB+5n1DUgCJu
 WGMzLtpGHUSqW3H9DCVmZprVNtWdPoEMme44qFr5zo/DToY5a/IgJAKGauA+io3bk1y5
 ssmg==
X-Gm-Message-State: AOJu0YwoQ7utkZ3ppPRkqiBAbbk+KMTIsU02PSYwKgWp5LyyYHK8wpAW
 vNzdMZD11zze7bfIZ3DtYopBvR+YlfBzvKf7MvvmMA0lgiYNzvpabC2TIA==
X-Gm-Gg: ASbGncuXcBI8041DLOcxpfUNftSGhmtREhMPBE1JSkUwNr/FrlIEPyI3cwP1Lo+1Oq1
 A6JCfbzS7VpjxZXQj5mEjaJEJawvrklJyyyoYFINOa6Db+44UA9HoAEUdFtHjDEFpzpZIRUHIJq
 ISt1dLOfYVDYPoMrAHL6wlk5VwbXBIlCO+X5xnblYcCsTi9qBupXUKGitwWZ7+470NxsYAqa4kj
 ExoJnPYaXJ0o4e4vFaYbYzM2M020AyYr66AEBMpCKiT17210E/17O6dL65DEcYf3UCcg64jYWZm
 /iFsMBBImPOqIg+F2ZS2xFJ8h4PvngcJWJvDaTbFo7x++Oygi1Dzq6X6JeFZ31gwDoAj05atOk4
 kgGPhJzb9dhx1bw==
X-Google-Smtp-Source: AGHT+IHFuB8r5tiCaRi8izDt6aQbc34G87uZEUCQc2TpxFaJZNCSeZdW4VcNVvWPgJ5L9jEdZU7GPw==
X-Received: by 2002:a7b:cb43:0:b0:434:fafe:edb with SMTP id
 5b1f17b1804b1-43891427757mr332358755e9.24.1737965040563; 
 Mon, 27 Jan 2025 00:04:00 -0800 (PST)
Received: from pro2 (p200300e0b74c5b0091beae7ba24add4f.dip0.t-ipconnect.de.
 [2003:e0:b74c:5b00:91be:ae7b:a24a:dd4f])
 by smtp.gmail.com with ESMTPSA id
 5b1f17b1804b1-438bd4d2a82sm121428525e9.36.2025.01.27.00.03.59
 for <75886 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 27 Jan 2025 00:04:00 -0800 (PST)
From: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
To: 75886 <at> debbugs.gnu.org
Subject: Re: bug#75886: 31.0.50; read-multiple-choice / read-key and
 input-decode-map
In-Reply-To: <m24j1kd9p0.fsf@HIDDEN> ("Gerd =?utf-8?Q?M=C3=B6llmann=22'?=
 =?utf-8?Q?s?= message of "Mon, 27 Jan 2025 07:58:51 +0100")
References: <m2bjvsssb1.fsf@HIDDEN> <m24j1kd9p0.fsf@HIDDEN>
Date: Mon, 27 Jan 2025 09:03:59 +0100
Message-ID: <m21pwod6og.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 75886
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes:

> Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes:
>
>> I would have thought that replacing read-event with read-key in
>> reac-multiple-choice would have solved this, because read-key consults
>> input-decode-map. But that is not the case because read-key behaves
>> differently if input-decode-map has an entry for C-g or not.
>>
>> Without input-decode-map for C-g.
>>
>> #+begin_src emacs-lisp
>>   (read-key) ;; press C-g
>>   =3D> Quit
>> #+end_src
>>
>>
>> With input-decode-map setting for C-g:
>>
>> #+begin_src emacs-lisp
>>   (read-key) ;; press C-g
>>   =3D> 7
>> #+end_src
>>
>> Sorry for lumping these two bugs together, but I think it's easier to
>> understand this way.
>
> I have to correct that, I confused read-event and read-key.
>
> read-key never quits, it always returns ^G, input-decode-map or not
>
> #+begin_src emacs-lisp
>   (read-key) ;; press C-g
>   =3D> 7
> #+end_src
>
>
> read-event quits if not input-decode-map
>
> #+begin_src emacs-lisp
>   (read-event) ;; press C-g
>   =3D> Quit
> #+end_src

The attached patch fixes things for me. It changes only
read-multiple-choice because read-key not quitting on C-g seems to have
been that way already in Emacs 30.


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
 filename=0001-Use-read-key-in-read-multiple-choice-bug-75886.patch

From 0dbe8060b375e317a0e2709141cda7ff6ea03a76 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gerd=20M=C3=B6llmann?= <gerd@HIDDEN>
Date: Mon, 27 Jan 2025 08:58:30 +0100
Subject: [PATCH] Use read-key in read-multiple-choice (bug#75886)

* lisp/emacs-lisp/rmc.el (read-multiple-choice--short-answers):
Use read-key instead of read-event because read-event doesn't
use input-decode-map.
---
 lisp/emacs-lisp/rmc.el | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/lisp/emacs-lisp/rmc.el b/lisp/emacs-lisp/rmc.el
index ad3c86cfd00..63f97fb006e 100644
--- a/lisp/emacs-lisp/rmc.el
+++ b/lisp/emacs-lisp/rmc.el
@@ -219,8 +219,11 @@ read-multiple-choice--short-answers
                                     (car elem)))
                             prompt-choices)))
                   (condition-case nil
-                      (let ((cursor-in-echo-area t))
-                        (read-event))
+                      (let ((cursor-in-echo-area t)
+                            (key (read-key)))
+                        (when (eq key ?\C-g)
+                          (signal 'quit nil))
+                        key)
                     (error nil))))
           (if (memq (car-safe tchar) '(touchscreen-begin
                                        touchscreen-end
-- 
2.48.1


--=-=-=--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75886; Package emacs. Full text available.

Message received at 75886 <at> debbugs.gnu.org:


Received: (at 75886) by debbugs.gnu.org; 27 Jan 2025 06:59:01 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 27 01:59:01 2025
Received: from localhost ([127.0.0.1]:59064 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tcJ5J-0005ZJ-3t
	for submit <at> debbugs.gnu.org; Mon, 27 Jan 2025 01:59:01 -0500
Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:52709)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>)
 id 1tcJ5H-0005Z1-6G
 for 75886 <at> debbugs.gnu.org; Mon, 27 Jan 2025 01:58:59 -0500
Received: by mail-wm1-x32e.google.com with SMTP id
 5b1f17b1804b1-436341f575fso43767635e9.1
 for <75886 <at> debbugs.gnu.org>; Sun, 26 Jan 2025 22:58:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1737961132; x=1738565932; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:user-agent:message-id:date
 :references:in-reply-to:subject:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=giSEx0B/TbgkXF7E60hVyBYTl/l2IofwGvozLjrJtu4=;
 b=X9c8Ve586wINjg3Dhg3tivCzEfE380M/CIjeWPBaesVyhpOQAStm/EZdMrkUAwmZRH
 22auCnuPm58hcnt+lMDCTxCOH/0ZOxXEZO2NycHmytXKgiZgBXhL0M1mqlQFU4UjnTvL
 LgNhcrtYaCNfbbjOZNerspMSzBqtGDjAczIq36JieC35yG5HLWVeo7QQBFGI5ho8mwd2
 KHnomvD1DGPbYPGJUeFV892eA4X5226NwxgWI9l3KFNPefg+wn0zCePvbAgEvTDc9P7U
 gFfioDpB9ivo3LsEWH2EIgDmHBfIAQa3OzBPpU3GDXEQxF3zWjneXq5EaUCHmjLN7KwZ
 TKbg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1737961132; x=1738565932;
 h=content-transfer-encoding:mime-version:user-agent:message-id:date
 :references:in-reply-to:subject:to:from:x-gm-message-state:from:to
 :cc:subject:date:message-id:reply-to;
 bh=giSEx0B/TbgkXF7E60hVyBYTl/l2IofwGvozLjrJtu4=;
 b=Po53M8QpVHdW7gjyixNM3oco1bYs1d8J5DSrkLmddW6G2mtc9QMMfML3PQIkWHZpQ1
 fX8G0LvjJTq0j5SMFxKvUkOSBlx76Z2tjoTvS+5/H52EfWUc97M7zvExws46cePlT1ZT
 RhK5vJ3rORNVkUGlPcTznxyaDUOA60J7Gt8fb3mY+W53kCfsOYCFNy0dIMoAnvdAhicy
 /RA8NuZjs+4TYxr72smhzCCavRINRxVCV7tTMp8dFzk9Kd2aZbzW02it2lE+pTAtF72o
 WFImpzpXSMbDj96qq6r6Yi/cBY2CvATMj5RZOqbR71OyraXBE4tATJR2QxhGd7MK5LcL
 BR4w==
X-Gm-Message-State: AOJu0YygplYawB/cYlwmiHJE4BUA/DNzGuDg85x3W2OEG7NMfKWfz4uM
 InrOlS2b7fisKFyUmGmhMqC/FkUKaRb4JxJVzlHEIrNh6IwgPWoQfJoL0A==
X-Gm-Gg: ASbGncuzmep3c2delJAtYfyniqXACQfylOdhnsOWna3IGTbNAfax9fCJ3G/6pQTKcVQ
 6dz0u0AawZebCtaxtrkFIRYJ70yffJBZQHUpx2JbJIjEdT9tIIt666W1DByChua46wbvHrQU3AA
 O3QvYfXHOdzDwUWitPyoBDrUUsQ+WCXrc5BzxdNyKCna/GFILUcYgSFjVz6FGi1dTDFfVuM9h1f
 O8uTCEL8ayWwRCjBY6DlGCjsOMhc+bxFkgBw+v6RFK9wugl1J4nz6iDovacxGNldbHrMdmsWa5c
 sRnqibfyRFYiPNoypmomt7W7thBZupLFKlu7N+dcd5XnAqjKzVfEOmUwmyvCQ4sXttKsqx1rZHT
 s4Mk9cnzQm3FxuQ==
X-Google-Smtp-Source: AGHT+IFPw3SjqU9n+LOBrkjewnHu1T0lcu8lTW23y3u499RTQquEA5sMCiAGCVdeB7B/ge52Kz3PCg==
X-Received: by 2002:a05:600c:3b0f:b0:436:e86e:e4ab with SMTP id
 5b1f17b1804b1-4389146e66cmr414030985e9.30.1737961132447; 
 Sun, 26 Jan 2025 22:58:52 -0800 (PST)
Received: from pro2 (p200300e0b74c5b0091beae7ba24add4f.dip0.t-ipconnect.de.
 [2003:e0:b74c:5b00:91be:ae7b:a24a:dd4f])
 by smtp.gmail.com with ESMTPSA id
 5b1f17b1804b1-438bd507d60sm119852045e9.18.2025.01.26.22.58.51
 for <75886 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 26 Jan 2025 22:58:52 -0800 (PST)
From: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
To: 75886 <at> debbugs.gnu.org
Subject: Re: bug#75886: 31.0.50; read-multiple-choice / read-key and
 input-decode-map
In-Reply-To: <m2bjvsssb1.fsf@HIDDEN> ("Gerd =?utf-8?Q?M=C3=B6llmann=22'?=
 =?utf-8?Q?s?= message of "Mon, 27 Jan 2025 07:07:46 +0100")
References: <m2bjvsssb1.fsf@HIDDEN>
Date: Mon, 27 Jan 2025 07:58:51 +0100
Message-ID: <m24j1kd9p0.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 75886
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes:

> I would have thought that replacing read-event with read-key in
> reac-multiple-choice would have solved this, because read-key consults
> input-decode-map. But that is not the case because read-key behaves
> differently if input-decode-map has an entry for C-g or not.
>
> Without input-decode-map for C-g.
>
> #+begin_src emacs-lisp
>   (read-key) ;; press C-g
>   =3D> Quit
> #+end_src
>
>
> With input-decode-map setting for C-g:
>
> #+begin_src emacs-lisp
>   (read-key) ;; press C-g
>   =3D> 7
> #+end_src
>
> Sorry for lumping these two bugs together, but I think it's easier to
> understand this way.

I have to correct that, I confused read-event and read-key.

read-key never quits, it always returns ^G, input-decode-map or not

#+begin_src emacs-lisp
  (read-key) ;; press C-g
  =3D> 7
#+end_src

read-event quits if not input-decode-map

#+begin_src emacs-lisp
  (read-event) ;; press C-g
  =3D> Quit
#+end_src




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75886; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 27 Jan 2025 06:08:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 27 01:08:03 2025
Received: from localhost ([127.0.0.1]:58972 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tcIHz-000321-84
	for submit <at> debbugs.gnu.org; Mon, 27 Jan 2025 01:08:03 -0500
Received: from lists.gnu.org ([2001:470:142::17]:53518)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>)
 id 1tcIHw-00031Q-Ik
 for submit <at> debbugs.gnu.org; Mon, 27 Jan 2025 01:08:01 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <gerd.moellmann@HIDDEN>)
 id 1tcIHp-0002jU-JG
 for bug-gnu-emacs@HIDDEN; Mon, 27 Jan 2025 01:07:53 -0500
Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <gerd.moellmann@HIDDEN>)
 id 1tcIHo-0007I2-35
 for bug-gnu-emacs@HIDDEN; Mon, 27 Jan 2025 01:07:53 -0500
Received: by mail-wm1-x335.google.com with SMTP id
 5b1f17b1804b1-436249df846so26145285e9.3
 for <bug-gnu-emacs@HIDDEN>; Sun, 26 Jan 2025 22:07:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1737958070; x=1738562870; darn=gnu.org;
 h=mime-version:message-id:date:subject:to:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=szzBtyleCj7XlUNrGyc/5I/kUNOJPq7IyErXetJU8FM=;
 b=Vs044/2HvxsIVCtbimLHg0Ln2+Sf0En6W1k+WQwgAfac+jztM5UttnxkxT99I8MIIm
 sObHJNWuCsVgJMWW/BAXNyNieHXl+5BGAAHciquKw4ojtx2ewD+Hkevly3eUXyExkDy3
 GYzdfKlULQapOvFhMAbK+7jS4Ng94jeDe+L1OZ2jU6iEy7FmswgsPgeJyoZSWFsdYrwP
 ok9v32ExfeXNAQcQaYoeXVuI7P6jQyai5T04ZVsxusczrtIgHxLuterAuWxFN4GuqGhu
 AFHrqtrOfMJhzUjih1wIUOQRTjINdTF2iw5AE76KL+DiUmfpSsMuqeTNZ5OvLqgt7HQS
 F9pQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1737958070; x=1738562870;
 h=mime-version:message-id:date:subject:to:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=szzBtyleCj7XlUNrGyc/5I/kUNOJPq7IyErXetJU8FM=;
 b=FjbJZwoUvMb/rnejsaIG48NqU7sTi0mJriYmcGlVYbeGDDzJSb7sxI/dfF6TEcnpwR
 NdO/hFO7nzW2+ACAoJECSnnS9EgI4dW6q6BsDKdgTUFolvOmvFM5Ky+QU1tS9Kb8pVdj
 2imtiN1lXSI0hMhVElCLPcVaC9dmibjQz5F+gSvbtdcunYPDjQYvPzde4lW8GFEwD5cf
 558xCyAAWA+bUEGs+H15vaNs0bSQm1pVyHTpkqb6+lKjs0+IEJ4TpnQ1vTqCAkTjuA/L
 LSqYHjcxBr50RGjW8PKCyEsZG0TQgQCugZji/fTSlXiXQeLoSPvKE9LdTf63u5W69Vca
 o0Sg==
X-Gm-Message-State: AOJu0YwtXDBb2K4XAqmMn0cHtIHED6fhru7QwO6zMFSruTw3K9coZO0L
 E+7OHGRpGL8FZGNtN2daa+/UjIk3XOWoX05in/DiAOwyTTXQVHwnSSqXiQ==
X-Gm-Gg: ASbGncuFsPzyN118hs98iOfeN+f0tHUNRUEPKE8UDwmuQOk+ltOF/ZNymhaNvZDRORk
 3nwApBH3RMZLb80OqZutv3MYl0hKiSr928SconLtDHT6IoJwVkc0JgJvNcF6r8HOeLykzWg1Z3J
 9kRv3VFCSL6TZqoIj5d885ShbYsc1cwizZhUnu0H0uXX5dw6pmqgqvFipqGpAqdZoZDFjFzrnZG
 w3g/SQ5BYCCdTIunfOEkjkCadulztTuJFVlOQFno5t4q80d9If/jIEYOqTWHY4ufDAIEkoEFYzo
 TvOlUw5dxZwZgrgmOgBQ1PmVi92sPTM/Rh3VhDSZ+LlbtYrl4TBjmjyAch0SxqOXFYbOMStt6Lw
 0YusvRmiBEC7lDw==
X-Google-Smtp-Source: AGHT+IEWKpxoN5XM4kE5QxdC3HNirinsRjgJEydTUGi2HGESiAyZ5cwnZYsyHO753wnn75VWBD3SLw==
X-Received: by 2002:a05:600c:450d:b0:436:840b:261c with SMTP id
 5b1f17b1804b1-438914340afmr334192605e9.19.1737958069591; 
 Sun, 26 Jan 2025 22:07:49 -0800 (PST)
Received: from pro2 (p200300e0b74c5b0091beae7ba24add4f.dip0.t-ipconnect.de.
 [2003:e0:b74c:5b00:91be:ae7b:a24a:dd4f])
 by smtp.gmail.com with ESMTPSA id
 5b1f17b1804b1-438bd4d3dbcsm121161585e9.40.2025.01.26.22.07.47
 for <bug-gnu-emacs@HIDDEN>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 26 Jan 2025 22:07:48 -0800 (PST)
From: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 31.0.50; read-multiple-choice / read-key and input-decode-map
X-Debbugs-Cc: 
Date: Mon, 27 Jan 2025 07:07:46 +0100
Message-ID: <m2bjvsssb1.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=2a00:1450:4864:20::335;
 envelope-from=gerd.moellmann@HIDDEN; helo=mail-wm1-x335.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

I am running emacs -nw on a terminal supporting the Kitty Keyboard
Protocol, and I am using the kkp package from MELPA to make use of the
additional keys KKP makes possible to use.

Must know:

1. Kkp works by adding entries to input-decode-map, among them a binding
for C-g, which arrives from the terminal as an escape sequence which
input-decode-map maps to ^G.

2. read-event does not consult input-decode-map:

  #+begin_src eemacs-lisp
    (read-event) ;; press C-g
    => 27
 [103;5u
  #+end_src

3. read-multiple-choice uses read-event.

Bug 1:

Modify a buffer and C-x k it. A prompt appears asking what to do. The
prompt comes from read-multiple-choice. Press C-g. That results in
"invalid choice" because read-multiple-choice gets (part of) the escape
sequence the terminal sends from read-event.

Bug 2:

I would have thought that replacing read-event with read-key in
reac-multiple-choice would have solved this, because read-key consults
input-decode-map. But that is not the case because read-key behaves
differently if input-decode-map has an entry for C-g or not.

Without input-decode-map for C-g.

#+begin_src emacs-lisp
  (read-key) ;; press C-g
  => Quit
#+end_src

With input-decode-map setting for C-g:

#+begin_src emacs-lisp
  (read-key) ;; press C-g
  => 7
#+end_src

Sorry for lumping these two bugs together, but I think it's easier to
understand this way.




Acknowledgement sent to Gerd Möllmann <gerd.moellmann@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#75886; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Thu, 6 Feb 2025 04:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.