GNU bug report logs - #75894
Request for merging "node-team" branch

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75894 in the body.
You can then email your comments to 75894 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: guix-patches <at> gnu.org
Subject: Request for merging "node-team" branch
Date: Mon, 27 Jan 2025 11:50:24 +0100

Hi Guix,

The node-team branch contains the bump of node-lts to the 22.X.Y series,
and supporting changes that make this possible.

Since some of the leaf packages depending on node are quite important and hard to
build on underpowered hardware, I'd like to get the ball rolling this
way so we have some substitutes before merging this into master.

NB, there is no real node-team yet, but there might be soon enough :)

Thanks,
 - Jelle

Message #8 received at 75894 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: Jelle Licht <jlicht <at> fsfe.org>, 75894 <at> debbugs.gnu.org
Subject: Re: [bug#75894] Request for merging "node-team" branch
Date: Mon, 24 Mar 2025 15:29:48 +0100

Hi Jelle,

I still see node-team on QA, it should probably be javascript-team
now.  Or is QA's node-team polling properly from javascript-team branch?

-- 
Best regards,
Nicolas Graves

Message #11 received at 75894 <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: Nicolas Graves <ngraves <at> ngraves.fr>, 75894 <at> debbugs.gnu.org
Subject: Re: [bug#75894] Request for merging "node-team" branch
Date: Mon, 24 Mar 2025 22:26:08 +0100

Hi!

Nicolas Graves <ngraves <at> ngraves.fr> writes:

> Hi Jelle,
>
> I still see node-team on QA, it should probably be javascript-team
> now.  Or is QA's node-team polling properly from javascript-team branch?

Good catch! I'll look into it this weekend so we can start getting
everything we have now merged before the next Node.js LTS is released.

- Jelle

Message #14 received at 75894 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Jelle Licht <jlicht <at> fsfe.org>
Cc: 75894 <at> debbugs.gnu.org, Nicolas Graves <ngraves <at> ngraves.fr>
Subject: Re: [bug#75894] Request for merging "node-team" branch
Date: Tue, 1 Apr 2025 22:52:41 +0200

Hello!

QA goes strictly by branch names. It picks up all branches not starting
with wip-. Then if your issue is named
   Request for merging "node-team" branch
it will build the branch named "node-team".
The team name plays no role.

Maybe it is enough to rename the issue. Or you delete the node-team branch
and create a new one with the same content as javascript-team.

By the way, I see lots of node related branches:
  remotes/origin/node-team
  remotes/origin/wip-node-14
  remotes/origin/wip-node-18-updates
  remotes/origin/wip-node-importer
  remotes/origin/wip-node-reproducibility
  remotes/origin/wip-node-riscv64
Maybe you could go through them at some point in time and clean them up.

Andreas

Message #17 received at 75894 <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: Andreas Enge <andreas <at> enge.fr>
Cc: 75894 <at> debbugs.gnu.org, Nicolas Graves <ngraves <at> ngraves.fr>
Subject: Re: [bug#75894] Request for merging "node-team" branch
Date: Sat, 05 Apr 2025 23:39:10 +0200

Hey folks,

Andreas Enge <andreas <at> enge.fr> writes:

> Hello!
>
> QA goes strictly by branch names. It picks up all branches not starting
> with wip-. Then if your issue is named
>    Request for merging "node-team" branch
> it will build the branch named "node-team".
> The team name plays no role.
>
> Maybe it is enough to rename the issue. Or you delete the node-team branch
> and create a new one with the same content as javascript-team.

The branch predates the team, but I guess for now we'll keep using the
branch.

> By the way, I see lots of node related branches:
>   remotes/origin/node-team
Removed this branch, rebased our current javascript-team branch on
master, renamed it to node-team, and pushed yet again.

>   remotes/origin/wip-node-14
>   remotes/origin/wip-node-18-updates
>   remotes/origin/wip-node-importer
>   remotes/origin/wip-node-reproducibility
Removed as these were (cleaned up and) merged into master

>   remotes/origin/wip-node-riscv64
This branch seems to be in use, so left alone.

In addition, I've deleted the javascript-team branch, as that one will
(for this round of the merge train) be called node-team. Thanks for the
guidance!

Thanks!
- Jelle

Message #20 received at 75894 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Jelle Licht <jlicht <at> fsfe.org>
Cc: 75894 <at> debbugs.gnu.org, Nicolas Graves <ngraves <at> ngraves.fr>
Subject: Re: [bug#75894] Request for merging "node-team" branch
Date: Mon, 7 Apr 2025 13:56:00 +0200

Hello Jelle,

thanks a lot for cleaning up the branches!

The node-team branch is currently built on QA:
   https://qa.guix.gnu.org/branch/node-team

There are not so many affected packages, so maybe you can apply it to
master rather quickly.

Andreas

Message #23 received at 75894 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Andreas Enge <andreas <at> enge.fr>
Cc: 75894 <at> debbugs.gnu.org, Jelle Licht <jlicht <at> fsfe.org>,
 Nicolas Graves <ngraves <at> ngraves.fr>
Subject: Re: [bug#75894] Request for merging "node-team" branch
Date: Wed, 09 Apr 2025 08:19:18 +0100

[Message part 1 (text/plain, inline)]

Andreas Enge <andreas <at> enge.fr> writes:

> thanks a lot for cleaning up the branches!
>
> The node-team branch is currently built on QA:
>    https://qa.guix.gnu.org/branch/node-team
>
> There are not so many affected packages, so maybe you can apply it to
> master rather quickly.

Looks like the builds are mostly complete, one package that stood out
was libnode, as that seems to fail to build on 32bit architectures.

I'm not sure if that's more flakyness (since some builds for other
architectures failed as well) or not:

  https://data.qa.guix.gnu.org/repository/1/branch/node-team/latest-processed-revision/package/libnode/22.14.0?locale=en_US.UTF-8

[signature.asc (application/pgp-signature, inline)]

Message #26 received at 75894 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Andreas Enge <andreas <at> enge.fr>
Cc: 75894 <at> debbugs.gnu.org, Jelle Licht <jlicht <at> fsfe.org>,
 Nicolas Graves <ngraves <at> ngraves.fr>
Subject: Re: [bug#75894] Request for merging "node-team" branch
Date: Sat, 12 Apr 2025 11:39:46 +0100

[Message part 1 (text/plain, inline)]

Christopher Baines <mail <at> cbaines.net> writes:

> Andreas Enge <andreas <at> enge.fr> writes:
>
>> thanks a lot for cleaning up the branches!
>>
>> The node-team branch is currently built on QA:
>>    https://qa.guix.gnu.org/branch/node-team
>>
>> There are not so many affected packages, so maybe you can apply it to
>> master rather quickly.
>
> Looks like the builds are mostly complete, one package that stood out
> was libnode, as that seems to fail to build on 32bit architectures.
>
> I'm not sure if that's more flakyness (since some builds for other
> architectures failed as well) or not:
>
>   https://data.qa.guix.gnu.org/repository/1/branch/node-team/latest-processed-revision/package/libnode/22.14.0?locale=en_US.UTF-8

The test looks to be regarded as flaky by upstream, so I've pushed a
commit to skip the test on 32 bit architectures and rebased the branch.

Obviously there's work ongoing on the python-team branch at the moment,
but hopefully either python-team or node-team are ready to merge shortly
(and given the small number of builds on the node-team branch, I think
it's likely that it might be node-team).

[signature.asc (application/pgp-signature, inline)]

Message #29 received at 75894 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: Christopher Baines <mail <at> cbaines.net>, Andreas Enge <andreas <at> enge.fr>
Cc: 75894 <at> debbugs.gnu.org, Jelle Licht <jlicht <at> fsfe.org>
Subject: Re: [bug#75894] Request for merging "node-team" branch
Date: Sat, 12 Apr 2025 17:54:33 +0200

On 2025-04-12 11:39, Christopher Baines wrote:

> Christopher Baines <mail <at> cbaines.net> writes:
>
>> Andreas Enge <andreas <at> enge.fr> writes:
>>
>>> thanks a lot for cleaning up the branches!
>>>
>>> The node-team branch is currently built on QA:
>>>    https://qa.guix.gnu.org/branch/node-team
>>>
>>> There are not so many affected packages, so maybe you can apply it to
>>> master rather quickly.
>>
>> Looks like the builds are mostly complete, one package that stood out
>> was libnode, as that seems to fail to build on 32bit architectures.
>>
>> I'm not sure if that's more flakyness (since some builds for other
>> architectures failed as well) or not:
>>
>>   https://data.qa.guix.gnu.org/repository/1/branch/node-team/latest-processed-revision/package/libnode/22.14.0?locale=en_US.UTF-8
>
> The test looks to be regarded as flaky by upstream, so I've pushed a
> commit to skip the test on 32 bit architectures and rebased the branch.
>
> Obviously there's work ongoing on the python-team branch at the moment,
> but hopefully either python-team or node-team are ready to merge shortly
> (and given the small number of builds on the node-team branch, I think
> it's likely that it might be node-team).

I was working on both recently.

I don't think what I worked on in node-team is ready yet (I had some
updates going on and did some work to auto-delete unwanted dependencies
just as I did on python too, but I'd say it's not ready yet and could be
delayed until a later revision of the branch if that's blocking for some
other team).

I don't know if Jelle had other plans but if not, node-team can be
merged IMO, and we'll open another one when I'll have more time to
iterate / mature on my idea (I might start a GCD because it might be
useful for several build-systems).

On python-team, there's still maybe a week of work.  I'll dedicate some
time this evening and tomorrow to advance on my part.

-- 
Best regards,
Nicolas Graves

Message #34 received at 75894-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: 75894-done <at> debbugs.gnu.org, Christopher Baines <mail <at> cbaines.net>,
 Jelle Licht <jlicht <at> fsfe.org>
Subject: Re: [bug#75894] Request for merging "node-team" branch
Date: Sun, 13 Apr 2025 14:25:16 +0200

Hello,

and thanks for the update! The node-team branch has been built without
further problems, thanks a lot to Chris for taking care of the 32bit
build failure.

So I have pushed the branch to master and am closing this bug.
I will also delete the node-team branch as per policy, and anyway
I think you wanted to rename it to javascript-team for the next run.

In any case, whenever you are ready, please feel free to push a new
branch and to open a corresponding merge request.

Andreas

Message #37 received at 75894 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Andreas Enge <andreas <at> enge.fr>
Cc: 75894 <at> debbugs.gnu.org, Jelle Licht <jlicht <at> fsfe.org>,
 Nicolas Graves <ngraves <at> ngraves.fr>
Subject: Re: [bug#75894] Request for merging "node-team" branch
Date: Sun, 13 Apr 2025 13:54:44 +0100

[Message part 1 (text/plain, inline)]

Andreas Enge <andreas <at> enge.fr> writes:

> and thanks for the update! The node-team branch has been built without
> further problems, thanks a lot to Chris for taking care of the 32bit
> build failure.

I think the builds are still flaky, but at least there should be some
substitutes, and this can be further worked on directly on the master
branch.

Thanks for pushing this Andreas!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.