GNU bug report logs - #75913
[PATCH] gnu: Add emacs-go-translate.

Previous Next

Package: guix-patches;

Reported by: Evgeny Pisemsky <mail <at> pisemsky.site>

Date: Tue, 28 Jan 2025 16:22:02 UTC

Severity: normal

Tags: patch

Done: Sharlatan Hellseher <sharlatanus <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75913 in the body.
You can then email your comments to 75913 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to andrew <at> trop.in, divya <at> subvertising.org, ian <at> retrospec.tv, cox.katherine.e+guix <at> gmail.com, liliana.prikler <at> gmail.com, guix-patches <at> gnu.org:
bug#75913; Package guix-patches. (Tue, 28 Jan 2025 16:22:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Evgeny Pisemsky <mail <at> pisemsky.site>:
New bug report received and forwarded. Copy sent to andrew <at> trop.in, divya <at> subvertising.org, ian <at> retrospec.tv, cox.katherine.e+guix <at> gmail.com, liliana.prikler <at> gmail.com, guix-patches <at> gnu.org. (Tue, 28 Jan 2025 16:22:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Evgeny Pisemsky <mail <at> pisemsky.site>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-go-translate.
Date: Tue, 28 Jan 2025 19:20:23 +0300
* gnu/packages/emacs-xyz.scm (emacs-go-translate): New variable.

Change-Id: I623079b65f6df2180537a7589b953eaeb57d6a77
---
 gnu/packages/emacs-xyz.scm | 41 +++++++++++++++++++++++++++++++++++++-
 1 file changed, 40 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 153785e017..51fd9c01e9 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -126,7 +126,7 @@
 ;;; Copyright © 2020, 2021, 2022, 2023 Andrew Tropin <andrew <at> trop.in>
 ;;; Copyright © 2023 Dominik Delgado Steuter <d <at> delgado.nrw>
 ;;; Copyright © 2023 Juliana Sims <juli <at> incana.org>
-;;; Copyright © 2023 Evgeny Pisemsky <mail <at> pisemsky.site>
+;;; Copyright © 2023, 2025 Evgeny Pisemsky <mail <at> pisemsky.site>
 ;;; Copyright © 2023 Gabriel Wicki <gabriel <at> erlikon.ch>
 ;;; Copyright © 2022-2023 Simon Josefsson <simon <at> josefsson.org>
 ;;; Copyright © 2023 Fabio Natali <me <at> fabionatali.com>
@@ -29151,6 +29151,45 @@ (define-public emacs-gif-screencast
 the GIF result.")
     (license license:gpl3+)))
 
+(define-public emacs-go-translate
+  (package
+    (name "emacs-go-translate")
+    (version "3.0.7")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/lorniu/go-translate")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0603iq1vjbm44sl7qrmkdfcqzzc703h1g5hdcswpj7pi0w7fxb4s"))))
+    (build-system emacs-build-system)
+    (arguments
+     (list
+      #:tests? #t
+      #:test-command #~(list "emacs" "-Q" "--batch"
+                             "-L" "."
+                             "-l" "gt-tests.el"
+                             "-f" "ert-run-tests-batch-and-exit")
+      #:phases #~(modify-phases %standard-phases
+                   (add-before 'check 'skip-failing-tests
+                     (lambda _
+                       (substitute* "gt-tests.el"
+                         (("\\(ert-deftest test--gt-translation-life-cycle .*"
+                           all)
+                          (string-append all "(skip-unless nil)\n"))
+                         (("\\(ert-deftest test--gt-valid-literally .*"
+                           all)
+                          (string-append all "(skip-unless nil)\n"))))))))
+    (home-page "https://github.com/lorniu/go-translate")
+    (synopsis "Configurable and scalable translation framework")
+    (description
+     "This is a translation framework on Emacs, with high configurability
+and extensibility.  It can easily be extended to various Text-to-Text
+conversion scenarios.")
+    (license license:gpl3+)))
+
 (define-public emacs-google-translate
   (package
     (name "emacs-google-translate")

base-commit: 49a113e3fc618d6f6bd5000c164a1d33701a30c4
-- 
2.47.1





Information forwarded to guix-patches <at> gnu.org:
bug#75913; Package guix-patches. (Thu, 30 Jan 2025 15:28:01 GMT) Full text and rfc822 format available.

Message #8 received at 75913 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 75913 <at> debbugs.gnu.org
Cc: Evgeny Pisemsky <mail <at> pisemsky.site>
Subject: [PATCH v1] gnu: Add emacs-go-translate.
Date: Thu, 30 Jan 2025 16:25:09 +0100
From: Evgeny Pisemsky <mail <at> pisemsky.site>

* gnu/packages/emacs-xyz.scm (emacs-go-translate): New variable.

Change-Id: I623079b65f6df2180537a7589b953eaeb57d6a77
---

This v1 fixes lint issues with long lines. If includes minor styling improvements too.

 gnu/packages/emacs-xyz.scm | 45 +++++++++++++++++++++++++++++++++++++-
 1 file changed, 44 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 153785e017..9e0b58e944 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -126,7 +126,7 @@
 ;;; Copyright © 2020, 2021, 2022, 2023 Andrew Tropin <andrew <at> trop.in>
 ;;; Copyright © 2023 Dominik Delgado Steuter <d <at> delgado.nrw>
 ;;; Copyright © 2023 Juliana Sims <juli <at> incana.org>
-;;; Copyright © 2023 Evgeny Pisemsky <mail <at> pisemsky.site>
+;;; Copyright © 2023, 2025 Evgeny Pisemsky <mail <at> pisemsky.site>
 ;;; Copyright © 2023 Gabriel Wicki <gabriel <at> erlikon.ch>
 ;;; Copyright © 2022-2023 Simon Josefsson <simon <at> josefsson.org>
 ;;; Copyright © 2023 Fabio Natali <me <at> fabionatali.com>
@@ -29151,6 +29151,49 @@ (define-public emacs-gif-screencast
 the GIF result.")
     (license license:gpl3+)))
 
+(define-public emacs-go-translate
+  (package
+    (name "emacs-go-translate")
+    (version "3.0.7")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/lorniu/go-translate/")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0603iq1vjbm44sl7qrmkdfcqzzc703h1g5hdcswpj7pi0w7fxb4s"))))
+    (build-system emacs-build-system)
+    (arguments
+     (list
+      #:tests? #t
+      #:test-command #~(list "emacs"
+                             "-Q"
+                             "--batch"
+                             "-L"
+                             "."
+                             "-l"
+                             "gt-tests.el"
+                             "-f"
+                             "ert-run-tests-batch-and-exit")
+      #:phases #~(modify-phases %standard-phases
+                   (add-before 'check 'skip-failing-tests
+                     (lambda _
+                       (substitute* "gt-tests.el"
+                         (("\\(ert-deftest test--gt-translation-life-cycle .*"
+                           all)
+                          (string-append all "(skip-unless nil)\n"))
+                         (("\\(ert-deftest test--gt-valid-literally .*" all)
+                          (string-append all "(skip-unless nil)\n"))))))))
+    (home-page "https://github.com/lorniu/go-translate/")
+    (synopsis "Configurable and scalable translation framework")
+    (description
+     "This is a translation framework on Emacs, with high configurability
+and extensibility.  It can easily be extended to various Text-to-Text
+conversion scenarios.")
+    (license license:gpl3+)))
+
 (define-public emacs-google-translate
   (package
     (name "emacs-google-translate")

base-commit: b85d20e853192a92093cd8d6a5756ec80e94c658
--
2.48.1





Information forwarded to guix-patches <at> gnu.org:
bug#75913; Package guix-patches. (Thu, 30 Jan 2025 16:19:01 GMT) Full text and rfc822 format available.

Message #11 received at 75913 <at> debbugs.gnu.org (full text, mbox):

From: Evgeny Pisemsky <mail <at> pisemsky.site>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 75913 <at> debbugs.gnu.org
Subject: Re: [PATCH v1] gnu: Add emacs-go-translate.
Date: Thu, 30 Jan 2025 19:18:34 +0300
Hi.

It looks like output of guix style, which I intentionally edited to make test-command look less ugly and make substitution lines look similar.

And I do not see any complains from guix lint with my version.




Information forwarded to guix-patches <at> gnu.org:
bug#75913; Package guix-patches. (Thu, 30 Jan 2025 16:41:02 GMT) Full text and rfc822 format available.

Message #14 received at 75913 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: Evgeny Pisemsky <mail <at> pisemsky.site>
Cc: 75913 <at> debbugs.gnu.org
Subject: Re: [PATCH v1] gnu: Add emacs-go-translate.
Date: Thu, 30 Jan 2025 17:40:14 +0100
[Message part 1 (text/plain, inline)]
>jeu. 30 janv. 2025 at 19:18, Evgeny Pisemsky <mail <at> pisemsky.site> wrote:

> Hi.
>
> It looks like output of guix style, which I intentionally edited to make test-command look
> less ugly and make substitution lines look similar.
>
> And I do not see any complains from guix lint with my version.

You’re absolutely right, I just checked. I probably did something wrong
when I applied your patch.

My bad, sorry about that.

--
Cayetano Santos
GnuPG Key:   https://meta.sr.ht/~csantosb.pgp
FingerPrint: CCB8 1842 F9D7 058E CD67 377A BF5C DF4D F6BF 6682
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#75913; Package guix-patches. (Thu, 30 Jan 2025 16:46:02 GMT) Full text and rfc822 format available.

Message #17 received at 75913 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: control <at> debbugs.gnu.org
Cc: mail <at> pisemsky.site, ian <at> retrospec.tv, 75913 <at> debbugs.gnu.org,
 cox.katherine.e+guix <at> gmail.com, liliana.prikler <at> gmail.com, andrew <at> trop.in,
 divya <at> subvertising.org
Subject: control message for bug #75913
Date: Thu, 30 Jan 2025 17:45:45 +0100
[Message part 1 (text/plain, inline)]
user guix
usertag 75913 + reviewed-looks-good
thanks

QA review:

- Commit messages
- Package builds
- Lint warnings
- Package tests
- Package style
- List dependent packages build

- New package licenses
- New package tests
- New package synopsis and descriptions

--
Cayetano Santos
GnuPG Key:   https://meta.sr.ht/~csantosb.pgp
FingerPrint: CCB8 1842 F9D7 058E CD67 377A BF5C DF4D F6BF 6682
[signature.asc (application/pgp-signature, inline)]

Reply sent to Sharlatan Hellseher <sharlatanus <at> gmail.com>:
You have taken responsibility. (Tue, 04 Feb 2025 14:10:02 GMT) Full text and rfc822 format available.

Notification sent to Evgeny Pisemsky <mail <at> pisemsky.site>:
bug acknowledged by developer. (Tue, 04 Feb 2025 14:10:02 GMT) Full text and rfc822 format available.

Message #22 received at 75913-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 75913-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add emacs-go-translate.
Date: Tue, 04 Feb 2025 14:09:19 +0000
[Message part 1 (text/plain, inline)]
Hi,

Pushed to master as

7e58d45adf7 * master gnu: Add emacs-go-translate.

--
Oleg
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 05 Mar 2025 12:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 8 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.