Juri Linkov <juri@HIDDEN>
to control <at> debbugs.gnu.org
.
Full text available.Received: (at 75918) by debbugs.gnu.org; 30 Jan 2025 18:38:38 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 30 13:38:38 2025 Received: from localhost ([127.0.0.1]:47767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tdZQz-00007h-Ib for submit <at> debbugs.gnu.org; Thu, 30 Jan 2025 13:38:37 -0500 Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]:33445) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1tdZQj-00006R-75; Thu, 30 Jan 2025 13:38:21 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 0D9DC442B4; Thu, 30 Jan 2025 18:38:11 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Ship Mints <shipmints@HIDDEN> Subject: Re: bug#75918: [PATCH] Add new user option tab-bar-define-keys In-Reply-To: <CAN+1HbpW7w2hk3dLitwoWq+7g1FL7QigATxMSOQ45hxxZ3qXfg@HIDDEN> (Ship Mints's message of "Wed, 29 Jan 2025 14:28:29 -0500") Organization: LINKOV.NET References: <CAN+1Hbq+WeBCv9ZWC_JT_6UooqsQC3YGESkbCzC-OncU2HLKDQ@HIDDEN> <87tt9iawy7.fsf@HIDDEN> <CAN+1HbpJ58BFX801toGrfO4+yCBBhQyuEWEmv+cr-u58PzVW7A@HIDDEN> <87r04ledga.fsf@HIDDEN> <CAN+1HbonAx2OX=O-B_yUfGdq=jEV8CpVGd_nRp+34Mf05s2nrA@HIDDEN> <87jzadeblt.fsf@HIDDEN> <CAN+1HbpfK2R_JoLzHMawcrrnCMBdhn0BNvwyt8JC7=hon4GH8Q@HIDDEN> <87a5b9e9by.fsf@HIDDEN> <CAN+1HbpW7w2hk3dLitwoWq+7g1FL7QigATxMSOQ45hxxZ3qXfg@HIDDEN> Date: Thu, 30 Jan 2025 20:33:49 +0200 Message-ID: <87h65gtalu.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdeiheeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrdeliedrledtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrdeliedrledtpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepfedprhgtphhtthhopegtohhnthhrohhlseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepjeehledukeesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehshhhiphhmihhnthhssehgmhgrihhlrdgtohhm X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75918 Cc: 75918 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) close 75918 31.0.50 thanks > This one should adequately address that backward compatibility issue. > Thanks for pointing it out. Thanks for the changes, now pushed and closed.
bug-gnu-emacs@HIDDEN
:bug#75918
; Package emacs
.
Full text available.Received: (at 75918) by debbugs.gnu.org; 29 Jan 2025 19:30:30 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 29 14:30:30 2025 Received: from localhost ([127.0.0.1]:43108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tdDle-0001El-3m for submit <at> debbugs.gnu.org; Wed, 29 Jan 2025 14:30:30 -0500 Received: from mail-vk1-xa32.google.com ([2607:f8b0:4864:20::a32]:54648) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <shipmints@HIDDEN>) id 1tdDlb-0001EX-8A for 75918 <at> debbugs.gnu.org; Wed, 29 Jan 2025 14:30:28 -0500 Received: by mail-vk1-xa32.google.com with SMTP id 71dfb90a1353d-5188c6f260cso1329e0c.1 for <75918 <at> debbugs.gnu.org>; Wed, 29 Jan 2025 11:30:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738179021; x=1738783821; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=NNIHFNvKHzLvgJM6bnKUV1+TOtv2SxLP04BzoRV334I=; b=Zp5PigO8jUx9dtylALF0IHQbu5UHKvwlr1fktkDkQ7p94MQ2O4Wwq/oErbmjuGA+X8 SuDFwQ2i+tyJsKib+FX2F9xmaFcSYVZgl8kjM7JuNmBhIzhWfYtZgUjTFSwR/2fb0Abf qF8+BqTzAkhgR7/EM2vp0TezDg/6Lu7I82PkaO14c6WQdWaiMZ4KrFQ+KqXFzEFuN0Tu sZ2vMFe8jtRXlfnxZJbLStmAOGGO6z6M1ulO8rS1YcEHGHvGspr6rwPkKFfEgp0fJUUH jmjxUpCi5zZ7PteJEuFubkuUJLFkoxqhNAbPibNxdcIP2Qw51c22NJM9Y0qczp6boJck V+7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738179021; x=1738783821; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NNIHFNvKHzLvgJM6bnKUV1+TOtv2SxLP04BzoRV334I=; b=YIdxz9wtUYnKvWSK+72JRId5vJKiuelETWYPxDni28ehwHnhCbjn53MpnjIL5V9rcI pYijAiAkbN/2NtnBuFMM53WRb8jqyQjPfFmJtK+E4nOZj+zA4YY5dKLawiF3/s4nqO6G tBbITjr8ZjlvbxXV9MXpKOxxZlNK5X2DbHwpvoK0IGcbnINVNdXgq7dWnbLgQHYzMZDG MxtAV1oCpkMKK95Yif3sTaH1KS2iPyDWtBjAnA3ZoyIF9ZlMW23tJLv5RjFETMbhw40u ApkfLj/SMoSaxH4JFsj2MOqhcmxpeL8/jwZH8Vwo+ALQvYA/1wh+5CXZWqN+HScO/xVE iHNQ== X-Gm-Message-State: AOJu0YxARiwR3gg4beWxkpWKkW7xdJj82y0KOnSukbfmmdKQHZTT0Djr SPB+zcpuQFjx+qVuMmchfYQykbbklPv2OJCxBsmLlmEWlJZK5FyUvXNVGN4QS6TmNtUmpg6ugH7 aSkzSpiA17eImqTaz7fxFH6Q1LUdsBQ== X-Gm-Gg: ASbGnctgtjg+KEm12W2VASYXL7eec1JQjn9dXO8+iqS5zGJNIi6peo71z1O2CG0h2fM yYqWvsIyHxc2O3fl36lh5EuARxvNvw5z14Id/1pnIRI2ayfAtt9nbXenlzzn/m31rrWp3Ernn X-Google-Smtp-Source: AGHT+IHeI7P98Vz98L1BA3GtJeXd4jgrBRYThqPQIK/NRHuqu9ZejS35vlwIJYlHwpzQ/EYKOajIJ0uY6oVdeXz+wmQ= X-Received: by 2002:a05:6122:887:b0:515:5008:118b with SMTP id 71dfb90a1353d-51e9e3e3e21mr4679433e0c.1.1738179021306; Wed, 29 Jan 2025 11:30:21 -0800 (PST) MIME-Version: 1.0 References: <CAN+1Hbq+WeBCv9ZWC_JT_6UooqsQC3YGESkbCzC-OncU2HLKDQ@HIDDEN> <87tt9iawy7.fsf@HIDDEN> <CAN+1HbpJ58BFX801toGrfO4+yCBBhQyuEWEmv+cr-u58PzVW7A@HIDDEN> <87r04ledga.fsf@HIDDEN> <CAN+1HbonAx2OX=O-B_yUfGdq=jEV8CpVGd_nRp+34Mf05s2nrA@HIDDEN> <87jzadeblt.fsf@HIDDEN> <CAN+1HbpfK2R_JoLzHMawcrrnCMBdhn0BNvwyt8JC7=hon4GH8Q@HIDDEN> <87a5b9e9by.fsf@HIDDEN> In-Reply-To: <87a5b9e9by.fsf@HIDDEN> From: Ship Mints <shipmints@HIDDEN> Date: Wed, 29 Jan 2025 14:28:29 -0500 X-Gm-Features: AWEUYZlUK6d_EQ2mqWBvE4Ofh787B3bz8wBVcbf_pPX_4EYDwK4ce5XCwZHUYzE Message-ID: <CAN+1HbpW7w2hk3dLitwoWq+7g1FL7QigATxMSOQ45hxxZ3qXfg@HIDDEN> Subject: Re: bug#75918: [PATCH] Add new user option tab-bar-define-keys To: Juri Linkov <juri@HIDDEN> Content-Type: multipart/mixed; boundary="0000000000001f4de1062cdd57fe" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75918 Cc: 75918 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --0000000000001f4de1062cdd57fe Content-Type: multipart/alternative; boundary="0000000000001f4de0062cdd57fc" --0000000000001f4de0062cdd57fc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable This one should adequately address that backward compatibility issue. Thanks for pointing it out. On Wed, Jan 29, 2025 at 1:58=E2=80=AFPM Juri Linkov <juri@HIDDEN> wrote= : > > + (when (memq tab-bar-define-keys '(t tab)) > > + (define-key tab-bar-mode-map [(control tab)] #'tab-next) > > + (define-key tab-bar-mode-map [(control shift tab)] #'tab-previous) > > + (define-key tab-bar-mode-map [(control shift iso-lefttab)] > #'tab-previous)) > > But we still need to check with global-key-binding here > before binding TAB keys. This will ensure backwards-compatibility. > > > -(defun tab-bar-mode--tab-key-bind (map key binding) > > - ;; Don't override user customized global key bindings > > - (define-key map key > > - `(menu-item "" ,binding > > - :filter ,(lambda (cmd) (unless (global-key-binding key) cmd))))) > --0000000000001f4de0062cdd57fc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:monospac= e">This one should adequately address that backward compatibility issue. Th= anks for pointing it out.</div></div><br><div class=3D"gmail_quote gmail_qu= ote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, Jan 29, 2025 a= t 1:58=E2=80=AFPM Juri Linkov <<a href=3D"mailto:juri@HIDDEN">juri@l= inkov.net</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style= =3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding= -left:1ex">> +=C2=A0 (when (memq tab-bar-define-keys '(t tab))<br> > +=C2=A0 =C2=A0 (define-key tab-bar-mode-map [(control tab)] #'tab-= next)<br> > +=C2=A0 =C2=A0 (define-key tab-bar-mode-map [(control shift tab)] #= 9;tab-previous)<br> > +=C2=A0 =C2=A0 (define-key tab-bar-mode-map [(control shift iso-leftta= b)] #'tab-previous))<br> <br> But we still need to check with global-key-binding here<br> before binding TAB keys.=C2=A0 This will ensure backwards-compatibility.<br= > <br> > -(defun tab-bar-mode--tab-key-bind (map key binding)<br> > -=C2=A0 ;; Don't override user customized global key bindings<br> > -=C2=A0 (define-key map key<br> > -=C2=A0 =C2=A0 `(menu-item "" ,binding<br> > -=C2=A0 =C2=A0 =C2=A0 :filter ,(lambda (cmd) (unless (global-key-bindi= ng key) cmd)))))<br> </blockquote></div> --0000000000001f4de0062cdd57fc-- --0000000000001f4de1062cdd57fe Content-Type: application/octet-stream; name="0001-Add-new-user-option-tab-bar-define-keys.patch" Content-Disposition: attachment; filename="0001-Add-new-user-option-tab-bar-define-keys.patch" Content-Transfer-Encoding: base64 Content-ID: <f_m6iaucla0> X-Attachment-Id: f_m6iaucla0 RnJvbSBhYzE1ZDE2NDZlOTJkMjhkOWEyNDc1OGRjMjRmNWI2NjMxZjYwYzUxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBzaGlwbWludHMgPHNoaXBtaW50c0BnbWFpbC5jb20+CkRhdGU6 IFdlZCwgMjkgSmFuIDIwMjUgMTM6NDM6MDQgLTA1MDAKU3ViamVjdDogW1BBVENIXSBBZGQgbmV3 IHVzZXIgb3B0aW9uIHRhYi1iYXItZGVmaW5lLWtleXMKCiogbGlzcC90YWItYmFyLmVsICh0YWIt YmFyLWRlZmluZS1rZXlzKToKQWRkIG5ldyBkZWZjdXN0b20gdGFiLWJhci1kZWZpbmUta2V5cy4g IFJlb3JnYW5pemUga2V5IGJpbmRpbmcgZnVuY3Rpb25zCnRvIGFjY29tbW9kYXRlLiAgQWxzbyBy ZW1vdmUgY2hlY2tzIGZvciB0YWItYmFyLW1vZGUgZW5hYmxlZCBpbgondGFiLWJhci1zZWxlY3Qt dGFiLW1vZGlmaWVycycsIGFzIHVubmVjZXNzYXJ5IGFuZCB3aGljaCBwcmV2ZW50ZWQgdXNlcgpj aGFuZ2VzIGZyb20gYmVpbmcgYWNjZXB0ZWQgaW4gY2FzZXMgd2hlcmUgdGhlIHVzZXIgZGVmZXJz IGVuYWJsaW5nCnRhYi1iYXItbW9kZS4KLS0tCiBldGMvTkVXUyAgICAgICAgfCAxMSArKysrKysr KwogbGlzcC90YWItYmFyLmVsIHwgNjggKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr Ky0tLS0tLS0tLS0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCA1OCBpbnNlcnRpb25zKCspLCAyMSBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdTCmluZGV4IDA5NTA3 YWRlY2I4Li43NGM1NDllYzllYSAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIvZXRjL05FV1MK QEAgLTIzOCw2ICsyMzgsMTcgQEAgbGF0dGVyIHRocm93cyBhbiBlcnJvciB3aGVuIHRoZSBhcmd1 bWVudCBGUkFNRSBjYW5ub3QgYmUgZGVsZXRlZC4KICoqKiBOZXcgYWJub3JtYWwgaG9vayAndGFi LWJhci1hdXRvLXdpZHRoLWZ1bmN0aW9ucycuCiBUaGlzIGhvb2sgYWxsb3dzIHlvdSB0byBjb250 cm9sIHdoaWNoIHRhYi1iYXIgdGFicyBhcmUgYXV0by1yZXNpemVkLgogCistLS0KKyoqKiBOZXcg dXNlciBvcHRpb24gJ3RhYi1iYXItZGVmaW5lLWtleXMnLgorVGhpcyBjb250cm9scyB3aGljaCBr ZXkgYmluZGluZ3MgdGFiLWJhciBjcmVhdGVzLiBWYWx1ZXMgYXJlIHQsdGhlCitkZWZhdWx0LCB3 aGljaCBkZWZpbmVzIGFsbCBrZXlzIGFuZCBpcyBiYWNrd2FyZHMgY29tcGF0aWJsZSwgJ251bWVy aWMKKyh0YWIgbnVtYmVyIHNlbGVjdGlvbiBvbmx5KSwgJ3RhYiAoVEFCIGFuZCBTSElGVC1UQUIg a2V5cyBvbmx5KSwgbmlsCisod2hpY2ggZGVmaW5lcyBub25lKS4KKworVGhpcyBpcyB1c2VmdWwg dG8gYXZvaWQga2V5IGJpbmRpbmcgY29uZmxpY3RzLCBzdWNoIGFzIHdoZW4gZm9sZGluZyBpbgor b3V0bGluZSBtb2RlIHVzaW5nIFRBQiBrZXlzLCBvciB3aGVuIGEgdXNlciB3YW50cyB0byBkZWZp bmUgaGVyIG93bgordGFiLWJhciBrZXlzIHdpdGhvdXQgZmlyc3QgaGF2aW5nIHRvIHJlbW92ZSB0 aGUgZGVmYXVsdHMuCisKICoqIFByb2plY3QKIAogLS0tCmRpZmYgLS1naXQgYS9saXNwL3RhYi1i YXIuZWwgYi9saXNwL3RhYi1iYXIuZWwKaW5kZXggYjU3MDk0OWJmZWMuLjFlZmI0YWFiYTQ3IDEw MDY0NAotLS0gYS9saXNwL3RhYi1iYXIuZWwKKysrIGIvbGlzcC90YWItYmFyLmVsCkBAIC04Niw2 ICs4NiwzNSBAQCB0YWItYmFyLXRhYi11bmdyb3VwZWQKICAgOmdyb3VwICd0YWItYmFyLWZhY2Vz KQogCiAMCisKKyhkZWZ2YXIgdGFiLWJhci1tb2RlLW1hcCAobWFrZS1zcGFyc2Uta2V5bWFwKQor ICAiVGFiIEJhciBtb2RlIG1hcC4iKQorCisoZGVmY3VzdG9tIHRhYi1iYXItZGVmaW5lLWtleXMg dAorICAiRGVmaW5lIHNwZWNpZmllZCB0YWItYmFyIGtleSBiaW5kaW5ncy4KK0lmIHQsIHRoZSBk ZWZhdWx0LCBhbGwga2V5IG1hcHBpbmdzIGFyZSBkZWZpbmVkLgorCitJZiBcXD0nbnVtZXJpYywg ZGVmaW5lIG9ubHkgbnVtZXJpYyBzZWxlY3QtdGFiIGtleSBtYXBwaW5ncywgYW5kIGluCitjb25q dW5jdGlvbiB3aXRoIGB0YWItYmFyLXNlbGVjdC10YWItbW9kaWZpZXJzJywgd2hpY2ggc2VlLgor CitJZiBcXD0ndGFiLCBkZWZpbmUgb25seSBUQUIgYW5kIFNISUZULVRBQiB0YWItc2VsZWN0aW9u IGtleSBtYXBwaW5ncy4KKworSWYgbmlsLCBkbyBub3QgZGVmaW5lIGFueSBrZXkgbWFwcGluZ3Mu CisKK0N1c3RvbWl6ZSB0aGlzIG9wdGlvbiwgb3IgdXNlIGBzZXRvcHQnIHRvIGVuc3VyZSBpdCB3 aWxsIHRha2UgZWZmZWN0LiIKKyAgOnR5cGUgJyhjaG9pY2UgKGNvbnN0IDp0YWcgIkFsbCBrZXlz IiB0KQorICAgICAgICAgICAgICAgICAoY29uc3QgOnRhZyAiTnVtZXJpYyB0YWIgc2VsZWN0aW9u IGtleXMiIG51bWVyaWMpCisgICAgICAgICAgICAgICAgIChjb25zdCA6dGFnICJUQUIgYW5kIFNI SUZULVRBQiBzZWxlY3Rpb24ga2V5cyIgdGFiKQorICAgICAgICAgICAgICAgICAoY29uc3QgOnRh ZyAiTm9uZSIgbmlsKSkKKyAgOmluaXRpYWxpemUgIydjdXN0b20taW5pdGlhbGl6ZS1kZWZhdWx0 CisgIDpzZXQgKGxhbWJkYSAoc3ltIHZhbCkKKyAgICAgICAgICh0YWItYmFyLS11bmRlZmluZS1r ZXlzKQorICAgICAgICAgKHNldC1kZWZhdWx0IHN5bSB2YWwpCisgICAgICAgICA7OyBFbmFibGUg dGhlIG5ldyBrZXliaW5kaW5ncworICAgICAgICAgKHRhYi1iYXItLWRlZmluZS1rZXlzKSkKKyAg Omdyb3VwICd0YWItYmFyCisgIDp2ZXJzaW9uICIzMS4xIikKKwogKGRlZmN1c3RvbSB0YWItYmFy LXNlbGVjdC10YWItbW9kaWZpZXJzICcoKQogICAiTGlzdCBvZiBtb2RpZmllciBrZXlzIGZvciBz ZWxlY3RpbmcgdGFiLWJhciB0YWJzIGJ5IHRoZWlyIG51bWJlcnMuCiBQb3NzaWJsZSBtb2RpZmll ciBrZXlzIGFyZSBgY29udHJvbCcsIGBtZXRhJywgYHNoaWZ0JywgYGh5cGVyJywgYHN1cGVyJyBh bmQKQEAgLTEwNCwxOCArMTMzLDE3IEBAIHRhYi1iYXItc2VsZWN0LXRhYi1tb2RpZmllcnMKICAg ICAgICAgICAgICAgKGNvbnN0IGFsdCkpCiAgIDppbml0aWFsaXplICMnY3VzdG9tLWluaXRpYWxp emUtZGVmYXVsdAogICA6c2V0IChsYW1iZGEgKHN5bSB2YWwpCi0gICAgICAgICAod2hlbiB0YWIt YmFyLW1vZGUKLSAgICAgICAgICAgKHRhYi1iYXItLXVuZGVmaW5lLWtleXMpKQorICAgICAgICAg KHRhYi1iYXItLXVuZGVmaW5lLWtleXMpCiAgICAgICAgICAoc2V0LWRlZmF1bHQgc3ltIHZhbCkK LSAgICAgICAgIDs7IFJlZW5hYmxlIHRoZSB0YWItYmFyIHdpdGggbmV3IGtleWJpbmRpbmdzCi0g ICAgICAgICAod2hlbiB0YWItYmFyLW1vZGUKLSAgICAgICAgICAgKHRhYi1iYXItLWRlZmluZS1r ZXlzKSkpCisgICAgICAgICA7OyBFbmFibGUgdGhlIG5ldyBrZXliaW5kaW5ncworICAgICAgICAg KHRhYi1iYXItLWRlZmluZS1rZXlzKSkKICAgOmdyb3VwICd0YWItYmFyCiAgIDp2ZXJzaW9uICIy Ny4xIikKIAogKGRlZnVuIHRhYi1iYXItLWRlZmluZS1rZXlzICgpCiAgICJJbnN0YWxsIGtleSBi aW5kaW5ncyB0byBzd2l0Y2ggYmV0d2VlbiB0YWJzIGlmIHNvIGNvbmZpZ3VyZWQuIgotICAod2hl biB0YWItYmFyLXNlbGVjdC10YWItbW9kaWZpZXJzCisgICh3aGVuIChhbmQgKG1lbXEgdGFiLWJh ci1kZWZpbmUta2V5cyAnKHQgbnVtZXJpYykpCisgICAgICAgICAgICAgdGFiLWJhci1zZWxlY3Qt dGFiLW1vZGlmaWVycykKICAgICAoZGVmaW5lLWtleSB0YWItYmFyLW1vZGUtbWFwCiAgICAgICAg ICAgICAgICAgKHZlY3RvciAoYXBwZW5kIHRhYi1iYXItc2VsZWN0LXRhYi1tb2RpZmllcnMgKGxp c3QgPzApKSkKICAgICAgICAgICAgICAgICAjJ3RhYi1yZWNlbnQpCkBAIC0xMjgsNiArMTU2LDE0 IEBAIHRhYi1iYXItLWRlZmluZS1rZXlzCiAgICAgICAgICAgICAgICAgKHZlY3RvciAoYXBwZW5k IHRhYi1iYXItc2VsZWN0LXRhYi1tb2RpZmllcnMgKGxpc3QgPzkpKSkKICAgICAgICAgICAgICAg ICAjJ3RhYi1sYXN0KSkKIAorICAod2hlbiAobWVtcSB0YWItYmFyLWRlZmluZS1rZXlzICcodCB0 YWIpKQorICAgICh1bmxlc3MgKGdsb2JhbC1rZXktYmluZGluZyBbKGNvbnRyb2wgdGFiKV0pCisg ICAgICAoZGVmaW5lLWtleSB0YWItYmFyLW1vZGUtbWFwIFsoY29udHJvbCB0YWIpXSAjJ3RhYi1u ZXh0KSkKKyAgICAodW5sZXNzIChnbG9iYWwta2V5LWJpbmRpbmcgWyhjb250cm9sIHNoaWZ0IHRh YildKQorICAgICAgKGRlZmluZS1rZXkgdGFiLWJhci1tb2RlLW1hcCBbKGNvbnRyb2wgc2hpZnQg dGFiKV0gIyd0YWItcHJldmlvdXMpKQorICAgICh1bmxlc3MgKGdsb2JhbC1rZXktYmluZGluZyBb KGNvbnRyb2wgc2hpZnQgaXNvLWxlZnR0YWIpXSkKKyAgICAgIChkZWZpbmUta2V5IHRhYi1iYXIt bW9kZS1tYXAgWyhjb250cm9sIHNoaWZ0IGlzby1sZWZ0dGFiKV0gIyd0YWItcHJldmlvdXMpKSkK KwogICA7OyBSZXBsYWNlIGRlZmF1bHQgdmFsdWUgd2l0aCBhIGNvbmRpdGlvbiB0aGF0IHN1cHBv cnRzIGRpc3BsYXlpbmcKICAgOzsgZ2xvYmFsLW1vZGUtc3RyaW5nIGluIHRoZSB0YWIgYmFyIGlu c3RlYWQgb2YgdGhlIG1vZGUgbGluZS4KICAgKHdoZW4gKGFuZCAobWVtcSAndGFiLWJhci1mb3Jt YXQtZ2xvYmFsIHRhYi1iYXItZm9ybWF0KQpAQCAtMTUyLDcgKzE4OCwxMSBAQCB0YWItYmFyLS11 bmRlZmluZS1rZXlzCiAgICAgICAgICAgICAgICAgICBuaWwgdCkpCiAgICAgKGRlZmluZS1rZXkg dGFiLWJhci1tb2RlLW1hcAogICAgICAgICAgICAgICAgICh2ZWN0b3IgKGFwcGVuZCB0YWItYmFy LXNlbGVjdC10YWItbW9kaWZpZXJzIChsaXN0ID85KSkpCi0gICAgICAgICAgICAgICAgbmlsIHQp KSkKKyAgICAgICAgICAgICAgICBuaWwgdCkpCisKKyAgKGRlZmluZS1rZXkgdGFiLWJhci1tb2Rl LW1hcCBbKGNvbnRyb2wgdGFiKV0gbmlsIHQpCisgIChkZWZpbmUta2V5IHRhYi1iYXItbW9kZS1t YXAgWyhjb250cm9sIHNoaWZ0IHRhYildIG5pbCB0KQorICAoZGVmaW5lLWtleSB0YWItYmFyLW1v ZGUtbWFwIFsoY29udHJvbCBzaGlmdCBpc28tbGVmdHRhYildIG5pbCB0KSkKIAogKGRlZnVuIHRh Yi1iYXItLWxvYWQtYnV0dG9ucyAoKQogICAiTG9hZCB0aGUgaWNvbnMgZm9yIHRoZSB0YWIgYnV0 dG9ucy4iCkBAIC0yNDIsMjAgKzI4Miw2IEBAIHRhYi1iYXItLXVwZGF0ZS10YWItYmFyLWxpbmVz CiAgICAgICAgICAgICAgICAgICAgICAgKGlmIChhbmQgdGFiLWJhci1tb2RlIChlcSB0YWItYmFy LXNob3cgdCkpIDEgMCkpCiAgICAgICAgICAgICAgICAgKGFzc3EtZGVsZXRlLWFsbCAndGFiLWJh ci1saW5lcyBkZWZhdWx0LWZyYW1lLWFsaXN0KSkpKSkKIAotKGRlZnVuIHRhYi1iYXItbW9kZS0t dGFiLWtleS1iaW5kIChtYXAga2V5IGJpbmRpbmcpCi0gIDs7IERvbid0IG92ZXJyaWRlIHVzZXIg Y3VzdG9taXplZCBnbG9iYWwga2V5IGJpbmRpbmdzCi0gIChkZWZpbmUta2V5IG1hcCBrZXkKLSAg ICBgKG1lbnUtaXRlbSAiIiAsYmluZGluZwotICAgICAgOmZpbHRlciAsKGxhbWJkYSAoY21kKSAo dW5sZXNzIChnbG9iYWwta2V5LWJpbmRpbmcga2V5KSBjbWQpKSkpKQotCi0oZGVmdmFyIHRhYi1i YXItbW9kZS1tYXAKLSAgKGxldCAoKG1hcCAobWFrZS1zcGFyc2Uta2V5bWFwKSkpCi0gICAgKHRh Yi1iYXItbW9kZS0tdGFiLWtleS1iaW5kIG1hcCBbKGNvbnRyb2wgdGFiKV0gIyd0YWItbmV4dCkK LSAgICAodGFiLWJhci1tb2RlLS10YWIta2V5LWJpbmQgbWFwIFsoY29udHJvbCBzaGlmdCB0YWIp XSAjJ3RhYi1wcmV2aW91cykKLSAgICAodGFiLWJhci1tb2RlLS10YWIta2V5LWJpbmQgbWFwIFso Y29udHJvbCBzaGlmdCBpc28tbGVmdHRhYildICMndGFiLXByZXZpb3VzKQotICAgIG1hcCkKLSAg IlRhYiBCYXIgbW9kZSBtYXAuIikKLQogKGRlZmluZS1taW5vci1tb2RlIHRhYi1iYXItbW9kZQog ICAiVG9nZ2xlIHRoZSB0YWIgYmFyIGluIGFsbCBncmFwaGljYWwgZnJhbWVzIChUYWIgQmFyIG1v ZGUpLgogCi0tIAoyLjQ3LjEKCg== --0000000000001f4de1062cdd57fe--
bug-gnu-emacs@HIDDEN
:bug#75918
; Package emacs
.
Full text available.Received: (at 75918) by debbugs.gnu.org; 29 Jan 2025 18:58:50 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 29 13:58:49 2025 Received: from localhost ([127.0.0.1]:43036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tdDGz-00053S-KA for submit <at> debbugs.gnu.org; Wed, 29 Jan 2025 13:58:49 -0500 Received: from relay8-d.mail.gandi.net ([2001:4b98:dc4:8::228]:60195) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1tdDGx-00053C-CW for 75918 <at> debbugs.gnu.org; Wed, 29 Jan 2025 13:58:48 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 5887A4442E; Wed, 29 Jan 2025 18:58:35 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Ship Mints <shipmints@HIDDEN> Subject: Re: bug#75918: [PATCH] Add new user option tab-bar-define-keys In-Reply-To: <CAN+1HbpfK2R_JoLzHMawcrrnCMBdhn0BNvwyt8JC7=hon4GH8Q@HIDDEN> (Ship Mints's message of "Wed, 29 Jan 2025 13:45:28 -0500") Organization: LINKOV.NET References: <CAN+1Hbq+WeBCv9ZWC_JT_6UooqsQC3YGESkbCzC-OncU2HLKDQ@HIDDEN> <87tt9iawy7.fsf@HIDDEN> <CAN+1HbpJ58BFX801toGrfO4+yCBBhQyuEWEmv+cr-u58PzVW7A@HIDDEN> <87r04ledga.fsf@HIDDEN> <CAN+1HbonAx2OX=O-B_yUfGdq=jEV8CpVGd_nRp+34Mf05s2nrA@HIDDEN> <87jzadeblt.fsf@HIDDEN> <CAN+1HbpfK2R_JoLzHMawcrrnCMBdhn0BNvwyt8JC7=hon4GH8Q@HIDDEN> Date: Wed, 29 Jan 2025 20:58:09 +0200 Message-ID: <87a5b9e9by.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdefjeekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrdeliedrledtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrdeliedrledtpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepvddprhgtphhtthhopeejheeludekseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepshhhihhpmhhinhhtshesghhmrghilhdrtghomh X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75918 Cc: 75918 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) > + (when (memq tab-bar-define-keys '(t tab)) > + (define-key tab-bar-mode-map [(control tab)] #'tab-next) > + (define-key tab-bar-mode-map [(control shift tab)] #'tab-previous) > + (define-key tab-bar-mode-map [(control shift iso-lefttab)] #'tab-previous)) But we still need to check with global-key-binding here before binding TAB keys. This will ensure backwards-compatibility. > -(defun tab-bar-mode--tab-key-bind (map key binding) > - ;; Don't override user customized global key bindings > - (define-key map key > - `(menu-item "" ,binding > - :filter ,(lambda (cmd) (unless (global-key-binding key) cmd)))))
bug-gnu-emacs@HIDDEN
:bug#75918
; Package emacs
.
Full text available.Received: (at 75918) by debbugs.gnu.org; 29 Jan 2025 18:47:28 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 29 13:47:28 2025 Received: from localhost ([127.0.0.1]:43001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tdD5z-0004Yy-L9 for submit <at> debbugs.gnu.org; Wed, 29 Jan 2025 13:47:28 -0500 Received: from mail-vk1-xa2e.google.com ([2607:f8b0:4864:20::a2e]:42047) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <shipmints@HIDDEN>) id 1tdD5x-0004Yi-DW for 75918 <at> debbugs.gnu.org; Wed, 29 Jan 2025 13:47:26 -0500 Received: by mail-vk1-xa2e.google.com with SMTP id 71dfb90a1353d-518799f2828so551214e0c.0 for <75918 <at> debbugs.gnu.org>; Wed, 29 Jan 2025 10:47:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738176439; x=1738781239; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=IPX0xGxAXYQ08gl7H8shxqf+sxFGlkF9bEqnd2yt/g0=; b=RvyKfBekgzSaoa38uT84g+tYelde5w88NcbWVPP/Nug4tTBUDxmc7liaYtj2PUMHgg ed2bLzQxhS8Xx4Px8uSWBlIyVFqan5GzmIBsPEv2zEO928PbWdEAtDwzJLp3mlanUo3t AKRGDPDYyNLZjlrjPZT2JgAKeb2b9OA47iJbv+09RhxvD9xw899DVvtNz0N24gTf0nWw T/UgwSLY9HNNhbLnrx+bf4fA/vrwvwySA5gSAKnxOSCNakRxdcKl41DdFxiRMAMZqm5f D8GqVcV6L+zOgsOkrQCwJOj8HWVbwprMhu1SdqWWMub21L2HJDyEunJ/gv3QeXMMdZIp ev+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738176439; x=1738781239; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IPX0xGxAXYQ08gl7H8shxqf+sxFGlkF9bEqnd2yt/g0=; b=sp/uh0ZFhXcEhbiZYRj/gViSQePhx4DjOdf9fk53Wng3W56CrRrpm33C4rNZNFjjac BK2cvCtOSHGlSQCU9mU7sajzn0WAGJ8qRvX3rH4pQMOv+iDrjb1c/S0WBewtz64/4+Dn MzhhUFedyh3GMfObA9cOImIfaeul6no5E5JsKX2vgvs/12sjJKSyzQJr+wm8/6pFqgKg VlNFfbsWnHG1iqPzBsPQK/uSG6IkMKDtc+JDDvucwe3+Q9f5Or4mEwB0t3sBDttNfAp7 /b0BNuAlnEFz3yIsPA1IH3z/XbEWx4E0qwSk9qOsNhYZmDivF9DncDwuNDl0CYVMjqBl tPnA== X-Gm-Message-State: AOJu0YxUMCKBy7BRUVem9qcjUICo2a8hqU9ZuUTaUdi3hQPDPzyDb6Pf v+GkIrRivISK0La+yDHJbLB8CEpcIgUPPQUlJMQ/vOP73v+fCYnWWJADKzarl9tUFfTMOgBCCbV qLN/FsHm54G8KLiEoWYI4aq+kTWA= X-Gm-Gg: ASbGncs+NsICwsQtGaeX3FZ6GwZ7wgrsXebnfiHHbLF2EOwjQ4fI4wte5CRBmoKmefi Z+rntvYywFgAanrS+Z5nCBEnsRD0eXqGZzggfmEM/BJ8JpMrM2AK8nW5xCCsLSB2ikOCYPWqIvY mhJXrqFq8= X-Google-Smtp-Source: AGHT+IEC79gADub3jfuquwVaez7+4coeqVL+okzulfEAsR5TQkqhX9oXSjS6KR/zDre4RrK85msL3oAF1Uo5rfyZRy4= X-Received: by 2002:a05:6122:d85:b0:515:d230:f2c6 with SMTP id 71dfb90a1353d-51eaf217758mr542237e0c.7.1738176439405; Wed, 29 Jan 2025 10:47:19 -0800 (PST) MIME-Version: 1.0 References: <CAN+1Hbq+WeBCv9ZWC_JT_6UooqsQC3YGESkbCzC-OncU2HLKDQ@HIDDEN> <87tt9iawy7.fsf@HIDDEN> <CAN+1HbpJ58BFX801toGrfO4+yCBBhQyuEWEmv+cr-u58PzVW7A@HIDDEN> <87r04ledga.fsf@HIDDEN> <CAN+1HbonAx2OX=O-B_yUfGdq=jEV8CpVGd_nRp+34Mf05s2nrA@HIDDEN> <87jzadeblt.fsf@HIDDEN> In-Reply-To: <87jzadeblt.fsf@HIDDEN> From: Ship Mints <shipmints@HIDDEN> Date: Wed, 29 Jan 2025 13:45:28 -0500 X-Gm-Features: AWEUYZlxcVB6eeahd_J8rmdHLdem-Ljz082hB5HV2BH_YDUI9LGrxVQF5CEoRQw Message-ID: <CAN+1HbpfK2R_JoLzHMawcrrnCMBdhn0BNvwyt8JC7=hon4GH8Q@HIDDEN> Subject: Re: bug#75918: [PATCH] Add new user option tab-bar-define-keys To: Juri Linkov <juri@HIDDEN> Content-Type: multipart/mixed; boundary="0000000000003b7b0f062cdcbd5a" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75918 Cc: 75918 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --0000000000003b7b0f062cdcbd5a Content-Type: multipart/alternative; boundary="0000000000003b7b0c062cdcbd58" --0000000000003b7b0c062cdcbd58 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Revised patch attached. On Wed, Jan 29, 2025 at 1:09=E2=80=AFPM Juri Linkov <juri@HIDDEN> wrote= : > > Right. How about I get rid of tab-bar-mode--tab-key-bind and just bind > > normally? I'll submit a revised patch shortly, if so. > > Yes, please do. > > TIA. > > > >>> This is useful to avoid key binding conflicts, such as when > folding > > in > > >>> outline mode using TAB keys, or when a user wants to define her > own > > >>> tab-bar keys without first having to remove the defaults. > > >> > > >> The current implementation was intended to allow removing the > > default keys > > >> easily from 'tab-bar-mode-map'. Here is the NEWS from bug#69578= : > > >> > > >> *** New keymap 'tab-bar-mode-map'. > > >> By default it contains a keybinding 'C-TAB' to switch tabs, but > > only > > >> when 'C-TAB' is not bound globally. You can unbind it if it > > conflicts > > >> with 'C-TAB' in other modes. > > > > > > This strategy doesn't account for the key definition race > condition, > > and > > > relies on the user to have first defined global TAB keys before > > > tab-bar-mode is enabled. > > > > It checks for global-key-binding every time when the user types > C-TAB. > > So it could also check with local-key-binding and > > minor-mode-key-binding in e.g. outline mode, etc. > > > > But since you want to move the C-TAB keybinding from tab-bar-mode-m= ap > > back to tab-bar--define-keys, then :filter is not needed anymore, > > so you can check for global-key-binding only once in > > tab-bar--define-keys. > --0000000000003b7b0c062cdcbd58 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:monospac= e">Revised patch attached.</div></div><br><div class=3D"gmail_quote gmail_q= uote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, Jan 29, 2025 = at 1:09=E2=80=AFPM Juri Linkov <<a href=3D"mailto:juri@HIDDEN">juri@= linkov.net</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style= =3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding= -left:1ex">> Right. How about I get rid of tab-bar-mode--tab-key-bind an= d just bind<br> > normally? I'll submit a revised patch shortly, if so.<br> <br> Yes, please do.<br> <br> TIA.<br> <br> >=C2=A0 =C2=A0 =C2=A0>>> This is useful to avoid key binding co= nflicts, such as when folding<br> >=C2=A0 =C2=A0 =C2=A0in<br> >=C2=A0 =C2=A0 =C2=A0>>> outline mode using TAB keys, or when a= user wants to define her own<br> >=C2=A0 =C2=A0 =C2=A0>>> tab-bar keys without first having to r= emove the defaults.<br> >=C2=A0 =C2=A0 =C2=A0>><br> >=C2=A0 =C2=A0 =C2=A0>> The current implementation was intended to= allow removing the<br> >=C2=A0 =C2=A0 =C2=A0default keys<br> >=C2=A0 =C2=A0 =C2=A0>> easily from 'tab-bar-mode-map'.=C2= =A0 Here is the NEWS from bug#69578:<br> >=C2=A0 =C2=A0 =C2=A0>><br> >=C2=A0 =C2=A0 =C2=A0>>=C2=A0 *** New keymap 'tab-bar-mode-map= '.<br> >=C2=A0 =C2=A0 =C2=A0>>=C2=A0 By default it contains a keybinding = 'C-TAB' to switch tabs, but<br> >=C2=A0 =C2=A0 =C2=A0only<br> >=C2=A0 =C2=A0 =C2=A0>>=C2=A0 when 'C-TAB' is not bound gl= obally.=C2=A0 You can unbind it if it<br> >=C2=A0 =C2=A0 =C2=A0conflicts<br> >=C2=A0 =C2=A0 =C2=A0>>=C2=A0 with 'C-TAB' in other modes.= <br> >=C2=A0 =C2=A0 =C2=A0><br> >=C2=A0 =C2=A0 =C2=A0> This strategy doesn't account for the key = definition race condition,<br> >=C2=A0 =C2=A0 =C2=A0and<br> >=C2=A0 =C2=A0 =C2=A0> relies on the user to have first defined globa= l TAB keys before<br> >=C2=A0 =C2=A0 =C2=A0> tab-bar-mode is enabled.<br> ><br> >=C2=A0 =C2=A0 =C2=A0It checks for global-key-binding every time when th= e user types C-TAB.<br> >=C2=A0 =C2=A0 =C2=A0So it could also check with local-key-binding and<b= r> >=C2=A0 =C2=A0 =C2=A0minor-mode-key-binding in e.g. outline mode, etc.<b= r> ><br> >=C2=A0 =C2=A0 =C2=A0But since you want to move the C-TAB keybinding fro= m tab-bar-mode-map<br> >=C2=A0 =C2=A0 =C2=A0back to tab-bar--define-keys, then :filter is not n= eeded anymore,<br> >=C2=A0 =C2=A0 =C2=A0so you can check for global-key-binding only once i= n<br> >=C2=A0 =C2=A0 =C2=A0tab-bar--define-keys.<br> </blockquote></div> --0000000000003b7b0c062cdcbd58-- --0000000000003b7b0f062cdcbd5a Content-Type: application/octet-stream; name="0001-Add-new-user-option-tab-bar-define-keys.patch" Content-Disposition: attachment; filename="0001-Add-new-user-option-tab-bar-define-keys.patch" Content-Transfer-Encoding: base64 Content-ID: <f_m6i9b0j90> X-Attachment-Id: f_m6i9b0j90 RnJvbSA4N2UzMDhiNDE5YTE1ZTlkYWNhODlmZGY3Yjc1ODEwOTk5ZTNjOTAzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBzaGlwbWludHMgPHNoaXBtaW50c0BnbWFpbC5jb20+CkRhdGU6 IFdlZCwgMjkgSmFuIDIwMjUgMTM6NDM6MDQgLTA1MDAKU3ViamVjdDogW1BBVENIXSBBZGQgbmV3 IHVzZXIgb3B0aW9uIHRhYi1iYXItZGVmaW5lLWtleXMKCiogbGlzcC90YWItYmFyLmVsICh0YWIt YmFyLWRlZmluZS1rZXlzKToKQWRkIG5ldyBkZWZjdXN0b20gdGFiLWJhci1kZWZpbmUta2V5cy4g IFJlb3JnYW5pemUga2V5IGJpbmRpbmcgZnVuY3Rpb25zCnRvIGFjY29tbW9kYXRlLiAgQWxzbyBy ZW1vdmUgY2hlY2tzIGZvciB0YWItYmFyLW1vZGUgZW5hYmxlZCBpbgondGFiLWJhci1zZWxlY3Qt dGFiLW1vZGlmaWVycycsIGFzIHVubmVjZXNzYXJ5IGFuZCB3aGljaCBwcmV2ZW50ZWQgdXNlcgpj aGFuZ2VzIGZyb20gYmVpbmcgYWNjZXB0ZWQgaW4gY2FzZXMgd2hlcmUgdGhlIHVzZXIgZGVmZXJz IGVuYWJsaW5nCnRhYi1iYXItbW9kZS4KLS0tCiBldGMvTkVXUyAgICAgICAgfCAxMSArKysrKysr KysKIGxpc3AvdGFiLWJhci5lbCB8IDY1ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr Ky0tLS0tLS0tLS0tLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgNTUgaW5zZXJ0aW9ucygrKSwgMjEg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZXRjL05FV1MgYi9ldGMvTkVXUwppbmRleCAwOTUw N2FkZWNiOC4uNzRjNTQ5ZWM5ZWEgMTAwNjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBiL2V0Yy9ORVdT CkBAIC0yMzgsNiArMjM4LDE3IEBAIGxhdHRlciB0aHJvd3MgYW4gZXJyb3Igd2hlbiB0aGUgYXJn dW1lbnQgRlJBTUUgY2Fubm90IGJlIGRlbGV0ZWQuCiAqKiogTmV3IGFibm9ybWFsIGhvb2sgJ3Rh Yi1iYXItYXV0by13aWR0aC1mdW5jdGlvbnMnLgogVGhpcyBob29rIGFsbG93cyB5b3UgdG8gY29u dHJvbCB3aGljaCB0YWItYmFyIHRhYnMgYXJlIGF1dG8tcmVzaXplZC4KIAorLS0tCisqKiogTmV3 IHVzZXIgb3B0aW9uICd0YWItYmFyLWRlZmluZS1rZXlzJy4KK1RoaXMgY29udHJvbHMgd2hpY2gg a2V5IGJpbmRpbmdzIHRhYi1iYXIgY3JlYXRlcy4gVmFsdWVzIGFyZSB0LHRoZQorZGVmYXVsdCwg d2hpY2ggZGVmaW5lcyBhbGwga2V5cyBhbmQgaXMgYmFja3dhcmRzIGNvbXBhdGlibGUsICdudW1l cmljCisodGFiIG51bWJlciBzZWxlY3Rpb24gb25seSksICd0YWIgKFRBQiBhbmQgU0hJRlQtVEFC IGtleXMgb25seSksIG5pbAorKHdoaWNoIGRlZmluZXMgbm9uZSkuCisKK1RoaXMgaXMgdXNlZnVs IHRvIGF2b2lkIGtleSBiaW5kaW5nIGNvbmZsaWN0cywgc3VjaCBhcyB3aGVuIGZvbGRpbmcgaW4K K291dGxpbmUgbW9kZSB1c2luZyBUQUIga2V5cywgb3Igd2hlbiBhIHVzZXIgd2FudHMgdG8gZGVm aW5lIGhlciBvd24KK3RhYi1iYXIga2V5cyB3aXRob3V0IGZpcnN0IGhhdmluZyB0byByZW1vdmUg dGhlIGRlZmF1bHRzLgorCiAqKiBQcm9qZWN0CiAKIC0tLQpkaWZmIC0tZ2l0IGEvbGlzcC90YWIt YmFyLmVsIGIvbGlzcC90YWItYmFyLmVsCmluZGV4IGI1NzA5NDliZmVjLi5iNGRhYzM4NjRlZCAx MDA2NDQKLS0tIGEvbGlzcC90YWItYmFyLmVsCisrKyBiL2xpc3AvdGFiLWJhci5lbApAQCAtODYs NiArODYsMzUgQEAgdGFiLWJhci10YWItdW5ncm91cGVkCiAgIDpncm91cCAndGFiLWJhci1mYWNl cykKIAogDAorCisoZGVmdmFyIHRhYi1iYXItbW9kZS1tYXAgKG1ha2Utc3BhcnNlLWtleW1hcCkK KyAgIlRhYiBCYXIgbW9kZSBtYXAuIikKKworKGRlZmN1c3RvbSB0YWItYmFyLWRlZmluZS1rZXlz IHQKKyAgIkRlZmluZSBzcGVjaWZpZWQgdGFiLWJhciBrZXkgYmluZGluZ3MuCitJZiB0LCB0aGUg ZGVmYXVsdCwgYWxsIGtleSBtYXBwaW5ncyBhcmUgZGVmaW5lZC4KKworSWYgXFw9J251bWVyaWMs IGRlZmluZSBvbmx5IG51bWVyaWMgc2VsZWN0LXRhYiBrZXkgbWFwcGluZ3MsIGFuZCBpbgorY29u anVuY3Rpb24gd2l0aCBgdGFiLWJhci1zZWxlY3QtdGFiLW1vZGlmaWVycycsIHdoaWNoIHNlZS4K KworSWYgXFw9J3RhYiwgZGVmaW5lIG9ubHkgVEFCIGFuZCBTSElGVC1UQUIgdGFiLXNlbGVjdGlv biBrZXkgbWFwcGluZ3MuCisKK0lmIG5pbCwgZG8gbm90IGRlZmluZSBhbnkga2V5IG1hcHBpbmdz LgorCitDdXN0b21pemUgdGhpcyBvcHRpb24sIG9yIHVzZSBgc2V0b3B0JyB0byBlbnN1cmUgaXQg d2lsbCB0YWtlIGVmZmVjdC4iCisgIDp0eXBlICcoY2hvaWNlIChjb25zdCA6dGFnICJBbGwga2V5 cyIgdCkKKyAgICAgICAgICAgICAgICAgKGNvbnN0IDp0YWcgIk51bWVyaWMgdGFiIHNlbGVjdGlv biBrZXlzIiBudW1lcmljKQorICAgICAgICAgICAgICAgICAoY29uc3QgOnRhZyAiVEFCIGFuZCBT SElGVC1UQUIgc2VsZWN0aW9uIGtleXMiIHRhYikKKyAgICAgICAgICAgICAgICAgKGNvbnN0IDp0 YWcgIk5vbmUiIG5pbCkpCisgIDppbml0aWFsaXplICMnY3VzdG9tLWluaXRpYWxpemUtZGVmYXVs dAorICA6c2V0IChsYW1iZGEgKHN5bSB2YWwpCisgICAgICAgICAodGFiLWJhci0tdW5kZWZpbmUt a2V5cykKKyAgICAgICAgIChzZXQtZGVmYXVsdCBzeW0gdmFsKQorICAgICAgICAgOzsgRW5hYmxl IHRoZSBuZXcga2V5YmluZGluZ3MKKyAgICAgICAgICh0YWItYmFyLS1kZWZpbmUta2V5cykpCisg IDpncm91cCAndGFiLWJhcgorICA6dmVyc2lvbiAiMzEuMSIpCisKIChkZWZjdXN0b20gdGFiLWJh ci1zZWxlY3QtdGFiLW1vZGlmaWVycyAnKCkKICAgIkxpc3Qgb2YgbW9kaWZpZXIga2V5cyBmb3Ig c2VsZWN0aW5nIHRhYi1iYXIgdGFicyBieSB0aGVpciBudW1iZXJzLgogUG9zc2libGUgbW9kaWZp ZXIga2V5cyBhcmUgYGNvbnRyb2wnLCBgbWV0YScsIGBzaGlmdCcsIGBoeXBlcicsIGBzdXBlcicg YW5kCkBAIC0xMDQsMTggKzEzMywxNyBAQCB0YWItYmFyLXNlbGVjdC10YWItbW9kaWZpZXJzCiAg ICAgICAgICAgICAgIChjb25zdCBhbHQpKQogICA6aW5pdGlhbGl6ZSAjJ2N1c3RvbS1pbml0aWFs aXplLWRlZmF1bHQKICAgOnNldCAobGFtYmRhIChzeW0gdmFsKQotICAgICAgICAgKHdoZW4gdGFi LWJhci1tb2RlCi0gICAgICAgICAgICh0YWItYmFyLS11bmRlZmluZS1rZXlzKSkKKyAgICAgICAg ICh0YWItYmFyLS11bmRlZmluZS1rZXlzKQogICAgICAgICAgKHNldC1kZWZhdWx0IHN5bSB2YWwp Ci0gICAgICAgICA7OyBSZWVuYWJsZSB0aGUgdGFiLWJhciB3aXRoIG5ldyBrZXliaW5kaW5ncwot ICAgICAgICAgKHdoZW4gdGFiLWJhci1tb2RlCi0gICAgICAgICAgICh0YWItYmFyLS1kZWZpbmUt a2V5cykpKQorICAgICAgICAgOzsgRW5hYmxlIHRoZSBuZXcga2V5YmluZGluZ3MKKyAgICAgICAg ICh0YWItYmFyLS1kZWZpbmUta2V5cykpCiAgIDpncm91cCAndGFiLWJhcgogICA6dmVyc2lvbiAi MjcuMSIpCiAKIChkZWZ1biB0YWItYmFyLS1kZWZpbmUta2V5cyAoKQogICAiSW5zdGFsbCBrZXkg YmluZGluZ3MgdG8gc3dpdGNoIGJldHdlZW4gdGFicyBpZiBzbyBjb25maWd1cmVkLiIKLSAgKHdo ZW4gdGFiLWJhci1zZWxlY3QtdGFiLW1vZGlmaWVycworICAod2hlbiAoYW5kIChtZW1xIHRhYi1i YXItZGVmaW5lLWtleXMgJyh0IG51bWVyaWMpKQorICAgICAgICAgICAgIHRhYi1iYXItc2VsZWN0 LXRhYi1tb2RpZmllcnMpCiAgICAgKGRlZmluZS1rZXkgdGFiLWJhci1tb2RlLW1hcAogICAgICAg ICAgICAgICAgICh2ZWN0b3IgKGFwcGVuZCB0YWItYmFyLXNlbGVjdC10YWItbW9kaWZpZXJzIChs aXN0ID8wKSkpCiAgICAgICAgICAgICAgICAgIyd0YWItcmVjZW50KQpAQCAtMTI4LDYgKzE1Niwx MSBAQCB0YWItYmFyLS1kZWZpbmUta2V5cwogICAgICAgICAgICAgICAgICh2ZWN0b3IgKGFwcGVu ZCB0YWItYmFyLXNlbGVjdC10YWItbW9kaWZpZXJzIChsaXN0ID85KSkpCiAgICAgICAgICAgICAg ICAgIyd0YWItbGFzdCkpCiAKKyAgKHdoZW4gKG1lbXEgdGFiLWJhci1kZWZpbmUta2V5cyAnKHQg dGFiKSkKKyAgICAoZGVmaW5lLWtleSB0YWItYmFyLW1vZGUtbWFwIFsoY29udHJvbCB0YWIpXSAj J3RhYi1uZXh0KQorICAgIChkZWZpbmUta2V5IHRhYi1iYXItbW9kZS1tYXAgWyhjb250cm9sIHNo aWZ0IHRhYildICMndGFiLXByZXZpb3VzKQorICAgIChkZWZpbmUta2V5IHRhYi1iYXItbW9kZS1t YXAgWyhjb250cm9sIHNoaWZ0IGlzby1sZWZ0dGFiKV0gIyd0YWItcHJldmlvdXMpKQorCiAgIDs7 IFJlcGxhY2UgZGVmYXVsdCB2YWx1ZSB3aXRoIGEgY29uZGl0aW9uIHRoYXQgc3VwcG9ydHMgZGlz cGxheWluZwogICA7OyBnbG9iYWwtbW9kZS1zdHJpbmcgaW4gdGhlIHRhYiBiYXIgaW5zdGVhZCBv ZiB0aGUgbW9kZSBsaW5lLgogICAod2hlbiAoYW5kIChtZW1xICd0YWItYmFyLWZvcm1hdC1nbG9i YWwgdGFiLWJhci1mb3JtYXQpCkBAIC0xNTIsNyArMTg1LDExIEBAIHRhYi1iYXItLXVuZGVmaW5l LWtleXMKICAgICAgICAgICAgICAgICAgIG5pbCB0KSkKICAgICAoZGVmaW5lLWtleSB0YWItYmFy LW1vZGUtbWFwCiAgICAgICAgICAgICAgICAgKHZlY3RvciAoYXBwZW5kIHRhYi1iYXItc2VsZWN0 LXRhYi1tb2RpZmllcnMgKGxpc3QgPzkpKSkKLSAgICAgICAgICAgICAgICBuaWwgdCkpKQorICAg ICAgICAgICAgICAgIG5pbCB0KSkKKworICAoZGVmaW5lLWtleSB0YWItYmFyLW1vZGUtbWFwIFso Y29udHJvbCB0YWIpXSBuaWwgdCkKKyAgKGRlZmluZS1rZXkgdGFiLWJhci1tb2RlLW1hcCBbKGNv bnRyb2wgc2hpZnQgdGFiKV0gbmlsIHQpCisgIChkZWZpbmUta2V5IHRhYi1iYXItbW9kZS1tYXAg Wyhjb250cm9sIHNoaWZ0IGlzby1sZWZ0dGFiKV0gbmlsIHQpKQogCiAoZGVmdW4gdGFiLWJhci0t bG9hZC1idXR0b25zICgpCiAgICJMb2FkIHRoZSBpY29ucyBmb3IgdGhlIHRhYiBidXR0b25zLiIK QEAgLTI0MiwyMCArMjc5LDYgQEAgdGFiLWJhci0tdXBkYXRlLXRhYi1iYXItbGluZXMKICAgICAg ICAgICAgICAgICAgICAgICAoaWYgKGFuZCB0YWItYmFyLW1vZGUgKGVxIHRhYi1iYXItc2hvdyB0 KSkgMSAwKSkKICAgICAgICAgICAgICAgICAoYXNzcS1kZWxldGUtYWxsICd0YWItYmFyLWxpbmVz IGRlZmF1bHQtZnJhbWUtYWxpc3QpKSkpKQogCi0oZGVmdW4gdGFiLWJhci1tb2RlLS10YWIta2V5 LWJpbmQgKG1hcCBrZXkgYmluZGluZykKLSAgOzsgRG9uJ3Qgb3ZlcnJpZGUgdXNlciBjdXN0b21p emVkIGdsb2JhbCBrZXkgYmluZGluZ3MKLSAgKGRlZmluZS1rZXkgbWFwIGtleQotICAgIGAobWVu dS1pdGVtICIiICxiaW5kaW5nCi0gICAgICA6ZmlsdGVyICwobGFtYmRhIChjbWQpICh1bmxlc3Mg KGdsb2JhbC1rZXktYmluZGluZyBrZXkpIGNtZCkpKSkpCi0KLShkZWZ2YXIgdGFiLWJhci1tb2Rl LW1hcAotICAobGV0ICgobWFwIChtYWtlLXNwYXJzZS1rZXltYXApKSkKLSAgICAodGFiLWJhci1t b2RlLS10YWIta2V5LWJpbmQgbWFwIFsoY29udHJvbCB0YWIpXSAjJ3RhYi1uZXh0KQotICAgICh0 YWItYmFyLW1vZGUtLXRhYi1rZXktYmluZCBtYXAgWyhjb250cm9sIHNoaWZ0IHRhYildICMndGFi LXByZXZpb3VzKQotICAgICh0YWItYmFyLW1vZGUtLXRhYi1rZXktYmluZCBtYXAgWyhjb250cm9s IHNoaWZ0IGlzby1sZWZ0dGFiKV0gIyd0YWItcHJldmlvdXMpCi0gICAgbWFwKQotICAiVGFiIEJh ciBtb2RlIG1hcC4iKQotCiAoZGVmaW5lLW1pbm9yLW1vZGUgdGFiLWJhci1tb2RlCiAgICJUb2dn bGUgdGhlIHRhYiBiYXIgaW4gYWxsIGdyYXBoaWNhbCBmcmFtZXMgKFRhYiBCYXIgbW9kZSkuCiAK LS0gCjIuNDcuMQoK --0000000000003b7b0f062cdcbd5a--
bug-gnu-emacs@HIDDEN
:bug#75918
; Package emacs
.
Full text available.Received: (at 75918) by debbugs.gnu.org; 29 Jan 2025 18:09:52 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 29 13:09:52 2025 Received: from localhost ([127.0.0.1]:42930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tdCVb-0002qL-K7 for submit <at> debbugs.gnu.org; Wed, 29 Jan 2025 13:09:51 -0500 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]:35693) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1tdCVY-0002q0-NB for 75918 <at> debbugs.gnu.org; Wed, 29 Jan 2025 13:09:49 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 11C314432C; Wed, 29 Jan 2025 18:09:39 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Ship Mints <shipmints@HIDDEN> Subject: Re: bug#75918: [PATCH] Add new user option tab-bar-define-keys In-Reply-To: <CAN+1HbonAx2OX=O-B_yUfGdq=jEV8CpVGd_nRp+34Mf05s2nrA@HIDDEN> (Ship Mints's message of "Wed, 29 Jan 2025 12:52:18 -0500") Organization: LINKOV.NET References: <CAN+1Hbq+WeBCv9ZWC_JT_6UooqsQC3YGESkbCzC-OncU2HLKDQ@HIDDEN> <87tt9iawy7.fsf@HIDDEN> <CAN+1HbpJ58BFX801toGrfO4+yCBBhQyuEWEmv+cr-u58PzVW7A@HIDDEN> <87r04ledga.fsf@HIDDEN> <CAN+1HbonAx2OX=O-B_yUfGdq=jEV8CpVGd_nRp+34Mf05s2nrA@HIDDEN> Date: Wed, 29 Jan 2025 20:09:02 +0200 Message-ID: <87jzadeblt.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdefieekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrdeliedrledtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrdeliedrledtpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepvddprhgtphhtthhopeejheeludekseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepshhhihhpmhhinhhtshesghhmrghilhdrtghomh X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75918 Cc: 75918 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) > Right. How about I get rid of tab-bar-mode--tab-key-bind and just bind > normally? I'll submit a revised patch shortly, if so. Yes, please do. TIA. > >>> This is useful to avoid key binding conflicts, such as when folding > in > >>> outline mode using TAB keys, or when a user wants to define her own > >>> tab-bar keys without first having to remove the defaults. > >> > >> The current implementation was intended to allow removing the > default keys > >> easily from 'tab-bar-mode-map'. Here is the NEWS from bug#69578: > >> > >> *** New keymap 'tab-bar-mode-map'. > >> By default it contains a keybinding 'C-TAB' to switch tabs, but > only > >> when 'C-TAB' is not bound globally. You can unbind it if it > conflicts > >> with 'C-TAB' in other modes. > > > > This strategy doesn't account for the key definition race condition, > and > > relies on the user to have first defined global TAB keys before > > tab-bar-mode is enabled. > > It checks for global-key-binding every time when the user types C-TAB. > So it could also check with local-key-binding and > minor-mode-key-binding in e.g. outline mode, etc. > > But since you want to move the C-TAB keybinding from tab-bar-mode-map > back to tab-bar--define-keys, then :filter is not needed anymore, > so you can check for global-key-binding only once in > tab-bar--define-keys.
bug-gnu-emacs@HIDDEN
:bug#75918
; Package emacs
.
Full text available.Received: (at 75918) by debbugs.gnu.org; 29 Jan 2025 17:54:17 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 29 12:54:17 2025 Received: from localhost ([127.0.0.1]:42909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tdCGX-00029P-6q for submit <at> debbugs.gnu.org; Wed, 29 Jan 2025 12:54:17 -0500 Received: from mail-ua1-x934.google.com ([2607:f8b0:4864:20::934]:56525) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <shipmints@HIDDEN>) id 1tdCGU-000298-9L for 75918 <at> debbugs.gnu.org; Wed, 29 Jan 2025 12:54:14 -0500 Received: by mail-ua1-x934.google.com with SMTP id a1e0cc1a2514c-85bad7be09dso3929051241.0 for <75918 <at> debbugs.gnu.org>; Wed, 29 Jan 2025 09:54:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738173248; x=1738778048; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Up1rnwe6tVG6hzG5xeTQyvmDavewpTWRp6AiuB/BFuQ=; b=SYvwnbY4e7OzvodIzbgySUW5SUzusmeC/TYClRnwAI2j+66wD9rZnEWSub5jMOTn86 kv/bF3ZLDoq6mdusyl/3H3eFtxzHGCvRv4LBEv4+GLd6+bw3223tDWIaoApGrbOFGu2e Fd02dJrTlP9m+BJMLmX4FoiA9D3ZYtsQGLGvvHP4Q02UCe9e86S0UtaoQ59ZIdWEiAjw KNIJIolCGslw8kGqQPSGg7jaK2vcW7XQNO62UXIqWoeapFNPGOHNZLl/YsxaIM/BHETx pBY5r42VwvDydj7A+4p+DXRzX2lcUQ51j6w/+99ywkwBfsvJkGCIYMyERtdqLSdZrZ7S bekg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738173248; x=1738778048; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Up1rnwe6tVG6hzG5xeTQyvmDavewpTWRp6AiuB/BFuQ=; b=B1y77igtD81HNlxEj3tr/OJGzPLZ20VUzV5e6orRfGgV7DttpzoBfpM9kKWgbIPHWP 8gthzndBBiuudh5HSUiRo+iZ1XT3hzrtNlkXBMfnhN4joR8NA6Q9oUhmUyF5WO6HlAU7 kXPlVsKveU/K7RGBFts+8Ivjz6IssVpQZ4mkNk4Iytg66hF8CL4HWljJZsbB2Ck7IddI 36pgnf5N9YrmVgId0/2pRe7QXxNFNEQUUXnmVTNDPyy0G7FZj06qHjWvcMaMvjrB73nB /44gB0ZzpyTmCO/OqMvbwsWGPY3wflYEoXNo2kLTuRqGGJOQMo846dK/ILKg2sSGk1nI CUng== X-Gm-Message-State: AOJu0YyGfkvNm7nkLQEstpbw13983yWeO7Mjn6ik992a6aBHqk8p0ErO 4S5n9+7Vf9FtAz74F3ng4RbIVLgv6rACWAu9/iM7aOMO0I5aAo7X5S4Zzfwj9+QUSz+CKMQAXdI 8DzeR0Qvffde3nQWxU4fSlDzzEfUeeErM X-Gm-Gg: ASbGncthnq4TR4D9AG7nWVOFYqctgPaJ274SEGl+KL/Q7XaN+Q5kkKNgl/nYJ5WpGJE FuyWbZipITyEEYD4v3gTwbFM/6OTUTUnpcdVPW7ESyUtZvYTuN4OlTgFB6ks17OR9FahhZlOg X-Google-Smtp-Source: AGHT+IHF7n114tJvwvwO4SFJi7FXSoqASIU4xmCy4EdxF/8SQOjYs71OuIJbjIkEYJSuvtiZgT6YdjlqJx0Pe0loAck= X-Received: by 2002:a67:f08d:0:b0:4b2:cc94:1d6a with SMTP id ada2fe7eead31-4b9a5272b08mr3050630137.19.1738173248420; Wed, 29 Jan 2025 09:54:08 -0800 (PST) MIME-Version: 1.0 References: <CAN+1Hbq+WeBCv9ZWC_JT_6UooqsQC3YGESkbCzC-OncU2HLKDQ@HIDDEN> <87tt9iawy7.fsf@HIDDEN> <CAN+1HbpJ58BFX801toGrfO4+yCBBhQyuEWEmv+cr-u58PzVW7A@HIDDEN> <87r04ledga.fsf@HIDDEN> In-Reply-To: <87r04ledga.fsf@HIDDEN> From: Ship Mints <shipmints@HIDDEN> Date: Wed, 29 Jan 2025 12:52:18 -0500 X-Gm-Features: AWEUYZntz_LanNvddo5dua646R-i54bTS_sDdaY_59QT9xcRci7Vj3-YJLVmQiw Message-ID: <CAN+1HbonAx2OX=O-B_yUfGdq=jEV8CpVGd_nRp+34Mf05s2nrA@HIDDEN> Subject: Re: bug#75918: [PATCH] Add new user option tab-bar-define-keys To: Juri Linkov <juri@HIDDEN> Content-Type: multipart/alternative; boundary="00000000000007c1de062cdbff0c" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75918 Cc: 75918 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --00000000000007c1de062cdbff0c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Right. How about I get rid of tab-bar-mode--tab-key-bind and just bind normally? I'll submit a revised patch shortly, if so. On Wed, Jan 29, 2025 at 12:35=E2=80=AFPM Juri Linkov <juri@HIDDEN> wrot= e: > >>> This is useful to avoid key binding conflicts, such as when folding i= n > >>> outline mode using TAB keys, or when a user wants to define her own > >>> tab-bar keys without first having to remove the defaults. > >> > >> The current implementation was intended to allow removing the default > keys > >> easily from 'tab-bar-mode-map'. Here is the NEWS from bug#69578: > >> > >> *** New keymap 'tab-bar-mode-map'. > >> By default it contains a keybinding 'C-TAB' to switch tabs, but only > >> when 'C-TAB' is not bound globally. You can unbind it if it conflict= s > >> with 'C-TAB' in other modes. > > > > This strategy doesn't account for the key definition race condition, an= d > > relies on the user to have first defined global TAB keys before > > tab-bar-mode is enabled. > > It checks for global-key-binding every time when the user types C-TAB. > So it could also check with local-key-binding and > minor-mode-key-binding in e.g. outline mode, etc. > > But since you want to move the C-TAB keybinding from tab-bar-mode-map > back to tab-bar--define-keys, then :filter is not needed anymore, > so you can check for global-key-binding only once in tab-bar--define-keys= . > --00000000000007c1de062cdbff0c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:monospac= e">Right. How about I get rid of=C2=A0tab-bar-mode--tab-key-bind and just b= ind normally? I'll submit=C2=A0a revised patch shortly, if so.</div></d= iv><br><div class=3D"gmail_quote gmail_quote_container"><div dir=3D"ltr" cl= ass=3D"gmail_attr">On Wed, Jan 29, 2025 at 12:35=E2=80=AFPM Juri Linkov <= ;<a href=3D"mailto:juri@HIDDEN">juri@HIDDEN</a>> wrote:<br></div= ><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border= -left:1px solid rgb(204,204,204);padding-left:1ex">>>> This is use= ful to avoid key binding conflicts, such as when folding in<br> >>> outline mode using TAB keys, or when a user wants to define he= r own<br> >>> tab-bar keys without first having to remove the defaults.<br> >><br> >> The current implementation was intended to allow removing the defa= ult keys<br> >> easily from 'tab-bar-mode-map'.=C2=A0 Here is the NEWS fro= m bug#69578:<br> >><br> >>=C2=A0 *** New keymap 'tab-bar-mode-map'.<br> >>=C2=A0 By default it contains a keybinding 'C-TAB' to switc= h tabs, but only<br> >>=C2=A0 when 'C-TAB' is not bound globally.=C2=A0 You can un= bind it if it conflicts<br> >>=C2=A0 with 'C-TAB' in other modes.<br> ><br> > This strategy doesn't account for the key definition race conditio= n, and<br> > relies on the user to have first defined global TAB keys before<br> > tab-bar-mode is enabled.<br> <br> It checks for global-key-binding every time when the user types C-TAB.<br> So it could also check with local-key-binding and<br> minor-mode-key-binding in e.g. outline mode, etc.<br> <br> But since you want to move the C-TAB keybinding from tab-bar-mode-map<br> back to tab-bar--define-keys, then :filter is not needed anymore,<br> so you can check for global-key-binding only once in tab-bar--define-keys.<= br> </blockquote></div> --00000000000007c1de062cdbff0c--
bug-gnu-emacs@HIDDEN
:bug#75918
; Package emacs
.
Full text available.Received: (at 75918) by debbugs.gnu.org; 29 Jan 2025 17:35:22 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 29 12:35:21 2025 Received: from localhost ([127.0.0.1]:42855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tdByD-0001LW-I2 for submit <at> debbugs.gnu.org; Wed, 29 Jan 2025 12:35:21 -0500 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]:38967) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1tdByB-0001Fo-In for 75918 <at> debbugs.gnu.org; Wed, 29 Jan 2025 12:35:20 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id E80224431B; Wed, 29 Jan 2025 17:35:09 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Ship Mints <shipmints@HIDDEN> Subject: Re: bug#75918: [PATCH] Add new user option tab-bar-define-keys In-Reply-To: <CAN+1HbpJ58BFX801toGrfO4+yCBBhQyuEWEmv+cr-u58PzVW7A@HIDDEN> (Ship Mints's message of "Wed, 29 Jan 2025 06:51:57 -0500") Organization: LINKOV.NET References: <CAN+1Hbq+WeBCv9ZWC_JT_6UooqsQC3YGESkbCzC-OncU2HLKDQ@HIDDEN> <87tt9iawy7.fsf@HIDDEN> <CAN+1HbpJ58BFX801toGrfO4+yCBBhQyuEWEmv+cr-u58PzVW7A@HIDDEN> Date: Wed, 29 Jan 2025 19:29:09 +0200 Message-ID: <87r04ledga.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdefieduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrdeliedrledtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrdeliedrledtpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepvddprhgtphhtthhopeejheeludekseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepshhhihhpmhhinhhtshesghhmrghilhdrtghomh X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75918 Cc: 75918 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >>> This is useful to avoid key binding conflicts, such as when folding in >>> outline mode using TAB keys, or when a user wants to define her own >>> tab-bar keys without first having to remove the defaults. >> >> The current implementation was intended to allow removing the default keys >> easily from 'tab-bar-mode-map'. Here is the NEWS from bug#69578: >> >> *** New keymap 'tab-bar-mode-map'. >> By default it contains a keybinding 'C-TAB' to switch tabs, but only >> when 'C-TAB' is not bound globally. You can unbind it if it conflicts >> with 'C-TAB' in other modes. > > This strategy doesn't account for the key definition race condition, and > relies on the user to have first defined global TAB keys before > tab-bar-mode is enabled. It checks for global-key-binding every time when the user types C-TAB. So it could also check with local-key-binding and minor-mode-key-binding in e.g. outline mode, etc. But since you want to move the C-TAB keybinding from tab-bar-mode-map back to tab-bar--define-keys, then :filter is not needed anymore, so you can check for global-key-binding only once in tab-bar--define-keys.
bug-gnu-emacs@HIDDEN
:bug#75918
; Package emacs
.
Full text available.Received: (at 75918) by debbugs.gnu.org; 29 Jan 2025 12:44:48 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 29 07:44:48 2025 Received: from localhost ([127.0.0.1]:40230 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1td7R2-0000Qd-9V for submit <at> debbugs.gnu.org; Wed, 29 Jan 2025 07:44:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36326) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1td7Qz-0000QN-SL for 75918 <at> debbugs.gnu.org; Wed, 29 Jan 2025 07:44:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1td7Qt-00079Y-C0; Wed, 29 Jan 2025 07:44:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=9uhD53dPVP1B3fCNjbQqPYVtOucUFUpjvZ+jqs4JPcE=; b=W5dzzpupXGzY s0+CJixw77Jm5+nky6rKbkqd5CvpLN0NURJzSgsuAr99P9ZEsfmzsZpb7QMh63+ztPX0jH5EoFMrS xQLqGWBurv6Am4VH91ld8JfdiIPXaoCCZjPUY+usIewssFPboVOefQpnOwfoC4psGDxtRj1R+x9Jt KWYQuk0rOwP3ScBpdACEndJPwqqBy6Oe0oQWm3Otj0bMcQY0Qe2j/LS91aa2Stt3SuCRmehCJ4UJz dr6rWmckcWGd8FYkHVbDGu91m6m3JRK0N1gyN0xNaDm/ejaUdVfgkqWbGcJ45k9MuiLdLBJJVrUaT B7gXO9bAzNiJ0tMMqrr79A==; Date: Wed, 29 Jan 2025 14:44:37 +0200 Message-Id: <86wmedn616.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Juri Linkov <juri@HIDDEN> In-Reply-To: <87tt9iawy7.fsf@HIDDEN> (message from Juri Linkov on Wed, 29 Jan 2025 09:41:36 +0200) Subject: Re: bug#75918: [PATCH] Add new user option tab-bar-define-keys References: <CAN+1Hbq+WeBCv9ZWC_JT_6UooqsQC3YGESkbCzC-OncU2HLKDQ@HIDDEN> <87tt9iawy7.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75918 Cc: 75918 <at> debbugs.gnu.org, shipmints@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: 75918 <at> debbugs.gnu.org > From: Juri Linkov <juri@HIDDEN> > Date: Wed, 29 Jan 2025 09:41:36 +0200 > > Last but not least: have you signed FSF papers for your patches to be applied? Yes, the assignment is on file.
bug-gnu-emacs@HIDDEN
:bug#75918
; Package emacs
.
Full text available.Received: (at 75918) by debbugs.gnu.org; 29 Jan 2025 11:53:56 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 29 06:53:56 2025 Received: from localhost ([127.0.0.1]:40164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1td6do-0003ZQ-3r for submit <at> debbugs.gnu.org; Wed, 29 Jan 2025 06:53:56 -0500 Received: from mail-vk1-xa35.google.com ([2607:f8b0:4864:20::a35]:47254) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <shipmints@HIDDEN>) id 1td6dl-0003Z8-HF for 75918 <at> debbugs.gnu.org; Wed, 29 Jan 2025 06:53:54 -0500 Received: by mail-vk1-xa35.google.com with SMTP id 71dfb90a1353d-517aea3ee2aso3931879e0c.2 for <75918 <at> debbugs.gnu.org>; Wed, 29 Jan 2025 03:53:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738151628; x=1738756428; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=MDzHp6wpqmrAiDj0ulRi2weJMw305rAENSNSTSNxoPk=; b=egfvx+L4M/oY82/GRSbaiHB9PvQNxRZ9shqfSsftPAdI/8AgScdT4p8iqeHwq9sLsg 49aX8JU2HG0fXfwBq+Yk1BEE70t6LBwCQXcrQfpiBRU6B+vX6zDUyf23JeRPNIer2kuL +3UdoyRTot2qMt9PbkOK1RC3yn1g/NGHOdULB6c5pcBuVNgzB6hnhY/Wh294twrbNhFS ZlOeaqELQnmFJJhVAXax1QCVznvm33EwLFDMZl8yjRJXhw9FCvbssNlMD745rySi2Vm5 qLr7SpL3WhVGreCSbumHZAqjVh/+IERAgPGJGb4FEhp+haowOm96iDx/q0/3gnMZlu/I gjrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738151628; x=1738756428; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MDzHp6wpqmrAiDj0ulRi2weJMw305rAENSNSTSNxoPk=; b=WKYcn6QUOrRrn/A411tA3LwyFRs3IO9PeMBsBEDnf0DKb3Rl20bjMwH8qZWeC8rCcy PRBFSndVSEZPjx2mGjokALrzbQPIKKaYC+J4fQhJPtOs94xQK1vs1eWrc/+PXUHR5sto Bu898vZ0ZV+Ur3QzZBi/ILpJUaOEBbPW3WRDYImlMzjMHM9ksUMvzH+BUgvYJOFIcVBF L+wG+Cbx3nGR1uL5rDR9wz0FGfxZ6rQOmXyvkOd2Sa6l+iv7MA6+0rPf59O8cU0fRKCE QUIK90DbiSI59E5NqYH9Xzv3mSJTdDTWMhVU+Vj2rd1OmTtn+tyZbvOnT1+uTsJPbsOv dzpg== X-Gm-Message-State: AOJu0Yx0cR3k3T9RjQvEkeCiT6gtqQO1GCxeF7KSQeEvjffbHRX529mO hoqIbTYe29GJdfCTLEvfLz01rvCK6YpMeJw7j4ZDz5m7ii0ugiJcAO6LhSe8qTRM05SkJqOKCyE rg53fCbQ3OHU5hj9jm8JIvCjvLv0= X-Gm-Gg: ASbGncthqP/gnatoFTwlsKj+Ru2Kj0M7paPbr3w4TOdFonUrIGWof+8fachJoqWtAmo +9JFmHHuRYVMePGok4jO0PXsOI22nysdHGYDawYeYQhnzflKmgEQ/axhIrE+cKobB/uebenN5 X-Google-Smtp-Source: AGHT+IE7WBwrl3jaarVMzJW1dQvJTLSdEADVBccamY5m3DrlHNkzVwGGn7YBQ/+/lEo46eg0gDorLalQVAx8uUlOB1o= X-Received: by 2002:a05:6122:2212:b0:51d:e9c0:e607 with SMTP id 71dfb90a1353d-51e9e33ae65mr2452691e0c.4.1738151627693; Wed, 29 Jan 2025 03:53:47 -0800 (PST) MIME-Version: 1.0 References: <CAN+1Hbq+WeBCv9ZWC_JT_6UooqsQC3YGESkbCzC-OncU2HLKDQ@HIDDEN> <87tt9iawy7.fsf@HIDDEN> In-Reply-To: <87tt9iawy7.fsf@HIDDEN> From: Ship Mints <shipmints@HIDDEN> Date: Wed, 29 Jan 2025 06:51:57 -0500 X-Gm-Features: AWEUYZlzf7hOypxdMaObXvSiUut-WH_Iy9Py1ZdBRKty9TPPWQlCAXr_IwMlRcs Message-ID: <CAN+1HbpJ58BFX801toGrfO4+yCBBhQyuEWEmv+cr-u58PzVW7A@HIDDEN> Subject: Re: bug#75918: [PATCH] Add new user option tab-bar-define-keys To: Juri Linkov <juri@HIDDEN> Content-Type: multipart/alternative; boundary="00000000000055a780062cd6f60f" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 75918 Cc: 75918 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --00000000000055a780062cd6f60f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jan 29, 2025 at 2:50=E2=80=AFAM Juri Linkov <juri@HIDDEN> wrote= : > > This controls which key bindings tab-bar creates. Values are t,the > > default, which defines all keys and is backwards compatible, 'numeric > > (tab number selection only), 'tab (TAB and SHIFT-TAB keys only), nil > > (which defines none). > > Thanks for the patch. I don't understand why to add 'numeric' when > it's already customized by 'tab-bar-select-tab-modifiers'. > If the problem is only with tab keys then a better name > would be 'tab-bar-tab-keys'. > I think it's a clearer way to control key definitions than relying on tab-bar-select-tab-modifiers, which has a separate impact that just so happens to be used as a numeric definition toggle. > This is useful to avoid key binding conflicts, such as when folding in > > outline mode using TAB keys, or when a user wants to define her own > > tab-bar keys without first having to remove the defaults. > > The current implementation was intended to allow removing the default key= s > easily from 'tab-bar-mode-map'. Here is the NEWS from bug#69578: > > *** New keymap 'tab-bar-mode-map'. > By default it contains a keybinding 'C-TAB' to switch tabs, but only > when 'C-TAB' is not bound globally. You can unbind it if it conflicts > with 'C-TAB' in other modes. > This strategy doesn't account for the key definition race condition, and relies on the user to have first defined global TAB keys before tab-bar-mode is enabled. > Is the new option intended only to replace in config files: > > (define-key tab-bar-mode-map [(control tab)] nil t) > > with > > (setopt tab-bar-define-keys nil) > Or (setopt tab-bar-define-keys 'numeric) which is what I will use and I will remove some accumulated init cruft. > Last but not least: have you signed FSF papers for your patches to be > applied? > Paperwork is on file. -Stephane --00000000000055a780062cd6f60f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon= t-family:monospace"><span style=3D"font-family:Arial,Helvetica,sans-serif">= On Wed, Jan 29, 2025 at 2:50=E2=80=AFAM Juri Linkov <<a href=3D"mailto:j= uri@HIDDEN">juri@HIDDEN</a>> wrote:</span></div></div><div class= =3D"gmail_quote gmail_quote_container"><blockquote class=3D"gmail_quote" st= yle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padd= ing-left:1ex">> This controls which key bindings tab-bar creates. Values= are t,the<br> > default, which defines all keys and is backwards compatible, 'nume= ric<br> > (tab number selection only), 'tab (TAB and SHIFT-TAB keys only), n= il<br> > (which defines none).<br> <br> Thanks for the patch.=C2=A0 I don't understand why to add 'numeric&= #39; when<br> it's already customized by 'tab-bar-select-tab-modifiers'.<br> If the problem is only with tab keys then a better name<br> would be 'tab-bar-tab-keys'.<br></blockquote><div><br></div><div><d= iv class=3D"gmail_default" style=3D"font-family:monospace">I think it's= a clearer way to control key definitions than relying on tab-bar-select-ta= b-modifiers, which has a separate impact that just so happens to be used as= a numeric definition toggle.</div></div><div><br></div><blockquote class= =3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg= b(204,204,204);padding-left:1ex"> > This is useful to avoid key binding conflicts, such as when folding in= <br> > outline mode using TAB keys, or when a user wants to define her own<br= > > tab-bar keys without first having to remove the defaults.<br> <br> The current implementation was intended to allow removing the default keys<= br> easily from 'tab-bar-mode-map'.=C2=A0 Here is the NEWS from bug#695= 78:<br> <br> =C2=A0 *** New keymap 'tab-bar-mode-map'.<br> =C2=A0 By default it contains a keybinding 'C-TAB' to switch tabs, = but only<br> =C2=A0 when 'C-TAB' is not bound globally.=C2=A0 You can unbind it = if it conflicts<br> =C2=A0 with 'C-TAB' in other modes.<br></blockquote><div><br></div>= <div><div class=3D"gmail_default" style=3D"font-family:monospace">This stra= tegy doesn't account for the key definition race condition,=C2=A0and re= lies on the user to have first defined global TAB keys before tab-bar-mode = is enabled.</div></div><div>=C2=A0</div><blockquote class=3D"gmail_quote" s= tyle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pad= ding-left:1ex"> Is the new option intended only to replace in config files:<br> <br> =C2=A0 (define-key tab-bar-mode-map [(control tab)] nil t)<br> <br> with<br> <br> =C2=A0 (setopt tab-bar-define-keys nil)<br></blockquote><div><br></div><div= ><div class=3D"gmail_default" style=3D"font-family:monospace">Or (setopt ta= b-bar-define-keys 'numeric) which is what I will use and I will remove = some accumulated init cruft.</div></div><div>=C2=A0</div><blockquote class= =3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg= b(204,204,204);padding-left:1ex"> Last but not least: have you signed FSF papers for your patches to be appli= ed?<br></blockquote><div><br></div><div class=3D"gmail_default" style=3D"fo= nt-family:monospace">Paperwork is on file.</div><div class=3D"gmail_default= " style=3D"font-family:monospace"><br></div><div class=3D"gmail_default" st= yle=3D"font-family:monospace">-Stephane</div></div></div> --00000000000055a780062cd6f60f--
bug-gnu-emacs@HIDDEN
:bug#75918
; Package emacs
.
Full text available.Received: (at 75918) by debbugs.gnu.org; 29 Jan 2025 07:51:01 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 29 02:51:00 2025 Received: from localhost ([127.0.0.1]:39774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1td2qi-0005qf-9R for submit <at> debbugs.gnu.org; Wed, 29 Jan 2025 02:51:00 -0500 Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]:42839) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1td2qe-0005qF-UY for 75918 <at> debbugs.gnu.org; Wed, 29 Jan 2025 02:50:57 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id D4D58204A5; Wed, 29 Jan 2025 07:50:47 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Ship Mints <shipmints@HIDDEN> Subject: Re: bug#75918: [PATCH] Add new user option tab-bar-define-keys In-Reply-To: <CAN+1Hbq+WeBCv9ZWC_JT_6UooqsQC3YGESkbCzC-OncU2HLKDQ@HIDDEN> (Ship Mints's message of "Tue, 28 Jan 2025 17:57:51 -0500") Organization: LINKOV.NET References: <CAN+1Hbq+WeBCv9ZWC_JT_6UooqsQC3YGESkbCzC-OncU2HLKDQ@HIDDEN> Date: Wed, 29 Jan 2025 09:41:36 +0200 Message-ID: <87tt9iawy7.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvgeegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrdeliedrledtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrdeliedrledtpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepvddprhgtphhtthhopeejheeludekseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepshhhihhpmhhinhhtshesghhmrghilhdrtghomh X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75918 Cc: 75918 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) > This controls which key bindings tab-bar creates. Values are t,the > default, which defines all keys and is backwards compatible, 'numeric > (tab number selection only), 'tab (TAB and SHIFT-TAB keys only), nil > (which defines none). Thanks for the patch. I don't understand why to add 'numeric' when it's already customized by 'tab-bar-select-tab-modifiers'. If the problem is only with tab keys then a better name would be 'tab-bar-tab-keys'. > This is useful to avoid key binding conflicts, such as when folding in > outline mode using TAB keys, or when a user wants to define her own > tab-bar keys without first having to remove the defaults. The current implementation was intended to allow removing the default keys easily from 'tab-bar-mode-map'. Here is the NEWS from bug#69578: *** New keymap 'tab-bar-mode-map'. By default it contains a keybinding 'C-TAB' to switch tabs, but only when 'C-TAB' is not bound globally. You can unbind it if it conflicts with 'C-TAB' in other modes. Is the new option intended only to replace in config files: (define-key tab-bar-mode-map [(control tab)] nil t) with (setopt tab-bar-define-keys nil) Last but not least: have you signed FSF papers for your patches to be applied?
bug-gnu-emacs@HIDDEN
:bug#75918
; Package emacs
.
Full text available.Received: (at submit) by debbugs.gnu.org; 28 Jan 2025 22:59:56 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 28 17:59:56 2025 Received: from localhost ([127.0.0.1]:39074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tcuYm-0006TK-BI for submit <at> debbugs.gnu.org; Tue, 28 Jan 2025 17:59:56 -0500 Received: from lists.gnu.org ([2001:470:142::17]:36696) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <shipmints@HIDDEN>) id 1tcuYk-0006T1-As for submit <at> debbugs.gnu.org; Tue, 28 Jan 2025 17:59:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <shipmints@HIDDEN>) id 1tcuYd-0007Gd-U3 for bug-gnu-emacs@HIDDEN; Tue, 28 Jan 2025 17:59:47 -0500 Received: from mail-vs1-xe30.google.com ([2607:f8b0:4864:20::e30]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <shipmints@HIDDEN>) id 1tcuYa-0004Hl-0P for bug-gnu-emacs@HIDDEN; Tue, 28 Jan 2025 17:59:46 -0500 Received: by mail-vs1-xe30.google.com with SMTP id ada2fe7eead31-4afdf8520c2so2029558137.2 for <bug-gnu-emacs@HIDDEN>; Tue, 28 Jan 2025 14:59:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738105181; x=1738709981; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=9OXE6mEWO2tRN0Q8ADMKZ6rIIX58Ciqk7QE1j4yJS/s=; b=lTYsVAiySZMw6mi4R1ujaTuMwzPuse1OSmXyJGkWdNQlFBJ7w65SSImGa0/NJJJyl+ vhVQpA2CSQYoPVG24m2MNKfe8ZLTShYnNv8Qy6CmXrWZ0zCc0oxZJsRCXlo4GvV31Imo TUZlHSXB52wFqsLfVSXqvGAgoaO7jCLEMAjTUKgCQin9lt5T5k4/3u+p0vjuBJrUgVua N9/VsfbqDJPCGIj7wQyBEskScRR8qXCN1S+ugmnP/FOeXQjaQS/Ljf5G4xLpggsrlzyJ PjVla+PDuNjj/JDeDO3LVOjcMgJHm7KJVrgVSi1KaloPk5t9rY3SiCJHfG9virYtpiBT Kdsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738105181; x=1738709981; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=9OXE6mEWO2tRN0Q8ADMKZ6rIIX58Ciqk7QE1j4yJS/s=; b=slWTjl1KatmWuF1mzoF5dw7/5hB+QndeDw7WNwluGtL6hKjuJC+kkyXa8HY2C4nOLO vuafHs7SgcwsD+WCjfYDYbswdq/nXL6XE7xWI5hdCusQmOVnKZvWNWDyKyaVyhrNDsro sRHcQIx0j1WNmnVTH3r7eup4W0276axfTqbZcsDFnO3eD/QGT7j39dMLi3VJ+xAGoRcN BXCeFPmGMQE/nCTxW4pa5HNQcI/fM3MshE/uiBdWpWgZOL2gg0ns17wU1IOOnd/eI2Y0 4MjJco2qqiUGM2olT904MClEGiVUVaVpHmPoOglGdGBTwU7qaYUxXdSZooCSvbge05tS Oevg== X-Gm-Message-State: AOJu0YzehekHXzIeejK8sqbVEa8mLdr9OUL/lfv3U6bRgpFZFnf6pHHd P7Miqq42ARfLaUpufbjj1kuJzCgpgS/nQg9GsOVFp+rlUXwvN0jHe3C8Cpw5P9dWUZ0xy0TjRKu d78UGkzq0ziTKON7bsPXAf+ak8QD9vDJe X-Gm-Gg: ASbGncuMNvV0ZoXqcU8Br6KrMLgqEpNWxEWLrkilLjWR720bg1OMB9eTgLVwpXJu1Mm YcGdBvc5ilh91A0fHRSf6KZo5nKwK5xTQPg250h7JOgeH6je5n9Wuak0iKh+fY5/DcOd6Kd48 X-Google-Smtp-Source: AGHT+IHjOmZhz+YpAxEOuSHLuCYKlc+/YDAt7hps0QsuSd4MGC1EqfDXRAeTWk5O5IRTjCcxZdMyynn+z8uKeMfZcMk= X-Received: by 2002:a05:6102:b0a:b0:4af:4902:153e with SMTP id ada2fe7eead31-4b9a4f50f7dmr878279137.9.1738105180874; Tue, 28 Jan 2025 14:59:40 -0800 (PST) MIME-Version: 1.0 From: Ship Mints <shipmints@HIDDEN> Date: Tue, 28 Jan 2025 17:57:51 -0500 X-Gm-Features: AWEUYZm5Vl03aPCQECXRGpoQlPkcPufO9g5_7t3fUQqPd7Vx0kVvEN3r_H51ToY Message-ID: <CAN+1Hbq+WeBCv9ZWC_JT_6UooqsQC3YGESkbCzC-OncU2HLKDQ@HIDDEN> Subject: [PATCH] Add new user option tab-bar-define-keys To: bug-gnu-emacs@HIDDEN Content-Type: multipart/mixed; boundary="000000000000e38583062ccc2572" Received-SPF: pass client-ip=2607:f8b0:4864:20::e30; envelope-from=shipmints@HIDDEN; helo=mail-vs1-xe30.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) --000000000000e38583062ccc2572 Content-Type: multipart/alternative; boundary="000000000000e3857f062ccc2570" --000000000000e3857f062ccc2570 Content-Type: text/plain; charset="UTF-8" This controls which key bindings tab-bar creates. Values are t,the default, which defines all keys and is backwards compatible, 'numeric (tab number selection only), 'tab (TAB and SHIFT-TAB keys only), nil (which defines none). This is useful to avoid key binding conflicts, such as when folding in outline mode using TAB keys, or when a user wants to define her own tab-bar keys without first having to remove the defaults. -Stephane --000000000000e3857f062ccc2570 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:monospac= e">This controls which key bindings tab-bar creates. Values are t,the<br>de= fault, which defines all keys and is backwards compatible, 'numeric<br>= (tab number selection only), 'tab (TAB and SHIFT-TAB keys only), nil<br= >(which defines none).<br><br>This is useful to avoid key binding conflicts= , such as when folding in<br>outline mode using TAB keys, or when a user wa= nts to define her own<br>tab-bar keys without first having to remove the de= faults.<br></div><div class=3D"gmail_default" style=3D"font-family:monospac= e"><br></div><div class=3D"gmail_default" style=3D"font-family:monospace">-= Stephane</div></div> --000000000000e3857f062ccc2570-- --000000000000e38583062ccc2572 Content-Type: application/octet-stream; name="0001-Add-new-user-option-tab-bar-define-keys.patch" Content-Disposition: attachment; filename="0001-Add-new-user-option-tab-bar-define-keys.patch" Content-Transfer-Encoding: base64 Content-ID: <f_m6h2uk060> X-Attachment-Id: f_m6h2uk060 RnJvbSA4OWMyMTgyYjFkNjVjMWU2NDlhNGZlNjczNzkzMDQ5Y2I4YjBlZGUzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBzaGlwbWludHMgPHNoaXBtaW50c0BnbWFpbC5jb20+CkRhdGU6 IFR1ZSwgMjggSmFuIDIwMjUgMTc6NTQ6MTEgLTA1MDAKU3ViamVjdDogW1BBVENIXSBBZGQgbmV3 IHVzZXIgb3B0aW9uIHRhYi1iYXItZGVmaW5lLWtleXMKCiogbGlzcC90YWItYmFyLmVsICh0YWIt YmFyLWRlZmluZS1rZXlzKToKQWRkIG5ldyBkZWZjdXN0b20gdGFiLWJhci1kZWZpbmUta2V5cy4g UmVvcmdhbml6ZSBrZXkgYmluZGluZyBmdW5jdGlvbnMKdG8gYWNjb21tb2RhdGUuIEFsc28gcmVt b3ZlIGNoZWNrcyBmb3IgdGFiLWJhci1tb2RlIGVuYWJsZWQgaW4KJ3RhYi1iYXItc2VsZWN0LXRh Yi1tb2RpZmllcnMnLCBhcyB1bm5lY2Vzc2FyeSBhbmQgd2hpY2ggcHJldmVudGVkIHVzZXIKY2hh bmdlcyBmcm9tIGJlaW5nIGFjY2VwdGVkIGluIGNhc2VzIHdoZXJlIHRoZSB1c2VyIGRlZmVycyBl bmFibGluZwp0YWItYmFyLW1vZGUuCi0tLQogZXRjL05FV1MgICAgICAgIHwgMTEgKysrKysrKysK IGxpc3AvdGFiLWJhci5lbCB8IDcxICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKyst LS0tLS0tLS0tLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgNjEgaW5zZXJ0aW9ucygrKSwgMjEgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZXRjL05FV1MgYi9ldGMvTkVXUwppbmRleCAwOTUwN2Fk ZWNiOC4uNzRjNTQ5ZWM5ZWEgMTAwNjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBiL2V0Yy9ORVdTCkBA IC0yMzgsNiArMjM4LDE3IEBAIGxhdHRlciB0aHJvd3MgYW4gZXJyb3Igd2hlbiB0aGUgYXJndW1l bnQgRlJBTUUgY2Fubm90IGJlIGRlbGV0ZWQuCiAqKiogTmV3IGFibm9ybWFsIGhvb2sgJ3RhYi1i YXItYXV0by13aWR0aC1mdW5jdGlvbnMnLgogVGhpcyBob29rIGFsbG93cyB5b3UgdG8gY29udHJv bCB3aGljaCB0YWItYmFyIHRhYnMgYXJlIGF1dG8tcmVzaXplZC4KIAorLS0tCisqKiogTmV3IHVz ZXIgb3B0aW9uICd0YWItYmFyLWRlZmluZS1rZXlzJy4KK1RoaXMgY29udHJvbHMgd2hpY2gga2V5 IGJpbmRpbmdzIHRhYi1iYXIgY3JlYXRlcy4gVmFsdWVzIGFyZSB0LHRoZQorZGVmYXVsdCwgd2hp Y2ggZGVmaW5lcyBhbGwga2V5cyBhbmQgaXMgYmFja3dhcmRzIGNvbXBhdGlibGUsICdudW1lcmlj CisodGFiIG51bWJlciBzZWxlY3Rpb24gb25seSksICd0YWIgKFRBQiBhbmQgU0hJRlQtVEFCIGtl eXMgb25seSksIG5pbAorKHdoaWNoIGRlZmluZXMgbm9uZSkuCisKK1RoaXMgaXMgdXNlZnVsIHRv IGF2b2lkIGtleSBiaW5kaW5nIGNvbmZsaWN0cywgc3VjaCBhcyB3aGVuIGZvbGRpbmcgaW4KK291 dGxpbmUgbW9kZSB1c2luZyBUQUIga2V5cywgb3Igd2hlbiBhIHVzZXIgd2FudHMgdG8gZGVmaW5l IGhlciBvd24KK3RhYi1iYXIga2V5cyB3aXRob3V0IGZpcnN0IGhhdmluZyB0byByZW1vdmUgdGhl IGRlZmF1bHRzLgorCiAqKiBQcm9qZWN0CiAKIC0tLQpkaWZmIC0tZ2l0IGEvbGlzcC90YWItYmFy LmVsIGIvbGlzcC90YWItYmFyLmVsCmluZGV4IGI1NzA5NDliZmVjLi40YjgxODM1ZjVkNyAxMDA2 NDQKLS0tIGEvbGlzcC90YWItYmFyLmVsCisrKyBiL2xpc3AvdGFiLWJhci5lbApAQCAtODYsNiAr ODYsMzUgQEAgdGFiLWJhci10YWItdW5ncm91cGVkCiAgIDpncm91cCAndGFiLWJhci1mYWNlcykK IAogDAorCisoZGVmdmFyIHRhYi1iYXItbW9kZS1tYXAgKG1ha2Utc3BhcnNlLWtleW1hcCkKKyAg IlRhYiBCYXIgbW9kZSBtYXAuIikKKworKGRlZmN1c3RvbSB0YWItYmFyLWRlZmluZS1rZXlzIHQK KyAgIkRlZmluZSBzcGVjaWZpZWQgdGFiLWJhciBrZXkgYmluZGluZ3MuCitJZiB0LCB0aGUgZGVm YXVsdCwgYWxsIGtleSBtYXBwaW5ncyBhcmUgZGVmaW5lZC4KKworSWYgXFw9J251bWVyaWMsIGRl ZmluZSBvbmx5IG51bWVyaWMgc2VsZWN0LXRhYiBrZXkgbWFwcGluZ3MsIGFuZCBpbgorY29uanVu Y3Rpb24gd2l0aCBgdGFiLWJhci1zZWxlY3QtdGFiLW1vZGlmaWVycycsIHdoaWNoIHNlZS4KKwor SWYgXFw9J3RhYiwgZGVmaW5lIG9ubHkgVEFCIGFuZCBTSElGVC1UQUIgdGFiLXNlbGVjdGlvbiBr ZXkgbWFwcGluZ3MuCisKK0lmIG5pbCwgZG8gbm90IGRlZmluZSBhbnkga2V5IG1hcHBpbmdzLgor CitDdXN0b21pemUgdGhpcyBvcHRpb24sIG9yIHVzZSBgc2V0b3B0JyB0byBlbnN1cmUgaXQgd2ls bCB0YWtlIGVmZmVjdC4iCisgIDp0eXBlICcoY2hvaWNlIChjb25zdCA6dGFnICJBbGwga2V5cyIg dCkKKyAgICAgICAgICAgICAgICAgKGNvbnN0IDp0YWcgIk51bWVyaWMgdGFiIHNlbGVjdGlvbiBr ZXlzIiBudW1lcmljKQorICAgICAgICAgICAgICAgICAoY29uc3QgOnRhZyAiVEFCIGFuZCBTSElG VC1UQUIgc2VsZWN0aW9uIGtleXMiIHRhYikKKyAgICAgICAgICAgICAgICAgKGNvbnN0IDp0YWcg Ik5vbmUiIG5pbCkpCisgIDppbml0aWFsaXplICMnY3VzdG9tLWluaXRpYWxpemUtZGVmYXVsdAor ICA6c2V0IChsYW1iZGEgKHN5bSB2YWwpCisgICAgICAgICAodGFiLWJhci0tdW5kZWZpbmUta2V5 cykKKyAgICAgICAgIChzZXQtZGVmYXVsdCBzeW0gdmFsKQorICAgICAgICAgOzsgRW5hYmxlIHRo ZSBuZXcga2V5YmluZGluZ3MKKyAgICAgICAgICh0YWItYmFyLS1kZWZpbmUta2V5cykpCisgIDpn cm91cCAndGFiLWJhcgorICA6dmVyc2lvbiAiMzEuMSIpCisKIChkZWZjdXN0b20gdGFiLWJhci1z ZWxlY3QtdGFiLW1vZGlmaWVycyAnKCkKICAgIkxpc3Qgb2YgbW9kaWZpZXIga2V5cyBmb3Igc2Vs ZWN0aW5nIHRhYi1iYXIgdGFicyBieSB0aGVpciBudW1iZXJzLgogUG9zc2libGUgbW9kaWZpZXIg a2V5cyBhcmUgYGNvbnRyb2wnLCBgbWV0YScsIGBzaGlmdCcsIGBoeXBlcicsIGBzdXBlcicgYW5k CkBAIC0xMDQsMTggKzEzMywyMyBAQCB0YWItYmFyLXNlbGVjdC10YWItbW9kaWZpZXJzCiAgICAg ICAgICAgICAgIChjb25zdCBhbHQpKQogICA6aW5pdGlhbGl6ZSAjJ2N1c3RvbS1pbml0aWFsaXpl LWRlZmF1bHQKICAgOnNldCAobGFtYmRhIChzeW0gdmFsKQotICAgICAgICAgKHdoZW4gdGFiLWJh ci1tb2RlCi0gICAgICAgICAgICh0YWItYmFyLS11bmRlZmluZS1rZXlzKSkKKyAgICAgICAgICh0 YWItYmFyLS11bmRlZmluZS1rZXlzKQogICAgICAgICAgKHNldC1kZWZhdWx0IHN5bSB2YWwpCi0g ICAgICAgICA7OyBSZWVuYWJsZSB0aGUgdGFiLWJhciB3aXRoIG5ldyBrZXliaW5kaW5ncwotICAg ICAgICAgKHdoZW4gdGFiLWJhci1tb2RlCi0gICAgICAgICAgICh0YWItYmFyLS1kZWZpbmUta2V5 cykpKQorICAgICAgICAgOzsgRW5hYmxlIHRoZSBuZXcga2V5YmluZGluZ3MKKyAgICAgICAgICh0 YWItYmFyLS1kZWZpbmUta2V5cykpCiAgIDpncm91cCAndGFiLWJhcgogICA6dmVyc2lvbiAiMjcu MSIpCiAKKyhkZWZ1biB0YWItYmFyLW1vZGUtLXRhYi1rZXktYmluZCAobWFwIGtleSBiaW5kaW5n KQorICA7OyBEb24ndCBvdmVycmlkZSB1c2VyIGN1c3RvbWl6ZWQgZ2xvYmFsIGtleSBiaW5kaW5n cworICAoZGVmaW5lLWtleSBtYXAga2V5CisgICAgICAgICAgICAgIGAobWVudS1pdGVtICIiICxi aW5kaW5nCisgICAgICAgICAgICAgICAgICAgICAgICAgIDpmaWx0ZXIgLChsYW1iZGEgKGNtZCkg KHVubGVzcyAoZ2xvYmFsLWtleS1iaW5kaW5nIGtleSkgY21kKSkpKSkKKwogKGRlZnVuIHRhYi1i YXItLWRlZmluZS1rZXlzICgpCiAgICJJbnN0YWxsIGtleSBiaW5kaW5ncyB0byBzd2l0Y2ggYmV0 d2VlbiB0YWJzIGlmIHNvIGNvbmZpZ3VyZWQuIgotICAod2hlbiB0YWItYmFyLXNlbGVjdC10YWIt bW9kaWZpZXJzCisgICh3aGVuIChhbmQgKG1lbXEgdGFiLWJhci1kZWZpbmUta2V5cyAnKHQgbnVt ZXJpYykpCisgICAgICAgICAgICAgdGFiLWJhci1zZWxlY3QtdGFiLW1vZGlmaWVycykKICAgICAo ZGVmaW5lLWtleSB0YWItYmFyLW1vZGUtbWFwCiAgICAgICAgICAgICAgICAgKHZlY3RvciAoYXBw ZW5kIHRhYi1iYXItc2VsZWN0LXRhYi1tb2RpZmllcnMgKGxpc3QgPzApKSkKICAgICAgICAgICAg ICAgICAjJ3RhYi1yZWNlbnQpCkBAIC0xMjgsNiArMTYyLDExIEBAIHRhYi1iYXItLWRlZmluZS1r ZXlzCiAgICAgICAgICAgICAgICAgKHZlY3RvciAoYXBwZW5kIHRhYi1iYXItc2VsZWN0LXRhYi1t b2RpZmllcnMgKGxpc3QgPzkpKSkKICAgICAgICAgICAgICAgICAjJ3RhYi1sYXN0KSkKIAorICAo d2hlbiAobWVtcSB0YWItYmFyLWRlZmluZS1rZXlzICcodCB0YWIpKQorICAgICh0YWItYmFyLW1v ZGUtLXRhYi1rZXktYmluZCB0YWItYmFyLW1vZGUtbWFwIFsoY29udHJvbCB0YWIpXSAjJ3RhYi1u ZXh0KQorICAgICh0YWItYmFyLW1vZGUtLXRhYi1rZXktYmluZCB0YWItYmFyLW1vZGUtbWFwIFso Y29udHJvbCBzaGlmdCB0YWIpXSAjJ3RhYi1wcmV2aW91cykKKyAgICAodGFiLWJhci1tb2RlLS10 YWIta2V5LWJpbmQgdGFiLWJhci1tb2RlLW1hcCBbKGNvbnRyb2wgc2hpZnQgaXNvLWxlZnR0YWIp XSAjJ3RhYi1wcmV2aW91cykpCisKICAgOzsgUmVwbGFjZSBkZWZhdWx0IHZhbHVlIHdpdGggYSBj b25kaXRpb24gdGhhdCBzdXBwb3J0cyBkaXNwbGF5aW5nCiAgIDs7IGdsb2JhbC1tb2RlLXN0cmlu ZyBpbiB0aGUgdGFiIGJhciBpbnN0ZWFkIG9mIHRoZSBtb2RlIGxpbmUuCiAgICh3aGVuIChhbmQg KG1lbXEgJ3RhYi1iYXItZm9ybWF0LWdsb2JhbCB0YWItYmFyLWZvcm1hdCkKQEAgLTE1Miw3ICsx OTEsMTEgQEAgdGFiLWJhci0tdW5kZWZpbmUta2V5cwogICAgICAgICAgICAgICAgICAgbmlsIHQp KQogICAgIChkZWZpbmUta2V5IHRhYi1iYXItbW9kZS1tYXAKICAgICAgICAgICAgICAgICAodmVj dG9yIChhcHBlbmQgdGFiLWJhci1zZWxlY3QtdGFiLW1vZGlmaWVycyAobGlzdCA/OSkpKQotICAg ICAgICAgICAgICAgIG5pbCB0KSkpCisgICAgICAgICAgICAgICAgbmlsIHQpKQorCisgIChkZWZp bmUta2V5IHRhYi1iYXItbW9kZS1tYXAgWyhjb250cm9sIHRhYildIG5pbCB0KQorICAoZGVmaW5l LWtleSB0YWItYmFyLW1vZGUtbWFwIFsoY29udHJvbCBzaGlmdCB0YWIpXSBuaWwgdCkKKyAgKGRl ZmluZS1rZXkgdGFiLWJhci1tb2RlLW1hcCBbKGNvbnRyb2wgc2hpZnQgaXNvLWxlZnR0YWIpXSBu aWwgdCkpCiAKIChkZWZ1biB0YWItYmFyLS1sb2FkLWJ1dHRvbnMgKCkKICAgIkxvYWQgdGhlIGlj b25zIGZvciB0aGUgdGFiIGJ1dHRvbnMuIgpAQCAtMjQyLDIwICsyODUsNiBAQCB0YWItYmFyLS11 cGRhdGUtdGFiLWJhci1saW5lcwogICAgICAgICAgICAgICAgICAgICAgIChpZiAoYW5kIHRhYi1i YXItbW9kZSAoZXEgdGFiLWJhci1zaG93IHQpKSAxIDApKQogICAgICAgICAgICAgICAgIChhc3Nx LWRlbGV0ZS1hbGwgJ3RhYi1iYXItbGluZXMgZGVmYXVsdC1mcmFtZS1hbGlzdCkpKSkpCiAKLShk ZWZ1biB0YWItYmFyLW1vZGUtLXRhYi1rZXktYmluZCAobWFwIGtleSBiaW5kaW5nKQotICA7OyBE b24ndCBvdmVycmlkZSB1c2VyIGN1c3RvbWl6ZWQgZ2xvYmFsIGtleSBiaW5kaW5ncwotICAoZGVm aW5lLWtleSBtYXAga2V5Ci0gICAgYChtZW51LWl0ZW0gIiIgLGJpbmRpbmcKLSAgICAgIDpmaWx0 ZXIgLChsYW1iZGEgKGNtZCkgKHVubGVzcyAoZ2xvYmFsLWtleS1iaW5kaW5nIGtleSkgY21kKSkp KSkKLQotKGRlZnZhciB0YWItYmFyLW1vZGUtbWFwCi0gIChsZXQgKChtYXAgKG1ha2Utc3BhcnNl LWtleW1hcCkpKQotICAgICh0YWItYmFyLW1vZGUtLXRhYi1rZXktYmluZCBtYXAgWyhjb250cm9s IHRhYildICMndGFiLW5leHQpCi0gICAgKHRhYi1iYXItbW9kZS0tdGFiLWtleS1iaW5kIG1hcCBb KGNvbnRyb2wgc2hpZnQgdGFiKV0gIyd0YWItcHJldmlvdXMpCi0gICAgKHRhYi1iYXItbW9kZS0t dGFiLWtleS1iaW5kIG1hcCBbKGNvbnRyb2wgc2hpZnQgaXNvLWxlZnR0YWIpXSAjJ3RhYi1wcmV2 aW91cykKLSAgICBtYXApCi0gICJUYWIgQmFyIG1vZGUgbWFwLiIpCi0KIChkZWZpbmUtbWlub3It bW9kZSB0YWItYmFyLW1vZGUKICAgIlRvZ2dsZSB0aGUgdGFiIGJhciBpbiBhbGwgZ3JhcGhpY2Fs IGZyYW1lcyAoVGFiIEJhciBtb2RlKS4KIAotLSAKMi40Ny4xCgo= --000000000000e38583062ccc2572--
Ship Mints <shipmints@HIDDEN>
:bug-gnu-emacs@HIDDEN
.
Full text available.bug-gnu-emacs@HIDDEN
:bug#75918
; Package emacs
.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.