GNU logs - #75924, boring messages

Message sent to bug-gzip@HIDDEN:

Subject: bug#75924: maint: fix s390 buffer flushes
Resent-From: Eduard Stefes <eduard.stefes@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gzip@HIDDEN
Resent-Date: Wed, 29 Jan 2025 14:20:02 +0000
Resent-Message-ID: <handler.75924.B.173816034318573 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 75924 <at> debbugs.gnu.org
Cc: Andreas Hasenack <andreas.hasenack@HIDDEN>, Eduard Stefes <eduard.stefes@HIDDEN>, Ilya Leoshkevich <iii@HIDDEN>
From: Eduard Stefes <eduard.stefes@HIDDEN>
Date: Wed, 29 Jan 2025 15:18:36 +0100
Message-ID: <20250129141836.69050-1-eduard.stefes@HIDDEN>
In-Reply-To: <5a8f263c4687100fceef43bf6a06a0b840af5180.camel@HIDDEN>
References: <5a8f263c4687100fceef43bf6a06a0b840af5180.camel@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=148.163.156.1; envelope-from=eduard.stefes@HIDDEN;
 helo=mx0a-001b2d01.pphosted.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=0.001,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Problem reported by Nick Rosbrook in:
https://bugs.launchpad.net/ubuntu/+source/rsyslog/+bug/2083700

align the behavior of dfltcc_inflate to do the same as gzip_inflate
when it hits a premature EOF
---
 dfltcc.c    | 6 +++++-
 tests/hufts | 6 ++++--
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/dfltcc.c b/dfltcc.c
index 811c1f8..5d421bb 100644
--- a/dfltcc.c
+++ b/dfltcc.c
@@ -18,6 +18,7 @@
 #include <config.h>
 
 #include <stdlib.h>
+#include <errno.h>
 
 #ifdef HAVE_SYS_SDT_H
 # include <sys/sdt.h>
@@ -437,7 +438,10 @@ dfltcc_inflate ()
           if (fill_inbuf (1) == EOF)
             {
               /* Premature EOF.  */
-              return 2;
+              flush_outbuf ();
+              errno = 0;
+              read_error ();
+              __builtin_unreachable ();
             }
           inptr = 0;
         }
diff --git a/tests/hufts b/tests/hufts
index c464ef6..6dbb8ac 100755
--- a/tests/hufts
+++ b/tests/hufts
@@ -40,10 +40,12 @@ compare exp err || fail=1
 
 printf '\037\213\010\000\060\060\060\060\060\060\144\000\000\000' > bug33501 \
   || framework_failure_
-printf '\ngzip: stdin: invalid compressed data--format violated\n' >exp33501 \
+printf '\ngzip: stdin: invalid compressed data--format violated\n' > exp33501.1 \
+  || framework_failure_
+printf '\ngzip: stdin: unexpected end of file\n' > exp33501.2 \
   || framework_failure_
 returns_ 1 gzip -d <bug33501 >out33501 2> err33501-raw || fail=1
 sed "$clean_stderr" err33501-raw > err33501 || framework_failure_
-compare exp33501 err33501 || fail=1
+compare exp33501.1 err33501 || compare exp33501.2 err33501 || fail=1
 
 Exit $fail
-- 
2.48.1

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Eduard Stefes <eduard.stefes@HIDDEN>
Subject: bug#75924: Acknowledgement (maint: fix s390 buffer flushes)
Message-ID: <handler.75924.B.173816034318573.ack <at> debbugs.gnu.org>
References: <20250129141836.69050-1-eduard.stefes@HIDDEN>
X-Gnu-PR-Message: ack 75924
X-Gnu-PR-Package: gzip
Reply-To: 75924 <at> debbugs.gnu.org
Date: Wed, 29 Jan 2025 14:20:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gzip@HIDDEN

If you wish to submit further information on this problem, please
send it to 75924 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
75924: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D75924
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gzip@HIDDEN:

Subject: bug#75924: maint: fix s390 buffer flushes
Resent-From: Paul Eggert <eggert@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gzip@HIDDEN
Resent-Date: Wed, 29 Jan 2025 19:00:03 +0000
Resent-Message-ID: <handler.75924.B75924.173817715119501 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Eduard Stefes <eduard.stefes@HIDDEN>
Cc: 75924 <at> debbugs.gnu.org, Ilya Leoshkevich <iii@HIDDEN>, Andreas Hasenack <andreas.hasenack@HIDDEN>
Content-Type: multipart/mixed; boundary="------------5LqlOc0V6pAowN6PHGzA9t0E"
Message-ID: <45df1f77-1deb-46ae-9dbf-446bf192d9e9@HIDDEN>
Date: Wed, 29 Jan 2025 10:58:59 -0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
References: <5a8f263c4687100fceef43bf6a06a0b840af5180.camel@HIDDEN>
 <20250129141836.69050-1-eduard.stefes@HIDDEN>
Content-Language: en-US
From: Paul Eggert <eggert@HIDDEN>
Organization: UCLA Computer Science Department
In-Reply-To: <20250129141836.69050-1-eduard.stefes@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

This is a multi-part message in MIME format.
--------------5LqlOc0V6pAowN6PHGzA9t0E
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Thanks for the bug report. I installed the attached, a bit simpler than 
the patch you suggested; can you please give it a try?

Also, is there a related bug near dfltcc.c line 375? That is, when 
(inptr == insize && fill_inbuf (1) == EOF && param->cf), won't insize 
then be zero, so that gzip will go into an infinite loop attempting to 
read past EOF?
--------------5LqlOc0V6pAowN6PHGzA9t0E
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-gzip-fix-problem-with-s390-buffer-flushes.patch"
Content-Disposition: attachment;
 filename="0001-gzip-fix-problem-with-s390-buffer-flushes.patch"
Content-Transfer-Encoding: base64

RnJvbSA1MTA4ODk3MGQ0NWJhZWRiYTQ3Mzk2MzIzMDVkMWRiYzVhY2JiM2JmIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1
PgpEYXRlOiBXZWQsIDI5IEphbiAyMDI1IDEwOjUyOjQ5IC0wODAwClN1YmplY3Q6IFtQQVRD
SF0gZ3ppcDogZml4IHByb2JsZW0gd2l0aCBzMzkwIGJ1ZmZlciBmbHVzaGVzCgpQcm9ibGVt
IHJlcG9ydGVkIGJ5IEVkdWFyZCBTdGVmZXMgPGh0dHBzOi8vYnVncy5nbnUub3JnLzc0NjUx
Pi4KKiBkZmx0Y2MuYyAoZGZsdGNjX2RlZmxhdGUpOiBGbHVzaCBvdXRwdXQgYnVmZmVyIGlm
IHByZW1hdHVyZSBFT0YuCi0tLQogTkVXUyAgICAgfCA0ICsrKysKIGRmbHRjYy5jIHwgNiAr
LS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygt
KQoKZGlmZiAtLWdpdCBhL05FV1MgYi9ORVdTCmluZGV4IDhiODczMWIuLjQxNzY4OWMgMTAw
NjQ0Ci0tLSBhL05FV1MKKysrIGIvTkVXUwpAQCAtNCw2ICs0LDEwIEBAIEdOVSBnemlwIE5F
V1MgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtKi0gb3V0bGluZSAtKi0K
IAogKiogQnVnIGZpeGVzCiAKKyAgJ2d6aXAgLWQnIG5vIGxvbmdlciBvbWl0cyB0aGUgbGFz
dCBwYXJ0aWFsIG91dHB1dCBidWZmZXIgd2hlbiB0aGUKKyAgaW5wdXQgZW5kcyB1bmV4cGVj
dGVkbHkgb24gYW4gSUJNIFogcGxhdGZvcm0uCisgIFtidWcgaW50cm9kdWNlZCBpbiBnemlw
LTEuMTFdCisKICAgJ2d6aXAgLWwnIG5vIGxvbmdlciBtaXNyZXBvcnRzIGxlbmd0aHMgb2Yg
bXVsdGltZW1iZXIgaW5wdXRzLgogICBbYnVnIGludHJvZHVjZWQgaW4gZ3ppcC0xLjEyXQog
CmRpZmYgLS1naXQgYS9kZmx0Y2MuYyBiL2RmbHRjYy5jCmluZGV4IGZjZGMwNWEuLmM5N2Ux
OWUgMTAwNjQ0Ci0tLSBhL2RmbHRjYy5jCisrKyBiL2RmbHRjYy5jCkBAIC00MzQsMTEgKzQz
NCw3IEBAIGRmbHRjY19pbmZsYXRlICgpCiAgICAgICAgIGZsdXNoX291dGJ1ZiAoKTsKICAg
ICAgIGlmIChpbnB0ciA9PSBpbnNpemUpCiAgICAgICAgIHsKLSAgICAgICAgICBpZiAoZmls
bF9pbmJ1ZiAoMSkgPT0gRU9GKQotICAgICAgICAgICAgewotICAgICAgICAgICAgICAvKiBQ
cmVtYXR1cmUgRU9GLiAgKi8KLSAgICAgICAgICAgICAgcmV0dXJuIDI7Ci0gICAgICAgICAg
ICB9CisgICAgICAgICAgZmlsbF9pbmJ1ZiAoMCk7CiAgICAgICAgICAgaW5wdHIgPSAwOwog
ICAgICAgICB9CiAKLS0gCjIuNDUuMgoK

--------------5LqlOc0V6pAowN6PHGzA9t0E--

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 29 Jan 2025 19:01:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 29 14:01:14 2025
Received: from localhost ([127.0.0.1]:43056 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tdDJJ-0005Fq-Re
	for submit <at> debbugs.gnu.org; Wed, 29 Jan 2025 14:01:14 -0500
Received: from mail.cs.ucla.edu ([131.179.128.66]:46260)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eggert@HIDDEN>)
 id 1tdDJH-0005FY-5B
 for control <at> debbugs.gnu.org; Wed, 29 Jan 2025 14:01:12 -0500
Received: from localhost (localhost [127.0.0.1])
 by mail.cs.ucla.edu (Postfix) with ESMTP id 91F153C01409D
 for <control <at> debbugs.gnu.org>; Wed, 29 Jan 2025 11:01:05 -0800 (PST)
Received: from mail.cs.ucla.edu ([127.0.0.1])
 by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP
 id OqeIaU7gEKIS for <control <at> debbugs.gnu.org>;
 Wed, 29 Jan 2025 11:01:05 -0800 (PST)
Received: from localhost (localhost [127.0.0.1])
 by mail.cs.ucla.edu (Postfix) with ESMTP id 582883C00E40A
 for <control <at> debbugs.gnu.org>; Wed, 29 Jan 2025 11:01:05 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 582883C00E40A
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu;
 s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1738177265;
 bh=ETMxxL9zwPO8Mj9/oDbb9iuJWFEa8/+eEv35+y0mzXY=;
 h=Message-ID:Date:MIME-Version:To:From;
 b=ONHqlDBy+vkDxLemN47uo4gw4WAhq4WRAN260E8ST/9qSg24jVWT9RO60ZeajULmK
 4R4vDInJtBcFhxBylLOnd/RyqtTQDw2gCyQ+7mHuM1GXPe9yj3Xz/cVuEphBSvsUyp
 e3kN3/ZQz2ojm+p2eAOrtXSaYOYJ8DX9U9bkkKYTJHjT9UK3uCqKTXnXsm0qgYZqE9
 SzFO5mEdXsssn/v2dBIyPRXbxqc2g/ZVy7r0+W7mCKRRPOtu37yiPnQQc7n3XXXrvI
 a7Dw83OzDxvZEAy+CRm/or8UYv0/x1Z97dRA7BFsyU60I7GHcJoytWiTJaruhV8UQ3
 f41iyAIDeMpOQ==
X-Virus-Scanned: amavis at mail.cs.ucla.edu
Received: from mail.cs.ucla.edu ([127.0.0.1])
 by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP
 id b1uPhzw7JfKP for <control <at> debbugs.gnu.org>;
 Wed, 29 Jan 2025 11:01:05 -0800 (PST)
Received: from [192.168.254.12] (unknown [47.154.28.214])
 by mail.cs.ucla.edu (Postfix) with ESMTPSA id 3DB7B3C01409D
 for <control <at> debbugs.gnu.org>; Wed, 29 Jan 2025 11:01:05 -0800 (PST)
Message-ID: <2cb23a7b-b5ff-4cac-9cb7-8b28a033291a@HIDDEN>
Date: Wed, 29 Jan 2025 11:01:05 -0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: control <at> debbugs.gnu.org
From: Paul Eggert <eggert@HIDDEN>
Subject: merge s390 bugs
Organization: UCLA Computer Science Department
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

merge 74651 75911 75924

Last modified: Wed, 29 Jan 2025 19:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.