Juri Linkov <juri@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 75945) by debbugs.gnu.org; 30 Jan 2025 18:47:25 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 30 13:47:25 2025 Received: from localhost ([127.0.0.1]:47799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tdZZV-0003b9-30 for submit <at> debbugs.gnu.org; Thu, 30 Jan 2025 13:47:25 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:51239) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1tdZZS-0003ar-Rk; Thu, 30 Jan 2025 13:47:23 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 4DEA9442A6; Thu, 30 Jan 2025 18:47:15 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Ship Mints <shipmints@HIDDEN> Subject: Re: bug#75945: tab-bar-new-tab-to tab post clone improvement In-Reply-To: <CAN+1Hbp=57W4Rf5E-RNTVy+0GDv=dpOp4OugubtML96s2YJRAg@HIDDEN> (Ship Mints's message of "Thu, 30 Jan 2025 13:09:45 -0500") Organization: LINKOV.NET References: <CAN+1Hbp4cCY08yzayQDinqGqjjOYQK_wd5XKpg2t9J+ox-Zn_g@HIDDEN> <87v7twtcnf.fsf@HIDDEN> <CAN+1Hbp=57W4Rf5E-RNTVy+0GDv=dpOp4OugubtML96s2YJRAg@HIDDEN> Date: Thu, 30 Jan 2025 20:45:13 +0200 Message-ID: <87jzacrvie.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdeiheekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrdeliedrledtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrdeliedrledtpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepfedprhgtphhtthhopegtohhnthhrohhlseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepjeehleegheesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehshhhiphhmihhnthhssehgmhgrihhlrdgtohhm X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75945 Cc: 75945 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) close 75945 31.0.50 thanks > That trick works, if a bit circuitous. Thank you. Ok, then let's close this report. > Is it really the case that adding an &optional argument to a hook function > breaks those that accept only the mandatory arguments? The caller needs to provide the optional argument in any case. But the user still has only mandatory arguments. Therefore the error with wrong number of arguments. A precautious user could add '&rest args' to the end of ALL own hook functions for the case when the callers decide to add more arguments. Then for the caller it would be safe to call the hook with any number of arguments.
bug-gnu-emacs@HIDDEN:bug#75945; Package emacs.
Full text available.Received: (at 75945) by debbugs.gnu.org; 30 Jan 2025 18:11:46 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 30 13:11:46 2025 Received: from localhost ([127.0.0.1]:47700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tdZ0z-0007NB-Pz for submit <at> debbugs.gnu.org; Thu, 30 Jan 2025 13:11:46 -0500 Received: from mail-vk1-xa2d.google.com ([2607:f8b0:4864:20::a2d]:47271) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <shipmints@HIDDEN>) id 1tdZ0w-0007Mu-W7 for 75945 <at> debbugs.gnu.org; Thu, 30 Jan 2025 13:11:43 -0500 Received: by mail-vk1-xa2d.google.com with SMTP id 71dfb90a1353d-517aea3ee2aso630899e0c.2 for <75945 <at> debbugs.gnu.org>; Thu, 30 Jan 2025 10:11:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738260697; x=1738865497; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Ko5OQYzIIFFCEauwKdDqFj/J5AAg0rlbcT/ijS6oFmE=; b=hFtoG+SquUl5WcDrBWPMAOh1ye4oM65haHAJ/8JEQWaNd1u//R1fbQAy4i1fyqkNF7 vaiLnTMGL6fenVpVSG2tcS1ammsiOWyE4L83BbYAAxmxkJILXHMpqNKv3nknymyXP1e8 XDxGXKxEiyQSo/6TNutqRWWPA4M1mrOrDGWZJd4dyXpJiEiGC6j8vtboZV6Azy5paSU6 fCU85gNB5YAT575fiPuebTJf/+gUCwA8JE11r6WsBWm9iuyMuQIv2N8L73ceAQpbQX5I KfXz22Yqz5INjc6N50kAoO8smGimlS5NcvPP1k74Ho0RB6z1L185E6SDgQX3XvM5xaCP omQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738260697; x=1738865497; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ko5OQYzIIFFCEauwKdDqFj/J5AAg0rlbcT/ijS6oFmE=; b=NLaqnI32uHCrPBHO5Y5rd9dwd7qDTttC5Kcjv0uBAcbVTZ46X1fTGNd9jkfP17Yc1j 62Uneyly8ggOfsR+v1KdQxNGimSVUVAoqHT7jwGBcU/1Nw248NLKi9/8BAlS5W0ljCSz SSyrP6s8kOYqZt7cH1TfjBPw3DvlOQGbL+1nYZQ9IVzbEWl1ACzW/h0rQK/54VGviDxV TEGkRikr9lIL58MVxNcnAPRp51Cj7UPpTEw7mCQ0QrxjrVXmdo9zvKMQeTPz9YcJlARF X8G0nNlZuKRTTT0U2RAMiXX/JhN3eDV2/iYc+WMOmo+3JHdaBEIoXCB/vL713m6HbTi+ YKDQ== X-Gm-Message-State: AOJu0Yz640+tEKqAbyl3mnb5qs5fPtuvNUv/qvnAjDucqpWMTU1YxG3D ho1d9KfzWjAuINOTLoc8bFoR7Az7yFLSP+8loCTh+ofYz/yJjmfeM9CVyN0YJw6xACsokh72IZn j5SVD0UWmlpUHNgOxXMGimlthg4oRxQ== X-Gm-Gg: ASbGnctl1JlWP1dTSm1pPELimHitgJUEB4CL4ZyAHaH1440mT1oEm/Vefg3LfJCvNqx yLwNcEHGJVUnLaG6AY+lG4oU8W+5VWWifddOuT9YyQHOCydqV65IWdIDhCnrzmPbYy7Bu63o6 X-Google-Smtp-Source: AGHT+IFomayNprFcr9dtBR+joyBYHDX17coWPbVAtS/PlLnDamCBswuwz+2RR+2QwgQD7lURyyMuVnvHx8Jvkor5z7Q= X-Received: by 2002:a05:6122:d98:b0:515:f586:5298 with SMTP id 71dfb90a1353d-51e9e3f69fcmr9302338e0c.7.1738260696990; Thu, 30 Jan 2025 10:11:36 -0800 (PST) MIME-Version: 1.0 References: <CAN+1Hbp4cCY08yzayQDinqGqjjOYQK_wd5XKpg2t9J+ox-Zn_g@HIDDEN> <87v7twtcnf.fsf@HIDDEN> In-Reply-To: <87v7twtcnf.fsf@HIDDEN> From: Ship Mints <shipmints@HIDDEN> Date: Thu, 30 Jan 2025 13:09:45 -0500 X-Gm-Features: AWEUYZkUJBcdskhkNPS5OSHOHEwznyjKQacnK27lW2ypQ7Jf5ZOkGxme3j5EoXI Message-ID: <CAN+1Hbp=57W4Rf5E-RNTVy+0GDv=dpOp4OugubtML96s2YJRAg@HIDDEN> Subject: Re: bug#75945: tab-bar-new-tab-to tab post clone improvement To: Juri Linkov <juri@HIDDEN> Content-Type: multipart/alternative; boundary="0000000000005f0943062cf05bbd" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75945 Cc: 75945 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --0000000000005f0943062cf05bbd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable That trick works, if a bit circuitous. Thank you. Is it really the case that adding an &optional argument to a hook function breaks those that accept only the mandatory arguments? On Thu, Jan 30, 2025 at 12:52=E2=80=AFPM Juri Linkov <juri@HIDDEN> wrot= e: > > The existing hooks: post open, post close, post clone (patch submitted)= , > > are insufficient in the tab clone case where users employ custom tab > > parameters. Such tab parameters often need post-clone curation. In my > case, > > cumbersome tab-bar advice is needed to work around cloning. Others migh= t > > experience the same need. > > > > I see a few ways we can help address this. Once we agree on an approach= , > > I'm happy to submit a patch. > > > > 1. Alter tab-bar-tab-post-open-functions to accept an optional second > > argument, namely, the originating tab, iff tab-bar-new-tab-choice 'clon= e. > > Adding a new argument will break the existing uses. This could be > avoided by using (condition-case ... (wrong-number-of-arguments ...)). > > But much simpler would be just to check the dynamically bound value > in the hook, e.g.: > > (add-hook 'tab-bar-tab-post-open-functions > (lambda (tab) > (when (eq tab-bar-new-tab-choice 'clone) > (message "Cloned tab %S" tab)))) > > > 2. Create a new hook tab-bar-post-duplicate-tab-functions, the function= s > of > > which accept two arguments: the originating tab, the cloned tab, and > where > > the hook runs iff tab-bar-new-tab-choice 'clone. > > The existing hook tab-bar-tab-post-open-functions doesn't accept the > originating tab. But still it's possible to get the originating tab > using tab-bar--tab-index-recent. > > > 3. In harmony with clone-frame, tab-bar could propagate tab parameters > to a > > cloned tab (it already saves them naturally, for use in undo close tab)= , > > modulo internal tab-bar parameters. A post-clone hook would still be > needed > > to allow a user to control their custom parameters. (A new post > undo-close > > tab hook patch is pending to support the undo case.) > > A cloned tab already inherits the group with tab-bar-new-tab-group. > > And it's easy to get other parameters from the originating tab using > tab-bar--tab-index-recent in the tab-bar-tab-post-open-functions hook. > --0000000000005f0943062cf05bbd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:monospac= e">That trick works,=C2=A0if a bit circuitous. Thank you.</div><div class= =3D"gmail_default" style=3D"font-family:monospace"><br></div><div class=3D"= gmail_default" style=3D"font-family:monospace">Is it really the case that a= dding an &optional argument to a hook function breaks those that accept= only the mandatory arguments?</div></div><br><div class=3D"gmail_quote gma= il_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Thu, Jan 30, 2= 025 at 12:52=E2=80=AFPM Juri Linkov <<a href=3D"mailto:juri@HIDDEN">= juri@HIDDEN</a>> wrote:<br></div><blockquote class=3D"gmail_quote" s= tyle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pad= ding-left:1ex">> The existing hooks: post open, post close, post clone (= patch submitted),<br> > are insufficient in the tab clone case where users employ custom tab<b= r> > parameters. Such tab parameters often need post-clone curation. In my = case,<br> > cumbersome tab-bar advice is needed to work around cloning. Others mig= ht<br> > experience the same need.<br> ><br> > I see a few ways we can help address this. Once we agree on an approac= h,<br> > I'm happy to submit a patch.<br> ><br> > 1. Alter tab-bar-tab-post-open-functions to accept an optional second<= br> > argument, namely, the originating tab, iff tab-bar-new-tab-choice '= ;clone.<br> <br> Adding a new argument will break the existing uses.=C2=A0 This could be<br> avoided by using (condition-case ... (wrong-number-of-arguments ...)).<br> <br> But much simpler would be just to check the dynamically bound value<br> in the hook, e.g.:<br> <br> (add-hook 'tab-bar-tab-post-open-functions<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (lambda (tab)<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (when (eq tab-bar-new-tab-choice = 'clone)<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (message "Cloned tab = %S" tab))))<br> <br> > 2. Create a new hook tab-bar-post-duplicate-tab-functions, the functio= ns of<br> > which accept two arguments: the originating tab, the cloned tab, and w= here<br> > the hook runs iff tab-bar-new-tab-choice 'clone.<br> <br> The existing hook tab-bar-tab-post-open-functions doesn't accept the<br= > originating tab.=C2=A0 But still it's possible to get the originating t= ab<br> using tab-bar--tab-index-recent.<br> <br> > 3. In harmony with clone-frame, tab-bar could propagate tab parameters= to a<br> > cloned tab (it already saves them naturally, for use in undo close tab= ),<br> > modulo internal tab-bar parameters. A post-clone hook would still be n= eeded<br> > to allow a user to control their custom parameters. (A new post undo-c= lose<br> > tab hook patch is pending to support the undo case.)<br> <br> A cloned tab already inherits the group with tab-bar-new-tab-group.<br> <br> And it's easy to get other parameters from the originating tab using<br= > tab-bar--tab-index-recent in the tab-bar-tab-post-open-functions hook.<br> </blockquote></div> --0000000000005f0943062cf05bbd--
bug-gnu-emacs@HIDDEN:bug#75945; Package emacs.
Full text available.Received: (at 75945) by debbugs.gnu.org; 30 Jan 2025 17:52:38 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 30 12:52:38 2025 Received: from localhost ([127.0.0.1]:47663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tdYiT-0006Tq-La for submit <at> debbugs.gnu.org; Thu, 30 Jan 2025 12:52:38 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:41197) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1tdYiR-0006Tb-1j for 75945 <at> debbugs.gnu.org; Thu, 30 Jan 2025 12:52:35 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 3310A204A5; Thu, 30 Jan 2025 17:52:24 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Ship Mints <shipmints@HIDDEN> Subject: Re: bug#75945: tab-bar-new-tab-to tab post clone improvement In-Reply-To: <CAN+1Hbp4cCY08yzayQDinqGqjjOYQK_wd5XKpg2t9J+ox-Zn_g@HIDDEN> (Ship Mints's message of "Thu, 30 Jan 2025 08:17:28 -0500") Organization: LINKOV.NET References: <CAN+1Hbp4cCY08yzayQDinqGqjjOYQK_wd5XKpg2t9J+ox-Zn_g@HIDDEN> Date: Thu, 30 Jan 2025 19:49:40 +0200 Message-ID: <87v7twtcnf.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdeigeejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrdeliedrledtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrdeliedrledtpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepvddprhgtphhtthhopeejheelgeehseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepshhhihhpmhhinhhtshesghhmrghilhdrtghomh X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75945 Cc: 75945 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) > The existing hooks: post open, post close, post clone (patch submitted), > are insufficient in the tab clone case where users employ custom tab > parameters. Such tab parameters often need post-clone curation. In my case, > cumbersome tab-bar advice is needed to work around cloning. Others might > experience the same need. > > I see a few ways we can help address this. Once we agree on an approach, > I'm happy to submit a patch. > > 1. Alter tab-bar-tab-post-open-functions to accept an optional second > argument, namely, the originating tab, iff tab-bar-new-tab-choice 'clone. Adding a new argument will break the existing uses. This could be avoided by using (condition-case ... (wrong-number-of-arguments ...)). But much simpler would be just to check the dynamically bound value in the hook, e.g.: (add-hook 'tab-bar-tab-post-open-functions (lambda (tab) (when (eq tab-bar-new-tab-choice 'clone) (message "Cloned tab %S" tab)))) > 2. Create a new hook tab-bar-post-duplicate-tab-functions, the functions of > which accept two arguments: the originating tab, the cloned tab, and where > the hook runs iff tab-bar-new-tab-choice 'clone. The existing hook tab-bar-tab-post-open-functions doesn't accept the originating tab. But still it's possible to get the originating tab using tab-bar--tab-index-recent. > 3. In harmony with clone-frame, tab-bar could propagate tab parameters to a > cloned tab (it already saves them naturally, for use in undo close tab), > modulo internal tab-bar parameters. A post-clone hook would still be needed > to allow a user to control their custom parameters. (A new post undo-close > tab hook patch is pending to support the undo case.) A cloned tab already inherits the group with tab-bar-new-tab-group. And it's easy to get other parameters from the originating tab using tab-bar--tab-index-recent in the tab-bar-tab-post-open-functions hook.
bug-gnu-emacs@HIDDEN:bug#75945; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 30 Jan 2025 13:19:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 30 08:19:47 2025 Received: from localhost ([127.0.0.1]:44972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tdUSR-0006AD-0p for submit <at> debbugs.gnu.org; Thu, 30 Jan 2025 08:19:47 -0500 Received: from lists.gnu.org ([2001:470:142::17]:49852) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <shipmints@HIDDEN>) id 1tdUSO-00069j-47 for submit <at> debbugs.gnu.org; Thu, 30 Jan 2025 08:19:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <shipmints@HIDDEN>) id 1tdUS2-000071-Vp for bug-gnu-emacs@HIDDEN; Thu, 30 Jan 2025 08:19:23 -0500 Received: from mail-ua1-x92a.google.com ([2607:f8b0:4864:20::92a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <shipmints@HIDDEN>) id 1tdUS1-0000Oy-4f for bug-gnu-emacs@HIDDEN; Thu, 30 Jan 2025 08:19:22 -0500 Received: by mail-ua1-x92a.google.com with SMTP id a1e0cc1a2514c-85bafa89d73so154947241.2 for <bug-gnu-emacs@HIDDEN>; Thu, 30 Jan 2025 05:19:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738243159; x=1738847959; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=bLY9mMps1VJRSeo+OydVk75QNu2Hz8BgXY2Irw9iUSo=; b=g9tt4bFtGoCPe7g85/wUi6O9RDJu8/6PlA/1bmLqK//bFYcRSJdIf4xoa4MwOrnn2Y Iyes/JAvVFPgteSNiU4HhW9UK0Veii6oS3yr5+X0efpBmFdmwdTE/tn3GF4rwHSShuFu HCntZYClmWOOdRTCn+b6uHjSBcPaMbCINIw7ZzUKM0aN6hYG2KvvMaXTkkJkYQGzB/xz /3YBIyeUpZQHmYDy3B7Y+Ik2YCldBO8gWr8STAMAs5MAz1nNsNiZtGEtIlq7JRfuptQe epPYaA9IhITQmIXVMCYKTyVFVJfn90CzOUUZzrVCmDlR8JKI89jnWc8o8LGSLUIxDAR1 At9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738243159; x=1738847959; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=bLY9mMps1VJRSeo+OydVk75QNu2Hz8BgXY2Irw9iUSo=; b=VJO9bA/WblpHa0qVQe2lSY9AKC7VMi3FzuqdVpX9RXZgbj/bpxTSJOJq6eBLQ1xU1v QBY36z+EQAuz7bcu9jyvcxbaDNp4JIoxfVDqoP+tBLoSXJs+CVq7WhXQxLOB54jiKsKN OT9HYJ+yA5VoILcPgQNYULI82MpV/TgUnXnmqu37AEejonwMbo5lXELceeDBPwAjsiOO 1IBT/ojmOCeE1if2YUikjDKE0kfeC4UME3xQqwFTbmhcSVgJmrJ5jarhlFp/Fq3KapiU NTH/02bQGRLGi+RKUM0KS+2ZJXxql/Hh+gzGZ+yugHHnMgALzMpCmtP+G2hZYeV0KM5E EdMw== X-Gm-Message-State: AOJu0YyJ0Q16cqmfFjmIVRz9r5jDfkj+3n8R0hjFyGYtblKOvcBl8+X9 MsIkl9qJMG9Udcta3T9CAulkSBKqERHOwL49NYsLpchbmThwVUqiLIaieCm5Y1FTprQIyyYW+LE H8SghEQr/3GW8UTbHKv+/7Ahtzq1l9DJI X-Gm-Gg: ASbGncuxKV9sUW5438nnx9TRWLydntPOQ+NR0fj2LkF8cAJh/l9Xzwii1PC+mxz4SNY 6RuYvSeWxGxYXrySm+oPbkUiSsWdPBcZpR66qskXgl+01b7CAA6zesa0PSFHpWdaBBT54Zucm X-Google-Smtp-Source: AGHT+IFQU7f9Hb+ni3hhrDlch+8+jxKzF9Nhv5zz/AZVaz/yJ86q5xbWel2vUCRqRqAcFTXkRxBeaKSnGE1UVLS1FGU= X-Received: by 2002:a05:6102:664:b0:4b9:c02b:afc2 with SMTP id ada2fe7eead31-4b9c02bb055mr503802137.3.1738243159678; Thu, 30 Jan 2025 05:19:19 -0800 (PST) MIME-Version: 1.0 From: Ship Mints <shipmints@HIDDEN> Date: Thu, 30 Jan 2025 08:17:28 -0500 X-Gm-Features: AWEUYZldiQDM1-CJ2SFiG4L3c1goBbifh1JdiyECB-6H8HnTVTqYraQIqZ7MS94 Message-ID: <CAN+1Hbp4cCY08yzayQDinqGqjjOYQK_wd5XKpg2t9J+ox-Zn_g@HIDDEN> Subject: tab-bar-new-tab-to tab post clone improvement To: bug-gnu-emacs@HIDDEN, Juri Linkov <juri@HIDDEN> Content-Type: multipart/alternative; boundary="00000000000010e5f8062cec46e3" Received-SPF: pass client-ip=2607:f8b0:4864:20::92a; envelope-from=shipmints@HIDDEN; helo=mail-ua1-x92a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) --00000000000010e5f8062cec46e3 Content-Type: text/plain; charset="UTF-8" The existing hooks: post open, post close, post clone (patch submitted), are insufficient in the tab clone case where users employ custom tab parameters. Such tab parameters often need post-clone curation. In my case, cumbersome tab-bar advice is needed to work around cloning. Others might experience the same need. I see a few ways we can help address this. Once we agree on an approach, I'm happy to submit a patch. 1. Alter tab-bar-tab-post-open-functions to accept an optional second argument, namely, the originating tab, iff tab-bar-new-tab-choice 'clone. 2. Create a new hook tab-bar-post-duplicate-tab-functions, the functions of which accept two arguments: the originating tab, the cloned tab, and where the hook runs iff tab-bar-new-tab-choice 'clone. 3. In harmony with clone-frame, tab-bar could propagate tab parameters to a cloned tab (it already saves them naturally, for use in undo close tab), modulo internal tab-bar parameters. A post-clone hook would still be needed to allow a user to control their custom parameters. (A new post undo-close tab hook patch is pending to support the undo case.) 4. In pseudo harmony with clone-frame, add tab-bar-duplicate-tab-clone-parameters-functions hook, the user-provided functions of which would accept the originating tab, and return the list of parameters to clone. My preference is 1, the simplest, but I can be persuaded that another on this list, or a different one entirely, is acceptable. -Stephane --00000000000010e5f8062cec46e3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:monospac= e">The existing hooks: post open, post close, post clone (patch submitted),= are insufficient in the tab clone case where users=C2=A0employ custom tab = parameters. Such tab parameters often need post-clone curation. In my case,= cumbersome tab-bar advice is needed to work around cloning. Others might e= xperience the same need.</div><div class=3D"gmail_default" style=3D"font-fa= mily:monospace"><br></div><div class=3D"gmail_default" style=3D"font-family= :monospace">I see a few ways we can help address this. Once we agree on an = approach, I'm happy to submit a patch.</div><div class=3D"gmail_default= " style=3D"font-family:monospace"><br></div><div class=3D"gmail_default" st= yle=3D"font-family:monospace">1. Alter tab-bar-tab-post-open-functions to a= ccept an optional second argument, namely, the originating tab, iff tab-bar= -new-tab-choice 'clone.<br></div><div class=3D"gmail_default" style=3D"= font-family:monospace"><br></div><div class=3D"gmail_default" style=3D"font= -family:monospace">2. Create a new hook tab-bar-post-duplicate-tab-function= s, the functions of which accept two arguments: the originating tab, the cl= oned tab, and where the hook runs=C2=A0iff tab-bar-new-tab-choice 'clon= e.</div><div class=3D"gmail_default" style=3D"font-family:monospace"><br>3.= =C2=A0In harmony with clone-frame, tab-bar could propagate tab parameters t= o a cloned tab (it already saves them naturally, for use in undo close tab)= , modulo internal tab-bar parameters. A post-clone hook would still be need= ed to allow a user to control their custom parameters. (A new post undo-clo= se tab hook patch is pending to support the undo case.)</div><div class=3D"= gmail_default" style=3D"font-family:monospace"><br></div><div class=3D"gmai= l_default" style=3D"font-family:monospace">4. In pseudo harmony with clone-= frame, add tab-bar-duplicate-tab-clone-parameters-functions hook, the user-= provided functions of which would accept the originating tab, and return th= e list of parameters to clone.</div><div class=3D"gmail_default" style=3D"f= ont-family:monospace"><br></div><div class=3D"gmail_default" style=3D"font-= family:monospace">My preference is 1, the simplest, but I can be persuaded = that another on this list, or a different one entirely, is acceptable.</div= ><div class=3D"gmail_default" style=3D"font-family:monospace"><br></div><di= v class=3D"gmail_default" style=3D"font-family:monospace">-Stephane</div></= div> --00000000000010e5f8062cec46e3--
Ship Mints <shipmints@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#75945; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.