GNU bug report logs - #75953
30.0.92; Bookmark fringe indicator not removed

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75953 in the body.
You can then email your comments to 75953 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.92; Bookmark fringe indicator not removed
Date: Thu, 30 Jan 2025 22:04:20 +0100

Hello.

I'm sending this bug report as a continuation of this closed report 
bug#51233.

The fringe indicator for bookmarks is correctly set, but the procedure 
`bookmark-delete-all` does not delete the indicator.

Steps for reproduction:

1. Run emacs -q

2. Create a new file, say /tmp/test.txt

3. Ensure bookmark-set-fringe-mark is t (should be by default)

4. Add some text and bookmark the line: a fringe indicator should appear
   at the left

5. Call `bookmark-delete-all` to delete the bookmark: the fringe 
indicator is still there


Best regards,
Sergio.

Message #8 received at 75953 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>
Cc: 75953 <at> debbugs.gnu.org
Subject: Re: bug#75953: 30.0.92; Bookmark fringe indicator not removed
Date: Fri, 31 Jan 2025 10:03:12 +0200

> Date: Thu, 30 Jan 2025 22:04:20 +0100
> From: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>
> 
> Hello.
> 
> I'm sending this bug report as a continuation of this closed report 
> bug#51233.
> 
> The fringe indicator for bookmarks is correctly set, but the procedure 
> `bookmark-delete-all` does not delete the indicator.
> 
> Steps for reproduction:
> 
> 1. Run emacs -q
> 
> 2. Create a new file, say /tmp/test.txt
> 
> 3. Ensure bookmark-set-fringe-mark is t (should be by default)
> 
> 4. Add some text and bookmark the line: a fringe indicator should appear
>     at the left
> 
> 5. Call `bookmark-delete-all` to delete the bookmark: the fringe 
> indicator is still there

Does the patch below give good results?

diff --git a/lisp/bookmark.el b/lisp/bookmark.el
index cd59293..153646c 100644
--- a/lisp/bookmark.el
+++ b/lisp/bookmark.el
@@ -1584,6 +1584,8 @@ bookmark-delete-all
   (when (or no-confirm
             (yes-or-no-p "Permanently delete all bookmarks? "))
     (bookmark-maybe-load-default-file)
+    (dolist (bm bookmark-alist)
+      (bookmark--remove-fringe-mark bm))
     (setq bookmark-alist-modification-count
           (+ bookmark-alist-modification-count (length bookmark-alist)))
     (setq bookmark-alist nil)

Message #11 received at 75953 <at> debbugs.gnu.org (full text, mbox):

From: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 75953 <at> debbugs.gnu.org
Subject: Re: bug#75953: 30.0.92; Bookmark fringe indicator not removed
Date: Fri, 31 Jan 2025 21:08:01 +0100

Hello!

On 1/31/25 09:03, Eli Zaretskii wrote:
> Does the patch below give good results?

Yes, the patch fixes the issue.

Thanks for taking a look at it.

Regards,
Sergio

Message #16 received at 75953-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>
Cc: 75953-done <at> debbugs.gnu.org
Subject: Re: bug#75953: 30.0.92; Bookmark fringe indicator not removed
Date: Sat, 01 Feb 2025 11:34:44 +0200

> Date: Fri, 31 Jan 2025 21:08:01 +0100
> Cc: 75953 <at> debbugs.gnu.org
> From: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>
> 
> Hello!
> 
> On 1/31/25 09:03, Eli Zaretskii wrote:
> > Does the patch below give good results?
> 
> Yes, the patch fixes the issue.
> 
> Thanks for taking a look at it.

Thanks, installed on the emacs-30 branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.