Received: (at 75956-done) by debbugs.gnu.org; 13 Feb 2025 09:34:20 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 13 04:34:20 2025 Received: from localhost ([127.0.0.1]:40417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tiVbv-0002pS-Qo for submit <at> debbugs.gnu.org; Thu, 13 Feb 2025 04:34:20 -0500 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]:60700) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tiVbt-0002pA-Kj for 75956-done <at> debbugs.gnu.org; Thu, 13 Feb 2025 04:34:18 -0500 Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-5ded46f323fso191723a12.1 for <75956-done <at> debbugs.gnu.org>; Thu, 13 Feb 2025 01:34:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739439251; x=1740044051; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=YmkTMIqwKL2iRSfejgEhnOZbpbXkz6FI5/DCYHapEoA=; b=nZ9q+HBucL4wlPcBbbLM8sVA/5RWrd5HwCOW7LppadkWCcgkn22cGHRE4pVZ9NPda9 Doyyd6JZ/B5v866an0gBGSSTz8l4QCmxlH/yTMj+9HxEDnvTdX3L58WUy9qhTjmp7XQR EFt7A6FIVzBVxhQ8yFVWlokBf1eAmDrs0YotzfginzYLAQlZOJ/Ykg8K/XEXu46gsU5r zKTRrp9k4xpBEhkM8Ps/GtzcFV7bSD+iFyatoVrVMARlK81vvaFl90bj/HCFj2DIZmbS VD0YcnyshccWCyaiWkuO3TfSs48ZKkYdqSyZ5tlm4lxr0A3tKz1VudQz7fsjc2Q1dMjI 5YOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739439251; x=1740044051; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=YmkTMIqwKL2iRSfejgEhnOZbpbXkz6FI5/DCYHapEoA=; b=jmXZbV/1/JFTEKKtVTCsGbtCSp40Thjro3daF6K1bA16pRtqx3wMgKeNRaxNQdmZmX Zymhr0wavtLFUWVOyBjFthU9cxf8kEhnELuf6jbrZq28NNS6ipdRl4nC+13XG8cVoDwQ 7qhrZJ4L4yamEJT2NXr+scjzCzANgC5UicIPkbzC0fEdtVlkCu+GNARPx1k9DekzQ4Q8 JzFV5YDlDMjHX46CSIJ7xjThHhLdw2gaHQ1/OmKgdvBEU2rqxf9hBjouyj/8JEUglr1y CCTQ7M03maYM3SEvi5dXaT/4xc//mJU2S40IyYa987yE4YdPnjDpC7E4SdQlVUfPund0 S4Pg== X-Forwarded-Encrypted: i=1; AJvYcCW40xSQFs0JAtAxaC/r7u8kV1m6R9nny9ElhDWs+jKJ9jn8j0zALLT7Spp3DBP5hUq0MtTSCcZ6/LSC <at> debbugs.gnu.org X-Gm-Message-State: AOJu0Yxgt8Mw/kEYblFIeaFFTTNyZY41ExthJbFZgMAZctMyfNVL1SQ2 /rQOIOk3tLEWFGl5tnm9ftnnQNTWrSh3v1gSdyX8j1fN+FkPJv0PLEHOGZYyK4KdB7g9NBlDLbZ IGl8HB46hM5i4eGCm47rx7uBEqUU= X-Gm-Gg: ASbGncvp5A5oJmsvibJ2HycknPibezzV7uHD1wL88ujyMDDX39VuyNoC4IXjbC2EcT2 QUt9I/Hsc9wKiTY0hIOsYYZ3apVVmRbCyzChI4p7iJUT/LTgT/kploVy7FzlN+3fPIA8k7jHwVk 8= X-Google-Smtp-Source: AGHT+IHRnkF2T+Co1z4A5Q/tDAk+bdpJQTz8oRvhRt7z8/6snlKAr9gqgRwNY4omrApdnlSHJeJRsCtcSPfzuy6afRg= X-Received: by 2002:a05:6402:278a:b0:5d0:b7c5:c3fc with SMTP id 4fb4d7f45d1cf-5deadd78004mr6728108a12.3.1739439251263; Thu, 13 Feb 2025 01:34:11 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 13 Feb 2025 01:34:09 -0800 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <67acf520.170a0220.49d33.131dSMTPIN_ADDED_BROKEN@HIDDEN> References: <86ldug3gl9.fsf@HIDDEN> <67a78f54.050a0220.22ba7c.4eb4SMTPIN_ADDED_BROKEN@HIDDEN> <CADwFkm=UXFxi5gr9v6v_QY9Ys6kfMCFdi31xBRb3HD+UnCZ+sQ@HIDDEN> <67ab705c.df0a0220.1717fd.a7d7SMTPIN_ADDED_BROKEN@HIDDEN> <CADwFkmmui=nFmXXdjg_P56JcZmZ=VxQ_0_iAn0n=ew+aJCuLyA@HIDDEN> <67abacdb.500a0220.c5250.9942SMTPIN_ADDED_BROKEN@HIDDEN> <CADwFkmnhkm6X5PO-9Ea-RfkUqdEkhXCAfbn3kyNBn3V=jAmH1w@HIDDEN> <86zfiruzb4.fsf@HIDDEN> <67ace50f.0c0a0220.85353.183cSMTPIN_ADDED_BROKEN@HIDDEN> <CADwFkm=H8TQwpH9C8c2dQAHrQJGtiWQN48TAWojta_9v07cnbQ@HIDDEN> <67acf520.170a0220.49d33.131dSMTPIN_ADDED_BROKEN@HIDDEN> MIME-Version: 1.0 Date: Thu, 13 Feb 2025 01:34:09 -0800 X-Gm-Features: AWEUYZm_mMCeei-Uy4xF-AfHHArhy8xiIeSoQaufQI80pjj_r2Ctyq3v56Edeu0 Message-ID: <CADwFkmk8+G8+OfrzHZDdw7AD+C3vH0cRh4ji1xEj1ZLdez1LgQ@HIDDEN> Subject: Re: bug#75956: Various improvements to sieve.el To: =?UTF-8?B?QmrDtnJuIEJpZGFy?= <bjorn.bidar@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75956-done Cc: Eli Zaretskii <eliz@HIDDEN>, 75956-done <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Version: 31.1 Bj=C3=B6rn Bidar <bjorn.bidar@HIDDEN> writes: > From 653a0196fd32c2fe0262beeb50e7fb74a0345d13 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Bj=3DC3=3DB6rn=3D20Bidar?=3D <bjorn.bidar@HIDDEN> > Date: Fri, 31 Jan 2025 02:34:19 +0200 > Subject: [PATCH 1/3] * lisp/net/sieve.el: Read port in sieve-manage when > interactive > > (sieve-manage): Optionally read port when called interactively. > Add previously missing documentation string. (Bug#75956) Thanks, I installed your patches on master with some minor touchups (commits 07d1fdb1ea2, c5bfaf1ae3e, and 6967587daef). Please take a look at the changes I did for reference. I'm consequently closing this bug report.
Björn Bidar <bjorn.bidar@HIDDEN>:Stefan Kangas <stefankangas@HIDDEN>:Received: (at 75956) by debbugs.gnu.org; 12 Feb 2025 19:23:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 12 14:23:21 2025
Received: from localhost ([127.0.0.1]:38332 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tiIKO-0003VZ-JK
for submit <at> debbugs.gnu.org; Wed, 12 Feb 2025 14:23:21 -0500
Received: from thaodan.de ([185.216.177.71]:46580)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <bjorn.bidar@HIDDEN>)
id 1tiIKM-0003VJ-Dw
for 75956 <at> debbugs.gnu.org; Wed, 12 Feb 2025 14:23:19 -0500
Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49])
by thaodan.de (Postfix) with ESMTPSA id A1AA2D00055;
Wed, 12 Feb 2025 21:23:11 +0200 (EET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail;
t=1739388191; bh=fLcGdK0YYktdODIWXcTdtQ4DTABYGwT6Kgzq6qk4w3Q=;
h=From:To:Cc:Subject:In-Reply-To:References:Date;
b=xzNMJJgfaiV5DlvdUbNePv1P7pWzA/wT7GYgUlNDTAtJXvG/2GXNcauVGugWF2ZeO
Hzv4O7RpExLir2i+hmdrdQlpomxn5McIsZDelkxM1OUB73oKynj9prELm2L5Ra9Uky
1NGLuNV/d7IMVrU2wB5OkFWWAN12tz+O2EoUgzQiXtSBr+QCyN8XJmwNWDWrVGiuJr
reoq/qtdb7kawDbAcypMQ31sOOUfMTcZ+3YV19ycZg+0yBcwnDSK+43bG76eNfKTAA
q8ibIKAuApQgWacJqlat8WOzGpOnOtTey1uuEEeLfWidD0hmg5X1Bl1rxvJRfw6qvB
uMp5iAEfg3TB8WsFRdn3fJO4gsl46aAiG6n2R5Gt94ip1qCHq0GHXL2sTfO/jg5IX6
uK2FlxjWJznn+YBYRhtyxhTd2jBKnJR2jCPXaGNC2qze+QOidFVRpanv6ayuPoTppA
zWZCBc56T8OE1y3GxE/C1wBJY9HvKom4D85FlfCMDUjCW6X5CseIg+Xe5QS70T7Npy
WCuRULtwqq9xJFFLVL0hHRtAtmy57CAGQ3ReRb1AmNqwFxQsCLug1LK2IEDDV/5jv6
T8BXqHnVqL1c+eHjBfLC6Ofh6nMqEHQYeugZY2blRnrUZjwrytCQaHHYNsBxpBXT6R
3qfJb9kUL0J+sIyht4UoZrbs=
From: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN>
To: Stefan Kangas <stefankangas@HIDDEN>
Subject: Re: bug#75956: Various improvements to sieve.el
In-Reply-To: <CADwFkm=H8TQwpH9C8c2dQAHrQJGtiWQN48TAWojta_9v07cnbQ@HIDDEN>
(Stefan Kangas's message of "Wed, 12 Feb 2025 10:47:31 -0800")
References: <86ldug3gl9.fsf@HIDDEN>
<67a78f54.050a0220.22ba7c.4eb4SMTPIN_ADDED_BROKEN@HIDDEN>
<CADwFkm=UXFxi5gr9v6v_QY9Ys6kfMCFdi31xBRb3HD+UnCZ+sQ@HIDDEN>
<67ab705c.df0a0220.1717fd.a7d7SMTPIN_ADDED_BROKEN@HIDDEN>
<CADwFkmmui=nFmXXdjg_P56JcZmZ=VxQ_0_iAn0n=ew+aJCuLyA@HIDDEN>
<67abacdb.500a0220.c5250.9942SMTPIN_ADDED_BROKEN@HIDDEN>
<CADwFkmnhkm6X5PO-9Ea-RfkUqdEkhXCAfbn3kyNBn3V=jAmH1w@HIDDEN>
<86zfiruzb4.fsf@HIDDEN>
<67ace50f.0c0a0220.85353.183cSMTPIN_ADDED_BROKEN@HIDDEN>
<CADwFkm=H8TQwpH9C8c2dQAHrQJGtiWQN48TAWojta_9v07cnbQ@HIDDEN>
Autocrypt: addr=bjorn.bidar@HIDDEN; prefer-encrypt=nopreference; keydata=
mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq
w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV
CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl
HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8
phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF
CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h
K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2
cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC
HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN
XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg
gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL
AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E
TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB
B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe
pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO
HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG
AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr
dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n
KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy
GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK
S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA==
Date: Wed, 12 Feb 2025 21:23:10 +0200
Message-ID: <87a5arezmp.fsf@>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Stefan Kangas <stefankangas@HIDDEN> writes: > Björn Bidar
via "Bug reports for GNU Emacs, the Swiss army knife of text > editors" <bug-gnu-emacs@HIDDEN>
writes: > >> Eli Zaretskii <eliz@HIDDEN> writes: >> >>>> From: Stefan Kangas
<stefankang [...]
Content analysis details: (1.2 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The
query to Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243
for more information.
[185.216.177.71 listed in sa-trusted.bondedsender.org]
0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The
query to Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243
for more information.
[185.216.177.71 listed in bl.score.senderscore.com]
-0.0 SPF_PASS SPF: sender matches SPF record
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822
X-Debbugs-Envelope-To: 75956
Cc: Eli Zaretskii <eliz@HIDDEN>, 75956 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Stefan Kangas <stefankangas@HIDDEN> writes:
> Bj=C3=B6rn Bidar via "Bug reports for GNU Emacs, the Swiss army knife of =
text
> editors" <bug-gnu-emacs@HIDDEN> writes:
>
>> Eli Zaretskii <eliz@HIDDEN> writes:
>>
>>>> From: Stefan Kangas <stefankangas@HIDDEN>
>>>> Date: Tue, 11 Feb 2025 12:09:16 -0800
>>>> Cc: Eli Zaretskii <eliz@HIDDEN>, 75956 <at> debbugs.gnu.org
>>>>
>>>> Yeah, we have to be brief, which makes this hard. How about this:
>>>>
>>>> Server (optionally followed by `:port'):
>>>>
>>>> Eli, any better ideas?
>>>
>>> That's not bad. Another possibility:
>>>
>>> Server and port (SERVER[:PORT]):
>>
>> Which one is preferred? Personally I'm fine with either. I already
>> updated the patch with Stefan's suggestion.
>
> I think we can go with Eli's suggestion here. Users that want to
> understand things better should read the docstring.
Ok there you go:
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0001-lisp-net-sieve.el-Read-port-in-sieve-manage-when-int.patch
From 653a0196fd32c2fe0262beeb50e7fb74a0345d13 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= <bjorn.bidar@HIDDEN>
Date: Fri, 31 Jan 2025 02:34:19 +0200
Subject: [PATCH 1/3] * lisp/net/sieve.el: Read port in sieve-manage when
interactive
(sieve-manage): Optionally read port when called interactively.
Add previously missing documentation string. (Bug#75956)
---
lisp/net/sieve.el | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/lisp/net/sieve.el b/lisp/net/sieve.el
index f9f036e1589..f0801238ab1 100644
--- a/lisp/net/sieve.el
+++ b/lisp/net/sieve.el
@@ -338,7 +338,15 @@ sieve-refresh-scriptlist
;;;###autoload
(defun sieve-manage (server &optional port)
- (interactive "sServer: ")
+ "Open ManageSieve SERVER.
+Optionally argument PORT specifies the port use;
+otherwise it defaults to `sieve-manage-default-port'.
+
+When called interactively, prompt for SERVER:PORT
+if :PORT is not specified fall back to `sieve-manage-default-port'."
+ (interactive
+ (split-string (read-string
+ "Server and port (SERVER[:PORT]): ") ":"))
(switch-to-buffer (get-buffer-create sieve-buffer))
(sieve-manage-mode)
(sieve-setup-buffer server port)
--
2.45.2
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0002-lisp-net-sieve.el-Add-missing-documentation-strings.patch
From 8f4f586617805a349339cb5e35341d96c82aa107 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= <bjorn.bidar@HIDDEN>
Date: Fri, 31 Jan 2025 02:53:34 +0200
Subject: [PATCH 2/3] * lisp/net/sieve.el: Add missing documentation strings
(sieve-activate, sieve-deactivate-all, sieve-remove)
(sieve-edit-script, sieve-refersh-scriptlist)
(sieve-upload, sieve-upload-and-burry)
(sieve-upload-and-kill): Add documentation strings (Bug#75956)
---
lisp/net/sieve.el | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/lisp/net/sieve.el b/lisp/net/sieve.el
index f0801238ab1..5b4c2440266 100644
--- a/lisp/net/sieve.el
+++ b/lisp/net/sieve.el
@@ -161,6 +161,7 @@ sieve-bury-buffer
(bury-buffer))
(defun sieve-activate (&optional _pos)
+ "Activate script at point."
(interactive)
(let ((name (sieve-script-at-point)) err)
(when (or (null name) (string-equal name sieve-new-script))
@@ -173,6 +174,7 @@ sieve-activate
(message "Activating script %s...failed: %s" name (nth 2 err)))))
(defun sieve-deactivate-all (&optional _pos)
+ "Deactivate all currently active scripts."
(interactive)
(message "Deactivating scripts...")
(let (;; (name (sieve-script-at-point))
@@ -185,6 +187,7 @@ sieve-deactivate-all
(defalias 'sieve-deactivate #'sieve-deactivate-all)
(defun sieve-remove (&optional _pos)
+ "Remove script at point."
(interactive)
(let ((name (sieve-script-at-point)) err)
(when (or (null name) (string-equal name sieve-new-script))
@@ -197,6 +200,7 @@ sieve-remove
(message "Removing sieve script %s...done" name)))
(defun sieve-edit-script (&optional _pos)
+ "Edit script at point."
(interactive)
(let ((name (sieve-script-at-point)))
(unless name
@@ -310,6 +314,7 @@ sieve-open-server
(sieve-manage-authenticate)))
(defun sieve-refresh-scriptlist ()
+ "Refresh list of scripts found the currently opened server."
(interactive)
(with-current-buffer sieve-buffer
(setq buffer-read-only nil)
@@ -356,6 +361,9 @@ sieve-manage
;;;###autoload
(defun sieve-upload (&optional name)
+ "Upload script NAME to currently opened server.
+If NAME is nil, detect it from script buffer name.
+If no open sieve buffer exists, call `sieve-manage' first."
(interactive)
(when (or (get-buffer sieve-buffer)
(save-current-buffer (call-interactively 'sieve-manage)))
@@ -374,12 +382,14 @@ sieve-upload
;;;###autoload
(defun sieve-upload-and-bury (&optional name)
+ "Upload script NAME and bury the current buffer."
(interactive)
(sieve-upload name)
(bury-buffer))
;;;###autoload
(defun sieve-upload-and-kill (&optional name)
+ "Upload script NAME and kill the current buffer."
(interactive)
(sieve-upload name)
(kill-buffer))
--
2.45.2
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0003-Bind-sieve-refresh-scriptlist-to-refresh-buffer.patch
From f65be55e92b720e2fb8b7f94c575aa2714a1e904 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= <bjorn.bidar@HIDDEN>
Date: Fri, 31 Jan 2025 03:24:44 +0200
Subject: [PATCH 3/3] Bind sieve-refresh-scriptlist to refresh buffer
* lisp/net/sieve.el (sieve-manage-mode-map):
Bind `sieve-refersh-scriptlist' to 'g' to refresh buffer.
(sieve-refresh-scriptlist): Highlight that the function updates
the current sieve buffer. (Bug#75956)
* etc/NEWS: Announce new keybinding
* doc/misc/siev.texi (Managing Sieve):
Document new keybinding and the existing `sieve-refresh-scriptlist`
function.
---
doc/misc/sieve.texi | 6 ++++++
etc/NEWS | 6 ++++++
lisp/net/sieve.el | 4 +++-
3 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/doc/misc/sieve.texi b/doc/misc/sieve.texi
index 5d4b3b369d7..deadc991173 100644
--- a/doc/misc/sieve.texi
+++ b/doc/misc/sieve.texi
@@ -213,6 +213,12 @@ Managing Sieve
@findex sieve-help
Displays help in the minibuffer.
+@item g
+@kindex g
+@findex sieve-refresh-scriptlist
+Refresh list of scripts found on the currently opened server.
+Update contents of the current sieve buffer.
+
@item Q
@kindex Q
@findex sieve-manage-quit
diff --git a/etc/NEWS b/etc/NEWS
index 2f04204ad94..fc40b07fa59 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -392,6 +392,12 @@ When called with a prefix argument, accepting, declining, or tentatively
accepting an icalendar event will prompt for a comment to add to the
response.
+** Sieve
++++
+*** New keybinding to refresh buffer in sieve-manage-mode
+'sieve-refresh-scriptlist' is now bound to 'g' to refresh the contents
+of the current sieve buffer.
+
** Button
+++
diff --git a/lisp/net/sieve.el b/lisp/net/sieve.el
index 5b4c2440266..7a5bdf02065 100644
--- a/lisp/net/sieve.el
+++ b/lisp/net/sieve.el
@@ -111,6 +111,7 @@ sieve-manage-mode-map
;; various
"?" #'sieve-help
"h" #'sieve-help
+ "g" #'sieve-refresh-scriptlist
;; activating
"m" #'sieve-activate
"u" #'sieve-deactivate
@@ -314,7 +315,8 @@ sieve-open-server
(sieve-manage-authenticate)))
(defun sieve-refresh-scriptlist ()
- "Refresh list of scripts found the currently opened server."
+ "Refresh list of scripts found the currently opened server.
+Update contents of the current sieve buffer."
(interactive)
(with-current-buffer sieve-buffer
(setq buffer-read-only nil)
--
2.45.2
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#75956; Package emacs.
Full text available.Received: (at 75956) by debbugs.gnu.org; 12 Feb 2025 18:47:44 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 12 13:47:44 2025 Received: from localhost ([127.0.0.1]:38259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tiHlw-0001oV-BB for submit <at> debbugs.gnu.org; Wed, 12 Feb 2025 13:47:44 -0500 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]:49646) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tiHlq-0001oB-1J for 75956 <at> debbugs.gnu.org; Wed, 12 Feb 2025 13:47:38 -0500 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5de5a853090so10160624a12.3 for <75956 <at> debbugs.gnu.org>; Wed, 12 Feb 2025 10:47:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739386052; x=1739990852; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=R6CdfXmfEekOSnK8Vvz3tl3tDSjeIbvVnKSwupYQoCk=; b=TdDJ9+AfH6oAlRCYiVCD0aTvcBxrdY0eSnC4VoLE+TzeACNnE1WAquU5JKa3fBcuRH 3I6lap7Ihbmy7Ghza7qzhyc+TkNGQTmkq7JZO/GyVWO9K9QNDLfkRyb98u1hvPi2Gt09 BQOWcLXOR8e7degaEM/p6KliHcHXjAX3rxLmd9XOS5vIDp1Hb2VmeMbBR5GaUQzLMlKn 5KIRrPabH9PflHhMFH8CEU8W7Fj1at8dnAyzkgZVMz/qMUbXSNO/LwjadRkjMZ0zIKEY e7aRFpgg+gmygeB+JWih8Jv4fd/G8SXHWndBKWT6fWyms65RkTMIqCsUHdRaM6swTtVR RAMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739386052; x=1739990852; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=R6CdfXmfEekOSnK8Vvz3tl3tDSjeIbvVnKSwupYQoCk=; b=DyDTZ/dSSvatrC7nLJqFw9WvntsH6kAThEgY7BIRQOohl776f75c0H2JC+AT9SqlNp qyOjcHE+1NNOPRy2sIZAK16IoigSboMx1VCy93CemzYFBR2G46poNBmZSjy2GY0Ym2Ks K9/+TsIGkaOQRVwx/mDFPSLokhIRDm4jXZ9RFQFEfuepZhWsssD7kJL9aGE2KCp2A4bf bukA99DPAd9LF+DSmBO88BsV8lap9ZcXf/RDnmZlOKxYm2I/HQorsvnT9TUhNzFSngaG mlyL88TAQWiZG5N5AKFgCkwLg8OTvkHR4jdZvaSRyj7rEO1DqMZf/Us53gBms9xlm6sE XitA== X-Gm-Message-State: AOJu0Ywb7gkhqwGcosF9O5mCRzhnzevdx31EgbQE1+OpQ5j0x1WzfAdH VbJZGzHvtIG21zd93M9A7Rx3kqOMxBOBOTxNxBS3dBOmIOW7t2NEVan0corWVn3sNgxyJqnZ21K X2mtZaDGnmD5WCqNoEH5MSf3vkI4= X-Gm-Gg: ASbGncvtZdBir2TuOKE+5vGzwELovZ6D3cQnC0wNYUJ8THALu15HuVRbqMiHYIX/uR8 HhYZW9gMSSIP7OVS7pY+0+kkyVsCFPwCPGus9/JV+mpVQnrvD6O7mAdGvVif/5pxjxZvfP6IYLA == X-Google-Smtp-Source: AGHT+IFMxTWR9PrIBOUuxiZc9lUh4ms4LvgBXtXgEvmIAd93v4L8znzfyHNxb6kCTlbgVwL+NgaQQ/ftzq4IOzdop1c= X-Received: by 2002:a05:6402:35c4:b0:5dc:7fbe:72ec with SMTP id 4fb4d7f45d1cf-5deadd7aee1mr3830695a12.2.1739386051605; Wed, 12 Feb 2025 10:47:31 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 12 Feb 2025 10:47:31 -0800 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <67ace50f.0c0a0220.85353.183cSMTPIN_ADDED_BROKEN@HIDDEN> References: <86ldug3gl9.fsf@HIDDEN> <67a78f54.050a0220.22ba7c.4eb4SMTPIN_ADDED_BROKEN@HIDDEN> <CADwFkm=UXFxi5gr9v6v_QY9Ys6kfMCFdi31xBRb3HD+UnCZ+sQ@HIDDEN> <67ab705c.df0a0220.1717fd.a7d7SMTPIN_ADDED_BROKEN@HIDDEN> <CADwFkmmui=nFmXXdjg_P56JcZmZ=VxQ_0_iAn0n=ew+aJCuLyA@HIDDEN> <67abacdb.500a0220.c5250.9942SMTPIN_ADDED_BROKEN@HIDDEN> <CADwFkmnhkm6X5PO-9Ea-RfkUqdEkhXCAfbn3kyNBn3V=jAmH1w@HIDDEN> <86zfiruzb4.fsf@HIDDEN> <67ace50f.0c0a0220.85353.183cSMTPIN_ADDED_BROKEN@HIDDEN> MIME-Version: 1.0 Date: Wed, 12 Feb 2025 10:47:31 -0800 X-Gm-Features: AWEUYZnAo5Q1ueyanJyGdpAVOp0u9SbTw_UDNvlIjMEUi6ZH1_JaGgAJGCUEMZk Message-ID: <CADwFkm=H8TQwpH9C8c2dQAHrQJGtiWQN48TAWojta_9v07cnbQ@HIDDEN> Subject: Re: bug#75956: Various improvements to sieve.el To: =?UTF-8?B?QmrDtnJuIEJpZGFy?= <bjorn.bidar@HIDDEN>, Eli Zaretskii <eliz@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75956 Cc: 75956 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Bj=C3=B6rn Bidar via "Bug reports for GNU Emacs, the Swiss army knife of te= xt editors" <bug-gnu-emacs@HIDDEN> writes: > Eli Zaretskii <eliz@HIDDEN> writes: > >>> From: Stefan Kangas <stefankangas@HIDDEN> >>> Date: Tue, 11 Feb 2025 12:09:16 -0800 >>> Cc: Eli Zaretskii <eliz@HIDDEN>, 75956 <at> debbugs.gnu.org >>> >>> Yeah, we have to be brief, which makes this hard. How about this: >>> >>> Server (optionally followed by `:port'): >>> >>> Eli, any better ideas? >> >> That's not bad. Another possibility: >> >> Server and port (SERVER[:PORT]): > > Which one is preferred? Personally I'm fine with either. I already > updated the patch with Stefan's suggestion. I think we can go with Eli's suggestion here. Users that want to understand things better should read the docstring.
bug-gnu-emacs@HIDDEN:bug#75956; Package emacs.
Full text available.Received: (at 75956) by debbugs.gnu.org; 12 Feb 2025 18:13:06 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 12 13:13:06 2025 Received: from localhost ([127.0.0.1]:38222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tiHEP-00009E-LF for submit <at> debbugs.gnu.org; Wed, 12 Feb 2025 13:13:05 -0500 Received: from thaodan.de ([2a03:4000:4f:f15::1]:59026) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <bjorn.bidar@HIDDEN>) id 1tiHEM-00008Y-AS for 75956 <at> debbugs.gnu.org; Wed, 12 Feb 2025 13:13:03 -0500 Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49]) by thaodan.de (Postfix) with ESMTPSA id 685C1D00055; Wed, 12 Feb 2025 20:12:55 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1739383975; bh=oMHsske364hSqhNjwb7q0pwfCoV1qbryh+OtC/wKtRU=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=ui8kcP7RQkcgjb7hen7Q8guhnbzIzl/odvho/WxCuCSsO5ClwaoLjc0wF7JmAl+Iw Nc+vdg1SnD5RjY68SOHBq+4kZMFWjoLFoHoSjCk5z/lC10eTLWeR1MLUF1ePfBCr63 JT1TmY4tEOVqpYGExMKPegGI5DbiQdqUothjs5yWXeRcPbBa4Wg8pOQkgwRxfSSzwu 8px0wmnEu5Lg3sVayvnwHfqHJegrPtP0rEjrwlaVJYgoXfFdKDticj5tRzzSxYegRI ZRsFwFwF/qqEPGQtpj4fmun5NPKkmYJ0mqoD1wnP7cqlGDlOLvwNWR+LPYbFv57eaP h+Cidkf4UdGrcaSHpwop27oYvyhyVr0FZK9xJnYJvxI94YaNJdeSbGhlrbkS4wuFnE hdQ+XqYAmwGuzJXhuxA/8JxaCIOCsYGD6yX4dApqFdf1woG535TYNDe02D5PJZg5jI FCBSu1xTczQV6U6HkdwPlACwlyUUJlTTEHdfgWfA7qRQAWkwSwzh+b3UyxKWXICDJ2 bmPmSxe1+STTBthr7/TSBreTH510n5poZ0qqKIH08aHrbYhb1f1yUYZb3N7XCI7gcW bIf1z/U1dbek+AQUPO6HYrbpmL+0lPRJUHg956CTy2400tDxKEWIw/4QFO7xQMdq9r VOMiwLzzU+xbdhEk8p/BDOnM= From: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#75956: Various improvements to sieve.el In-Reply-To: <86zfiruzb4.fsf@HIDDEN> (Eli Zaretskii's message of "Wed, 12 Feb 2025 14:23:27 +0200") References: <86ldug3gl9.fsf@HIDDEN> <67a78f54.050a0220.22ba7c.4eb4SMTPIN_ADDED_BROKEN@HIDDEN> <CADwFkm=UXFxi5gr9v6v_QY9Ys6kfMCFdi31xBRb3HD+UnCZ+sQ@HIDDEN> <67ab705c.df0a0220.1717fd.a7d7SMTPIN_ADDED_BROKEN@HIDDEN> <CADwFkmmui=nFmXXdjg_P56JcZmZ=VxQ_0_iAn0n=ew+aJCuLyA@HIDDEN> <67abacdb.500a0220.c5250.9942SMTPIN_ADDED_BROKEN@HIDDEN> <CADwFkmnhkm6X5PO-9Ea-RfkUqdEkhXCAfbn3kyNBn3V=jAmH1w@HIDDEN> <86zfiruzb4.fsf@HIDDEN> Autocrypt: addr=bjorn.bidar@HIDDEN; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA== Date: Wed, 12 Feb 2025 20:12:53 +0200 Message-ID: <87ldubf2vu.fsf@> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Eli Zaretskii <eliz@HIDDEN> writes: >> From: Stefan Kangas <stefankangas@HIDDEN> >> Date: Tue, 11 Feb 2025 12:09:16 -0800 >> Cc: Eli Zaretskii <eliz@HIDDEN>, 75956 <at> debbugs.gnu.org >> >> Yeah, we have to be brief, which makes this ha [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822 X-Debbugs-Envelope-To: 75956 Cc: 75956 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.2 (/) Eli Zaretskii <eliz@HIDDEN> writes: >> From: Stefan Kangas <stefankangas@HIDDEN> >> Date: Tue, 11 Feb 2025 12:09:16 -0800 >> Cc: Eli Zaretskii <eliz@HIDDEN>, 75956 <at> debbugs.gnu.org >> >> Yeah, we have to be brief, which makes this hard. How about this: >> >> Server (optionally followed by `:port'): >> >> Eli, any better ideas? > > That's not bad. Another possibility: > > Server and port (SERVER[:PORT]): Which one is preferred? Personally I'm fine with either. I already updated the patch with Stefan's suggestion.
bug-gnu-emacs@HIDDEN:bug#75956; Package emacs.
Full text available.Received: (at 75956) by debbugs.gnu.org; 12 Feb 2025 12:23:58 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 12 07:23:58 2025 Received: from localhost ([127.0.0.1]:33073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tiBmY-0005eO-30 for submit <at> debbugs.gnu.org; Wed, 12 Feb 2025 07:23:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34232) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tiBmV-0005e6-Td for 75956 <at> debbugs.gnu.org; Wed, 12 Feb 2025 07:23:56 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tiBmP-00041z-HB; Wed, 12 Feb 2025 07:23:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=j+A4cN+EbSRIJ6uQHA4SLrmJIRoWq618f62Is38Rl0Y=; b=Hid/FSjzhK43 7Kf92uDo9X7sPlouQ2KbG2kEluM4MlLQy9PyOGGxJGA/8tU4Y+Hkk2odZI9zQKLwhk+K2hBscC0Mi fba0Px9Aya/bnCAg1I3WuZBI9l6ApWCivfY0gL1Pkch++2X4n65cM5ai3D8n7GRrd5XGygzyKa4yh hh9jEN72142NvuyhZAVjfbT42tG6Yb4AkqSiGz3YY3CsN/XADweZVg+dFDsmNSfNAu2RZ6n8G+sya nOh+InghzPkkNkL8UAiCcMxRaKD6326E96QdnCsUp/3zCmbD/e/bTbTWfq8N4EUKXVwePtM3gIxO2 AHoC55Kwy2MwgJGz/yBPqw==; Date: Wed, 12 Feb 2025 14:23:27 +0200 Message-Id: <86zfiruzb4.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <CADwFkmnhkm6X5PO-9Ea-RfkUqdEkhXCAfbn3kyNBn3V=jAmH1w@HIDDEN> (message from Stefan Kangas on Tue, 11 Feb 2025 12:09:16 -0800) Subject: Re: bug#75956: Various improvements to sieve.el References: <86ldug3gl9.fsf@HIDDEN> <67a78f54.050a0220.22ba7c.4eb4SMTPIN_ADDED_BROKEN@HIDDEN> <CADwFkm=UXFxi5gr9v6v_QY9Ys6kfMCFdi31xBRb3HD+UnCZ+sQ@HIDDEN> <67ab705c.df0a0220.1717fd.a7d7SMTPIN_ADDED_BROKEN@HIDDEN> <CADwFkmmui=nFmXXdjg_P56JcZmZ=VxQ_0_iAn0n=ew+aJCuLyA@HIDDEN> <67abacdb.500a0220.c5250.9942SMTPIN_ADDED_BROKEN@HIDDEN> <CADwFkmnhkm6X5PO-9Ea-RfkUqdEkhXCAfbn3kyNBn3V=jAmH1w@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75956 Cc: bjorn.bidar@HIDDEN, 75956 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Stefan Kangas <stefankangas@HIDDEN> > Date: Tue, 11 Feb 2025 12:09:16 -0800 > Cc: Eli Zaretskii <eliz@HIDDEN>, 75956 <at> debbugs.gnu.org > > Yeah, we have to be brief, which makes this hard. How about this: > > Server (optionally followed by `:port'): > > Eli, any better ideas? That's not bad. Another possibility: Server and port (SERVER[:PORT]):
bug-gnu-emacs@HIDDEN:bug#75956; Package emacs.
Full text available.Received: (at 75956) by debbugs.gnu.org; 11 Feb 2025 21:58:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 11 16:58:21 2025
Received: from localhost ([127.0.0.1]:59197 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1thyGq-0004Co-91
for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 16:58:20 -0500
Received: from thaodan.de ([185.216.177.71]:47950)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <bjorn.bidar@HIDDEN>)
id 1thyGm-0004CT-Vi
for 75956 <at> debbugs.gnu.org; Tue, 11 Feb 2025 16:58:17 -0500
Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49])
by thaodan.de (Postfix) with ESMTPSA id AC86CD00063;
Tue, 11 Feb 2025 23:58:10 +0200 (EET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail;
t=1739311090; bh=HFts5i2G7l+cf60qBoUQz9wJzLcn6bMZGcUffNXbTbw=;
h=From:To:Cc:Subject:In-Reply-To:References:Date;
b=zdA35elAXSAbxTfFUBz0uWT4vWVQ9pb0zZGLjtwP3V87uZwJvHqes5Yvp3nNVLT+8
8jx91boJNLuJAIlC90+pj42XCFtRRcw0fvZG67wgylTDly28eVFxVKxS1KTWQ71pTO
3n4uYe7YYbwyHKGjIUcEk3HBVs338Xub444KHXyT9/T70CIsPXSCVV6bd/hpFccmXj
yuaXBQ3QIcdhNdYq0L+ZPyIQ0KfLWzf8IAHxB0CRvmYYMXaIrf78LpwbOk+0jUe0al
FOARPKmfhvIAVWirWd8oQTKzCHXmcR91yHixXdskqs0+Vw68r/1RZEBYk2ri68ipPF
c2s8os4oKShOtGTQQVnLPuhOiarwNAwktMQzmeuUePP9b582xqYZMFDVnrORJq3I2x
5EVEKfvw4L0OWYOchWMEh/SC1uPGXMENj6H1S58daBj7GIKg48Gu7ZHfcVAiJQXb9a
qng9qluxghMgZGex66Ct7q3joLoj1KqDzxkwV72+bawsEcuX9GAzvtdWcZ3o5Amlkr
0r42IcURKgF6Mc4v8oeZFoTzGi1E1Mk0z/p49ZnWOTptFpXwxrtkQU5WY6h0DGcdU1
z+/0EN9RkTqtcz9RXPnV4aRyK0bxtf9uFpoZBuSKHEFqMslFNkEvzrsJ1oLqRH0fPZ
OPvVtm+9/AQG87FAdF23v+ZQ=
From: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN>
To: Stefan Kangas <stefankangas@HIDDEN>
Subject: Re: bug#75956: Various improvements to sieve.el
In-Reply-To: <CADwFkmnhkm6X5PO-9Ea-RfkUqdEkhXCAfbn3kyNBn3V=jAmH1w@HIDDEN>
(Stefan Kangas's message of "Tue, 11 Feb 2025 12:09:16 -0800")
References: <86ldug3gl9.fsf@HIDDEN>
<67a78f54.050a0220.22ba7c.4eb4SMTPIN_ADDED_BROKEN@HIDDEN>
<CADwFkm=UXFxi5gr9v6v_QY9Ys6kfMCFdi31xBRb3HD+UnCZ+sQ@HIDDEN>
<67ab705c.df0a0220.1717fd.a7d7SMTPIN_ADDED_BROKEN@HIDDEN>
<CADwFkmmui=nFmXXdjg_P56JcZmZ=VxQ_0_iAn0n=ew+aJCuLyA@HIDDEN>
<67abacdb.500a0220.c5250.9942SMTPIN_ADDED_BROKEN@HIDDEN>
<CADwFkmnhkm6X5PO-9Ea-RfkUqdEkhXCAfbn3kyNBn3V=jAmH1w@HIDDEN>
Autocrypt: addr=bjorn.bidar@HIDDEN; prefer-encrypt=nopreference; keydata=
mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq
w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV
CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl
HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8
phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF
CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h
K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2
cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC
HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN
XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg
gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL
AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E
TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB
B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe
pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO
HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG
AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr
dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n
KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy
GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK
S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA==
Date: Tue, 11 Feb 2025 23:58:09 +0200
Message-ID: <87r044f8jy.fsf@>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Stefan Kangas <stefankangas@HIDDEN> writes: > Björn Bidar
<bjorn.bidar@HIDDEN> writes: > >> Stefan Kangas <stefankangas@HIDDEN>
writes: >> >>>> A compromise would be to mention in the prompt that the port
can be >>>> specified in the pr [...]
Content analysis details: (1.2 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The
query to Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243
for more information.
[185.216.177.71 listed in sa-trusted.bondedsender.org]
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The
query to Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243
for more information.
[185.216.177.71 listed in bl.score.senderscore.com]
1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822
X-Debbugs-Envelope-To: 75956
Cc: Eli Zaretskii <eliz@HIDDEN>, 75956 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Stefan Kangas <stefankangas@HIDDEN> writes:
> Bj=C3=B6rn Bidar <bjorn.bidar@HIDDEN> writes:
>
>> Stefan Kangas <stefankangas@HIDDEN> writes:
>>
>>>> A compromise would be to mention in the prompt that the port can be
>>>> specified in the prompt.
>>>
>>> OK, then let's do that.
>>
>> What did you have in mind? For example for man pages the optional argume=
nts
>> it is custom to put optional arguments in [].
>> Going with that the prompt could look like that: 'Server[:port] : '.
>
> Yeah, we have to be brief, which makes this hard. How about this:
>
> Server (optionally followed by `:port'):
OK changed the prompt to look like this. Regarding the bug reference
again.
When the patch touches multiple files should the reference go to the
first change only?
Anyway here the updated patches.
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0001-lisp-net-sieve.el-Read-port-in-sieve-manage-when-int.patch
From 1291a3f4467df1a6bdb0be6500b0f44f2c6dd731 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= <bjorn.bidar@HIDDEN>
Date: Fri, 31 Jan 2025 02:34:19 +0200
Subject: [PATCH 1/3] * lisp/net/sieve.el: Read port in sieve-manage when
interactive
(sieve-manage): Optionally read port when called interactively.
Add previously missing documentation string. (Bug#75956)
---
lisp/net/sieve.el | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/lisp/net/sieve.el b/lisp/net/sieve.el
index f9f036e1589..6b40e1e6af7 100644
--- a/lisp/net/sieve.el
+++ b/lisp/net/sieve.el
@@ -338,7 +338,15 @@ sieve-refresh-scriptlist
;;;###autoload
(defun sieve-manage (server &optional port)
- (interactive "sServer: ")
+ "Open ManageSieve SERVER.
+Optionally argument PORT specifies the port use;
+otherwise it defaults to `sieve-manage-default-port'.
+
+When called interactively, prompt for SERVER:PORT
+if :PORT is not specified fall back to `sieve-manage-default-port'."
+ (interactive
+ (split-string (read-string
+ "Server (optionally followed by `:port'): ") ":"))
(switch-to-buffer (get-buffer-create sieve-buffer))
(sieve-manage-mode)
(sieve-setup-buffer server port)
--
2.45.2
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0002-lisp-net-sieve.el-Add-missing-documentation-strings.patch
From 401586830b3bb64de4bbdfcf6e4fe0fc48be8c27 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= <bjorn.bidar@HIDDEN>
Date: Fri, 31 Jan 2025 02:53:34 +0200
Subject: [PATCH 2/3] * lisp/net/sieve.el: Add missing documentation strings
(sieve-activate, sieve-deactivate-all, sieve-remove)
(sieve-edit-script, sieve-refersh-scriptlist)
(sieve-upload, sieve-upload-and-burry)
(sieve-upload-and-kill): Add documentation strings (Bug#75956)
---
lisp/net/sieve.el | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/lisp/net/sieve.el b/lisp/net/sieve.el
index 6b40e1e6af7..8feb1c0bdbd 100644
--- a/lisp/net/sieve.el
+++ b/lisp/net/sieve.el
@@ -161,6 +161,7 @@ sieve-bury-buffer
(bury-buffer))
(defun sieve-activate (&optional _pos)
+ "Activate script at point."
(interactive)
(let ((name (sieve-script-at-point)) err)
(when (or (null name) (string-equal name sieve-new-script))
@@ -173,6 +174,7 @@ sieve-activate
(message "Activating script %s...failed: %s" name (nth 2 err)))))
(defun sieve-deactivate-all (&optional _pos)
+ "Deactivate all currently active scripts."
(interactive)
(message "Deactivating scripts...")
(let (;; (name (sieve-script-at-point))
@@ -185,6 +187,7 @@ sieve-deactivate-all
(defalias 'sieve-deactivate #'sieve-deactivate-all)
(defun sieve-remove (&optional _pos)
+ "Remove script at point."
(interactive)
(let ((name (sieve-script-at-point)) err)
(when (or (null name) (string-equal name sieve-new-script))
@@ -197,6 +200,7 @@ sieve-remove
(message "Removing sieve script %s...done" name)))
(defun sieve-edit-script (&optional _pos)
+ "Edit script at point."
(interactive)
(let ((name (sieve-script-at-point)))
(unless name
@@ -310,6 +314,7 @@ sieve-open-server
(sieve-manage-authenticate)))
(defun sieve-refresh-scriptlist ()
+ "Refresh list of scripts found the currently opened server."
(interactive)
(with-current-buffer sieve-buffer
(setq buffer-read-only nil)
@@ -356,6 +361,9 @@ sieve-manage
;;;###autoload
(defun sieve-upload (&optional name)
+ "Upload script NAME to currently opened server.
+If NAME is nil, detect it from script buffer name.
+If no open sieve buffer exists, call `sieve-manage' first."
(interactive)
(when (or (get-buffer sieve-buffer)
(save-current-buffer (call-interactively 'sieve-manage)))
@@ -374,12 +382,14 @@ sieve-upload
;;;###autoload
(defun sieve-upload-and-bury (&optional name)
+ "Upload script NAME and bury the current buffer."
(interactive)
(sieve-upload name)
(bury-buffer))
;;;###autoload
(defun sieve-upload-and-kill (&optional name)
+ "Upload script NAME and kill the current buffer."
(interactive)
(sieve-upload name)
(kill-buffer))
--
2.45.2
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0003-Bind-sieve-refresh-scriptlist-to-refresh-buffer.patch
From abe3024fd1019de535b7643e0637b2aaffcca675 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= <bjorn.bidar@HIDDEN>
Date: Fri, 31 Jan 2025 03:24:44 +0200
Subject: [PATCH 3/3] Bind sieve-refresh-scriptlist to refresh buffer
* lisp/net/sieve.el (sieve-manage-mode-map):
Bind `sieve-refersh-scriptlist' to 'g' to refresh buffer.
(sieve-refresh-scriptlist): Highlight that the function updates
the current sieve buffer. (Bug#75956)
* etc/NEWS: Announce new keybinding
* doc/misc/siev.texi (Managing Sieve):
Document new keybinding and the existing `sieve-refresh-scriptlist`
function.
---
doc/misc/sieve.texi | 6 ++++++
etc/NEWS | 6 ++++++
lisp/net/sieve.el | 4 +++-
3 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/doc/misc/sieve.texi b/doc/misc/sieve.texi
index 5d4b3b369d7..deadc991173 100644
--- a/doc/misc/sieve.texi
+++ b/doc/misc/sieve.texi
@@ -213,6 +213,12 @@ Managing Sieve
@findex sieve-help
Displays help in the minibuffer.
+@item g
+@kindex g
+@findex sieve-refresh-scriptlist
+Refresh list of scripts found on the currently opened server.
+Update contents of the current sieve buffer.
+
@item Q
@kindex Q
@findex sieve-manage-quit
diff --git a/etc/NEWS b/etc/NEWS
index 2f04204ad94..fc40b07fa59 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -392,6 +392,12 @@ When called with a prefix argument, accepting, declining, or tentatively
accepting an icalendar event will prompt for a comment to add to the
response.
+** Sieve
++++
+*** New keybinding to refresh buffer in sieve-manage-mode
+'sieve-refresh-scriptlist' is now bound to 'g' to refresh the contents
+of the current sieve buffer.
+
** Button
+++
diff --git a/lisp/net/sieve.el b/lisp/net/sieve.el
index 8feb1c0bdbd..0ee95599d3e 100644
--- a/lisp/net/sieve.el
+++ b/lisp/net/sieve.el
@@ -111,6 +111,7 @@ sieve-manage-mode-map
;; various
"?" #'sieve-help
"h" #'sieve-help
+ "g" #'sieve-refresh-scriptlist
;; activating
"m" #'sieve-activate
"u" #'sieve-deactivate
@@ -314,7 +315,8 @@ sieve-open-server
(sieve-manage-authenticate)))
(defun sieve-refresh-scriptlist ()
- "Refresh list of scripts found the currently opened server."
+ "Refresh list of scripts found the currently opened server.
+Update contents of the current sieve buffer."
(interactive)
(with-current-buffer sieve-buffer
(setq buffer-read-only nil)
--
2.45.2
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#75956; Package emacs.
Full text available.Received: (at 75956) by debbugs.gnu.org; 11 Feb 2025 20:09:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 11 15:09:27 2025
Received: from localhost ([127.0.0.1]:58931 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1thwZS-0006hY-QY
for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 15:09:27 -0500
Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:47336)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
id 1thwZQ-0006hH-IQ
for 75956 <at> debbugs.gnu.org; Tue, 11 Feb 2025 15:09:25 -0500
Received: by mail-ed1-x52a.google.com with SMTP id
4fb4d7f45d1cf-5de4a8b4f86so7096987a12.2
for <75956 <at> debbugs.gnu.org>; Tue, 11 Feb 2025 12:09:24 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1739304558; x=1739909358; darn=debbugs.gnu.org;
h=content-transfer-encoding:cc:to:subject:message-id:date
:mime-version:references:in-reply-to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=KlNsPtz0QuYtN9TSXSR6sNqsHW48hAAP+N3X607IHe0=;
b=bWo/aDK8FYn+7rZ0n/edKpos+dwATpXLJaATpGQTsnNDm/XcFtQ8/9+C7IffCKsbCR
+6/2ezLz7S3x/+cBhtNjUcq53bVVDxbi10Y7vm66is5zzL6RI/aIvxWq7UkudGLZwUb8
BmYQYfWO6Taka7fgmfHDZCFlGL2ZDLC3QC6m8HP5oeVh5yP8nuBC8y+nEtGhmhEh149n
o25TgAzyYFilXQ9X9GvOYwdCDhoefli97GfeTJ2UUkmb5wr7LdUoTNg1wGhmyHK3AoNc
M7ks06EUMIPvQCeXZpfW6O4iRg3u+HCYL/GxN8xBZQGZOYwyHfE/MMDZUn1NxJ3sPF/D
FZMQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1739304558; x=1739909358;
h=content-transfer-encoding:cc:to:subject:message-id:date
:mime-version:references:in-reply-to:from:x-gm-message-state:from:to
:cc:subject:date:message-id:reply-to;
bh=KlNsPtz0QuYtN9TSXSR6sNqsHW48hAAP+N3X607IHe0=;
b=wUdhkXNG6EF1D8BGANiOyFngBYO4pDJzSCLkE5R8Dj13ElNbUDxbbVuencO5/lvt8u
AkIFTJ2mydpEEJpoU9vCLPBXQE2OlBwUUmQ9P1hDqEZee0LFTMSP8Jr3o6m5blSOLXFy
bw40lX9Y+P+x1BXJSsHItr2BA8TENR6GJUKUnpe+sTHIFHZEbkeMKNDQqrUZkC39VwNP
8Oz3ICU9/32gIDIqND3TUi9LgSdbbYha2QSJ5eczPwqe7sBNzYdxhFRi6hiGwgKjYviV
m1FCS9CjxQ7A82sbjnd6SM6rq8gSHyaA+swF6iqN3PsEV8OgolgELx48D7RuQ6Sgng8l
TK6A==
X-Forwarded-Encrypted: i=1;
AJvYcCU5s7ZqzoAH1JW3tsSpYbuXPsmdUpIbwjfq7N//faDZC25uEUDD/nBluqsDS+lwtazyByZ9GQ==@debbugs.gnu.org
X-Gm-Message-State: AOJu0Yxr6vOvYcwCTgdfNtinfmESmTOjeiGbRSsYsri2/WTXgU2wj0g9
lyqLBiQtUgjkr124W4zUt/XU4Ad/ichG9LqQuN5IQxT1JfH/kszbxeWcppBdAkPQtFylO0r4w+b
LCRWX7UVxteO2Df/dkaak/Uqr1P0=
X-Gm-Gg: ASbGnctWIYSUTHhlR7Z3/2evuMd8HMejlcbkPSrItAyPUXiDbJClbHTmsA66lwmcwfO
ZbEWh57G8wXrxveoICjvnPF7GZ8hDiRJ0L8p1g85y4L+VHZDdwkXy+LDpYMu6caYqoeeIURAu+g
==
X-Google-Smtp-Source: AGHT+IFAGBduAcnrWsT5q3KO2NthzRlXtVEG5T4numLGFDOHNtsuv+w0WmGduy+C0pv7YkWgWWJ0AUzgVUxMMH/f2BE=
X-Received: by 2002:a05:6402:5250:b0:5db:f423:19b9 with SMTP id
4fb4d7f45d1cf-5deadda8aa8mr463726a12.16.1739304558298; Tue, 11 Feb 2025
12:09:18 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
HTTPREST; Tue, 11 Feb 2025 12:09:16 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <67abacdb.500a0220.c5250.9942SMTPIN_ADDED_BROKEN@HIDDEN>
References: <86ldug3gl9.fsf@HIDDEN>
<67a78f54.050a0220.22ba7c.4eb4SMTPIN_ADDED_BROKEN@HIDDEN>
<CADwFkm=UXFxi5gr9v6v_QY9Ys6kfMCFdi31xBRb3HD+UnCZ+sQ@HIDDEN>
<67ab705c.df0a0220.1717fd.a7d7SMTPIN_ADDED_BROKEN@HIDDEN>
<CADwFkmmui=nFmXXdjg_P56JcZmZ=VxQ_0_iAn0n=ew+aJCuLyA@HIDDEN>
<67abacdb.500a0220.c5250.9942SMTPIN_ADDED_BROKEN@HIDDEN>
MIME-Version: 1.0
Date: Tue, 11 Feb 2025 12:09:16 -0800
X-Gm-Features: AWEUYZm9Sw9HpGLQ9xxGrVOpXdVc8IFvXeSIp-dswX9iygnvegdmuuO4IEm2Ris
Message-ID: <CADwFkmnhkm6X5PO-9Ea-RfkUqdEkhXCAfbn3kyNBn3V=jAmH1w@HIDDEN>
Subject: Re: bug#75956: Various improvements to sieve.el
To: =?UTF-8?B?QmrDtnJuIEJpZGFy?= <bjorn.bidar@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75956
Cc: Eli Zaretskii <eliz@HIDDEN>, 75956 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Bj=C3=B6rn Bidar <bjorn.bidar@HIDDEN> writes:
> Stefan Kangas <stefankangas@HIDDEN> writes:
>
>>> A compromise would be to mention in the prompt that the port can be
>>> specified in the prompt.
>>
>> OK, then let's do that.
>
> What did you have in mind? For example for man pages the optional argumen=
ts
> it is custom to put optional arguments in [].
> Going with that the prompt could look like that: 'Server[:port] : '.
Yeah, we have to be brief, which makes this hard. How about this:
Server (optionally followed by `:port'):
Eli, any better ideas?
bug-gnu-emacs@HIDDEN:bug#75956; Package emacs.
Full text available.Received: (at 75956) by debbugs.gnu.org; 11 Feb 2025 20:02:43 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 11 15:02:43 2025 Received: from localhost ([127.0.0.1]:58900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thwSx-0006Od-CI for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 15:02:43 -0500 Received: from thaodan.de ([2a03:4000:4f:f15::1]:52436) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <bjorn.bidar@HIDDEN>) id 1thwSv-0006OM-64 for 75956 <at> debbugs.gnu.org; Tue, 11 Feb 2025 15:02:41 -0500 Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49]) by thaodan.de (Postfix) with ESMTPSA id 329D0D00045; Tue, 11 Feb 2025 22:02:35 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1739304155; bh=wHnUfpOpmmPn9LyJUasUzzAW7fsTFLINFcihtHAThvk=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=Aj4AWeuYdKCBLH/cGWIkNe1ToPSvIiiRwfXIqrNTgzz0yjAecRyTLArzMIenvPFn6 EbZz6WoK5o+TzC6fHvxqRU6J/+rdM6Od1A6LrenyZbqK3JIOoglEOY57qtn5UdM0ei hdnHhAyTmZxnS/yAPe9rD3AmKyvN5ZYF5okbKfH1dATleud7Hfw9q6qxBFFNsJkNiw h2D6S4SgDTj+xEXJQtG2RsgPxf0Vm4iSNLrU5FyL8gBCVe6uAYwmWZQRGZR6CEg/FY UIH17t1Szm/ckmMhL2OPWgTtLJUfOxYJax1uFPeB7h412aIcoUWZdJrfUb3HHdysqx g5/KZQIyj0paGV3nrccp8FTgXU28C9Zq+FCp/VHaiTjWdlmcQikKKLF57+WRx1DN1v y6R/rX+4mj9u3JRIgw7sJfnOhJRIAzY4hMQhvg3dZfPyttd9L6LzrYpaiICkn15ZBo 4JghqvIMP+XdFmxa1evaTSg/BN7QzGwJZkgcxgO8828WXlmJnHJPwMnPTn9qIYgMpn RO3DU9VG46Zm9oeWaiFrye/vKdHjL+YcWx8wUP0lhNjgEXiyVzg+rPCkFCv2EPVKPJ /XwREZKTgJS6FLjyR2xa0HvMQZxPWTd9YIS1aX7DrrsehWg09DlQJYo+6cdbvXNQvB cs1PWklCd5yHcG9ORUkTtnGI= From: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN> To: Stefan Kangas <stefankangas@HIDDEN> Subject: Re: bug#75956: Various improvements to sieve.el In-Reply-To: <CADwFkmmui=nFmXXdjg_P56JcZmZ=VxQ_0_iAn0n=ew+aJCuLyA@HIDDEN> (Stefan Kangas's message of "Tue, 11 Feb 2025 08:25:15 -0800") References: <86ldug3gl9.fsf@HIDDEN> <67a78f54.050a0220.22ba7c.4eb4SMTPIN_ADDED_BROKEN@HIDDEN> <CADwFkm=UXFxi5gr9v6v_QY9Ys6kfMCFdi31xBRb3HD+UnCZ+sQ@HIDDEN> <67ab705c.df0a0220.1717fd.a7d7SMTPIN_ADDED_BROKEN@HIDDEN> <CADwFkmmui=nFmXXdjg_P56JcZmZ=VxQ_0_iAn0n=ew+aJCuLyA@HIDDEN> Autocrypt: addr=bjorn.bidar@HIDDEN; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA== Date: Tue, 11 Feb 2025 22:02:34 +0200 Message-ID: <871pw4i71h.fsf@> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Stefan Kangas <stefankangas@HIDDEN> writes: >> A compromise would be to mention in the prompt that the port can be >> specified in the prompt. > > OK, then let's do that. What did you have in mind? For example for man pages the optional arguments it is custom to put optional arguments in []. Going with that the prompt could look like that: 'Server[:port] : '. Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822 X-Debbugs-Envelope-To: 75956 Cc: Eli Zaretskii <eliz@HIDDEN>, 75956 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.2 (/) Stefan Kangas <stefankangas@HIDDEN> writes: >> A compromise would be to mention in the prompt that the port can be >> specified in the prompt. > > OK, then let's do that. What did you have in mind? For example for man pages the optional arguments it is custom to put optional arguments in []. Going with that the prompt could look like that: 'Server[:port] : '.
bug-gnu-emacs@HIDDEN:bug#75956; Package emacs.
Full text available.Received: (at 75956) by debbugs.gnu.org; 11 Feb 2025 16:25:26 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 11 11:25:26 2025 Received: from localhost ([127.0.0.1]:58247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tht4g-0000oF-Av for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 11:25:26 -0500 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]:58771) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tht4c-0000nx-Gd for 75956 <at> debbugs.gnu.org; Tue, 11 Feb 2025 11:25:23 -0500 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-ab2b29dfc65so882525066b.1 for <75956 <at> debbugs.gnu.org>; Tue, 11 Feb 2025 08:25:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739291116; x=1739895916; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=t0NesMiTivB1zcchZhmcHKdPbhcle/wbYXuOYpIaz34=; b=aV4egp+pQcq2paLfAg3LT7F/RMOrHCDKNNeX0BteDWt548C1IBghptDBvsxigduwYf 4J5iTFKHG8a9wvnjtfmJ5TQS6CH9ciZERuzM5EZeYj3gwxzKNAu9g/2xl2nd+GkJJEXb H5eeXiJJJtuiNT6bBE/Rs4g7la/S7irtP6FKb75TJ+z/SBLlvPJlMfDtigmhguArMFUO tsxH/fj8vpwNPhK2o+eU0LRS1igJCto1AmEh8o/ky/yaGq2o0ZxY6kvJYBohmj8uPPZH wrrWOOZT0zjw1/MX6/66sjpJlHaF52lK0rGigdGAnJ1+wCXjxuWB1180t0MOhxV6hlo5 NFeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739291116; x=1739895916; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=t0NesMiTivB1zcchZhmcHKdPbhcle/wbYXuOYpIaz34=; b=MwMil0Tf8z2YbpGti6c7LW45EOK3iUyJVjQdKlkv1P2Go0VWU/vm+T4NKO9Mx4Dfon mUyJnX34EJtQ/MFgz7kpYrJeu5SVRWBefn9GPZKbuPrNQK1lYl3Yn2X+PNdOFsQdDiiO NcV4L8NC36F3ejZRA51bkaPJdUh8Ub3KowotBcOWxd2M4bHhPYq4Gnt3UZG9ZarXlp/5 31Q5WsJS8CEgzXcgkxeO/X8d6GH22GKscE7Q8U2iZAz9saTBXaA1qaCiHn/3SXfFJStF WD6ixIio0K3v5V4S77fQl07j8qLr4QdL81rYNHEpISgMMtFcHBgzzfVddl231kjJLPMc rzVQ== X-Forwarded-Encrypted: i=1; AJvYcCUY88bRHyiZFXAn+7VIjs51apwKNJWPdcD2/jXjvGWFBvRzWEknTHKA3itL6HnnHbDKV/HNfg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxCXyEE8j4XzR3PAKvFlpDnLgZHNaNdjbEJzGQ8aM0j+MiR5fZS fm1IMhuVgp+IshXBlLpFWga+QiYploCit4O0eqAvtRkfPRENQ3je5D3MskkZPVCd4SvW5ipTOnp 55k+mpbQCJTmvXS3CezrR1y+0UqS+/e/j X-Gm-Gg: ASbGncvfnT8zPzocnmBR20WrRZnlzbnWOMQcb5fqrW6uLr2BeaxhQ4iSRY7kD9wWisd /1lZBdA3WtsU+T7YPf2zPdvjQj+np8HUlVWYzs+eYTHm51eczlVfMhg2zjXlyxm0qowBs+m7Mlx E= X-Google-Smtp-Source: AGHT+IFoH7JN02cImxo1h12OPHfNsdoQKyBNflylqvKDd/2iHU/MwkiJ4pbcQsVi5E7fQaGRI2ng5Hm0EoU4fKKxmYU= X-Received: by 2002:a17:906:ef0b:b0:ab2:d8e7:682c with SMTP id a640c23a62f3a-ab789c630c2mr2165199466b.38.1739291116167; Tue, 11 Feb 2025 08:25:16 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 11 Feb 2025 08:25:15 -0800 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <67ab705c.df0a0220.1717fd.a7d7SMTPIN_ADDED_BROKEN@HIDDEN> References: <86ldug3gl9.fsf@HIDDEN> <67a78f54.050a0220.22ba7c.4eb4SMTPIN_ADDED_BROKEN@HIDDEN> <CADwFkm=UXFxi5gr9v6v_QY9Ys6kfMCFdi31xBRb3HD+UnCZ+sQ@HIDDEN> <67ab705c.df0a0220.1717fd.a7d7SMTPIN_ADDED_BROKEN@HIDDEN> MIME-Version: 1.0 Date: Tue, 11 Feb 2025 08:25:15 -0800 X-Gm-Features: AWEUYZnl0nrJ_VxQBwwOTYk-5XBcAnO0J8RUp1yDwCHs1hqH7RYF2ZXGQMVXryA Message-ID: <CADwFkmmui=nFmXXdjg_P56JcZmZ=VxQ_0_iAn0n=ew+aJCuLyA@HIDDEN> Subject: Re: bug#75956: Various improvements to sieve.el To: =?UTF-8?B?QmrDtnJuIEJpZGFy?= <bjorn.bidar@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75956 Cc: Eli Zaretskii <eliz@HIDDEN>, 75956 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Bj=C3=B6rn Bidar <bjorn.bidar@HIDDEN> writes: > A compromise would be to mention in the prompt that the port can be > specified in the prompt. OK, then let's do that.
bug-gnu-emacs@HIDDEN:bug#75956; Package emacs.
Full text available.Received: (at 75956) by debbugs.gnu.org; 11 Feb 2025 15:44:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 11 10:44:39 2025
Received: from localhost ([127.0.0.1]:58126 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1thsRD-0007F0-0e
for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 10:44:39 -0500
Received: from thaodan.de ([2a03:4000:4f:f15::1]:60710)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <bjorn.bidar@HIDDEN>)
id 1thsR8-0007Ef-OT
for 75956 <at> debbugs.gnu.org; Tue, 11 Feb 2025 10:44:36 -0500
Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49])
by thaodan.de (Postfix) with ESMTPSA id AB7E5D00095;
Tue, 11 Feb 2025 17:44:27 +0200 (EET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail;
t=1739288667; bh=D2k8PSSB6j5xvjnLAPzypv+sZYkcjpRG+9MCKsyw4VU=;
h=From:To:Cc:Subject:In-Reply-To:References:Date;
b=JcRy+2uSMDPp236KUMxTX2dAikiqlPe0q2JNr4hJp3kcyLo3gTWimCpuO1X9QKtAe
y+D6vFqrNVB/I+uxV4RWbnoI4rGGt7GyQrZ4lADKFMz2WB4cvDgQNzVtTofSk4cL1Y
b+USwAv6cGDZJFZAG8S4Rdn/Hj6Z+RAVgllFfN1cRSL2MwIo6iZbgv7zfSioISqaUm
0nVzfjNDUQ3dbUrVo1z6Uh2yrXiIU6KZSd0JGgKOpLoxMMn+7rxc4PcWLxisIFznk9
IegtB1VAs6BJ1I9/9SxwbHfwHY2RK/oFIHFFlT/yaN29GtWWMASQem2GUJxN/Dkjvu
sKKFViqkyE+PnxhYi/ZD6t/OC6kDanvXd+h+dqwlxP8w/CS1/CBINUPBE56poycwX2
tIOei0pygVatv7Vhb2YmgyuIvdkxdH8UPBnnFOA3Df9uApCw3s2qqExKLBWhacb064
wNyzwpixjVdEECrktCJm53PgYEtvXaBQZYC9KNCTic2W+gSmi+0kbxmM8YPlT091R4
h7+d+1aRjYHF0/Gk+jCupCdOqzJUEgAknFnVxE6vIA2/TD+6IavL3+T9xUA+igOPVg
tpl6AYq84vTl7AyA6s2etzqOU3Is7fDWSmcG4i00ZuLLaOx6t28n01rh0EYGidtjas
K2gkvDmqw1twj00M0tP0b/sw=
From: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN>
To: Stefan Kangas <stefankangas@HIDDEN>
Subject: Re: bug#75956: Various improvements to sieve.el
In-Reply-To: <CADwFkm=UXFxi5gr9v6v_QY9Ys6kfMCFdi31xBRb3HD+UnCZ+sQ@HIDDEN>
(Stefan Kangas's message of "Mon, 10 Feb 2025 23:59:57 -0800")
References: <86ldug3gl9.fsf@HIDDEN>
<67a78f54.050a0220.22ba7c.4eb4SMTPIN_ADDED_BROKEN@HIDDEN>
<CADwFkm=UXFxi5gr9v6v_QY9Ys6kfMCFdi31xBRb3HD+UnCZ+sQ@HIDDEN>
Autocrypt: addr=bjorn.bidar@HIDDEN; prefer-encrypt=nopreference; keydata=
mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq
w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV
CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl
HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8
phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF
CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h
K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2
cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC
HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN
XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg
gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL
AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E
TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB
B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe
pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO
HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG
AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr
dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n
KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy
GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK
S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA==
Date: Tue, 11 Feb 2025 17:44:24 +0200
Message-ID: <87v7tgiizr.fsf@>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Stefan Kangas <stefankangas@HIDDEN> writes: > Björn Bidar
via "Bug reports for GNU Emacs, the Swiss army knife of text > editors" <bug-gnu-emacs@HIDDEN>
writes: > >> Eli Zaretskii <eliz@HIDDEN> writes: >> >>>> Date: Fri, 31 Jan
2025 03:54:11 [...]
Content analysis details: (1.2 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
-0.0 SPF_PASS SPF: sender matches SPF record
1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822
X-Debbugs-Envelope-To: 75956
Cc: Eli Zaretskii <eliz@HIDDEN>, 75956 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)
Stefan Kangas <stefankangas@HIDDEN> writes:
> Bj=C3=B6rn Bidar via "Bug reports for GNU Emacs, the Swiss army knife of =
text
> editors" <bug-gnu-emacs@HIDDEN> writes:
>
>> Eli Zaretskii <eliz@HIDDEN> writes:
>>
>>>> Date: Fri, 31 Jan 2025 03:54:11 +0200
>>>> From: Bj=C3=B6rn Bidar via "Bug reports for GNU Emacs,
>>>> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>>>>
>>>> I noticed it is not possible to specific the sieve-manage port when
>>>> calling `sieve-manage`. While fixing that I noticed various other issu=
es.
>>>> - Missing documentation strings on many functions
>>>> - There is function to refresh the buffer but it is not bound
>>>>
>>>> The attached patches try to fix these issues.
>>>
>>> Thanks, please see some comments below.
>
> Some additional comments from me.
>
>>>> (defun sieve-manage (server &optional port)
>>>> - (interactive "sServer: ")
>>>> + "Open ManageSieve SERVER.
>>>> +Optionally with PORT.
>>>
>>> This is too cryptic. It should be something like
>>>
>>> Optional argument PORT specifies the port to use; it defaults to
>>> `sieve-manage-default-port'.
>>
>> Isn't that kinda redundant? Especially saying port twice doesn't help to
>> understand the purpose the variable is self explanatory.
>
> It's not redundant, no.
>
>> From 7b2d6c3c4bfaa0611c6a23b452c0b40831c41696 Mon Sep 17 00:00:00 2001
>> From: =3D?UTF-8?q?Bj=3DC3=3DB6rn=3D20Bidar?=3D <bjorn.bidar@HIDDEN>
>> Date: Fri, 31 Jan 2025 02:34:19 +0200
>> Subject: [PATCH 1/3] * lisp/net/sieve.el: Read port in sieve-manage when
>> interactive
>>
>> (sieve-manage): Optionally read port when called interactively.
>> Add previously missing documentation string.
>
> Please add the bug number here and to the other patches, like this:
>
> Add missing documentation string. (Bug#75956)
>
>> ---
>> lisp/net/sieve.el | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/lisp/net/sieve.el b/lisp/net/sieve.el
>> index f9f036e1589..c67d8b34ce0 100644
>> --- a/lisp/net/sieve.el
>> +++ b/lisp/net/sieve.el
>> @@ -338,7 +338,14 @@ sieve-refresh-scriptlist
>>
>> ;;;###autoload
>> (defun sieve-manage (server &optional port)
>> - (interactive "sServer: ")
>> + "Open ManageSieve SERVER.
>> +Optionally argument PORT specifies the port use;
>> +otherwise it defaults to `sieve-manage-default-port'.
>> +
>> +When called interactively, prompt for SERVER:PORT
>> +if :PORT is not specified fall back to `sieve-manage-default-port'."
>> + (interactive
>> + (split-string (read-string "Server: ") ":"))
>
> How are users that see a prompt for "Server: " supposed to know that
> they are to enter a part also? What will happen if the user doesn't do
> that?
As per the documentation string if the port isn't included the default
port is used which is sieve.
> I recommend prompting first for server, then for port. Also, how about
> providing some defaults (does "localhost" and some standard port make
> sense)?
Specifying the port inside url is part of the standard why of specifying
the port (standard as is in general).
Asking for the port in the second step would also change the default
behavior.
A compromise would be to mention in the prompt that the port can be
specified in the prompt.
bug-gnu-emacs@HIDDEN:bug#75956; Package emacs.
Full text available.Received: (at 75956) by debbugs.gnu.org; 11 Feb 2025 08:00:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 11 03:00:09 2025
Received: from localhost ([127.0.0.1]:54231 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1thlBg-0002Mv-JD
for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 03:00:09 -0500
Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:51240)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
id 1thlBc-00022j-Ev
for 75956 <at> debbugs.gnu.org; Tue, 11 Feb 2025 03:00:05 -0500
Received: by mail-ed1-x52f.google.com with SMTP id
4fb4d7f45d1cf-5de849a0b6cso3275910a12.2
for <75956 <at> debbugs.gnu.org>; Tue, 11 Feb 2025 00:00:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1739260798; x=1739865598; darn=debbugs.gnu.org;
h=content-transfer-encoding:cc:to:subject:message-id:date
:mime-version:references:in-reply-to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=gIc9jTsaortuvuo1RSaJPCSrDny31sqz4QnK2AlSzr0=;
b=RPB+df40asBDc5KFE3JNgXK4Wd/no+fRuv0xSOUCyLYDU2KsUw96mT0UvN8buB8901
LjLiRVaz0NATX8QBGuDoHQzEwOHmmp5zGHRV/YE4OVOrVJgJ2YOICz34CB/jPTvFMSFZ
09U9EOwK8idsX5LPyrGtaYsX3CUG/4d3hUeSg+sOir7tPSHMgd+7X/eYQfw8RqB0A+c6
SsWEwbiMj0k9XUN1NA0Tw6zcBqeTspK9JZZucCG4R8yKSx2hYCm5y4xr5EchEvjv/dIL
NST7e73DK9u+r6dPCxCfohY8P6n+hksjz+DUqhFU+xmZbyuBGR3exNL6xqhpMidoSJwa
h2CA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1739260798; x=1739865598;
h=content-transfer-encoding:cc:to:subject:message-id:date
:mime-version:references:in-reply-to:from:x-gm-message-state:from:to
:cc:subject:date:message-id:reply-to;
bh=gIc9jTsaortuvuo1RSaJPCSrDny31sqz4QnK2AlSzr0=;
b=FEHcyh0Xd45QwZy4sNqKzauHHOendBOGB0tnPJDTvXfyKnHfEsXyaPp9T1Yh45a/+s
XDbRcYllPUU98Dyl6L1xYNj5ZGR3pbknMN7ldOPqjdA4RfFlqMaVZvbL1/YrIXA5EnWD
PR7JgfhFz/7dHb1STcUkjE2lgLzjHHOzAqM85yaolMZxhPUhE4in0Cz6LDYOTZiNN7nT
CWlUyYJd/h0W2dVOX3m87MxvQf9R+/zzKpId2CAl6D+70eUPpXT31d1X5opZhg2+rEwI
UUIUFi18JBQSm0wkXDugR/msEQ8v6tidY1TjYZEMyfxria6T0cVw3o3bj344a31IUC69
YhkA==
X-Gm-Message-State: AOJu0Yx4oGGYLJtKWdT2M/5Wf390O4RUlULMTdKU7vbuWyZAptM3zNfe
oVpvSdwKRK9Z3w/AAvzbTmZ7cd9E94taKndtm8jrrE+LDYZJuYrH8u6Iu0zLCd02P4H1zDhD4+x
IG0NRjOnbLULZzrdaQ+l+OAE8XI0pQQ5FblY=
X-Gm-Gg: ASbGncvPMHjuXzafzEHkKGDBOJlQVRQ543f0LWpfjFFA9yPOI4u09iXCWB2OXpe/uWJ
elAu13V1p8InhMTxsjhPxOVT3Yks7Cv8APt8QWJekxL6RXkwMfP9gwk6Ww99x7xNZFuu2Ra1Hkg
==
X-Google-Smtp-Source: AGHT+IHYdQsWX6Z8NNzQwHVBZRSAasHTh/Wygn3LVA1cCBQUboO8ct3L8LwagrE/g/K9odn8Z1OCgnkjidk69eprY9Q=
X-Received: by 2002:a05:6402:238c:b0:5de:5717:f235 with SMTP id
4fb4d7f45d1cf-5de5717f3fdmr9752985a12.24.1739260798190; Mon, 10 Feb 2025
23:59:58 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
HTTPREST; Mon, 10 Feb 2025 23:59:57 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <67a78f54.050a0220.22ba7c.4eb4SMTPIN_ADDED_BROKEN@HIDDEN>
References: <86ldug3gl9.fsf@HIDDEN>
<67a78f54.050a0220.22ba7c.4eb4SMTPIN_ADDED_BROKEN@HIDDEN>
MIME-Version: 1.0
Date: Mon, 10 Feb 2025 23:59:57 -0800
X-Gm-Features: AWEUYZk--YT3PGW_K9ER4gir6dSdHIIV7x3Tdcm5FwzZbetwWxjC5-nzYUf8u9I
Message-ID: <CADwFkm=UXFxi5gr9v6v_QY9Ys6kfMCFdi31xBRb3HD+UnCZ+sQ@HIDDEN>
Subject: Re: bug#75956: Various improvements to sieve.el
To: =?UTF-8?B?QmrDtnJuIEJpZGFy?= <bjorn.bidar@HIDDEN>,
Eli Zaretskii <eliz@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75956
Cc: 75956 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Bj=C3=B6rn Bidar via "Bug reports for GNU Emacs, the Swiss army knife of te=
xt
editors" <bug-gnu-emacs@HIDDEN> writes:
> Eli Zaretskii <eliz@HIDDEN> writes:
>
>>> Date: Fri, 31 Jan 2025 03:54:11 +0200
>>> From: Bj=C3=B6rn Bidar via "Bug reports for GNU Emacs,
>>> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>>>
>>> I noticed it is not possible to specific the sieve-manage port when
>>> calling `sieve-manage`. While fixing that I noticed various other issue=
s.
>>> - Missing documentation strings on many functions
>>> - There is function to refresh the buffer but it is not bound
>>>
>>> The attached patches try to fix these issues.
>>
>> Thanks, please see some comments below.
Some additional comments from me.
>>> (defun sieve-manage (server &optional port)
>>> - (interactive "sServer: ")
>>> + "Open ManageSieve SERVER.
>>> +Optionally with PORT.
>>
>> This is too cryptic. It should be something like
>>
>> Optional argument PORT specifies the port to use; it defaults to
>> `sieve-manage-default-port'.
>
> Isn't that kinda redundant? Especially saying port twice doesn't help to
> understand the purpose the variable is self explanatory.
It's not redundant, no.
> From 7b2d6c3c4bfaa0611c6a23b452c0b40831c41696 Mon Sep 17 00:00:00 2001
> From: =3D?UTF-8?q?Bj=3DC3=3DB6rn=3D20Bidar?=3D <bjorn.bidar@HIDDEN>
> Date: Fri, 31 Jan 2025 02:34:19 +0200
> Subject: [PATCH 1/3] * lisp/net/sieve.el: Read port in sieve-manage when
> interactive
>
> (sieve-manage): Optionally read port when called interactively.
> Add previously missing documentation string.
Please add the bug number here and to the other patches, like this:
Add missing documentation string. (Bug#75956)
> ---
> lisp/net/sieve.el | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/net/sieve.el b/lisp/net/sieve.el
> index f9f036e1589..c67d8b34ce0 100644
> --- a/lisp/net/sieve.el
> +++ b/lisp/net/sieve.el
> @@ -338,7 +338,14 @@ sieve-refresh-scriptlist
>
> ;;;###autoload
> (defun sieve-manage (server &optional port)
> - (interactive "sServer: ")
> + "Open ManageSieve SERVER.
> +Optionally argument PORT specifies the port use;
> +otherwise it defaults to `sieve-manage-default-port'.
> +
> +When called interactively, prompt for SERVER:PORT
> +if :PORT is not specified fall back to `sieve-manage-default-port'."
> + (interactive
> + (split-string (read-string "Server: ") ":"))
How are users that see a prompt for "Server: " supposed to know that
they are to enter a part also? What will happen if the user doesn't do
that?
I recommend prompting first for server, then for port. Also, how about
providing some defaults (does "localhost" and some standard port make
sense)?
The rest of your patches LGTM.
bug-gnu-emacs@HIDDEN:bug#75956; Package emacs.
Full text available.Stefan Kangas <stefankangas@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 75956) by debbugs.gnu.org; 8 Feb 2025 17:06:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 08 12:06:51 2025
Received: from localhost ([127.0.0.1]:41228 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tgoI6-0004HG-S7
for submit <at> debbugs.gnu.org; Sat, 08 Feb 2025 12:06:51 -0500
Received: from thaodan.de ([2a03:4000:4f:f15::1]:45302)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <bjorn.bidar@HIDDEN>)
id 1tgoI4-0004Gu-9l
for 75956 <at> debbugs.gnu.org; Sat, 08 Feb 2025 12:06:49 -0500
Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49])
by thaodan.de (Postfix) with ESMTPSA id 39F1BD00038;
Sat, 8 Feb 2025 19:06:40 +0200 (EET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail;
t=1739034400; bh=RRGdQW2kZxr0r1NSBvj/93H2m1O0h2bmES+mPdQZ3zk=;
h=From:To:Cc:Subject:In-Reply-To:References:Date;
b=N1Gp9ORO7XckzCvgs1GvoV2K6nwypUYIcMfn6OviJa8AXOVT60tpgqIWgbdbpE93O
kakx7k6HcQCaNgf3nnT7l5Iz+Oz62c+Gs3VB2I30139+EE7USbVLDikiGH6aILxOZA
KZVXOeLfsjS/lUHiurGRogmtCUtSgDOv0CWY+wExInDLLMN7Q+Nww/tlHk3PUGQrQh
6tVR0Qg8yYOijmT+U1zfc7ERhwNE8ut1G5RIoSXrPHTj+6aV4q304eO+EI8ULjjqqi
PB9ukJtD73Kier5diADyDLen/YMaG/lTB1FccKdqcShsgMXud+vZeVkoa2oJ9VLzAf
OyQvTGeAF/qL5Q8/LINVTtRZ/PkiSaZu7kP9C0A61NqMlY1YW1qHyhMURCefIAl/xa
9q8/JP7RVFVu8AkmEnKDwuBYlXPvVq3RGlCiIhURyAbIIWQdq0AbcHbBLmnKEmNAa6
hKMuF7NkKJbu77bMBQm6+bGNSIVrZ9EFXm+30mGUlozBkZFiIwxrjrGmYIjQlfBtsV
YQV5VAMyjFLWXsYKu7z0eaHEPNKGPIl5IOKXoOv0bEKdhnYVwa4an29vKsu+KfRCOH
FWsijI9yY8rmH1ZS0nG/S1b4m7fpWNovcZzP9u3zZSW8IdnJ6IfD/MLAO6PI1mOGOl
lkSgdxTDB6mJmH3J0aOr4EMk=
From: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#75956: Various improvements to sieve.el
In-Reply-To: <86ldug3gl9.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 08 Feb
2025 11:56:18 +0200")
References: <86ldug3gl9.fsf@HIDDEN>
Autocrypt: addr=bjorn.bidar@HIDDEN; prefer-encrypt=nopreference; keydata=
mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq
w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV
CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl
HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8
phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF
CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h
K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2
cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC
HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN
XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg
gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL
AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E
TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB
B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe
pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO
HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG
AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr
dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n
KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy
GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK
S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA==
Date: Sat, 08 Feb 2025 19:06:39 +0200
Message-ID: <875xlktlgg.fsf@>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Eli Zaretskii <eliz@HIDDEN> writes: >> Date: Fri, 31 Jan
2025 03:54:11 +0200 >> From: Björn Bidar via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> >> >> I noticed
it is not possible to sp [...]
Content analysis details: (1.2 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
-0.0 SPF_PASS SPF: sender matches SPF record
1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822
X-Debbugs-Envelope-To: 75956
Cc: 75956 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Eli Zaretskii <eliz@HIDDEN> writes:
>> Date: Fri, 31 Jan 2025 03:54:11 +0200
>> From: Bj=C3=B6rn Bidar via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>>
>> I noticed it is not possible to specific the sieve-manage port when
>> calling `sieve-manage`. While fixing that I noticed various other issues.
>> - Missing documentation strings on many functions
>> - There is function to refresh the buffer but it is not bound
>>
>> The attached patches try to fix these issues.
>
> Thanks, please see some comments below.
>
>> (defun sieve-manage (server &optional port)
>> - (interactive "sServer: ")
>> + "Open ManageSieve SERVER.
>> +Optionally with PORT.
>
> This is too cryptic. It should be something like
>
> Optional argument PORT specifies the port to use; it defaults to
> `sieve-manage-default-port'.
Isn't that kinda redundant? Especially saying port twice doesn't help to
understand the purpose the variable is self explanatory.=20
>> +When called in interactively prompt for SERVER:PORT
> ^^ ^
> This "in" is redundant. And a comma is missing after "interactively".
>
>> +if :PORT is not specified fallback to `sieve-manage-default-port'."
> ^^^^^^^^
> "fall back", as two words.
>
>> (defun sieve-upload (&optional name)
>> + "Upload to script NAME to currently opened server.
> ^^
> That "to" should be removed.
>
>> +If NAME is nil detect name from script buffer name;
> ^
> Comma missing. Also, "name" should be "NAME". And the semicolon at
> the end should be a period.
Replaced the second NAME with it.
>> +If no open sieve buffer exists call `sieve-manage' first."
> ^
> Comma missing.
>
>> (defun sieve-upload-and-bury (&optional name)
>> + "Upload script NAME and bury buffer."
>
> This should say "bury the current buffer", not just "bury buffer".
>
>> ;;;###autoload
>> (defun sieve-upload-and-kill (&optional name)
>> + "Upload script NAME and kill buffer."
>
> Likewise.
>
>> >From 4c5a9c6267989d888b0b8aaa4a5b91508cd62d6e Mon Sep 17 00:00:00 2001
>> From: =3D?UTF-8?q?Bj=3DC3=3DB6rn=3D20Bidar?=3D <bjorn.bidar@HIDDEN>
>> Date: Fri, 31 Jan 2025 03:24:44 +0200
>> Subject: [PATCH 3/3] * lisp/net/sieve.el: Bind sieve-refresh-scriptlist =
to
>> refresh buffer
>>
>> (sieve-manage-mode-map: Bind `sieve-refersh-scriptlist' to 'g' to refresh
>> buffer.
>> ---
>> lisp/net/sieve.el | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/lisp/net/sieve.el b/lisp/net/sieve.el
>> index cd7053a7e65..98f1832d58d 100644
>> --- a/lisp/net/sieve.el
>> +++ b/lisp/net/sieve.el
>> @@ -111,6 +111,7 @@ sieve-manage-mode-map
>> ;; various
>> "?" #'sieve-help
>> "h" #'sieve-help
>> + "g" #'sieve-refresh-scriptlist
>> ;; activating
>> "m" #'sieve-activate
>> "u" #'sieve-deactivate
>> --
>
> This needs a NEWS entry about the new binding.
Done that while doing so I noticed that thghe info manual also needs
updating.
Updated that higlighted that the function updates the current sieve
buffer.
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0001-lisp-net-sieve.el-Read-port-in-sieve-manage-when-int.patch
From 7b2d6c3c4bfaa0611c6a23b452c0b40831c41696 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= <bjorn.bidar@HIDDEN>
Date: Fri, 31 Jan 2025 02:34:19 +0200
Subject: [PATCH 1/3] * lisp/net/sieve.el: Read port in sieve-manage when
interactive
(sieve-manage): Optionally read port when called interactively.
Add previously missing documentation string.
---
lisp/net/sieve.el | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/lisp/net/sieve.el b/lisp/net/sieve.el
index f9f036e1589..c67d8b34ce0 100644
--- a/lisp/net/sieve.el
+++ b/lisp/net/sieve.el
@@ -338,7 +338,14 @@ sieve-refresh-scriptlist
;;;###autoload
(defun sieve-manage (server &optional port)
- (interactive "sServer: ")
+ "Open ManageSieve SERVER.
+Optionally argument PORT specifies the port use;
+otherwise it defaults to `sieve-manage-default-port'.
+
+When called interactively, prompt for SERVER:PORT
+if :PORT is not specified fall back to `sieve-manage-default-port'."
+ (interactive
+ (split-string (read-string "Server: ") ":"))
(switch-to-buffer (get-buffer-create sieve-buffer))
(sieve-manage-mode)
(sieve-setup-buffer server port)
--
2.45.2
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0002-lisp-net-sieve.el-Add-missing-documentation-strings.patch
From a634a9bc7f01f15849706a377aae61d3c6921953 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= <bjorn.bidar@HIDDEN>
Date: Fri, 31 Jan 2025 02:53:34 +0200
Subject: [PATCH 2/3] * lisp/net/sieve.el: Add missing documentation strings
(sieve-activate, sieve-deactivate-all, sieve-remove)
(sieve-edit-script, sieve-refersh-scriptlist)
(sieve-upload, sieve-upload-and-burry)
(sieve-upload-and-kill): Add documentation strings
---
lisp/net/sieve.el | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/lisp/net/sieve.el b/lisp/net/sieve.el
index c67d8b34ce0..b714e54b01a 100644
--- a/lisp/net/sieve.el
+++ b/lisp/net/sieve.el
@@ -161,6 +161,7 @@ sieve-bury-buffer
(bury-buffer))
(defun sieve-activate (&optional _pos)
+ "Activate script at point."
(interactive)
(let ((name (sieve-script-at-point)) err)
(when (or (null name) (string-equal name sieve-new-script))
@@ -173,6 +174,7 @@ sieve-activate
(message "Activating script %s...failed: %s" name (nth 2 err)))))
(defun sieve-deactivate-all (&optional _pos)
+ "Deactivate all currently active scripts."
(interactive)
(message "Deactivating scripts...")
(let (;; (name (sieve-script-at-point))
@@ -185,6 +187,7 @@ sieve-deactivate-all
(defalias 'sieve-deactivate #'sieve-deactivate-all)
(defun sieve-remove (&optional _pos)
+ "Remove script at point."
(interactive)
(let ((name (sieve-script-at-point)) err)
(when (or (null name) (string-equal name sieve-new-script))
@@ -197,6 +200,7 @@ sieve-remove
(message "Removing sieve script %s...done" name)))
(defun sieve-edit-script (&optional _pos)
+ "Edit script at point."
(interactive)
(let ((name (sieve-script-at-point)))
(unless name
@@ -310,6 +314,7 @@ sieve-open-server
(sieve-manage-authenticate)))
(defun sieve-refresh-scriptlist ()
+ "Refresh list of scripts found the currently opened server."
(interactive)
(with-current-buffer sieve-buffer
(setq buffer-read-only nil)
@@ -355,6 +360,9 @@ sieve-manage
;;;###autoload
(defun sieve-upload (&optional name)
+ "Upload script NAME to currently opened server.
+If NAME is nil, detect it from script buffer name.
+If no open sieve buffer exists, call `sieve-manage' first."
(interactive)
(when (or (get-buffer sieve-buffer)
(save-current-buffer (call-interactively 'sieve-manage)))
@@ -373,12 +381,14 @@ sieve-upload
;;;###autoload
(defun sieve-upload-and-bury (&optional name)
+ "Upload script NAME and bury the current buffer."
(interactive)
(sieve-upload name)
(bury-buffer))
;;;###autoload
(defun sieve-upload-and-kill (&optional name)
+ "Upload script NAME and kill the current buffer."
(interactive)
(sieve-upload name)
(kill-buffer))
--
2.45.2
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0003-Bind-sieve-refresh-scriptlist-to-refresh-buffer.patch
From 90d6157a24906aac02cbacebebc2caeccfbf3a47 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= <bjorn.bidar@HIDDEN>
Date: Fri, 31 Jan 2025 03:24:44 +0200
Subject: [PATCH 3/3] Bind sieve-refresh-scriptlist to refresh buffer
* lisp/net/sieve.el (sieve-manage-mode-map):
Bind `sieve-refersh-scriptlist' to 'g' to refresh buffer.
(sieve-refresh-scriptlist): Highlight that the function updates
the current sieve buffer.
* etc/NEWS: Announce new keybinding
* doc/misc/siev.texi (Managing Sieve):
Document new keybinding and the existing `sieve-refresh-scriptlist`
function.
---
doc/misc/sieve.texi | 6 ++++++
etc/NEWS | 6 ++++++
lisp/net/sieve.el | 4 +++-
3 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/doc/misc/sieve.texi b/doc/misc/sieve.texi
index 5d4b3b369d7..deadc991173 100644
--- a/doc/misc/sieve.texi
+++ b/doc/misc/sieve.texi
@@ -213,6 +213,12 @@ Managing Sieve
@findex sieve-help
Displays help in the minibuffer.
+@item g
+@kindex g
+@findex sieve-refresh-scriptlist
+Refresh list of scripts found on the currently opened server.
+Update contents of the current sieve buffer.
+
@item Q
@kindex Q
@findex sieve-manage-quit
diff --git a/etc/NEWS b/etc/NEWS
index 2f04204ad94..fc40b07fa59 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -392,6 +392,12 @@ When called with a prefix argument, accepting, declining, or tentatively
accepting an icalendar event will prompt for a comment to add to the
response.
+** Sieve
++++
+*** New keybinding to refresh buffer in sieve-manage-mode
+'sieve-refresh-scriptlist' is now bound to 'g' to refresh the contents
+of the current sieve buffer.
+
** Button
+++
diff --git a/lisp/net/sieve.el b/lisp/net/sieve.el
index b714e54b01a..b55f571e07c 100644
--- a/lisp/net/sieve.el
+++ b/lisp/net/sieve.el
@@ -111,6 +111,7 @@ sieve-manage-mode-map
;; various
"?" #'sieve-help
"h" #'sieve-help
+ "g" #'sieve-refresh-scriptlist
;; activating
"m" #'sieve-activate
"u" #'sieve-deactivate
@@ -314,7 +315,8 @@ sieve-open-server
(sieve-manage-authenticate)))
(defun sieve-refresh-scriptlist ()
- "Refresh list of scripts found the currently opened server."
+ "Refresh list of scripts found the currently opened server.
+Update contents of the current sieve buffer."
(interactive)
(with-current-buffer sieve-buffer
(setq buffer-read-only nil)
--
2.45.2
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#75956; Package emacs.
Full text available.Received: (at 75956) by debbugs.gnu.org; 8 Feb 2025 09:56:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 08 04:56:36 2025
Received: from localhost ([127.0.0.1]:38618 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tghZj-00079M-Uc
for submit <at> debbugs.gnu.org; Sat, 08 Feb 2025 04:56:36 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:53662)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tghZg-000794-Aj
for 75956 <at> debbugs.gnu.org; Sat, 08 Feb 2025 04:56:33 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1tghZZ-0007H0-Mu; Sat, 08 Feb 2025 04:56:26 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
Date; bh=jYqTgOm1YqX2RW8okAFrswcSlQ/NkfDxsZfTppFB78w=; b=bKuGtMquMgfkfWnOlqfX
LZCfBgdNX1t0hCsTanpFvh4lyz42IZNjN0BgeZdakDjU6pFvxV+b6rhSFVaed64k5PI0gZHl4xaYo
Knb84fQHNC+VwDaJ7tYuaxhZSeASR5svfc6iNGKQcvuTxJAahzq1xcWbsvcCojmQClswy1P06MTxz
JKn+CfXUxafeMh9lf1SVqqEhPVuOweqKG46C6yd2LtgR7sN4pQLGJ+leZITK3bqcwGFd5DXf60oLd
fZYx/dYfqtWGK1FLBZ15TxvOeU84vlTsAu8hNZCC0RZhbpSXbkhBZ+YHhnxIJKARB64W0aaipuLnT
+oiIpCbk3hRaOg==;
Date: Sat, 08 Feb 2025 11:56:18 +0200
Message-Id: <86ldug3gl9.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN>
In-Reply-To: <87h65f694s.fsf@> (bug-gnu-emacs@HIDDEN)
Subject: Re: bug#75956: Various improvements to sieve.el
References: <87h65f694s.fsf@>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 75956
Cc: 75956 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Date: Fri, 31 Jan 2025 03:54:11 +0200
> From: Björn Bidar via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>
> I noticed it is not possible to specific the sieve-manage port when
> calling `sieve-manage`. While fixing that I noticed various other issues.
> - Missing documentation strings on many functions
> - There is function to refresh the buffer but it is not bound
>
> The attached patches try to fix these issues.
Thanks, please see some comments below.
> (defun sieve-manage (server &optional port)
> - (interactive "sServer: ")
> + "Open ManageSieve SERVER.
> +Optionally with PORT.
This is too cryptic. It should be something like
Optional argument PORT specifies the port to use; it defaults to
`sieve-manage-default-port'.
> +When called in interactively prompt for SERVER:PORT
^^ ^
This "in" is redundant. And a comma is missing after "interactively".
> +if :PORT is not specified fallback to `sieve-manage-default-port'."
^^^^^^^^
"fall back", as two words.
> (defun sieve-upload (&optional name)
> + "Upload to script NAME to currently opened server.
^^
That "to" should be removed.
> +If NAME is nil detect name from script buffer name;
^
Comma missing. Also, "name" should be "NAME". And the semicolon at
the end should be a period.
> +If no open sieve buffer exists call `sieve-manage' first."
^
Comma missing.
> (defun sieve-upload-and-bury (&optional name)
> + "Upload script NAME and bury buffer."
This should say "bury the current buffer", not just "bury buffer".
> ;;;###autoload
> (defun sieve-upload-and-kill (&optional name)
> + "Upload script NAME and kill buffer."
Likewise.
> >From 4c5a9c6267989d888b0b8aaa4a5b91508cd62d6e Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= <bjorn.bidar@HIDDEN>
> Date: Fri, 31 Jan 2025 03:24:44 +0200
> Subject: [PATCH 3/3] * lisp/net/sieve.el: Bind sieve-refresh-scriptlist to
> refresh buffer
>
> (sieve-manage-mode-map: Bind `sieve-refersh-scriptlist' to 'g' to refresh
> buffer.
> ---
> lisp/net/sieve.el | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lisp/net/sieve.el b/lisp/net/sieve.el
> index cd7053a7e65..98f1832d58d 100644
> --- a/lisp/net/sieve.el
> +++ b/lisp/net/sieve.el
> @@ -111,6 +111,7 @@ sieve-manage-mode-map
> ;; various
> "?" #'sieve-help
> "h" #'sieve-help
> + "g" #'sieve-refresh-scriptlist
> ;; activating
> "m" #'sieve-activate
> "u" #'sieve-deactivate
> --
This needs a NEWS entry about the new binding.
bug-gnu-emacs@HIDDEN:bug#75956; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 31 Jan 2025 01:54:28 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 30 20:54:28 2025
Received: from localhost ([127.0.0.1]:48524 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tdgEl-0000eE-6N
for submit <at> debbugs.gnu.org; Thu, 30 Jan 2025 20:54:28 -0500
Received: from lists.gnu.org ([2001:470:142::17]:37898)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <bjorn.bidar@HIDDEN>)
id 1tdgEh-0000e0-Rm
for submit <at> debbugs.gnu.org; Thu, 30 Jan 2025 20:54:24 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <bjorn.bidar@HIDDEN>)
id 1tdgEc-0003Ej-EW
for bug-gnu-emacs@HIDDEN; Thu, 30 Jan 2025 20:54:18 -0500
Received: from thaodan.de ([185.216.177.71])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <bjorn.bidar@HIDDEN>)
id 1tdgEZ-0002Ou-Hy
for bug-gnu-emacs@HIDDEN; Thu, 30 Jan 2025 20:54:18 -0500
Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49])
by thaodan.de (Postfix) with ESMTPSA id E934CD0004F
for <bug-gnu-emacs@HIDDEN>; Fri, 31 Jan 2025 03:54:12 +0200 (EET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail;
t=1738288453; bh=whpwLSvZ58lzv6vzybHfEomSHZTYHxrkcKbjANlgVX8=;
h=From:To:Subject:Date;
b=2CfKv0zK9GqDb22ai5oYvvZ7VP9WifmP/C5jyBBfjd62qL2coWuHVQMEEAVFCKnQF
dmYaPVPNVfLRLHsE3Hjl/KvG3DIPXiOb+o814zFPlp0H4FZIqWhbfkFpPDbYMsAsp2
t0+2Qgnasj4gXdIrjQfHwFfcfsWTaIwjwrFPqbkkbn2Zyn3Nr1CMDWRiQzfXwi/9ae
k0z98OtJ5ElHAJd37vVhZ5GGD8VZp9+xDLyDyVatIINLCWS6m4C0ilF3ulNXDGwIkS
kG1OtKktJBTp9fXx6rCFPt0sFrgms3B1HRYECfnsK4iD/18J/VA3XSXzVYAioiCKwW
TCYtGk4CkX/3XlufdX9NDLgH1YIEDW/3fCaX/U4fn2fiPbg0WkAidRpJ+jUJvKeu07
F86RP5nsy2DMNWAjwJIfeAUd4hpIZOtwdTvLrD5DwRiGROBwZwUrWyxxGoS/GinDFM
49EqqYE9zZT87IHnydjCfD6flDl2lxe1mx9yfmjyeZX+xX5ely9X/DXZpSBg+K6xSz
bD7srCSSqkzk1p0hHDr98FnA0WZKLw9l4nHse2nhqjO4AHFA9GH5p+fI28YGWd6qh0
pDmSJmqLqwN1yzQqqff+jP2d76ifNTU/qTgMVHsYtXtxA3KOBbibowYR62gB30Mzim
cqJISHPRNSElYDxFA+QHj3j8=
From: =?utf-8?Q?Bj=C3=B6rn?= Bidar <bjorn.bidar@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: Various improvements to sieve.el
X-Debbugs-Cc:
Autocrypt: addr=bjorn.bidar@HIDDEN; prefer-encrypt=nopreference; keydata=
mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq
w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV
CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl
HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8
phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF
CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h
K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2
cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC
HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN
XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg
gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL
AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E
TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB
B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe
pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO
HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG
AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr
dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n
KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy
GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK
S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA==
Date: Fri, 31 Jan 2025 03:54:11 +0200
Message-ID: <87h65f694s.fsf@>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=185.216.177.71;
envelope-from=bjorn.bidar@HIDDEN; helo=thaodan.de
X-Spam_score_int: -14
X-Spam_score: -1.5
X-Spam_bar: -
X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, INVALID_MSGID=0.568,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 2.1 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Tags: patch I noticed it is not possible to specific the
sieve-manage
port when calling `sieve-manage`. While fixing that I noticed various other
issues. - Missing documentation strings on many functions - There [...]
Content analysis details: (2.1 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org]
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)
1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.1 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Tags: patch I noticed it is not possible to specific the sieve-manage
port when calling `sieve-manage`. While fixing that I noticed various other
issues. - Missing documentation strings on many functions - There [...]
Content analysis details: (1.1 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust
[2001:470:142:0:0:0:0:17 listed in]
[list.dnswl.org]
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)
1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
--=-=-=
Content-Type: text/plain
Tags: patch
I noticed it is not possible to specific the sieve-manage port when
calling `sieve-manage`. While fixing that I noticed various other issues.
- Missing documentation strings on many functions
- There is function to refresh the buffer but it is not bound
The attached patches try to fix these issues.
In GNU Emacs 31.0.50 (build 1, x86_64-suse-linux-gnu, GTK+ Version
3.24.43, cairo version 1.18.2)
Repository revision: 2efffbe7731ba979540df851819af0ef15b94c62
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101015
System Description: openSUSE Tumbleweed
Configured using:
'configure --disable-build-details --without-pop --with-mailutils
--without-hesiod --with-gameuser=:games --with-kerberos
--with-kerberos5 --with-file-notification=inotify --with-modules
--enable-autodepend --enable-link-time-optimization --prefix=/usr
--mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share
--localstatedir=/var --sharedstatedir=/var/lib
--libexecdir=/usr/libexec --with-file-notification=yes
--libdir=/usr/lib64 --with-native-compilation=aot
--enable-locallisppath=/usr/share/emacs/31.0.50/site-lisp:/usr/share/emacs/site-lisp
--with-x --with-xim --with-sound --with-xpm --with-jpeg --with-tiff
--with-gif --with-png --with-rsvg --with-dbus --with-xft --without-gpm
--with-tree-sitter --with-x-toolkit=gtk --without-pgtk
--with-toolkit-scroll-bars --x-includes=/usr/include
--x-libraries=/usr/lib64 --with-libotf --with-m17n-flt --with-cairo
--build=x86_64-suse-linux --with-dumping=pdumper
build_alias=x86_64-suse-linux 'CC=sccache cc' 'CFLAGS=-O2 -Wall
-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong
-funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection
-Werror=return-type -flto=auto -march=znver3 -mmmx -mpopcnt -msse
-msse2 -msse3 -mssse3 -msse4.1 -msse4.2 -mavx -mavx2 -msse4a -mno-fma4
-mno-xop -mfma -mbmi -mbmi2 -maes -mpclmul -mno-gfni -mvpclmulqdq
-mno-3dnow -madx -mabm -mno-cldemote -mclflushopt -mclwb -mclzero
-mcx16 -mno-enqcmd -mf16c -mfsgsbase -mfxsr -mno-hle -msahf -mno-lwp
-mlzcnt -mmovbe -mno-movdir64b -mno-movdiri -mmwaitx -mno-pconfig -mpku
-mprfchw -mno-ptwrite -mrdpid -mrdrnd -mrdseed -mno-rtm -mno-serialize
-mno-sgx -msha -mshstk -mno-tbm -mno-tsxldtrk -mvaes -mno-waitpkg
-mwbnoinvd -mxsave -mxsavec -mxsaveopt -mxsaves -mno-amx-tile
-mno-amx-int8 -mno-amx-bf16 -mno-uintr -mno-hreset -mno-kl -mno-widekl
-mno-avxvnni -mno-avxifma -mno-avxvnniint8 -mno-avxneconvert
-mno-cmpccxadd -mno-amx-fp16 -mno-prefetchi -mno-raoint
-mno-amx-complex --param l1-cache-size=32 --param l1-cache-line-size=64
--param l2-cache-size=512 -mtune=znver3 -fno-optimize-sibling-calls -O2
-Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong
-funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection
-Werror=return-type -flto=auto -g -D_GNU_SOURCE
-DGDK_DISABLE_DEPRECATION_WARNINGS -DGLIB_DISABLE_DEPRECATION_WARNINGS
-pipe -Wno-pointer-sign -Wno-unused-variable -Wno-unused-label
-DPDMP_BASE='\''"emacs-gtk"'\''' LDFLAGS=-Wl,-O2 'CXX=sccache c++'
PKG_CONFIG_PATH=:/usr/lib64/pkgconfig:/usr/share/pkgconfig'
--=-=-=
Content-Type: text/patch
Content-Disposition: attachment;
filename=0001-lisp-net-sieve.el-Read-port-in-sieve-manage-when-int.patch
From e54ab1de5bbd214e38b4064ae6f2c81c12e54cf6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= <bjorn.bidar@HIDDEN>
Date: Fri, 31 Jan 2025 02:34:19 +0200
Subject: [PATCH 1/3] * lisp/net/sieve.el: Read port in sieve-manage when
interactive
(sieve-manage): Optionally read port when called interactively.
Add previously missing documentation string.
---
lisp/net/sieve.el | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/lisp/net/sieve.el b/lisp/net/sieve.el
index f9f036e1589..8d44c384539 100644
--- a/lisp/net/sieve.el
+++ b/lisp/net/sieve.el
@@ -338,7 +338,13 @@ sieve-refresh-scriptlist
;;;###autoload
(defun sieve-manage (server &optional port)
- (interactive "sServer: ")
+ "Open ManageSieve SERVER.
+Optionally with PORT.
+
+When called in interactively prompt for SERVER:PORT
+if :PORT is not specified fallback to `sieve-manage-default-port'."
+ (interactive
+ (split-string (read-string "Server: ") ":"))
(switch-to-buffer (get-buffer-create sieve-buffer))
(sieve-manage-mode)
(sieve-setup-buffer server port)
--
2.45.2
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0002-lisp-net-sieve.el-Add-missing-documentation-strings.patch
From 537db1a9595e08a0169a406257e90d6b9d9f7b67 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= <bjorn.bidar@HIDDEN>
Date: Fri, 31 Jan 2025 02:53:34 +0200
Subject: [PATCH 2/3] * lisp/net/sieve.el: Add missing documentation strings
(sieve-activate, sieve-deactivate-all, sieve-remove)
(sieve-edit-script, sieve-refersh-scriptlist)
(sieve-upload, sieve-upload-and-burry)
(sieve-upload-and-kill): Add documentation strings
---
lisp/net/sieve.el | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/lisp/net/sieve.el b/lisp/net/sieve.el
index 8d44c384539..cd7053a7e65 100644
--- a/lisp/net/sieve.el
+++ b/lisp/net/sieve.el
@@ -161,6 +161,7 @@ sieve-bury-buffer
(bury-buffer))
(defun sieve-activate (&optional _pos)
+ "Activate script at point."
(interactive)
(let ((name (sieve-script-at-point)) err)
(when (or (null name) (string-equal name sieve-new-script))
@@ -173,6 +174,7 @@ sieve-activate
(message "Activating script %s...failed: %s" name (nth 2 err)))))
(defun sieve-deactivate-all (&optional _pos)
+ "Deactivate all currently active scripts."
(interactive)
(message "Deactivating scripts...")
(let (;; (name (sieve-script-at-point))
@@ -185,6 +187,7 @@ sieve-deactivate-all
(defalias 'sieve-deactivate #'sieve-deactivate-all)
(defun sieve-remove (&optional _pos)
+ "Remove script at point."
(interactive)
(let ((name (sieve-script-at-point)) err)
(when (or (null name) (string-equal name sieve-new-script))
@@ -197,6 +200,7 @@ sieve-remove
(message "Removing sieve script %s...done" name)))
(defun sieve-edit-script (&optional _pos)
+ "Edit script at point."
(interactive)
(let ((name (sieve-script-at-point)))
(unless name
@@ -310,6 +314,7 @@ sieve-open-server
(sieve-manage-authenticate)))
(defun sieve-refresh-scriptlist ()
+ "Refresh list of scripts found the currently opened server."
(interactive)
(with-current-buffer sieve-buffer
(setq buffer-read-only nil)
@@ -354,6 +359,9 @@ sieve-manage
;;;###autoload
(defun sieve-upload (&optional name)
+ "Upload to script NAME to currently opened server.
+If NAME is nil detect name from script buffer name;
+If no open sieve buffer exists call `sieve-manage' first."
(interactive)
(when (or (get-buffer sieve-buffer)
(save-current-buffer (call-interactively 'sieve-manage)))
@@ -372,12 +380,14 @@ sieve-upload
;;;###autoload
(defun sieve-upload-and-bury (&optional name)
+ "Upload script NAME and bury buffer."
(interactive)
(sieve-upload name)
(bury-buffer))
;;;###autoload
(defun sieve-upload-and-kill (&optional name)
+ "Upload script NAME and kill buffer."
(interactive)
(sieve-upload name)
(kill-buffer))
--
2.45.2
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0003-lisp-net-sieve.el-Bind-sieve-refresh-scriptlist-to-r.patch
From 4c5a9c6267989d888b0b8aaa4a5b91508cd62d6e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= <bjorn.bidar@HIDDEN>
Date: Fri, 31 Jan 2025 03:24:44 +0200
Subject: [PATCH 3/3] * lisp/net/sieve.el: Bind sieve-refresh-scriptlist to
refresh buffer
(sieve-manage-mode-map: Bind `sieve-refersh-scriptlist' to 'g' to refresh
buffer.
---
lisp/net/sieve.el | 1 +
1 file changed, 1 insertion(+)
diff --git a/lisp/net/sieve.el b/lisp/net/sieve.el
index cd7053a7e65..98f1832d58d 100644
--- a/lisp/net/sieve.el
+++ b/lisp/net/sieve.el
@@ -111,6 +111,7 @@ sieve-manage-mode-map
;; various
"?" #'sieve-help
"h" #'sieve-help
+ "g" #'sieve-refresh-scriptlist
;; activating
"m" #'sieve-activate
"u" #'sieve-deactivate
--
2.45.2
--=-=-=--
Björn Bidar <bjorn.bidar@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#75956; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.