GNU bug report logs - #76024
maint: fix mistake in module renaming

Previous Next

Package: gzip;

Reported by: Collin Funk <collin.funk1 <at> gmail.com>

Date: Mon, 3 Feb 2025 03:55:02 UTC

Severity: normal

To reply to this bug, email your comments to 76024 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gzip <at> gnu.org:
bug#76024; Package gzip. (Mon, 03 Feb 2025 03:55:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Collin Funk <collin.funk1 <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gzip <at> gnu.org. (Mon, 03 Feb 2025 03:55:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Collin Funk <collin.funk1 <at> gmail.com>
To: bug-gzip <at> gnu.org, Jim Meyering <jim <at> meyering.net>
Subject: maint: fix mistake in module renaming
Date: Sun, 02 Feb 2025 19:54:24 -0800
[Message part 1 (text/plain, inline)]
Hi Jim,

I noticed a small mistake in this commit:

    maint: reflect gnulib module renamings
    
    * bootstrap.conf: Some gnulib modules are now deprecated in favor of
    new names with a "-h" suffix.  Induce this change with the following:
      re='inttypes|realloc-gnu|sys_stat'
      perl -pi -e 's{^('"$re"')$}{$1-h}' bootstrap.conf

It renamed realloc-gnu to realloc-gnu-h which does not exist.

Patch attached.

Collin

[0001-maint-fix-mistake-in-module-renaming.patch (text/x-patch, attachment)]

Information forwarded to bug-gzip <at> gnu.org:
bug#76024; Package gzip. (Mon, 03 Feb 2025 04:16:02 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Collin Funk <collin.funk1 <at> gmail.com>
Cc: bug-gzip <at> gnu.org
Subject: Re: maint: fix mistake in module renaming
Date: Sun, 2 Feb 2025 20:15:06 -0800
[Message part 1 (text/plain, inline)]
On Sun, Feb 2, 2025 at 7:54 PM Collin Funk <collin.funk1 <at> gmail.com> wrote:
> Hi Jim,
>
> I noticed a small mistake in this commit:
>
>     maint: reflect gnulib module renamings
>
>     * bootstrap.conf: Some gnulib modules are now deprecated in favor of
>     new names with a "-h" suffix.  Induce this change with the following:
>       re='inttypes|realloc-gnu|sys_stat'
>       perl -pi -e 's{^('"$re"')$}{$1-h}' bootstrap.conf
>
> It renamed realloc-gnu to realloc-gnu-h which does not exist.

Thanks, Collin!
However, the goal of that change was to move away from deprecated modules,
so from realloc-gnu to realloc-posix. This is what I'll push shortly:
[gzip-bootstrap-conf.diff (application/octet-stream, attachment)]

Information forwarded to bug-gzip <at> gnu.org:
bug#76024; Package gzip. (Mon, 03 Feb 2025 04:22:02 GMT) Full text and rfc822 format available.

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Collin Funk <collin.funk1 <at> gmail.com>
To: Jim Meyering <jim <at> meyering.net>
Cc: bug-gzip <at> gnu.org
Subject: Re: maint: fix mistake in module renaming
Date: Sun, 02 Feb 2025 20:21:28 -0800
Jim Meyering <jim <at> meyering.net> writes:

> However, the goal of that change was to move away from deprecated modules,
> so from realloc-gnu to realloc-posix. This is what I'll push shortly:

Ah, right. I forgot about the change from realloc-gnu to realloc-posix.
Thanks!

Collin




This bug report was last modified 4 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.