GNU logs - #76065, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#76065: 31.0.50; When package is installed with 'package-vc-install' it has default summary
Resent-From: Przemyslaw Kryger <pkryger@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 05 Feb 2025 01:49:02 +0000
Resent-Message-ID: <handler.76065.B.173872013328886 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 76065 <at> debbugs.gnu.org
From: Przemyslaw Kryger <pkryger@HIDDEN>
Date: Tue, 04 Feb 2025 18:27:19 +0000
Message-ID: <34gt4lbs.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=2a00:1450:4864:20::32b;
 envelope-from=pkryger@HIDDEN; helo=mail-wm1-x32b.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Mailman-Approved-At: Tue, 04 Feb 2025 20:48:50 -0500
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

--=-=-=
Content-Type: text/plain


On a freshly installed Emacs (no user configuration whatsoever):

1. 'emacs -Q'

2. Install a package providing package name and spec by evaling the
followinw in '*scratch*' (using 'ace-window' for the sake of arguments):

(package-vc-install (cons 'ace-window
                          (list
                           :url "https://github.com/abo-abo/ace-window.git")))

3. Eval the following to get the package summary:

(package-desc-summary
 (cadr (assq 'ace-window package-alist)))
;; "No description available."

4. Eval the following to get the contents of generated
'ace-window-pkg.el' file:

(with-temp-buffer
  (insert-file-contents
   (expand-file-name "ace-window-pkg.el"
                     (package-desc-dir
                      (cadr (assq 'ace-window package-alist)))))
  (goto-char (point-min))
  (read (current-buffer)))
;; (define-package "ace-window" "0.10.0" "No description available." '((avy "0.5.0")) :kind vc :commit "77115afc1b0b9f633084cf7479c767988106c196")

The function 'package-vc-install-from-checkout' is affected as well,
again starting with a freshly installed Emacs with no configuration:

1. 'cd ~'

2. 'git clone https://github.com/abo-abo/ace-window.git'

3. 'emacs -Q'

4. Eval the following

(package-vc-install-from-checkout "~/ace-window" "ace-window")

5. Eval the following to get the package summary:

(package-desc-summary
 (cadr (assq 'ace-window package-alist)))
;; "No description available."

5. Eval the following to get the contents of generated
'ace-window-pkg.el' file:

(with-temp-buffer
  (insert-file-contents
   (expand-file-name "ace-window-pkg.el"
                     "~"))
  (goto-char (point-min))
  (read (current-buffer)))
;; (define-package "ace-window" "0.10.0" "No description available." '((avy "0.5.0")) :kind vc :commit "77115afc1b0b9f633084cf7479c767988106c196")


I can reproduce the same behaviour on Emacs 29.4 Mac port as well.

I think the issue stems from how function
'package-vc--generate-description-file' detects that it needs to
generate a new description (as opposed to re-using the one in passed
argument PGK-DESC).  I have applied the attached patch and after
installing the package (either with 'package-vc-install' or with
'package-vc-install-from-checkout') I can see description being properly
generated.

--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
 filename=0001-Fix-summary-in-packages-installed-with-package-vc-fu.patch

From af4a5cf3ef576d2acf5efc53dd563664c3c23869 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Przemys=C5=82aw=20Kryger?= <pkryger@HIDDEN>
Date: Tue, 4 Feb 2025 18:18:06 +0000
Subject: [PATCH] Fix summary in packages installed with package-vc functions

* emacs-list/package-vc.el: (package-vc--generate-description-file): Use
`package--default-summary` to determine when a summary for a newly
installed package should be generated.
---
 lisp/emacs-lisp/package-vc.el | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el
index a18841fb64d..ec8418faf69 100644
--- a/lisp/emacs-lisp/package-vc.el
+++ b/lisp/emacs-lisp/package-vc.el
@@ -272,10 +272,14 @@ asynchronously."
   "Generate a package description file for PKG-DESC and write it to PKG-FILE."
   (let ((name (package-desc-name pkg-desc)))
     ;; Infer the subject if missing.
-    (unless (package-desc-summary pkg-desc)
+    (when (or (null (package-desc-summary pkg-desc))
+              (equal (package-desc-summary pkg-desc)
+                     package--default-summary))
       (setf (package-desc-summary pkg-desc)
             (let ((main-file (package-vc--main-file pkg-desc)))
-              (or (package-desc-summary pkg-desc)
+              (or (and-let* ((summary (package-desc-summary pkg-desc))
+                             ((not (equal summary package--default-summary))))
+                    summary)
                   (and-let* ((pkg (cadr (assq name package-archive-contents))))
                     (package-desc-summary pkg))
                   (and main-file (file-exists-p main-file)
-- 
2.47.1


--=-=-=
Content-Type: text/plain




Emacs didn't crash.

In GNU Emacs 31.0.50 (build 1, aarch64-unknown-linux-gnu)
System Description: Debian GNU/Linux 12 (bookworm)

Configured using:
 'configure
 --prefix=/nix/store/4jhcb89gfm6if89074lcha3zb04gibgx-emacs-snapshot
 --disable-build-details --with-modules --with-x=no --with-ns=no
 --with-xpm=no --with-jpeg=no --with-png=no --with-gif=no
 --with-tiff=no'

Configured features:
GMP GNUTLS LIBXML2 MODULES NOTIFY INOTIFY PDUMPER SECCOMP SOUND SQLITE3
THREADS TREE_SITTER

Important settings:
  locale-coding-system: nil

Major mode: Lisp Interaction

Minor modes in effect:
  xterm-mouse-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  minibuffer-regexp-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(cus-edit cus-start cus-load wid-edit rfc2104 cl-extra gnutls
network-stream nsm mailalias smtpmail textsec uni-scripts url url-proxy
url-privacy url-expand url-methods url-history url-cookie
generate-lisp-file url-domsuf url-util url-parse auth-source cl-seq
eieio eieio-core cl-macs icons json map url-vars idna-mapping
ucs-normalize uni-confusable textsec-check thingatpt ispell rx help-mode
tool-bar pp shadow regexp-opt sort mail-extr emacsbug message mailcap
yank-media puny dired dnd dired-loaddefs rfc822 mml mml-sec
password-cache epa derived epg rfc6068 epg-config gnus-util
text-property-search time-date subr-x mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib
sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
xt-mouse term/xterm xterm byte-opt gv bytecomp byte-compile disp-table
rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook
vc-hooks lisp-float-type elisp-mode tabulated-list replace newcomment
text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow
isearch easymenu timer select mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads inotify multi-tty
make-network-process tty-child-frames emacs)

Memory information:
((conses 16 200474 35320) (symbols 48 9592 2) (strings 32 37755 1150)
 (string-bytes 1 686599) (vectors 16 35572)
 (vector-slots 8 415602 35621) (floats 8 46 280) (intervals 56 455 24)
 (buffers 992 14))

--=-=-=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Przemyslaw Kryger <pkryger@HIDDEN>
Subject: bug#76065: Acknowledgement (31.0.50; When package is installed
 with 'package-vc-install' it has default summary)
Message-ID: <handler.76065.B.173872013328886.ack <at> debbugs.gnu.org>
References: <34gt4lbs.fsf@HIDDEN>
X-Gnu-PR-Message: ack 76065
X-Gnu-PR-Package: emacs
Reply-To: 76065 <at> debbugs.gnu.org
Date: Wed, 05 Feb 2025 01:49:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 76065 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
76065: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D76065
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#76065: 31.0.50; When package is installed with 'package-vc-install' it has default summary
References: <34gt4lbs.fsf@HIDDEN>
In-Reply-To: <34gt4lbs.fsf@HIDDEN>
Resent-From: =?UTF-8?Q?Przemys=C5=82aw?= Kryger <pkryger@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 06 Feb 2025 16:08:01 +0000
Resent-Message-ID: <handler.76065.B76065.173885806723028 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 76065 <at> debbugs.gnu.org
From: =?UTF-8?Q?Przemys=C5=82aw?= Kryger <pkryger@HIDDEN>
Date: Thu, 06 Feb 2025 16:07:32 +0000
Message-ID: <m2ed0buke3.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>


For what it's worth, I can force VC installed packages descriptions to
be generated with the following workaround:

(defun pk/package-vc-erase-summary (args)
  "Set summary slot in (car ARGS) to nil."
  (when-let* ((pkg-desc (car args))
              ((package-desc-p pkg-desc))
              ((equal package--default-summary (oref pkg-desc summary))))
    (oset pkg-desc summary nil))
  args)

(with-eval-after-load 'package-vc
  (advice-add 'package-vc--generate-description-file
              :filter-args #'pk/package-vc-erase-summary))

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 11 Feb 2025 07:12:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 11 02:12:42 2025
Received: from localhost ([127.0.0.1]:53884 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1thkRm-0007Gp-Bv
	for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 02:12:42 -0500
Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]:59523)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1thkRk-0007Gb-M7
 for control <at> debbugs.gnu.org; Tue, 11 Feb 2025 02:12:41 -0500
Received: by mail-ed1-x52b.google.com with SMTP id
 4fb4d7f45d1cf-5de6e26db8eso4279324a12.2
 for <control <at> debbugs.gnu.org>; Mon, 10 Feb 2025 23:12:40 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1739257954; x=1739862754; darn=debbugs.gnu.org;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=TirBWfzkHm7YQU4C95ruFdBURxXAwYN1zcmykE9SJoE=;
 b=SIiAFFaAgCCzkvGYJ82S5QZ/JHKCqnYcRFKpcgjP17v143UmOsJdQV/Rvs1Me+TpxF
 tC+pi5bwB6rnKLaRK3X2PzJbRUonBB53HSOQvULZjYwdDzaYzB89Mq/+Um+4hEXujyqU
 biS+swt15BXVuqg8sQZtjp1Zs/P7yOwAnaZfzrpp2SQG4zvSBCYdxRIKiN4tiBXaJVnR
 4h9c2EyjaO0x7G0Os/7pjD8yMnRniKsTzmpizAXhEDcjLbvAQtpnlKJ0GUPWm2GVUxxL
 WrBt+DHNmv15pE6EyqpXSuPVwqzQA8q9CpGiPgF9ILoF2aty6QBFqKb+1TRKRHcRmzXx
 Eekg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1739257954; x=1739862754;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=TirBWfzkHm7YQU4C95ruFdBURxXAwYN1zcmykE9SJoE=;
 b=CFN1AjEMXiFJNXprKkiSiqUhkHCSTssBQb+6iv6pRUNnPnj7IXdY4GzTcJK/Q797JD
 GagBlOxYGbq6SCrA2cbqs4DSVGgC3LLQOCYPmoGRyXuJIta7We06Vq6p4mHfFL32VNVK
 NaEGPXq+3vzgJWizTevPhtv588BjqHwsLT1Ir4IuGcek9HU3MFHNYCuMbXpnudXK9t4A
 dcjFctV56uksXXMualoguZ+p+i548rL7VHx8EIUPA0KXxuqg5FlS3CjGC8tTh4VYCleM
 WwbpsYpUoTLHqL8eWnh3ga2rD4e6/FcAiqTI57l4aYdj/LOsW8fWZGsY8ff5WZkkCFz5
 Z5Ag==
X-Gm-Message-State: AOJu0YyKOiz1k4QiPNMmqmCJPhmSq+P6Z2uXv/2+UTZzR0z6BhPgdV3R
 iK1X9VmNDeOAFGScGILg3Hqe51nrwlRgZ95j4rQ+osUKPv5QR3gVY2pGLpfPsBKV7p5iP55QXyA
 1EJnGLGzf5GNjpvcYbe0hM/71I0bC2zyddJo=
X-Gm-Gg: ASbGncs0ayDiXkLIyeQay25YQiULuecCTErl4F26iWqgsWUa9Jpa5qZrRx+SgsOwVCi
 6nxmR2lwVZjZap/S1EwLfCG23Z+C0tRRGtKd3n9WC0Z4PuC7hMh312AZmavxUprzrKLpv3gYeIw
 ==
X-Google-Smtp-Source: AGHT+IExOY8j/PBl3pS0noyNmL5+AtlwW6E3Gy2y0xlzp5TdOE11u10gzzpqQjkcdvARzVKxhBpgMtIjb9R7eDxsJaU=
X-Received: by 2002:a05:6402:35cb:b0:5de:481a:cbc1 with SMTP id
 4fb4d7f45d1cf-5de481acda0mr15898517a12.16.1739257954280; Mon, 10 Feb 2025
 23:12:34 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Mon, 10 Feb 2025 23:12:33 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
MIME-Version: 1.0
Date: Mon, 10 Feb 2025 23:12:33 -0800
X-Gm-Features: AWEUYZllSSMjXAWQM7snJXG3kLJ4S9n1f7f3zuXdn4qa4m2w4P8QNUzHuu5ortQ
Message-ID: <CADwFkmmZmP-2Y299Ai2ArqYOO+hon2KeP55rC=+CF5KS3zkqSg@HIDDEN>
Subject: control message for bug #76065
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

severity 76065 minor
quit

Last modified: Tue, 11 Feb 2025 07:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.