GNU bug report logs - #76102
[PATCH] services: greetd: Use mkdir-p in activation-script.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76102 in the body.
You can then email your comments to 76102 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dariqq <dariqq <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Dariqq <dariqq <at> posteo.net>
Subject: [PATCH] services: greetd: Use mkdir-p in activation-script.
Date: Thu,  6 Feb 2025 16:50:09 +0000

Reconfiguring a system would fail with guix system: error: mkdir: File exists "/run/user".

* gnu/services/base.scm (greetd-run-user-activation): Replace mkdir with mkdir-p.

Change-Id: I030d1f57c3292c518b3f17061f75258e8a72141c
---
 gnu/services/base.scm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 1f31df1d87..8d710114d1 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -3875,9 +3875,11 @@ (define (greetd-pam-service config)
            pam))))))
 
 (define (greetd-run-user-activation config)
-  #~(let ((d "/run/user"))
-      (mkdir d #o755)
-      (chmod d #o755)))
+  #~(begin
+      (use-modules (guix build utils))
+      (let ((d "/run/user"))
+        (mkdir-p d)
+        (chmod d #o755))))
 
 (define (greetd-shepherd-services config)
   (map

base-commit: 3f76813d82530303881ffdac87de29da92eef880
-- 
2.48.1

Message #8 received at 76102 <at> debbugs.gnu.org (full text, mbox):

From: "Murilo" <murilo <at> disroot.org>
To: "Dariqq" <dariqq <at> posteo.net>, <76102 <at> debbugs.gnu.org>,
 <maxim.cournoyer <at> gmail.com>
Subject: Re: [bug#76102] [PATCH] services: greetd: Use mkdir-p in
 activation-script.
Date: Thu, 06 Feb 2025 15:20:44 -0300

I suggest the commit message description to include the commit which introduced the bug.

My suggestion is to change:

> Reconfiguring a system would fail with guix system: error: mkdir: File exists "/run/user".

to

------
Fixes a bug introduced in ee0d1b144c1572433c9475c32c74d61c3be9c058 where
reconfiguring a system with ‘greetd-service-type’ would fail with:

  guix system: error: mkdir: File exists "/run/user".
------

Other than that, LGTM.

PS: I'm CC'ing Maxim here because they are familiar with [1], which just got
merged, and this seems simple enough to push. Sorry if I shouldn't have.

[1] https://issues.guix.gnu.org/75270

Message #13 received at 76102-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: "Murilo" <murilo <at> disroot.org>
Cc: Dariqq <dariqq <at> posteo.net>, 76102-done <at> debbugs.gnu.org
Subject: Re: [bug#76102] [PATCH] services: greetd: Use mkdir-p in
 activation-script.
Date: Fri, 07 Feb 2025 17:52:15 +0900

Hi,

"Murilo" <murilo <at> disroot.org> writes:

> I suggest the commit message description to include the commit which introduced the bug.
>
> My suggestion is to change:
>
>> Reconfiguring a system would fail with guix system: error: mkdir: File exists "/run/user".
>
> to
>
> ------
> Fixes a bug introduced in ee0d1b144c1572433c9475c32c74d61c3be9c058 where
> reconfiguring a system with ‘greetd-service-type’ would fail with:
>
>   guix system: error: mkdir: File exists "/run/user".
> ------
>
> Other than that, LGTM.

Applied with your suggestion!

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.