GNU logs - #76110, boring messages

Message sent to bug-guix@HIDDEN:

Subject: bug#76110: Broken i686 package on x86_64 since commit 28e4018e59
Resent-From: Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Fri, 07 Feb 2025 00:18:01 +0000
Resent-Message-ID: <handler.76110.B.173888746526414 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 76110 <at> debbugs.gnu.org, ludo@HIDDEN, david.elsing@HIDDEN
Date: Fri, 7 Feb 2025 01:15:41 +0100
From: Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN>
Message-ID: <20250207011541.4eecdd7a@primary_laptop>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/QsFdsRY9eaP9grgCu_taVoJ";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Received-SPF: pass client-ip=2001:678:938:3ff::36;
 envelope-from=GNUtoo@HIDDEN; helo=rockpro64.cyberdimension.org
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)

--Sig_/QsFdsRY9eaP9grgCu_taVoJ
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi,

I run a 32bit version of PostgreSQL that I compile with the package
definition below:
> ;; Copyright (C) 2024 Denis 'GNUtoo' Carikli
> ;; <GNUtoo@HIDDEN>
> ;; This file is free software; you can redistribute it and/or modify
> ;; it under the terms of the GNU General Public License as
> ;; published by the Free Software Foundation; either version 3 of the
> ;; License, or (at your option) any later version.
> ;;
> ;; This file is distributed in the hope that it will be useful, but
> ;; WITHOUT ANY WARRANTY; without even the implied warranty of
> ;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> ;; GNU General Public License for more details.
> ;;
> ;; You should have received a copy of the GNU General Public License
> ;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
>=20
> (define-module (postgresql-i686-linux)
>   #:use-module (gnu packages databases)
>   #:use-module (guix packages)
>   #:use-module (guix utils))
>=20
> (define-public postgresql-14-i686-linux
>   (package
>    (inherit postgresql-14)
>    (name "postgresql-14-i686-linux")
>    (arguments
>     (ensure-keyword-arguments
>      (package-arguments postgresql-14)
>      '(#:system "i686-linux")))))
>=20
> (list postgresql-14-i686-linux)

Here's why it is broken:
> $ guix build -f postgresql-i686-linux.scm
> [...]
> /gnu/store/[...]-postgresql-14-i686-linux-14.13

> $ file /gnu/store/[...]-postgresql-14-i686-linux-14.13/bin/psql
> /gnu/store/[...]-postgresql-14-i686-linux-14.13/bin/psql:
> ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), dynamically
> linked, interpreter
> /gnu/store/[...]-glibc-2.39/lib/ld-linux.so.2,

> $ ls -l /gnu/store/[...]-postgresql-14-i686-linux-14.13/bin/psql
> -r-xr-xr-x 2 root root 674532 Jan  1  1970
> /gnu/store/jb8jdcyf8q4whlczhp76kdgpqs007jz9-postgresql-14-i686-linux-14.1=
3/bin/psql

> $ /gnu/store/[...]-postgresql-14-i686-linux-14.13/bin/psql --help
> bash:
> /gnu/store/jb8jdcyf8q4whlczhp76kdgpqs007jz9-postgresql-14-i686-linux-14.1=
3/bin/psql:
> No such file or directory

Before the commit 28e4018e59d30efb3d52aa950ce2261f11b69b33, the same
command printed the help of the psql program.

So I bisected with the script below (ran manually, not with git bisect
run):

> #!/usr/bin/env bash
> $(guix time-machine \
> --commit=3D$(git show HEAD --no-patch --pretty=3D"%H") -- \
> build -f \
> ~/work/setup/configs/packages/postgresql-i686-linux.scm )/bin/psql
> --help

And the process gave the commit 28e4018e59d30efb3d52aa950ce2261f11b69b33
("grafts: Allow file-like objects in the =E2=80=98replacement=E2=80=99 fiel=
d of
<graft>.").

However I didn't look into how to repair the behavior above as I'm not
familiar at all with the code that the 28e4018e59 patch touches.

Denis.

--Sig_/QsFdsRY9eaP9grgCu_taVoJ
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEeC+d2+Nrp/PU3kkGX138wUF34mMFAmelUK0ACgkQX138wUF3
4mMikQ/+OLpxC82KSSMxjpy5cCdaumN3fYkJ8T1fmrHgtWjNcREPj6SMPH+icWBz
V844jwfOGWZ+F2H5xbLpXlRzx1R0WKyPASwZF8v/OCDH9M1+2BgzUNj630iXyhdL
FraUw7SB7+XA9bryvpG4iIkDRyzb5eGC5GpFtu3byhYI3Bi+Ma0/Pnfw11Rn6woB
9nTvchwsqQXYO1imBKbILtXgPJVDZFWze0ghpQSVqD9D0Jp0vJLpRIFtFMlcvFmN
c1mLa9YXt3a36EKaeTMXG+WHnsZsD9D0wIieoiLgQCqxJQp0Xz45i+S6qFGgZ7cB
Mk74HRDQxbiyxUXm7naloE1RCMJZH+YJQY5TZdl8pM/zSRfNiXT4wBfc7U7IbAZt
rP3zRcDjZi8sAbpuikZeE+g8CrGwSQ1j6bHZh+mayUxMVngs0SX/4SpZ0Ron0Cgg
02yB6VqjndDp2/wJTS+FxZzq3FBieFvqzKRLpVoAlF/s7D9D5dTBaqhzRmb0d0YF
+1pUgKqRAAa0szfTb/JCWmYJRRKWaHxooZaTB0wvCDEcpzQZUUfhweQm2Q++M/HE
pj2766ofZvLGf5+Jp/RTau+SD6LC+Yrqa2JtkXpm0PYqgmp6t7zFx+bNQ8HtjqF4
K5JkAjHBye2lbuVgf7RnsCBVclD6nMICYzl7iNQ87FWnwneHYxc=
=w0bJ
-----END PGP SIGNATURE-----

--Sig_/QsFdsRY9eaP9grgCu_taVoJ--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN>
Subject: bug#76110: Acknowledgement (Broken i686 package on x86_64 since
 commit 28e4018e59)
Message-ID: <handler.76110.B.173888746526414.ack <at> debbugs.gnu.org>
References: <20250207011541.4eecdd7a@primary_laptop>
X-Gnu-PR-Message: ack 76110
X-Gnu-PR-Package: guix
Reply-To: 76110 <at> debbugs.gnu.org
Date: Fri, 07 Feb 2025 00:18:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-guix@HIDDEN

If you wish to submit further information on this problem, please
send it to 76110 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
76110: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D76110
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-guix@HIDDEN:

Subject: bug#76110: Broken i686 package on x86_64 since commit 28e4018e59
Resent-From: David Elsing <david.elsing@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Sat, 08 Feb 2025 13:02:02 +0000
Resent-Message-ID: <handler.76110.B76110.173901970031849 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN>, 76110 <at> debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
From: David Elsing <david.elsing@HIDDEN>
In-Reply-To: <20250207011541.4eecdd7a@primary_laptop>
References: <20250207011541.4eecdd7a@primary_laptop>
Date: Sat, 08 Feb 2025 13:01:26 +0000
Message-ID: <7y1pw8bnfd.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi,

Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN> writes:

> And the process gave the commit 28e4018e59d30efb3d52aa950ce2261f11b69b33
> ("grafts: Allow file-like objects in the =E2=80=98replacement=E2=80=99 fi=
eld of
> <graft>.").
>
> However I didn't look into how to repair the behavior above as I'm not
> familiar at all with the code that the 28e4018e59 patch touches.

The problematic change with commit 28e4018e59 is that the 'system'
argument in `input-graft' (and `system' and `target' in
`input-cross-graft') is no longer respected for the replacement, such
that the 'origin' and 'replacement' fields are built for a different
system. Therefore, I would suggest to indeed add another wrapping by
`with-parameters' to `input-graft' and `input-cross-graft' (but keeping
the `with-parameters' wrapping which sets %grafts in
`graft-derivation/shallow', even if it doesn't do anything yet [2]).

Attached is a patch with the change. Unlike other parameters, for which
`with-parameters' currently does not work with packages [2],
`%current-system' and `%current-target-system' are treated specially and
are working correctly.

However, this still does not really solve the issue for your package:
It still (correctly) calls `package->derivation' with the 'system'
argument set to "x86_64-linux", which is then overridden by the #:system
argument in the system package in `bag->derivation'.
The same is not the case however for grafts, and `graft-derivation*' is
still called with "x86_64-linux", which is arguably correct, but
inconsistent with the #:system package argument. IIUC, this leads to
grafts being missed, as some are calculated for "x86_64-linux" (which
are not applicable) and some for "i686-linux".

For reference, is setting #:system in a package even intended? It seems
more coincidental to me that it works, as the #:system argument of a package
overrides the previous #:system argument in `bag->derivation'.
I think it makes more sense to use `with-parameters', which works
correctly in this case (also without the new patch):

--8<---------------cut here---------------start------------->8---
(with-parameters
    ((%current-system "i686-linux"))
  postgresql-14)
--8<---------------cut here---------------end--------------->8---

Cheers,
David

[1] https://issues.guix.gnu.org/70895
[2] https://issues.guix.gnu.org/75879

--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline; filename=graft-replacement-system.patch

diff --git a/guix/packages.scm b/guix/packages.scm
index 78726b089ae..43125bac61a 100644
--- a/guix/packages.scm
+++ b/guix/packages.scm
@@ -1824,7 +1824,9 @@ (define (input-graft system)
                         (return (graft
                                   (origin orig)
                                   (origin-output output)
-                                  (replacement replacement)
+                                  (replacement
+                                   (with-parameters ((%current-system system))
+                                     replacement))
                                   (replacement-output output))))
                       package output system)
              (return #f))))
@@ -1846,7 +1848,10 @@ (define (input-cross-graft target system)
                (return (graft
                          (origin orig)
                          (origin-output output)
-                         (replacement replacement)
+                         (replacement
+                          (with-parameters ((%current-system system)
+                                            (%current-target-system target))
+                            replacement))
                          (replacement-output output))))
              (return #f))))
       (_

--=-=-=--

Message sent to bug-guix@HIDDEN:

Subject: bug#76110: Broken i686 package on x86_64 since commit 28e4018e59
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Thu, 27 Feb 2025 14:44:02 +0000
Resent-Message-ID: <handler.76110.B76110.17406674058353 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: David Elsing <david.elsing@HIDDEN>
Cc: 76110 <at> debbugs.gnu.org, Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
In-Reply-To: <7y1pw8bnfd.fsf@HIDDEN> (David Elsing's message of "Sat, 08
 Feb 2025 13:01:26 +0000")
References: <20250207011541.4eecdd7a@primary_laptop>
 <7y1pw8bnfd.fsf@HIDDEN>
Date: Thu, 27 Feb 2025 15:43:12 +0100
Message-ID: <871pvjxxbz.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi David,

David Elsing <david.elsing@HIDDEN> skribis:

> diff --git a/guix/packages.scm b/guix/packages.scm
> index 78726b089ae..43125bac61a 100644
> --- a/guix/packages.scm
> +++ b/guix/packages.scm
> @@ -1824,7 +1824,9 @@ (define (input-graft system)
>                          (return (graft
>                                    (origin orig)
>                                    (origin-output output)
> -                                  (replacement replacement)
> +                                  (replacement
> +                                   (with-parameters ((%current-system sy=
stem))
> +                                     replacement))
>                                    (replacement-output output))))
>                        package output system)
>               (return #f))))
> @@ -1846,7 +1848,10 @@ (define (input-cross-graft target system)
>                 (return (graft
>                           (origin orig)
>                           (origin-output output)
> -                         (replacement replacement)
> +                         (replacement
> +                          (with-parameters ((%current-system system)
> +                                            (%current-target-system targ=
et))
> +                            replacement))
>                           (replacement-output output))))

I think we should apply this patch, it makes perfect sense.

And yes, passing #:system in the =E2=80=98arguments=E2=80=99 field is valid=
: it=E2=80=99s used
in a handful of packages.

David, would you be willing/able to send it as a proper patch to
guix-patches, ideally with a test?

Thanks,
Ludo=E2=80=99.

Last modified: Thu, 27 Feb 2025 14:45:03 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.