GNU bug report logs - #76153
[PATCH] gnu: icewm: iAdd icewm.desktop file.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: guix-patches; Reported by: Andy Tai <atai@HIDDEN>; Keywords: patch; Done: Andy Tai <lichengtai@HIDDEN>; Maintainer for guix-patches is guix-patches@HIDDEN.
bug closed, send any further explanations to 76153 <at> debbugs.gnu.org and Andy Tai <atai@HIDDEN> Request was from Andy Tai <lichengtai@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 76153 <at> debbugs.gnu.org:


Received: (at 76153) by debbugs.gnu.org; 2 Mar 2025 06:34:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Mar 02 01:34:30 2025
Received: from localhost ([127.0.0.1]:51507 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tocuD-00036y-VJ
	for submit <at> debbugs.gnu.org; Sun, 02 Mar 2025 01:34:30 -0500
Received: from mail.z572.online ([88.99.160.180]:58302)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <zhengjunjie@HIDDEN>)
 id 1tocu9-00036d-UO
 for 76153 <at> debbugs.gnu.org; Sun, 02 Mar 2025 01:34:27 -0500
Received: from m (mail1.85362086.com [107.174.64.25])
 by mail.z572.online (OpenSMTPD) with ESMTPSA id df957222
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Sun, 2 Mar 2025 06:39:58 +0000 (UTC)
From: Z572 <zhengjunjie@HIDDEN>
To: Andy Tai <atai@HIDDEN>
Subject: Re: [bug#76153] [PATCH v3] gnu: icewm: Add icewm.desktop file.
 patch originally written by =?utf-8?B?55m944GE54aK?= ShiroiKuma retrieved
 from
 https://lists.nongnu.org/archive/html/help-guix/2022-05/msg00114.html
In-Reply-To: <562a500312cab8951e0b015702c33d25d31a66f6.1740894035.git.atai@HIDDEN>
 (Andy Tai's message of "Sat, 1 Mar 2025 21:41:22 -0800")
References: <9a98aea8a4ba530cc59d35f16c989bb298c2c913.1739085365.git.atai@HIDDEN>
 <562a500312cab8951e0b015702c33d25d31a66f6.1740894035.git.atai@HIDDEN>
User-Agent: mu4e 1.12.7; emacs 30.0.92
Date: Sun, 02 Mar 2025 14:34:07 +0800
Message-ID: <87cyf0lz4w.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 1.7 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview: Andy Tai <atai@HIDDEN> writes: > * gnu/packages/wm.scm
 (icewm):
 Add 'install-xsession phase that > installs the icewm.desktop.file so icewm
 can be a choice as a desktop > in gdm (the graphical login screen) > >
 Change-Id: I94661ec1 [...] 
 Content analysis details:   (1.7 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 0.1 URIBL_SBL_A Contains URL's A record listed in the Spamhaus SBL
 blocklist [URIs: ice-wm.org]
 0.6 URIBL_SBL Contains an URL's NS IP listed in the Spamhaus SBL
 blocklist [URIs: ice-wm.org]
 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE:
 The query to Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243
 for more information.
 [88.99.160.180 listed in sa-trusted.bondedsender.org]
 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The
 query to Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243
 for more information.
 [88.99.160.180 listed in bl.score.senderscore.com]
 0.9 SPF_FAIL               SPF: sender does not match SPF record (fail)
 [SPF failed: Please see http://www.openspf.org/Why?s=mfrom;
 id=zhengjunjie%40iscas.ac.cn; ip=88.99.160.180; r=debbugs.gnu.org]
 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
X-Debbugs-Envelope-To: 76153
Cc: 76153 <at> debbugs.gnu.org, mail@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.7 (/)

--=-=-=
Content-Type: text/plain

Andy Tai <atai@HIDDEN> writes:

> * gnu/packages/wm.scm (icewm): Add 'install-xsession phase that
> installs the icewm.desktop.file so icewm can be a choice as a desktop
> in gdm (the graphical login screen)
>
> Change-Id: I94661ec15bccc3bcb1539a52c78cc303a4b5caf3
> ---
>  gnu/packages/wm.scm | 21 ++++++++++++++++++++-
>  1 file changed, 20 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
> index ca79e39c57..126f71ddee 100644
> --- a/gnu/packages/wm.scm
> +++ b/gnu/packages/wm.scm
> @@ -1065,7 +1065,26 @@ (define-public icewm
>                   (lambda _
>                     (substitute* "src/Makefile.in"
>                       (("TESTS = strtest\\$\\(EXEEXT\\)")
> -                      "TESTS = ")))))))
> +                      "TESTS = "))))
> +                   (add-after 'install 'install-xsession
> +                     (lambda* (#:key outputs #:allow-other-keys)
> +                       ;; Add a .desktop file to xsessions.
> +                       (let* ((output (assoc-ref outputs "out"))

use #$output

> +                              (xsessions (string-append output
> +                                                        "/share/xsessions")))
> +                         (mkdir-p xsessions)
> +                         (call-with-output-file (string-append xsessions
> +
> +                                                 "/icewm.desktop")
> +                           (lambda (port)
> +                             (format port
> +                              "[Desktop Entry]~@
> +                            Name=icewm~@
> +                            Comment=IceWM window manager~@
> +                            Exec=~a/bin/icewm~@
> +                            TryExec=~@*~a/bin/icewm~@
> +                            Type=Application~%"
> +                              output)))))))))

please use `make-desktop-entry-file'

>      (home-page "https://ice-wm.org/")
>      (synopsis "Window manager for the X Window System")
>      (description
>
> base-commit: f9dcb84550b85aa816899b2106b1a5ae546167a3

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfr6klGDOXiwIdX/bO1qpk+Gi3/AFAmfD+98ACgkQO1qpk+Gi
3/CFjxAAvTRs/cZ4DDxiTMArXxIrYoC1rnFjw2jbb0ks5kmiedxJdSR5C4m/pOrb
/AffGWY1Pti1iO6UMv0rPbNc6ApdbJ5h1Y2PBHA2/5VU17jblZb3Y/zGvvNpUWvM
h9vc8uOKRyrZYqfxOZW8JySBKYE2ABQKRUF0tKy7wiATGHMwr8kt+WQncVA8qOVr
KsZbedQdfdsx1mIuVDKEamqB8rBIKg17Ar4j098gJ6LAhM0wg5CcucGNwbCyOxrM
wKEMxJnsdSPQnRYm/qHJKucalUHwiJqZ4wvWb2gUHxPqqUJbJHpyxkVydtBe6TxB
M2+G0hf+2Xs6D3dAdGKPcdGr8Agf0p6smDk8gWE1KC2kKsbPKhgO6fTfXoDKwE0A
LPu82c+/9t5OWqiFMJstS0FtI4hGB02BoV4To5QAdHKApN4YveDlJr2dzcz/hExp
NnGsekO9QlSNIgHr/ygmP0g9x0ALqCGJIoo8a5ntTdFOFLxnOREZOwWCznaZjnrk
q/uAUCvtIONuWz0D7j0ZO9kOynwfXJUtYx9saKqNzumlarKdJg4Kc8znHGyFnELu
QYr9HA5mW3Kox8g7pEtHlOu38fI41KuNLlOXFsKVAg0xOlAFXPwpntwKAUsSA/MB
8QY+12ZXByOX6qj2ii+DAV8umKhzXl/P/gP22VzUJM1/XcCQzPs=
=IY12
-----END PGP SIGNATURE-----
--=-=-=--
Information forwarded to guix-patches@HIDDEN:
bug#76153; Package guix-patches. Full text available.

Message received at 76153 <at> debbugs.gnu.org:


Received: (at 76153) by debbugs.gnu.org; 2 Mar 2025 05:41:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Mar 02 00:41:36 2025
Received: from localhost ([127.0.0.1]:50847 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1toc52-00067h-54
	for submit <at> debbugs.gnu.org; Sun, 02 Mar 2025 00:41:36 -0500
Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:53271)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <lichengtai@HIDDEN>)
 id 1toc4z-000676-3c
 for 76153 <at> debbugs.gnu.org; Sun, 02 Mar 2025 00:41:34 -0500
Received: by mail-pl1-x62f.google.com with SMTP id
 d9443c01a7336-2239c066347so6564915ad.2
 for <76153 <at> debbugs.gnu.org>; Sat, 01 Mar 2025 21:41:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1740894087; x=1741498887; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:message-id:date:subject:cc
 :to:from:sender:from:to:cc:subject:date:message-id:reply-to;
 bh=AopQyjEkSZ3072hbeAWPZqydhZSKisfHWqxORx5w/vU=;
 b=LBvS/J7sYR7Sd7n7ofeab8jbU3s2mYmEczXwcTPEQcJLIXyFr1GqdAaSwJL//Fc9JO
 hN6pbZ0e6aYgXWAbKjrU3hFGK08Wc8wflJpIznZfdtI04KJC40m+T10jGrRrXS2fpdDz
 9bYYFwbUbHXr7m9ciJHIWlAi0uIrBs/dL299S1d9k1Ke/JM+jTNfCdtj7n9eOvZzuAxJ
 Nxa9+S0V6DZrp+5WSw9mZ+BkfOvMtZkYYPBGeVIBtiNutUOYxKdOJvshaDJYhSLzIDuM
 UvSOvZlw8CPFWn0O0xYsapky0xxx/I/ucwuICQHNyENE0ekHDpWTEIvpmBFEqBZrbLD2
 60Hw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1740894087; x=1741498887;
 h=content-transfer-encoding:mime-version:message-id:date:subject:cc
 :to:from:sender:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=AopQyjEkSZ3072hbeAWPZqydhZSKisfHWqxORx5w/vU=;
 b=tobHZmLHTGLeWu7G6/as/UOp+TGAZYOQZuNExea7oBBkGg051thlPveKPjqgxV8ki3
 L4EABmDGI3fMiRenBf/5D6R0OVVSIQlrYyWr1eHSxp/XGcFgvTX0fqZmNl0if5U6IVMq
 g7SZA0rIUzXu+ZTez7q8tzOcuvuoWRP/XOuVi7gFfNjXSazsqeLUJJ2VgYrNYFAzoJRc
 yzxMsGmsJlKCUIq/y6ylEUtzaVjPhG5SmkO03jOZay2b5qKKj2cKQhYAn+883iZY0Z5w
 BjV9+0SyMfLwERdI1PmJSL3uAKNs26tVxNLagRgzTvL4fGx5kMqw7bHKKJN0vDXyPY2+
 DMRA==
X-Gm-Message-State: AOJu0YxCyiKBFE2QtdJXwhnG3YMgsTPHuRSd/MQOcqelsOtg/dE8rsAO
 Z317J+JZr8L6bPwXC92UJGIG/+dqAETH3PN++/Aq1TaLLt0ieW1UfEahpg==
X-Gm-Gg: ASbGncvvtI9X2nS4IsURtJdQra0RaiIww0HMoOY0QKYP+6z+PorvxmmId9lpeojHIjl
 jpz2IHGaercqVe5QOuJQkvkZaHIjMY4k0H4ntPllvLt4iEy2QvTD2EcYwiWTnUht4FWrZnTs2vP
 KvL7VMjyjA77RrrAzspW7tXnyH+y2ibD2FWUOafEtvYfYQ7nBfbQH1l8FLeTbG4aqikR5tszXdb
 des77vMU7Nt8ZiJJZiNC1Rr29HGNyuv9OJvw20VWV2ED/hgQyN5UEu1CIpsGuTTR036IxedVe0z
 jbIFgr4+iskC9ElJZMqEXHbpmCA9gDZEt/j9Cf0q
X-Google-Smtp-Source: AGHT+IFWDyko+rg6MeQ3PWpE0gAo9nLvY3zXplWKmkesuVStuUvAR5Me4tlBDOH2eFz9UuJONdxV9g==
X-Received: by 2002:a17:903:2306:b0:216:794f:6d7d with SMTP id
 d9443c01a7336-22369260875mr126359945ad.48.1740894086650; 
 Sat, 01 Mar 2025 21:41:26 -0800 (PST)
Received: from DEskMiniX300.. ([172.98.218.160])
 by smtp.gmail.com with ESMTPSA id
 d9443c01a7336-223505336ecsm56251305ad.244.2025.03.01.21.41.25
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 01 Mar 2025 21:41:26 -0800 (PST)
From: Andy Tai <atai@HIDDEN>
To: 76153 <at> debbugs.gnu.org,
	mail@HIDDEN
Subject: [PATCH v3] =?UTF-8?q?gnu:=20icewm:=20Add=20icewm.desktop=20file.?=
 =?UTF-8?q?=20patch=20originally=20written=20by=20=E7=99=BD=E3=81=84?=
 =?UTF-8?q?=E7=86=8A=20ShiroiKuma=20retrieved=20from=20https://lists.nongn?=
 =?UTF-8?q?u.org/archive/html/help-guix/2022-05/msg00114.html?=
Date: Sat,  1 Mar 2025 21:41:22 -0800
Message-ID: <562a500312cab8951e0b015702c33d25d31a66f6.1740894035.git.atai@HIDDEN>
X-Mailer: git-send-email 2.43.0
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 76153
Cc: Andy Tai <atai@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

* gnu/packages/wm.scm (icewm): Add 'install-xsession phase that
installs the icewm.desktop.file so icewm can be a choice as a desktop
in gdm (the graphical login screen)

Change-Id: I94661ec15bccc3bcb1539a52c78cc303a4b5caf3
---
 gnu/packages/wm.scm | 21 ++++++++++++++++++++-
 1 file changed, 20 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index ca79e39c57..126f71ddee 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -1065,7 +1065,26 @@ (define-public icewm
                  (lambda _
                    (substitute* "src/Makefile.in"
                      (("TESTS = strtest\\$\\(EXEEXT\\)")
-                      "TESTS = ")))))))
+                      "TESTS = "))))
+                   (add-after 'install 'install-xsession
+                     (lambda* (#:key outputs #:allow-other-keys)
+                       ;; Add a .desktop file to xsessions.
+                       (let* ((output (assoc-ref outputs "out"))
+                              (xsessions (string-append output
+                                                        "/share/xsessions")))
+                         (mkdir-p xsessions)
+                         (call-with-output-file (string-append xsessions
+
+                                                 "/icewm.desktop")
+                           (lambda (port)
+                             (format port
+                              "[Desktop Entry]~@
+                            Name=icewm~@
+                            Comment=IceWM window manager~@
+                            Exec=~a/bin/icewm~@
+                            TryExec=~@*~a/bin/icewm~@
+                            Type=Application~%"
+                              output)))))))))
     (home-page "https://ice-wm.org/")
     (synopsis "Window manager for the X Window System")
     (description

base-commit: f9dcb84550b85aa816899b2106b1a5ae546167a3
-- 
2.43.0
Information forwarded to guix-patches@HIDDEN:
bug#76153; Package guix-patches. Full text available.

Message received at 76153 <at> debbugs.gnu.org:


Received: (at 76153) by debbugs.gnu.org; 1 Mar 2025 21:33:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 01 16:33:16 2025
Received: from localhost ([127.0.0.1]:45266 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1toUSS-0004b6-2S
	for submit <at> debbugs.gnu.org; Sat, 01 Mar 2025 16:33:16 -0500
Received: from mira.cbaines.net
 ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]:49365)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1toUSP-0004aa-Fz
 for 76153 <at> debbugs.gnu.org; Sat, 01 Mar 2025 16:33:14 -0500
Received: from localhost (unknown [IPv6:2a02:6b67:e390:8b00::1ce5])
 by mira.cbaines.net (Postfix) with ESMTPSA id 5ABB827BBE2;
 Sat,  1 Mar 2025 21:33:12 +0000 (GMT)
Received: from fang (localhost [127.0.0.1])
 by localhost (OpenSMTPD) with ESMTP id 8129e3f3;
 Sat, 1 Mar 2025 21:33:11 +0000 (UTC)
From: Christopher Baines <mail@HIDDEN>
To: Andy Tai <atai@HIDDEN>
Subject: Re: [bug#76153] [PATCH v2] gnu: icewm: Add icewm.desktop file.
In-Reply-To: <CAJsg1E9VXYOAZLwiWFH07989bJHMH+4=6+tUEDhYCF0ZrA-jcw@HIDDEN>
 (Andy Tai's message of "Sat, 8 Feb 2025 23:24:10 -0800")
References: <97224d956e711613b54fbcffed781a5d503a63e2.1739085587.git.atai@HIDDEN>
 <CAJsg1E9VXYOAZLwiWFH07989bJHMH+4=6+tUEDhYCF0ZrA-jcw@HIDDEN>
Date: Sat, 01 Mar 2025 21:33:09 +0000
Message-ID: <877c58zbai.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 76153
Cc: 76153 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Andy Tai <atai@HIDDEN> writes:

> patch originally written here:
> https://lists.nongnu.org/archive/html/help-guix/2022-05/msg00114.html
>
> by
>
> =E7=99=BD=E3=81=84=E7=86=8A
> ShiroiKuma

I think it would be good to mention this in the commit message, I also
think it's missing why this change is being made, it's unclear to me at
least what this .desktop file enables?

Second thing, re-indenting parts of the package definition is fine, but
it's best to do that in a separate commit, that way the diff will be
clearer.

Thanks,

Chris

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmfDfRVfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XfA7A/+KnWUGrgbcarAqo/PZ7AOOnbibPlHKb7p
ia5FWSdQMfAtjJ6UwMNN8//QYvGDOH2I/AvDR1SdeCQY6mL42GCBfI6PihslJqNp
o525kjgfMZU9b6U+TBDpkNPy4ppI3zrMSLV1mtFrQBoM51nuAJSuxlgMWtntcQTe
+VW9qX5a4zDvb9E2aSLjN2+7RGFWcBB7i7nNXHjTDEVugOd0OXCWMKG4rJx2GtW3
jZERbjnNMiiZVQWH6L7Q1fH+w3ulOqtN7gMd4ALOMX0CljNk6k51M5dNo57X/1Bq
eULGGY4SrsSSBw5GtjnfBMpa9KvRPi4F0u9rqUf+hTfXBSGAd3MqGMMPgm/vagxL
kTCMklxAKT00VSIVPxrmO06gUjqb0AJ93TRSzn8q3TwMH7Ek1kZFNXjMT1sLyYdT
ccFGKIw7iRlIXtZcBnlV32n+ye8iqLqvNY4ZyETH2t/CeC2uKYCm7KHS5bMS1osE
dDuSsc5InNcLg6UZHPGS7EcJUCXryl4812sAH8tFBnXUIDtKqfknkhDw1KZ6t1kj
XiZwwkO44J8vjZk5oej17whWbWCSP2u2lxT6xWk68yXNoi96QD4mUXvjYQQNus5W
IUYIXDp4vp1gNcnOxSNUHy9hC7LlCTikoZIXzJcUFQIY76CRws2x2dMa2kz4+pT9
ocK7IsJFVtk=
=FQpw
-----END PGP SIGNATURE-----
--=-=-=--
Information forwarded to guix-patches@HIDDEN:
bug#76153; Package guix-patches. Full text available.

Message received at 76153 <at> debbugs.gnu.org:


Received: (at 76153) by debbugs.gnu.org; 9 Feb 2025 07:24:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 09 02:24:56 2025
Received: from localhost ([127.0.0.1]:42822 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1th1gW-0006ub-FV
	for submit <at> debbugs.gnu.org; Sun, 09 Feb 2025 02:24:56 -0500
Received: from mail-ua1-x92f.google.com ([2607:f8b0:4864:20::92f]:56669)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <lichengtai@HIDDEN>)
 id 1th1gU-0006uM-0t
 for 76153 <at> debbugs.gnu.org; Sun, 09 Feb 2025 02:24:54 -0500
Received: by mail-ua1-x92f.google.com with SMTP id
 a1e0cc1a2514c-866f414ccedso2023401241.1
 for <76153 <at> debbugs.gnu.org>; Sat, 08 Feb 2025 23:24:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=atai-org.20230601.gappssmtp.com; s=20230601; t=1739085887; x=1739690687;
 darn=debbugs.gnu.org; 
 h=content-transfer-encoding:to:subject:message-id:date:from
 :in-reply-to:references:mime-version:from:to:cc:subject:date
 :message-id:reply-to;
 bh=FIWVfc3xClslbfqObE+hDba19u5TwXoby7ZFKolh3sI=;
 b=ucdHTmD8Cm4rfAZsFEDScABuXd+NdUamRD8C6lz3H9IHNrrHM/7bASIH161/Oq51zY
 65Sv7fOPlXuG3/r2r3sY4jAXK4gEvqQovdSBqIFCc483OXs1c1BW+IpeQgWHvJjH1cbS
 QrIXh6zwbnYgd/1Dr5WOFBr4wTv5JR1GSXxCdV1N6FaMgfxwtIOdIqAUuBMq2Y+PRgFd
 gsbJcHTDzDhGsB43hUbkA8BJ85vfAVSdKdbaZxUA0t200e+4CkUiSDJJ0byd0Zy4Z7M+
 /VeNbJ1M3ztq9EfdcARQ32dX2nAg772Cmqj2DXogVmT3+z2v/EfVCnLsUEH67b6Wijwa
 PpJQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1739085887; x=1739690687;
 h=content-transfer-encoding:to:subject:message-id:date:from
 :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=FIWVfc3xClslbfqObE+hDba19u5TwXoby7ZFKolh3sI=;
 b=WQzeOJYm3dk8X8WleNwe8/xCoO+XdclNdkbTmPLo9tULullrhB/Y9ueNitDZczoRmT
 4AgovnyPbvsYLxF8a+JqcpUWghY95LDX+XeQR5M6dJuZ7e92gmlTY3pkX+LXNjI+iorU
 YqsREe+l2rWIcRlMN7/Jd0RCWSJLUObVryFW/aajSpkybY9ujMtSSLp9/yWYwbYFYBCn
 t7BlfLH0mNJ7BW6arNOGFiWXph6VGi8VdgEf+AQnkoTY3FQJnDQyFVdKJx9LTvM8NlSi
 StZVS4L5XZ29YrgjOkGYRXMMpdzU/F2lliGBChSMVwpOV+ERO8UXy89DoWo8Gk6lG7bn
 ppTA==
X-Gm-Message-State: AOJu0YxRZFCVT8xp9/xJ+rscHVUTi6Iw476Guuv1dpwUlqsv7ipbsr60
 RNVCvBrIk8l7uGq3Q17CxuAoUJxVb5KEq1rX/cNxS834W22h6TgAktUp/aAVDUbHQfOlEzY/cLG
 GEQgDlzVoe4pat6k/9nmN+K1vTh4ClLDM
X-Gm-Gg: ASbGncvtfOnfo0Xxkd37v+EpXMHE2NXkUScYM+pMbUNB8QiKSmawSPOmOrd8xBTr9OT
 teE2lH8ZcFPS20JFPVtGPsEjgE1c1EDS4WM9+QpWLDEiKvGttuYCi1A6YfKDAPDabQc2J05w=
X-Google-Smtp-Source: AGHT+IFdbN2X+FVbiTZKmuoh4Xton0UJemh/ItdRg9sftpOw5ozKeFcKGGbHx+h+iIbP5uJwdJRYfciXk4HuEwX3MMo=
X-Received: by 2002:a05:6102:3fa2:b0:4b1:1eb5:8ee5 with SMTP id
 ada2fe7eead31-4ba85fa2a85mr7544089137.25.1739085886781; Sat, 08 Feb 2025
 23:24:46 -0800 (PST)
MIME-Version: 1.0
References: <97224d956e711613b54fbcffed781a5d503a63e2.1739085587.git.atai@HIDDEN>
In-Reply-To: <97224d956e711613b54fbcffed781a5d503a63e2.1739085587.git.atai@HIDDEN>
From: Andy Tai <atai@HIDDEN>
Date: Sat, 8 Feb 2025 23:24:10 -0800
X-Gm-Features: AWEUYZmkmU8kKtC7aYPHVNadRr2wQcbDhKk4foQ_Aj4PBhauWxBnEcgtYrxztHY
Message-ID: <CAJsg1E9VXYOAZLwiWFH07989bJHMH+4=6+tUEDhYCF0ZrA-jcw@HIDDEN>
Subject: Re: [PATCH v2] gnu: icewm: Add icewm.desktop file.
To: 76153 <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.1 (/)
X-Debbugs-Envelope-To: 76153
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.9 (/)

patch originally written here:
https://lists.nongnu.org/archive/html/help-guix/2022-05/msg00114.html

by

=E7=99=BD=E3=81=84=E7=86=8A
ShiroiKuma
Information forwarded to guix-patches@HIDDEN:
bug#76153; Package guix-patches. Full text available.

Message received at 76153 <at> debbugs.gnu.org:


Received: (at 76153) by debbugs.gnu.org; 9 Feb 2025 07:20:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 09 02:20:36 2025
Received: from localhost ([127.0.0.1]:42812 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1th1cJ-0006mR-VS
	for submit <at> debbugs.gnu.org; Sun, 09 Feb 2025 02:20:36 -0500
Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]:48557)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <lichengtai@HIDDEN>)
 id 1th1cG-0006m9-Ky
 for 76153 <at> debbugs.gnu.org; Sun, 09 Feb 2025 02:20:33 -0500
Received: by mail-pj1-x102b.google.com with SMTP id
 98e67ed59e1d1-2f9bd7c480eso6251164a91.1
 for <76153 <at> debbugs.gnu.org>; Sat, 08 Feb 2025 23:20:32 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1739085626; x=1739690426; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:message-id:date:subject:cc
 :to:from:sender:from:to:cc:subject:date:message-id:reply-to;
 bh=/2Nzsf/FEtcr7zWDlLhj1sXHwZi/lQDT/3F5AjksLsI=;
 b=ll/oyg1Eo4WLB0ctfKN78EzzC/BFMPkDrg9hSHBIU8DU0e2x5FS9ezAunSThd4W5Zr
 pqtavXbexFLwRX1hf696bMm8R5iPk0P/82jSe65ri0W0c/7qz0gvK/A2SeLKw/c3T13o
 cbF+m1AI5tDC6QNnO+9xrhOoEV73VwZFION+5LCvAROcqWAUsIwfcKcNF54wC2siM8i0
 XcHAomkWk8VbpUWbgb7/Qv+pqZzolyYsqW7jk/uh/HbW2a2eadEa3Ze2u0QZ6oNkOxZn
 +asj67L100FLRgdFE4A0hwUnvMUwtFGU1Hn0mymHqSC5OXJ51NsBAt344/Ye+vgKAZDf
 e3bw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1739085626; x=1739690426;
 h=content-transfer-encoding:mime-version:message-id:date:subject:cc
 :to:from:sender:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=/2Nzsf/FEtcr7zWDlLhj1sXHwZi/lQDT/3F5AjksLsI=;
 b=LunAFUw8ekquv51clySyNovQgRYNCPMiUV4GsRu4B+ecg6jiQfsolJ/ZS9Jiti9rdb
 vJUN/FfygqiMsWpCDKH359cPE3GFXnwHYduuMqXviAigOYCQDQBd1HD6X0xTTNH4eqjB
 6Y0+5lNAdvKw33hrJekH+J/euV446jYj0de3Ly7ONnglqg2PGB3DqMgJfT0w6DMfsd4h
 0U6fcLk8QQDRcD2QJuIkScyzqwKP8wghDygLxggfb9o/fpYsBMc6fCaUoKRewp5SqcgG
 vivc1X+1lh4GWaWEQpDko77OceWj95U8LraruYCHTo4L1Krgt7syUqB7VJ7dYGYXhxso
 2HcQ==
X-Gm-Message-State: AOJu0Yzza5v1+IlxjUp04sIkvXr2bz9l5WKGtbC9xuUScQkhgOpz27gf
 vj4kIVA46vBcsYXcQ0fYSCAHZo+xU42KIH2D7UFIrwfQYkwNMFnV6EXqwQ==
X-Gm-Gg: ASbGncv3Q/zjdxhu6shYVtKND+MOIkqmpxA7KRUSFbUFSoQXfp7O6DUCzXpKiR1uzuU
 2l54GmvBmC+4tpuJY9O8EN23eRMkN+Zbyp6tBLucJOtMtaureuwMjEk2ZyK3cQd7hxNjunCQ7U/
 FlQszdEJ7WMdMpX2H3beBookeaoxqyWMqgH+Zc8WF7csBsrT5pimM+UzCC7R4B7O7ItwCBA+gsO
 H6UhpGx5CNy0TGEIIwdGXCX1iZpl7yDrVxhC/rF+aHkMtvseOoJ5YrwGzLVzihExS/M1yGjZ425
 vp+bq8BDZ26Tlc9F2w==
X-Google-Smtp-Source: AGHT+IGvYC+oejv+cL1w1SHjVh7QTtkv3CO09NKmqyPOPKTdzOvhPSZdKOWMQCX4dOlvymI5KLxbeQ==
X-Received: by 2002:a17:90b:3d03:b0:2ea:bf1c:1e3a with SMTP id
 98e67ed59e1d1-2fa24069ec6mr17219578a91.12.1739085626110; 
 Sat, 08 Feb 2025 23:20:26 -0800 (PST)
Received: from localhost.localdomain ([38.84.157.61])
 by smtp.googlemail.com with ESMTPSA id
 98e67ed59e1d1-2fa2716c1ecsm4371005a91.25.2025.02.08.23.20.25
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 08 Feb 2025 23:20:25 -0800 (PST)
From: Andy Tai <atai@HIDDEN>
To: 76153 <at> debbugs.gnu.org
Subject: [PATCH v2] gnu: icewm: Add icewm.desktop file.
Date: Sat,  8 Feb 2025 23:20:21 -0800
Message-ID: <97224d956e711613b54fbcffed781a5d503a63e2.1739085587.git.atai@HIDDEN>
X-Mailer: git-send-email 2.46.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.8 (/)
X-Debbugs-Envelope-To: 76153
Cc: Andy Tai <atai@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.2 (/)

* gnu/packages/wm.scm (icewm): Add 'install-xsession phase that
  installs the icewm.desktop.file.

Change-Id: I94661ec15bccc3bcb1539a52c78cc303a4b5caf3
---
 gnu/packages/wm.scm | 55 ++++++++++++++++++++++++++++++---------------
 1 file changed, 37 insertions(+), 18 deletions(-)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 8aa314e56b..7ce4bb9f34 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -1027,19 +1027,19 @@ (define-public icewm
   (package
     (name "icewm")
     (version "3.6.0")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append
-                    "https://github.com/ice-wm/icewm/releases/download/"
-                    version "/icewm-" version ".tar.lz"))
-              (sha256
-               (base32
-                "0xmw4ilzsc932fxqahxvqix66x940nzf54p5mz5p67rplg9sz7wp"))))
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/ice-wm/icewm/releases/download/" version
+             "/icewm-" version ".tar.lz"))
+       (sha256
+        (base32 "0xmw4ilzsc932fxqahxvqix66x940nzf54p5mz5p67rplg9sz7wp"))))
     (build-system gnu-build-system)
     (native-inputs (list pkg-config))
     (inputs (list fontconfig
                   fribidi
-                  glib                  ;for icewm-menu-fdo
+                  glib ;for icewm-menu-fdo
                   imlib2
                   libice
                   libjpeg-turbo
@@ -1057,15 +1057,34 @@ (define-public icewm
                   lzip
                   perl))
     (arguments
-     (list #:phases
-           #~(modify-phases %standard-phases
-               (add-after 'unpack 'skip-failing-test
-                 ;; strtest.cc tests failing due to $HOME and /etc setup
-                 ;; difference under guix
-                 (lambda _
-                   (substitute* "src/Makefile.in"
-                     (("TESTS = strtest\\$\\(EXEEXT\\)")
-                      "TESTS = ")))))))
+     (list
+      #:phases #~(modify-phases %standard-phases
+                   (add-after 'unpack 'skip-failing-test
+                     ;; strtest.cc tests failing due to $HOME and /etc setup
+                     ;; difference under guix
+                     (lambda _
+                       (substitute* "src/Makefile.in"
+                         (("TESTS = strtest\\$\\(EXEEXT\\)")
+                          "TESTS = "))))
+                   (add-after 'install 'install-xsession
+                     (lambda* (#:key outputs #:allow-other-keys)
+                       ;; Add a .desktop file to xsessions.
+                       (let* ((output (assoc-ref outputs "out"))
+                              (xsessions (string-append output
+                                                        "/share/xsessions")))
+                         (mkdir-p xsessions)
+                         (call-with-output-file (string-append xsessions
+
+                                                 "/icewm.desktop")
+                           (lambda (port)
+                             (format port
+                              "[Desktop Entry]~@
+                            Name=icewm~@
+                            Comment=IceWM window manager~@
+                            Exec=~a/bin/icewm~@
+                            TryExec=~@*~a/bin/icewm~@
+                            Type=Application~%"
+                              output)))))))))
     (home-page "https://ice-wm.org/")
     (synopsis "Window manager for the X Window System")
     (description

base-commit: fd3876ec2a47909eac8e7fa0f24710a94ccb1459
-- 
2.46.0
Information forwarded to guix-patches@HIDDEN:
bug#76153; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 9 Feb 2025 07:16:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 09 02:16:43 2025
Received: from localhost ([127.0.0.1]:42793 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1th1YZ-0006Yt-H6
	for submit <at> debbugs.gnu.org; Sun, 09 Feb 2025 02:16:43 -0500
Received: from lists.gnu.org ([2001:470:142::17]:40346)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <lichengtai@HIDDEN>)
 id 1th1YX-0006Yc-Dy
 for submit <at> debbugs.gnu.org; Sun, 09 Feb 2025 02:16:42 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <lichengtai@HIDDEN>)
 id 1th1YR-00062L-LF
 for guix-patches@HIDDEN; Sun, 09 Feb 2025 02:16:35 -0500
Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <lichengtai@HIDDEN>)
 id 1th1YP-0003hD-DM
 for guix-patches@HIDDEN; Sun, 09 Feb 2025 02:16:35 -0500
Received: by mail-pl1-x62f.google.com with SMTP id
 d9443c01a7336-21f53ad05a0so31212315ad.3
 for <guix-patches@HIDDEN>; Sat, 08 Feb 2025 23:16:32 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1739085391; x=1739690191; darn=gnu.org;
 h=content-transfer-encoding:mime-version:message-id:date:subject:cc
 :to:from:sender:from:to:cc:subject:date:message-id:reply-to;
 bh=/2Nzsf/FEtcr7zWDlLhj1sXHwZi/lQDT/3F5AjksLsI=;
 b=H26mWJMV0CzUPsao5WPFW/VHmB1ixDkXYI/Et1lpu3MrkKZI3y7hfXdFIqbjQPN04+
 YVEoUL3qhKzY39ABrQjGRmXbMRDjJaVzXXSFZAyxn9MsLi65wlesbBZjeboFFkENb4oo
 gT3wqUF5cZg9WV+Y9HIYx6SarEb5PRxqVnXPsosusBrbXBhe5fxoWLOkW7ye6UnuXbE6
 PbftE01u8Z+iyLYpsso44uc2fq1DisaSrKH1PkAZJR3xccHC7KJNev010ADDsqD7cU73
 diqfpS+vAY3Ca2bST+bJd9KbVIAYhHXozQ0vdj/cZRbAYd8SG+z+Uv7tSqf94TZbZxzc
 Z8OQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1739085391; x=1739690191;
 h=content-transfer-encoding:mime-version:message-id:date:subject:cc
 :to:from:sender:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=/2Nzsf/FEtcr7zWDlLhj1sXHwZi/lQDT/3F5AjksLsI=;
 b=pdKmXkj3qCKVQLo4MEKV9XfcvplSjp4maqLTY70kRf9WWhChKwr7VOzEbD3t9Vfi49
 g4tp0XwEKA6aVaVbIG5HygERzZC53cvu40zE7Zycg/0fuQVynkwt25ShB4QiOyWwGLef
 jGeBFlE8PkXJkfVqSXtkK8Pv0+uqk2ltn5L1nLstB7nLTN8aje+z0J330ia6uUVKH0JO
 PULQs4RJFcgh3or/pHH2Is1LWJkCjJSNXIsYFhVAslWDJ2dftsO1T/m3UMRBwcomMfTZ
 wkXgg0Fqr0tk+Km0PFjpebtbMywfPavAc/vluMuW0iBEz0iY3cQZcz/iLXP8F6GaodvG
 OI1g==
X-Gm-Message-State: AOJu0YzVCab7R9WA+l/uD+Dan5d18KPdXBUv1DGxfZ8KIk6/ujvgobCa
 hDRpniK0aeVCpyO6Gz65g4Q/6+olq6eP9QdFiOZIUXqwqF+wLoVcQvS5DQ==
X-Gm-Gg: ASbGncswObUdjcw2r4jxYJFpcmk03xuxWZeDivz/kLwIuW0XYn9eb8naAaDuAS97JTy
 3Ls58zuWlS3DE58Kec8tYU0RqXvc8WxrUiSp0jj/iM7nsGwAQSWIfGYOJR5O/cHmtJWafI0+8VH
 1n5VyGMascgGojigJUuO3AVudPMua8Tx9ayq5WzA6JEkYyPRb/Idk7G3mlRX1kpzY/6blmv2hZq
 t3aLjmHGjhbq5FuDiCpaMAeoLt4C8NWqEOrgyONqqCzvvbSpDEGeRa/vVCmIWTQcoQndcI1yzRq
 3tONddDexizb43eFRg==
X-Google-Smtp-Source: AGHT+IGTUc2zN2wiBpGV7a0YMHcH2IhgWUmvR8Q2gKXlv+FWZIUzI2TNvmGwZum3CgTfTGTvvfVJaw==
X-Received: by 2002:a05:6a21:170f:b0:1e0:c56f:7daf with SMTP id
 adf61e73a8af0-1ee03a21dddmr16836310637.6.1739085390888; 
 Sat, 08 Feb 2025 23:16:30 -0800 (PST)
Received: from localhost.localdomain ([38.84.157.61])
 by smtp.googlemail.com with ESMTPSA id
 41be03b00d2f7-ad5498dac9asm746826a12.66.2025.02.08.23.16.29
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 08 Feb 2025 23:16:30 -0800 (PST)
From: Andy Tai <atai@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: icewm: iAdd icewm.desktop file.
Date: Sat,  8 Feb 2025 23:16:24 -0800
Message-ID: <9a98aea8a4ba530cc59d35f16c989bb298c2c913.1739085365.git.atai@HIDDEN>
X-Mailer: git-send-email 2.46.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2607:f8b0:4864:20::62f;
 envelope-from=lichengtai@HIDDEN; helo=mail-pl1-x62f.google.com
X-Spam_score_int: -17
X-Spam_score: -1.8
X-Spam_bar: -
X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001,
 FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.07,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 URIBL_SBL_A=0.1 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.8 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  * gnu/packages/wm.scm (icewm): Add 'install-xsession phase
 that installs the icewm.desktop.file. Change-Id:
 I94661ec15bccc3bcb1539a52c78cc303a4b5caf3
 --- gnu/packages/wm.scm | 55 ++++++++++++++++++++++++++++++ 1 file changed,
 37 insertions(+), 18 deletions(-) 
 Content analysis details:   (1.8 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 1.0 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
 no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org]
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 0.1 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
 mail domains are different
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (lichengtai[at]gmail.com)
 0.1 URIBL_SBL_A Contains URL's A record listed in the Spamhaus SBL
 blocklist [URIs: ice-wm.org]
 0.6 URIBL_SBL Contains an URL's NS IP listed in the Spamhaus SBL
 blocklist [URIs: ice-wm.org]
 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and
 EnvelopeFrom freemail headers are different
X-Debbugs-Envelope-To: submit
Cc: Andy Tai <atai@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.8 (/)

* gnu/packages/wm.scm (icewm): Add 'install-xsession phase that
  installs the icewm.desktop.file.

Change-Id: I94661ec15bccc3bcb1539a52c78cc303a4b5caf3
---
 gnu/packages/wm.scm | 55 ++++++++++++++++++++++++++++++---------------
 1 file changed, 37 insertions(+), 18 deletions(-)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 8aa314e56b..7ce4bb9f34 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -1027,19 +1027,19 @@ (define-public icewm
   (package
     (name "icewm")
     (version "3.6.0")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append
-                    "https://github.com/ice-wm/icewm/releases/download/"
-                    version "/icewm-" version ".tar.lz"))
-              (sha256
-               (base32
-                "0xmw4ilzsc932fxqahxvqix66x940nzf54p5mz5p67rplg9sz7wp"))))
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/ice-wm/icewm/releases/download/" version
+             "/icewm-" version ".tar.lz"))
+       (sha256
+        (base32 "0xmw4ilzsc932fxqahxvqix66x940nzf54p5mz5p67rplg9sz7wp"))))
     (build-system gnu-build-system)
     (native-inputs (list pkg-config))
     (inputs (list fontconfig
                   fribidi
-                  glib                  ;for icewm-menu-fdo
+                  glib ;for icewm-menu-fdo
                   imlib2
                   libice
                   libjpeg-turbo
@@ -1057,15 +1057,34 @@ (define-public icewm
                   lzip
                   perl))
     (arguments
-     (list #:phases
-           #~(modify-phases %standard-phases
-               (add-after 'unpack 'skip-failing-test
-                 ;; strtest.cc tests failing due to $HOME and /etc setup
-                 ;; difference under guix
-                 (lambda _
-                   (substitute* "src/Makefile.in"
-                     (("TESTS = strtest\\$\\(EXEEXT\\)")
-                      "TESTS = ")))))))
+     (list
+      #:phases #~(modify-phases %standard-phases
+                   (add-after 'unpack 'skip-failing-test
+                     ;; strtest.cc tests failing due to $HOME and /etc setup
+                     ;; difference under guix
+                     (lambda _
+                       (substitute* "src/Makefile.in"
+                         (("TESTS = strtest\\$\\(EXEEXT\\)")
+                          "TESTS = "))))
+                   (add-after 'install 'install-xsession
+                     (lambda* (#:key outputs #:allow-other-keys)
+                       ;; Add a .desktop file to xsessions.
+                       (let* ((output (assoc-ref outputs "out"))
+                              (xsessions (string-append output
+                                                        "/share/xsessions")))
+                         (mkdir-p xsessions)
+                         (call-with-output-file (string-append xsessions
+
+                                                 "/icewm.desktop")
+                           (lambda (port)
+                             (format port
+                              "[Desktop Entry]~@
+                            Name=icewm~@
+                            Comment=IceWM window manager~@
+                            Exec=~a/bin/icewm~@
+                            TryExec=~@*~a/bin/icewm~@
+                            Type=Application~%"
+                              output)))))))))
     (home-page "https://ice-wm.org/")
     (synopsis "Window manager for the X Window System")
     (description

base-commit: fd3876ec2a47909eac8e7fa0f24710a94ccb1459
-- 
2.46.0
Acknowledgement sent to Andy Tai <atai@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#76153; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 3 Mar 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.