GNU bug report logs - #76339
[PATCH core-updates-team 0/4] Update libde265 and remove dependency on qtbase-5.

Previous Next

Package: guix-patches;

Reported by: Vinicius Monego <monego <at> posteo.net>

Date: Sun, 16 Feb 2025 14:59:01 UTC

Severity: normal

Tags: patch

To reply to this bug, email your comments to 76339 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#76339; Package guix-patches. (Sun, 16 Feb 2025 14:59:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Vinicius Monego <monego <at> posteo.net>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 16 Feb 2025 14:59:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH core-updates-team 0/4] Update libde265 and remove dependency
 on qtbase-5.
Date: Sun, 16 Feb 2025 14:56:31 +0000
This series updates and removes the unused inputs of qtbase-5 on libde265. Removing this input would clear a transitive dependency of 400+ packages on qtbase-5, so I am sending this to core-updates-team but it could be pushed to master if wanted.

As said in the commit message, qtbase-5 is a dependency for 'sherlock265', a h265 developer tool. It was not being built already because it depends on either libvideogfx or
libswscale, and is not useful for dependent packages which only link the library.

Vinicius Monego (4):
  gnu: libde265: Remove dependency on qtbase-5.
  libde265: Remove package labels.
  gnu: libde265: Update to 1.0.15.
  gnu: libde265: Use G-Expressions.

 gnu/packages/video.scm | 20 ++++++--------------
 1 file changed, 6 insertions(+), 14 deletions(-)


base-commit: b4dc8eb4adff9d824ff7df704e134964b3b47396
-- 
2.48.1





Information forwarded to guix-patches <at> gnu.org:
bug#76339; Package guix-patches. (Sun, 16 Feb 2025 15:05:01 GMT) Full text and rfc822 format available.

Message #8 received at 76339 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: 76339 <at> debbugs.gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH core-updates-team 1/4] gnu: libde265: Remove dependency on
 qtbase-5.
Date: Sun, 16 Feb 2025 15:04:01 +0000
This is a dependency for 'sherlock265', a h265 developer tool. It was
not being built already because it depends on either libvideogfx or
libswscale.

* gnu/packages/video.scm (libde265)[inputs]: Remove qtbase-5.

Change-Id: Iaf9d71cb701f4f9c51cbc3181c9b0a87353736fd
---
 gnu/packages/video.scm | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 9863ee9f39..a23b5b27d3 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -718,10 +718,7 @@ (define-public libde265
        ("pkg-config" ,pkg-config)
        ("python" ,python-wrapper)))
     (inputs
-     `(;; XXX: Build fails with libvideogfx.
-       ;; ("libvideogfx" ,libvideogfx)
-       ("qt" ,qtbase-5)
-       ("sdl" ,sdl)))
+     `(("sdl" ,sdl)))
     (synopsis "H.265 video codec implementation")
     (description "Libde265 is an implementation of the h.265 video codec.  It is
 written from scratch and has a plain C API to enable a simple integration into

base-commit: b4dc8eb4adff9d824ff7df704e134964b3b47396
-- 
2.48.1





Information forwarded to guix-patches <at> gnu.org:
bug#76339; Package guix-patches. (Sun, 16 Feb 2025 15:05:02 GMT) Full text and rfc822 format available.

Message #11 received at 76339 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: 76339 <at> debbugs.gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH core-updates-team 2/4] gnu: libde265: Remove package labels.
Date: Sun, 16 Feb 2025 15:04:02 +0000
* gnu/packages/video.scm (libde265)[native-inputs, inputs]: Remove
package labels.

Change-Id: I9e0fb470ed1b2644edd1114dfae6f1dcd2ed3fe5
---
 gnu/packages/video.scm | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index a23b5b27d3..436a170894 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -712,13 +712,8 @@ (define-public libde265
      `(#:configure-flags
        (list "--disable-static")))
     (native-inputs
-     `(("autoconf" ,autoconf)
-       ("automake" ,automake)
-       ("libtool" ,libtool)
-       ("pkg-config" ,pkg-config)
-       ("python" ,python-wrapper)))
-    (inputs
-     `(("sdl" ,sdl)))
+     (list autoconf automake libtool pkg-config python-wrapper))
+    (inputs (list sdl))
     (synopsis "H.265 video codec implementation")
     (description "Libde265 is an implementation of the h.265 video codec.  It is
 written from scratch and has a plain C API to enable a simple integration into
-- 
2.48.1





Information forwarded to guix-patches <at> gnu.org:
bug#76339; Package guix-patches. (Sun, 16 Feb 2025 15:05:03 GMT) Full text and rfc822 format available.

Message #14 received at 76339 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: 76339 <at> debbugs.gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH core-updates-team 3/4] gnu: libde265: Update to 1.0.15.
Date: Sun, 16 Feb 2025 15:04:03 +0000
* gnu/packages/video.scm (libde265): Update to 1.0.15.
[inputs]: Replace sdl by sdl2.

Change-Id: I2f84b050c86ce01005beda8d233bee4e03c34ce1
---
 gnu/packages/video.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 436a170894..2b79e78491 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -696,7 +696,7 @@ (define-public libvideogfx
 (define-public libde265
   (package
     (name "libde265")
-    (version "1.0.8")
+    (version "1.0.15")
     (source
      (origin
        (method git-fetch)
@@ -706,14 +706,14 @@ (define-public libde265
          (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1dzflqbk248lz5ws0ni5acmf32b3rmnq5gsfaz7691qqjxkl1zml"))))
+        (base32 "09pk079figmdrnyj5wi99j7pnmmk3c2s30lpmas96ysdhhrqps42"))))
     (build-system gnu-build-system)
     (arguments
      `(#:configure-flags
        (list "--disable-static")))
     (native-inputs
      (list autoconf automake libtool pkg-config python-wrapper))
-    (inputs (list sdl))
+    (inputs (list sdl2))
     (synopsis "H.265 video codec implementation")
     (description "Libde265 is an implementation of the h.265 video codec.  It is
 written from scratch and has a plain C API to enable a simple integration into
-- 
2.48.1





Information forwarded to guix-patches <at> gnu.org:
bug#76339; Package guix-patches. (Sun, 16 Feb 2025 15:05:03 GMT) Full text and rfc822 format available.

Message #17 received at 76339 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: 76339 <at> debbugs.gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH core-updates-team 4/4] gnu: libde265: Use G-Expressions.
Date: Sun, 16 Feb 2025 15:04:04 +0000
* gnu/packages/video.scm (libde265)[arguments]: Use G-Expressions.

Change-Id: Ie93df560f0d784d3ff983884860c88b5fce6f7b0
---
 gnu/packages/video.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 2b79e78491..3a98872b7f 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -709,8 +709,8 @@ (define-public libde265
         (base32 "09pk079figmdrnyj5wi99j7pnmmk3c2s30lpmas96ysdhhrqps42"))))
     (build-system gnu-build-system)
     (arguments
-     `(#:configure-flags
-       (list "--disable-static")))
+     (list
+      #:configure-flags #~(list "--disable-static")))
     (native-inputs
      (list autoconf automake libtool pkg-config python-wrapper))
     (inputs (list sdl2))
-- 
2.48.1





Information forwarded to guix-patches <at> gnu.org:
bug#76339; Package guix-patches. (Sun, 16 Feb 2025 16:22:01 GMT) Full text and rfc822 format available.

Message #20 received at 76339 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: Vinicius Monego <monego <at> posteo.net>, 76339 <at> debbugs.gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>, liliana.prikler <at> gmail.com,
 maxim.cournoyer <at> gmail.com
Subject: Re: [bug#76339] [PATCH core-updates-team 0/4] Update libde265 and
 remove dependency on qtbase-5.
Date: Sun, 16 Feb 2025 17:21:21 +0100
On 2025-02-16 14:56, Vinicius Monego wrote:

> This series updates and removes the unused inputs of qtbase-5 on
> libde265. Removing this input would clear a transitive dependency of
> 400+ packages on qtbase-5, so I am sending this to core-updates-team
> but it could be pushed to master if wanted.

Hi Vinicius,

I made a similar commit in 74517 that should be (haven't checked)
applied in the gnome-team branch.

-- 
Best regards,
Nicolas Graves




Information forwarded to guix-patches <at> gnu.org:
bug#76339; Package guix-patches. (Mon, 17 Feb 2025 23:13:01 GMT) Full text and rfc822 format available.

Message #23 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org>
Cc: 76339 <at> debbugs.gnu.org, Vinicius Monego <monego <at> posteo.net>,
 liliana.prikler <at> gmail.com, maxim.cournoyer <at> gmail.com
Subject: Re: [bug#76339] [PATCH core-updates-team 0/4] Update libde265 and
 remove dependency on qtbase-5.
Date: Mon, 17 Feb 2025 18:12:28 -0500
On Sun, Feb 16, 2025 at 05:21:21PM +0100, Nicolas Graves via Guix-patches via wrote:
> On 2025-02-16 14:56, Vinicius Monego wrote:
> 
> > This series updates and removes the unused inputs of qtbase-5 on
> > libde265. Removing this input would clear a transitive dependency of
> > 400+ packages on qtbase-5, so I am sending this to core-updates-team
> > but it could be pushed to master if wanted.
> 
> Hi Vinicius,
> 
> I made a similar commit in 74517 that should be (haven't checked)
> applied in the gnome-team branch.

Okay Nicolas, gnome-team sounds fine to me.

Vinicius, we are no longer using a core-updates branch, and I don't
there is no core-updates-team. See here for the new workflow:

https://guix.gnu.org/manual/devel/en/html_node/Managing-Patches-and-Branches.html

There is a 'core-packages' team, but that's for packages that are truly
at the root of the dependency graph:

https://git.savannah.gnu.org/cgit/guix.git/tree/etc/teams.scm?id=e4b54095cbe377ea526719b3d5dcc619e111aa2a#n490

Maybe we should make a 'media' team that would handle things like video
codecs, as they tend to trigger a lot of rebuilds these days, and they
don't really fit anywhere else.




Information forwarded to guix-patches <at> gnu.org:
bug#76339; Package guix-patches. (Mon, 17 Feb 2025 23:13:03 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#76339; Package guix-patches. (Tue, 18 Feb 2025 06:55:02 GMT) Full text and rfc822 format available.

Message #29 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 76339 <at> debbugs.gnu.org, Vinicius Monego <monego <at> posteo.net>,
 liliana.prikler <at> gmail.com,
 Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org>
Subject: Re: [bug#76339] [PATCH core-updates-team 0/4] Update libde265 and
 remove dependency on qtbase-5.
Date: Tue, 18 Feb 2025 15:53:40 +0900
Hi Leo,

Leo Famulari <leo <at> famulari.name> writes:

> On Sun, Feb 16, 2025 at 05:21:21PM +0100, Nicolas Graves via Guix-patches via wrote:
>> On 2025-02-16 14:56, Vinicius Monego wrote:
>> 
>> > This series updates and removes the unused inputs of qtbase-5 on
>> > libde265. Removing this input would clear a transitive dependency of
>> > 400+ packages on qtbase-5, so I am sending this to core-updates-team
>> > but it could be pushed to master if wanted.
>> 
>> Hi Vinicius,
>> 
>> I made a similar commit in 74517 that should be (haven't checked)
>> applied in the gnome-team branch.
>
> Okay Nicolas, gnome-team sounds fine to me.
>
> Vinicius, we are no longer using a core-updates branch, and I don't
> there is no core-updates-team. See here for the new workflow:
>
> https://guix.gnu.org/manual/devel/en/html_node/Managing-Patches-and-Branches.html
>
> There is a 'core-packages' team, but that's for packages that are truly
> at the root of the dependency graph:
>
> https://git.savannah.gnu.org/cgit/guix.git/tree/etc/teams.scm?id=e4b54095cbe377ea526719b3d5dcc619e111aa2a#n490
>
> Maybe we should make a 'media' team that would handle things like video
> codecs, as they tend to trigger a lot of rebuilds these days, and they
> don't really fit anywhere else.

I think Nicolas knows that given their subject prefix is
'core-updates-TEAM', and using it simply as a hint that this causes a
large rebuild.  We don't have this documented yet, but it makes sense to
communicate this information to help avoiding inadvertently merging
large changes to the main branch.

-- 
Thanks,
Maxim




Information forwarded to guix-patches <at> gnu.org:
bug#76339; Package guix-patches. (Tue, 18 Feb 2025 06:55:03 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#76339; Package guix-patches. (Tue, 18 Feb 2025 19:07:01 GMT) Full text and rfc822 format available.

Message #35 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Leo Famulari" <leo <at> famulari.name>
To: "Maxim Cournoyer" <maxim.cournoyer <at> gmail.com>
Cc: 76339 <at> debbugs.gnu.org, Vinicius Monego <monego <at> posteo.net>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org>
Subject: Re: [bug#76339] [PATCH core-updates-team 0/4] Update libde265 and
 remove dependency on qtbase-5.
Date: Tue, 18 Feb 2025 14:05:36 -0500
On Tue, Feb 18, 2025, at 01:53, Maxim Cournoyer wrote:
> Leo Famulari <leo <at> famulari.name> writes:
>> Vinicius, we are no longer using a core-updates branch, and I don't
>> there is no core-updates-team. See here for the new workflow:
> I think Nicolas knows that given their subject prefix is
> 'core-updates-TEAM', and using it simply as a hint that this causes a
> large rebuild.  We don't have this documented yet, but it makes sense to
> communicate this information to help avoiding inadvertently merging
> large changes to the main branch.

I had meant to write "I don't think there is a core-updates-team".

Sorry for the confusion.




Information forwarded to guix-patches <at> gnu.org:
bug#76339; Package guix-patches. (Tue, 18 Feb 2025 19:07:01 GMT) Full text and rfc822 format available.

This bug report was last modified 13 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.