GNU logs - #76355, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#76355: [PATCH] Add new minor mode for clear whitespaces on save.
Resent-From: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= <eg642616@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 17 Feb 2025 00:02:01 +0000
Resent-Message-ID: <handler.76355.B.17397504942366 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 76355 <at> debbugs.gnu.org
From: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= <eg642616@HIDDEN>
Date: Sun, 16 Feb 2025 18:00:56 -0600
Message-ID: <874j0th22v.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=2607:f8b0:4864:20::344;
 envelope-from=eg642616@HIDDEN; helo=mail-ot1-x344.google.com
X-Spam_score_int: -17
X-Spam_score: -1.8
X-Spam_bar: -
X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 2.5 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview: Tags: patch This feature adds a minor mode (and global) for
 clean whitespaces in current file/buffer on save. I know that already exists
 the option 'auto-cleanup' in whitespace-action that does the same, however,
 it just depends on the whitespace-mode, so if i turn-off whitespace-mode
 auto-cleanup won't work. 
 Content analysis details:   (2.5 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
 no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org]
 1.0 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends
 in digit (eg642616[at]gmail.com)
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (eg642616[at]gmail.com)
 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS
 0.0 SPOOFED_FREEMAIL_NO_RDNS From SPOOFED_FREEMAIL and no rDNS
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.5 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  Tags: patch This feature adds a minor mode (and global) for
    clean whitespaces in current file/buffer on save. I know that already exists
    the option 'auto-cleanup' in whitespace-action that does the same, however,
    it just depends on the whitespace-mode, so if i turn-off whitespace-mode
   auto-cleanup won't work. 
 
 Content analysis details:   (1.5 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
                              no trust
                             [2001:470:142:0:0:0:0:17 listed in]
                             [list.dnswl.org]
  1.0 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
  0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends
                             in digit (eg642616[at]gmail.com)
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider (eg642616[at]gmail.com)
  1.3 RDNS_NONE              Delivered to internal network by a host with no rDNS
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager
  0.0 SPOOFED_FREEMAIL_NO_RDNS From SPOOFED_FREEMAIL and no rDNS

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Tags: patch

This feature adds a minor mode (and global) for clean whitespaces in
current file/buffer on save.

I know that already exists the option 'auto-cleanup' in
whitespace-action that does the same, however, it just depends on the
whitespace-mode, so if i turn-off whitespace-mode auto-cleanup won't
work.

Also I know there's already a package on MELPA that does something like
this, however i think this kind of functionality must be included in
Emacs so I did my own implementation.

This patch is just a working prototype, and I want to know if there is
interest in this so I can polish it.


In GNU Emacs 31.0.50 (build 1, x86_64-redhat-linux-gnu, GTK+ Version
 3.24.43, cairo version 1.18.2) of 2025-02-03 built on
 49a55a317a644839ad7d857f65aa5be0
System Description: Fedora Linux 41 (Workstation Edition)

Configured using:
 'configure --build=3Dx86_64-redhat-linux --host=3Dx86_64-redhat-linux --pr=
ogram-prefix=3D --disable-dependency-tracking --prefix=3D/usr --exec-prefix=
=3D/usr --bindir=3D/usr/bin --sbindir=3D/usr/sbin --sysconfdir=3D/etc --dat=
adir=3D/usr/share --includedir=3D/usr/include --libdir=3D/usr/lib64 --libex=
ecdir=3D/usr/libexec --localstatedir=3D/var --runstatedir=3D/run --sharedst=
atedir=3D/var/lib --mandir=3D/usr/share/man --infodir=3D/usr/share/info --w=
ith-cairo --with-dbus --with-gif --with-gpm=3Dno --with-harfbuzz --with-jpe=
g --with-modules --with-native-compilation=3Daot --with-pgtk --with-png --w=
ith-rsvg --with-sqlite3 --with-tiff --with-tree-sitter --with-webp --with-x=
pm build_alias=3Dx86_64-redhat-linux host_alias=3Dx86_64-redhat-linux CC=3D=
gcc 'CFLAGS=3D-DMAIL_USE_LOCKF -O2 -flto=3Dauto -ffat-lto-objects -fexcepti=
ons -g -grecord-gcc-switches -pipe -Wall -Werror=3Dformat-security -Wp,-U_F=
ORTIFY_SOURCE,-D_FORTIFY_SOURCE=3D3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=3D/usr=
/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=3D/usr/=
lib/rpm/redhat/redhat-annobin-cc1  -m64 -march=3Dx86-64 -mtune=3Dgeneric -f=
asynchronous-unwind-tables -fstack-clash-protection -fcf-protection -mtls-d=
ialect=3Dgnu2 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer ' 'LDFLA=
GS=3D-Wl,-z,relro -Wl,--as-needed  -Wl,-z,pack-relative-relocs -Wl,-z,now -=
specs=3D/usr/lib/rpm/redhat/redhat-hardened-ld -specs=3D/usr/lib/rpm/redhat=
/redhat-annobin-cc1  -Wl,--build-id=3Dsha1 -specs=3D/usr/lib/rpm/redhat/red=
hat-package-notes ' CXX=3Dg++ 'CXXFLAGS=3D-O2 -flto=3Dauto -ffat-lto-object=
s -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=3Dformat-securi=
ty -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3D3 -Wp,-D_GLIBCXX_ASSERTIONS -s=
pecs=3D/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -sp=
ecs=3D/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -march=3Dx86-64 -mtune=
=3Dgeneric -fasynchronous-unwind-tables -fstack-clash-protection -fcf-prote=
ction -mtls-dialect=3Dgnu2 -fno-omit-frame-pointer -mno-omit-leaf-frame-poi=
nter ' PKG_CONFIG_PATH=3D:/usr/lib64/pkgconfig:/usr/share/pkgconfig'


--=-=-=
Content-Type: text/patch
Content-Disposition: attachment;
 filename=0001-Add-new-minor-mode-for-clear-whitespaces-on-save.patch

From 894a27e270373db41674ba6bc460fdee29f15585 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?El=C3=ADas=20Gabriel=20P=C3=A9rez?= <eg642616@HIDDEN>
Date: Sun, 16 Feb 2025 16:33:46 -0600
Subject: [PATCH] Add new minor mode for clear whitespaces on save.

Add minor mode and global minor mode for clean whitespaces in current
file/buffer on save.

* lisp/whitespace.el (whitespace-autoclean-on-save-mode):
New minor mode.
(turn-on-whitespace-cleanup-on-save): New function.
(global-whitespace-cleanup-on-save): New global minor mode.
---
 lisp/whitespace.el | 26 +++++++++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)

diff --git a/lisp/whitespace.el b/lisp/whitespace.el
index efee11faf98..98210febf2d 100644
--- a/lisp/whitespace.el
+++ b/lisp/whitespace.el
@@ -1008,11 +1008,21 @@ whitespace-newline-mode
   ;; sync states (running a batch job)
   (setq whitespace-newline-mode whitespace-mode))
 
+(define-minor-mode whitespace-autoclean-on-save-mode
+  "Toggle cleanup of whitespace before saving the buffer.
+Cleans up any whitespace in the buffer before saving."
+  :lighter    " wscln"
+  :init-value nil
+  :global     nil
+  :group      'whitespace
+  (if whitespace-autoclean-on-save-mode
+      (add-hook 'write-file-functions 'whitespace-cleanup nil t)
+    (remove-hook 'write-file-functions 'whitespace-cleanup t)))
+
 
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 ;;;; User commands - Global mode
 
-
 ;;;###autoload
 (define-globalized-minor-mode global-whitespace-mode
   whitespace-mode
@@ -1069,6 +1079,20 @@ global-whitespace-newline-mode
                "use `global-whitespace-mode' with `whitespace-style' set to `(newline-mark newline)' instead."
                "28.1")
 
+(defun turn-on-whitespace-autoclean-on-save ()
+  "Turn on whitespace visualization."
+  ;; prepare local hooks
+  (if (not whitespace-autoclean-on-save-mode)
+      (whitespace-autoclean-on-save-mode)
+    (whitespace-autoclean-on-save-mode)))
+
+;;;###autoload
+(define-globalized-minor-mode global-whitespace-cleanup-on-save
+  whitespace-autoclean-on-save
+  turn-on-whitespace-autoclean-on-save
+  :init-value nil
+  :group 'whitespace)
+
 
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 ;;;; User commands - Toggle
-- 
2.48.1


--=-=-=
Content-Type: text/plain


-- 
                                                   - E.G via GNU Emacs.

--=-=-=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= <eg642616@HIDDEN>
Subject: bug#76355: Acknowledgement ([PATCH] Add new minor mode for clear
 whitespaces on save.)
Message-ID: <handler.76355.B.17397504942366.ack <at> debbugs.gnu.org>
References: <874j0th22v.fsf@HIDDEN>
X-Gnu-PR-Message: ack 76355
X-Gnu-PR-Package: emacs
X-Gnu-PR-Keywords: patch
Reply-To: 76355 <at> debbugs.gnu.org
Date: Mon, 17 Feb 2025 00:02:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 76355 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
76355: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D76355
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 19 Feb 2025 02:08:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 18 21:08:47 2025
Received: from localhost ([127.0.0.1]:37384 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tkZW3-0004sC-7N
	for submit <at> debbugs.gnu.org; Tue, 18 Feb 2025 21:08:47 -0500
Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:42361)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1tkZW1-0004rb-No
 for control <at> debbugs.gnu.org; Tue, 18 Feb 2025 21:08:46 -0500
Received: by mail-ed1-x52e.google.com with SMTP id
 4fb4d7f45d1cf-5debbced002so714833a12.1
 for <control <at> debbugs.gnu.org>; Tue, 18 Feb 2025 18:08:45 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1739930920; x=1740535720; darn=debbugs.gnu.org;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=kh3ZLGkrwwFx+ApQMPlp+9F44iNki02hlQcXkLepePc=;
 b=HOIpZ69M7IJUN+Gg8bd3hvbfPOpHsJJAzisACH8iJA33kL30saEejEeIE+FrIwQ6++
 pGBQokqsBk+j0d3zz2gAwOSD7JDPUtuUkLpSS1GJZm69pqPRnc+tJ307c0NXXic45B12
 Yz5pvq45SSux18Q/fxLwFxzOzvKMdanTMiCA2YHTuwBb3FEmhIoRWKNmkjEdh8hiartT
 GrvTTHwmCfLFQXtpYTPgG/OKDoR6So2y+njS05ckkBPV5opNeiKWWLCmh1TioGUBAAkm
 zbdoF//yVXvQdx7TMIKGHcLc/p8QzIj2Pxiyn1kyB/inaHSdd0ivKm+ULEnrYw9Piuva
 b5Ww==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1739930920; x=1740535720;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=kh3ZLGkrwwFx+ApQMPlp+9F44iNki02hlQcXkLepePc=;
 b=i4V907HuRc77fe1AqLtJUkkfyMtWbscYsoWouXmmeXUW9NckgPf9xXT10m5jkg9SQW
 iXY7+J3LQISfxo09lfZBd99Kb8Z73ZLw8uZRLK5qiiGPKzrpGC1lr6YACTWRqYb7TNvw
 5P63dbGnd4dR4NuXavh8mrDLmwQJjuKX8nkSHrpozJS6qPUURQoYQ0D39zrI9v25ig1q
 5b7B+1LpA1QoNJnLfGSDCVmr2ogNjf72vbV1ao3meE4oYFp7xr8Q5cLLRYxK9QOSYE2L
 Jq8/tBfs6VMzkQF3Y/gakQ2XESJ/Ez8tNkmhJAdHViQQes7p5f+vQgOxYQdL9VeKJpx/
 Calw==
X-Gm-Message-State: AOJu0YwFIQzKZlXvq4I4Spym+ICI6inaEVKUS7CR7/b3e3J4ZVOy9J2j
 gD9qL5JiulWCguw+GAvupSoxen+/LkHy+lCBfRv6Uam/M+idJU5xA5NJ5IoKtzS8/zbaBME2ND/
 GRSTOSqPZaqFZffHKofkRYudOwJ/qnROc
X-Gm-Gg: ASbGncseY0WR3c5+oIonUqFmQhcbVVrdKVNp6ZO4EMXngOH+4ztFRfVVjECR5DfL25v
 CA14FHG3OvWfVyOyOueH4o8zqyjn+pz9luHbxft9SjgHMQgu+KJ295ggAxU5DsWDABEzVYMBHiw
 c=
X-Google-Smtp-Source: AGHT+IHySdf3X6pPtCgJUww+5xvyCdvTkUJZHWqa9MJcc2lH7RBToy685aoI4oD+egQ2/e8OMkkr3gnkvf3XDNJgSME=
X-Received: by 2002:a05:6402:354a:b0:5db:e88c:914f with SMTP id
 4fb4d7f45d1cf-5e088da1c39mr1836846a12.4.1739930919629; Tue, 18 Feb 2025
 18:08:39 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Tue, 18 Feb 2025 18:08:39 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
MIME-Version: 1.0
Date: Tue, 18 Feb 2025 18:08:39 -0800
X-Gm-Features: AWEUYZmy7gbzRCxcyuXzIFZfhcAxcgKOiIBtk8nytPXlhXqNXHVlx4-myYNVXJQ
Message-ID: <CADwFkm=bd1nfVUz4=Z32a3fgRnCGCOWb5Snh8CUNJe1giuQXRw@HIDDEN>
Subject: control message for bug #76355
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

severity 76355 wishlist
quit

Last modified: Wed, 19 Feb 2025 02:15:03 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.