GNU bug report logs - #76364
[PATCH] Add python-ts-mode to ffap-alist

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: wishlist; Reported by: kobarity <kobarity@HIDDEN>; Keywords: patch; Done: Stefan Kangas <stefankangas@HIDDEN>; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 76364-done <at> debbugs.gnu.org:


Received: (at 76364-done) by debbugs.gnu.org; 19 Feb 2025 02:08:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 18 21:08:32 2025
Received: from localhost ([127.0.0.1]:37379 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tkZVn-0004qt-Lk
	for submit <at> debbugs.gnu.org; Tue, 18 Feb 2025 21:08:32 -0500
Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:50555)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1tkZVm-0004q5-82
 for 76364-done <at> debbugs.gnu.org; Tue, 18 Feb 2025 21:08:30 -0500
Received: by mail-ed1-x52e.google.com with SMTP id
 4fb4d7f45d1cf-5e04861e7a6so5919393a12.1
 for <76364-done <at> debbugs.gnu.org>; Tue, 18 Feb 2025 18:08:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1739930904; x=1740535704; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=sgARg7XYV8ViBEb0g+AlUNrRzdUT0YEVzsNaQxSk0ac=;
 b=OGpa+pU+CVMwhvz2HG1Dx/wkFwEwCZ/e8K+X/wPHJ/rpTJ9MO5H/2IIZsAwioPdIXQ
 eJXBZrqaMM7dp6uwf2CEzgPnKLKbh2B0DYowsxCT/3EXeHTFruxoc2meDTv4HU/uRn8p
 IHyadKgic3NysjVbnA6ryrmEBsyYPRgBn+kv5kaysmI5jC05M8P7easzDlTsaSsXOBD3
 /p21rWphiW/cWaOfsg9kJ8gwnrVMYS6IQLMiRxfXnPYFv29Z5TtcHZ66P9vLVfbKqKjK
 Qp774vyztLD5BWVdWLYzi91BfG/gxQyWtFIXlUy9LbRAZbltflpUXgrzrpX8WVDVcunD
 FFUg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1739930904; x=1740535704;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=sgARg7XYV8ViBEb0g+AlUNrRzdUT0YEVzsNaQxSk0ac=;
 b=au9XGOY24l/1NTxyJlA2rW9hTO4zjDj6Ew+hPI8i4hHMmP0HrUNm3QCd1/Ms+eSxK1
 et8jGF4biNC2Cpvr/Ns6NMd6cUG0xnJx1+irxX+4ALouUKXTjNgDVMzuYoG/0u6C90Lg
 DSxHpUVRmt4CnCE/sqQDzqwaex92SD4zP8XyNZROxpcdN93dvzo3Lta0pHroMVZ8u0dw
 gYdvFavTNIrNRNOAHsSGJuQkm0sy9w8Ea/qccs2t10hGKPrpuxucEgLqeaOllnV28DOQ
 TzXu1pj4cLT/ryy4CfcJMWlyIThZnE1xN0HEYqnVEqV8rxeN4uzyVImw6VuAUejAL14K
 v63w==
X-Gm-Message-State: AOJu0YzslcK9vqA4W5hBmOZg85Lf00C00c299BA99slQZz258WKmcv4f
 kdJR3lqlwPLyEyNLrYJRjMJ9sJCoxobNFekH2yL3fQH7rSr7ihxFedbz9+ioixBD4UQdRpfJOkK
 BCExFgUeEcVLkK75CHHto5VCaYw4=
X-Gm-Gg: ASbGncvXKdI8Tfkt/LuUsjMx0XMoJHzQ9nPfxXXajS5QpGTIjeUFn8Jk4y0ZgW3ylW1
 7OQ1OfcNDy3UnyXhNN5d5qWVYeNXgy2DBmuigj4mupMDHYcP84IWaJGgnwLQf6gBPrviJnN9kih
 g=
X-Google-Smtp-Source: AGHT+IFYMrX28MKBI2gPI79EyOEENVEmYQNJ/ZkxCKbO7bXQO7BKbPBYQTtRBMdbyVnekTom0Kzm7IOOnCwSE/yvQ34=
X-Received: by 2002:a05:6402:2384:b0:5e0:36c0:7b00 with SMTP id
 4fb4d7f45d1cf-5e036c07d5fmr13681851a12.31.1739930904085; Tue, 18 Feb 2025
 18:08:24 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Tue, 18 Feb 2025 18:08:23 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <eke7tt8sr6nm.wl-kobarity@HIDDEN>
References: <eke7tt8sr6nm.wl-kobarity@HIDDEN>
MIME-Version: 1.0
Date: Tue, 18 Feb 2025 18:08:23 -0800
X-Gm-Features: AWEUYZkcCVu6z1VUlokj7ACaswseMZ6u9P9_w8VZoOVb-CxNKsmHyLve7ycAMtA
Message-ID: <CADwFkmnbO6kYzBORg3F+vbJeBEr3gtJydunVg0jPzNah6JyMHg@HIDDEN>
Subject: Re: bug#76364: [PATCH] Add python-ts-mode to ffap-alist
To: kobarity <kobarity@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 76364-done
Cc: 76364-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Version: 31.1

kobarity <kobarity@HIDDEN> writes:

> FFAP support in python.el does not work in `python-ts-mode'.
>
> 1. emacs -Q
> 2. Open a Python file and enter the following:
>
> import argparse
>
> 3. C-c C-p   (Open the Inferior Python buffer)
> 4. Back to the Python file buffer.
> 5. C-c C-c   (Send the buffer to Inferior Python)
> 5. Place the point to "argparse".
> 6. M-x ffap-bindings
> 7. C-x C-f
>
> Minibuffer should display something like:
>
> Find file or URL: somewhere/argparse.py
>
> 8. C-g   (Cancel opening the file)
> 9. M-x python-ts-mode
> 10. C-x C-f
>
> The path to argparse.py is not shown.
>
> This occurs because `python-ts-mode' is not registered in
> `ffap-alist'.
>
> Attached is a patch to fix this issue.

Thanks, installed on master, closing.




Notification sent to kobarity <kobarity@HIDDEN>:
bug acknowledged by developer. Full text available.
Reply sent to Stefan Kangas <stefankangas@HIDDEN>:
You have taken responsibility. Full text available.
Severity set to 'wishlist' from 'normal' Request was from Stefan Kangas <stefankangas@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 17 Feb 2025 14:24:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 17 09:24:29 2025
Received: from localhost ([127.0.0.1]:44933 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tk22v-0000Tx-3h
	for submit <at> debbugs.gnu.org; Mon, 17 Feb 2025 09:24:29 -0500
Received: from lists.gnu.org ([2001:470:142::17]:54440)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <kobarity@HIDDEN>)
 id 1tk22s-0000TR-3t
 for submit <at> debbugs.gnu.org; Mon, 17 Feb 2025 09:24:27 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <kobarity@HIDDEN>)
 id 1tk22k-0001Dg-Gx
 for bug-gnu-emacs@HIDDEN; Mon, 17 Feb 2025 09:24:18 -0500
Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <kobarity@HIDDEN>)
 id 1tk22i-000129-Uc
 for bug-gnu-emacs@HIDDEN; Mon, 17 Feb 2025 09:24:18 -0500
Received: by mail-pj1-x102c.google.com with SMTP id
 98e67ed59e1d1-2fc4418c0e1so2603259a91.1
 for <bug-gnu-emacs@HIDDEN>; Mon, 17 Feb 2025 06:24:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1739802254; x=1740407054; darn=gnu.org;
 h=mime-version:user-agent:subject:to:from:message-id:date:from:to:cc
 :subject:date:message-id:reply-to;
 bh=FJd743h6Xn1cPk1Pa//WN3kI1xvB6RVrMdlMYjiFbvE=;
 b=ZyXGu/lcWewaaoOJXaJow0yfd8c0QsYk9opFnzkItWkO7MbaI3nQkvQ9PyHnA3VD/j
 jEscqkxgwpY6p7zw1stSGhGt5v1d5e1jM3Z+hfGShtGOsYUEWvMapugzoaHAuRbRiZAi
 Cv2BLLLQlQGAzuTqPozCBDvtSa9TfHC+EgJN6bwpEwKniXPbwcfAYJy7cO4NKTdkug9n
 tIqcJZWqGHMd/AQ9m8OwhYFEmXIdnK1tOusekNuBsvLTcW43Mx9bhpgJSBqnSZADoNQ5
 aCGnLcBJbFbboj7mCFlGlXUroQrHsQD+8EQkatggbOCV0IK+3RA8yxavXAq9TS5k40fx
 SMYw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1739802254; x=1740407054;
 h=mime-version:user-agent:subject:to:from:message-id:date
 :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=FJd743h6Xn1cPk1Pa//WN3kI1xvB6RVrMdlMYjiFbvE=;
 b=klPacPUExaEQJ5rlyT6ESxpvRpFLJp+sfOavVLhroH0ZUWbPgrWYk4fbEEKyr/mAxK
 8yFFXVr3lkzfe6v6XFr03fGW5NojLNgZloD1sve0WLNFiTEoJAvx2xMiUa3gUAjKHlJm
 0Xk47VdC5tw4B1nYdfahCIdsLLRd2UnvrjawHWAgkql550Ca+lyPGkR7pnpVXNP+4tOE
 0ATCOACMRuohsoR5ISV1kddL4fwOWfagehMbggNRBN+Cym2pimqIHADVMoJ5GxQy7y3g
 fhQlF6TjjR1r6BbK2RC7M4slohDQK2aZ6Bjnr0uEtfsfX2USqGHvVR/lDe1iD0zb40JU
 OF5Q==
X-Gm-Message-State: AOJu0YwEhMvCKFyd2E9jD2o3/Chs8ldfj2pltMZKqY6EUrFzvqNTBpdz
 VRdwambLP/NV8a/G11qVZ358lvmr2760ERAI2bJ1n4cehLaNwWpM23WVlg==
X-Gm-Gg: ASbGncv68NTACUF9AFMfxc75HTmTRIPRgCLLAt/YY3k3a5HMA2Br9fVvR/7UrGoBVsk
 jEx3QyaUa2JAYzanZxK4t/WRh6kSs5nVv+zuGUETMS1gY+9v3ifvI9rze398YmkJdBJwru0nKcm
 m7uD085+IGZjG+BEJCl1duKpXkNjop1ByR26PqG3nOAk8Iw03HMzuHpzxvsxnG/MdspgGZ/zCdU
 Ht8szMjEgAwL7LeUvpaY7cFa6nGXlim17GlEpNcwSQTILMZywdS3Y75qumIqwD6rTFC09bX9tG3
 5CRDpkaMuOL2LI2mylki6igDBXyqdRsIXVXlOV232FzkuQ==
X-Google-Smtp-Source: AGHT+IEeN8zx+G+hVJ+sO2YDYsIa0kWCq3zzv9RzmFyhHkJjNn3Ypm3Jb0aL/S6OxRm0gfhDrW+dwQ==
X-Received: by 2002:a17:90b:3ec2:b0:2ee:8253:9a9f with SMTP id
 98e67ed59e1d1-2fc0fa412d0mr27873071a91.11.1739802254394; 
 Mon, 17 Feb 2025 06:24:14 -0800 (PST)
Received: from localhost (58x12x133x161.ap58.ftth.ucom.ne.jp. [58.12.133.161])
 by smtp.gmail.com with ESMTPSA id
 98e67ed59e1d1-2fc13bbeec8sm8081696a91.49.2025.02.17.06.24.13
 for <bug-gnu-emacs@HIDDEN>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 17 Feb 2025 06:24:13 -0800 (PST)
Date: Mon, 17 Feb 2025 23:24:13 +0900
Message-ID: <eke7tt8sr6nm.wl-kobarity@HIDDEN>
From: kobarity <kobarity@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: [PATCH] Add python-ts-mode to ffap-alist
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0
 Emacs/31.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: multipart/mixed; boundary="Multipart_Mon_Feb_17_23:24:13_2025-1"
Received-SPF: pass client-ip=2607:f8b0:4864:20::102c;
 envelope-from=kobarity@HIDDEN; helo=mail-pj1-x102c.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

--Multipart_Mon_Feb_17_23:24:13_2025-1
Content-Type: text/plain; charset=US-ASCII

FFAP support in python.el does not work in `python-ts-mode'.

1. emacs -Q
2. Open a Python file and enter the following:

import argparse

3. C-c C-p   (Open the Inferior Python buffer)
4. Back to the Python file buffer.
5. C-c C-c   (Send the buffer to Inferior Python)
5. Place the point to "argparse".
6. M-x ffap-bindings
7. C-x C-f

Minibuffer should display something like:

Find file or URL: somewhere/argparse.py

8. C-g   (Cancel opening the file)
9. M-x python-ts-mode
10. C-x C-f

The path to argparse.py is not shown.

This occurs because `python-ts-mode' is not registered in
`ffap-alist'.

Attached is a patch to fix this issue.

--
In GNU Emacs 31.0.50 (build 8, x86_64-pc-linux-gnu, GTK+ Version
 3.24.41, cairo version 1.18.0) of 2025-01-01 built on ubuntu2404
Repository revision: 78bc5949db489b143f7424540d6cc56fc529c9ea
Repository branch: master
System Description: Ubuntu 24.04.2 LTS

Configured using:
 'configure --with-pgtk --with-native-compilation --with-tree-sitter'

--Multipart_Mon_Feb_17_23:24:13_2025-1
Content-Type: application/octet-stream; type=patch; name="0001-Add-python-ts-mode-to-ffap-alist.patch"
Content-Disposition: attachment; filename="0001-Add-python-ts-mode-to-ffap-alist.patch"
Content-Transfer-Encoding: 7bit

From 5d210d95b1823ee12671db351252c60a368c8940 Mon Sep 17 00:00:00 2001
From: kobarity <kobarity@HIDDEN>
Date: Mon, 17 Feb 2025 23:00:04 +0900
Subject: [PATCH] Add python-ts-mode to ffap-alist

* lisp/progmodes/python.el (ffap-alist): Add python-ts-mode.
---
 lisp/progmodes/python.el | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el
index a42e2b2a28a..4f92db5ff67 100644
--- a/lisp/progmodes/python.el
+++ b/lisp/progmodes/python.el
@@ -5539,9 +5539,8 @@ python-ffap-module-path
 (defvar ffap-alist)
 
 (eval-after-load "ffap"
-  '(progn
-     (push '(python-mode . python-ffap-module-path) ffap-alist)
-     (push '(inferior-python-mode . python-ffap-module-path) ffap-alist)))
+  '(dolist (mode '(python-mode python-ts-mode inferior-python-mode))
+     (add-to-list 'ffap-alist `(,mode . python-ffap-module-path))))
 
 
 ;;; Code check
-- 
2.43.0


--Multipart_Mon_Feb_17_23:24:13_2025-1--




Acknowledgement sent to kobarity <kobarity@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#76364; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Wed, 19 Feb 2025 02:15:03 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.