X-Loop: help-debbugs@HIDDEN Subject: bug#76399: [PATCH] Change 'fullscreen' references to 'maximized' Resent-From: Ship Mints <shipmints@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Tue, 18 Feb 2025 17:50:02 +0000 Resent-Message-ID: <handler.76399.B.173990095115579 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 76399 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 76399 <at> debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN Received: via spool by submit <at> debbugs.gnu.org id=B.173990095115579 (code B ref -1); Tue, 18 Feb 2025 17:50:02 +0000 Received: (at submit) by debbugs.gnu.org; 18 Feb 2025 17:49:11 +0000 Received: from localhost ([127.0.0.1]:60693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tkRiY-00043B-Nh for submit <at> debbugs.gnu.org; Tue, 18 Feb 2025 12:49:11 -0500 Received: from lists.gnu.org ([2001:470:142::17]:43862) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <shipmints@HIDDEN>) id 1tkRiV-00041x-Qa for submit <at> debbugs.gnu.org; Tue, 18 Feb 2025 12:49:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <shipmints@HIDDEN>) id 1tkRiP-00035g-3W for bug-gnu-emacs@HIDDEN; Tue, 18 Feb 2025 12:49:01 -0500 Received: from mail-vk1-xa2c.google.com ([2607:f8b0:4864:20::a2c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <shipmints@HIDDEN>) id 1tkRiN-0003JB-K7 for bug-gnu-emacs@HIDDEN; Tue, 18 Feb 2025 12:49:00 -0500 Received: by mail-vk1-xa2c.google.com with SMTP id 71dfb90a1353d-521b188df16so494752e0c.2 for <bug-gnu-emacs@HIDDEN>; Tue, 18 Feb 2025 09:48:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739900938; x=1740505738; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=FEhcK1MFVDJH8UbtLbHuUdWaAgT82fwiQSbem52ro6o=; b=MhI1cwnDjKYUHn4Waxc4lNlTaAo7pd70BT6x+5J165rzqJb/F3Q4HxXjNM0pLAm2d3 ogTw+Fstgbe9Hq/zpn3LFFqxp9gMvpyxFCG0r6dx34lg+wC2/s2dGXboUpWULvmTfD6+ K+j0YJpD1MeGeDRtaXj0Nt8THzfvmYi9D8VZQqWHoczSuJxQ95a6GHFDBkz4osePpiZq L4cd8kV95824ObJ9FxWV0pvp1OMA8BLEIqYXws8gcM1VdLwprXY46eGTXyLa7rg/2HFv gyZBpFQ6S4BI1jWA5HRLDC2sKS875U+Q3Q9YSET9N+gJ+p9gtPTxHKwD5Z0JwEOqQADx l4WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739900938; x=1740505738; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=FEhcK1MFVDJH8UbtLbHuUdWaAgT82fwiQSbem52ro6o=; b=so9Ld6S01UDg6gBlxOaAGyovGOb1I6dTG2Hs+ZhWHny5bqB8GBSdpznoOoshvSLDhS mN0JwUAYLWIWj3eGR/qshUxV1h95sqyahan6L7+i9YR2S53549ouAtVqRNLNpAjN8BLn Qb31EwxsWKELMSw85AsCxMWVCKJeDD5zcG10uTaJAdFCzbEwqVG23i4JpPQf8xMwLLGv nhsz4/KXfyxNn5rzSNWiam2R0ZljJKKZqnnSscVmuDuJhHajkDiKMyN0pQXMgbbTXL0d uv+oGLppJ/Ix3lC8GdD+mv9xmgRw7pURTUt4tOcP0JP/msmP0CcoAckjGJQykKtTSj3g zp3A== X-Gm-Message-State: AOJu0Ywg3jSCrfjS1J8sLIAnBUjCd+RUSN/Us6jArnb6vUwFkZyxixLa rSrkD25BvCh0//Bk87ZclPFAUBZdSICVvre84AE7heS8Ujvgdi0QxbIzUnz9m/MgjjSCaDYWnYl 225Rm4By0oqdXwx57cwd8L+8xDJU39Non X-Gm-Gg: ASbGncuJWzexoxQjDRE4pXkBup0KyTZOzePtVdCyUr7zanMqQl9/0t+GWRZIzZrbe9N BStGbsETm+yQ53KIpYAK2PR417YkrH2abbGx+Ns9sKA3Kq5awcPe2bqm7vMJAJr8kEYOkT9Qd X-Google-Smtp-Source: AGHT+IFeQMgG9+IZbOBaQmmhLo8rCfDdcEzf6RKnS8iBO+Xv7JqVotP3gYrZL5BGv7y0AywEyj+PWv0R52NoAR/mhDE= X-Received: by 2002:a05:6122:1ad6:b0:520:64ea:c461 with SMTP id 71dfb90a1353d-5209dc2306bmr7470884e0c.6.1739900937954; Tue, 18 Feb 2025 09:48:57 -0800 (PST) MIME-Version: 1.0 From: Ship Mints <shipmints@HIDDEN> Date: Tue, 18 Feb 2025 12:48:46 -0500 X-Gm-Features: AWEUYZnWBEEXlGT5L_WCpN2UPRQiaaO6j4wi_aW6F0_yRCfRygSsrFWdr4Tt2nA Message-ID: <CAN+1HbqoK41Ed=_BMbWgiU-4yO2J2jAiUPkuQ3fG31hasHh_cQ@HIDDEN> Content-Type: multipart/mixed; boundary="0000000000005a055d062e6e41c5" Received-SPF: pass client-ip=2607:f8b0:4864:20::a2c; envelope-from=shipmints@HIDDEN; helo=mail-vk1-xa2c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) --0000000000005a055d062e6e41c5 Content-Type: multipart/alternative; boundary="0000000000005a055b062e6e41c3" --0000000000005a055b062e6e41c3 Content-Type: text/plain; charset="UTF-8" In frame.el's toggle-frame-fullscreen and toggle-frame-maximized, these look like either typos, or vestigial references. The frame-parameter fullscreen is never set to 'fullscreen nor is the value 'fullscreen used in other places in Emacs. It is an undocumented value, appearing nowhere. Unless I missed something. I reviewed below sources and relevant headers: android.c androidfns.c androidterm.c emacs.c frame.c gtkutil.c haikufns.c haikuterm.c pgtkfns.c pgtkterm.c term.c w32fns.c w32term.c xfns.c xmenu.c xterm.c nsfns.m nsterm.m -Stephane --0000000000005a055b062e6e41c3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:monospac= e">In frame.el's toggle-frame-fullscreen and toggle-frame-maximized, th= ese look like either typos, or vestigial references.=C2=A0 The frame-parame= ter fullscreen is never set to 'fullscreen nor is the=C2=A0value 'f= ullscreen=C2=A0used in other places in Emacs.=C2=A0 It is an undocumented v= alue, appearing nowhere.=C2=A0 Unless I missed something.</div><div class= =3D"gmail_default" style=3D"font-family:monospace"><br></div><div class=3D"= gmail_default" style=3D"font-family:monospace">I reviewed below sources and= relevant headers:</div><div class=3D"gmail_default" style=3D"font-family:m= onospace"><br></div><div class=3D"gmail_default" style=3D"font-family:monos= pace">android.c<br>androidfns.c<br>androidterm.c<br>emacs.c<br>frame.c<br>g= tkutil.c<br>haikufns.c<br>haikuterm.c<br>pgtkfns.c<br>pgtkterm.c<br>term.c<= br>w32fns.c<br>w32term.c<br>xfns.c<br>xmenu.c<br>xterm.c<br>nsfns.m<br>nste= rm.m<br></div><div class=3D"gmail_default" style=3D"font-family:monospace">= <br></div><div class=3D"gmail_default" style=3D"font-family:monospace">-Ste= phane</div></div> --0000000000005a055b062e6e41c3-- --0000000000005a055d062e6e41c5 Content-Type: application/octet-stream; name="0001-Change-fullscreen-references-to-maximized.patch" Content-Disposition: attachment; filename="0001-Change-fullscreen-references-to-maximized.patch" Content-Transfer-Encoding: base64 Content-ID: <f_m7araxso0> X-Attachment-Id: f_m7araxso0 RnJvbSBhZTcwYWVmYTQxZGRiMTJkYjgzM2Q4ZmExNTU1Y2IzYTY5MTMwZTY3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBzaGlwbWludHMgPHNoaXBtaW50c0BnbWFpbC5jb20+CkRhdGU6 IFR1ZSwgMTggRmViIDIwMjUgMTI6MjM6MDIgLTA1MDAKU3ViamVjdDogW1BBVENIXSBDaGFuZ2Ug J2Z1bGxzY3JlZW4nIHJlZmVyZW5jZXMgdG8gJ21heGltaXplZCcKCiogbGlzcC9mcmFtZS5lbAoo dG9nZ2xlLWZyYW1lLW1heGltaXplZCB0b2dnbGUtZnJhbWUtZnVsbHNjcmVlbik6IENoYW5nZSAn ZnVsbHNjcmVlbicgdG8KJ21heGltaXplZCcuCi0tLQogbGlzcC9mcmFtZS5lbCB8IDQgKystLQog MSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9saXNwL2ZyYW1lLmVsIGIvbGlzcC9mcmFtZS5lbAppbmRleCBlNjYyNzAxMzBkMi4uNTU0 OTdkNTUwMzkgMTAwNjQ0Ci0tLSBhL2xpc3AvZnJhbWUuZWwKKysrIGIvbGlzcC9mcmFtZS5lbApA QCAtMzE0NCw3ICszMTQ0LDcgQEAgdG9nZ2xlLWZyYW1lLW1heGltaXplZAogICAoaW50ZXJhY3Rp dmUpCiAgIChsZXQgKChmdWxsc2NyZWVuIChmcmFtZS1wYXJhbWV0ZXIgZnJhbWUgJ2Z1bGxzY3Jl ZW4pKSkKICAgICAoY29uZAotICAgICAoKG1lbXEgZnVsbHNjcmVlbiAnKGZ1bGxzY3JlZW4gZnVs bGJvdGgpKQorICAgICAoKG1lbXEgZnVsbHNjcmVlbiAnKG1heGltaXplZCBmdWxsYm90aCkpCiAg ICAgICAoc2V0LWZyYW1lLXBhcmFtZXRlciBmcmFtZSAnZnVsbHNjcmVlbi1yZXN0b3JlICdtYXhp bWl6ZWQpKQogICAgICAoKGVxIGZ1bGxzY3JlZW4gJ21heGltaXplZCkKICAgICAgIChzZXQtZnJh bWUtcGFyYW1ldGVyIGZyYW1lICdmdWxsc2NyZWVuIG5pbCkpCkBAIC0zMTcwLDcgKzMxNzAsNyBA QCB0b2dnbGUtZnJhbWUtZnVsbHNjcmVlbgogU2VlIGFsc28gYHRvZ2dsZS1mcmFtZS1tYXhpbWl6 ZWQnLiIKICAgKGludGVyYWN0aXZlKQogICAobGV0ICgoZnVsbHNjcmVlbiAoZnJhbWUtcGFyYW1l dGVyIGZyYW1lICdmdWxsc2NyZWVuKSkpCi0gICAgKGlmIChtZW1xIGZ1bGxzY3JlZW4gJyhmdWxs c2NyZWVuIGZ1bGxib3RoKSkKKyAgICAoaWYgKG1lbXEgZnVsbHNjcmVlbiAnKG1heGltaXplZCBm dWxsYm90aCkpCiAJKGxldCAoKGZ1bGxzY3JlZW4tcmVzdG9yZSAoZnJhbWUtcGFyYW1ldGVyIGZy YW1lICdmdWxsc2NyZWVuLXJlc3RvcmUpKSkKIAkgIChpZiAobWVtcSBmdWxsc2NyZWVuLXJlc3Rv cmUgJyhtYXhpbWl6ZWQgZnVsbGhlaWdodCBmdWxsd2lkdGgpKQogCSAgICAgIChzZXQtZnJhbWUt cGFyYW1ldGVyIGZyYW1lICdmdWxsc2NyZWVuIGZ1bGxzY3JlZW4tcmVzdG9yZSkKLS0gCjIuNDcu MQoK --0000000000005a055d062e6e41c5--
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Ship Mints <shipmints@HIDDEN> Subject: bug#76399: Acknowledgement ([PATCH] Change 'fullscreen' references to 'maximized') Message-ID: <handler.76399.B.173990095115579.ack <at> debbugs.gnu.org> References: <CAN+1HbqoK41Ed=_BMbWgiU-4yO2J2jAiUPkuQ3fG31hasHh_cQ@HIDDEN> X-Gnu-PR-Message: ack 76399 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 76399 <at> debbugs.gnu.org Date: Tue, 18 Feb 2025 17:50:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 76399 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 76399: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D76399 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN Subject: bug#76399: [PATCH] Change 'fullscreen' references to 'maximized' Resent-From: Ship Mints <shipmints@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Tue, 18 Feb 2025 19:38:02 +0000 Resent-Message-ID: <handler.76399.B76399.173990748029980 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 76399 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 76399 <at> debbugs.gnu.org Received: via spool by 76399-submit <at> debbugs.gnu.org id=B76399.173990748029980 (code B ref 76399); Tue, 18 Feb 2025 19:38:02 +0000 Received: (at 76399) by debbugs.gnu.org; 18 Feb 2025 19:38:00 +0000 Received: from localhost ([127.0.0.1]:33600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tkTPr-0007nM-MT for submit <at> debbugs.gnu.org; Tue, 18 Feb 2025 14:38:00 -0500 Received: from mail-ua1-x931.google.com ([2607:f8b0:4864:20::931]:43258) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <shipmints@HIDDEN>) id 1tkTPo-0007mp-4i for 76399 <at> debbugs.gnu.org; Tue, 18 Feb 2025 14:37:57 -0500 Received: by mail-ua1-x931.google.com with SMTP id a1e0cc1a2514c-860f0e91121so87579241.0 for <76399 <at> debbugs.gnu.org>; Tue, 18 Feb 2025 11:37:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739907470; x=1740512270; darn=debbugs.gnu.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=sRpjS5TzNoWlB5mXRqHDk8nlu3W/wlec/6R77jS9/ds=; b=A6wgRQm08aes1MAhclb0oWAxg8udPGbKzHdpvvUBcwsGIrdZTDRscnHCdCIlZQCaz8 NMs3Db61VagPXSA9TxMQ+H0DHdchFYEZ01xcNJte40QXU3yBXNiFNalo5IJEiqxMPXsa 6SDc6ev5axDgtu3R0I2w9X9RBeYSIxi6caBnE1HCYeX50HhZDC9sLpftHXMZwLhBGdMc ta6QBDo2hQCc31RsHO/uzJwrUCP9PRv3kp/a8BSLTwvbc5kqSJfq/MpoZVmY9PGnhF9O mA/z/ERIM9DzimhsNBSMDiuL1VvGYjeT8Q3u6jqQ7N/cJYbRqVqIrtNvyENNfv2yLKma 7SWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739907470; x=1740512270; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sRpjS5TzNoWlB5mXRqHDk8nlu3W/wlec/6R77jS9/ds=; b=Jn7Fn7wpSIW0f6cEV2tfw7o5DhJ+bQq87VWqiYcGY3hH0WOlWculYCYWOCH9/O67qQ EZ/WetFmJJvCaGJK8b40Z+Ynmzbw3NDO+q10iK1KMLt49/QXqQktSfV9v+fwEvOz21W+ dXx72Ri6St9VOudFQjXoNDPGK9upbLOr0++ysnH8ERAPuFhOWLBVXWa5jYpxelFgolep Hpbx2U14c5OsX6fRDltv+25AtRp6k7uGOa6E0H7y+3XsAPnYzXK/NJW4SesUMY5Xf2Wi d6Yv7GmLdzzOWRYyzTIqQEhpD0OwdpViwD5KhxNymTl/eNFwNwIBgiWCFAeuBI/Yv1fl c0OA== X-Gm-Message-State: AOJu0Ywa/d8pmjcHH+0TlRYSZ6l/E1LBeyJeRxDWH/1DnSNAsOvZwrUL xyWJFbdMxyJwlskQaYnEBVYAOBiIU4dfji9x+/Gt4u7YT2dibM8/Rvhg4gnf9AodePHf+1A60Lq tIwhSL7hEXZYgxhp2839n8oXQ0v9HKkox X-Gm-Gg: ASbGncspnF7omhV7vpsPvaz/eLdy6i20ra2T+XXCgQBl1ctPNqBt3ytm2a5fTYIx0YN W/70gFW5p4Gm+30sRLhb1NOmwiuu/qVm4WIZzSGBYId17Q1PrJtK0k5J0lFeItnGJneL1IJ4M X-Google-Smtp-Source: AGHT+IHclabjio3LRjLsH7UL0mtKTq4gIw/T9wKNtTEsN60UGmN9yObiUQc6deK/XrxG6JLJLFFN2U8ojc/LHpl8isE= X-Received: by 2002:a05:6122:1306:b0:520:9883:29c2 with SMTP id 71dfb90a1353d-521c33928a0mr959822e0c.6.1739907469749; Tue, 18 Feb 2025 11:37:49 -0800 (PST) MIME-Version: 1.0 References: <CAN+1HbqoK41Ed=_BMbWgiU-4yO2J2jAiUPkuQ3fG31hasHh_cQ@HIDDEN> In-Reply-To: <CAN+1HbqoK41Ed=_BMbWgiU-4yO2J2jAiUPkuQ3fG31hasHh_cQ@HIDDEN> From: Ship Mints <shipmints@HIDDEN> Date: Tue, 18 Feb 2025 14:37:38 -0500 X-Gm-Features: AWEUYZnEjkMHtaV1u04M71VeZSXKdjPKyHWuAXYTC1n3ZoIi9LdcMOAflj7C7uE Message-ID: <CAN+1Hbpc3tux2xSN4e1H7__6H7fPeJDUZvuhyQcZmHiwXHSeaA@HIDDEN> Content-Type: multipart/alternative; boundary="000000000000ad368d062e6fc663" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --000000000000ad368d062e6fc663 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I did just find two references to 'fullscreen used as an alias to 'fullboth, but it's not documented and not implemented in all front ends so its use is not portable. I suggest we remove these or we document it and correct all the front ends. It looks like copy pasta, rather than by intent. pgtkfns.c: static Lisp_Object frame_geometry (Lisp_Object frame, Lisp_Object attribute) { struct frame *f =3D decode_live_frame (frame); Lisp_Object fullscreen_symbol =3D Fframe_parameter (frame, Qfullscreen); bool fullscreen =3D (EQ (fullscreen_symbol, Qfullboth) || EQ (fullscreen_symbol, Qfullscreen)); nsfns.m: static Lisp_Object frame_geometry (Lisp_Object frame, Lisp_Object attribute) { struct frame *f =3D decode_live_frame (frame); Lisp_Object fullscreen_symbol =3D Fframe_parameter (frame, Qfullscreen); bool fullscreen =3D (EQ (fullscreen_symbol, Qfullboth) || EQ (fullscreen_symbol, Qfullscreen)); On Tue, Feb 18, 2025 at 12:50=E2=80=AFPM Ship Mints <shipmints@HIDDEN> w= rote: > In frame.el's toggle-frame-fullscreen and toggle-frame-maximized, these > look like either typos, or vestigial references. The frame-parameter > fullscreen is never set to 'fullscreen nor is the value 'fullscreen used = in > other places in Emacs. It is an undocumented value, appearing nowhere. > Unless I missed something. > > I reviewed below sources and relevant headers: > > android.c > androidfns.c > androidterm.c > emacs.c > frame.c > gtkutil.c > haikufns.c > haikuterm.c > pgtkfns.c > pgtkterm.c > term.c > w32fns.c > w32term.c > xfns.c > xmenu.c > xterm.c > nsfns.m > nsterm.m > > -Stephane > --000000000000ad368d062e6fc663 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:monospac= e">I did just find two references to 'fullscreen used as an alias to &#= 39;fullboth, but it's not documented and not implemented in all front e= nds so=C2=A0its use is not portable.=C2=A0 I suggest we remove these or we = document it and correct all the front ends.=C2=A0 It looks like copy pasta,= rather than by intent.</div><div class=3D"gmail_default" style=3D"font-fam= ily:monospace"><br></div><div class=3D"gmail_default" style=3D"font-family:= monospace">pgtkfns.c:</div><div class=3D"gmail_default" style=3D"font-famil= y:monospace"><br></div><div class=3D"gmail_default" style=3D"font-family:mo= nospace">static Lisp_Object<br>frame_geometry (Lisp_Object frame, Lisp_Obje= ct attribute)<br>{<br>=C2=A0 struct frame *f =3D decode_live_frame (frame);= <br>=C2=A0 Lisp_Object fullscreen_symbol =3D Fframe_parameter (frame, Qfull= screen);<br>=C2=A0 bool fullscreen =3D (EQ (fullscreen_symbol, Qfullboth)<b= r> =C2=A0 =C2=A0 || EQ (fullscreen_symbol, Qfullscreen));<br></div><div c= lass=3D"gmail_default" style=3D"font-family:monospace"><br></div><div class= =3D"gmail_default" style=3D"font-family:monospace">nsfns.m:</div><div class= =3D"gmail_default" style=3D"font-family:monospace"><br></div><div class=3D"= gmail_default" style=3D"font-family:monospace">static Lisp_Object<br></div>= <div class=3D"gmail_default" style=3D"font-family:monospace">frame_geometry= (Lisp_Object frame, Lisp_Object attribute)<br>{<br>=C2=A0 struct frame *f = =3D decode_live_frame (frame);<br>=C2=A0 Lisp_Object fullscreen_symbol =3D = Fframe_parameter (frame, Qfullscreen);<br>=C2=A0 bool fullscreen =3D (EQ (f= ullscreen_symbol, Qfullboth)<br> =C2=A0 =C2=A0 || EQ (fullscreen_symbol, = Qfullscreen));<br></div></div><br><div class=3D"gmail_quote gmail_quote_con= tainer"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Feb 18, 2025 at 12:50= =E2=80=AFPM Ship Mints <<a href=3D"mailto:shipmints@HIDDEN">shipmints= @gmail.com</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style= =3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding= -left:1ex"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-fami= ly:monospace">In frame.el's toggle-frame-fullscreen and toggle-frame-ma= ximized, these look like either typos, or vestigial references.=C2=A0 The f= rame-parameter fullscreen is never set to 'fullscreen nor is the=C2=A0v= alue 'fullscreen=C2=A0used in other places in Emacs.=C2=A0 It is an und= ocumented value, appearing nowhere.=C2=A0 Unless I missed something.</div><= div class=3D"gmail_default" style=3D"font-family:monospace"><br></div><div = class=3D"gmail_default" style=3D"font-family:monospace">I reviewed below so= urces and relevant headers:</div><div class=3D"gmail_default" style=3D"font= -family:monospace"><br></div><div class=3D"gmail_default" style=3D"font-fam= ily:monospace">android.c<br>androidfns.c<br>androidterm.c<br>emacs.c<br>fra= me.c<br>gtkutil.c<br>haikufns.c<br>haikuterm.c<br>pgtkfns.c<br>pgtkterm.c<b= r>term.c<br>w32fns.c<br>w32term.c<br>xfns.c<br>xmenu.c<br>xterm.c<br>nsfns.= m<br>nsterm.m<br></div><div class=3D"gmail_default" style=3D"font-family:mo= nospace"><br></div><div class=3D"gmail_default" style=3D"font-family:monosp= ace">-Stephane</div></div> </blockquote></div> --000000000000ad368d062e6fc663--
Received: (at control) by debbugs.gnu.org; 19 Feb 2025 02:05:38 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 18 21:05:38 2025 Received: from localhost ([127.0.0.1]:37330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tkZSz-0004bQ-O0 for submit <at> debbugs.gnu.org; Tue, 18 Feb 2025 21:05:37 -0500 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]:48473) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tkZSx-0004ag-0p for control <at> debbugs.gnu.org; Tue, 18 Feb 2025 21:05:36 -0500 Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-5e0516e7a77so4491422a12.1 for <control <at> debbugs.gnu.org>; Tue, 18 Feb 2025 18:05:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739930728; x=1740535528; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=YCpSZvzo7P1HXulAk8EftLPwukNB/ASOkAmZLEz5HuE=; b=auSuGhM6t2bFClGtxQUOCPctzdV4Znp4VMBL9d+P1IHQ/uYR+D4LNArJDicx6xFLrC zVqYJx4is54BwMoJmUyVcBibkwfaYFunMW+lQdFn2yd58EjmlmX0y8OZOxqegGjfBWws UG9ZJS6G/7D+zOS03GhEEfV+BCH0Z8G0wsgjly0hWQbhuNiMN7bbPpYNXkmx/cqZVShn LLvfBcy/fthGmmdFJv3gQHcRtQWJq1Jcl4/NopusfQGDQ9pXbOtKh9RwgdzKAnEblLSX 1GV1geVX/CxbcpVlpvYJvROHOzUmYiMn645utdxAlFUg2FopNyKHmjQ8peDYypBJyX/m dDmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739930728; x=1740535528; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=YCpSZvzo7P1HXulAk8EftLPwukNB/ASOkAmZLEz5HuE=; b=UerG8b6NC4IsnsfhdzJa94o8qsPdbq/XslxY/C7/cHdZkM5IL2WnRVXLr2W/pBH8iR 8U2BuNCrUiWe9bA3mM3TuGiJdI+XS75k33+gh5P78FruuqMUQtQMLFHoyNoBYHZbt7Ge cXQGUzmR3TysNW0waVGpIlOxdYoK5eSJCfelOKjONSCL8z83N8x9Ii/39m6c89Zx+Db2 Ny06BuTFcWvnWvP703bIeqxQy4hYsIXNGIpyV1OKLWEL9bpQ+sbkQefL6LsdcD5jdkFx 9kh+Vag3aCwF5vJcraJtC5e33ktuVsCehRXVCyq4JyNaQ6tSF03ZMM8o7l4uUizZi0G1 Of2A== X-Gm-Message-State: AOJu0YwmKl3HoiyRFSvO+hrbe7bpiJSiQ37cdtQs+VVkSU8jUahSFdvV u60gKHaiffOT/M9lpzYVEX8uxwVRLDxLtYuhvNr+cHSsBw/7d4D6j7e14tH2XHBraG8cCcd7zcj crLfipQZVJjMxgp2Tw9A3uKUf3pj8yWDg X-Gm-Gg: ASbGncsr6/TnccpdBCHuJn9CKUvQoZp+PJuWl2+O59KtS3NIprFkgI22RGaxk44Sp28 D8kjefDrICiv2bjvXaS7LomSAvB7i73yXBOxdnxWFo3Dg5ItkweurVum+1CSTT/JvHD0O5ELSMo g= X-Google-Smtp-Source: AGHT+IFZCGTWUBAR0hYEFPB/x4wcumk4iU0zIH5Ag2kiRjRDIU1CYFA/5Qgab9wpKttoSs9Cgrq7zCKwmpaFjk50Uyo= X-Received: by 2002:a05:6402:3593:b0:5e0:815d:4e02 with SMTP id 4fb4d7f45d1cf-5e0815d6196mr3412137a12.5.1739930728225; Tue, 18 Feb 2025 18:05:28 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 18 Feb 2025 18:05:27 -0800 From: Stefan Kangas <stefankangas@HIDDEN> MIME-Version: 1.0 Date: Tue, 18 Feb 2025 18:05:27 -0800 X-Gm-Features: AWEUYZkyExN5A2qndlaFRAY1H--7lDGO4Mju04thNhVRFfLPbwuvfzpK2wEX2gU Message-ID: <CADwFkm=f6LoSzQoBPWZcQiyaJOCTCGYw+7_7+gPCpJcH4Q7pfw@HIDDEN> Subject: control message for bug #76399 To: control <at> debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) severity 76399 wishlist quit
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.