Juri Linkov <juri@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 76408) by debbugs.gnu.org; 19 Feb 2025 07:44:03 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 19 02:44:03 2025 Received: from localhost ([127.0.0.1]:41264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tkekV-00089k-Ay for submit <at> debbugs.gnu.org; Wed, 19 Feb 2025 02:44:03 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:46217) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1tkekF-000876-CR; Wed, 19 Feb 2025 02:43:48 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id BC7E643161; Wed, 19 Feb 2025 07:43:37 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Jared Finder <jared@HIDDEN> Subject: Re: bug#76408: 29.4; read-key always returns only tab-line for click in tab-line In-Reply-To: <3df498ad51c5dd4ae85493e67ce894d6@HIDDEN> Organization: LINKOV.NET References: <3df498ad51c5dd4ae85493e67ce894d6@HIDDEN> Date: Wed, 19 Feb 2025 09:42:06 +0200 Message-ID: <87o6yys7n5.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdeifeeijecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefujghofhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecuggftrfgrthhtvghrnhepffegteefveelhfeljeefueehieduiedtfffhuddtkeeffffghfevheetgeeukeehnecukfhppeeluddruddvledrleekrdehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrdelkedrhedphhgvlhhopehmrghilhdrghgrnhguihdrnhgvthdpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnsggprhgtphhtthhopeefpdhrtghpthhtoheptghonhhtrhholhesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopeejieegtdekseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepjhgrrhgvugesfhhinhguvghrrdhorhhg X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76408 Cc: 76408 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) close 76408 31.0.50 thanks > read-key only reports the symbol tab-line for clicks in the tab-line, > instead of the mouse event. > > To reproduce: > > emacs -q -nw > M-x xterm-mouse-mode > Show the tab-line, either global-tab-line-mode or > global-window-tool-bar-mode > Then just eval (read-key) > > Clicks in the mode-line or header-line return the underlying mouse > event, but clicks in tab-line-only return the symbol tab-line. > > I believe the following change to read-key fixes this: > > @@ -3074,7 +3074,7 @@ read-key > - (memq key '(mode-line header-line > + (memq key '(mode-line header-line tab-line Thanks for the fix. Pushed to master (I guess it's too late for release?)
bug-gnu-emacs@HIDDEN:bug#76408; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 18 Feb 2025 22:35:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 18 17:35:37 2025
Received: from localhost ([127.0.0.1]:35383 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tkWBl-0000R4-1a
for submit <at> debbugs.gnu.org; Tue, 18 Feb 2025 17:35:37 -0500
Received: from lists.gnu.org ([2001:470:142::17]:44582)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <jared@HIDDEN>) id 1tkWBh-0000Q8-EW
for submit <at> debbugs.gnu.org; Tue, 18 Feb 2025 17:35:34 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <jared@HIDDEN>) id 1tkWBZ-0006ZP-Ps
for bug-gnu-emacs@HIDDEN; Tue, 18 Feb 2025 17:35:25 -0500
Received: from greenhill.hpalace.com ([192.155.80.58])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <jared@HIDDEN>) id 1tkWBW-00036f-1F
for bug-gnu-emacs@HIDDEN; Tue, 18 Feb 2025 17:35:24 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=finder.org; s=2018;
t=1739918113; bh=Inup0ms7R7vI9rPYLM2EDGb/PeaCn6z9Lr/Ud97aDPA=;
h=Date:From:To:Subject:From;
b=ayxsJY+3ZTdE/XiHA96vzee69s65bwYL+66dhOLvBarr7hk/s3j7JqZp9IkKSaNvW
Ira8VSE6G8yuvoUZeTrQ8f2lhdJ1Sdt5UGfCYLLS0rRJCS8eRlJJ+5/nXP3rCIlfgC
QiHKkudrEoD82qgb8z5lzoEj6rPeeMlUf3xp7UIbhtookgoUDjWWzVht6/A/dFRpko
oxYPj6vWK3k5nSIldz+HU9VkchjBGKnqTBv+lHq2qG9YFCychErNEsiYhjWmTmlzT3
ibxT7FtghpUlQTPS9q6Fh/kn5ZBzP2XgPnBnPKCZOBRbq7tqCZ1MKCTwpdMJFiA36d
jjTFsh9J/dQnQ==
Received: from mail.finder.org (unknown [192.155.80.58])
by greenhill.hpalace.com (Postfix) with ESMTPSA id 3857113AF
for <bug-gnu-emacs@HIDDEN>; Tue, 18 Feb 2025 22:35:13 +0000 (UTC)
MIME-Version: 1.0
Date: Tue, 18 Feb 2025 17:35:13 -0500
From: Jared Finder <jared@HIDDEN>
To: Bug-gnu Emacs <bug-gnu-emacs@HIDDEN>
Subject: 29.4; read-key always returns only tab-line for click in tab-line
Message-ID: <3df498ad51c5dd4ae85493e67ce894d6@HIDDEN>
X-Sender: jared@HIDDEN
Content-Type: text/plain; charset=US-ASCII;
format=flowed
Content-Transfer-Encoding: 7bit
Received-SPF: pass client-ip=192.155.80.58; envelope-from=jared@HIDDEN;
helo=greenhill.hpalace.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)
read-key only reports the symbol tab-line for clicks in the tab-line,
instead of the mouse event.
To reproduce:
emacs -q -nw
M-x xterm-mouse-mode
Show the tab-line, either global-tab-line-mode or
global-window-tool-bar-mode
Then just eval (read-key)
Clicks in the mode-line or header-line return the underlying mouse
event, but clicks in tab-line-only return the symbol tab-line.
I believe the following change to read-key fixes this:
@@ -3074,7 +3074,7 @@
(catch 'read-key (read-key-sequence-vector prompt nil
t)))
(key (aref keys 0)))
(if (and (> (length keys) 1)
- (memq key '(mode-line header-line
+ (memq key '(mode-line header-line tab-line
left-fringe right-fringe)))
(aref keys 1)
key)))
-- MJF
Jared Finder <jared@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#76408; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.