GNU bug report logs - #76419
[PATCH] * gnu/packages/games.scm (moonlight-qt): Modify inputs.

Previous Next

Package: guix-patches;

Reported by: Vitor Hugo <vitorhugonunes <at> proton.me>

Date: Wed, 19 Feb 2025 18:18:02 UTC

Severity: normal

Tags: patch

Done: Andreas Enge <andreas <at> enge.fr>

To reply to this bug, email your comments to 76419 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#76419; Package guix-patches. (Wed, 19 Feb 2025 18:18:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Vitor Hugo <vitorhugonunes <at> proton.me>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 19 Feb 2025 18:18:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vitor Hugo <vitorhugonunes <at> proton.me>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] * gnu/packages/games.scm (moonlight-qt): Modify inputs.
Date: Wed, 19 Feb 2025 18:17:05 +0000
The package was missing `wayland` as an input, which broke hardware
acceleration whenever running under wayland. This fixes it.

Change-Id: I65b16f5e2e77627f79f45a63461436be51e0fa96
---
 gnu/packages/games.scm | 44 +++++++++++++++++++++++++-----------------
 1 file changed, 26 insertions(+), 18 deletions(-)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 30aaf0767a..10fe0f6dac 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -6566,15 +6566,15 @@ (define-public moonlight-qt
   (package
     (name "moonlight-qt")
     (version "6.1.0")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://github.com/moonlight-stream/moonlight-qt")
-                    (commit (string-append "v" version))))
-              (file-name (git-file-name name version))
-              (sha256
-               (base32
-                "06fxf3m26k036asxjkkykk5q96nincwmpiqm953m7zgr9224gidx"))))
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/moonlight-stream/moonlight-qt")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "06fxf3m26k036asxjkkykk5q96nincwmpiqm953m7zgr9224gidx"))))
     (build-system qt-build-system)
     (arguments
      (list
@@ -6583,18 +6583,25 @@ (define-public moonlight-qt
       #~(modify-phases %standard-phases
           (replace 'configure
             (lambda* _
-              (symlink (string-append
-                        #$(this-package-input "sdl2-gamecontrollerdb")
-                        "/share/sdl2/gamecontrollerdb.txt")
+              (symlink (string-append #$(this-package-input
+                                         "sdl2-gamecontrollerdb")
+                                      "/share/sdl2/gamecontrollerdb.txt")
                        "app/SDL_GameControllerDB/gamecontrollerdb.txt")
               ;; Unbundle libraries.
               (substitute* "moonlight-qt.pro"
-                (("    moonlight-common-c.*\n") "")
-                (("    qmdnsengine.*\n") "")
-                (("    h264bitstream.*\n") "")
-                (("    app \\\\") "    app")
-                (("app.depends") "INCLUDEPATH +="))
-              (invoke "qmake" (string-append "PREFIX=" #$output)))))))
+                (("    moonlight-common-c.*\n")
+                 "")
+                (("    qmdnsengine.*\n")
+                 "")
+                (("    h264bitstream.*\n")
+                 "")
+                (("    app \\\\")
+                 "    app")
+                (("app.depends")
+                 "INCLUDEPATH +="))
+              (invoke "qmake"
+                      (string-append "PREFIX="
+                                     #$output)))))))
     (native-inputs (list pkg-config qttools-5))
     (inputs (list ffmpeg
                   h264bitstream
@@ -6609,6 +6616,7 @@ (define-public moonlight-qt
                   qtquickcontrols2-5
                   qtsvg-5
                   qtwayland-5
+                  wayland
                   sdl2
                   sdl2-ttf
                   sdl2-gamecontrollerdb))
-- 
2.46.0






Information forwarded to guix-patches <at> gnu.org:
bug#76419; Package guix-patches. (Sun, 13 Apr 2025 22:04:01 GMT) Full text and rfc822 format available.

Message #8 received at 76419 <at> debbugs.gnu.org (full text, mbox):

From: Vitor Hugo <vitorhugonunes <at> proton.me>
To: "76419 <at> debbugs.gnu.org" <76419 <at> debbugs.gnu.org>
Subject: [PATCH] * gnu/packages/games.scm (moonlight-qt): Modify inputs.
Date: Sun, 13 Apr 2025 22:03:23 +0000
Below follows a better formatted patch, as per suggestions
in IRC.


* gnu/packages/games.scm (moonlight-qt): Modify inputs.

Change-Id: I0a24f8c1011360681afe6c2f8200787aec4868ef
---
 gnu/packages/games.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 59145a46c5..07f199966a 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -6825,6 +6825,7 @@ (define-public moonlight-qt
                   qtquickcontrols2-5
                   qtsvg-5
                   qtwayland-5
+                  wayland
                   sdl2
                   sdl2-ttf
                   sdl2-gamecontrollerdb))

base-commit: 7f0ec135d1bf6fd8b7bff84bc176b6c61fdee75d
-- 
2.49.0





Reply sent to Andreas Enge <andreas <at> enge.fr>:
You have taken responsibility. (Mon, 14 Apr 2025 12:57:03 GMT) Full text and rfc822 format available.

Notification sent to Vitor Hugo <vitorhugonunes <at> proton.me>:
bug acknowledged by developer. (Mon, 14 Apr 2025 12:57:03 GMT) Full text and rfc822 format available.

Message #13 received at 76419-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Vitor Hugo <vitorhugonunes <at> proton.me>
Cc: "76419 <at> debbugs.gnu.org" <76419-done <at> debbugs.gnu.org>
Subject: Re: [PATCH] * gnu/packages/games.scm (moonlight-qt): Modify inputs.
Date: Mon, 14 Apr 2025 14:56:40 +0200
Am Sun, Apr 13, 2025 at 10:03:23PM +0000 schrieb Vitor Hugo:
> Below follows a better formatted patch, as per suggestions
> in IRC.

Yes, not reformatting the package makes it easier to see what actually
changed. I have slightly modified the commit message and pushed, thanks!

Andreas





This bug report was last modified 14 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.