GNU logs - #76443, boring messages

Message sent to rahul.juliato@HIDDEN, casouri@HIDDEN, bug-gnu-emacs@HIDDEN:

Subject: bug#76443: Imenu in markdown-ts-mode
Resent-From: Juri Linkov <juri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: rahul.juliato@HIDDEN, casouri@HIDDEN, bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 20 Feb 2025 18:03:01 +0000
Resent-Message-ID: <handler.76443.B.1740074523697 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 76443 <at> debbugs.gnu.org
Cc: Rahul Martim Juliato <rahul.juliato@HIDDEN>,  Yuan Fu <casouri@HIDDEN>
From: Juri Linkov <juri@HIDDEN>
Organization: LINKOV.NET
Date: Thu, 20 Feb 2025 19:59:38 +0200
Message-ID: <87seo8wl85.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=217.70.183.200; envelope-from=juri@HIDDEN;
 helo=relay7-d.mail.gandi.net
X-Spam_score_int: -25
X-Spam_score: -2.6
X-Spam_bar: --
X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7,
 RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

markdown-ts-mode uses the function as the second element of
treesit-simple-imenu-settings:

  (setq-local treesit-simple-imenu-settings
              `(("Headings" markdown-ts-imenu-node-p nil markdown-ts-imenu-name-function)))

This breaks treesit-outline-predicate--from-imenu since it expects only a string.

So I tried to fix this with the patch below.  But then noticed that the
REGEXP element of treesit-simple-imenu-settings is documented only as
a string:

  REGEXP should be a regexp matching the type of nodes that
  belong to CATEGORY.

So there is two possible variants:

1. Support a function by applying this patch and changing the
documentation of treesit-simple-imenu-settings;
2. Maybe markdown-ts-mode doesn't need to use a function
and it should be sufficient to use just "section" as string.
Then markdown-ts-imenu-name-function can extract "atx_heading" from it.

diff --git a/lisp/treesit.el b/lisp/treesit.el
index 30efd4d4599..6eaa7a761e3 100644
--- a/lisp/treesit.el
+++ b/lisp/treesit.el
@@ -3611,7 +3611,10 @@ treesit-outline-predicate--from-imenu
   ;; you can directly set a proper value to `treesit-outline-predicate'.
   (seq-some
    (lambda (setting)
-     (and (string-match-p (nth 1 setting) (treesit-node-type node))
+     (and (or (and (stringp (nth 1 setting))
+                   (string-match-p (nth 1 setting) (treesit-node-type node)))
+              (and (functionp (nth 1 setting))
+                   (funcall (nth 1 setting) node)))
           (or (null (nth 2 setting))
               (funcall (nth 2 setting) node))))
    treesit-simple-imenu-settings))

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Juri Linkov <juri@HIDDEN>
Subject: bug#76443: Acknowledgement (Imenu in markdown-ts-mode)
Message-ID: <handler.76443.B.1740074523697.ack <at> debbugs.gnu.org>
References: <87seo8wl85.fsf@HIDDEN>
X-Gnu-PR-Message: ack 76443
X-Gnu-PR-Package: emacs
Reply-To: 76443 <at> debbugs.gnu.org
Date: Thu, 20 Feb 2025 18:03:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  Rahul Martim Juliato <rahul.juliato@HIDDEN>,  Yuan Fu <casouri@HIDDEN=
om>
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 76443 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
76443: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D76443
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#76443: Imenu in markdown-ts-mode
Resent-From: Yuan Fu <casouri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 21 Feb 2025 05:55:02 +0000
Resent-Message-ID: <handler.76443.B76443.174011726312945 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Juri Linkov <juri@HIDDEN>
Cc: Rahul Martim Juliato <rahul.juliato@HIDDEN>, 76443 <at> debbugs.gnu.org
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\))
From: Yuan Fu <casouri@HIDDEN>
In-Reply-To: <87seo8wl85.fsf@HIDDEN>
Date: Thu, 20 Feb 2025 21:54:01 -0800
Content-Transfer-Encoding: quoted-printable
Message-Id: <B6A67F74-5D29-434C-B830-D506FA9A98B5@HIDDEN>
References: <87seo8wl85.fsf@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>



> On Feb 20, 2025, at 9:59=E2=80=AFAM, Juri Linkov <juri@HIDDEN> =
wrote:
>=20
> markdown-ts-mode uses the function as the second element of
> treesit-simple-imenu-settings:
>=20
>  (setq-local treesit-simple-imenu-settings
>              `(("Headings" markdown-ts-imenu-node-p nil =
markdown-ts-imenu-name-function)))
>=20
> This breaks treesit-outline-predicate--from-imenu since it expects =
only a string.
>=20
> So I tried to fix this with the patch below.  But then noticed that =
the
> REGEXP element of treesit-simple-imenu-settings is documented only as
> a string:
>=20
>  REGEXP should be a regexp matching the type of nodes that
>  belong to CATEGORY.
>=20
> So there is two possible variants:
>=20
> 1. Support a function by applying this patch and changing the
> documentation of treesit-simple-imenu-settings;
> 2. Maybe markdown-ts-mode doesn't need to use a function
> and it should be sufficient to use just "section" as string.
> Then markdown-ts-imenu-name-function can extract "atx_heading" from =
it.
>=20
> diff --git a/lisp/treesit.el b/lisp/treesit.el
> index 30efd4d4599..6eaa7a761e3 100644
> --- a/lisp/treesit.el
> +++ b/lisp/treesit.el
> @@ -3611,7 +3611,10 @@ treesit-outline-predicate--from-imenu
>   ;; you can directly set a proper value to =
`treesit-outline-predicate'.
>   (seq-some
>    (lambda (setting)
> -     (and (string-match-p (nth 1 setting) (treesit-node-type node))
> +     (and (or (and (stringp (nth 1 setting))
> +                   (string-match-p (nth 1 setting) (treesit-node-type =
node)))
> +              (and (functionp (nth 1 setting))
> +                   (funcall (nth 1 setting) node)))
>           (or (null (nth 2 setting))
>               (funcall (nth 2 setting) node))))
>    treesit-simple-imenu-settings))

Thanks Juri. FWIW, if we can accomplish it with regex only, then let=E2=80=
=99s keep it simple and use regex. markdown-ts-imenu-node-p just =
compares the node type to a string, it doesn=E2=80=99t even need a =
regex.

Yuan=

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 22 Feb 2025 23:58:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 22 18:58:55 2025
Received: from localhost ([127.0.0.1]:57827 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tlzOZ-0005Nr-6D
	for submit <at> debbugs.gnu.org; Sat, 22 Feb 2025 18:58:55 -0500
Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:51276)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1tlzOW-0005NN-L7
 for control <at> debbugs.gnu.org; Sat, 22 Feb 2025 18:58:53 -0500
Received: by mail-ed1-x535.google.com with SMTP id
 4fb4d7f45d1cf-5e05780509dso4725304a12.2
 for <control <at> debbugs.gnu.org>; Sat, 22 Feb 2025 15:58:52 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1740268726; x=1740873526; darn=debbugs.gnu.org;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=sWgcSTc2GiWvgLV2UZwyogluUKyQOobaqAF2YCcUZ9U=;
 b=GsExMmDSgyYp9Tvr7J48Qpm2lNbgYVAb3RyihKbayX9RBp3IyyBB9sqFL1S2AlV/SB
 HoSXbqpRNSeOuL7N2/KKr/B1s3eXY8FhLEZvyHFV+OVz1VSCAXDuR1rlciC9nBRDmbN4
 Oy2sp4opt0Rplp4/4ewmuxt2hn92hb0xU8HKIZHRJPo9N1jzeSKYDNPtctVcBtJGR48u
 Ggy9szHYFf3oOTDOWVUT97DTqbnjCeIDYxos8eZunc26iX06KPRndNRvOCtay/JOfiuJ
 HLm1zoSjah9re8MgnK6qWh7Y5c8Fu8RVcN8a7O0aAtLMoUqf2TvVI760TRQoc8U2qY7e
 oTig==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1740268726; x=1740873526;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=sWgcSTc2GiWvgLV2UZwyogluUKyQOobaqAF2YCcUZ9U=;
 b=Quj1hghcwFdRhMBNptHrrnLHHiXm2o1p537oXJNKSG1ukKbGQZ+iBNzgzt6/6Klz5b
 pHKsh7vGeADyNuChmypQDAvUYoaVC16N88o0xsjLDewIGyrTFZWWo9sW2cIG/q+61bIz
 mLYIi/tNhDB1vVI+kOZQcH4i5Qw81AJnq6rLrsidu/QejYSWQ0PUq1cHb4nZn6yuyyem
 ilfyPmCaAj5n6X5bRG2dk4XBl0MBIEW/lgQZ1/fOyaluv/GNfNZwLTmlZh8ZVhOFe2EB
 MmlN0zwOvjOV4sRycf3Zj8KChmHE3d0+T/CuHrImz3Sk8vJBrpw/gKuBSOqbEfykEz6j
 ccKA==
X-Gm-Message-State: AOJu0Yx79zWfn/VVRvD7yqkfDlb9l29HhJZz3QCyiPp7HNwVH00/dS5g
 Fwh2EbOdsqXH6lWEp+v6ulNwTbbmJrS1dWMCanqJM27QoOVdvPNu7E0cEnvqBH32f6D5pe2r55a
 9vQk+eEU1Etsj8pzGWUWwZ6xp97sgefvcbCc=
X-Gm-Gg: ASbGncsmcnh15BntckJ1Ag5qcvrsKwVkv+9OHX04ibjBBw//upqdD+Jllzw5C+fYef4
 RasE/b+uRmWNRYpFAGsIX/+qEUzr8CJl/h89UbhzQyWWdkwzrjH4fQp3okXtPre+z6/tzsGEk4q
 DjZGQseK/o
X-Google-Smtp-Source: AGHT+IGgwPXgyxO2a6TjLHOKF8r/Xz8Flp7FScuYtliE6DJEOyP1tnf83wPfSdw2E6n18kH7PqOW6//N5C7avatwGpU=
X-Received: by 2002:a05:6402:5309:b0:5e0:8c55:531 with SMTP id
 4fb4d7f45d1cf-5e0b70fa43emr6064871a12.14.1740268726490; Sat, 22 Feb 2025
 15:58:46 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sat, 22 Feb 2025 23:58:46 +0000
From: Stefan Kangas <stefankangas@HIDDEN>
MIME-Version: 1.0
Date: Sat, 22 Feb 2025 23:58:46 +0000
X-Gm-Features: AWEUYZm3ZqaAxz4nUiZs_fzGxyeQwn1jDTgwTO19R2UVNmwMapBeiOVeEQmHxrc
Message-ID: <CADwFkmkC5oah3=zsuuWQcWJutd-wHGYHeRuDknMKfA7VhbWFRg@HIDDEN>
Subject: control message for bug #76443
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

severity 76443 wishlist
quit

Last modified: Sun, 23 Feb 2025 00:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.